Re: [PATCH v6 08/11] i2c: designware: Convert driver to using regmap API

2020-05-31 Thread Serge Semin
On Sat, May 30, 2020 at 11:05:54PM +0200, Wolfram Sang wrote: > On Sat, May 30, 2020 at 01:09:30PM +0200, Wolfram Sang wrote: > > On Thu, May 28, 2020 at 12:33:18PM +0300, Serge Semin wrote: > > > Seeing the DW I2C driver is using flags-based accessors with two > > > conditional clauses it would

Re: [PATCH v6 08/11] i2c: designware: Convert driver to using regmap API

2020-05-30 Thread Wolfram Sang
On Sat, May 30, 2020 at 01:09:30PM +0200, Wolfram Sang wrote: > On Thu, May 28, 2020 at 12:33:18PM +0300, Serge Semin wrote: > > Seeing the DW I2C driver is using flags-based accessors with two > > conditional clauses it would be better to replace them with the regmap > > API IO methods and to

Re: [PATCH v6 08/11] i2c: designware: Convert driver to using regmap API

2020-05-30 Thread Wolfram Sang
On Thu, May 28, 2020 at 12:33:18PM +0300, Serge Semin wrote: > Seeing the DW I2C driver is using flags-based accessors with two > conditional clauses it would be better to replace them with the regmap > API IO methods and to initialize the regmap object with read/write > callbacks specific to the

Re: [PATCH v6 08/11] i2c: designware: Convert driver to using regmap API

2020-05-28 Thread Andy Shevchenko
On Thu, May 28, 2020 at 12:33:18PM +0300, Serge Semin wrote: > Seeing the DW I2C driver is using flags-based accessors with two > conditional clauses it would be better to replace them with the regmap > API IO methods and to initialize the regmap object with read/write > callbacks specific to the

[PATCH v6 08/11] i2c: designware: Convert driver to using regmap API

2020-05-28 Thread Serge Semin
Seeing the DW I2C driver is using flags-based accessors with two conditional clauses it would be better to replace them with the regmap API IO methods and to initialize the regmap object with read/write callbacks specific to the controller registers map implementation. This will be also handy for