Re: [PATCH v6 1/7] ASoC: sun4i-i2s: Move channel select offset

2019-10-16 Thread Maxime Ripard
On Wed, Oct 16, 2019 at 10:41:31AM +0200, Code Kipper wrote: > On Wed, 16 Oct 2019 at 10:04, Maxime Ripard wrote: > > > > On Wed, Oct 16, 2019 at 09:07:34AM +0200, codekip...@gmail.com wrote: > > > From: Marcus Cooper > > > > > > On the newer SoCs the offset is used to set the mode of the > > >

Re: [PATCH v6 1/7] ASoC: sun4i-i2s: Move channel select offset

2019-10-16 Thread Code Kipper
On Wed, 16 Oct 2019 at 10:04, Maxime Ripard wrote: > > On Wed, Oct 16, 2019 at 09:07:34AM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > On the newer SoCs the offset is used to set the mode of the > > connection. As it is to be used elsewhere then it makes sense > > to move

Re: [PATCH v6 1/7] ASoC: sun4i-i2s: Move channel select offset

2019-10-16 Thread Maxime Ripard
On Wed, Oct 16, 2019 at 09:07:34AM +0200, codekip...@gmail.com wrote: > From: Marcus Cooper > > On the newer SoCs the offset is used to set the mode of the > connection. As it is to be used elsewhere then it makes sense > to move it to the main structure. Elsewhere where, and to do what? Maxime

[PATCH v6 1/7] ASoC: sun4i-i2s: Move channel select offset

2019-10-16 Thread codekipper
From: Marcus Cooper On the newer SoCs the offset is used to set the mode of the connection. As it is to be used elsewhere then it makes sense to move it to the main structure. Signed-off-by: Marcus Cooper --- sound/soc/sunxi/sun4i-i2s.c | 22 +++--- 1 file changed, 11