Re: [PATCH v7 09/18] pstore/blk: Introduce backend for block devices

2020-05-11 Thread Kees Cook
On Mon, May 11, 2020 at 08:36:49AM -0700, Randy Dunlap wrote: > On 5/10/20 1:24 PM, Kees Cook wrote: > > diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig > > index 98d2457bdd9f..92ba73bd0b62 100644 > > --- a/fs/pstore/Kconfig > > +++ b/fs/pstore/Kconfig > > @@ -160,3 +160,67 @@ config

Re: [PATCH v7 09/18] pstore/blk: Introduce backend for block devices

2020-05-11 Thread Kees Cook
On Mon, May 11, 2020 at 04:36:51PM +0800, WeiXiong Liao wrote: > On 2020/5/11 AM 4:24, Kees Cook wrote: > > [...] > > +static struct block_device *psblk_get_bdev(void *holder, > > + struct bdev_info *info) > > Well. That's pretty a good idea to get information

Re: [PATCH v7 09/18] pstore/blk: Introduce backend for block devices

2020-05-11 Thread Randy Dunlap
On 5/10/20 1:24 PM, Kees Cook wrote: > diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig > index 98d2457bdd9f..92ba73bd0b62 100644 > --- a/fs/pstore/Kconfig > +++ b/fs/pstore/Kconfig > @@ -160,3 +160,67 @@ config PSTORE_ZONE > help > The common layer for pstore/blk (and pstore/ram

Re: [PATCH v7 09/18] pstore/blk: Introduce backend for block devices

2020-05-11 Thread WeiXiong Liao
hi Kees Cook, On 2020/5/11 AM 4:24, Kees Cook wrote: > From: WeiXiong Liao > > pstore/blk is similar to pstore/ram, but uses a block device as the > storage rather than persistent ram. > > The pstore/blk backend solves two common use-cases that used to preclude > using pstore/ram: > - not all

[PATCH v7 09/18] pstore/blk: Introduce backend for block devices

2020-05-10 Thread Kees Cook
From: WeiXiong Liao pstore/blk is similar to pstore/ram, but uses a block device as the storage rather than persistent ram. The pstore/blk backend solves two common use-cases that used to preclude using pstore/ram: - not all devices have a battery that could be used to persist regular RAM