On Mon, May 11, 2020 at 08:36:49AM -0700, Randy Dunlap wrote: > On 5/10/20 1:24 PM, Kees Cook wrote: > > diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig > > index 98d2457bdd9f..92ba73bd0b62 100644 > > --- a/fs/pstore/Kconfig > > +++ b/fs/pstore/Kconfig > > @@ -160,3 +160,67 @@ config PSTORE_ZONE > > help > > The common layer for pstore/blk (and pstore/ram in the future) > > to manage storage in zones. > > + > > +config PSTORE_BLK > > + tristate "Log panic/oops to a block device" > > + depends on PSTORE > > + depends on BLOCK > > + select PSTORE_ZONE > > + default n > > + help > > + This enables panic and oops message to be logged to a block dev > > + where it can be read back at some later point. > > + > > + If unsure, say N. > > + > > +config PSTORE_BLK_BLKDEV > > + string "block device identifier" > > + depends on PSTORE_BLK > > + default "" > > + help > > + Which block device should be used for pstore/blk. > > + > > + It accept the following variants: > > + 1) <hex_major><hex_minor> device number in hexadecimal represents > > + itself no leading 0x, for example b302. > > itself with no leading 0x,
Yes, I've reworked the language here. Thanks! -- Kees Cook
