On Wed, Apr 06, 2016 at 07:36:49PM -0500, Thor Thayer wrote:
> Yes, nothing else changes. The rest was OK. Thanks!
Cool. The two remaining applied and pushed out.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
On Wed, Apr 06, 2016 at 07:36:49PM -0500, Thor Thayer wrote:
> Yes, nothing else changes. The rest was OK. Thanks!
Cool. The two remaining applied and pushed out.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
Hi Boris,
On 04/05/2016 12:31 AM, Borislav Petkov wrote:
On Tue, Apr 05, 2016 at 12:25:33AM -0500, Thor Thayer wrote:
I realize that I'm not calling iounmap(ecc_block_base) and I'll fix that in
the next revision with a goto.
I'm assuming nothing else changes. Because I've applied 1-4
Hi Boris,
On 04/05/2016 12:31 AM, Borislav Petkov wrote:
On Tue, Apr 05, 2016 at 12:25:33AM -0500, Thor Thayer wrote:
I realize that I'm not calling iounmap(ecc_block_base) and I'll fix that in
the next revision with a goto.
I'm assuming nothing else changes. Because I've applied 1-4
On Tue, Apr 05, 2016 at 01:37:49PM -0500, Dinh Nguyen wrote:
> My only suggestion was to change the 3 helper functions(ecc_set_bits,
> ecc_clear_bits, and ecc_test_bits) should be static inline.
That doesn't take care of the iounmap error path Thor is talking about,
AFAICT.
So, I've pushed out
On Tue, Apr 05, 2016 at 01:37:49PM -0500, Dinh Nguyen wrote:
> My only suggestion was to change the 3 helper functions(ecc_set_bits,
> ecc_clear_bits, and ecc_test_bits) should be static inline.
That doesn't take care of the iounmap error path Thor is talking about,
AFAICT.
So, I've pushed out
On Tue, 5 Apr 2016, Borislav Petkov wrote:
> On Tue, Apr 05, 2016 at 12:25:33AM -0500, Thor Thayer wrote:
> > I realize that I'm not calling iounmap(ecc_block_base) and I'll fix that in
> > the next revision with a goto.
>
> I'm assuming nothing else changes. Because I've applied 1-4 already.
>
On Tue, 5 Apr 2016, Borislav Petkov wrote:
> On Tue, Apr 05, 2016 at 12:25:33AM -0500, Thor Thayer wrote:
> > I realize that I'm not calling iounmap(ecc_block_base) and I'll fix that in
> > the next revision with a goto.
>
> I'm assuming nothing else changes. Because I've applied 1-4 already.
>
On Tue, Apr 05, 2016 at 12:25:33AM -0500, Thor Thayer wrote:
> I realize that I'm not calling iounmap(ecc_block_base) and I'll fix that in
> the next revision with a goto.
I'm assuming nothing else changes. Because I've applied 1-4 already.
Yes, no?
If no, then please send only an updated
On Tue, Apr 05, 2016 at 12:25:33AM -0500, Thor Thayer wrote:
> I realize that I'm not calling iounmap(ecc_block_base) and I'll fix that in
> the next revision with a goto.
I'm assuming nothing else changes. Because I've applied 1-4 already.
Yes, no?
If no, then please send only an updated
Hi,
On 03/31/2016 01:48 PM, ttha...@opensource.altera.com wrote:
From: Thor Thayer
Enable ECC for Arria10 On-Chip RAM on machine startup. The ECC has to
be enabled and memory initialized before data is stored in memory
otherwise the ECC will fail on reads.
Hi,
On 03/31/2016 01:48 PM, ttha...@opensource.altera.com wrote:
From: Thor Thayer
Enable ECC for Arria10 On-Chip RAM on machine startup. The ECC has to
be enabled and memory initialized before data is stored in memory
otherwise the ECC will fail on reads.
Signed-off-by: Thor Thayer
---
v2:
From: Thor Thayer
Enable ECC for Arria10 On-Chip RAM on machine startup. The ECC has to
be enabled and memory initialized before data is stored in memory
otherwise the ECC will fail on reads.
Signed-off-by: Thor Thayer
---
v2: Add
From: Thor Thayer
Enable ECC for Arria10 On-Chip RAM on machine startup. The ECC has to
be enabled and memory initialized before data is stored in memory
otherwise the ECC will fail on reads.
Signed-off-by: Thor Thayer
---
v2: Add Arria10 ECC block initialization locally.
---
14 matches
Mail list logo