Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-02-08 Thread Dan Murphy
Veas On 2/7/19 11:09 PM, Vesa Jääskeläinen wrote: > Hi All, > > On 08/02/2019 6.55, Vesa Jääskeläinen wrote: >> Hi All, >> >> On 31/01/2019 0.35, Pavel Machek wrote: >>> On Wed 2019-01-30 12:30:05, Dan Murphy wrote: Add a documentation of LED Multicolor LED class specific sysfs

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-02-07 Thread Vesa Jääskeläinen
Hi All, On 08/02/2019 6.55, Vesa Jääskeläinen wrote: Hi All, On 31/01/2019 0.35, Pavel Machek wrote: On Wed 2019-01-30 12:30:05, Dan Murphy wrote: Add a documentation of LED Multicolor LED class specific sysfs attributes. No, sorry. This does not most of the requirements.  

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-02-07 Thread Vesa Jääskeläinen
Hi All, On 31/01/2019 0.35, Pavel Machek wrote: On Wed 2019-01-30 12:30:05, Dan Murphy wrote: Add a documentation of LED Multicolor LED class specific sysfs attributes. No, sorry. This does not most of the requirements. Pavel

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-01-31 Thread Jacek Anaszewski
Hi Dan, On 1/31/19 2:48 PM, Dan Murphy wrote: Jacek On 1/30/19 4:14 PM, Jacek Anaszewski wrote: Dan, On 1/30/19 10:07 PM, Dan Murphy wrote: Jacek On 1/30/19 2:20 PM, Jacek Anaszewski wrote: Dan, On 1/30/19 8:59 PM, Dan Murphy wrote: Jacek On 1/30/19 1:37 PM, Jacek Anaszewski wrote: Hi

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-01-31 Thread Dan Murphy
Jacek On 1/30/19 4:14 PM, Jacek Anaszewski wrote: > Dan, > > On 1/30/19 10:07 PM, Dan Murphy wrote: >> Jacek >> >> On 1/30/19 2:20 PM, Jacek Anaszewski wrote: >>> Dan, >>> >>> On 1/30/19 8:59 PM, Dan Murphy wrote: Jacek On 1/30/19 1:37 PM, Jacek Anaszewski wrote: > Hi Dan,

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-01-30 Thread Pavel Machek
On Wed 2019-01-30 12:30:05, Dan Murphy wrote: > Add a documentation of LED Multicolor LED class specific > sysfs attributes. No, sorry. This does not most of the requirements. Pavel Requirements for RGB LED interface: 1) Userspace

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-01-30 Thread Jacek Anaszewski
Dan, On 1/30/19 10:07 PM, Dan Murphy wrote: Jacek On 1/30/19 2:20 PM, Jacek Anaszewski wrote: Dan, On 1/30/19 8:59 PM, Dan Murphy wrote: Jacek On 1/30/19 1:37 PM, Jacek Anaszewski wrote: Hi Dan, Thank you for the RFC. One vital thing is missing - documentation of brightness file must be

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-01-30 Thread Dan Murphy
Jacek On 1/30/19 2:20 PM, Jacek Anaszewski wrote: > Dan, > > On 1/30/19 8:59 PM, Dan Murphy wrote: >> Jacek >> >> On 1/30/19 1:37 PM, Jacek Anaszewski wrote: >>> Hi Dan, >>> >>> Thank you for the RFC. >>> >>> One vital thing is missing - documentation of brightness file must >>> be updated to

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-01-30 Thread Jacek Anaszewski
Dan, On 1/30/19 8:59 PM, Dan Murphy wrote: Jacek On 1/30/19 1:37 PM, Jacek Anaszewski wrote: Hi Dan, Thank you for the RFC. One vital thing is missing - documentation of brightness file must be updated to define its semantics for LED multi color class. Either we need brightness-model file

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-01-30 Thread Dan Murphy
Jacek On 1/30/19 1:37 PM, Jacek Anaszewski wrote: > Hi Dan, > > Thank you for the RFC. > > One vital thing is missing - documentation of brightness file must > be updated to define its semantics for LED multi color class. > > Either we need brightness-model file returning only "onoff" option >

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-01-30 Thread Jacek Anaszewski
Hi Dan, Thank you for the RFC. One vital thing is missing - documentation of brightness file must be updated to define its semantics for LED multi color class. Either we need brightness-model file returning only "onoff" option available, or, for time being, fix the max_brightness for LED multi

[RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-01-30 Thread Dan Murphy
Add a documentation of LED Multicolor LED class specific sysfs attributes. Signed-off-by: Dan Murphy --- .../ABI/testing/sysfs-class-led-multicolor| 38 +++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor diff --git