RE: [RFC PATCH 1/1] platform-msi: Add platform check for subdevice irq domain

2021-01-06 Thread Tian, Kevin
> From: David Woodhouse > Sent: Thursday, December 10, 2020 4:23 PM > > On Thu, 2020-12-10 at 08:46 +0800, Lu Baolu wrote: > > +/* > > + * We want to figure out which context we are running in. But the > hardware > > + * does not introduce a reliable way (instruction, CPUID leaf, MSR, > whatever)

Re: [RFC PATCH 1/1] platform-msi: Add platform check for subdevice irq domain

2020-12-15 Thread Lu Baolu
Hi Bjorn, On 12/11/20 2:57 AM, Bjorn Helgaas wrote: On Thu, Dec 10, 2020 at 08:46:24AM +0800, Lu Baolu wrote: The pci_subdevice_msi_create_irq_domain() should fail if the underlying platform is not able to support IMS (Interrupt Message Storage). Otherwise, the isolation of interrupt is not gua

Re: [RFC PATCH 1/1] platform-msi: Add platform check for subdevice irq domain

2020-12-15 Thread Lu Baolu
Hi David, On 12/10/20 4:22 PM, David Woodhouse wrote: On Thu, 2020-12-10 at 08:46 +0800, Lu Baolu wrote: +/* + * We want to figure out which context we are running in. But the hardware + * does not introduce a reliable way (instruction, CPUID leaf, MSR, whatever) + * which can be manipulated by

Re: [RFC PATCH 1/1] platform-msi: Add platform check for subdevice irq domain

2020-12-10 Thread David Woodhouse
On Thu, 2020-12-10 at 12:57 -0600, Bjorn Helgaas wrote: > What is the point of a function called probably_on_bare_metal()? > *Probably*? The caller can't really do anything with the fact that > we're not 100% sure this gives the correct answer. Just call it > "on_bare_metal()" or something and ac

Re: [RFC PATCH 1/1] platform-msi: Add platform check for subdevice irq domain

2020-12-10 Thread Bjorn Helgaas
On Thu, Dec 10, 2020 at 08:46:24AM +0800, Lu Baolu wrote: > The pci_subdevice_msi_create_irq_domain() should fail if the underlying > platform is not able to support IMS (Interrupt Message Storage). Otherwise, > the isolation of interrupt is not guaranteed. > > For x86, IMS is only supported on ba

Re: [RFC PATCH 1/1] platform-msi: Add platform check for subdevice irq domain

2020-12-10 Thread David Woodhouse
On Thu, 2020-12-10 at 08:46 +0800, Lu Baolu wrote: > +/* > + * We want to figure out which context we are running in. But the hardware > + * does not introduce a reliable way (instruction, CPUID leaf, MSR, whatever) > + * which can be manipulated by the VMM to let the OS figure out where it > runs

[RFC PATCH 1/1] platform-msi: Add platform check for subdevice irq domain

2020-12-09 Thread Lu Baolu
The pci_subdevice_msi_create_irq_domain() should fail if the underlying platform is not able to support IMS (Interrupt Message Storage). Otherwise, the isolation of interrupt is not guaranteed. For x86, IMS is only supported on bare metal for now. We could enable it in the virtualization environme