Re: [linux-sunxi] [PATCH 1/5] spi: sunxi: fix transfer timeout

2016-06-01 Thread Maxime Ripard
Hi Mark, On Mon, May 30, 2016 at 12:23:50PM +0100, Mark Brown wrote: > On Fri, May 27, 2016 at 03:10:11PM +1000, Julian Calaby wrote: > > On Fri, May 27, 2016 at 3:05 PM, Michal Suchanek wrote: > > > >> Also, should the changes for the drivers be in two separate patches also? > > > > That's bas

Re: [linux-sunxi] [PATCH 1/5] spi: sunxi: fix transfer timeout

2016-05-31 Thread Michal Suchanek
Hello On 30 May 2016 at 13:23, Mark Brown wrote: > On Fri, May 27, 2016 at 03:10:11PM +1000, Julian Calaby wrote: >> On Fri, May 27, 2016 at 3:05 PM, Michal Suchanek wrote: > >> >> Also, should the changes for the drivers be in two separate patches also? > >> > That's basically the same driver w

Re: [linux-sunxi] [PATCH 1/5] spi: sunxi: fix transfer timeout

2016-05-30 Thread Mark Brown
On Fri, May 27, 2016 at 03:10:11PM +1000, Julian Calaby wrote: > On Fri, May 27, 2016 at 3:05 PM, Michal Suchanek wrote: > >> Also, should the changes for the drivers be in two separate patches also? > > That's basically the same driver with different constants so I guess not. > Fair enough, I

Re: [linux-sunxi] [PATCH 1/5] spi: sunxi: fix transfer timeout

2016-05-26 Thread Julian Calaby
Hi Michal, On Fri, May 27, 2016 at 3:05 PM, Michal Suchanek wrote: > On 27 May 2016 at 04:05, Julian Calaby wrote: >> Hi Michal, >> >> On Fri, May 27, 2016 at 5:25 AM, Michal Suchanek wrote: >>> The trasfer timeout is fixed at 1000 ms. Reading a 4Mbyte flash over >>> 1MHz SPI bus takes way long

Re: [linux-sunxi] [PATCH 1/5] spi: sunxi: fix transfer timeout

2016-05-26 Thread Michal Suchanek
On 27 May 2016 at 04:05, Julian Calaby wrote: > Hi Michal, > > On Fri, May 27, 2016 at 5:25 AM, Michal Suchanek wrote: >> The trasfer timeout is fixed at 1000 ms. Reading a 4Mbyte flash over >> 1MHz SPI bus takes way longer than that. Calculate the timeout from the >> actual time the transfer is

Re: [linux-sunxi] [PATCH 1/5] spi: sunxi: fix transfer timeout

2016-05-26 Thread Julian Calaby
Hi Michal, On Fri, May 27, 2016 at 5:25 AM, Michal Suchanek wrote: > The trasfer timeout is fixed at 1000 ms. Reading a 4Mbyte flash over > 1MHz SPI bus takes way longer than that. Calculate the timeout from the > actual time the transfer is supposed to take and multiply by 2 for good > measure.