Re: [linux-sunxi] Re: [PATCH] dma: sun4i: expose block size and wait cycle configuration to DMA users

On Tue, Mar 08, 2016 at 03:35:38PM +0530, Vinod Koul wrote: > On Tue, Mar 08, 2016 at 09:42:31AM +0100, Hans de Goede wrote: > > > > > > I see 2 possible reasons why waiting till checking for drq can help: > > > > 1) A lot of devices have an internal fifo hooked up to a single mmio data > >

Re: [linux-sunxi] Re: [PATCH] dma: sun4i: expose block size and wait cycle configuration to DMA users

On Tue, Mar 08, 2016 at 03:35:38PM +0530, Vinod Koul wrote: > On Tue, Mar 08, 2016 at 09:42:31AM +0100, Hans de Goede wrote: > > > > > > I see 2 possible reasons why waiting till checking for drq can help: > > > > 1) A lot of devices have an internal fifo hooked up to a single mmio data > >

Re: [linux-sunxi] Re: [PATCH] dma: sun4i: expose block size and wait cycle configuration to DMA users

> > > > It doesn't really makes sense to us, but it does have a significant > > impact on the throughput. > > I wouldn't say significant impact, but tweaking those parameters has > some impact on the performances, and since it's not that complicated to > implement, I thought it was worth a try,

Re: [linux-sunxi] Re: [PATCH] dma: sun4i: expose block size and wait cycle configuration to DMA users

> > > > It doesn't really makes sense to us, but it does have a significant > > impact on the throughput. > > I wouldn't say significant impact, but tweaking those parameters has > some impact on the performances, and since it's not that complicated to > implement, I thought it was worth a try,

Re: [linux-sunxi] Re: [PATCH] dma: sun4i: expose block size and wait cycle configuration to DMA users

On Tue, Mar 08, 2016 at 09:42:31AM +0100, Hans de Goede wrote: > > > I see 2 possible reasons why waiting till checking for drq can help: > > 1) A lot of devices have an internal fifo hooked up to a single mmio data > register which gets read using the general purpose dma-engine, it allows >

Re: [linux-sunxi] Re: [PATCH] dma: sun4i: expose block size and wait cycle configuration to DMA users

On Tue, Mar 08, 2016 at 09:42:31AM +0100, Hans de Goede wrote: > > > I see 2 possible reasons why waiting till checking for drq can help: > > 1) A lot of devices have an internal fifo hooked up to a single mmio data > register which gets read using the general purpose dma-engine, it allows >

Re: [linux-sunxi] Re: [PATCH] dma: sun4i: expose block size and wait cycle configuration to DMA users

On Tue, 2016-03-08 at 09:46 +0100, Boris Brezillon wrote: > On Tue, 8 Mar 2016 08:51:31 +0100 > Maxime Ripard wrote: > > > On Tue, Mar 08, 2016 at 08:25:47AM +0530, Vinod Koul wrote: > > > On Mon, Mar 07, 2016 at 09:30:24PM +0100, Maxime Ripard wrote: > > > > On

Re: [linux-sunxi] Re: [PATCH] dma: sun4i: expose block size and wait cycle configuration to DMA users

On Tue, 2016-03-08 at 09:46 +0100, Boris Brezillon wrote: > On Tue, 8 Mar 2016 08:51:31 +0100 > Maxime Ripard wrote: > > > On Tue, Mar 08, 2016 at 08:25:47AM +0530, Vinod Koul wrote: > > > On Mon, Mar 07, 2016 at 09:30:24PM +0100, Maxime Ripard wrote: > > > > On Mon, Mar 07, 2016 at 04:08:57PM

Re: [linux-sunxi] Re: [PATCH] dma: sun4i: expose block size and wait cycle configuration to DMA users

Hi, On 08-03-16 08:51, Maxime Ripard wrote: On Tue, Mar 08, 2016 at 08:25:47AM +0530, Vinod Koul wrote: On Mon, Mar 07, 2016 at 09:30:24PM +0100, Maxime Ripard wrote: On Mon, Mar 07, 2016 at 04:08:57PM +0100, Boris Brezillon wrote: Hi Vinod, On Mon, 7 Mar 2016 20:24:29 +0530 Vinod Koul

Re: [linux-sunxi] Re: [PATCH] dma: sun4i: expose block size and wait cycle configuration to DMA users

Hi, On 08-03-16 08:51, Maxime Ripard wrote: On Tue, Mar 08, 2016 at 08:25:47AM +0530, Vinod Koul wrote: On Mon, Mar 07, 2016 at 09:30:24PM +0100, Maxime Ripard wrote: On Mon, Mar 07, 2016 at 04:08:57PM +0100, Boris Brezillon wrote: Hi Vinod, On Mon, 7 Mar 2016 20:24:29 +0530 Vinod Koul