Re: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer

2016-11-30 Thread Zefir Kurtisi
On 11/29/2016 07:35 PM, Nikita Yushchenko wrote: > Fec driver uses Rx buffers of 2k, but programs hardware to limit > incoming frames to 1522 bytes. This raises issues when FEC device > is used with DSA (since DSA tag can make frame larger), and also > disallows manual sending and receiving larger

RE: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer

2016-11-30 Thread Andy Duan
; Nikita >Yushchenko >Subject: [patch net / RFC] net: fec: increase frame size limitation to >actually >available buffer > >Fec driver uses Rx buffers of 2k, but programs hardware to limit incoming >frames to 1522 bytes. This raises issues when FEC device is used with

Re: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer

2016-11-30 Thread Toshiaki Makita
On 2016/11/30 15:36, Nikita Yushchenko wrote: >> But I think it is not necessary since the driver don't support jumbo frame. > > Hardcoded 1522 raises two separate issues. > > (1) When DSA is in use, frames processed by FEC chip contain DSA tag and > thus can be larger than hardcoded limit of 152

RE: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer

2016-11-29 Thread Andy Duan
nel.org >Subject: Re: [patch net / RFC] net: fec: increase frame size limitation to >actually available buffer > >> But I think it is not necessary since the driver don't support jumbo frame. > >Hardcoded 1522 raises two separate issues. > >(1) When DSA is in use, fr

Re: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer

2016-11-29 Thread Nikita Yushchenko
> But I think it is not necessary since the driver don't support jumbo frame. Hardcoded 1522 raises two separate issues. (1) When DSA is in use, frames processed by FEC chip contain DSA tag and thus can be larger than hardcoded limit of 1522. This issue is not FEC-specific, any driver that hardco

[patch net / RFC] net: fec: increase frame size limitation to actually available buffer

2016-11-29 Thread Nikita Yushchenko
Fec driver uses Rx buffers of 2k, but programs hardware to limit incoming frames to 1522 bytes. This raises issues when FEC device is used with DSA (since DSA tag can make frame larger), and also disallows manual sending and receiving larger frames. This patch removes the limitation, allowing Rx s