Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-25 Thread Jarkko Sakkinen
On Fri, Oct 21, 2016 at 06:11:41PM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 20, 2016 at 02:24:21PM -0600, Jason Gunthorpe wrote: > > On Thu, Oct 20, 2016 at 05:00:11PM +0300, Jarkko Sakkinen wrote: > > > > > > > I have a 4th Gen Core NUC where I experienced this issue. It reported > > > > >

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-25 Thread Jarkko Sakkinen
On Fri, Oct 21, 2016 at 06:11:41PM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 20, 2016 at 02:24:21PM -0600, Jason Gunthorpe wrote: > > On Thu, Oct 20, 2016 at 05:00:11PM +0300, Jarkko Sakkinen wrote: > > > > > > > I have a 4th Gen Core NUC where I experienced this issue. It reported > > > > >

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-21 Thread Jarkko Sakkinen
On Thu, Oct 20, 2016 at 02:24:21PM -0600, Jason Gunthorpe wrote: > On Thu, Oct 20, 2016 at 05:00:11PM +0300, Jarkko Sakkinen wrote: > > > > > I have a 4th Gen Core NUC where I experienced this issue. It reported > > > > requiring only ACPI start but actually required ACPI + CRB start. The > > > >

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-21 Thread Jarkko Sakkinen
On Thu, Oct 20, 2016 at 02:24:21PM -0600, Jason Gunthorpe wrote: > On Thu, Oct 20, 2016 at 05:00:11PM +0300, Jarkko Sakkinen wrote: > > > > > I have a 4th Gen Core NUC where I experienced this issue. It reported > > > > requiring only ACPI start but actually required ACPI + CRB start. The > > > >

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-20 Thread Jason Gunthorpe
On Thu, Oct 20, 2016 at 05:00:11PM +0300, Jarkko Sakkinen wrote: > > > I have a 4th Gen Core NUC where I experienced this issue. It reported > > > requiring only ACPI start but actually required ACPI + CRB start. The > > > comment could have been better. Shouldn't bios work arounds be keyed on

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-20 Thread Jason Gunthorpe
On Thu, Oct 20, 2016 at 05:00:11PM +0300, Jarkko Sakkinen wrote: > > > I have a 4th Gen Core NUC where I experienced this issue. It reported > > > requiring only ACPI start but actually required ACPI + CRB start. The > > > comment could have been better. Shouldn't bios work arounds be keyed on

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-20 Thread Jarkko Sakkinen
On Thu, Oct 20, 2016 at 04:59:06PM +0300, Jarkko Sakkinen wrote: > On Wed, Oct 19, 2016 at 07:09:28PM +0300, Jarkko Sakkinen wrote: > > On Wed, Oct 19, 2016 at 10:28:29AM +, Winkler, Tomas wrote: > > > > > > > > > > > > > > On Mon, Oct 17, 2016 at 11:42:24PM +0300, Jarkko Sakkinen wrote: >

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-20 Thread Jarkko Sakkinen
On Thu, Oct 20, 2016 at 04:59:06PM +0300, Jarkko Sakkinen wrote: > On Wed, Oct 19, 2016 at 07:09:28PM +0300, Jarkko Sakkinen wrote: > > On Wed, Oct 19, 2016 at 10:28:29AM +, Winkler, Tomas wrote: > > > > > > > > > > > > > > On Mon, Oct 17, 2016 at 11:42:24PM +0300, Jarkko Sakkinen wrote: >

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-20 Thread Jarkko Sakkinen
On Wed, Oct 19, 2016 at 07:09:28PM +0300, Jarkko Sakkinen wrote: > On Wed, Oct 19, 2016 at 10:28:29AM +, Winkler, Tomas wrote: > > > > > > > > > > On Mon, Oct 17, 2016 at 11:42:24PM +0300, Jarkko Sakkinen wrote: > > > > Because all the existing hardware have HID MSFT0101 we end up always >

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-20 Thread Jarkko Sakkinen
On Wed, Oct 19, 2016 at 07:09:28PM +0300, Jarkko Sakkinen wrote: > On Wed, Oct 19, 2016 at 10:28:29AM +, Winkler, Tomas wrote: > > > > > > > > > > On Mon, Oct 17, 2016 at 11:42:24PM +0300, Jarkko Sakkinen wrote: > > > > Because all the existing hardware have HID MSFT0101 we end up always >

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-19 Thread Jarkko Sakkinen
On Wed, Oct 19, 2016 at 10:28:29AM +, Winkler, Tomas wrote: > > > > > > On Mon, Oct 17, 2016 at 11:42:24PM +0300, Jarkko Sakkinen wrote: > > > Because all the existing hardware have HID MSFT0101 we end up always > > > setting CRB_FL_CRB_START flag as a workaround for 4th Gen Core CPUs. > >

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-19 Thread Jarkko Sakkinen
On Wed, Oct 19, 2016 at 10:28:29AM +, Winkler, Tomas wrote: > > > > > > On Mon, Oct 17, 2016 at 11:42:24PM +0300, Jarkko Sakkinen wrote: > > > Because all the existing hardware have HID MSFT0101 we end up always > > > setting CRB_FL_CRB_START flag as a workaround for 4th Gen Core CPUs. > >

RE: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-19 Thread Winkler, Tomas
> > On Mon, Oct 17, 2016 at 11:42:24PM +0300, Jarkko Sakkinen wrote: > > Because all the existing hardware have HID MSFT0101 we end up always > > setting CRB_FL_CRB_START flag as a workaround for 4th Gen Core CPUs. > > Even if ACPI start is used, the driver will always issue also CRB start. Do

RE: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-19 Thread Winkler, Tomas
> > On Mon, Oct 17, 2016 at 11:42:24PM +0300, Jarkko Sakkinen wrote: > > Because all the existing hardware have HID MSFT0101 we end up always > > setting CRB_FL_CRB_START flag as a workaround for 4th Gen Core CPUs. > > Even if ACPI start is used, the driver will always issue also CRB start. Do