Re: 回复：[PATCH 2/4] pinctrl: sunxi: add support for the Allwinner A100 pin controller

On Tue, Jun 16, 2020 at 11:27 AM Frank Lee wrote: > HI Chen-Yu, Linus, > On Fri, Jun 5, 2020 at 11:13 PM Maxime Ripard wrote: > > > Considering that the same pin has multiple same functions, > > > so add a suffix, like i2s3_dout3 and i2s3_din3? > > > > > > Or specify muxsel in the device tree

Re: 回复：[PATCH 2/4] pinctrl: sunxi: add support for the Allwinner A100 pin controller

HI Chen-Yu, Linus, On Fri, Jun 5, 2020 at 11:13 PM Maxime Ripard wrote: > > Hi Frank, > > On Wed, Jun 03, 2020 at 05:44:36PM +0800, 李扬韬 wrote: > > >> + SUNXI_PIN(SUNXI_PINCTRL_PIN(F, 0), > > >> + SUNXI_FUNCTION(0x0, "gpio_in"), > > >> + SUNXI_FUNCTION(0x1, "gpio_out"), > > >> +

Re: 回复：[PATCH 2/4] pinctrl: sunxi: add support for the Allwinner A100 pin controller

Hi Frank, On Wed, Jun 03, 2020 at 05:44:36PM +0800, 李扬韬 wrote: > >> + SUNXI_PIN(SUNXI_PINCTRL_PIN(F, 0), > >> + SUNXI_FUNCTION(0x0, "gpio_in"), > >> + SUNXI_FUNCTION(0x1, "gpio_out"), > >> + SUNXI_FUNCTION(0x2, "mmc0"), /* D1 */ > >> + SUNXI_FUNCTION(0x3, "jtag"), /* MS1 */ > >> +

回复：[PATCH 2/4] pinctrl: sunxi: add support for the Allwinner A100 pin controller

>> + SUNXI_PIN(SUNXI_PINCTRL_PIN(F, 0), >> + SUNXI_FUNCTION(0x0, "gpio_in"), >> + SUNXI_FUNCTION(0x1, "gpio_out"), >> + SUNXI_FUNCTION(0x2, "mmc0"), /* D1 */ >> + SUNXI_FUNCTION(0x3, "jtag"), /* MS1 */ >> + SUNXI_FUNCTION(0x4, "jtag"), /* MS_GPU */ > >We should use another name here, since