Re: Aw: Re: [PATCH] thermal: mediatek: add sensors-support

2021-04-20 Thread Daniel Lezcano
On 20/04/2021 17:24, Frank Wunderlich wrote: > Am 20. April 2021 17:18:32 MESZ schrieb Daniel Lezcano > : >> >> Hi Frank, > >> The no_hwmon usage is a bit fuzzy in the thermal core code. > > Maybe add depency in Kconfig? Else we can get undefined symbols on linking > > regards Frank Nope, ther

Re: Aw: Re: [PATCH] thermal: mediatek: add sensors-support

2021-04-20 Thread Frank Wunderlich
Am 20. April 2021 17:18:32 MESZ schrieb Daniel Lezcano : > >Hi Frank, >The no_hwmon usage is a bit fuzzy in the thermal core code. Maybe add depency in Kconfig? Else we can get undefined symbols on linking regards Frank

Re: Aw: Re: [PATCH] thermal: mediatek: add sensors-support

2021-04-20 Thread Daniel Lezcano
Hi Frank, On 20/04/2021 16:59, Frank Wunderlich wrote: > Hi, > >> Gesendet: Dienstag, 20. April 2021 um 14:07 Uhr >> Von: "Daniel Lezcano" > >> No #ifdef in C file. > ... > >> devm_thermal_add_hwmon_sysfs() ? > > based on your comments this should be enough/right? > > #if IS_ENABLED(CONFIG

Aw: Re: [PATCH] thermal: mediatek: add sensors-support

2021-04-20 Thread Frank Wunderlich
Hi, > Gesendet: Dienstag, 20. April 2021 um 14:07 Uhr > Von: "Daniel Lezcano" > No #ifdef in C file. ... > devm_thermal_add_hwmon_sysfs() ? based on your comments this should be enough/right? #if IS_ENABLED(CONFIG_THERMAL_HWMON) tzdev->tzp->no_hwmon = false; ret = devm_thermal_add_hwm

Aw: [PATCH] thermal: mediatek: add sensors-support

2021-04-18 Thread Frank Wunderlich
Hi, any opinion (except typo)? thermanl => thermal regards Frank > Gesendet: Samstag, 20. März 2021 um 10:06 Uhr > Von: "Frank Wunderlich" > add HWMON-support to mediateks thermanl driver to allow lm-sensors > userspace tools read soc temperature

Aw: Re: [PATCH net,v2] net: dsa: mt7530: setup core clock even in TRGMII mode

2021-03-19 Thread Frank Wunderlich
Hi René,Ilya > Gesendet: Freitag, 19. März 2021 um 11:25 Uhr > Von: "René van Dorst" > Hi Ilya, > > Thanks for fixing this issue. > > I remember that Frank also had an issue with TRGMII on his MT7623 ARM board. > I never found why it did not work but this may be also fix his issue > on the MT

AW: [PATCH v6 1/1] mfd: da9063: Support SMBus and I2C mode

2021-03-17 Thread Jonas Mark (BT-FIR/ENG1-Grb)
Hi, > > From: Hubert Streidl > > > > By default the PMIC DA9063 2-wire interface is SMBus compliant. This > > means the PMIC will automatically reset the interface when the clock > > signal ceases for more than the SMBus timeout of 35 ms. > > > > If the I2C driver / device is not capable of creat

Re: AW: [RFC v3 04/17] arch_prctl.2: SYNOPSIS: Remove unused includes

2021-03-16 Thread Alejandro Colomar (man-pages)
Hi Walter, On 3/15/21 7:00 PM, Walter Harms wrote: I have learned the other way around: #include Is a general system header to use that may include the asm/prctrl.h what should never be included by userspace programms. Are you sure that includes ? user@debian:/usr/include$ grep -rn '\bARCH

Aw: [PATCH] net: wireguard: fix error with icmp{,v6}_ndo_send in 5.4

2021-03-16 Thread Frank Wunderlich
Hi, sorry, please ignore this wireguard was included with 5.6, my 5.4 uses external wireguard regards Frank

AW: [RFC v3 04/17] arch_prctl.2: SYNOPSIS: Remove unused includes

2021-03-15 Thread Walter Harms
I have learned the other way around: #include Is a general system header to use that may include the asm/prctrl.h what should never be included by userspace programms. jm2c, re, wh Von: Alejandro Colomar Gesendet: Samstag, 13. März 2021 20:25:14 An: mtk.

Re: Aw: Re: Re: [PATCH 09/13] PCI: mediatek: Advertise lack of MSI handling

2021-03-02 Thread Robin Murphy
On 2021-03-01 14:06, Frank Wunderlich wrote: Gesendet: Montag, 01. März 2021 um 14:31 Uhr Von: "Marc Zyngier" Frank, i guess it's a bug in ath10k driver or my r64 board (it is a v1.1 which has missing capacitors on tx lines). No, this definitely looks like a bug in the MTK PCIe driver, wher

AW: [PATCH 0/8] USB Audio Gadget part 2: Feedback endpoint, Volume/Mute support

2021-03-01 Thread Johannes Freyberger
Hi Ruslan, thanks a lot for your quick answer. > -Ursprüngliche Nachricht- > Von: Ruslan Bilovol > Gesendet: Montag, 1. März 2021 22:34 > An: Johannes Freyberger > Cc: Felipe Balbi ; Jonathan Corbet ; > Greg Kroah-Hartman ; Glenn Schmottlach > ; linux-...@vger.kernel.org; linux- > ker...

Aw: Re: Re: [PATCH 09/13] PCI: mediatek: Advertise lack of MSI handling

2021-03-01 Thread Frank Wunderlich
> Gesendet: Montag, 01. März 2021 um 14:31 Uhr > Von: "Marc Zyngier" > > Frank, > > >> > i guess it's a bug in ath10k driver or my r64 board (it is a v1.1 > >> > which has missing capacitors on tx lines). > >> > >> No, this definitely looks like a bug in the MTK PCIe driver, > >> where the mutex

Re: Aw: Re: [PATCH 09/13] PCI: mediatek: Advertise lack of MSI handling

2021-03-01 Thread Marc Zyngier
Frank, > i guess it's a bug in ath10k driver or my r64 board (it is a v1.1 > which has missing capacitors on tx lines). No, this definitely looks like a bug in the MTK PCIe driver, where the mutex is either not properly initialised, corrupted, or the wrong pointer is passed. but why does it h

Aw: Re: [PATCH 09/13] PCI: mediatek: Advertise lack of MSI handling

2021-03-01 Thread Frank Wunderlich
regards Frank > Gesendet: Montag, 01. März 2021 um 12:49 Uhr > Von: "Marc Zyngier" > Frank, > > On 2021-03-01 10:43, Frank Wunderlich wrote: > > tested full series on bananapi-r2 and r64 > > > > r2 (with mt7615) looks good. > > > > on r64 (with atheros card WLE900VX) i see this while loadi

Re: Aw: [PATCH 09/13] PCI: mediatek: Advertise lack of MSI handling

2021-03-01 Thread Marc Zyngier
Frank, On 2021-03-01 10:43, Frank Wunderlich wrote: tested full series on bananapi-r2 and r64 r2 (with mt7615) looks good. on r64 (with atheros card WLE900VX) i see this while loading ath10k driver: [6.525981] ath10k_pci :01:00.0: enabling device ( -> 0002) [6.537810] ath10k

Aw: [PATCH 09/13] PCI: mediatek: Advertise lack of MSI handling

2021-03-01 Thread Frank Wunderlich
tested full series on bananapi-r2 and r64 r2 (with mt7615) looks good. on r64 (with atheros card WLE900VX) i see this while loading ath10k driver: [6.525981] ath10k_pci :01:00.0: enabling device ( -> 0002) [6.537810] ath10k_pci :01:00.0: enabling bus mastering [6.543831]

AW: [PATCH net] net: hsr: add support for EntryForgetTime

2021-02-25 Thread Wenzel, Marco
On Thu, Feb 25, 2021 at 6:49 PM Jakub Kicinski wrote: > > On Wed, 24 Feb 2021 14:55:17 +0100 Andrew Lunn wrote: > > On Wed, Feb 24, 2021 at 10:46:49AM +0100, Marco Wenzel wrote: > > > In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. > > > When a node does not send any frame withi

AW: [PATCH] net: hsr: add support for EntryForgetTime

2021-02-24 Thread Wenzel, Marco
On Mon, Feb 22, 2021 at 5:49 PM : George McCollister wrote: > > On Mon, Feb 22, 2021 at 7:38 AM Wenzel, Marco eberle.de> wrote: > > > > On Fri, Feb 19, 2021 at 2:14 PM : George McCollister > wrote: > > > > > > On Fri, Feb 19, 2021 at 2:27 AM Wenzel, Marco > > eberle.de> wrote: > > > > > > > >

AW: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-02-19 Thread Jonas Mark (BT-FIR/ENG1-Grb)
Hi, > > From: Hubert Streidl > > > > By default the PMIC DA9063 2-wire interface is SMBus compliant. This > > means the PMIC will automatically reset the interface when the clock > > signal ceases for more than the SMBus timeout of 35 ms. > > > > If the I2C driver / device is not capable of creat

AW: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-19 Thread Sven Schuchmann
Hello Andy, > Von: Andy Shevchenko > Gesendet: Freitag, 19. Februar 2021 14:56 > An: Sven Schuchmann > Cc: Pavel Machek ; Dan Murphy ; > linux-l...@vger.kernel.org; > linux-kernel@vger.kernel.org > Betreff: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity > from DT > > > > >

AW: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-19 Thread Sven Schuchmann
Hello Pavel, hello Andy, > -Ursprüngliche Nachricht- > Von: Pavel Machek > Gesendet: Freitag, 19. Februar 2021 12:17 > An: Sven Schuchmann > Cc: Dan Murphy ; linux-l...@vger.kernel.org; > linux-kernel@vger.kernel.org > Betreff: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default int

AW: [PATCH] net: hsr: add support for EntryForgetTime

2021-02-19 Thread Wenzel, Marco
On Thu, Feb 18, 2021 at 6:06 PM : George McCollister wrote: > > On Thu, Feb 18, 2021 at 9:01 AM Marco Wenzel eberle.de> wrote: > > > > In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. When > > a node does not send any frame within this time, the sequence number > > check for ca

AW: [PATCH][next] iommu/mediatek: Fix unsigned domid comparison with less than zero

2021-02-09 Thread Walter Harms
I second that ... Having i unsigned violates the rule of "least surprise". If you need it unsigned make it clearly visible, also adding a simple comment may help. jm2c, wh Von: Dan Carpenter Gesendet: Dienstag, 9. Februar 2021 10:19:23 An: Will Deacon Cc

AW: [PATCH] drm/amdgpu: fix potential integer overflow on shift of a int

2021-02-08 Thread Walter Harms
thx for info Von: Christian König Gesendet: Montag, 8. Februar 2021 13:14:49 An: Walter Harms; Colin King; Alex Deucher; David Airlie; Daniel Vetter; Huang Rui; Junwei Zhang; amd-...@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: kernel-janit.

AW: [PATCH] drm/amdgpu: fix potential integer overflow on shift of a int

2021-02-08 Thread Walter Harms
i am curious: what is the win to have a unsigned 64 bit integer in the first place ? re, wh Von: Christian König Gesendet: Montag, 8. Februar 2021 10:17:42 An: Colin King; Alex Deucher; David Airlie; Daniel Vetter; Huang Rui; Junwei Zhang; amd-...@lists.

Re: AW: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT

2021-02-06 Thread Jacek Anaszewski
Sven, On 2/6/21 2:14 PM, Sven Schuchmann wrote: Hello Dan, Von: Jacek Anaszewski Gesendet: Freitag, 5. Februar 2021 19:37 Hi Pavel, On 2/5/21 11:23 AM, Pavel Machek wrote: Hi! patternProperties: "(^led-[0-9a-f]$|led)": @@ -99,6 +104,7 @@ examples: reg = <

AW: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT

2021-02-06 Thread Sven Schuchmann
Hello Dan, > Von: Jacek Anaszewski > Gesendet: Freitag, 5. Februar 2021 19:37 > Hi Pavel, > > On 2/5/21 11:23 AM, Pavel Machek wrote: > > Hi! > > > patternProperties: > "(^led-[0-9a-f]$|led)": > @@ -99,6 +104,7 @@ examples: > reg = <0x1>; >

AW: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT

2021-02-05 Thread Sven Schuchmann
Hello Pavel, hello Dan, > > diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml > > b/Documentation/devicetree/bindings/leds/leds- > lp50xx.yaml > > index c192b5feadc7..2bc25b2fc94d 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml > > +++ b/Documentation/d

AW: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-05 Thread Sven Schuchmann
Hello Pavel, > > > > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c > > > > index f13117eed976..4b40bf66483c 100644 > > > > --- a/drivers/leds/leds-lp50xx.c > > > > +++ b/drivers/leds/leds-lp50xx.c > > > > @@ -267,7 +267,6 @@ struct lp50xx_led { > > > > struct led_cl

AW: [PATCH v2 4/4] leds: lp50xx: add setting of default intensity from DT

2021-02-05 Thread Sven Schuchmann
Hello Pavel, > > > Signed-off-by: Sven Schuchmann > > Check your email headers, empty To: is strange. > > > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c > > index 79bc071c31fb..e8aa36c7e963 100644 > > --- a/drivers/leds/leds-lp50xx.c > > +++ b/drivers/leds/leds-lp50xx.c

AW: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

2021-02-05 Thread Sven Schuchmann
Hello Pavel, > > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c > > index f13117eed976..4b40bf66483c 100644 > > --- a/drivers/leds/leds-lp50xx.c > > +++ b/drivers/leds/leds-lp50xx.c > > @@ -267,7 +267,6 @@ struct lp50xx_led { > > struct led_classdev_mc mc_cdev; > > st

AW: [PATCH v2] mfd: da9063: Support SMBus and I2C mode

2021-02-04 Thread Jonas Mark (BT-FIR/ENG1-Grb)
Hi Adam, > > + if (i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C)) { > > + dev_info(da9063->dev, "I2C mode"); > > + busmode = 0; > > + } else { > > + dev_info(da9063->dev, "SMBus mode"); > > + busmode = 1; > > I think this should be 'DA9063_TWOWIRE

AW: [PATCH v1] leds: lp50xx: add setting of default intensity from DT

2021-02-03 Thread Sven Schuchmann
Helo Pavel, > > > Yes, sounds reasonable. Could we get default intensity of 100% on all > > > channels if nothing else is specified? > > > > > > Or maybe simply "if intensity is not specified, start with 100%, and > > > use explicit =0 if other color is expected". > > > > > Mh, if someone is alrea

AW: [PATCH v1] leds: lp50xx: add setting of default intensity from DT

2021-02-03 Thread Sven Schuchmann
Hello Pavel, hello Marek > > Is the property default-intensity documented in DT bindings? I updated the documentation in leds-lp50xx.yaml. Is it this what you mean? > > Wouldn't it be better if the property was used in the multi-led node > > instead of the channel node? I.e. > > multi-led@3 {

AW: [PATCH v1] leds: lp50xx: add setting of default intensity from DT

2021-02-03 Thread Sven Schuchmann
Hello Pavel, > > Yes, sounds reasonable. Could we get default intensity of 100% on all > channels if nothing else is specified? > > Or maybe simply "if intensity is not specified, start with 100%, and > use explicit =0 if other color is expected". > Mh, if someone is already using the led drive

AW: [PATCH 2/2] leds: lp50xx: remove unused regulator

2021-02-03 Thread Sven Schuchmann
Hello Dan, hello Pavel, > > Do you have set up where this is needed and you can test this? Will > > you submit the fixes? > > No I use an always on regulator in my setup. I have no managed supplies > exposed. I am also sorry I do not have a setup ready for testing this. I think we should ignore t

AW: [PATCH v1] leds: lp50xx: add setting of default intensity from DT

2021-02-03 Thread Sven Schuchmann
Hello Pavel, > > In order to use a multicolor-led together with a trigger > > from DT the led needs to have an intensity set to see something. > > The trigger changes the brightness of the led but if there > > is no intensity we actually see nothing. > > > > This patch adds the ability to set the

Aw: Re: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2021-02-02 Thread Frank Wunderlich
Hi, is there any new state? kernel test robot reports the following problem (i do not see it when compiling for my arm/arm64 devices): ARCH=i386 drivers/pci/probe.c: In function 'pci_register_host_bridge': >> drivers/pci/probe.c:930:39: error: 'struct device' has no member named >> 'msi_domai

AW: [PATCH v1] leds: lp50xx: add setting of default intensity from DT

2021-02-02 Thread Sven Schuchmann
Hi, sorry to ask but was someone able to look at this? Any thoughts? Best Regards, Sven > -Ursprüngliche Nachricht- > Von: Sven Schuchmann > Gesendet: Dienstag, 19. Januar 2021 11:53 > An: Sven Schuchmann > Cc: Pavel Machek ; Dan Murphy ; Rob Herring > ; linux- > l...@vger.kernel.o

AW: [PATCH 1/1] mfd: da9063: Support SMBus and I2C mode

2021-01-28 Thread Jonas Mark (BT-FIR/ENG1-Grb)
Hi Adam, > > From: Hubert Streidl > > > > By default the PMIC DA9063 2-wire interface is SMBus compliant. This > > means the PMIC will automatically reset the interface when the clock > > signal ceases for more than the SMBus timeout of 35 ms. > > > > If the I2C driver / device is not capable of

Re: Aw: [PATCH v2 3/3] regulator: mt6323: Add OF match table

2021-01-10 Thread Matthias Brugger
On 09/01/2021 17:44, Frank Wunderlich wrote: > Hi > >> Gesendet: Samstag, 09. Januar 2021 um 12:26 Uhr >> Von: matthias@kernel.org > >> Changes in v2: >> - check for CONFIG_OF >> - add Fixes tag > >> --- a/drivers/regulator/mt6323-regulator.c >> +++ b/drivers/regulator/mt6323-regulator.c

Aw: [PATCH v2 3/3] regulator: mt6323: Add OF match table

2021-01-09 Thread Frank Wunderlich
Hi > Gesendet: Samstag, 09. Januar 2021 um 12:26 Uhr > Von: matthias@kernel.org > Changes in v2: > - check for CONFIG_OF > - add Fixes tag > --- a/drivers/regulator/mt6323-regulator.c > +++ b/drivers/regulator/mt6323-regulator.c > @@ -406,9 +406,18 @@ static const struct platform_device_id

Aw: Re: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2021-01-03 Thread Frank Wunderlich
Hi, 5.11-rc1 is also affected, here is the relevant part of trace from my bananapi-r2: [5.792659] mtk-pcie 1a14.pcie: PCI host bridge to bus :00 [5.798879] pci_bus :00: root bus resource [bus 00-ff] [5.804412] pci_bus :00: root bus resource [io 0x-0x] (bus a

Aw: Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration

2020-12-11 Thread Lino Sanfilippo
Hi Uwe, > Gesendet: Donnerstag, 10. Dezember 2020 um 12:43 Uhr > Von: "Uwe Kleine-König" > An: "Lino Sanfilippo" > Cc: thierry.red...@gmail.com, lee.jo...@linaro.org, nsaenzjulie...@suse.de, > f.faine...@gmail.com, r...@broadcom.com, s...@mess.org, > sbran...@broadcom.com, bcm-kernel-feedback-

Aw: Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration

2020-12-09 Thread Lino Sanfilippo
Hi Uwe > Hello Lino, > > On Tue, Dec 08, 2020 at 11:01:45PM +0100, Lino Sanfilippo wrote: > > Use the newer .apply function of pwm_ops instead of .config, .enable, > > .disable and .set_polarity. This guarantees atomic changes of the pwm > > controller configuration. It also reduces the size of th

AW: [PATCH] drm: imx: Move fbdev setup to before output polling

2020-11-26 Thread Jonas Mark (BT-FIR/ENG1-Grb)
Hi Daniel, > > Thank you very much for your feedback. We appreciate it. > > > > > >>> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c > > > >>> b/drivers/gpu/drm/imx/imx-drm-core.c > > > >>> index 9bf5ad6d18a2..2665040e11c7 100644 > > > >>> --- a/drivers/gpu/drm/imx/imx-drm-core.c > > > >>> +++ b/

Aw: Re: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-21 Thread Frank Wunderlich
Hi, any new state here? last fix works, but i have not seen it approved by anyone for merge or sent as separate Patch regards Frank

AW: [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C

2020-11-18 Thread werner....@siemens.com
Hi Henning. We had a short discussion with Andy on coreboot Gerrit (https://review.coreboot.org/c/coreboot/+/47235) regarding this issue. We have agreed that we will give Epson a period of two weeks for reaction. If we will not have a valid HID by then, I will push a patch which will use a non

AW: [PATCH] drm: imx: Move fbdev setup to before output polling

2020-11-18 Thread Jonas Mark (BT-FIR/ENG1-Grb)
Hi Thomas and Daniel, Thank you very much for your feedback. We appreciate it. > >>> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c > >>> b/drivers/gpu/drm/imx/imx-drm-core.c > >>> index 9bf5ad6d18a2..2665040e11c7 100644 > >>> --- a/drivers/gpu/drm/imx/imx-drm-core.c > >>> +++ b/drivers/gpu/drm/

AW: [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C

2020-11-17 Thread johannes-h...@siemens.com
Hello Val, my name is Johannes Hahn from Siemens AG in Germany. Our product Open Controller II (OCII)[1] uses the Realtime Clock RX6110SA from SEIKO EPSON. Currently there is a merge request ongoing for the Linux Kernel master branch[2] which adds I²C and ACPI support to your original driver i

AW: [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C

2020-11-16 Thread johannes-h...@siemens.com
Hello Andy, when comparing the ACPI IDs used in rtc-ds1307.c, which is already on mainline https://elixir.bootlin.com/linux/latest/source/drivers/rtc/rtc-ds1307.c#L1141 for example. Every ID listed there is also not formatted the ACPI ID , PNP ID way defined in the ACPI spec. How about that ?

Re: Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-06 Thread Marc Zyngier
On 2020-11-05 23:00, Thomas Gleixner wrote: On Thu, Nov 05 2020 at 09:20, Marc Zyngier wrote: On 2020-11-04 23:14, Thomas Gleixner wrote: /* Resource alignment requirements */ resource_size_t (*align_resource)(struct pci_dev *dev, If that's the direction of travel, we also nee

Re: Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-05 Thread Thomas Gleixner
On Thu, Nov 05 2020 at 09:20, Marc Zyngier wrote: > On 2020-11-04 23:14, Thomas Gleixner wrote: >> /* Resource alignment requirements */ >> resource_size_t (*align_resource)(struct pci_dev *dev, > > If that's the direction of travel, we also need something like this > for configuration wh

Aw: Re: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-05 Thread Frank Wunderlich
Marc's Patch based on thomas' last one also seems to work well for r2, again no warning, PCI and AHCI (connected to pcie bus) working regards Frank

Re: Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-05 Thread Marc Zyngier
On 2020-11-04 23:14, Thomas Gleixner wrote: [...] TBH, that's butt ugly. So after staring long enough into the PCI code I came up with a way to transport that information to the probe code. That allows a particular device to say 'I can't do MSI' and at the same time keeps the warning machinery

Re: Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-04 Thread Thomas Gleixner
Frank, On Wed, Nov 04 2020 at 17:49, Frank Wunderlich wrote: >> Von: "Thomas Gleixner" >> Any architecture which selects PCI_MSI_ARCH_FALLBACKS and does not have >> irqdomain support runs into: >> >> if (!d) >> bus->bus_flags |= PCI_BUS_FLAGS_NO_MSI; >> >> which in turn makes pc

Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-04 Thread Frank Wunderlich
> Gesendet: Dienstag, 03. November 2020 um 11:16 Uhr > Von: "Thomas Gleixner" > Any architecture which selects PCI_MSI_ARCH_FALLBACKS and does not have > irqdomain support runs into: > > if (!d) > bus->bus_flags |= PCI_BUS_FLAGS_NO_MSI; > > which in turn makes pci_msi_support

Re: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-03 Thread Thomas Gleixner
On Tue, Nov 03 2020 at 11:41, Marc Zyngier wrote: > On 2020-11-03 10:31, Thomas Gleixner wrote: > We can do that, although I worried that it isn't 100% reliable: > > pci_host_probe() ends up calling pci_add_device(), and will start > probing devices if the endpoint drivers have already registered >

Re: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-03 Thread Marc Zyngier
On 2020-11-03 10:31, Thomas Gleixner wrote: On Tue, Nov 03 2020 at 09:54, Marc Zyngier wrote: On 2020-11-02 22:18, Thomas Gleixner wrote: So we really need some other solution and removing the warning is not an option. If MSI is enabled then we want to get a warning when a PCI device has no MSI

Re: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-03 Thread Thomas Gleixner
On Tue, Nov 03 2020 at 09:54, Marc Zyngier wrote: > On 2020-11-02 22:18, Thomas Gleixner wrote: >> So we really need some other solution and removing the warning is not >> an option. If MSI is enabled then we want to get a warning when a PCI >> device has no MSI domain associated. Explicitly expre

Re: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-03 Thread Marc Zyngier
On 2020-11-03 10:16, Thomas Gleixner wrote: On Tue, Nov 03 2020 at 09:54, Marc Zyngier wrote: On 2020-11-02 22:18, Thomas Gleixner wrote: On Mon, Nov 02 2020 at 17:16, Thomas Gleixner wrote: On Mon, Nov 02 2020 at 11:30, Marc Zyngier wrote: --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c

Re: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-03 Thread Thomas Gleixner
On Tue, Nov 03 2020 at 09:54, Marc Zyngier wrote: > On 2020-11-02 22:18, Thomas Gleixner wrote: >> On Mon, Nov 02 2020 at 17:16, Thomas Gleixner wrote: >>> On Mon, Nov 02 2020 at 11:30, Marc Zyngier wrote: --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -871,6 +871,8 @@ static

Re: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-03 Thread Marc Zyngier
On 2020-11-02 22:18, Thomas Gleixner wrote: On Mon, Nov 02 2020 at 17:16, Thomas Gleixner wrote: On Mon, Nov 02 2020 at 11:30, Marc Zyngier wrote: --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -871,6 +871,8 @@ static void pci_set_bus_msi_domain(struct pci_bus *bus) d =

Re: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-02 Thread Thomas Gleixner
On Mon, Nov 02 2020 at 17:16, Thomas Gleixner wrote: > On Mon, Nov 02 2020 at 11:30, Marc Zyngier wrote: >> --- a/drivers/pci/probe.c >> +++ b/drivers/pci/probe.c >> @@ -871,6 +871,8 @@ static void pci_set_bus_msi_domain(struct pci_bus >> *bus) >> d = pci_host_bridge_msi_domain(b); >>

Re: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-02 Thread Thomas Gleixner
On Mon, Nov 02 2020 at 11:30, Marc Zyngier wrote: > On 2020-11-01 22:27, Thomas Gleixner wrote: > The following patch makes it work for me (GICv3 guest without an ITS)by > checking for the presence of an MSI domain at the point where we > actually > perform this association, and before starting to

Aw: Re: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-02 Thread Frank Wunderlich
> Gesendet: Montag, 02. November 2020 um 14:58 Uhr > Von: "Marc Zyngier" > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c > index d15c881e2e7e..5bb1306162c7 100644 > --- a/drivers/pci/pci-sysfs.c > +++ b/drivers/pci/pci-sysfs.c > @@ -387,10 +387,20 @@ static ssize_t msi_bus_store(

Re: Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-02 Thread Marc Zyngier
On 2020-11-02 11:56, Frank Wunderlich wrote: looks good on bananapi-r2, no warning, pcie-card and hdd recognized Thanks for giving it a shot. Still needs a bit of tweaking, as I expect it to break configurations that select CONFIG_PCI_MSI_ARCH_FALLBACKS (we have to assume that MSIs can be handl

Aw: Re: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-02 Thread Frank Wunderlich
looks good on bananapi-r2, no warning, pcie-card and hdd recognized regards Frank > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 4289030b0fff..bb363eb103a2 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -871,6 +871,8 @@ static void pci_set_bus_msi_domain(st

Re: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-02 Thread Marc Zyngier
On 2020-11-01 22:27, Thomas Gleixner wrote: On Sun, Nov 01 2020 at 21:47, Marc Zyngier wrote: On Sun, 01 Nov 2020 18:27:13 +, Frank Wunderlich wrote: Thinking of it a bit more, I think this is the wrong solution. PCI MSIs are optional, and not a requirement. I can trivially spin a VM with

Re: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-01 Thread Thomas Gleixner
On Sun, Nov 01 2020 at 21:47, Marc Zyngier wrote: > On Sun, 01 Nov 2020 18:27:13 +, > Frank Wunderlich wrote: > Thinking of it a bit more, I think this is the wrong solution. > > PCI MSIs are optional, and not a requirement. I can trivially spin a > VM with PCI devices and yet no MSI capabilit

Re: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-01 Thread Marc Zyngier
On Sun, 01 Nov 2020 18:27:13 +, Frank Wunderlich wrote: > > > Gesendet: Sonntag, 01. November 2020 um 18:54 Uhr > > Von: "Ryder Lee" > > > Yea, mt7623 (mtk_pcie_soc_v1) does not support MSI, so that's a way to > > handle it. > > > > @Frank, could you help to test it? > > > > Ryder > > comp

Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-01 Thread Frank Wunderlich
> Gesendet: Sonntag, 01. November 2020 um 18:54 Uhr > Von: "Ryder Lee" > Yea, mt7623 (mtk_pcie_soc_v1) does not support MSI, so that's a way to > handle it. > > @Frank, could you help to test it? > > Ryder compiles clean for mt7623/armhf and mt7622/aarch64 so far at least bananapi-r2/mt7623 boo

Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h

2020-11-01 Thread Frank Wunderlich
> Gesendet: Sonntag, 01. November 2020 um 12:43 Uhr > Von: "Marc Zyngier" > On Sun, 01 Nov 2020 09:25:04 +, > Frank Wunderlich wrote: > > It looks like for mt7623 there is no msi domain setup (done via > > mtk_pcie_setup_irq callback + mtk_pcie_init_irq_domain) in mtk pcie > > driver. > >

AW: [PATCH][next] SFH: fix error return check for -ERESTARTSYS

2020-10-30 Thread Walter Harms
nit picking: i would without "else" to improve readability: if (ret == -ERESTARTSYS) return -ERESTARTSYS; if (ret < 0) return -ETIMEDOUT; return 0; jm2c wh Von: Colin King Gesendet: Freitag, 30.

AW: [PATCH] x86/unwind: remove unneeded initialization

2020-10-29 Thread Walter Harms
this looks like a reimplementation of bsearch() perhaps the maintainer can add a comment why the kernel implementation is not suitable here ? jm2c wh Von: Lukas Bulwahn [lukas.bulw...@gmail.com] Gesendet: Mittwoch, 28. Oktober 2020 13:21 An: Thomas Gleix

AW: [PATCH] sched/fair: check for idle core

2020-10-22 Thread Walter Harms
To avoid this #ifdef jungle .. I guess it would be save to search for a governor even ones that are not enabled. and a second thing: can we change the subject please ? jm2c wh Von: Peter Zijlstra [pet...@infradead.org] Gesendet: Donnerstag, 22. Oktobe

AW: [PATCH] tools: net: traceevent: Fix 'snprintf' return value check in 'tep_filter_strerror'

2020-10-15 Thread Walter Harms
i guess the whole thing can be made more simple we have len and buflen len=strlen(filter->error_buffer); if (len >= buflen ) return -1; strcpy(buf, filter->error_buffer); jm2c, Von: Fedor Tokarev [ftoka...@gmail.com] Gesendet: Donnerstag, 15. Oktobe

AW: [PATCH] net: sunrpc: Fix 'snprintf' return value check in 'do_xprt_debugfs'

2020-10-15 Thread Walter Harms
if xprt->debugfs->d_name.name can be what ever long it is more clever to use kasprintf() the some for link (no idea how many xprt als possible) jm2c wh Von: Fedor Tokarev [ftoka...@gmail.com] Gesendet: Donnerstag, 15. Oktober 2020 15:59 An: bfie...@field

Re: AW: [PATCH 0/7] TC-ETF support PTP clocks series

2020-10-09 Thread Thomas Gleixner
Andreas, On Fri, Oct 09 2020 at 11:17, Andreas Meisinger wrote: please do not top-post and trim your replies. > Yet we do already have usecases where this can't be done. Additionally > a lot of discussions at this topic are ongoing in 60802 profile > creation too. Some of our usecases do requir

AW: [PATCH 0/7] TC-ETF support PTP clocks series

2020-10-09 Thread Meisinger, Andreas
Hello Mr Gleixner, thanks for your feedback we'll fix the issues not related to the time scale topic as soon as possible. Regarding your concerns about not using TAI timescale, we do admit that in many situations TAI makes a lot of things way more easy and therefore is the way to go. Yet we do

Aw: [v5 0/2] Add Mediatek thermal dirver and dtsi

2020-10-07 Thread Frank Wunderlich
> Gesendet: Mittwoch, 07. Oktober 2020 um 09:54 Uhr > Von: "Michael Kao" > Betreff: [v5 0/2] Add Mediatek thermal dirver and dtsi Hi, just a small typo "dirver" => driver and coverletter (v5) does not match series (v1/without version), so it is not linked correctly in patchwork. I guess V1 is t

Aw: [PATCH] arm: dts: mt7623: add missing pause for switchport

2020-09-16 Thread Frank Wunderlich
just a gentle ping regards Frank > Gesendet: Montag, 07. September 2020 um 09:05 Uhr > +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > @@ -192,6 +192,7 @@ port@6 { > fixed-link { > speed = <1000>; >

Aw: Re: [question] KBUILD_OUTPUT and modules install (with INSTALL_MOD_PATH)

2020-09-15 Thread Frank Wunderlich
> Gesendet: Dienstag, 15. September 2020 um 09:54 Uhr > Von: "Masahiro Yamada" > On Tue, Sep 15, 2020 at 2:42 PM Frank Wunderlich > wrote: > > Yes i exported it before use at beginning of my script [1] and > > modules_install used inside install function [2]. It works with > > build-function [

Re: AW: AW: [PATCH 12/24] getgrent_r.3: Use sizeof() to get buffer size (instead of hardcoding macro name)

2020-09-14 Thread Alejandro Colomar
Hi Walter, On 9/14/20 11:24 AM, Walter Harms wrote: > missunderstanding, > i do not want to discuss sizeof() vs define I did understand, that was point (3). > > in this example you do: > #define BUFLEN 4096 > char buf[BUFLEN]; > getgrent_r(&grp, buf, sizeof(buf), &grpp); > > so there is no re

AW: AW: [PATCH 12/24] getgrent_r.3: Use sizeof() to get buffer size (instead of hardcoding macro name)

2020-09-14 Thread Walter Harms
move BUFLEN Von: Alejandro Colomar [colomar.6@gmail.com] Gesendet: Freitag, 11. September 2020 21:17 An: Walter Harms; mtk.manpa...@gmail.com Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Betreff: Re: AW: [PATCH 12/24] getgrent_r.3: Use sizeof() to get

Re: AW: [PATCH 17/24] get_phys_pages.3: Write 'long' instead of 'long int'

2020-09-11 Thread Alejandro Colomar
On 2020-09-11 15:07, Walter Harms wrote: sys/sysinfo.h:extern long int get_phys_pages (void) for the real world i would say that long int == long but for the same reason i would say what the include says and stay away from discussions. jm2c, wh I think that the man-pages don't need to

Re: AW: [PATCH 12/24] getgrent_r.3: Use sizeof() to get buffer size (instead of hardcoding macro name)

2020-09-11 Thread Alejandro Colomar
Hi Walter, On 2020-09-11 14:50, Walter Harms wrote: BUFLEN should be remove completely or stay jm2c wh Sorry that you weren't CC'd in the conversation we are having about it. You can have a look at it here: https://lore.kernel.org/linux-man/ab12151d-6951-2a36-2fc6-ea7eed538...@gmail.com/T

Aw: [PATCH net-next v5 6/6] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board

2020-09-11 Thread Frank Wunderlich
Tested full series on Bananapi-r2 and r64, results as in v3 Tested-By: Frank Wunderlich regards Frank

AW: [PATCH 04/24] eventfd.2: Use 'PRIxN' macros when printing C99 fixed-width integer types

2020-09-11 Thread Walter Harms
I do not think that this is a good idea. An example should be clear and easy to understand. (e.g. with reduced error handling) These C99 macros are over the top for me. jm2c wh Von: linux-man-ow...@vger.kernel.org [linux-man-ow...@vger.kernel.org] im Auf

AW: [PATCH 22/24] membarrier.2: Note that glibc does not provide a wrapper

2020-09-11 Thread Walter Harms
the groff commands are ducument in man 7 groff .nf No filling or adjusting of output-lines. .fi Fill output lines (for me) a typical use is like this: .nf struct timeval { time_t tv_sec; /* seconds */ suseconds_t tv_usec;/* microseconds */ }; .fi In the top secti

AW: [PATCH 17/24] get_phys_pages.3: Write 'long' instead of 'long int'

2020-09-11 Thread Walter Harms
sys/sysinfo.h:extern long int get_phys_pages (void) for the real world i would say that long int == long but for the same reason i would say what the include says and stay away from discussions. jm2c, wh Von: linux-man-ow...@vger.kernel.org [linux-man-

AW: [PATCH 12/24] getgrent_r.3: Use sizeof() to get buffer size (instead of hardcoding macro name)

2020-09-11 Thread Walter Harms
BUFLEN should be remove completely or stay jm2c wh Von: linux-man-ow...@vger.kernel.org [linux-man-ow...@vger.kernel.org] im Auftrag von Alejandro Colomar [colomar.6@gmail.com] Gesendet: Donnerstag, 10. September 2020 23:13 An: mtk.manpa...@gmail.com

Re: Aw: Re: [PATCH v4 0/4] Split PCIe node to comply with hardware design

2020-09-10 Thread Chuanjia Liu
On Tue, 2020-09-08 at 08:13 +0200, Frank Wunderlich wrote: > Hi, > > i don't see this Patchset in 5.9-rc4 > > is anything missing? > > regards Frank Thanks for ping this mail, mali list consider this patchset is SPAM because of my environmental problems. I have fixed this problem and send the

Aw: Re: [PATCH v4 0/4] Split PCIe node to comply with hardware design

2020-09-07 Thread Frank Wunderlich
Hi, i don't see this Patchset in 5.9-rc4 is anything missing? regards Frank

Aw: [PATCH net-next v3 0/6] net-next: dsa: mt7530: add support for MT7531

2020-09-07 Thread Frank Wunderlich
Hi > Gesendet: Samstag, 05. September 2020 um 10:45 Uhr > Von: "Frank Wunderlich" > similar to bananapi-r2 (mt7530) ... > reverse-mode: > > [ ID] Interval Transfer Bitrate Retr > [ 5] 0.00-10.01 sec 1.05 GBytes 905 Mbits/sec 14533 > sender <<< >

Aw: [PATCH net-next v3 0/6] net-next: dsa: mt7530: add support for MT7531

2020-09-05 Thread Frank Wunderlich
tested full series on Bananapi-r64 (mt7531) running iperf3-server [ ID] Interval Transfer Bitrate Retr [ 5] 0.00-10.00 sec 1.09 GBytes 939 Mbits/sec0 sender [ 5] 0.00-10.01 sec 1.09 GBytes 935 Mbits/sec receiver reverse mode (-R

Aw: Re: [PATCH v5 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-09-04 Thread Frank Wunderlich
Tested-By: Frank Wunderlich regards Frank

Aw: [PATCH] arm: dts: mt7623: add lima related regulator

2020-09-04 Thread Frank Wunderlich
this Patch is now Part of my hdmi-series v6 https://patchwork.kernel.org/project/linux-mediatek/list/?series=343565 so comments please to this series regards Frank

Re: Aw: Re: [PATCH v5 3/7] drm/mediatek: disable tmds on mt2701

2020-08-28 Thread Matthias Brugger
On 28/08/2020 01:46, Chun-Kuang Hu wrote: Hi, Frank: Matthias Brugger 於 2020年8月27日 週四 下午10:28寫道: On 27/08/2020 15:41, Frank Wunderlich wrote: Hi Matthias, any opinions about the dts-changes? they look good to me. maybe series except the tmds-Patch get merged...so i add it only to

  1   2   3   4   5   >