Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-07 Thread Adrian Bunk
On Sat, Jul 07, 2007 at 07:20:12PM +0200, Willy Tarreau wrote: > On Sat, Jul 07, 2007 at 07:01:57PM +0200, Adrian Bunk wrote: > > On Sat, Jul 07, 2007 at 11:45:20AM -0400, Frank Ch. Eigler wrote: >... > > You always have to decide between some debug code and some small bit of > > performance.

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-07 Thread Frank Ch. Eigler
Hi, Adrian - On Sat, Jul 07, 2007 at 07:01:57PM +0200, Adrian Bunk wrote: > [...] > > Things are not so simple. One might not know that one has a > > performance problem until one tries some analysis tools. Rebooting > > into different kernels just to investigate does not work generally [...] >

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-07 Thread Willy Tarreau
On Sat, Jul 07, 2007 at 07:01:57PM +0200, Adrian Bunk wrote: > On Sat, Jul 07, 2007 at 11:45:20AM -0400, Frank Ch. Eigler wrote: > > Adrian Bunk <[EMAIL PROTECTED]> writes: > > > > > [...] > > > profiling = debugging of performance problems > > > > Indeed. > > > > > My words were perhaps a bit

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-07 Thread Adrian Bunk
On Sat, Jul 07, 2007 at 11:45:20AM -0400, Frank Ch. Eigler wrote: > Adrian Bunk <[EMAIL PROTECTED]> writes: > > > [...] > > profiling = debugging of performance problems > > Indeed. > > > My words were perhaps a bit sloppy, but profiling isn't part of > > normal operation and if people use a

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-07 Thread Frank Ch. Eigler
Adrian Bunk <[EMAIL PROTECTED]> writes: > [...] > profiling = debugging of performance problems Indeed. > My words were perhaps a bit sloppy, but profiling isn't part of > normal operation and if people use a separate kernel for such > purposes we don't need infrastructure for reducing

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-07 Thread Frank Ch. Eigler
Adrian Bunk [EMAIL PROTECTED] writes: [...] profiling = debugging of performance problems Indeed. My words were perhaps a bit sloppy, but profiling isn't part of normal operation and if people use a separate kernel for such purposes we don't need infrastructure for reducing performance

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-07 Thread Adrian Bunk
On Sat, Jul 07, 2007 at 11:45:20AM -0400, Frank Ch. Eigler wrote: Adrian Bunk [EMAIL PROTECTED] writes: [...] profiling = debugging of performance problems Indeed. My words were perhaps a bit sloppy, but profiling isn't part of normal operation and if people use a separate kernel

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-07 Thread Willy Tarreau
On Sat, Jul 07, 2007 at 07:01:57PM +0200, Adrian Bunk wrote: On Sat, Jul 07, 2007 at 11:45:20AM -0400, Frank Ch. Eigler wrote: Adrian Bunk [EMAIL PROTECTED] writes: [...] profiling = debugging of performance problems Indeed. My words were perhaps a bit sloppy, but profiling

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-07 Thread Frank Ch. Eigler
Hi, Adrian - On Sat, Jul 07, 2007 at 07:01:57PM +0200, Adrian Bunk wrote: [...] Things are not so simple. One might not know that one has a performance problem until one tries some analysis tools. Rebooting into different kernels just to investigate does not work generally [...] I'm

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-07 Thread Adrian Bunk
On Sat, Jul 07, 2007 at 07:20:12PM +0200, Willy Tarreau wrote: On Sat, Jul 07, 2007 at 07:01:57PM +0200, Adrian Bunk wrote: On Sat, Jul 07, 2007 at 11:45:20AM -0400, Frank Ch. Eigler wrote: ... You always have to decide between some debug code and some small bit of performance. There's a

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Willy Tarreau
On Sat, Jul 07, 2007 at 06:03:07AM +0200, Adrian Bunk wrote: > On Fri, Jul 06, 2007 at 10:35:11PM -0400, Mathieu Desnoyers wrote: > > * Adrian Bunk ([EMAIL PROTECTED]) wrote: > > > On Fri, Jul 06, 2007 at 07:43:15PM -0400, Mathieu Desnoyers wrote: > > > > * Adrian Bunk ([EMAIL PROTECTED]) wrote: >

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Adrian Bunk
On Fri, Jul 06, 2007 at 10:35:11PM -0400, Mathieu Desnoyers wrote: > * Adrian Bunk ([EMAIL PROTECTED]) wrote: > > On Fri, Jul 06, 2007 at 07:43:15PM -0400, Mathieu Desnoyers wrote: > > > * Adrian Bunk ([EMAIL PROTECTED]) wrote: > > > > On Fri, Jul 06, 2007 at 06:14:10PM -0400, Chuck Ebbert wrote:

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Mathieu Desnoyers
* Adrian Bunk ([EMAIL PROTECTED]) wrote: > On Fri, Jul 06, 2007 at 07:43:15PM -0400, Mathieu Desnoyers wrote: > > * Adrian Bunk ([EMAIL PROTECTED]) wrote: > > > On Fri, Jul 06, 2007 at 06:14:10PM -0400, Chuck Ebbert wrote: > > > > On 07/06/2007 07:44 AM, Andi Kleen wrote: > > > > > I think the

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Adrian Bunk
On Fri, Jul 06, 2007 at 07:43:15PM -0400, Mathieu Desnoyers wrote: > * Adrian Bunk ([EMAIL PROTECTED]) wrote: > > On Fri, Jul 06, 2007 at 06:14:10PM -0400, Chuck Ebbert wrote: > > > On 07/06/2007 07:44 AM, Andi Kleen wrote: > > > > I think the optimization is a good idea, although i dislike it > >

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Adrian Bunk
On Fri, Jul 06, 2007 at 07:38:27PM -0400, Dave Jones wrote: > On Sat, Jul 07, 2007 at 01:28:43AM +0200, Adrian Bunk wrote: > > > Only if you want to squeeze the last bit of performance out of > > _debugging_ functionality. > > > > You avoid all the pain if you simply don't use debugging

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Mathieu Desnoyers
* Adrian Bunk ([EMAIL PROTECTED]) wrote: > On Fri, Jul 06, 2007 at 06:14:10PM -0400, Chuck Ebbert wrote: > > On 07/06/2007 07:44 AM, Andi Kleen wrote: > > > I think the optimization is a good idea, although i dislike it > > > that it is complicated for the dynamic markers. If it was just > > >

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Dave Jones
On Sat, Jul 07, 2007 at 01:28:43AM +0200, Adrian Bunk wrote: > Only if you want to squeeze the last bit of performance out of > _debugging_ functionality. > > You avoid all the pain if you simply don't use debugging functionality > on production systems. I think you're mixing up profiling

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Adrian Bunk
On Fri, Jul 06, 2007 at 06:14:10PM -0400, Chuck Ebbert wrote: > On 07/06/2007 07:44 AM, Andi Kleen wrote: > > I think the optimization is a good idea, although i dislike it > > that it is complicated for the dynamic markers. If it was just > > static it would be much simpler. > > Another thing to

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Chuck Ebbert
On 07/06/2007 07:44 AM, Andi Kleen wrote: > I think the optimization is a good idea, although i dislike it > that it is complicated for the dynamic markers. If it was just > static it would be much simpler. > Another thing to consider is that there might be hundreds of these probes/tracepoints

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Adrian Bunk
On Thu, Jul 05, 2007 at 11:46:44AM -0400, Mathieu Desnoyers wrote: > * Bodo Eggert ([EMAIL PROTECTED]) wrote: > > Andi Kleen <[EMAIL PROTECTED]> wrote: > > > Alexey Dobriyan <[EMAIL PROTECTED]> writes: > > >> On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: > > > > >> > Use

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Mathieu Desnoyers
* Li, Tong N ([EMAIL PROTECTED]) wrote: > > I found that memory latency is difficult to measure in modern x86 > > CPUs because they have very clever prefetchers that can often > > outwit benchmarks. > > A pointer-chasing program that accesses a random sequence of addresses > usually can produce a

RE: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Li, Tong N
> I found that memory latency is difficult to measure in modern x86 > CPUs because they have very clever prefetchers that can often > outwit benchmarks. A pointer-chasing program that accesses a random sequence of addresses usually can produce a good estimate on memory latency. Also, prefetching

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Andi Kleen
On Fri, Jul 06, 2007 at 10:50:30AM -0700, Li, Tong N wrote: > > Also cache misses in this situation tend to be much more than 48 > cycles > > (even an K8 with integrated memory controller with fastest DIMMs is > > slower than that) Mathieu probably measured an L2 miss, not a load

RE: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Li, Tong N
> Also cache misses in this situation tend to be much more than 48 cycles > (even an K8 with integrated memory controller with fastest DIMMs is > slower than that) Mathieu probably measured an L2 miss, not a load from > RAM. > Load from RAM can be hundreds of ns in the worst case. > The 48

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Andi Kleen
Andrew Morton <[EMAIL PROTECTED]> writes: > Is that 48 cycles measured when the target of the read is in L1 cache, as > it would be in any situation which we actually care about? I guess so... The normal situation is big database or other bloated software runs; clears all the dcaches, then

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Andi Kleen
Andrew Morton [EMAIL PROTECTED] writes: Is that 48 cycles measured when the target of the read is in L1 cache, as it would be in any situation which we actually care about? I guess so... The normal situation is big database or other bloated software runs; clears all the dcaches, then enters

RE: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Li, Tong N
Also cache misses in this situation tend to be much more than 48 cycles (even an K8 with integrated memory controller with fastest DIMMs is slower than that) Mathieu probably measured an L2 miss, not a load from RAM. Load from RAM can be hundreds of ns in the worst case. The 48 cycles

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Andi Kleen
On Fri, Jul 06, 2007 at 10:50:30AM -0700, Li, Tong N wrote: Also cache misses in this situation tend to be much more than 48 cycles (even an K8 with integrated memory controller with fastest DIMMs is slower than that) Mathieu probably measured an L2 miss, not a load

RE: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Li, Tong N
I found that memory latency is difficult to measure in modern x86 CPUs because they have very clever prefetchers that can often outwit benchmarks. A pointer-chasing program that accesses a random sequence of addresses usually can produce a good estimate on memory latency. Also, prefetching can

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Mathieu Desnoyers
* Li, Tong N ([EMAIL PROTECTED]) wrote: I found that memory latency is difficult to measure in modern x86 CPUs because they have very clever prefetchers that can often outwit benchmarks. A pointer-chasing program that accesses a random sequence of addresses usually can produce a good

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Adrian Bunk
On Thu, Jul 05, 2007 at 11:46:44AM -0400, Mathieu Desnoyers wrote: * Bodo Eggert ([EMAIL PROTECTED]) wrote: Andi Kleen [EMAIL PROTECTED] wrote: Alexey Dobriyan [EMAIL PROTECTED] writes: On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: Use immediate values with

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Chuck Ebbert
On 07/06/2007 07:44 AM, Andi Kleen wrote: I think the optimization is a good idea, although i dislike it that it is complicated for the dynamic markers. If it was just static it would be much simpler. Another thing to consider is that there might be hundreds of these probes/tracepoints

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Adrian Bunk
On Fri, Jul 06, 2007 at 06:14:10PM -0400, Chuck Ebbert wrote: On 07/06/2007 07:44 AM, Andi Kleen wrote: I think the optimization is a good idea, although i dislike it that it is complicated for the dynamic markers. If it was just static it would be much simpler. Another thing to consider

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Dave Jones
On Sat, Jul 07, 2007 at 01:28:43AM +0200, Adrian Bunk wrote: Only if you want to squeeze the last bit of performance out of _debugging_ functionality. You avoid all the pain if you simply don't use debugging functionality on production systems. I think you're mixing up profiling and

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Mathieu Desnoyers
* Adrian Bunk ([EMAIL PROTECTED]) wrote: On Fri, Jul 06, 2007 at 06:14:10PM -0400, Chuck Ebbert wrote: On 07/06/2007 07:44 AM, Andi Kleen wrote: I think the optimization is a good idea, although i dislike it that it is complicated for the dynamic markers. If it was just static it would

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Adrian Bunk
On Fri, Jul 06, 2007 at 07:38:27PM -0400, Dave Jones wrote: On Sat, Jul 07, 2007 at 01:28:43AM +0200, Adrian Bunk wrote: Only if you want to squeeze the last bit of performance out of _debugging_ functionality. You avoid all the pain if you simply don't use debugging functionality

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Adrian Bunk
On Fri, Jul 06, 2007 at 07:43:15PM -0400, Mathieu Desnoyers wrote: * Adrian Bunk ([EMAIL PROTECTED]) wrote: On Fri, Jul 06, 2007 at 06:14:10PM -0400, Chuck Ebbert wrote: On 07/06/2007 07:44 AM, Andi Kleen wrote: I think the optimization is a good idea, although i dislike it that it

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Mathieu Desnoyers
* Adrian Bunk ([EMAIL PROTECTED]) wrote: On Fri, Jul 06, 2007 at 07:43:15PM -0400, Mathieu Desnoyers wrote: * Adrian Bunk ([EMAIL PROTECTED]) wrote: On Fri, Jul 06, 2007 at 06:14:10PM -0400, Chuck Ebbert wrote: On 07/06/2007 07:44 AM, Andi Kleen wrote: I think the optimization is a

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Adrian Bunk
On Fri, Jul 06, 2007 at 10:35:11PM -0400, Mathieu Desnoyers wrote: * Adrian Bunk ([EMAIL PROTECTED]) wrote: On Fri, Jul 06, 2007 at 07:43:15PM -0400, Mathieu Desnoyers wrote: * Adrian Bunk ([EMAIL PROTECTED]) wrote: On Fri, Jul 06, 2007 at 06:14:10PM -0400, Chuck Ebbert wrote: On

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Willy Tarreau
On Sat, Jul 07, 2007 at 06:03:07AM +0200, Adrian Bunk wrote: On Fri, Jul 06, 2007 at 10:35:11PM -0400, Mathieu Desnoyers wrote: * Adrian Bunk ([EMAIL PROTECTED]) wrote: On Fri, Jul 06, 2007 at 07:43:15PM -0400, Mathieu Desnoyers wrote: * Adrian Bunk ([EMAIL PROTECTED]) wrote: On

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-05 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: > On Thu, 5 Jul 2007 13:21:20 -0700 > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > Please prepare and maintain a short document which describes the > > justification for making all these changes to the kernel. > > oh, you did. It's there in the

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-05 Thread Andrew Morton
On Thu, 5 Jul 2007 13:21:20 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > Please prepare and maintain a short document which describes the > justification for making all these changes to the kernel. oh, you did. It's there in the add-kconfig-stuff patch. - To unsubscribe from this list: send

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-05 Thread Andrew Morton
On Tue, 3 Jul 2007 14:57:48 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > Measuring the overall impact on the system of this single modification > results in the difference brought by one site within the standard > deviation of the normal samples. It will become significant when the >

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-05 Thread Mathieu Desnoyers
* Bodo Eggert ([EMAIL PROTECTED]) wrote: > Andi Kleen <[EMAIL PROTECTED]> wrote: > > Alexey Dobriyan <[EMAIL PROTECTED]> writes: > >> On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: > > >> > Use immediate values with lower d-cache hit in optimized version as a > >> > condition

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-05 Thread Bodo Eggert
Andi Kleen <[EMAIL PROTECTED]> wrote: > Alexey Dobriyan <[EMAIL PROTECTED]> writes: >> On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: >> > Use immediate values with lower d-cache hit in optimized version as a >> > condition for scheduler profiling call. >> >> I think it's

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-05 Thread Bodo Eggert
Andi Kleen [EMAIL PROTECTED] wrote: Alexey Dobriyan [EMAIL PROTECTED] writes: On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: Use immediate values with lower d-cache hit in optimized version as a condition for scheduler profiling call. I think it's better to put

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-05 Thread Mathieu Desnoyers
* Bodo Eggert ([EMAIL PROTECTED]) wrote: Andi Kleen [EMAIL PROTECTED] wrote: Alexey Dobriyan [EMAIL PROTECTED] writes: On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: Use immediate values with lower d-cache hit in optimized version as a condition for scheduler

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-05 Thread Andrew Morton
On Tue, 3 Jul 2007 14:57:48 -0400 Mathieu Desnoyers [EMAIL PROTECTED] wrote: Measuring the overall impact on the system of this single modification results in the difference brought by one site within the standard deviation of the normal samples. It will become significant when the number of

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-05 Thread Andrew Morton
On Thu, 5 Jul 2007 13:21:20 -0700 Andrew Morton [EMAIL PROTECTED] wrote: Please prepare and maintain a short document which describes the justification for making all these changes to the kernel. oh, you did. It's there in the add-kconfig-stuff patch. - To unsubscribe from this list: send the

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-05 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: On Thu, 5 Jul 2007 13:21:20 -0700 Andrew Morton [EMAIL PROTECTED] wrote: Please prepare and maintain a short document which describes the justification for making all these changes to the kernel. oh, you did. It's there in the

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-04 Thread Andi Kleen
Alexey Dobriyan <[EMAIL PROTECTED]> writes: > On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: > > Use immediate values with lower d-cache hit in optimized version as a > > condition for scheduler profiling call. > > I think it's better to put profile.c under CONFIG_PROFILING

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-04 Thread Alexey Dobriyan
On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: > Use immediate values with lower d-cache hit in optimized version as a > condition for scheduler profiling call. I think it's better to put profile.c under CONFIG_PROFILING as _expected_, so CONFIG_PROFILING=n users won't get any

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-04 Thread Alexey Dobriyan
On Tue, Jul 03, 2007 at 02:57:48PM -0400, Mathieu Desnoyers wrote: > * Alexey Dobriyan ([EMAIL PROTECTED]) wrote: > > On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: > > > Use immediate values with lower d-cache hit in optimized version as a > > > condition for scheduler

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-04 Thread Adrian Bunk
On Tue, Jul 03, 2007 at 02:57:48PM -0400, Mathieu Desnoyers wrote: > * Alexey Dobriyan ([EMAIL PROTECTED]) wrote: > > On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: > > > Use immediate values with lower d-cache hit in optimized version as a > > > condition for scheduler

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-04 Thread Adrian Bunk
On Tue, Jul 03, 2007 at 02:57:48PM -0400, Mathieu Desnoyers wrote: * Alexey Dobriyan ([EMAIL PROTECTED]) wrote: On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: Use immediate values with lower d-cache hit in optimized version as a condition for scheduler profiling call.

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-04 Thread Alexey Dobriyan
On Tue, Jul 03, 2007 at 02:57:48PM -0400, Mathieu Desnoyers wrote: * Alexey Dobriyan ([EMAIL PROTECTED]) wrote: On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: Use immediate values with lower d-cache hit in optimized version as a condition for scheduler profiling call.

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-04 Thread Alexey Dobriyan
On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: Use immediate values with lower d-cache hit in optimized version as a condition for scheduler profiling call. I think it's better to put profile.c under CONFIG_PROFILING as _expected_, so CONFIG_PROFILING=n users won't get any

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-04 Thread Andi Kleen
Alexey Dobriyan [EMAIL PROTECTED] writes: On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: Use immediate values with lower d-cache hit in optimized version as a condition for scheduler profiling call. I think it's better to put profile.c under CONFIG_PROFILING as

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-03 Thread Mathieu Desnoyers
* Alexey Dobriyan ([EMAIL PROTECTED]) wrote: > On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: > > Use immediate values with lower d-cache hit in optimized version as a > > condition for scheduler profiling call. > > How much difference in performance do you see? > Hi Alexey,

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-03 Thread Alexey Dobriyan
On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: > Use immediate values with lower d-cache hit in optimized version as a > condition for scheduler profiling call. How much difference in performance do you see? - To unsubscribe from this list: send the line "unsubscribe

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-03 Thread Alexey Dobriyan
On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: Use immediate values with lower d-cache hit in optimized version as a condition for scheduler profiling call. How much difference in performance do you see? - To unsubscribe from this list: send the line unsubscribe

Re: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-03 Thread Mathieu Desnoyers
* Alexey Dobriyan ([EMAIL PROTECTED]) wrote: On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote: Use immediate values with lower d-cache hit in optimized version as a condition for scheduler profiling call. How much difference in performance do you see? Hi Alexey, Please