Re: [PATCH] x86: fix cpu-hotplug regression

2007-11-12 Thread Andreas Herrmann
On Fri, Nov 09, 2007 at 12:16:34PM -0800, Andrew Morton wrote: > On Wed, 7 Nov 2007 23:15:38 +0900 > "Akinobu Mita" <[EMAIL PROTECTED]> wrote: > > > > [PATCH] x86: fix cpu hotplug regression (don't call mce_create_device on > > > CPU_UP_PREPARE) > > > > > > Fix regression introduced with

Re: [PATCH] x86: fix cpu-hotplug regression

2007-11-12 Thread Andreas Herrmann
On Fri, Nov 09, 2007 at 12:16:34PM -0800, Andrew Morton wrote: On Wed, 7 Nov 2007 23:15:38 +0900 Akinobu Mita [EMAIL PROTECTED] wrote: [PATCH] x86: fix cpu hotplug regression (don't call mce_create_device on CPU_UP_PREPARE) Fix regression introduced with

Re: [PATCH] x86: fix cpu-hotplug regression

2007-11-09 Thread Andrew Morton
On Wed, 7 Nov 2007 23:15:38 +0900 "Akinobu Mita" <[EMAIL PROTECTED]> wrote: > > [PATCH] x86: fix cpu hotplug regression (don't call mce_create_device on > > CPU_UP_PREPARE) > > > > Fix regression introduced with d435d862baca3e25e5eec236762a43251b1e7ffc > > ("cpu hotplug: mce: fix cpu hotplug

Re: [PATCH] x86: fix cpu-hotplug regression

2007-11-09 Thread Andrew Morton
On Wed, 7 Nov 2007 23:15:38 +0900 Akinobu Mita [EMAIL PROTECTED] wrote: [PATCH] x86: fix cpu hotplug regression (don't call mce_create_device on CPU_UP_PREPARE) Fix regression introduced with d435d862baca3e25e5eec236762a43251b1e7ffc (cpu hotplug: mce: fix cpu hotplug error handling).

Re: [PATCH] x86: fix cpu-hotplug regression

2007-11-07 Thread Akinobu Mita
> [PATCH] x86: fix cpu hotplug regression (don't call mce_create_device on > CPU_UP_PREPARE) > > Fix regression introduced with d435d862baca3e25e5eec236762a43251b1e7ffc > ("cpu hotplug: mce: fix cpu hotplug error handling"). > > For CPUs not brought up during boot (using maxcpus and

Re: [PATCH] x86: fix cpu-hotplug regression

2007-11-07 Thread Andreas Herrmann
On Wed, Nov 07, 2007 at 03:35:43AM +0100, Andi Kleen wrote: > On Wednesday 07 November 2007 02:12, Andreas Herrmann wrote: > > > In cases where not all CPUs are brought up during > > boot (e.g. using maxcpus and additional_cpus parameters) > > mce_cpu_callback now returns NOTFIY_BAD because > >

Re: [PATCH] x86: fix cpu-hotplug regression

2007-11-07 Thread Akinobu Mita
[PATCH] x86: fix cpu hotplug regression (don't call mce_create_device on CPU_UP_PREPARE) Fix regression introduced with d435d862baca3e25e5eec236762a43251b1e7ffc (cpu hotplug: mce: fix cpu hotplug error handling). For CPUs not brought up during boot (using maxcpus and additional_cpus

Re: [PATCH] x86: fix cpu-hotplug regression

2007-11-07 Thread Andreas Herrmann
On Wed, Nov 07, 2007 at 03:35:43AM +0100, Andi Kleen wrote: On Wednesday 07 November 2007 02:12, Andreas Herrmann wrote: In cases where not all CPUs are brought up during boot (e.g. using maxcpus and additional_cpus parameters) mce_cpu_callback now returns NOTFIY_BAD because for such

Re: [PATCH] x86: fix cpu-hotplug regression

2007-11-06 Thread Andi Kleen
On Wednesday 07 November 2007 02:12, Andreas Herrmann wrote: > In cases where not all CPUs are brought up during > boot (e.g. using maxcpus and additional_cpus parameters) > mce_cpu_callback now returns NOTFIY_BAD because > for such CPUs cpu_data is not completely filled when > the notifier is

Re: [PATCH] x86: fix cpu-hotplug regression

2007-11-06 Thread Andi Kleen
On Wednesday 07 November 2007 02:12, Andreas Herrmann wrote: In cases where not all CPUs are brought up during boot (e.g. using maxcpus and additional_cpus parameters) mce_cpu_callback now returns NOTFIY_BAD because for such CPUs cpu_data is not completely filled when the notifier is called.