Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-18 Thread Daniel Wagner
On 12/18/2015 02:50 PM, pi3orama wrote: >> Could it be that $(srcdir) somehow is not correct? I exchanged >> >>feature_dir := $(srctree)/tools/build/feature >> to >>feature_dir := /home/wagi/src/linux/tools/build/feature >> > > Can you remember the patch set I skipped? > >

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-18 Thread pi3orama
发自我的 iPhone > 在 2015年12月18日,下午8:55,Daniel Wagner 写道: > >> On 12/18/2015 12:03 PM, Wangnan (F) wrote: >> That's good. This is not a magic. > > That is what you say! :) > >> I guess something in your top makefile >> causes this feature check failure. I sent a patch on feature checker to >>

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-18 Thread Daniel Wagner
On 12/18/2015 12:03 PM, Wangnan (F) wrote: > That's good. This is not a magic. That is what you say! :) > I guess something in your top makefile > causes this feature check failure. I sent a patch on feature checker to > you. > It will appear as [1] soon. Could you please apply it and try again?

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-18 Thread Wangnan (F)
On 2015/12/18 16:49, Daniel Wagner wrote: On 12/18/2015 04:04 AM, Wangnan (F) wrote: On 2015/12/17 21:46, Daniel Wagner wrote: On 12/17/2015 11:09 AM, Wangnan (F) wrote: On 2015/12/17 16:29, Daniel Wagner wrote: On 12/17/2015 08:03 AM, Daniel Wagner wrote: Patch number 2 didn't apply

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-18 Thread Daniel Wagner
On 12/18/2015 04:04 AM, Wangnan (F) wrote: > On 2015/12/17 21:46, Daniel Wagner wrote: >> On 12/17/2015 11:09 AM, Wangnan (F) wrote: >>> On 2015/12/17 16:29, Daniel Wagner wrote: On 12/17/2015 08:03 AM, Daniel Wagner wrote: Patch number 2 didn't apply cleanly. >>> When you see this,

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-18 Thread Daniel Wagner
On 12/18/2015 04:04 AM, Wangnan (F) wrote: > On 2015/12/17 21:46, Daniel Wagner wrote: >> On 12/17/2015 11:09 AM, Wangnan (F) wrote: >>> On 2015/12/17 16:29, Daniel Wagner wrote: On 12/17/2015 08:03 AM, Daniel Wagner wrote: Patch number 2 didn't apply cleanly. >>> When you see this,

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-18 Thread Wangnan (F)
On 2015/12/18 16:49, Daniel Wagner wrote: On 12/18/2015 04:04 AM, Wangnan (F) wrote: On 2015/12/17 21:46, Daniel Wagner wrote: On 12/17/2015 11:09 AM, Wangnan (F) wrote: On 2015/12/17 16:29, Daniel Wagner wrote: On 12/17/2015 08:03 AM, Daniel Wagner wrote: Patch number 2 didn't apply

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-18 Thread Daniel Wagner
On 12/18/2015 12:03 PM, Wangnan (F) wrote: > That's good. This is not a magic. That is what you say! :) > I guess something in your top makefile > causes this feature check failure. I sent a patch on feature checker to > you. > It will appear as [1] soon. Could you please apply it and try again?

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-18 Thread Daniel Wagner
On 12/18/2015 02:50 PM, pi3orama wrote: >> Could it be that $(srcdir) somehow is not correct? I exchanged >> >>feature_dir := $(srctree)/tools/build/feature >> to >>feature_dir := /home/wagi/src/linux/tools/build/feature >> > > Can you remember the patch set I skipped? > >

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-18 Thread pi3orama
发自我的 iPhone > 在 2015年12月18日,下午8:55,Daniel Wagner 写道: > >> On 12/18/2015 12:03 PM, Wangnan (F) wrote: >> That's good. This is not a magic. > > That is what you say! :) > >> I guess something in your top makefile >> causes this feature check failure. I sent a patch

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-17 Thread Wangnan (F)
On 2015/12/17 21:46, Daniel Wagner wrote: On 12/17/2015 11:09 AM, Wangnan (F) wrote: On 2015/12/17 16:29, Daniel Wagner wrote: On 12/17/2015 08:03 AM, Daniel Wagner wrote: Patch number 2 didn't apply cleanly. Because I have another patch in my local tree which also modifis bpf Makefile:

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-17 Thread Daniel Wagner
On 12/17/2015 11:09 AM, Wangnan (F) wrote: > On 2015/12/17 16:29, Daniel Wagner wrote: >> On 12/17/2015 08:03 AM, Daniel Wagner wrote: >> Patch number 2 didn't apply cleanly. > > Because I have another patch in my local tree which also modifis bpf > Makefile: > >

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-17 Thread Wangnan (F)
On 2015/12/17 16:29, Daniel Wagner wrote: On 12/17/2015 08:03 AM, Daniel Wagner wrote: On 12/17/2015 07:51 AM, Wangnan (F) wrote: On 2015/12/17 14:38, Daniel Wagner wrote: On 12/17/2015 06:23 AM, Wang Nan wrote: Since we already have libbpf in tools/lib, we don't need to maintain another

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-17 Thread Daniel Wagner
On 12/17/2015 08:03 AM, Daniel Wagner wrote: > On 12/17/2015 07:51 AM, Wangnan (F) wrote: >> On 2015/12/17 14:38, Daniel Wagner wrote: >>> On 12/17/2015 06:23 AM, Wang Nan wrote: Since we already have libbpf in tools/lib, we don't need to maintain another bpf loader and operations

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-17 Thread Daniel Wagner
On 12/17/2015 08:03 AM, Daniel Wagner wrote: > On 12/17/2015 07:51 AM, Wangnan (F) wrote: >> On 2015/12/17 14:38, Daniel Wagner wrote: >>> On 12/17/2015 06:23 AM, Wang Nan wrote: Since we already have libbpf in tools/lib, we don't need to maintain another bpf loader and operations

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-17 Thread Wangnan (F)
On 2015/12/17 16:29, Daniel Wagner wrote: On 12/17/2015 08:03 AM, Daniel Wagner wrote: On 12/17/2015 07:51 AM, Wangnan (F) wrote: On 2015/12/17 14:38, Daniel Wagner wrote: On 12/17/2015 06:23 AM, Wang Nan wrote: Since we already have libbpf in tools/lib, we don't need to maintain another

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-17 Thread Daniel Wagner
On 12/17/2015 11:09 AM, Wangnan (F) wrote: > On 2015/12/17 16:29, Daniel Wagner wrote: >> On 12/17/2015 08:03 AM, Daniel Wagner wrote: >> Patch number 2 didn't apply cleanly. > > Because I have another patch in my local tree which also modifis bpf > Makefile: > >

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-17 Thread Wangnan (F)
On 2015/12/17 21:46, Daniel Wagner wrote: On 12/17/2015 11:09 AM, Wangnan (F) wrote: On 2015/12/17 16:29, Daniel Wagner wrote: On 12/17/2015 08:03 AM, Daniel Wagner wrote: Patch number 2 didn't apply cleanly. Because I have another patch in my local tree which also modifis bpf Makefile:

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-16 Thread Daniel Wagner
On 12/17/2015 07:51 AM, Wangnan (F) wrote: > On 2015/12/17 14:38, Daniel Wagner wrote: >> On 12/17/2015 06:23 AM, Wang Nan wrote: >>> Since we already have libbpf in tools/lib, we don't need to maintain >>> another bpf loader and operations library in samples/bpf. >>> >>> In patchset: >>> >>>

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-16 Thread Wangnan (F)
On 2015/12/17 14:38, Daniel Wagner wrote: Hi, On 12/17/2015 06:23 AM, Wang Nan wrote: Since we already have libbpf in tools/lib, we don't need to maintain another bpf loader and operations library in samples/bpf. In patchset: Patch 1/10 - 7/10 improves libbpf, add missing features to

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-16 Thread Daniel Wagner
Hi, On 12/17/2015 06:23 AM, Wang Nan wrote: > Since we already have libbpf in tools/lib, we don't need to maintain > another bpf loader and operations library in samples/bpf. > > In patchset: > > Patch 1/10 - 7/10 improves libbpf, add missing features to support > samples, > > Patch 8/10

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-16 Thread Daniel Wagner
Hi, On 12/17/2015 06:23 AM, Wang Nan wrote: > Since we already have libbpf in tools/lib, we don't need to maintain > another bpf loader and operations library in samples/bpf. > > In patchset: > > Patch 1/10 - 7/10 improves libbpf, add missing features to support > samples, > > Patch 8/10

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-16 Thread Wangnan (F)
On 2015/12/17 14:38, Daniel Wagner wrote: Hi, On 12/17/2015 06:23 AM, Wang Nan wrote: Since we already have libbpf in tools/lib, we don't need to maintain another bpf loader and operations library in samples/bpf. In patchset: Patch 1/10 - 7/10 improves libbpf, add missing features to

Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations

2015-12-16 Thread Daniel Wagner
On 12/17/2015 07:51 AM, Wangnan (F) wrote: > On 2015/12/17 14:38, Daniel Wagner wrote: >> On 12/17/2015 06:23 AM, Wang Nan wrote: >>> Since we already have libbpf in tools/lib, we don't need to maintain >>> another bpf loader and operations library in samples/bpf. >>> >>> In patchset: >>> >>>