Re: [PATCH 04/27] perf tools: Move programs check into config/Makefile

2013-04-01 Thread Namhyung Kim
On Tue, 2 Apr 2013 00:27:03 +0200, Jiri Olsa wrote: > On Tue, Apr 02, 2013 at 07:09:50AM +0900, Namhyung Kim wrote: >> 2013-04-01 (월), 21:18 +0200, Jiri Olsa: >> > Moving programs check into config/Makefile. >> >> [SNIP] >> >> > +RM = rm -f >> > +MKDIR = mkdir >> > +FIND= find >> >

Re: [PATCH 04/27] perf tools: Move programs check into config/Makefile

2013-04-01 Thread Jiri Olsa
On Tue, Apr 02, 2013 at 07:09:50AM +0900, Namhyung Kim wrote: > 2013-04-01 (월), 21:18 +0200, Jiri Olsa: > > Moving programs check into config/Makefile. > > [SNIP] > > > +RM = rm -f > > +MKDIR = mkdir > > +FIND= find > > +INSTALL = install > > +FLEX= flex > > +BISON = bison > >

Re: [PATCH 04/27] perf tools: Move programs check into config/Makefile

2013-04-01 Thread Namhyung Kim
2013-04-01 (월), 21:18 +0200, Jiri Olsa: > Moving programs check into config/Makefile. [SNIP] > +RM = rm -f > +MKDIR = mkdir > +FIND= find > +INSTALL = install > +FLEX= flex > +BISON = bison > +STRIP ?= strip Why does STRIP use "?=" form? I know you just moved the line, but

Re: [PATCH 04/27] perf tools: Move programs check into config/Makefile

2013-04-01 Thread Namhyung Kim
2013-04-01 (월), 21:18 +0200, Jiri Olsa: Moving programs check into config/Makefile. [SNIP] +RM = rm -f +MKDIR = mkdir +FIND= find +INSTALL = install +FLEX= flex +BISON = bison +STRIP ?= strip Why does STRIP use ?= form? I know you just moved the line, but AFAICS it

Re: [PATCH 04/27] perf tools: Move programs check into config/Makefile

2013-04-01 Thread Jiri Olsa
On Tue, Apr 02, 2013 at 07:09:50AM +0900, Namhyung Kim wrote: 2013-04-01 (월), 21:18 +0200, Jiri Olsa: Moving programs check into config/Makefile. [SNIP] +RM = rm -f +MKDIR = mkdir +FIND= find +INSTALL = install +FLEX= flex +BISON = bison +STRIP ?= strip

Re: [PATCH 04/27] perf tools: Move programs check into config/Makefile

2013-04-01 Thread Namhyung Kim
On Tue, 2 Apr 2013 00:27:03 +0200, Jiri Olsa wrote: On Tue, Apr 02, 2013 at 07:09:50AM +0900, Namhyung Kim wrote: 2013-04-01 (월), 21:18 +0200, Jiri Olsa: Moving programs check into config/Makefile. [SNIP] +RM = rm -f +MKDIR = mkdir +FIND= find +INSTALL = install +FLEX