Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-07 Thread Stephane Eranian
On Tue, Feb 6, 2018 at 1:35 AM, Jiri Olsa wrote: > On Mon, Feb 05, 2018 at 06:51:05PM -0800, Stephane Eranian wrote: > > SNIP > >> > >> Looks like this is working then, great! >> >> Now, related to profiling and reporting. There is still an issue I >> keep running into >> with

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-07 Thread Stephane Eranian
On Tue, Feb 6, 2018 at 1:35 AM, Jiri Olsa wrote: > On Mon, Feb 05, 2018 at 06:51:05PM -0800, Stephane Eranian wrote: > > SNIP > >> > >> Looks like this is working then, great! >> >> Now, related to profiling and reporting. There is still an issue I >> keep running into >> with grouping. I want to

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-06 Thread Jiri Olsa
On Mon, Feb 05, 2018 at 06:51:05PM -0800, Stephane Eranian wrote: SNIP > > > Looks like this is working then, great! > > Now, related to profiling and reporting. There is still an issue I > keep running into > with grouping. I want to sample on N events, where N > number of hw counters. > Yet

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-06 Thread Jiri Olsa
On Mon, Feb 05, 2018 at 06:51:05PM -0800, Stephane Eranian wrote: SNIP > > > Looks like this is working then, great! > > Now, related to profiling and reporting. There is still an issue I > keep running into > with grouping. I want to sample on N events, where N > number of hw counters. > Yet

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-05 Thread Stephane Eranian
On Mon, Feb 5, 2018 at 1:13 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Feb 05, 2018 at 12:58:16PM -0800, Stephane Eranian escreveu: >> On Mon, Feb 5, 2018 at 7:17 AM, Jiri Olsa wrote: >> > On Fri, Feb 02, 2018 at 01:04:34PM -0800, Stephane Eranian wrote: >>

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-05 Thread Stephane Eranian
On Mon, Feb 5, 2018 at 1:13 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Feb 05, 2018 at 12:58:16PM -0800, Stephane Eranian escreveu: >> On Mon, Feb 5, 2018 at 7:17 AM, Jiri Olsa wrote: >> > On Fri, Feb 02, 2018 at 01:04:34PM -0800, Stephane Eranian wrote: >> >> On Fri, Feb 2, 2018 at 12:40 PM,

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-05 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 05, 2018 at 12:58:16PM -0800, Stephane Eranian escreveu: > On Mon, Feb 5, 2018 at 7:17 AM, Jiri Olsa wrote: > > On Fri, Feb 02, 2018 at 01:04:34PM -0800, Stephane Eranian wrote: > >> On Fri, Feb 2, 2018 at 12:40 PM, Arnaldo Carvalho de Melo > >>

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-05 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 05, 2018 at 12:58:16PM -0800, Stephane Eranian escreveu: > On Mon, Feb 5, 2018 at 7:17 AM, Jiri Olsa wrote: > > On Fri, Feb 02, 2018 at 01:04:34PM -0800, Stephane Eranian wrote: > >> On Fri, Feb 2, 2018 at 12:40 PM, Arnaldo Carvalho de Melo > >> wrote: > >> > Em Fri, Feb 02, 2018 at

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-05 Thread Stephane Eranian
On Mon, Feb 5, 2018 at 7:17 AM, Jiri Olsa wrote: > On Fri, Feb 02, 2018 at 01:04:34PM -0800, Stephane Eranian wrote: >> On Fri, Feb 2, 2018 at 12:40 PM, Arnaldo Carvalho de Melo >> wrote: >> > Em Fri, Feb 02, 2018 at 05:28:49PM -0300, Arnaldo Carvalho de Melo

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-05 Thread Stephane Eranian
On Mon, Feb 5, 2018 at 7:17 AM, Jiri Olsa wrote: > On Fri, Feb 02, 2018 at 01:04:34PM -0800, Stephane Eranian wrote: >> On Fri, Feb 2, 2018 at 12:40 PM, Arnaldo Carvalho de Melo >> wrote: >> > Em Fri, Feb 02, 2018 at 05:28:49PM -0300, Arnaldo Carvalho de Melo >> > escreveu: >> >> Em Fri, Feb

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-05 Thread Jiri Olsa
On Fri, Feb 02, 2018 at 01:04:34PM -0800, Stephane Eranian wrote: > On Fri, Feb 2, 2018 at 12:40 PM, Arnaldo Carvalho de Melo > wrote: > > Em Fri, Feb 02, 2018 at 05:28:49PM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Fri, Feb 02, 2018 at 10:45:46AM -0800, Stephane Eranian

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-05 Thread Jiri Olsa
On Fri, Feb 02, 2018 at 01:04:34PM -0800, Stephane Eranian wrote: > On Fri, Feb 2, 2018 at 12:40 PM, Arnaldo Carvalho de Melo > wrote: > > Em Fri, Feb 02, 2018 at 05:28:49PM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Fri, Feb 02, 2018 at 10:45:46AM -0800, Stephane Eranian escreveu: > >> >

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-03 Thread Stephane Eranian
On Sat, Feb 3, 2018 at 7:30 AM, Jiri Olsa wrote: > On Fri, Feb 02, 2018 at 10:45:46AM -0800, Stephane Eranian wrote: >> Jiri, >> >> On Thu, Feb 1, 2018 at 12:38 AM, Jiri Olsa wrote: >> > Stephane reported that we don't set properly PERIOD >> > sample type for

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-03 Thread Stephane Eranian
On Sat, Feb 3, 2018 at 7:30 AM, Jiri Olsa wrote: > On Fri, Feb 02, 2018 at 10:45:46AM -0800, Stephane Eranian wrote: >> Jiri, >> >> On Thu, Feb 1, 2018 at 12:38 AM, Jiri Olsa wrote: >> > Stephane reported that we don't set properly PERIOD >> > sample type for events with period term defined. >>

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-03 Thread Jiri Olsa
On Fri, Feb 02, 2018 at 10:45:46AM -0800, Stephane Eranian wrote: > Jiri, > > On Thu, Feb 1, 2018 at 12:38 AM, Jiri Olsa wrote: > > Stephane reported that we don't set properly PERIOD > > sample type for events with period term defined. > > > > Before: > > $ perf record -e

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-03 Thread Jiri Olsa
On Fri, Feb 02, 2018 at 10:45:46AM -0800, Stephane Eranian wrote: > Jiri, > > On Thu, Feb 1, 2018 at 12:38 AM, Jiri Olsa wrote: > > Stephane reported that we don't set properly PERIOD > > sample type for events with period term defined. > > > > Before: > > $ perf record -e

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-02 Thread Stephane Eranian
On Fri, Feb 2, 2018 at 12:40 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Feb 02, 2018 at 05:28:49PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Fri, Feb 02, 2018 at 10:45:46AM -0800, Stephane Eranian escreveu: >> > Otherwise, I tested what you have written so far and it

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-02 Thread Stephane Eranian
On Fri, Feb 2, 2018 at 12:40 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Feb 02, 2018 at 05:28:49PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Fri, Feb 02, 2018 at 10:45:46AM -0800, Stephane Eranian escreveu: >> > Otherwise, I tested what you have written so far and it works. > >> So I

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-02 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 02, 2018 at 05:28:49PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 02, 2018 at 10:45:46AM -0800, Stephane Eranian escreveu: > > Otherwise, I tested what you have written so far and it works. > So I take that as a Tested-by: Stephane and will apply the patches, Jiri > can

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-02 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 02, 2018 at 05:28:49PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 02, 2018 at 10:45:46AM -0800, Stephane Eranian escreveu: > > Otherwise, I tested what you have written so far and it works. > So I take that as a Tested-by: Stephane and will apply the patches, Jiri > can

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-02 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 02, 2018 at 10:45:46AM -0800, Stephane Eranian escreveu: > Jiri, > > On Thu, Feb 1, 2018 at 12:38 AM, Jiri Olsa wrote: > > Stephane reported that we don't set properly PERIOD > > sample type for events with period term defined. > > > > Before: > > $ perf record -e

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-02 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 02, 2018 at 10:45:46AM -0800, Stephane Eranian escreveu: > Jiri, > > On Thu, Feb 1, 2018 at 12:38 AM, Jiri Olsa wrote: > > Stephane reported that we don't set properly PERIOD > > sample type for events with period term defined. > > > > Before: > > $ perf record -e

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-02 Thread Stephane Eranian
Jiri, On Thu, Feb 1, 2018 at 12:38 AM, Jiri Olsa wrote: > Stephane reported that we don't set properly PERIOD > sample type for events with period term defined. > > Before: > $ perf record -e cpu/cpu-cycles,period=1000/u ls > $ perf evlist -v >

Re: [PATCH 1/3] perf tools: Fix period/freq terms setup

2018-02-02 Thread Stephane Eranian
Jiri, On Thu, Feb 1, 2018 at 12:38 AM, Jiri Olsa wrote: > Stephane reported that we don't set properly PERIOD > sample type for events with period term defined. > > Before: > $ perf record -e cpu/cpu-cycles,period=1000/u ls > $ perf evlist -v > cpu/cpu-cycles,period=1000/u: ...