Re: [PATCH 1/5] phy: sun4i: add support for USB phy0

2014-10-30 Thread Maxime Ripard
Hi, On Wed, Oct 29, 2014 at 10:24:12AM +0800, Chen-Yu Tsai wrote: > On Wed, Oct 29, 2014 at 5:47 AM, Maxime Ripard > wrote: > > Hi Roman, > > > > Thanks for your patches > > > > On Mon, Oct 27, 2014 at 10:43:01PM +0100, Roman Byshko wrote: > >> The driver for sun4i USB phys currently supports >

Re: [PATCH 1/5] phy: sun4i: add support for USB phy0

2014-10-30 Thread Maxime Ripard
Hi, On Wed, Oct 29, 2014 at 10:24:12AM +0800, Chen-Yu Tsai wrote: On Wed, Oct 29, 2014 at 5:47 AM, Maxime Ripard maxime.rip...@free-electrons.com wrote: Hi Roman, Thanks for your patches On Mon, Oct 27, 2014 at 10:43:01PM +0100, Roman Byshko wrote: The driver for sun4i USB phys

Re: [PATCH 1/5] phy: sun4i: add support for USB phy0

2014-10-29 Thread Roman Byshko
Hi all, sorry for missing Signed-offs, they will be added, of course. >>> + /* Regulation 45 ohms */ >>> + if (phy->index == 0) >>> + sun4i_usb_phy_write(phy, PHY_RES45_CAL_EN, 0x01, 1); >> >> What is this code supposed to do? >> >> Some define for this bit and/or a better

Re: [PATCH 1/5] phy: sun4i: add support for USB phy0

2014-10-29 Thread Roman Byshko
Hi all, sorry for missing Signed-offs, they will be added, of course. + /* Regulation 45 ohms */ + if (phy-index == 0) + sun4i_usb_phy_write(phy, PHY_RES45_CAL_EN, 0x01, 1); What is this code supposed to do? Some define for this bit and/or a better comment would be

Re: [PATCH 1/5] phy: sun4i: add support for USB phy0

2014-10-28 Thread Chen-Yu Tsai
On Wed, Oct 29, 2014 at 5:47 AM, Maxime Ripard wrote: > Hi Roman, > > Thanks for your patches > > On Mon, Oct 27, 2014 at 10:43:01PM +0100, Roman Byshko wrote: >> The driver for sun4i USB phys currently supports >> only phy1 and phy2 which are used for USB host >> controllers. This patch adds

Re: [PATCH 1/5] phy: sun4i: add support for USB phy0

2014-10-28 Thread Maxime Ripard
Hi Roman, Thanks for your patches On Mon, Oct 27, 2014 at 10:43:01PM +0100, Roman Byshko wrote: > The driver for sun4i USB phys currently supports > only phy1 and phy2 which are used for USB host > controllers. This patch adds support for USB phy0, > which is used by the musb hdrc USB

Re: [PATCH 1/5] phy: sun4i: add support for USB phy0

2014-10-28 Thread Maxime Ripard
Hi Roman, Thanks for your patches On Mon, Oct 27, 2014 at 10:43:01PM +0100, Roman Byshko wrote: The driver for sun4i USB phys currently supports only phy1 and phy2 which are used for USB host controllers. This patch adds support for USB phy0, which is used by the musb hdrc USB controller.

Re: [PATCH 1/5] phy: sun4i: add support for USB phy0

2014-10-28 Thread Chen-Yu Tsai
On Wed, Oct 29, 2014 at 5:47 AM, Maxime Ripard maxime.rip...@free-electrons.com wrote: Hi Roman, Thanks for your patches On Mon, Oct 27, 2014 at 10:43:01PM +0100, Roman Byshko wrote: The driver for sun4i USB phys currently supports only phy1 and phy2 which are used for USB host