Re: [PATCH 1/6] staging: media: intel-ipu3: replace bit shifts with BIT() macro

2021-04-12 Thread Sakari Ailus
On Mon, Apr 12, 2021 at 12:55:52PM +0200, Greg KH wrote: > On Mon, Apr 12, 2021 at 01:44:35PM +0300, Sakari Ailus wrote: > > Hi Greg, > > > > On Mon, Apr 12, 2021 at 11:49:43AM +0200, Greg KH wrote: > > > On Mon, Apr 12, 2021 at 12:42:30PM +0300, Sakari Ailus wrote: > > > > Hi Mitali, > > > > >

Re: [PATCH 1/6] staging: media: intel-ipu3: replace bit shifts with BIT() macro

2021-04-12 Thread Greg KH
On Mon, Apr 12, 2021 at 01:44:35PM +0300, Sakari Ailus wrote: > Hi Greg, > > On Mon, Apr 12, 2021 at 11:49:43AM +0200, Greg KH wrote: > > On Mon, Apr 12, 2021 at 12:42:30PM +0300, Sakari Ailus wrote: > > > Hi Mitali, > > > > > > On Mon, Apr 12, 2021 at 04:38:39AM +0530, Mitali Borkar wrote: > >

Re: [PATCH 1/6] staging: media: intel-ipu3: replace bit shifts with BIT() macro

2021-04-12 Thread Sakari Ailus
Hi Greg, On Mon, Apr 12, 2021 at 11:49:43AM +0200, Greg KH wrote: > On Mon, Apr 12, 2021 at 12:42:30PM +0300, Sakari Ailus wrote: > > Hi Mitali, > > > > On Mon, Apr 12, 2021 at 04:38:39AM +0530, Mitali Borkar wrote: > > > Added #include and replaced bit shifts by BIT() macro. > > > This BIT()

Re: [Outreachy kernel] Re: [PATCH 1/6] staging: media: intel-ipu3: replace bit shifts with BIT() macro

2021-04-12 Thread Julia Lawall
On Mon, 12 Apr 2021, Greg KH wrote: > On Mon, Apr 12, 2021 at 12:42:30PM +0300, Sakari Ailus wrote: > > Hi Mitali, > > > > On Mon, Apr 12, 2021 at 04:38:39AM +0530, Mitali Borkar wrote: > > > Added #include and replaced bit shifts by BIT() macro. > > > This BIT() macro from linux/bitops.h is

Re: [PATCH 1/6] staging: media: intel-ipu3: replace bit shifts with BIT() macro

2021-04-12 Thread Greg KH
On Mon, Apr 12, 2021 at 12:42:30PM +0300, Sakari Ailus wrote: > Hi Mitali, > > On Mon, Apr 12, 2021 at 04:38:39AM +0530, Mitali Borkar wrote: > > Added #include and replaced bit shifts by BIT() macro. > > This BIT() macro from linux/bitops.h is used to define > > IPU3_UAPI_GRID_Y_START_EN > >

Re: [PATCH 1/6] staging: media: intel-ipu3: replace bit shifts with BIT() macro

2021-04-12 Thread Sakari Ailus
Hi Mitali, On Mon, Apr 12, 2021 at 04:38:39AM +0530, Mitali Borkar wrote: > Added #include and replaced bit shifts by BIT() macro. > This BIT() macro from linux/bitops.h is used to define > IPU3_UAPI_GRID_Y_START_EN > and IPU3_UAPI_AWB_RGBS_THR_B_* bitmask. > Use of macro is better and neater.