On Tue, 2008-01-15 at 20:18 +0300, Anton Salikhmetov wrote:
> 2008/1/15, Peter Zijlstra <[EMAIL PROTECTED]>:
> >
> > On Tue, 2008-01-15 at 19:02 +0300, Anton Salikhmetov wrote:
> >
> > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> > > index 3d3848f..53d0e34 100644
> > > ---
2008/1/15, Christoph Hellwig <[EMAIL PROTECTED]>:
> On Tue, Jan 15, 2008 at 07:02:45PM +0300, Anton Salikhmetov wrote:
> > +/*
> > + * Update the ctime and mtime stamps for memory-mapped block device files.
> > + */
> > +static void bd_inode_update_time(struct inode *inode, struct timespec *ts)
>
On Tue, Jan 15, 2008 at 07:02:45PM +0300, Anton Salikhmetov wrote:
> +/*
> + * Update the ctime and mtime stamps for memory-mapped block device files.
> + */
> +static void bd_inode_update_time(struct inode *inode, struct timespec *ts)
> +{
> + struct block_device *bdev = inode->i_bdev;
> +
2008/1/15, Peter Zijlstra <[EMAIL PROTECTED]>:
>
> On Tue, 2008-01-15 at 19:02 +0300, Anton Salikhmetov wrote:
>
> > diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> > index 3d3848f..53d0e34 100644
> > --- a/mm/page-writeback.c
> > +++ b/mm/page-writeback.c
> > @@ -997,35 +997,39 @@ int
On Tue, 2008-01-15 at 19:02 +0300, Anton Salikhmetov wrote:
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 3d3848f..53d0e34 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -997,35 +997,39 @@ int __set_page_dirty_no_writeback(struct page *page)
> */
> int
2008/1/15, Miklos Szeredi <[EMAIL PROTECTED]>:
> > Thanks for your review, Peter and Miklos!
> >
> > I overlooked this case when AS_MCTIME flag has been turned off and the
> > page is still dirty.
> >
> > On the other hand, the words "shall be marked for update" may be
> > considered as just
> Thanks for your review, Peter and Miklos!
>
> I overlooked this case when AS_MCTIME flag has been turned off and the
> page is still dirty.
>
> On the other hand, the words "shall be marked for update" may be
> considered as just setting the AS_MCTIME flag, not updating the time
> stamps.
>
>
Thanks for your review, Peter and Miklos!
I overlooked this case when AS_MCTIME flag has been turned off and the
page is still dirty.
On the other hand, the words shall be marked for update may be
considered as just setting the AS_MCTIME flag, not updating the time
stamps.
What do you
2008/1/15, Miklos Szeredi [EMAIL PROTECTED]:
Thanks for your review, Peter and Miklos!
I overlooked this case when AS_MCTIME flag has been turned off and the
page is still dirty.
On the other hand, the words shall be marked for update may be
considered as just setting the AS_MCTIME
On Tue, 2008-01-15 at 19:02 +0300, Anton Salikhmetov wrote:
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 3d3848f..53d0e34 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -997,35 +997,39 @@ int __set_page_dirty_no_writeback(struct page *page)
*/
int
2008/1/15, Peter Zijlstra [EMAIL PROTECTED]:
On Tue, 2008-01-15 at 19:02 +0300, Anton Salikhmetov wrote:
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 3d3848f..53d0e34 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -997,35 +997,39 @@ int
On Tue, Jan 15, 2008 at 07:02:45PM +0300, Anton Salikhmetov wrote:
+/*
+ * Update the ctime and mtime stamps for memory-mapped block device files.
+ */
+static void bd_inode_update_time(struct inode *inode, struct timespec *ts)
+{
+ struct block_device *bdev = inode-i_bdev;
+ struct
2008/1/15, Christoph Hellwig [EMAIL PROTECTED]:
On Tue, Jan 15, 2008 at 07:02:45PM +0300, Anton Salikhmetov wrote:
+/*
+ * Update the ctime and mtime stamps for memory-mapped block device files.
+ */
+static void bd_inode_update_time(struct inode *inode, struct timespec *ts)
+{
+
On Tue, 2008-01-15 at 20:18 +0300, Anton Salikhmetov wrote:
2008/1/15, Peter Zijlstra [EMAIL PROTECTED]:
On Tue, 2008-01-15 at 19:02 +0300, Anton Salikhmetov wrote:
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 3d3848f..53d0e34 100644
--- a/mm/page-writeback.c
2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>:
> > 2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>:
> > > > http://bugzilla.kernel.org/show_bug.cgi?id=2645
> > > >
> > > > Changes for updating the ctime and mtime fields for memory-mapped files:
> > > >
> > > > 1) new flag triggering update of the
2008/1/14, Peter Zijlstra <[EMAIL PROTECTED]>:
>
> On Mon, 2008-01-14 at 14:14 +0100, Miklos Szeredi wrote:
> > > 2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>:
> > > > > http://bugzilla.kernel.org/show_bug.cgi?id=2645
> > > > >
> > > > > Changes for updating the ctime and mtime fields for
> > More fun, it would require marking them RO but leaving the dirty bit
> > set, because this ext3 fudge where we confuse the page dirty state - or
> > did that get fixed?
>
> That got fixed by Nick, I think.
>
> The alternative to marking pages RO, is to walk the PTEs in MS_ASYNC,
> note the
> More fun, it would require marking them RO but leaving the dirty bit
> set, because this ext3 fudge where we confuse the page dirty state - or
> did that get fixed?
That got fixed by Nick, I think.
The alternative to marking pages RO, is to walk the PTEs in MS_ASYNC,
note the dirty bit and
On Mon, 2008-01-14 at 14:35 +0100, Peter Zijlstra wrote:
> On Mon, 2008-01-14 at 14:14 +0100, Miklos Szeredi wrote:
> > > 2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>:
> > > > > http://bugzilla.kernel.org/show_bug.cgi?id=2645
> > > > >
> > > > > Changes for updating the ctime and mtime fields
On Mon, 2008-01-14 at 14:14 +0100, Miklos Szeredi wrote:
> > 2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>:
> > > > http://bugzilla.kernel.org/show_bug.cgi?id=2645
> > > >
> > > > Changes for updating the ctime and mtime fields for memory-mapped files:
> > > >
> > > > 1) new flag triggering
> 2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>:
> > > http://bugzilla.kernel.org/show_bug.cgi?id=2645
> > >
> > > Changes for updating the ctime and mtime fields for memory-mapped files:
> > >
> > > 1) new flag triggering update of the inode data;
> > > 2) new function to update ctime and mtime
2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>:
> > > http://bugzilla.kernel.org/show_bug.cgi?id=2645
> > >
> > > Changes for updating the ctime and mtime fields for memory-mapped files:
> > >
> > > 1) new flag triggering update of the inode data;
> > > 2) new function to update ctime and mtime for
2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>:
> > http://bugzilla.kernel.org/show_bug.cgi?id=2645
> >
> > Changes for updating the ctime and mtime fields for memory-mapped files:
> >
> > 1) new flag triggering update of the inode data;
> > 2) new function to update ctime and mtime for block
> > http://bugzilla.kernel.org/show_bug.cgi?id=2645
> >
> > Changes for updating the ctime and mtime fields for memory-mapped files:
> >
> > 1) new flag triggering update of the inode data;
> > 2) new function to update ctime and mtime for block device files;
> > 3) new helper function to update
> http://bugzilla.kernel.org/show_bug.cgi?id=2645
>
> Changes for updating the ctime and mtime fields for memory-mapped files:
>
> 1) new flag triggering update of the inode data;
> 2) new function to update ctime and mtime for block device files;
> 3) new helper function to update ctime and
2008/1/14, Miklos Szeredi [EMAIL PROTECTED]:
http://bugzilla.kernel.org/show_bug.cgi?id=2645
Changes for updating the ctime and mtime fields for memory-mapped files:
1) new flag triggering update of the inode data;
2) new function to update ctime and mtime for block device files;
3)
2008/1/14, Miklos Szeredi [EMAIL PROTECTED]:
http://bugzilla.kernel.org/show_bug.cgi?id=2645
Changes for updating the ctime and mtime fields for memory-mapped files:
1) new flag triggering update of the inode data;
2) new function to update ctime and mtime for block device
More fun, it would require marking them RO but leaving the dirty bit
set, because this ext3 fudge where we confuse the page dirty state - or
did that get fixed?
That got fixed by Nick, I think.
The alternative to marking pages RO, is to walk the PTEs in MS_ASYNC,
note the dirty bit
More fun, it would require marking them RO but leaving the dirty bit
set, because this ext3 fudge where we confuse the page dirty state - or
did that get fixed?
That got fixed by Nick, I think.
The alternative to marking pages RO, is to walk the PTEs in MS_ASYNC,
note the dirty bit and mark
On Mon, 2008-01-14 at 14:35 +0100, Peter Zijlstra wrote:
On Mon, 2008-01-14 at 14:14 +0100, Miklos Szeredi wrote:
2008/1/14, Miklos Szeredi [EMAIL PROTECTED]:
http://bugzilla.kernel.org/show_bug.cgi?id=2645
Changes for updating the ctime and mtime fields for memory-mapped
On Mon, 2008-01-14 at 14:14 +0100, Miklos Szeredi wrote:
2008/1/14, Miklos Szeredi [EMAIL PROTECTED]:
http://bugzilla.kernel.org/show_bug.cgi?id=2645
Changes for updating the ctime and mtime fields for memory-mapped files:
1) new flag triggering update of the inode data;
2008/1/14, Peter Zijlstra [EMAIL PROTECTED]:
On Mon, 2008-01-14 at 14:14 +0100, Miklos Szeredi wrote:
2008/1/14, Miklos Szeredi [EMAIL PROTECTED]:
http://bugzilla.kernel.org/show_bug.cgi?id=2645
Changes for updating the ctime and mtime fields for memory-mapped
files:
2008/1/14, Miklos Szeredi [EMAIL PROTECTED]:
2008/1/14, Miklos Szeredi [EMAIL PROTECTED]:
http://bugzilla.kernel.org/show_bug.cgi?id=2645
Changes for updating the ctime and mtime fields for memory-mapped files:
1) new flag triggering update of the inode data;
2) new
On Sun, 13 Jan 2008 07:39:59 +0300
Anton Salikhmetov <[EMAIL PROTECTED]> wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=2645
>
> Changes for updating the ctime and mtime fields for memory-mapped files:
>
> 1) new flag triggering update of the inode data;
> 2) new function to update ctime
On Sun, 13 Jan 2008 07:39:59 +0300
Anton Salikhmetov [EMAIL PROTECTED] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=2645
Changes for updating the ctime and mtime fields for memory-mapped files:
1) new flag triggering update of the inode data;
2) new function to update ctime and mtime
35 matches
Mail list logo
