Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-07 Thread Jan Kiszka
On 2017-02-06 23:04, Sudip Mukherjee wrote: > On Monday 06 February 2017 02:45 PM, Jan Kiszka wrote: >> On 2017-01-30 23:28, Sudip Mukherjee wrote: >>> From: Sudip Mukherjee >>> >>> Add the serial driver for the Exar chips. And also register the >>> platform

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-07 Thread Jan Kiszka
On 2017-02-06 23:04, Sudip Mukherjee wrote: > On Monday 06 February 2017 02:45 PM, Jan Kiszka wrote: >> On 2017-01-30 23:28, Sudip Mukherjee wrote: >>> From: Sudip Mukherjee >>> >>> Add the serial driver for the Exar chips. And also register the >>> platform device for the GPIO provided by the

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Sudip Mukherjee
On Monday 06 February 2017 01:49 PM, Jan Kiszka wrote: On 2017-02-03 22:31, Sudip Mukherjee wrote: On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: BTW, are you personally the copyright holder or your employer Codethink? Depends on your contractual situation, but the former is less

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Sudip Mukherjee
On Monday 06 February 2017 01:49 PM, Jan Kiszka wrote: On 2017-02-03 22:31, Sudip Mukherjee wrote: On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: BTW, are you personally the copyright holder or your employer Codethink? Depends on your contractual situation, but the former is less

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Sudip Mukherjee
On Monday 06 February 2017 02:06 PM, Greg Kroah-Hartman wrote: On Mon, Feb 06, 2017 at 02:49:07PM +0100, Jan Kiszka wrote: On 2017-02-03 22:31, Sudip Mukherjee wrote: On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: BTW, are you personally the copyright holder or your employer

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Sudip Mukherjee
On Monday 06 February 2017 02:06 PM, Greg Kroah-Hartman wrote: On Mon, Feb 06, 2017 at 02:49:07PM +0100, Jan Kiszka wrote: On 2017-02-03 22:31, Sudip Mukherjee wrote: On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: BTW, are you personally the copyright holder or your employer

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Sudip Mukherjee
On Monday 06 February 2017 02:45 PM, Jan Kiszka wrote: On 2017-01-30 23:28, Sudip Mukherjee wrote: From: Sudip Mukherjee Add the serial driver for the Exar chips. And also register the platform device for the GPIO provided by the Exar chips. And another

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Sudip Mukherjee
On Monday 06 February 2017 02:45 PM, Jan Kiszka wrote: On 2017-01-30 23:28, Sudip Mukherjee wrote: From: Sudip Mukherjee Add the serial driver for the Exar chips. And also register the platform device for the GPIO provided by the Exar chips. And another question: you left

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Jan Kiszka
On 2017-02-06 20:37, Jan Kiszka wrote: > On 2017-01-30 23:28, Sudip Mukherjee wrote: >> From: Sudip Mukherjee >> >> Add the serial driver for the Exar chips. And also register the >> platform device for the GPIO provided by the Exar chips. >> >> Reviewed-by: Andy

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Jan Kiszka
On 2017-02-06 20:37, Jan Kiszka wrote: > On 2017-01-30 23:28, Sudip Mukherjee wrote: >> From: Sudip Mukherjee >> >> Add the serial driver for the Exar chips. And also register the >> platform device for the GPIO provided by the Exar chips. >> >> Reviewed-by: Andy Shevchenko >> Signed-off-by:

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Jan Kiszka
On 2017-01-30 23:28, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > Add the serial driver for the Exar chips. And also register the > platform device for the GPIO provided by the Exar chips. > > Reviewed-by: Andy Shevchenko >

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Jan Kiszka
On 2017-01-30 23:28, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > Add the serial driver for the Exar chips. And also register the > platform device for the GPIO provided by the Exar chips. > > Reviewed-by: Andy Shevchenko > Signed-off-by: Sudip Mukherjee ... > +static int

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Jan Kiszka
On 2017-01-30 23:28, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > Add the serial driver for the Exar chips. And also register the > platform device for the GPIO provided by the Exar chips. > And another question: you left pci_fastcom335_setup and related

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Jan Kiszka
On 2017-01-30 23:28, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > Add the serial driver for the Exar chips. And also register the > platform device for the GPIO provided by the Exar chips. > And another question: you left pci_fastcom335_setup and related things untouched - did that code

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Jan Kiszka
On 2017-02-06 15:06, Greg Kroah-Hartman wrote: > On Mon, Feb 06, 2017 at 02:49:07PM +0100, Jan Kiszka wrote: >> On 2017-02-03 22:31, Sudip Mukherjee wrote: >>> On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: BTW, are you personally the copyright holder or your employer Codethink?

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Jan Kiszka
On 2017-02-06 15:06, Greg Kroah-Hartman wrote: > On Mon, Feb 06, 2017 at 02:49:07PM +0100, Jan Kiszka wrote: >> On 2017-02-03 22:31, Sudip Mukherjee wrote: >>> On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: BTW, are you personally the copyright holder or your employer Codethink?

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Greg Kroah-Hartman
On Mon, Feb 06, 2017 at 02:49:07PM +0100, Jan Kiszka wrote: > On 2017-02-03 22:31, Sudip Mukherjee wrote: > > On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: > >> BTW, are you personally the copyright holder or your employer Codethink? > >> Depends on your contractual situation, but the

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Greg Kroah-Hartman
On Mon, Feb 06, 2017 at 02:49:07PM +0100, Jan Kiszka wrote: > On 2017-02-03 22:31, Sudip Mukherjee wrote: > > On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: > >> BTW, are you personally the copyright holder or your employer Codethink? > >> Depends on your contractual situation, but the

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Jan Kiszka
On 2017-02-03 22:31, Sudip Mukherjee wrote: > On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: >> BTW, are you personally the copyright holder or your employer Codethink? >> Depends on your contractual situation, but the former is less common. > > Well, Codethink has nothing to do with this

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-06 Thread Jan Kiszka
On 2017-02-03 22:31, Sudip Mukherjee wrote: > On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: >> BTW, are you personally the copyright holder or your employer Codethink? >> Depends on your contractual situation, but the former is less common. > > Well, Codethink has nothing to do with this

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-04 Thread Andy Shevchenko
On Fri, Feb 3, 2017 at 11:31 PM, Sudip Mukherjee wrote: > On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: >> On 2017-01-30 23:28, Sudip Mukherjee wrote: >>> @@ -0,0 +1,396 @@ >>> +/* >>> + * Probe module for 8250/16550-type Exar chips PCI serial ports. >>> +

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-04 Thread Andy Shevchenko
On Fri, Feb 3, 2017 at 11:31 PM, Sudip Mukherjee wrote: > On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: >> On 2017-01-30 23:28, Sudip Mukherjee wrote: >>> @@ -0,0 +1,396 @@ >>> +/* >>> + * Probe module for 8250/16550-type Exar chips PCI serial ports. >>> + * >>> + * Based on

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-03 Thread Sudip Mukherjee
On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: On 2017-01-30 23:28, Sudip Mukherjee wrote: From: Sudip Mukherjee Add the serial driver for the Exar chips. And also register the platform device for the GPIO provided by the Exar chips. "Also" means you

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-03 Thread Sudip Mukherjee
On Friday 03 February 2017 02:02 PM, Jan Kiszka wrote: On 2017-01-30 23:28, Sudip Mukherjee wrote: From: Sudip Mukherjee Add the serial driver for the Exar chips. And also register the platform device for the GPIO provided by the Exar chips. "Also" means you are doing two things in one

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-03 Thread Andy Shevchenko
On Fri, Feb 3, 2017 at 4:02 PM, Jan Kiszka wrote: > On 2017-01-30 23:28, Sudip Mukherjee wrote: >> From: Sudip Mukherjee >> >> Add the serial driver for the Exar chips. And also register the >> platform device for the GPIO provided by the

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-03 Thread Andy Shevchenko
On Fri, Feb 3, 2017 at 4:02 PM, Jan Kiszka wrote: > On 2017-01-30 23:28, Sudip Mukherjee wrote: >> From: Sudip Mukherjee >> >> Add the serial driver for the Exar chips. And also register the >> platform device for the GPIO provided by the Exar chips. > > "Also" means you are doing two things in

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-03 Thread Jan Kiszka
On 2017-01-30 23:28, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > Add the serial driver for the Exar chips. And also register the > platform device for the GPIO provided by the Exar chips. "Also" means you are doing two things in one patch - was this

Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci

2017-02-03 Thread Jan Kiszka
On 2017-01-30 23:28, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > Add the serial driver for the Exar chips. And also register the > platform device for the GPIO provided by the Exar chips. "Also" means you are doing two things in one patch - was this already discussed and accepted in