Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 9:47 PM, Jan Kiszka wrote: > On 2017-05-22 20:37, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 9:23 PM, Lee Jones wrote: >>> On Mon, 22 May 2017, Andy Shevchenko wrote: On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 9:47 PM, Jan Kiszka wrote: > On 2017-05-22 20:37, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 9:23 PM, Lee Jones wrote: >>> On Mon, 22 May 2017, Andy Shevchenko wrote: On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka wrote: >> Got your point. >> Jan, care to

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On 2017-05-22 20:37, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 9:23 PM, Lee Jones wrote: >> On Mon, 22 May 2017, Andy Shevchenko wrote: >>> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka wrote: On 2017-05-22 19:36, Andy Shevchenko wrote: >

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On 2017-05-22 20:37, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 9:23 PM, Lee Jones wrote: >> On Mon, 22 May 2017, Andy Shevchenko wrote: >>> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka wrote: On 2017-05-22 19:36, Andy Shevchenko wrote: > Then let's leave the decision up to the

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 9:23 PM, Lee Jones wrote: > On Mon, 22 May 2017, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka wrote: >> > On 2017-05-22 19:36, Andy Shevchenko wrote: >> > Then let's leave the decision up to the

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 9:23 PM, Lee Jones wrote: > On Mon, 22 May 2017, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka wrote: >> > On 2017-05-22 19:36, Andy Shevchenko wrote: >> > Then let's leave the decision up to the maintainer. >> >> Lee, just for your convenience

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, 22 May 2017, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka wrote: > > On 2017-05-22 19:36, Andy Shevchenko wrote: > >> On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka wrote: > >>> On 2017-05-22 19:26, Andy Shevchenko

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, 22 May 2017, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka wrote: > > On 2017-05-22 19:36, Andy Shevchenko wrote: > >> On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka wrote: > >>> On 2017-05-22 19:26, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:25 PM, Jan

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka wrote: > On 2017-05-22 19:36, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka wrote: >>> On 2017-05-22 19:26, Andy Shevchenko wrote: On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka wrote: > On 2017-05-22 19:36, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka wrote: >>> On 2017-05-22 19:26, Andy Shevchenko wrote: On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka wrote: > On 2017-05-22 19:20, Andy

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On 2017-05-22 19:36, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka wrote: >> On 2017-05-22 19:26, Andy Shevchenko wrote: >>> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka wrote: On 2017-05-22 19:20, Andy Shevchenko wrote:

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On 2017-05-22 19:36, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka wrote: >> On 2017-05-22 19:26, Andy Shevchenko wrote: >>> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka wrote: On 2017-05-22 19:20, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:18 PM, Jan

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka wrote: > On 2017-05-22 19:26, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka wrote: >>> On 2017-05-22 19:20, Andy Shevchenko wrote: On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka wrote: > On 2017-05-22 19:26, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka wrote: >>> On 2017-05-22 19:20, Andy Shevchenko wrote: On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka wrote: > On 2017-05-22 19:12, Andy

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On 2017-05-22 19:26, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka wrote: >> On 2017-05-22 19:20, Andy Shevchenko wrote: >>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka wrote: On 2017-05-22 19:12, Andy Shevchenko wrote:

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On 2017-05-22 19:26, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka wrote: >> On 2017-05-22 19:20, Andy Shevchenko wrote: >>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka wrote: On 2017-05-22 19:12, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 1:53 PM, Jan

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka wrote: > On 2017-05-22 19:20, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka wrote: >>> On 2017-05-22 19:12, Andy Shevchenko wrote: On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka wrote: > On 2017-05-22 19:20, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka wrote: >>> On 2017-05-22 19:12, Andy Shevchenko wrote: On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka wrote: > Avoids reimplementation of DMI

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On 2017-05-22 19:20, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka wrote: >> On 2017-05-22 19:12, Andy Shevchenko wrote: >>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka wrote: Avoids reimplementation of DMI matching in

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On 2017-05-22 19:20, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka wrote: >> On 2017-05-22 19:12, Andy Shevchenko wrote: >>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka wrote: Avoids reimplementation of DMI matching in intel_quark_i2c_setup. >>> >>> What's wrong with

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka wrote: > On 2017-05-22 19:12, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka wrote: >>> Avoids reimplementation of DMI matching in intel_quark_i2c_setup. >> >> What's wrong with

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka wrote: > On 2017-05-22 19:12, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka wrote: >>> Avoids reimplementation of DMI matching in intel_quark_i2c_setup. >> >> What's wrong with current approach? I suppose this will make sense >>

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On 2017-05-22 19:12, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka wrote: >> Avoids reimplementation of DMI matching in intel_quark_i2c_setup. > > What's wrong with current approach? I suppose this will make sense > when we will have an issue /

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On 2017-05-22 19:12, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka wrote: >> Avoids reimplementation of DMI matching in intel_quark_i2c_setup. > > What's wrong with current approach? I suppose this will make sense > when we will have an issue / impediment. Right now it

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka wrote: > Avoids reimplementation of DMI matching in intel_quark_i2c_setup. What's wrong with current approach? I suppose this will make sense when we will have an issue / impediment. Right now it looks like over-engineering.

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka wrote: > Avoids reimplementation of DMI matching in intel_quark_i2c_setup. What's wrong with current approach? I suppose this will make sense when we will have an issue / impediment. Right now it looks like over-engineering. (Yes, I know what I said