Re: [PATCH v2 5/6] media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS

2021-03-12 Thread Laurent Pinchart
Hi Hans, On Fri, Mar 12, 2021 at 11:22:07AM +0100, Hans Verkuil wrote: > On 12/03/2021 11:13, Laurent Pinchart wrote: > > On Fri, Mar 12, 2021 at 10:57:33AM +0100, Ricardo Ribalda Delgado wrote: > >> On Fri, Mar 12, 2021 at 2:25 AM Laurent Pinchart wrote: > >>> On Thu, Mar 11, 2021 at 11:19:45PM

Re: [PATCH v2 5/6] media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS

2021-03-12 Thread Hans Verkuil
On 12/03/2021 11:13, Laurent Pinchart wrote: > Hi Ricardo, > > On Fri, Mar 12, 2021 at 10:57:33AM +0100, Ricardo Ribalda Delgado wrote: >> On Fri, Mar 12, 2021 at 2:25 AM Laurent Pinchart wrote: >>> On Thu, Mar 11, 2021 at 11:19:45PM +0100, Ricardo Ribalda wrote: Create all the class

Re: [PATCH v2 5/6] media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS

2021-03-12 Thread Laurent Pinchart
Hi Ricardo, On Fri, Mar 12, 2021 at 10:57:33AM +0100, Ricardo Ribalda Delgado wrote: > On Fri, Mar 12, 2021 at 2:25 AM Laurent Pinchart wrote: > > On Thu, Mar 11, 2021 at 11:19:45PM +0100, Ricardo Ribalda wrote: > > > Create all the class controls for the device defined controls. > > > > > >

Re: [PATCH v2 5/6] media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS

2021-03-12 Thread Ricardo Ribalda Delgado
HI Laurent Thanks for the prompt reply :) On Fri, Mar 12, 2021 at 2:25 AM Laurent Pinchart wrote: > > Hi Ricardo, > > Thank you for the patch. > > On Thu, Mar 11, 2021 at 11:19:45PM +0100, Ricardo Ribalda wrote: > > Create all the class controls for the device defined controls. > > > > Fixes

Re: [PATCH v2 5/6] media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS

2021-03-11 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Thu, Mar 11, 2021 at 11:19:45PM +0100, Ricardo Ribalda wrote: > Create all the class controls for the device defined controls. > > Fixes v4l2-compliance: > Control ioctls (Input 0): > fail: v4l2-test-controls.cpp(216): missing control class