Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Fri, Apr 06, 2018 at 02:56:36PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Subject: [PATCH] nohz: Avoid duplication of code related to got_idle_tick > > Move the code setting ts->got_idle_tick into tick_sched_do_timer() to > avoid code duplication.

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Fri, Apr 06, 2018 at 02:56:36PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Subject: [PATCH] nohz: Avoid duplication of code related to got_idle_tick > > Move the code setting ts->got_idle_tick into tick_sched_do_timer() to > avoid code duplication. > > No intentional changes

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Fri, Apr 06, 2018 at 10:11:04AM +0200, Rafael J. Wysocki wrote: > On Friday, April 6, 2018 4:44:14 AM CEST Frederic Weisbecker wrote: > > On Wed, Apr 04, 2018 at 10:39:50AM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > Index:

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Fri, Apr 06, 2018 at 10:11:04AM +0200, Rafael J. Wysocki wrote: > On Friday, April 6, 2018 4:44:14 AM CEST Frederic Weisbecker wrote: > > On Wed, Apr 04, 2018 at 10:39:50AM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > Index: linux-pm/kernel/time/tick-sched.c > > >

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Fri, Apr 06, 2018 at 09:58:37AM +0200, Peter Zijlstra wrote: > On Fri, Apr 06, 2018 at 04:44:14AM +0200, Frederic Weisbecker wrote: > > You can move that to tick_sched_do_timer() to avoid code duplication. > > I expect the reason I didn't was that it didn't have @ts, but that's > easily

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Fri, Apr 06, 2018 at 09:58:37AM +0200, Peter Zijlstra wrote: > On Fri, Apr 06, 2018 at 04:44:14AM +0200, Frederic Weisbecker wrote: > > You can move that to tick_sched_do_timer() to avoid code duplication. > > I expect the reason I didn't was that it didn't have @ts, but that's > easily

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Fri, Apr 06, 2018 at 09:24:42AM +0200, Rafael J. Wysocki wrote: > On Friday, April 6, 2018 4:44:14 AM CEST Frederic Weisbecker wrote: > > On Wed, Apr 04, 2018 at 10:39:50AM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > Index:

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Fri, Apr 06, 2018 at 09:24:42AM +0200, Rafael J. Wysocki wrote: > On Friday, April 6, 2018 4:44:14 AM CEST Frederic Weisbecker wrote: > > On Wed, Apr 04, 2018 at 10:39:50AM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > Index: linux-pm/kernel/time/tick-sched.c > > >

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Friday, April 6, 2018 10:11:04 AM CEST Rafael J. Wysocki wrote: > On Friday, April 6, 2018 4:44:14 AM CEST Frederic Weisbecker wrote: > > On Wed, Apr 04, 2018 at 10:39:50AM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > Index:

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Friday, April 6, 2018 10:11:04 AM CEST Rafael J. Wysocki wrote: > On Friday, April 6, 2018 4:44:14 AM CEST Frederic Weisbecker wrote: > > On Wed, Apr 04, 2018 at 10:39:50AM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > Index: linux-pm/kernel/time/tick-sched.c > > >

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Friday, April 6, 2018 4:44:14 AM CEST Frederic Weisbecker wrote: > On Wed, Apr 04, 2018 at 10:39:50AM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > Index: linux-pm/kernel/time/tick-sched.c > >

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Friday, April 6, 2018 4:44:14 AM CEST Frederic Weisbecker wrote: > On Wed, Apr 04, 2018 at 10:39:50AM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > Index: linux-pm/kernel/time/tick-sched.c > > === > > ---

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Fri, Apr 06, 2018 at 04:44:14AM +0200, Frederic Weisbecker wrote: > You can move that to tick_sched_do_timer() to avoid code duplication. I expect the reason I didn't was that it didn't have @ts, but that's easily fixable. > Also these constants are very opaque. And even with proper symbols

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Fri, Apr 06, 2018 at 04:44:14AM +0200, Frederic Weisbecker wrote: > You can move that to tick_sched_do_timer() to avoid code duplication. I expect the reason I didn't was that it didn't have @ts, but that's easily fixable. > Also these constants are very opaque. And even with proper symbols

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Friday, April 6, 2018 4:44:14 AM CEST Frederic Weisbecker wrote: > On Wed, Apr 04, 2018 at 10:39:50AM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > Index: linux-pm/kernel/time/tick-sched.c > >

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Friday, April 6, 2018 4:44:14 AM CEST Frederic Weisbecker wrote: > On Wed, Apr 04, 2018 at 10:39:50AM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > Index: linux-pm/kernel/time/tick-sched.c > > === > > ---

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Wed, Apr 04, 2018 at 10:39:50AM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Index: linux-pm/kernel/time/tick-sched.c > === > --- linux-pm.orig/kernel/time/tick-sched.c > +++

Re: [PATCH v9 05/10] cpuidle: Return nohz hint from cpuidle_select()

On Wed, Apr 04, 2018 at 10:39:50AM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Index: linux-pm/kernel/time/tick-sched.c > === > --- linux-pm.orig/kernel/time/tick-sched.c > +++ linux-pm/kernel/time/tick-sched.c > @@