Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-20 Thread Christoph Hellwig
On Sat, May 20, 2017 at 09:49:56AM -0700, Linus Torvalds wrote: > Side note: why is it doing that " > 1" check, when any value _other_ > than 1 is wrong? It's the same effect, so either one is fine with me. > Also, to match the non-MSI implementation, wouldn't it be nicer to > just write it that

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-20 Thread Christoph Hellwig
On Sat, May 20, 2017 at 09:49:56AM -0700, Linus Torvalds wrote: > Side note: why is it doing that " > 1" check, when any value _other_ > than 1 is wrong? It's the same effect, so either one is fine with me. > Also, to match the non-MSI implementation, wouldn't it be nicer to > just write it that

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-20 Thread Linus Torvalds
On Fri, May 19, 2017 at 5:46 AM, Christoph Hellwig wrote: > > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 33c2b0b77429..5a7fd3b6a7b9 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -1342,7 +1342,7 @@ pci_alloc_irq_vectors_affinity(struct pci_dev

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-20 Thread Linus Torvalds
On Fri, May 19, 2017 at 5:46 AM, Christoph Hellwig wrote: > > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 33c2b0b77429..5a7fd3b6a7b9 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -1342,7 +1342,7 @@ pci_alloc_irq_vectors_affinity(struct pci_dev *dev, >

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-19 Thread Steven Rostedt
On Fri, 19 May 2017 14:46:25 +0200 Christoph Hellwig wrote: > On Fri, May 19, 2017 at 08:37:21AM -0400, Steven Rostedt wrote: > > ktest config bisect ended with: > > > > *** > > Found bad config: CONFIG_PCI_MSI > >

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-19 Thread Steven Rostedt
On Fri, 19 May 2017 14:46:25 +0200 Christoph Hellwig wrote: > On Fri, May 19, 2017 at 08:37:21AM -0400, Steven Rostedt wrote: > > ktest config bisect ended with: > > > > *** > > Found bad config: CONFIG_PCI_MSI > > *** >

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-19 Thread Christoph Hellwig
On Fri, May 19, 2017 at 08:37:21AM -0400, Steven Rostedt wrote: > ktest config bisect ended with: > > *** > Found bad config: CONFIG_PCI_MSI > *** Oh, that's interesting. I think there's been a bug in the !CONFIG_PCI_MSI

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-19 Thread Christoph Hellwig
On Fri, May 19, 2017 at 08:37:21AM -0400, Steven Rostedt wrote: > ktest config bisect ended with: > > *** > Found bad config: CONFIG_PCI_MSI > *** Oh, that's interesting. I think there's been a bug in the !CONFIG_PCI_MSI

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-19 Thread Steven Rostedt
On Fri, 19 May 2017 06:08:56 -0400 Steven Rostedt wrote: > > But other configs on this same hardware work, can you do a diff of a > > working vs. not working? > > I could probably run my config-bisect and see what it comes up with. ktest config bisect ended with:

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-19 Thread Steven Rostedt
On Fri, 19 May 2017 06:08:56 -0400 Steven Rostedt wrote: > > But other configs on this same hardware work, can you do a diff of a > > working vs. not working? > > I could probably run my config-bisect and see what it comes up with. ktest config bisect ended with:

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-19 Thread Steven Rostedt
On Fri, 19 May 2017 10:20:03 +0200 Christoph Hellwig wrote: > On Thu, May 18, 2017 at 11:42:34PM -0400, Steven Rostedt wrote: > > > > One of my the configs I use to test ftrace with (configs that have > > caused failures in the past), has lots of irq issues and fails to > >

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-19 Thread Steven Rostedt
On Fri, 19 May 2017 10:20:03 +0200 Christoph Hellwig wrote: > On Thu, May 18, 2017 at 11:42:34PM -0400, Steven Rostedt wrote: > > > > One of my the configs I use to test ftrace with (configs that have > > caused failures in the past), has lots of irq issues and fails to > > initialize the

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-19 Thread Steven Rostedt
On Fri, 19 May 2017 07:42:23 +0200 Greg Kroah-Hartman wrote: > On Thu, May 18, 2017 at 11:42:34PM -0400, Steven Rostedt wrote: > > > > One of my the configs I use to test ftrace with (configs that have > > caused failures in the past), has lots of irq issues and

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-19 Thread Steven Rostedt
On Fri, 19 May 2017 07:42:23 +0200 Greg Kroah-Hartman wrote: > On Thu, May 18, 2017 at 11:42:34PM -0400, Steven Rostedt wrote: > > > > One of my the configs I use to test ftrace with (configs that have > > caused failures in the past), has lots of irq issues and fails to > > initialize the

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-19 Thread Christoph Hellwig
On Thu, May 18, 2017 at 11:42:34PM -0400, Steven Rostedt wrote: > > One of my the configs I use to test ftrace with (configs that have > caused failures in the past), has lots of irq issues and fails to > initialize the network of my box. I bisected the problem down to a > single commit, and when

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-19 Thread Christoph Hellwig
On Thu, May 18, 2017 at 11:42:34PM -0400, Steven Rostedt wrote: > > One of my the configs I use to test ftrace with (configs that have > caused failures in the past), has lots of irq issues and fails to > initialize the network of my box. I bisected the problem down to a > single commit, and when

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-18 Thread Greg Kroah-Hartman
On Thu, May 18, 2017 at 11:42:34PM -0400, Steven Rostedt wrote: > > One of my the configs I use to test ftrace with (configs that have > caused failures in the past), has lots of irq issues and fails to > initialize the network of my box. I bisected the problem down to a > single commit, and when

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

2017-05-18 Thread Greg Kroah-Hartman
On Thu, May 18, 2017 at 11:42:34PM -0400, Steven Rostedt wrote: > > One of my the configs I use to test ftrace with (configs that have > caused failures in the past), has lots of irq issues and fails to > initialize the network of my box. I bisected the problem down to a > single commit, and when