Re: [RFC PATCH 6/6] soundwire: qcom: add support for SoundWire controller

2019-06-10 Thread Srinivas Kandagatla
Thanks for taking time to review! On 10/06/2019 07:40, Vinod Koul wrote: On 07-06-19, 09:56, Srinivas Kandagatla wrote: Qualcomm SoundWire Master controller is present in most Qualcomm SoCs either integrated as part of WCD audio codecs via slimbus or as part of SOC I/O. This patchset adds

Re: [RFC PATCH 6/6] soundwire: qcom: add support for SoundWire controller

2019-06-10 Thread Vinod Koul
On 07-06-19, 09:56, Srinivas Kandagatla wrote: > Qualcomm SoundWire Master controller is present in most Qualcomm SoCs > either integrated as part of WCD audio codecs via slimbus or > as part of SOC I/O. > > This patchset adds support to a very basic controller which has been > tested with

Re: [RFC PATCH 6/6] soundwire: qcom: add support for SoundWire controller

2019-06-09 Thread Srinivas Kandagatla
Thanks for taking time to review, I agre with most of the comments specially handling returns and making code more readable. Will fix them in next version. On 08/06/2019 22:53, Cezary Rojewski wrote: On 2019-06-07 10:56, Srinivas Kandagatla wrote: Qualcomm SoundWire Master controller is

Re: [RFC PATCH 6/6] soundwire: qcom: add support for SoundWire controller

2019-06-08 Thread Cezary Rojewski
On 2019-06-07 10:56, Srinivas Kandagatla wrote: Qualcomm SoundWire Master controller is present in most Qualcomm SoCs either integrated as part of WCD audio codecs via slimbus or as part of SOC I/O. This patchset adds support to a very basic controller which has been tested with WCD934x