Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, Apr 9, 2018 at 11:00 AM, Kees Cook wrote: > > Can we update the comment near the top to explain why we need > __UNIQUE_ID() since we've now rediscovered why it was originally > there? Too late, since it's already committed in my tree and going through the build

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, Apr 9, 2018 at 11:00 AM, Kees Cook wrote: > > Can we update the comment near the top to explain why we need > __UNIQUE_ID() since we've now rediscovered why it was originally > there? Too late, since it's already committed in my tree and going through the build test paces. But I really

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, Apr 9, 2018 at 10:14 AM, Linus Torvalds wrote: > On Mon, Apr 9, 2018 at 10:03 AM, Linus Torvalds > wrote: >> >> Our old "min()" had the internal variables called "min1" and "min2", >> which is crazy too. > > Actually, no, it

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, Apr 9, 2018 at 10:14 AM, Linus Torvalds wrote: > On Mon, Apr 9, 2018 at 10:03 AM, Linus Torvalds > wrote: >> >> Our old "min()" had the internal variables called "min1" and "min2", >> which is crazy too. > > Actually, no, it used the really cumbersome "__UNIQUE_ID" and then > passed that

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, Apr 9, 2018 at 10:14 AM, Linus Torvalds wrote: > > Ugh, I find that really nasty to read, but it was obviously done > because we hit this before. Side note, we have a *lof* of those "__x" and "__y" names in the helper macros. Clearly min/max was the only

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, Apr 9, 2018 at 10:14 AM, Linus Torvalds wrote: > > Ugh, I find that really nasty to read, but it was obviously done > because we hit this before. Side note, we have a *lof* of those "__x" and "__y" names in the helper macros. Clearly min/max was the only one we really had ever hit

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, 9 Apr 2018, Linus Torvalds wrote: > On Mon, Apr 9, 2018 at 10:03 AM, Linus Torvalds > wrote: > > > > Our old "min()" had the internal variables called "min1" and "min2", > > which is crazy too. > > Actually, no, it used the really cumbersome "__UNIQUE_ID"

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, 9 Apr 2018, Linus Torvalds wrote: > On Mon, Apr 9, 2018 at 10:03 AM, Linus Torvalds > wrote: > > > > Our old "min()" had the internal variables called "min1" and "min2", > > which is crazy too. > > Actually, no, it used the really cumbersome "__UNIQUE_ID" and then > passed that odd as

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, Apr 9, 2018 at 10:11 AM, Sebastian Ott wrote: > > Arghso obvious now :-) > > When I change these it works. Mind testing the slightly more complex patch I just emailed out, and I can commit it? Linus

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, Apr 9, 2018 at 10:11 AM, Sebastian Ott wrote: > > Arghso obvious now :-) > > When I change these it works. Mind testing the slightly more complex patch I just emailed out, and I can commit it? Linus

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, Apr 9, 2018 at 10:03 AM, Linus Torvalds wrote: > > Our old "min()" had the internal variables called "min1" and "min2", > which is crazy too. Actually, no, it used the really cumbersome "__UNIQUE_ID" and then passed that odd as the name 'min1/2', Ugh, I

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, Apr 9, 2018 at 10:03 AM, Linus Torvalds wrote: > > Our old "min()" had the internal variables called "min1" and "min2", > which is crazy too. Actually, no, it used the really cumbersome "__UNIQUE_ID" and then passed that odd as the name 'min1/2', Ugh, I find that really nasty to read,

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, 9 Apr 2018, Linus Torvalds wrote: > On Mon, Apr 9, 2018 at 9:18 AM, Sebastian Ott wrote: > > > > Both of the following return 0 on my machine: > > + pr_warn("%u\n", min_not_zero(100, 1000)); > > + pr_warn("%u\n", min_not_zero(1000, 100)); > > Oooh. > >

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, 9 Apr 2018, Linus Torvalds wrote: > On Mon, Apr 9, 2018 at 9:18 AM, Sebastian Ott wrote: > > > > Both of the following return 0 on my machine: > > + pr_warn("%u\n", min_not_zero(100, 1000)); > > + pr_warn("%u\n", min_not_zero(1000, 100)); > > Oooh. > > [ Raises hand, and

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, Apr 9, 2018 at 9:18 AM, Sebastian Ott wrote: > > Both of the following return 0 on my machine: > + pr_warn("%u\n", min_not_zero(100, 1000)); > + pr_warn("%u\n", min_not_zero(1000, 100)); Oooh. [ Raises hand, and says "I know, I know, pick me, pick me" ]

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, Apr 9, 2018 at 9:18 AM, Sebastian Ott wrote: > > Both of the following return 0 on my machine: > + pr_warn("%u\n", min_not_zero(100, 1000)); > + pr_warn("%u\n", min_not_zero(1000, 100)); Oooh. [ Raises hand, and says "I know, I know, pick me, pick me" ] min_not_zero()

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, 9 Apr 2018, Sebastian Ott wrote: > On Fri, 6 Apr 2018, Kees Cook wrote: > > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott > > wrote: > > > Today's kernel oopsed on s390. Bisect points to: > > > 3c8ba0d61d04 ("kernel.h: Retain constant expression output for > >

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, 9 Apr 2018, Sebastian Ott wrote: > On Fri, 6 Apr 2018, Kees Cook wrote: > > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott > > wrote: > > > Today's kernel oopsed on s390. Bisect points to: > > > 3c8ba0d61d04 ("kernel.h: Retain constant expression output for > > > max()/min()") > > > > >

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Fri, 6 Apr 2018, Kees Cook wrote: > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott > wrote: > > Today's kernel oopsed on s390. Bisect points to: > > 3c8ba0d61d04 ("kernel.h: Retain constant expression output for max()/min()") > > > > [1.898277] dasd-eckd

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Fri, 6 Apr 2018, Kees Cook wrote: > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott > wrote: > > Today's kernel oopsed on s390. Bisect points to: > > 3c8ba0d61d04 ("kernel.h: Retain constant expression output for max()/min()") > > > > [1.898277] dasd-eckd 0.0.3304: DASD with 4 KB/block,

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Fri, 6 Apr 2018, Kees Cook wrote: > On Fri, Apr 6, 2018 at 9:47 AM, Kees Cook wrote: > > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott > > wrote: > >> Today's kernel oopsed on s390. Bisect points to: > >> 3c8ba0d61d04 ("kernel.h: Retain

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Fri, 6 Apr 2018, Kees Cook wrote: > On Fri, Apr 6, 2018 at 9:47 AM, Kees Cook wrote: > > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott > > wrote: > >> Today's kernel oopsed on s390. Bisect points to: > >> 3c8ba0d61d04 ("kernel.h: Retain constant expression output for > >> max()/min()") > >>

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Fri, Apr 6, 2018 at 9:47 AM, Kees Cook wrote: > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott > wrote: >> Today's kernel oopsed on s390. Bisect points to: >> 3c8ba0d61d04 ("kernel.h: Retain constant expression output for max()/min()") >> >> [

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Fri, Apr 6, 2018 at 9:47 AM, Kees Cook wrote: > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott > wrote: >> Today's kernel oopsed on s390. Bisect points to: >> 3c8ba0d61d04 ("kernel.h: Retain constant expression output for max()/min()") >> >> [1.898277] dasd-eckd 0.0.3304: DASD with 4

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott wrote: > Today's kernel oopsed on s390. Bisect points to: > 3c8ba0d61d04 ("kernel.h: Retain constant expression output for max()/min()") > > [1.898277] dasd-eckd 0.0.3304: DASD with 4 KB/block, 21636720 KB total > size,

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott wrote: > Today's kernel oopsed on s390. Bisect points to: > 3c8ba0d61d04 ("kernel.h: Retain constant expression output for max()/min()") > > [1.898277] dasd-eckd 0.0.3304: DASD with 4 KB/block, 21636720 KB total > size, 48 KB/track, compatible