Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Cyrill Gorcunov
[David Woodhouse - Thu, Jan 03, 2008 at 02:57:08PM +] | | On Thu, 2008-01-03 at 17:50 +0300, Cyrill Gorcunov wrote: | > | > | > so what i would do now? i could post updated patch *without* that | > splitted line, should I? | | And with the if (rc == 0) thing fixed too. Yes please. | | --

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread David Woodhouse
On Thu, 2008-01-03 at 17:50 +0300, Cyrill Gorcunov wrote: > > > so what i would do now? i could post updated patch *without* that > splitted line, should I? And with the if (rc == 0) thing fixed too. Yes please. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Cyrill Gorcunov
[David Woodhouse - Thu, Jan 03, 2008 at 02:37:24PM +] | | On Thu, 2008-01-03 at 15:37 +0100, Ingo Molnar wrote: | > * David Woodhouse <[EMAIL PROTECTED]> wrote: | > | > > On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote: | > > > not to make a big issue out of this, but when was the last

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread David Woodhouse
On Thu, 2008-01-03 at 15:37 +0100, Ingo Molnar wrote: > * David Woodhouse <[EMAIL PROTECTED]> wrote: > > > On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote: > > > not to make a big issue out of this, but when was the last time you > > > tried to grep this way: > > > > > > grep -E

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Ingo Molnar
* David Woodhouse <[EMAIL PROTECTED]> wrote: > On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote: > > not to make a big issue out of this, but when was the last time you > > tried to grep this way: > > > > grep -E "audit_rate_limit=[0-9]+ audit_backlog" */*.c > > Not precisely that, but

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread David Woodhouse
On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote: > not to make a big issue out of this, but when was the last time you > tried to grep this way: > > grep -E "audit_rate_limit=[0-9]+ audit_backlog" */*.c Not precisely that, but I've certainly had greps fail because people have split up

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Ingo Molnar
* Jörn Engel <[EMAIL PROTECTED]> wrote: > > - "audit: audit_lost=%d audit_rate_limit=%d > > audit_backlog_limit=%d\n", > > + "audit: audit_lost=%d audit_rate_limit=%d " > > + "audit_backlog_limit=%d\n", > >

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Cyrill Gorcunov
[Tomas Carnecky - Thu, Jan 03, 2008 at 01:10:28PM +0100] > Cyrill Gorcunov wrote: >> [=?ISO-8859-1?Q?J=F6rn_Engel_ - Thu, Jan 03, 2008 at 12:29:57PM +0100] >> | On Thu, 3 January 2008 14:19:25 +0300, Cyrill Gorcunov wrote: >> | > @@ -232,7 +232,8 @@ void audit_log_lost(const char *message) >> | >

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Tomas Carnecky
Cyrill Gorcunov wrote: [=?ISO-8859-1?Q?J=F6rn_Engel_ - Thu, Jan 03, 2008 at 12:29:57PM +0100] | On Thu, 3 January 2008 14:19:25 +0300, Cyrill Gorcunov wrote: | > @@ -232,7 +232,8 @@ void audit_log_lost(const char *message) | > | > if (print) { | > printk(KERN_WARNING | > -

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Cyrill Gorcunov
[=?ISO-8859-1?Q?J=F6rn_Engel_ - Thu, Jan 03, 2008 at 12:29:57PM +0100] | On Thu, 3 January 2008 14:19:25 +0300, Cyrill Gorcunov wrote: | > @@ -232,7 +232,8 @@ void audit_log_lost(const char *message) | > | > if (print) { | > printk(KERN_WARNING | > - "audit:

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Jörn Engel
On Thu, 3 January 2008 14:19:25 +0300, Cyrill Gorcunov wrote: > @@ -232,7 +232,8 @@ void audit_log_lost(const char *message) > > if (print) { > printk(KERN_WARNING > -"audit: audit_lost=%d audit_rate_limit=%d > audit_backlog_limit=%d\n", > +

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Jörn Engel
On Thu, 3 January 2008 14:19:25 +0300, Cyrill Gorcunov wrote: @@ -232,7 +232,8 @@ void audit_log_lost(const char *message) if (print) { printk(KERN_WARNING -audit: audit_lost=%d audit_rate_limit=%d audit_backlog_limit=%d\n, +

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Cyrill Gorcunov
[=?ISO-8859-1?Q?J=F6rn_Engel_ - Thu, Jan 03, 2008 at 12:29:57PM +0100] | On Thu, 3 January 2008 14:19:25 +0300, Cyrill Gorcunov wrote: | @@ -232,7 +232,8 @@ void audit_log_lost(const char *message) | | if (print) { | printk(KERN_WARNING | - audit:

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Cyrill Gorcunov
[Tomas Carnecky - Thu, Jan 03, 2008 at 01:10:28PM +0100] Cyrill Gorcunov wrote: [=?ISO-8859-1?Q?J=F6rn_Engel_ - Thu, Jan 03, 2008 at 12:29:57PM +0100] | On Thu, 3 January 2008 14:19:25 +0300, Cyrill Gorcunov wrote: | @@ -232,7 +232,8 @@ void audit_log_lost(const char *message) | | if

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Tomas Carnecky
Cyrill Gorcunov wrote: [=?ISO-8859-1?Q?J=F6rn_Engel_ - Thu, Jan 03, 2008 at 12:29:57PM +0100] | On Thu, 3 January 2008 14:19:25 +0300, Cyrill Gorcunov wrote: | @@ -232,7 +232,8 @@ void audit_log_lost(const char *message) | | if (print) { | printk(KERN_WARNING | -

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Ingo Molnar
* Jörn Engel [EMAIL PROTECTED] wrote: - audit: audit_lost=%d audit_rate_limit=%d audit_backlog_limit=%d\n, + audit: audit_lost=%d audit_rate_limit=%d + audit_backlog_limit=%d\n, atomic_read(audit_lost),

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Ingo Molnar
* David Woodhouse [EMAIL PROTECTED] wrote: On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote: not to make a big issue out of this, but when was the last time you tried to grep this way: grep -E audit_rate_limit=[0-9]+ audit_backlog */*.c Not precisely that, but I've certainly

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Cyrill Gorcunov
[David Woodhouse - Thu, Jan 03, 2008 at 02:37:24PM +] | | On Thu, 2008-01-03 at 15:37 +0100, Ingo Molnar wrote: | * David Woodhouse [EMAIL PROTECTED] wrote: | | On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote: |not to make a big issue out of this, but when was the last time you

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread David Woodhouse
On Thu, 2008-01-03 at 15:37 +0100, Ingo Molnar wrote: * David Woodhouse [EMAIL PROTECTED] wrote: On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote: not to make a big issue out of this, but when was the last time you tried to grep this way: grep -E audit_rate_limit=[0-9]+

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread David Woodhouse
On Thu, 2008-01-03 at 17:50 +0300, Cyrill Gorcunov wrote: so what i would do now? i could post updated patch *without* that splitted line, should I? And with the if (rc == 0) thing fixed too. Yes please. -- dwmw2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Cyrill Gorcunov
[David Woodhouse - Thu, Jan 03, 2008 at 02:57:08PM +] | | On Thu, 2008-01-03 at 17:50 +0300, Cyrill Gorcunov wrote: | | | so what i would do now? i could post updated patch *without* that | splitted line, should I? | | And with the if (rc == 0) thing fixed too. Yes please. | | -- |