Re: Regression from efi: call get_event_log before ExitBootServices

On Mon, Mar 12, 2018 at 11:41:25AM +0100, Paul Menzel wrote: > Dear Jarkko, > > > On 03/12/18 11:17, Jarkko Sakkinen wrote: > > On Sat, 2018-03-10 at 10:45 +, Thiebaud Weksteen wrote: > > > On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > > > > and it's hanging at

Re: Regression from efi: call get_event_log before ExitBootServices

On Mon, Mar 12, 2018 at 11:41:25AM +0100, Paul Menzel wrote: > Dear Jarkko, > > > On 03/12/18 11:17, Jarkko Sakkinen wrote: > > On Sat, 2018-03-10 at 10:45 +, Thiebaud Weksteen wrote: > > > On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > > > > and it's hanging at "memset(log_tbl, 0,

Re: Regression from efi: call get_event_log before ExitBootServices

On Tue, Mar 13, 2018 at 2:43 PM Ard Biesheuvel wrote: > On 13 March 2018 at 13:41, Jeremy Cline wrote: > > On 03/13/2018 03:59 AM, Ard Biesheuvel wrote: > >> On 13 March 2018 at 07:47, Hans de Goede wrote: > >>> Hi, > >>> > >>>

Re: Regression from efi: call get_event_log before ExitBootServices

On Tue, Mar 13, 2018 at 2:43 PM Ard Biesheuvel wrote: > On 13 March 2018 at 13:41, Jeremy Cline wrote: > > On 03/13/2018 03:59 AM, Ard Biesheuvel wrote: > >> On 13 March 2018 at 07:47, Hans de Goede wrote: > >>> Hi, > >>> > >>> > >>> On 12-03-18 20:55, Thiebaud Weksteen wrote: > > >> ...

Re: Regression from efi: call get_event_log before ExitBootServices

On 13 March 2018 at 13:41, Jeremy Cline wrote: > On 03/13/2018 03:59 AM, Ard Biesheuvel wrote: >> On 13 March 2018 at 07:47, Hans de Goede wrote: >>> Hi, >>> >>> >>> On 12-03-18 20:55, Thiebaud Weksteen wrote: >> ... Hans, you said you

Re: Regression from efi: call get_event_log before ExitBootServices

On 13 March 2018 at 13:41, Jeremy Cline wrote: > On 03/13/2018 03:59 AM, Ard Biesheuvel wrote: >> On 13 March 2018 at 07:47, Hans de Goede wrote: >>> Hi, >>> >>> >>> On 12-03-18 20:55, Thiebaud Weksteen wrote: >> ... Hans, you said you configured the tablet to use the 32-bit

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/13/2018 03:59 AM, Ard Biesheuvel wrote: > On 13 March 2018 at 07:47, Hans de Goede wrote: >> Hi, >> >> >> On 12-03-18 20:55, Thiebaud Weksteen wrote: >>> > ... >>> >>> Hans, you said you configured the tablet to use the 32-bit version of grub >>> instead >>> of 64.

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/13/2018 03:59 AM, Ard Biesheuvel wrote: > On 13 March 2018 at 07:47, Hans de Goede wrote: >> Hi, >> >> >> On 12-03-18 20:55, Thiebaud Weksteen wrote: >>> > ... >>> >>> Hans, you said you configured the tablet to use the 32-bit version of grub >>> instead >>> of 64. Why's that? >> >> >>

Re: Regression from efi: call get_event_log before ExitBootServices

On Tue, Mar 13, 2018 at 9:47 AM, Hans de Goede wrote: > On 12-03-18 20:55, Thiebaud Weksteen wrote: >> Hans, you said you configured the tablet to use the 32-bit version of grub >> instead >> of 64. Why's that? > Because this tablet, like (almost?) all Bay Trail hardware

Re: Regression from efi: call get_event_log before ExitBootServices

On Tue, Mar 13, 2018 at 9:47 AM, Hans de Goede wrote: > On 12-03-18 20:55, Thiebaud Weksteen wrote: >> Hans, you said you configured the tablet to use the 32-bit version of grub >> instead >> of 64. Why's that? > Because this tablet, like (almost?) all Bay Trail hardware has a 32 bit > UEFI, >

Re: Regression from efi: call get_event_log before ExitBootServices

On 13 March 2018 at 10:23, Thiebaud Weksteen wrote: > On Tue, Mar 13, 2018 at 8:59 AM Ard Biesheuvel > wrote: > >> On 13 March 2018 at 07:47, Hans de Goede wrote: ... >> > Could the problem perhaps be that the new code for the

Re: Regression from efi: call get_event_log before ExitBootServices

On 13 March 2018 at 10:23, Thiebaud Weksteen wrote: > On Tue, Mar 13, 2018 at 8:59 AM Ard Biesheuvel > wrote: > >> On 13 March 2018 at 07:47, Hans de Goede wrote: ... >> > Could the problem perhaps be that the new code for the TPM event-log is >> > missing some handling to deal with running on

Re: Regression from efi: call get_event_log before ExitBootServices

On Tue, Mar 13, 2018 at 8:59 AM Ard Biesheuvel wrote: > On 13 March 2018 at 07:47, Hans de Goede wrote: > > Hi, > > > > > > On 12-03-18 20:55, Thiebaud Weksteen wrote: > >> > ... > >> > >> Hans, you said you configured the tablet to use the 32-bit

Re: Regression from efi: call get_event_log before ExitBootServices

On Tue, Mar 13, 2018 at 8:59 AM Ard Biesheuvel wrote: > On 13 March 2018 at 07:47, Hans de Goede wrote: > > Hi, > > > > > > On 12-03-18 20:55, Thiebaud Weksteen wrote: > >> > ... > >> > >> Hans, you said you configured the tablet to use the 32-bit version of grub > >> instead > >> of 64. Why's

Re: Regression from efi: call get_event_log before ExitBootServices

Hi, On 12-03-18 22:02, Ard Biesheuvel wrote: On 12 March 2018 at 19:55, Thiebaud Weksteen wrote: On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel <

Re: Regression from efi: call get_event_log before ExitBootServices

Hi, On 12-03-18 22:02, Ard Biesheuvel wrote: On 12 March 2018 at 19:55, Thiebaud Weksteen wrote: On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < ard.biesheu...@linaro.org> wrote: On

Re: Regression from efi: call get_event_log before ExitBootServices

On 13 March 2018 at 07:59, Ard Biesheuvel wrote: > On 13 March 2018 at 07:47, Hans de Goede wrote: >> Hi, >> >> >> On 12-03-18 20:55, Thiebaud Weksteen wrote: >>> > ... >>> >>> Hans, you said you configured the tablet to use the 32-bit version of

Re: Regression from efi: call get_event_log before ExitBootServices

On 13 March 2018 at 07:59, Ard Biesheuvel wrote: > On 13 March 2018 at 07:47, Hans de Goede wrote: >> Hi, >> >> >> On 12-03-18 20:55, Thiebaud Weksteen wrote: >>> > ... >>> >>> Hans, you said you configured the tablet to use the 32-bit version of grub >>> instead >>> of 64. Why's that? >> >> >>

Re: Regression from efi: call get_event_log before ExitBootServices

On 13 March 2018 at 07:47, Hans de Goede wrote: > Hi, > > > On 12-03-18 20:55, Thiebaud Weksteen wrote: >> ... >> >> Hans, you said you configured the tablet to use the 32-bit version of grub >> instead >> of 64. Why's that? > > > Because this tablet, like (almost?) all Bay

Re: Regression from efi: call get_event_log before ExitBootServices

On 13 March 2018 at 07:47, Hans de Goede wrote: > Hi, > > > On 12-03-18 20:55, Thiebaud Weksteen wrote: >> ... >> >> Hans, you said you configured the tablet to use the 32-bit version of grub >> instead >> of 64. Why's that? > > > Because this tablet, like (almost?) all Bay Trail hardware has a

Re: Regression from efi: call get_event_log before ExitBootServices

Hi, On 12-03-18 20:55, Thiebaud Weksteen wrote: On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < ard.biesheu...@linaro.org> wrote: On 12 March 2018 at 17:01, Jeremy

Re: Regression from efi: call get_event_log before ExitBootServices

Hi, On 12-03-18 20:55, Thiebaud Weksteen wrote: On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < ard.biesheu...@linaro.org> wrote: On 12 March 2018 at 17:01, Jeremy Cline wrote: On

Re: Regression from efi: call get_event_log before ExitBootServices

On Mon, Mar 12, 2018 at 10:03 PM Ard Biesheuvel wrote: > On 12 March 2018 at 19:55, Thiebaud Weksteen wrote: > > On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > > > >> On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: > >> >

Re: Regression from efi: call get_event_log before ExitBootServices

On Mon, Mar 12, 2018 at 10:03 PM Ard Biesheuvel wrote: > On 12 March 2018 at 19:55, Thiebaud Weksteen wrote: > > On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > > > >> On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: > >> > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < > >

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/12/2018 03:55 PM, Thiebaud Weksteen wrote: > On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > >> On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: >>> On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < > ard.biesheu...@linaro.org> >>> wrote: >>> On 12 March 2018

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/12/2018 03:55 PM, Thiebaud Weksteen wrote: > On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > >> On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: >>> On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < > ard.biesheu...@linaro.org> >>> wrote: >>> On 12 March 2018 at 17:01, Jeremy

Re: Regression from efi: call get_event_log before ExitBootServices

On 12 March 2018 at 19:55, Thiebaud Weksteen wrote: > On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > >> On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: >> > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < > ard.biesheu...@linaro.org> >> > wrote: >> >

Re: Regression from efi: call get_event_log before ExitBootServices

On 12 March 2018 at 19:55, Thiebaud Weksteen wrote: > On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > >> On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: >> > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < > ard.biesheu...@linaro.org> >> > wrote: >> > >> >> On 12 March 2018 at 17:01,

Re: Regression from efi: call get_event_log before ExitBootServices

On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: > > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < ard.biesheu...@linaro.org> > > wrote: > > > >> On 12 March 2018 at 17:01, Jeremy Cline wrote: > >>>

Re: Regression from efi: call get_event_log before ExitBootServices

On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: > > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < ard.biesheu...@linaro.org> > > wrote: > > > >> On 12 March 2018 at 17:01, Jeremy Cline wrote: > >>> On 03/12/2018 10:56 AM, Ard Biesheuvel

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel > wrote: > >> On 12 March 2018 at 17:01, Jeremy Cline wrote: >>> On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: On 12 March 2018 at 14:30, Jeremy

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel > wrote: > >> On 12 March 2018 at 17:01, Jeremy Cline wrote: >>> On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: On 12 March 2018 at 14:30, Jeremy Cline wrote: > On 03/12/2018 07:08 AM, Ard

Re: Regression from efi: call get_event_log before ExitBootServices

On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel wrote: > On 12 March 2018 at 17:01, Jeremy Cline wrote: > > On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: > >> On 12 March 2018 at 14:30, Jeremy Cline wrote: > >>> On 03/12/2018

Re: Regression from efi: call get_event_log before ExitBootServices

On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel wrote: > On 12 March 2018 at 17:01, Jeremy Cline wrote: > > On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: > >> On 12 March 2018 at 14:30, Jeremy Cline wrote: > >>> On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: > On 10 March 2018 at 10:45,

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/12/2018 01:30 PM, Ard Biesheuvel wrote: > On 12 March 2018 at 17:01, Jeremy Cline wrote: >> On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: >>> On 12 March 2018 at 14:30, Jeremy Cline wrote: On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: > On 10

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/12/2018 01:30 PM, Ard Biesheuvel wrote: > On 12 March 2018 at 17:01, Jeremy Cline wrote: >> On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: >>> On 12 March 2018 at 14:30, Jeremy Cline wrote: On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: > On 10 March 2018 at 10:45, Thiebaud Weksteen

Re: Regression from efi: call get_event_log before ExitBootServices

On 12 March 2018 at 17:01, Jeremy Cline wrote: > On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: >> On 12 March 2018 at 14:30, Jeremy Cline wrote: >>> On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: On 10 March 2018 at 10:45, Thiebaud Weksteen

Re: Regression from efi: call get_event_log before ExitBootServices

On 12 March 2018 at 17:01, Jeremy Cline wrote: > On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: >> On 12 March 2018 at 14:30, Jeremy Cline wrote: >>> On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: > On Fri, Mar 9, 2018 at 5:54 PM Jeremy

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: > On 12 March 2018 at 14:30, Jeremy Cline wrote: >> On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: >>> On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: > On 12 March 2018 at 14:30, Jeremy Cline wrote: >> On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: >>> On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > On Fri, Mar 09, 2018 at

Re: Regression from efi: call get_event_log before ExitBootServices

On 12 March 2018 at 14:30, Jeremy Cline wrote: > On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: >> On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: >>> On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: >>> On Fri, Mar 09, 2018 at

Re: Regression from efi: call get_event_log before ExitBootServices

On 12 March 2018 at 14:30, Jeremy Cline wrote: > On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: >> On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: >>> On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: >>> On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: > Thanks a

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: > On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: >> On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: >> >>> On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: Thanks a lot for trying

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: > On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: >> On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: >> >>> On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: Thanks a lot for trying out the patch! Please don't

Re: Regression from efi: call get_event_log before ExitBootServices

On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: > On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > >> On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: >> > Thanks a lot for trying out the patch! >> > >> > Please don't modify your

Re: Regression from efi: call get_event_log before ExitBootServices

On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: > On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > >> On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: >> > Thanks a lot for trying out the patch! >> > >> > Please don't modify your install at this stage, I think we are

Re: Regression from efi: call get_event_log before ExitBootServices

Dear Jarkko, On 03/12/18 11:17, Jarkko Sakkinen wrote: On Sat, 2018-03-10 at 10:45 +, Thiebaud Weksteen wrote: On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: and it's hanging at "memset(log_tbl, 0, sizeof(*log_tbl) + log_size);" Thanks. Well, it looks like the

Re: Regression from efi: call get_event_log before ExitBootServices

Dear Jarkko, On 03/12/18 11:17, Jarkko Sakkinen wrote: On Sat, 2018-03-10 at 10:45 +, Thiebaud Weksteen wrote: On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: and it's hanging at "memset(log_tbl, 0, sizeof(*log_tbl) + log_size);" Thanks. Well, it looks like the memory that is

Re: Regression from efi: call get_event_log before ExitBootServices

On Sat, 2018-03-10 at 10:45 +, Thiebaud Weksteen wrote: > On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > > and it's hanging at "memset(log_tbl, 0, sizeof(*log_tbl) + log_size);" > > Thanks. Well, it looks like the memory that is supposedly allocated is not > usable.

Re: Regression from efi: call get_event_log before ExitBootServices

On Sat, 2018-03-10 at 10:45 +, Thiebaud Weksteen wrote: > On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > > and it's hanging at "memset(log_tbl, 0, sizeof(*log_tbl) + log_size);" > > Thanks. Well, it looks like the memory that is supposedly allocated is not > usable. I'm thinking this

Re: Regression from efi: call get_event_log before ExitBootServices

On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: > > Thanks a lot for trying out the patch! > > > > Please don't modify your install at this stage, I think we are hitting a > > firmware bug and that would

Re: Regression from efi: call get_event_log before ExitBootServices

On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: > > Thanks a lot for trying out the patch! > > > > Please don't modify your install at this stage, I think we are hitting a > > firmware bug and that would be awesome if we can

Re: Regression from efi: call get_event_log before ExitBootServices

On Fri, 2018-03-09 at 10:29 +0100, Hans de Goede wrote: > Hi, > > On 08-03-18 18:26, Jeremy Cline wrote: > > > > On 03/08/2018 11:50 AM, Hans de Goede wrote: [...] > > > > The UEFI firmware does some measurements and so does shim. So > > > > you should have some event logs. What version of shim

Re: Regression from efi: call get_event_log before ExitBootServices

On Fri, 2018-03-09 at 10:29 +0100, Hans de Goede wrote: > Hi, > > On 08-03-18 18:26, Jeremy Cline wrote: > > > > On 03/08/2018 11:50 AM, Hans de Goede wrote: [...] > > > > The UEFI firmware does some measurements and so does shim. So > > > > you should have some event logs. What version of shim

Re: Regression from efi: call get_event_log before ExitBootServices

On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: > Thanks a lot for trying out the patch! > > Please don't modify your install at this stage, I think we are hitting a > firmware bug and that would be awesome if we can fix how we are handling it. > So, if we reach that stage in

Re: Regression from efi: call get_event_log before ExitBootServices

On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: > Thanks a lot for trying out the patch! > > Please don't modify your install at this stage, I think we are hitting a > firmware bug and that would be awesome if we can fix how we are handling it. > So, if we reach that stage in

Re: Regression from efi: call get_event_log before ExitBootServices

--- drivers/firmware/efi/libstub/tpm.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/firmware/efi/libstub/tpm.c b/drivers/firmware/efi/libstub/tpm.c index 773afcd6a37c..ee3fac109078 100644 --- a/drivers/firmware/efi/libstub/tpm.c +++

Re: Regression from efi: call get_event_log before ExitBootServices

--- drivers/firmware/efi/libstub/tpm.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/firmware/efi/libstub/tpm.c b/drivers/firmware/efi/libstub/tpm.c index 773afcd6a37c..ee3fac109078 100644 --- a/drivers/firmware/efi/libstub/tpm.c +++

Re: Regression from efi: call get_event_log before ExitBootServices

On Fri, Mar 9, 2018 at 10:29 AM Hans de Goede wrote: > Hi, > On 08-03-18 18:26, Jeremy Cline wrote: > > On 03/08/2018 11:50 AM, Hans de Goede wrote: > >> >> added these now> > >> > >> Hi, > >> > >> On 07-03-18 12:34, Javier Martinez Canillas wrote: > > > > > > > >>> Are

Re: Regression from efi: call get_event_log before ExitBootServices

On Fri, Mar 9, 2018 at 10:29 AM Hans de Goede wrote: > Hi, > On 08-03-18 18:26, Jeremy Cline wrote: > > On 03/08/2018 11:50 AM, Hans de Goede wrote: > >> >> added these now> > >> > >> Hi, > >> > >> On 07-03-18 12:34, Javier Martinez Canillas wrote: > > > > > > > >>> Are you also able to read

Re: Regression from efi: call get_event_log before ExitBootServices

Hi, On 08-03-18 18:26, Jeremy Cline wrote: On 03/08/2018 11:50 AM, Hans de Goede wrote: Hi, On 07-03-18 12:34, Javier Martinez Canillas wrote: Are you also able to read the TPM event logs? $ hexdump /sys/kernel/security/tpm0/binary_bios_measurements Yes for me that outputs a lot of

Re: Regression from efi: call get_event_log before ExitBootServices

Hi, On 08-03-18 18:26, Jeremy Cline wrote: On 03/08/2018 11:50 AM, Hans de Goede wrote: Hi, On 07-03-18 12:34, Javier Martinez Canillas wrote: Are you also able to read the TPM event logs? $ hexdump /sys/kernel/security/tpm0/binary_bios_measurements Yes for me that outputs a lot of

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/08/2018 03:45 AM, Thiebaud Weksteen wrote: > Jeremy, Hans, could you both describe precisely how your boot is > configured? This feature is only triggered when booting the EFI stub of the > kernel so this may be not executed if you are using something else in > between. I put everything I

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/08/2018 03:45 AM, Thiebaud Weksteen wrote: > Jeremy, Hans, could you both describe precisely how your boot is > configured? This feature is only triggered when booting the EFI stub of the > kernel so this may be not executed if you are using something else in > between. I put everything I

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/08/2018 11:50 AM, Hans de Goede wrote: > added these now> > > Hi, > > On 07-03-18 12:34, Javier Martinez Canillas wrote: >> Are you also able to read the TPM event logs? >> >> $ hexdump /sys/kernel/security/tpm0/binary_bios_measurements > > Yes for me that outputs a lot of hex :) For

Re: Regression from efi: call get_event_log before ExitBootServices

On 03/08/2018 11:50 AM, Hans de Goede wrote: > added these now> > > Hi, > > On 07-03-18 12:34, Javier Martinez Canillas wrote: >> Are you also able to read the TPM event logs? >> >> $ hexdump /sys/kernel/security/tpm0/binary_bios_measurements > > Yes for me that outputs a lot of hex :) For

Re: Regression from efi: call get_event_log before ExitBootServices

Hi, On 07-03-18 12:34, Javier Martinez Canillas wrote: On 03/07/2018 12:10 PM, Hans de Goede wrote: Both according to the BIOS and to the /sys/class/tpm/tpm0/device/description file it is a TPM 2.0. I see, so you can choose enabling the TPM 1.2 or TPM 2.0 device? At least that's the

Re: Regression from efi: call get_event_log before ExitBootServices

Hi, On 07-03-18 12:34, Javier Martinez Canillas wrote: On 03/07/2018 12:10 PM, Hans de Goede wrote: Both according to the BIOS and to the /sys/class/tpm/tpm0/device/description file it is a TPM 2.0. I see, so you can choose enabling the TPM 1.2 or TPM 2.0 device? At least that's the

Re: Regression from efi: call get_event_log before ExitBootServices

--- drivers/firmware/efi/libstub/tpm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/firmware/efi/libstub/tpm.c b/drivers/firmware/efi/libstub/tpm.c index da661bf8cb96..773afcd6a37c 100644 --- a/drivers/firmware/efi/libstub/tpm.c +++

Re: Regression from efi: call get_event_log before ExitBootServices

--- drivers/firmware/efi/libstub/tpm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/firmware/efi/libstub/tpm.c b/drivers/firmware/efi/libstub/tpm.c index da661bf8cb96..773afcd6a37c 100644 --- a/drivers/firmware/efi/libstub/tpm.c +++

Re: Regression from efi: call get_event_log before ExitBootServices

On Wed, Mar 7, 2018 at 6:33 PM Jeremy Cline wrote: > On 03/07/2018 03:41 AM, Thiebaud Weksteen wrote: > > Hi, > > > > Thanks for testing and sending this report! This patch relies heavily on > > the functions exposed by the firmware. My first guess would be that some of > >

Re: Regression from efi: call get_event_log before ExitBootServices

On Wed, Mar 7, 2018 at 6:33 PM Jeremy Cline wrote: > On 03/07/2018 03:41 AM, Thiebaud Weksteen wrote: > > Hi, > > > > Thanks for testing and sending this report! This patch relies heavily on > > the functions exposed by the firmware. My first guess would be that some of > > these may not be

Re: Regression from efi: call get_event_log before ExitBootServices

Hi Hans, On 03/07/2018 12:16 PM, Hans de Goede wrote: > Hi, > > On 07-03-18 09:41, Thiebaud Weksteen wrote: >> Hi, >> >> Thanks for testing and sending this report! This patch relies heavily on >> the functions exposed by the firmware. My first guess would be that some of >> these may not be

Re: Regression from efi: call get_event_log before ExitBootServices

Hi Hans, On 03/07/2018 12:16 PM, Hans de Goede wrote: > Hi, > > On 07-03-18 09:41, Thiebaud Weksteen wrote: >> Hi, >> >> Thanks for testing and sending this report! This patch relies heavily on >> the functions exposed by the firmware. My first guess would be that some of >> these may not be

Re: Regression from efi: call get_event_log before ExitBootServices

Hi, On 07-03-18 09:41, Thiebaud Weksteen wrote: Hi, Thanks for testing and sending this report! This patch relies heavily on the functions exposed by the firmware. My first guess would be that some of these may not be implemented correctly by the manufacturer. Could you share more information

Re: Regression from efi: call get_event_log before ExitBootServices

Hi, On 07-03-18 09:41, Thiebaud Weksteen wrote: Hi, Thanks for testing and sending this report! This patch relies heavily on the functions exposed by the firmware. My first guess would be that some of these may not be implemented correctly by the manufacturer. Could you share more information

Re: Regression from efi: call get_event_log before ExitBootServices

Hi, Thanks for testing and sending this report! This patch relies heavily on the functions exposed by the firmware. My first guess would be that some of these may not be implemented correctly by the manufacturer. Could you share more information on this specific device? Do you have any link to

Re: Regression from efi: call get_event_log before ExitBootServices

Hi, Thanks for testing and sending this report! This patch relies heavily on the functions exposed by the firmware. My first guess would be that some of these may not be implemented correctly by the manufacturer. Could you share more information on this specific device? Do you have any link to

Regression from efi: call get_event_log before ExitBootServices

Hi folks, Commit 33b6d03469b2 ("efi: call get_event_log before ExitBootServices") causes my GP-electronic T701 tablet to hang when booting. Reverting the patch series or hiding the TPM in the BIOS fixes the problem. I've never fiddled with TPMs before so I'm not sure what what debugging

Regression from efi: call get_event_log before ExitBootServices

Hi folks, Commit 33b6d03469b2 ("efi: call get_event_log before ExitBootServices") causes my GP-electronic T701 tablet to hang when booting. Reverting the patch series or hiding the TPM in the BIOS fixes the problem. I've never fiddled with TPMs before so I'm not sure what what debugging