Re: Regression in 32-bit-compat TIOCGPTPEER ioctl due to 311fc65c9fb9c966bca8e6f3ff8132ce57344ab9

2019-01-17 Thread Greg Kroah-Hartman
On Wed, Jan 16, 2019 at 08:36:49AM +1300, Robert O'Callahan wrote: > On Tue, Jan 15, 2019 at 8:25 PM Eric W. Biederman > wrote: > > Can you confirm this fixes it for you? > > Sorry --- I made a mistake. It looks like this is already fixed on > master, by commit

Re: Regression in 32-bit-compat TIOCGPTPEER ioctl due to 311fc65c9fb9c966bca8e6f3ff8132ce57344ab9

2019-01-15 Thread Robert O'Callahan
On Tue, Jan 15, 2019 at 8:25 PM Eric W. Biederman wrote: > Can you confirm this fixes it for you? Sorry --- I made a mistake. It looks like this is already fixed on master, by commit e21120383f2dce32312f63ffca145ff8a87d41f5 (though I don't think Al Viro knew he was fixing this bug). So, nothing

Re: Regression in 32-bit-compat TIOCGPTPEER ioctl due to 311fc65c9fb9c966bca8e6f3ff8132ce57344ab9

2019-01-14 Thread Eric W. Biederman
"Robert O'Callahan" writes: > This commit refactored the implementation of TIOCGPTPEER, moving "case > TIOCGPTPEER" from pty_unix98_ioctl() to tty_ioctl(). > pty_unix98_ioctl() is called by pty_unix98_compat_ioctl(), so before > the commit, TIOCGPTPEER worked for 32-bit userspace. Unfortunately

Regression in 32-bit-compat TIOCGPTPEER ioctl due to 311fc65c9fb9c966bca8e6f3ff8132ce57344ab9

2019-01-14 Thread Robert O'Callahan
This commit refactored the implementation of TIOCGPTPEER, moving "case TIOCGPTPEER" from pty_unix98_ioctl() to tty_ioctl(). pty_unix98_ioctl() is called by pty_unix98_compat_ioctl(), so before the commit, TIOCGPTPEER worked for 32-bit userspace. Unfortunately tty_compat_ioctl() does not call