Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

2017-08-08 Thread SF Markus Elfring
>> https://patchwork.ozlabs.org/patch/798575/ > > I submitted your patch Thanks for your constructive feedback. https://patchwork.ozlabs.org/patch/798850/ > and a fix to ps3vram_probe() with the other patches in my queue. I find it nice that you picked this change opportunity up after a bit of

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

2017-08-07 Thread Michael Ellerman
SF Markus Elfring writes: I didn't consider one would be triggered by the kzalloc failure. >>> >>> Do you reconsider any special system settings for further >>> software evolution then? >> >> Sorry, I don't quite understand your question. > > Do you try to configure the Linux error reportin

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

2017-08-07 Thread Geoff Levand
On 08/07/2017 12:04 PM, SF Markus Elfring wrote: >> I think your original patch is OK, > > How does this feedback fit to the initial response “Not Applicable”? > https://patchwork.ozlabs.org/patch/798575/ I submitted your patch and a fix to ps3vram_probe() with the other patches in my queue. Tha

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

2017-08-07 Thread SF Markus Elfring
>>> I didn't consider one would be triggered by the kzalloc failure. >> >> Do you reconsider any special system settings for further >> software evolution then? > > Sorry, I don't quite understand your question. Do you try to configure the Linux error reporting to any special needs? > I think y

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

2017-08-07 Thread Geoff Levand
On 08/07/2017 11:34 AM, SF Markus Elfring wrote: >> I didn't consider one would be triggered by the kzalloc failure. > > Do you reconsider any special system settings for further > software evolution then? Sorry, I don't quite understand your question. I think your original patch is OK, and I wo

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

2017-08-07 Thread SF Markus Elfring
>> Do you find the default allocation failure report insufficient? > > The default is OK. Thanks for this information. > I didn't consider one would be triggered by the kzalloc failure. Do you reconsider any special system settings for further software evolution then? Regards, Markus

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

2017-08-07 Thread Geoff Levand
On 08/07/2017 09:27 AM, SF Markus Elfring wrote: >>> Omit an extra message for a memory allocation failure in this function. >>> >>> This issue was detected by using the Coccinelle software. >> >> NACK >> >> When a user asks me for help I would certainly like to get >> 'Could not allocate cache ta

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

2017-08-07 Thread SF Markus Elfring
>> Omit an extra message for a memory allocation failure in this function. >> >> This issue was detected by using the Coccinelle software. > > NACK > > When a user asks me for help I would certainly like to get > 'Could not allocate cache tags' as apposed to nothing, Do you find the default all

Re: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

2017-08-07 Thread Joe Perches
On Mon, 2017-08-07 at 08:10 -0700, Geoff Levand wrote: > On 08/07/2017 03:52 AM, SF Markus Elfring wrote: > > Omit an extra message for a memory allocation failure in this function. > NACK > > When a user asks me for help I would certainly like to get > 'Could not allocate cache tags' as apposed

Re: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

2017-08-07 Thread Geoff Levand
On 08/07/2017 03:52 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 7 Aug 2017 12:37:01 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. NACK When a user asks me for help I would cer

[PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

2017-08-07 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 7 Aug 2017 12:37:01 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signe