On Tue, Aug 20, 2019 at 11:05 PM Hongwei Zhang wrote:
> Add SGPIO driver support for Aspeed AST2500 SoC.
>
> Signed-off-by: Hongwei Zhang
> Reviewed-by: Andrew Jeffery
This v8 patch applied for v5.4, thanks!
Yours,
Linus Walleij
-kernel@vger.kernel.org; Linux ARM
> Subject: Re: [v7 2/2] gpio: aspeed: Add SGPIO driver
>
> Hi Hongwei,
>
> thanks for your patch!
>
> I have now merged the bindings so you only need to respin this patch.
>
> On Wed, Jul 31, 2019 at 10:02 PM Hongwei Zhang wrote:
ngwei
> From: Linus Walleij
> Sent: Wednesday, August 14, 2019 4:09 AM
> To: Hongwei Zhang
> Cc: Andrew Jeffery; open list:GPIO SUBSYSTEM; Joel Stanley; linux-aspeed;
> Bartosz Golaszewski;
> linux-kernel@vger.kernel.org; Linux ARM
> Subject: Re: [v7 2/2] gpio: aspeed
, some comments cleanup
The related SGPM pinmux dt-binding document, dts, and pinctrl driver
updates have been accepted and merged:
_http://patchwork.ozlabs.org/patch/1110210/
Hongwei Zhang (1):
gpio: aspeed: Add SGPIO driver
drivers/gpio/sgpio-aspeed.c | 533 +
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
Reviewed-by: Andrew Jeffery
---
drivers/gpio/sgpio-aspeed.c | 533
1 file changed, 533 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers
Hi Hongwei,
thanks for your patch!
I have now merged the bindings so you only need to respin
this patch.
On Wed, Jul 31, 2019 at 10:02 PM Hongwei Zhang wrote:
> Add SGPIO driver support for Aspeed AST2500 SoC.
>
> Signed-off-by: Hongwei Zhang
> Reviewed-by: Andrew Jeffery
I guess I need t
On Thu, 1 Aug 2019, at 05:32, Hongwei Zhang wrote:
> Add SGPIO driver support for Aspeed AST2500 SoC.
>
> Signed-off-by: Hongwei Zhang
> Reviewed-by: Andrew Jeffery
Adding my Reviewed-by tag is a bit keen, I only gave it for the bindings on v6.
However, having looked over the patch you've
> linux-arm-ker...@lists.infradead.org
> Subject: Re: [v6 2/2] gpio: aspeed: Add SGPIO driver
>
>
>
> On Wed, 31 Jul 2019, at 00:55, Hongwei Zhang wrote:
> > Add SGPIO driver support for Aspeed AST2500 SoC.
> >
> > Signed-off-by: Hongwei Zh
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
Reviewed-by: Andrew Jeffery
---
drivers/gpio/sgpio-aspeed.c | 530
1 file changed, 530 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers
ings: gpio: aspeed: Add SGPIO support
gpio: aspeed: Add SGPIO driver
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 +++
drivers/gpio/sgpio-aspeed.c| 530 +
2 files changed, 585 insertions(+)
create mode 100644 Documentation/devicetree/bindings/
On Wed, 31 Jul 2019, at 00:55, Hongwei Zhang wrote:
> Add SGPIO driver support for Aspeed AST2500 SoC.
>
> Signed-off-by: Hongwei Zhang
> ---
> drivers/gpio/sgpio-aspeed.c | 521
>
> 1 file changed, 521 insertions(+)
> create mode 100644 drivers/
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
drivers/gpio/sgpio-aspeed.c | 521
1 file changed, 521 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers/
document, dts, and pinctrl driver
updates have been accepted and merged:
_http://patchwork.ozlabs.org/patch/1110210/
Hongwei Zhang (2):
dt-bindings: gpio: aspeed: Add SGPIO support
gpio: aspeed: Add SGPIO driver
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 +++
drivers/gpio/sgpio
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
drivers/gpio/sgpio-aspeed.c | 521
1 file changed, 521 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers/
:38 PM
> To: Hongwei Zhang
> Cc: Andrew Jeffery; linux-gpio; Joel Stanley; linux-aspeed; Bartosz
> Golaszewski; linux-kernel; linux-
> arm-kernel
> Subject: Re: [v5 2/2] gpio: aspeed: Add SGPIO driver
>
> On Mon, Jul 22, 2019 at 10:37 PM Hongwei Zhang wrote:
>
>
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
drivers/gpio/sgpio-aspeed.c | 521
1 file changed, 521 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers/
On Mon, Jul 22, 2019 at 10:37 PM Hongwei Zhang wrote:
> As you suspected it correctly, AST2500 utilizes all the 32 bits of the
> registers
> (data value, interrupt, etc...), such that using 8-bit bands
> [7:0]/[15:8]/23:16]/[31:24] of GPIO_200H for SGPIO_A/B/C/D .
> so registering 10 gpiochip dr
9 3:37 AM
> To: Hongwei Zhang
> Cc: Andrew Jeffery; open list:GPIO SUBSYSTEM; Joel Stanley;
> linux-asp...@lists.ozlabs.org; Bartosz
> Golaszewski; linux-kernel@vger.kernel.org; Linux ARM
> Subject: Re: [v5 2/2] gpio: aspeed: Add SGPIO driver
>
> Hi Hongwei,
>
> th
Hi Hongwei,
thanks for your patch!
some comments and nitpicking below:
On Fri, Jul 19, 2019 at 9:25 PM Hongwei Zhang wrote:
> Add SGPIO driver support for Aspeed AST2500 SoC.
>
> Signed-off-by: Hongwei Zhang
> +// SPDX-License-Identifier: GPL-2.0+
I think the SPDX people prefer GPL-2.0-or-l
Hello Andrew,
Thanks for reviewing and suggestions.
please see my inline comments. I just submitted v5 with a proper series title,
please help review them.
In AST2500 datasheet, it says:
"Support up to 80 SGPIO input ports and 80 output ports concurrently only at
the cost of 4 control pins".
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
drivers/gpio/sgpio-aspeed.c | 522
1 file changed, 522 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers/
):
dt-bindings: gpio: aspeed: Add SGPIO support
gpio: aspeed: Add SGPIO driver
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 +++
drivers/gpio/sgpio-aspeed.c| 522 +
2 files changed, 577 insertions(+)
create mode 100644 Documentation
22 matches
Mail list logo
