Re: pinctrl-icelake: driver writes to wrong offsets?

2018-09-20 Thread Linus Walleij
Good bug hunting in this thread! Please see if you can use libgpiod or the tools from the kernel tools/gpio directory to test GPIO lines, I usually use that since the global GPIO numberspace only constantly confuse me. Especially when there is a really many many GPIOs the local numberspace and

Re: pinctrl-icelake: driver writes to wrong offsets?

2018-09-20 Thread Linus Walleij
Good bug hunting in this thread! Please see if you can use libgpiod or the tools from the kernel tools/gpio directory to test GPIO lines, I usually use that since the global GPIO numberspace only constantly confuse me. Especially when there is a really many many GPIOs the local numberspace and

Re: pinctrl-icelake: driver writes to wrong offsets?

2018-09-18 Thread Mika Westerberg
On Tue, Sep 18, 2018 at 11:31:57AM +0300, Mika Westerberg wrote: > > As you can see in the above example, when I export the pins and change > > the directions from "in" to "out" PADCFG get updated correctly for pin > > 18, but when writing the value, it is the PADCFG for pin 42 that gets > >

Re: pinctrl-icelake: driver writes to wrong offsets?

2018-09-18 Thread Mika Westerberg
On Tue, Sep 18, 2018 at 11:31:57AM +0300, Mika Westerberg wrote: > > As you can see in the above example, when I export the pins and change > > the directions from "in" to "out" PADCFG get updated correctly for pin > > 18, but when writing the value, it is the PADCFG for pin 42 that gets > >

Re: pinctrl-icelake: driver writes to wrong offsets?

2018-09-18 Thread Mika Westerberg
On Mon, Sep 17, 2018 at 11:16:41AM -0700, Rajat Jain wrote: > On Mon, Sep 17, 2018 at 1:13 AM Mika Westerberg > wrote: > > > > On Fri, Sep 14, 2018 at 05:18:34PM -0700, Rajat Jain wrote: > > > This is to report what I think is a problem in the pinctrl-icelake > > > driver. It seems that when

Re: pinctrl-icelake: driver writes to wrong offsets?

2018-09-18 Thread Mika Westerberg
On Mon, Sep 17, 2018 at 11:16:41AM -0700, Rajat Jain wrote: > On Mon, Sep 17, 2018 at 1:13 AM Mika Westerberg > wrote: > > > > On Fri, Sep 14, 2018 at 05:18:34PM -0700, Rajat Jain wrote: > > > This is to report what I think is a problem in the pinctrl-icelake > > > driver. It seems that when

Re: pinctrl-icelake: driver writes to wrong offsets?

2018-09-17 Thread Rajat Jain
On Mon, Sep 17, 2018 at 1:13 AM Mika Westerberg wrote: > > On Fri, Sep 14, 2018 at 05:18:34PM -0700, Rajat Jain wrote: > > This is to report what I think is a problem in the pinctrl-icelake > > driver. It seems that when trying to control GPIO pins GPP_A* and > > GPIO_B*, the driver ends up

Re: pinctrl-icelake: driver writes to wrong offsets?

2018-09-17 Thread Rajat Jain
On Mon, Sep 17, 2018 at 1:13 AM Mika Westerberg wrote: > > On Fri, Sep 14, 2018 at 05:18:34PM -0700, Rajat Jain wrote: > > This is to report what I think is a problem in the pinctrl-icelake > > driver. It seems that when trying to control GPIO pins GPP_A* and > > GPIO_B*, the driver ends up

Re: pinctrl-icelake: driver writes to wrong offsets?

2018-09-17 Thread Mika Westerberg
On Fri, Sep 14, 2018 at 05:18:34PM -0700, Rajat Jain wrote: > This is to report what I think is a problem in the pinctrl-icelake > driver. It seems that when trying to control GPIO pins GPP_A* and > GPIO_B*, the driver ends up writing to incorrect PADCFG registers. > I've reached this conclusion

Re: pinctrl-icelake: driver writes to wrong offsets?

2018-09-17 Thread Mika Westerberg
On Fri, Sep 14, 2018 at 05:18:34PM -0700, Rajat Jain wrote: > This is to report what I think is a problem in the pinctrl-icelake > driver. It seems that when trying to control GPIO pins GPP_A* and > GPIO_B*, the driver ends up writing to incorrect PADCFG registers. > I've reached this conclusion

Re: pinctrl-icelake: driver writes to wrong offsets?

2018-09-17 Thread Mika Westerberg
On Fri, Sep 14, 2018 at 05:18:34PM -0700, Rajat Jain wrote: > Hi, > > This is to report what I think is a problem in the pinctrl-icelake > driver. It seems that when trying to control GPIO pins GPP_A* and > GPIO_B*, the driver ends up writing to incorrect PADCFG registers. > I've reached this

Re: pinctrl-icelake: driver writes to wrong offsets?

2018-09-17 Thread Mika Westerberg
On Fri, Sep 14, 2018 at 05:18:34PM -0700, Rajat Jain wrote: > Hi, > > This is to report what I think is a problem in the pinctrl-icelake > driver. It seems that when trying to control GPIO pins GPP_A* and > GPIO_B*, the driver ends up writing to incorrect PADCFG registers. > I've reached this

pinctrl-icelake: driver writes to wrong offsets?

2018-09-14 Thread Rajat Jain
Hi, This is to report what I think is a problem in the pinctrl-icelake driver. It seems that when trying to control GPIO pins GPP_A* and GPIO_B*, the driver ends up writing to incorrect PADCFG registers. I've reached this conclusion by putting debug prints in the driver, although this can be seen

pinctrl-icelake: driver writes to wrong offsets?

2018-09-14 Thread Rajat Jain
Hi, This is to report what I think is a problem in the pinctrl-icelake driver. It seems that when trying to control GPIO pins GPP_A* and GPIO_B*, the driver ends up writing to incorrect PADCFG registers. I've reached this conclusion by putting debug prints in the driver, although this can be seen