Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again

2007-01-01 Thread James Bottomley
On Thu, 2006-12-21 at 16:57 +, Russell King wrote: > I'm not entirely convinced that it can be replaced. What if the page > is in the page cache and is shared with other processes? That quite > clearly falls under flush_dcache_page()'s remit. Actually, it should work. flush_dcache_page()

Re: chaostables-0.2 & 2.6.19.1

2007-01-01 Thread Folkert van Heusden
> >I'm trying to compile chaostables v0.2 on a system with kernel 2.6.19.1 > >and c-compiler 3.4.6: > >[EMAIL PROTECTED]:/usr/src/chaostables-0.2/kernel# make all > >make -C /lib/modules/2.6.19.1/build M=$PWD modules; > >make[1]: Entering directory `/usr/src/linux-2.6.19.1' > > CC [M]

Re: [PATCH 2.6.19] mmc: Add support for SDHC cards

2007-01-01 Thread Philip Langdale
I will post the updated diff as a separate follow up. Pierre Ossman wrote: > > When you have a commit message larger than the patch, you know there is > something wrong. ;) > > Please skip the part about MMC at least. Heh. I forget that you don't want to manually alter the email. Will do. >

Re: chaostables-0.2 & 2.6.19.1

2007-01-01 Thread Jan Engelhardt
On Jan 1 2007 16:15, Folkert van Heusden wrote: >> >I'm trying to compile chaostables v0.2 on a system with kernel 2.6.19.1 >> >and c-compiler 3.4.6: >> >/usr/src/chaostables-0.2/kernel/xt_CHAOS.c: In function `xt_chaos_target': >> >/usr/src/chaostables-0.2/kernel/xt_CHAOS.c:53: error: too many

[PATCH 2.6.19] mmc: Add support for SDHC cards (Take 2)

2007-01-01 Thread Philip Langdale
Thanks to the generous donation of an SDHC card by John Gilmore, and the surprisingly enlightened decision by the SD Card Association to publish useful specs, I've been able to bash out support for SDHC. The changes are not too profound: i) Add a card flag indicating the card uses block level

Re: Using _syscall3 to manipulate files in a driver

2007-01-01 Thread Jon Smirl
On 1/1/07, Paul Mundt <[EMAIL PROTECTED]> wrote: On Sun, Dec 31, 2006 at 12:13:52PM -0500, Jon Smirl wrote: > I have the source code for a vendor written driver that is targeted at > 2.6.9. It includes this and then proceeds to manipulate files from the > driver. > > asmlinkage

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2007-01-01 Thread Jan Engelhardt
On Dec 31 2006 19:23, Randy Dunlap wrote: >> > >> > #define setcc(cc) ({ \ >> > partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \ >> > partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); }) >> >> This _does_ return a value though, bad example. > > Where does it return a value? I don't see any

Re: Happy New Year (and v2.6.20-rc3 released)

2007-01-01 Thread Olaf Hering
The final 2.6.20 release note should mention the following commit in some way: "[NETFILTER]: Kconfig: improve conntrack selection" It will break existing iptable setups without warning becausee it disables all related .config options. If one says NO to the new NF_CONNTRACK_ENABLED "Netfilter

Re: new harddrive with media error

2007-01-01 Thread Alexander Nagel
Thanks for the input of everybody. i think the drive is broken and i will return it. Happy gnu year @ all Alex Tejun Heo schrieb: Al Viro wrote: From the look of it, I'd say that it's size reported by disk being more than what's accessible. Take a look at the block numbers... How so?

x86 instability with 2.6.1{8,9}

2007-01-01 Thread Ken Moffat
Hi, I've been running an athlon64 in 64-bit mode without problems, up to and incluing 2.6.19.1. A couple of weeks ago I decided to use it for testing x86 builds, since then it's been nothing but trouble in 32-bit mode. It still works fine when I boot it in 64-bit mode. I already had a 32-bit

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

2007-01-01 Thread Ingo Oeser
Hi, On Monday, 1. January 2007 07:37, Amit Choudhary wrote: > --- Ingo Oeser <[EMAIL PROTECTED]> wrote: > > #define kfree_nullify(x) do { \ > > if (__builtin_constant_p(x)) { \ > > kfree(x); \ > > } else { \ > > typeof(x) *__addr_x = \ Ok, I should change that

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

2007-01-01 Thread Andreas Schwab
Ingo Oeser <[EMAIL PROTECTED]> writes: > Hi, > > On Monday, 1. January 2007 07:37, Amit Choudhary wrote: >> --- Ingo Oeser <[EMAIL PROTECTED]> wrote: >> > #define kfree_nullify(x) do { \ >> >if (__builtin_constant_p(x)) { \ >> >kfree(x); \ >> >} else { \ >> >

Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again

2007-01-01 Thread Russell King
On Mon, Jan 01, 2007 at 09:35:17AM -0500, James Bottomley wrote: > On Sat, 2006-12-30 at 10:26 -0800, Linus Torvalds wrote: > > > > On Sat, 30 Dec 2006, Russell King wrote: > > > > > > And here's the flush_anon_page() part. > > This looks fine to me (if you need my ack). > > > > Add

Re: Finding hardlinks

2007-01-01 Thread Pavel Machek
Hi! > >>If user (or script) doesn't specify that flag, it > >>doesn't help. I think > >>the best solution for these filesystems would be > >>either to add new syscall > >>int is_hardlink(char *filename1, char *filename2) > >>(but I know adding syscall bloat may be objectionable) > > > >it's

Re: [PATCH 2.6.19] mmc: Add support for SDHC cards

2007-01-01 Thread Pavel Machek
Hi! > > Hi all, > > > > Thanks to the generous donation of an SDHC card by John Gilmore, and the > > surprisingly enlightened decision by the SD Card Association to publish > > useful specs, I've been able to bash out support for SDHC. The changes > > are not too profound: > > So I sent that

Re: LCA 2007 Kernel Miniconf CFP (better late than never...)

2007-01-01 Thread Pavel Machek
Hi! > The Kernel miniconference at LCA 20007 is finally being > organised and > this is the call for participation: > > http://lca2007.linux.org.au/Miniconfs/Kernel > > The current schedule gives us 6 slots. ... (s2ram debugging session). Hmmm, it would be nice to be there... > The other 3

Re: Binary Drivers

2007-01-01 Thread Pavel Machek
Hi! > >You're not alone, I think everybody who knows, how > >things in a > >computer work shares this view. > --- > > Two of the specific arguments I've heard are (a) that > the board (and > its hardware interfaces that the documentation would > describe) involve > IP licensed from a third

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2007-01-01 Thread Randy Dunlap
Robert P. J. Day wrote: On Mon, 1 Jan 2007, Christoph Hellwig wrote: On Sun, Dec 31, 2006 at 02:32:25PM -0500, Robert P. J. Day wrote: + (a) Enclose those statements in a do - while block: + + #define macrofun(a, b, c) \ + do {\ +

Re: x86 instability with 2.6.1{8,9}

2007-01-01 Thread Alistair John Strachan
On Monday 01 January 2007 16:01, Ken Moffat wrote: > Hi, I've been running an athlon64 in 64-bit mode without problems, > up to and incluing 2.6.19.1. A couple of weeks ago I decided to use > it for testing x86 builds, since then it's been nothing but trouble > in 32-bit mode. It still works

Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again

2007-01-01 Thread James Bottomley
On Sun, 2006-12-31 at 13:12 -0800, David Miller wrote: > From: Linus Torvalds <[EMAIL PROTECTED]> > Date: Sun, 31 Dec 2006 12:58:45 -0800 (PST) > > > So there really is two different cases here: > > > > - flush the cache as seen by A PARTICULAR virtual mapping. > > > >This is ptrace, but

Re: x86 instability with 2.6.1{8,9}

2007-01-01 Thread Ken Moffat
On Mon, Jan 01, 2007 at 04:48:55PM +, Alistair John Strachan wrote: > > Obviously papering over a severe bug, but why is it necessary for you to run > a > 32bit kernel to test 32bit userspace? If your 64bit kernel is stable, use the > IA32 emulation surely? > My 64-bit is pure64 on this

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2007-01-01 Thread Randy Dunlap
On Mon, 1 Jan 2007 17:42:31 +0900 Paul Mundt wrote: > On Mon, Jan 01, 2007 at 02:59:32AM +0100, Folkert van Heusden wrote: > > > > regarding alignment that don't allow clear_page() to be used > > > > copy_page() in the memcpy() case), but it's going to need a lot of > > > > Maybe these

Re: [PATCH] OHCI: disallow autostop when wakeup is not available

2007-01-01 Thread Andrey Borzenkov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wednesday 15 November 2006 00:28, Alan Stern wrote: > This patch (as822) prevents the OHCI autostop mechanism from kicking in > if the root hub is not able or not allowed to issue wakeup requests. > > Signed-off-by: Alan Stern <[EMAIL PROTECTED]> >

Re: [PATCH] Open Firmware device tree virtual filesystem

2007-01-01 Thread Segher Boessenkool
Not the same exact thing -- using a text representation for the property contents is a very different thing (and completely braindead). The filesystem bit is for groveling around and getting information from the shell prompt, or shell scripts. Text processing. If you want the binary bits,

Re: [PATCH 2.6.19] mmc: Add support for SDHC cards

2007-01-01 Thread Pierre Ossman
Pavel Machek wrote: > Would you describe what SDHC is? I know SD flash cards, and IIRC SDIO > cards exist, with functionality such as bluetooth...? But SDHC? > > SDHC is short for "Secure Digital High Capacity". It's simply SD flash cards than conform to a new version of the protocol, a

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2007-01-01 Thread Segher Boessenkool
If people want to return something from a ({ }) construct, they should do it explicitly, e.g. #define setcc(cc) ({ \ partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \ partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); \ partial_status; \ }) No, they generally should use

[PATCH] sound: hda: detect ALC883 on MSI K9A Platinum motherboards (MS-7280)

2007-01-01 Thread Leonard Norrgard
From: Leonard Norrgård <[EMAIL PROTECTED]> Recognize the Realtek ALC883 chip on MSI K9A Platinum motherboards (model no. MS-7280), enabling full sound capabilities. Signed-off-by: Leonard Norrgård <[EMAIL PROTECTED]> --- Error messages seen before this patch: cannot find the slot for index 0

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

2007-01-01 Thread Pavel Machek
Hi! > > I decided to keep it simple. If someone is calling kfree_nullify() with > > anything other than a > > simple variable, then they should call kfree(). > > kfree_nullify() has to replace kfree() to be of any use one day. So this is > not an option. > Doing kfree() that writes to its

Re: bluetooth memory corruption (was Re: ext3-related crash in 2.6.20-rc1)

2007-01-01 Thread Pavel Machek
Hi! > > > > Okay, I spoke too soon. bluetooth & suspend memory corruption was > > > > _way_ harder to reproduce than expected. Took me 5-or-so-suspend > > > > cycles... so it is probably unrelated to the previous crash. > > > > > > can you try to reproduce this with 2.6.20-rc2 as well. > > > >

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2007-01-01 Thread Dave Jones
On Mon, Jan 01, 2007 at 05:27:10AM -0500, Robert P. J. Day wrote: > > both look good... I'd be in favor of this. Maybe also add a part > > about using GFP_KERNEL whenever possible, GFP_NOFS from filesystem > > writeout code and GFP_NOIO from block writeout code (and never doing > >

Re: [PATCH] Consolidate default sched_clock()

2007-01-01 Thread Vincent Legoll
Hello, what about the following, on top of your patch ? It's trivial modif to kernel-doc style comment... -- Vincent Legoll diff --git a/kernel/sched.c b/kernel/sched.c index f92a239..2c51ec0 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -56,8 +56,8 @@ #include -/* - * Scheduler

Re: Sparse 0.2 warnings from {asm,net}/checksum.h

2007-01-01 Thread Dave Jones
On Mon, Jan 01, 2007 at 03:23:45PM +0100, Tilman Schmidt wrote: > With sparse 0.2, my previously sparse-clean driver generates the > following warnings: > > include/asm/checksum.h:182:6: warning: symbol 'sum' shadows an earlier one > include/asm/checksum.h:178:28: originally declared here >

Re: [PATCH] Open Firmware device tree virtual filesystem

2007-01-01 Thread Mitch Bradley
David Miller wrote: We don't generally export binary representation files out of /proc or /sys, in fact this rule I believe is layed our precisely somewhere at least in the sysfs case. pci-sysfs exports PCI config space in binary. - To unsubscribe from this list: send the line

Re: [PATCH] preliminary sata_promise ATAPI support

2007-01-01 Thread Mikael Pettersson
On Sat, 30 Dec 2006 18:37:18 +0100 (MET), Mikael Pettersson wrote: >This patch against 2.6.20-rc2 adds partial ATAPI support to >the sata_promise driver. This patch is preliminary and for >review only. ... >As to why CD-writing fails with DMA enabled, I suspect that I >either need to blacklist

Re: x86 instability with 2.6.1{8,9}

2007-01-01 Thread Ken Moffat
On Mon, Jan 01, 2007 at 05:07:58PM +, Ken Moffat wrote: > On Mon, Jan 01, 2007 at 04:48:55PM +, Alistair John Strachan wrote: > > > > Obviously papering over a severe bug, but why is it necessary for you to > > run a > > 32bit kernel to test 32bit userspace? If your 64bit kernel is

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2007-01-01 Thread Jan Engelhardt
On Jan 1 2007 18:51, Segher Boessenkool wrote: >> If people want to return something from a ({ }) construct, they should do >> it >> explicitly, e.g. >> >> #define setcc(cc) ({ \ >> partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \ >> partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); \ >>

Re: [RFC] HZ free ntp

2007-01-01 Thread Roman Zippel
Hi, On Wednesday 20 December 2006 02:32, john stultz wrote: > > I know and all you have to change in the ntp and some related code is to > > replace HZ there with a variable, thus make it changable, so you can > > increase the update interval (i.e. it becomes 1s/hz instead of 1s/HZ). > >

Re: [RFC] HZ free ntp

2007-01-01 Thread Roman Zippel
On Wednesday 20 December 2006 02:54, john stultz wrote: > And here would be the follow on patch (again *untested*) for > CONFIG_NO_HZ slowing the time accumulation down to once per second. Changing it to one creates a potential problem with calling second_overflow(). It should be called every

2.6.20 regression: suspend to disk no more works

2007-01-01 Thread Andrey Borzenkov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 In *the same* configuration STD now fails with "Cannot find swap device". The reason is changes in kernel/power/swap.c. In 2.6.19 it did not require valid swsusp_resume_device at all - it took first available swap device and saved image. Later

Re: x86 instability with 2.6.1{8,9}

2007-01-01 Thread Alistair John Strachan
On Monday 01 January 2007 19:13, Ken Moffat wrote: > On Mon, Jan 01, 2007 at 05:07:58PM +, Ken Moffat wrote: > > On Mon, Jan 01, 2007 at 04:48:55PM +, Alistair John Strachan wrote: > > > Obviously papering over a severe bug, but why is it necessary for you > > > to run a 32bit kernel to

Re: Happy New Year (and v2.6.20-rc3 released)

2007-01-01 Thread Linus Torvalds
Jeff, what was the resolution to this one? Just revert the offending commit, or what? We're about five weeks into the 2.6.20-rc series. I was hoping for a two-month release rather than the usual dragged-out three months, so I'd like to get these regressions to be actively fixed. By forcible

Re: kref refcnt and false positives

2007-01-01 Thread Benjamin Herrenschmidt
> This makes my Maple board very unhappy -- it triggers a WARN_ON() in > kref_get() lots of times... Maybe the refounting in prom.c is broken ? I'll have a look. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers

2007-01-01 Thread David Brownell
For the list archives: here's the latest version of this. The signed-off-by discussion is offlist right now, so this version has none; see what eventually merges. From: Philipp Zabel <[EMAIL PROTECTED]> Arch-neutral GPIO calls for PXA. Index: pxa/include/asm-arm/arch-pxa/gpio.h

Re: [patch 2.6.20-rc1 0/6] arch-neutral GPIO calls

2007-01-01 Thread David Brownell
On Sunday 31 December 2006 11:11 am, Kevin O'Connor wrote: > > Based on earlier discussion, I'm sending a refresh of the generic GPIO > > patch, with several (ARM based) implementations in separate patches: > > Hi Dave, > > I'm very interested in seeing an abstraction for gpios. Good! I

Re: [2.6 patch] kconfig: remove the unused "requires" syntax

2007-01-01 Thread Roman Zippel
Hi, On Thursday 28 December 2006 22:05, Adrian Bunk wrote: > How to add some warning prints? Simple, see the attached patch. > And what's the problem with changing the generated files? > There doesn't seem to be much activity in this area, and the noise of > changing the generated files

Re: [PATCH] Open Firmware device tree virtual filesystem

2007-01-01 Thread Jan Engelhardt
On Jan 1 2007 08:10, Mitch Bradley wrote: >> >> We don't generally export binary representation >> files out of /proc or /sys, in fact this rule I believe is layed >> our precisely somewhere at least in the sysfs case. >> > pci-sysfs exports PCI config space in binary. cat

[PATCH 0/8] UML - Locking fixes and code cleanup

2007-01-01 Thread Jeff Dike
As before, this is post-2.6.20 material. These patches fix locking, style and whitespace problems, and make small code cleanups. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

[PATCH 3/8] UML - audio driver locking

2007-01-01 Thread Jeff Dike
Comment the lack of locking and make a couple of variables static. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/hostaudio_kern.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) Index: linux-2.6.18-mm/arch/um/drivers/hostaudio_kern.c

[PATCH 4/8] UML - audio driver formatting

2007-01-01 Thread Jeff Dike
Whitespace and style fixes. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/hostaudio_kern.c | 160 +-- 1 file changed, 73 insertions(+), 87 deletions(-) Index: linux-2.6.18-mm/arch/um/drivers/hostaudio_kern.c

[PATCH 2/8] UML - watchdog driver formatting

2007-01-01 Thread Jeff Dike
Whitespace and style fixes. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/harddog_kern.c | 33 +++-- arch/um/drivers/harddog_user.c | 23 ++- 2 files changed, 17 insertions(+), 39 deletions(-) Index:

[PATCH 1/8] UML - watchdog driver locking

2007-01-01 Thread Jeff Dike
Replace BKL use with a spinlock. Also fix the control so that open doesn't return holding a lock. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/harddog_kern.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) Index:

[PATCH 6/8] UML - make two variables static

2007-01-01 Thread Jeff Dike
Make a couple of variables static. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/port_kern.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.18-mm/arch/um/drivers/port_kern.c === ---

[PATCH 7/8] UML - port driver formatting

2007-01-01 Thread Jeff Dike
Whitespace and style fixes. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/port_kern.c | 46 +++ arch/um/drivers/port_user.c | 51 +--- 2 files changed, 43 insertions(+), 54 deletions(-) Index:

[PATCH 8/8] UML - Kill a compilation warning

2007-01-01 Thread Jeff Dike
Kill a compilation warning. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/kernel/exec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.18-mm/arch/um/kernel/exec.c === ---

[PATCH 5/8] UML - mconsole locking

2007-01-01 Thread Jeff Dike
Locking fixes. Locking was totally lacking for the mconsole_devices, which got a spin lock, and the unplugged pages data, which got a mutex. The locking of the mconsole console output code was confused. Now, the console_lock (renamed to client_lock) protects the clients list. Signed-off-by:

Re: [PATCH 1/6] UML - Console locking fixes

2007-01-01 Thread Jeff Dike
On Fri, Dec 29, 2006 at 03:48:02PM -0800, Randy Dunlap wrote: > /* > * Normally, ... > if ( > (several of these) Yeah, I'm working off the most blatant style violations at the moment. Jeff -- Work email - jdike at linux dot intel dot com - To

Re: Happy New Year (and v2.6.20-rc3 released)

2007-01-01 Thread Jeff Garzik
Linus Torvalds wrote: Jeff, what was the resolution to this one? Just revert the offending commit, or what? We're about five weeks into the 2.6.20-rc series. I was hoping for a two-month release rather than the usual dragged-out three months, so I'd like to get these regressions to be

Re: [patch 2.6.20-rc1 1/6] GPIO core

2007-01-01 Thread Pavel Machek
Hi! > > Well. when you see (something) = gpio_number + 5 ... you most likely > > have an error. > > One could surely apply that argument to hundreds of places throughout > the kernel ... that doesn't make it a good one. One of the downfalls > of many "object oriented programming" efforts was

Cut power to a USB port?

2007-01-01 Thread Andrew Barr
I have a simple question perhaps someone can help me with here... I have one of those simple LED keyboard lamps that get their power from the USB port. Is there some way in Linux, using files under /sys I would imagine, to cut power to the USB port into which this lamp is plugged? I know I would

Re: Happy New Year (and v2.6.20-rc3 released)

2007-01-01 Thread Alan
On Mon, 1 Jan 2007 12:13:08 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > Jeff, > what was the resolution to this one? Just revert the offending commit, or > what? If you revert the commit you end with all the PCI resource tree breakage back > > We're about five weeks into the

Re: Happy New Year (and v2.6.20-rc3 released)

2007-01-01 Thread Alan
> * I was unable to argue against Alan's logic behind > 368c73d4f689dae0807d0a2aa74c61fd2b9b075f but I just don't like it. > Regardless of whether or not this truly reflects how the PCI device is > wired, it makes pci_request_regions() and similar resource handling code > behave differently.

Re: [PATCH] include/linux/slab.h: new KFREE() macro.

2007-01-01 Thread Pekka Enberg
On 1/1/07, Amit Choudhary <[EMAIL PROTECTED]> wrote: +#define KFREE(x) \ + do {\ + kfree(x); \ + x = NULL; \ + } while(0) NAK until you have actual callers for it. CONFIG_SLAB_DEBUG already catches use after

Re: [patch 2.6.20-rc1 1/6] GPIO core

2007-01-01 Thread David Brownell
On Monday 01 January 2007 12:55 pm, Pavel Machek wrote: > > Think of it as "cookies represented by integers" if you like. > > typedef int gpio_t would hurt, and would serve as a useful > documentation hint. Yes, I agree that such needless obfuscation hurts. ;) Plus, such a typedef would

Re: Patch "i386: Relocatable kernel support" causes instant reboot

2007-01-01 Thread Jean Delvare
Hi Vivek, Sorry for the delay, I'm just back from vacation. I tried it all again with 2.6.20-rc3 just in case, but the problem I've hit is still present. On Fri, 22 Dec 2006 16:10:56 +0530, Vivek Goyal wrote: > Can you please also upload boot/compressed/vmlinux. I've shared the whole build tree

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

2007-01-01 Thread Ingo Oeser
On Monday, 1. January 2007 17:25, Andreas Schwab wrote: > Ingo Oeser <[EMAIL PROTECTED]> writes: > > Then this works, because the side effect (+20) is evaluated only once. > > It's not a side effect, it's a non-lvalue, and you can't take the address > of a non-lvalue. Just verified this. So If

Re: [PATCH] radeonfb: add support for newer cards

2007-01-01 Thread Luca Tettamanti
Il Mon, Jan 01, 2007 at 10:25:51PM +0100, Luca Tettamanti ha scritto: > Hi Ben, Andrew, > I've rebased 'ATOM BIOS patch' from Solomon Peachy to apply to 2.6.20. > The patch adds support for newer Radeon cards and is mainly based on > X.Org code. And - for an easier review - this is the diff

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

2007-01-01 Thread Jan Engelhardt
On Jan 1 2007 22:40, Ingo Oeser wrote: >On Monday, 1. January 2007 17:25, Andreas Schwab wrote: >> Ingo Oeser <[EMAIL PROTECTED]> writes: >> > Then this works, because the side effect (+20) is evaluated only once. >> >> It's not a side effect, it's a non-lvalue, and you can't take the address

Re: Cut power to a USB port?

2007-01-01 Thread Oliver Neukum
Am Montag, 1. Januar 2007 21:56 schrieb Andrew Barr: > I have a simple question perhaps someone can help me with here... > > I have one of those simple LED keyboard lamps that get their power from > the USB port. Is there some way in Linux, using files under /sys I would > imagine, to cut power

[PATCH] [RESEND] include/linux/slab.h: new KFREE() macro.

2007-01-01 Thread Amit Choudhary
Description: new KFREE() macro to set the variable NULL after freeing it. Signed-off-by: Amit Choudhary <[EMAIL PROTECTED]> diff --git a/include/linux/slab.h b/include/linux/slab.h index 1ef822e..28da74c 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -75,6 +75,12 @@ void

Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again

2007-01-01 Thread Miklos Szeredi
> > > I'm willing to do that - and I guess this means we can probably do this > > > instead of walking the list of VMAs for the shared mapping, thereby > > > hitting both anonymous and shared mappings with the same code? > > > > But for the get_user_pages() case there's no point, is there? The

Re: [RFC] MTD driver for MMC cards

2007-01-01 Thread Arnd Bergmann
On Sunday 31 December 2006 13:32, Pierre Ossman wrote: > Arnd Bergmann wrote: > > I'm a complete MTD noob, but what uses does the MTD layer have besides > JFFS2. If it's none, than this advantage isn't that big of a deal. > > > * It becomes possible to use MMC cards with jffs2 even with

2.6.20-rc2+: CFQ halving disk throughput.

2007-01-01 Thread Rene Herman
Tejun Heo wrote: Everything seems fine in the dmesg. Performance degradation is probably some other issue in -rc kernel. I'm suspecting recently fixed block layer bug. If it's still the same in the next -rc, please report. In fact, it's CFQ. The PATA thing was a red herring. 2.6.20-rc2 and

Re: 2.6.20-rc2+: CFQ halving disk throughput.

2007-01-01 Thread Rene Herman
Rene Herman wrote: In fact, it's CFQ. The PATA thing was a red herring. 2.6.20-rc2 and 3 give me ~ 24 MB/s from "hdparm t /dev/hda" while 2.6.20-rc1 and below give me ~ 50 MB/s. Jens: this is due to "[PATCH] cfq-iosched: tighten allow merge criteria",

Re: Finding hardlinks

2007-01-01 Thread Mikulas Patocka
Hi! If user (or script) doesn't specify that flag, it doesn't help. I think the best solution for these filesystems would be either to add new syscall int is_hardlink(char *filename1, char *filename2) (but I know adding syscall bloat may be objectionable) it's also the wrong api; the

Re: Finding hardlinks

2007-01-01 Thread Mikulas Patocka
> The question is: why does the kernel contain iget5 function that looks up > according to callback, if the filesystem cannot have more than 64-bit > inode identifier? Generally speaking, file system might have two different identifiers for files: - one that makes it easy to tell whether two

Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again

2007-01-01 Thread David Miller
From: James Bottomley <[EMAIL PROTECTED]> Date: Mon, 01 Jan 2007 10:34:12 -0600 > Erm, well the whole reason for the flush_anon_pages() was that you told > me not to do it in flush_dcache_page() ... > > Although this is perhaps part of the confusion over what > flush_dcache_page() is actually

Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again

2007-01-01 Thread David Miller
From: James Bottomley <[EMAIL PROTECTED]> Date: Mon, 01 Jan 2007 10:44:36 -0600 > Actually, this was proposed here: > > http://marc.theaimsgroup.com/?t=11540975413 > > When I updated the interface to work for the combined VIPT/PIPT cache on > the latest pariscs. However, there were no

Re: Finding hardlinks

2007-01-01 Thread Nikita Danilov
Mikulas Patocka writes: [...] > > BTW. How does ReiserFS find that a given inode number (or object ID in > ReiserFS terminology) is free before assigning it to new file/directory? reiserfs v3 has an extent map of free object identifiers in super-block. reiser4 used 64 bit object

Re: [patch 2.6.20-rc1 0/6] arch-neutral GPIO calls

2007-01-01 Thread Kevin O'Connor
Hi Dave, On Mon, Jan 01, 2007 at 12:06:19PM -0800, David Brownell wrote: > > The concern I have with your current implementation is that I don't > > see a way to flexibly add in support for additional gpio pins on a > > machine by machine basis. The code does do a good job of abstracting > >

Re: Using _syscall3 to manipulate files in a driver

2007-01-01 Thread Daniel Drake
Jon Smirl wrote: I have the source code for a vendor written driver that is targeted at 2.6.9. It includes this and then proceeds to manipulate files from the driver. In future just kill the code in question, it's wrong and not needed. It's already mostly disabled in the code, based on my

Re: 2.6.20 regression: suspend to disk no more works

2007-01-01 Thread Rafael J. Wysocki
Hi, On Monday, 1 January 2007 20:44, Andrey Borzenkov wrote: > In *the same* configuration STD now fails with "Cannot find swap device". The > reason is changes in kernel/power/swap.c. In 2.6.19 it did not require valid > swsusp_resume_device at all - it took first available swap device and saved

[2.6 PATCH] Export invalidate_mapping_pages() to modules.

2007-01-01 Thread Anton Altaparmakov
Hi Linus and Andrew, Please apply below patch which exports invalidate_mapping_pages() to modules. It makes no sense to me to export invalidate_inode_pages() and not invalidate_mapping_pages() and I actually need invalidate_mapping_pages() because of its range specification ability... It

Re: 2.6.20-rc2+: CFQ halving disk throughput.

2007-01-01 Thread Linus Torvalds
On Mon, 1 Jan 2007, Rene Herman wrote: > Rene Herman wrote: > > > In fact, it's CFQ. The PATA thing was a red herring. 2.6.20-rc2 and 3 give > > me ~ 24 MB/s from "hdparm t /dev/hda" while 2.6.20-rc1 and below give me ~ > > 50 MB/s. > > > > Jens: this is due to "[PATCH] cfq-iosched: tighten

Re: Happy New Year (and v2.6.20-rc3 released)

2007-01-01 Thread Linus Torvalds
On Mon, 1 Jan 2007, Alan wrote: > > Want a fix Linus given Jeff is away ? Send it over, and please cc Alessandro and others that can test it. Things obviously aren't broken on _my_ machines ;) And if we end up having more problems related to this in -rc4, I'll just revert both your fix and

Re: Suspend problems on 2.6.20-rc2-git1

2007-01-01 Thread Rafael J. Wysocki
On Sunday, 31 December 2006 17:24, Rafael J. Wysocki wrote: > On Sunday, 31 December 2006 14:27, Rafael J. Wysocki wrote: > > On Sunday, 31 December 2006 09:15, Robert Hancock wrote: > > > Having some suspend problems on 2.6.20-rc2-git1 with Fedora Core 6. > > > First of all the normal user

Re: 2.6.20-rc2+: CFQ halving disk throughput.

2007-01-01 Thread Mark Lord
Rene Herman wrote: Tejun Heo wrote: Everything seems fine in the dmesg. Performance degradation is probably some other issue in -rc kernel. I'm suspecting recently fixed block layer bug. If it's still the same in the next -rc, please report. In fact, it's CFQ. The PATA thing was a red

Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again

2007-01-01 Thread Russell King
On Mon, Jan 01, 2007 at 03:01:52PM -0800, David Miller wrote: > From: James Bottomley <[EMAIL PROTECTED]> > Date: Mon, 01 Jan 2007 10:34:12 -0600 > > > Erm, well the whole reason for the flush_anon_pages() was that you told > > me not to do it in flush_dcache_page() ... > > > > Although this is

Re: [patch] remove MAX_ARG_PAGES

2007-01-01 Thread Pavel Machek
Hi! > FYI, i have forward ported your MAX_ARG_PAGES limit removal patch to > 2.6.20-rc2 and have included it in the -rt kernel. It's working great - > i can now finally do a "ls -t patches/*.patch" in my patch repository - > something i havent been able to do for years ;-) > > what is keeping

Re: Finding hardlinks

2007-01-01 Thread Mikulas Patocka
> BTW. How does ReiserFS find that a given inode number (or object ID in > ReiserFS terminology) is free before assigning it to new file/directory? reiserfs v3 has an extent map of free object identifiers in super-block. Inode free space can have at most 2^31 extents --- if inode numbers

Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again

2007-01-01 Thread James Bottomley
On Mon, 2007-01-01 at 15:04 -0800, David Miller wrote: > I thought this was accepted and Ralf is using it on MIPS? It partially is ... we're using it on parisc as well, but only as a supplement to the current linux flushing APIs. There's still no guarantee in the standard linux API that

Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again

2007-01-01 Thread Russell King
On Mon, Jan 01, 2007 at 11:15:04PM +0100, Miklos Szeredi wrote: > > > > I'm willing to do that - and I guess this means we can probably do this > > > > instead of walking the list of VMAs for the shared mapping, thereby > > > > hitting both anonymous and shared mappings with the same code? > > >

Re: [PATCH] Open Firmware device tree virtual filesystem

2007-01-01 Thread David Miller
From: Segher Boessenkool <[EMAIL PROTECTED]> Date: Mon, 1 Jan 2007 18:48:33 +0100 > If you *really* want (the option of) showing things as text > in the filesystem, you better make it so that there is a > one-to-one translation back to binary. For example, what > does this mean, is it a text

Re: Finding hardlinks

2007-01-01 Thread Jan Harkes
On Mon, Jan 01, 2007 at 11:47:06PM +0100, Mikulas Patocka wrote: > >Anyway, cp -a is not the only application that wants to do hardlink > >detection. > > I tested programs for ino_t collision (I intentionally injected it) and > found that CP from coreutils 6.7 fails to copy directories but

Re: Finding hardlinks

2007-01-01 Thread Mikulas Patocka
On Mon, 1 Jan 2007, Jan Harkes wrote: On Mon, Jan 01, 2007 at 11:47:06PM +0100, Mikulas Patocka wrote: Anyway, cp -a is not the only application that wants to do hardlink detection. I tested programs for ino_t collision (I intentionally injected it) and found that CP from coreutils 6.7 fails

[PATCH] scsi: lpfc error path fix

2007-01-01 Thread Mariusz Kozlowski
Hello, Add kmalloc failure check and fix the loop on error path. Without the patch pool element at index [0] will not be freed. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/lpfc/lpfc_mem.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff -upr

Re: [RFC] MTD driver for MMC cards

2007-01-01 Thread David Woodhouse
On Mon, 2007-01-01 at 23:22 +0100, Arnd Bergmann wrote: > There are multiple efforts in progress to get a jffs2 replacement. NAND > flash in embedded devices has the same size as it has on MMC card > potentially, so we will need one soon. David Woodhouse has pushed the > limit that jffs2 can

Re: [PATCH] radeonfb: add support for newer cards

2007-01-01 Thread Benjamin Herrenschmidt
On Mon, 2007-01-01 at 22:25 +0100, Luca Tettamanti wrote: > Hi Ben, Andrew, > I've rebased 'ATOM BIOS patch' from Solomon Peachy to apply to 2.6.20. > The patch adds support for newer Radeon cards and is mainly based on > X.Org code. > > I've fixed a few things: > - Port sharing in

Re: [PATCH] radeonfb: add support for newer cards

2007-01-01 Thread Benjamin Herrenschmidt
On Mon, 2007-01-01 at 22:44 +0100, Luca Tettamanti wrote: > Il Mon, Jan 01, 2007 at 10:25:51PM +0100, Luca Tettamanti ha scritto: > > Hi Ben, Andrew, > > I've rebased 'ATOM BIOS patch' from Solomon Peachy to apply to 2.6.20. > > The patch adds support for newer Radeon cards and is mainly based on

[PATCH] Fix freezer.h mistake.

2007-01-01 Thread Nigel Cunningham
I have no idea now why this fragment was in the patch, and Olaf has rightly questioned it. Please apply. Regards, Nigel diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c index c8558d4..e63ea1c 100644 --- a/drivers/macintosh/via-pmu.c +++ b/drivers/macintosh/via-pmu.c @@

Re: [PATCH] radeonfb: add support for newer cards

2007-01-01 Thread Luca
On 1/2/07, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: On Mon, 2007-01-01 at 22:44 +0100, Luca Tettamanti wrote: > Il Mon, Jan 01, 2007 at 10:25:51PM +0100, Luca Tettamanti ha scritto: > > Hi Ben, Andrew, > > I've rebased 'ATOM BIOS patch' from Solomon Peachy to apply to 2.6.20. > > The

<    1   2   3   4   >