Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > But the flogging continues multiple times per second > until the system is shutdown, so it is "the next bug to fix". That's not true. The number of commands sent while probing a device is predetermined and strictly limited. In any case, what you're

Re: Peculiar out-of-sync boot log lines

2007-11-29 Thread Joe Perches
On Thu, 2007-11-29 at 20:03 +, Nick Warne wrote: > Yes, but where does the <7> come from? printk interleaving of functions in ide-cd and ide-iops. drivers/ide/ide-cd.c ide_cdrom_probe_capabilities could use something like the string_buf implementations talked about awhile ago. - To

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-29 Thread Michael Rubin
Due to my faux pas of top posting (see http://www.zip.com.au/~akpm/linux/patches/stuff/top-posting.txt) I am resending this email. On Nov 28, 2007 4:34 PM, Fengguang Wu <[EMAIL PROTECTED]> wrote: > Could you demonstrate the situation? Or if I guess it right, could it > be fixed by the following

Re: [Bluez-users] Lost connections - mouse and keyboard

2007-11-29 Thread Marcel Holtmann
Hi Dave, apparently does manage bluetooth devices using bluetooth-input- service. I still have the problem of the devices disappearing if idle for too long such as when i lock the desktop or log out for a long period. Sometimes I can re-enable the devices, but sometimes I cannot. This is

Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init

2007-11-29 Thread Kay Sievers
On Thu, 2007-11-29 at 15:09 -0500, Alan Stern wrote: > On Thu, 29 Nov 2007, Kay Sievers wrote: > > > > My conclusion is different. We should make kobject_init() not consume > > > any resources at all; just initialize various fields. That way it > > > would be okay to call either kfree() or

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
(resending with condensed version of original syslog) Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: But the flogging continues multiple times per second until the system is shutdown, so it is "the next bug to fix". That's not true. The number of commands sent while probing a

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 03:25:04PM -0500, Mark Lord wrote: > (resending .. somebody trimmed the CC: list earlier) > > Greg KH wrote: > Mark Lord wrote: >> .. >> >> While doing insert/remove (quickly) tests on USB, >> I managed to trigger an Oops on 2.6.23.8 on a call >> to

Re: [PATCH?] OSS: fix operator precedence in return of btaudio_dsp_ioctl

2007-11-29 Thread Adrian Bunk
On Thu, Nov 29, 2007 at 07:59:26PM +0100, Tomas Carnecky wrote: > Roel Kluin wrote: > > First of all, is /sound/oss/* still maintained? > > > > Documentation/feature-removal-schedule.txt > > What: drivers depending on OSS_OBSOLETE > When: options in 2.6.23, code in 2.6.25 > Why: obsolete

Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init

2007-11-29 Thread Kay Sievers
On Thu, 2007-11-29 at 21:20 +0100, Kay Sievers wrote: > On Thu, 2007-11-29 at 15:09 -0500, Alan Stern wrote: > > On Thu, 29 Nov 2007, Kay Sievers wrote: > > > > There's another good reason for not assigning the name in > > > > kobject_init(): Code that uses kobjects (like the driver core) doesn't

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
(resending .. somebody trimmed the CC: list earlier) Greg KH wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). ... I'll hold off on adding this patch for now. .. Why? Bugs

[PATCH 0/2] Markers Implementation for RCU Tracing

2007-11-29 Thread K. Prasad
Hi, Please review the ensuing set of patches which convert the existing RCU tracing mechanism for Preempt RCU and RCU Boost into markers. These patches are based upon the 2.6.24-rc2-rt1 kernel tree. Along with marker transition, the RCU Tracing infrastructure has also been modularised to

Re: [PATCH] sched: cpu accounting controller

2007-11-29 Thread Srivatsa Vaddagiri
On Thu, Nov 29, 2007 at 11:30:35AM -0800, Andrew Morton wrote: > > - Make the accounting scalable on SMP systems (perhaps > > for 2.6.25) > > That sounds like a rather important todo. How bad is it now? It is indeed an important todo. Right now we take a per-group global lock on every

Re: [patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Mark Lord
Kristen Carlson Accardi wrote: On Thu, 29 Nov 2007 13:16:07 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: Kristen wrote: ... +* XXX will need Port Multiplier support What's that all about ? I didn't have any hardware that had LED support as well as Port Multiplier, so I didn't

Re: [patch -mm 2/4] mqueue namespace : add unshare support

2007-11-29 Thread Oren Laadan
Cedric Le Goater wrote: >>> Index: 2.6.24-rc3-mm2/include/linux/sched.h >>> === >>> --- 2.6.24-rc3-mm2.orig/include/linux/sched.h >>> +++ 2.6.24-rc3-mm2/include/linux/sched.h >>> @@ -27,6 +27,7 @@ >>> #define CLONE_NEWUSER

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread H. Peter Anvin
Ingo Molnar wrote: * Andi Kleen <[EMAIL PROTECTED]> wrote: For i386 iirc Jeremy/Zach did the benchmarking and they settled on %fs because it was faster for something (originally it was %gs too) yep. IIRC, some CPUs only optimize %fs because that's what Windows uses and leaves Linux with %gs

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). Does this oops occur under 2.6.24? The SCSI async scanning code was changed

Re: [bug] SLOB, tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52 kmap_atomic_prot()

2007-11-29 Thread Andrew Morton
On Thu, 29 Nov 2007 15:39:20 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > i'm getting this on 32-bit (with the kmap-atomic debugging patch > > applied): > > > > > > > Calling initcall 0x78b67c00: tipc_init+0x0/0xc0() > >

Re: Peculiar out-of-sync boot log lines

2007-11-29 Thread Nick Warne
Hi Jon, On Thu, 29 Nov 2007 14:51:11 -0500 Jon Masters <[EMAIL PROTECTED]> wrote: > > On Thu, 2007-11-29 at 19:37 +, Nick Warne wrote: > > Hi all, > > > > 2.6.23.9 > > > > I have noticed after applying Bart's patch to word93 blacklist my > > new DVD drive: > > > >

Re: [BUG] jiffies counter leaps in 2.6.24-rc3

2007-11-29 Thread Dave Jones
On Thu, Nov 29, 2007 at 08:25:46PM +0100, Stefano Brivio wrote: > On Thu, 29 Nov 2007 13:24:02 -0500 > Dave Jones <[EMAIL PROTECTED]> wrote: > > > On Thu, Nov 29, 2007 at 06:57:43PM +0100, Stefano Brivio wrote: > > > > Do you want me to comment out adjust_jiffies() and see what happens?

Re: ata4294967295: failed to start port (errno=-19)

2007-11-29 Thread Alessandro Suardi
On Nov 28, 2007 9:07 PM, Alan Cox <[EMAIL PROTECTED]> wrote: > > This message comes from 2.6.24-rc3 + todays git, version > > a531a141089714efe39eca89593524fdf05104f2. I did grep the logs and found > > that it first appeared in 2.6.24-rc1 (+ some git mayve) on Nov 3. > > I used 2.6.23 before that

Re: [BUG] jiffies counter leaps in 2.6.24-rc3

2007-11-29 Thread Stefano Brivio
On Thu, 29 Nov 2007 20:36:24 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > just to make sure there is no tsc impact, does booting with "notsc" > change anything? No, it doesn't. > if not, does booting with idle=halt or idle=poll help? [your power usage > will go up so it's not very useful -

[patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
This patch implements Enclosure Management via the LED protocol. See the AHCI 1.1 spec for details. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- Ok, here's one that actually compiles... drivers/ata/ahci.c| 154 -

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread Linus Torvalds
On Thu, 29 Nov 2007, Andi Kleen wrote: > > How would you catch (common) the case of them having different bases in the > GDT TLS entries? At some point the selector has to be reloaded, otherwise > it won't be picked up by the CPU. You're right. I somehow thought we were using the LDT for TLS

Re: [PATCH 5/5] PPC cleanup: powermac - do use for_each macro

2007-11-29 Thread Benjamin Herrenschmidt
On Thu, 2007-11-29 at 22:46 +0300, Cyrill Gorcunov wrote: > From: Cyrill Gorcunov <[EMAIL PROTECTED]> > > Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> > --- Ack. > arch/powerpc/platforms/powermac/low_i2c.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git

Re: Out of tree module using LSM

2007-11-29 Thread Valdis . Kletnieks
On Thu, 29 Nov 2007 14:45:51 EST, Jon Masters said: > Ah, but I could write a sequence of pages that on their own looked > garbage, but in reality, when executed would print out a copy of the > Jargon File in all its glory. And if you still think you could look for > patterns, how about executable

Re: 2.6.24-rc3-mm2

2007-11-29 Thread Torsten Kaiser
On Nov 28, 2007 12:41 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc3/2.6.24-rc3-mm2/ > > - All patches against subsystem trees were recently sent to the relevant > maintainers. Many (probably most) were ignored. I don't

Re: [PATCH x86/mm 09/11] x86 ia32 ptrace arch merge

2007-11-29 Thread Alexey Dobriyan
On Thu, Nov 29, 2007 at 04:00:41AM -0800, Roland McGrath wrote: > This moves the sys32_ptrace code into arch/x86/kernel/ptrace.c, > verbatim except for a few hard-coded sizes replaced with sizeof. > Here this code can use the shared local functions in this file. > --- a/arch/x86/kernel/ptrace.c >

[PATCH] Reduce stack used by lib/hexdump.c

2007-11-29 Thread Joe Perches
200 bytes on stack might be a bit much. Size goes up to textdata bss dec hex filename 1142 0 01142 476 lib/hexdump.o Without the WARN_ON 1053 0 01053 41d lib/hexdump.o Before this patch 1004 0 01004 3ec

[Timers SMP] can this machine be helped?

2007-11-29 Thread Guennadi Liakhovetski
Hi, I've got an old 2xP-II @ 400MHz Compaq AP400 system, which I'm still using. It has many peculiarities, so, I wouldn't be surprised if the answer to my questions would be "sorry, the patient is rather dead than alive". Some of the problems lie in ACPI area, I tried some time ago to fix the

Re: Relax permissions for reading hard drive serial number?

2007-11-29 Thread Bartlomiej Zolnierkiewicz
On Thursday 29 November 2007, Kay Sievers wrote: > On Nov 29, 2007 4:46 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > On Nov 29, 2007 7:37 AM, Xavier Bestel <[EMAIL PROTECTED]> wrote: > > > > One sticking point is that apps like Photoshop and probably > > > > Punkbuster want to retrieve the hard

Re: [PATCH] Reduce stack used by lib/hexdump.c

2007-11-29 Thread Randy Dunlap
Joe Perches wrote: 200 bytes on stack might be a bit much. Size goes up to textdata bss dec hex filename 1142 0 01142 476 lib/hexdump.o Without the WARN_ON 1053 0 01053 41d lib/hexdump.o Before this patch 1004 0 0

Re: XFS related Oops (suspend/resume related)

2007-11-29 Thread Tino Keitel
On Thu, Nov 29, 2007 at 22:05:24 +0100, Rafael J. Wysocki wrote: [...] > Tino, can you check if this patch helps, please? Not really. I suspend one to several times a day, and in most cases resume works. I thing checking the patch is hard when I have no real procedure to reproduce the resume

Re: [PATCH] Reduce stack used by lib/hexdump.c

2007-11-29 Thread Jan Engelhardt
On Nov 29 2007 13:02, Randy Dunlap wrote: >> @@ -140,13 +140,20 @@ EXPORT_SYMBOL(hex_dump_to_buffer); >> * Example output using %DUMP_PREFIX_ADDRESS and 4-byte mode: >> * 88089af0: 73727170 77767574 7b7a7978 7f7e7d7c pqrstuvwxyz{|}~. >> */ >> + >> +#define HEX_LINE_SIZE 200 >> + >>

Re: 2.6.24-rc3-mm2

2007-11-29 Thread Andrew Morton
On Thu, 29 Nov 2007 21:58:16 +0100 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > On Nov 28, 2007 12:41 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc3/2.6.24-rc3-mm2/ > > > > - All patches against subsystem trees were

Re: Out of tree module using LSM

2007-11-29 Thread Andi Kleen
Alan Cox <[EMAIL PROTECTED]> writes: > If I want I can have 16 threads executing code in a shared object being > written to by ten other programs at once and shared over a network while > we are at it. Its probably not a good idea but I can do it if I have > reason to. Actually the kernel

Re: [BUG] 2.6.24-rc3-mm2 soft lockup while running tbench

2007-11-29 Thread Andrew Morton
On Wed, 28 Nov 2007 20:03:22 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > while running tbench on the powerpc with 2.6.24-rc3-mm2 softlock up occurs > > BUG: soft lockup - CPU#0 stuck for 11s! [tbench:12183] > NIP: c00ac978 LR: c00acff0 CTR:

Re: XFS related Oops (suspend/resume related)

2007-11-29 Thread Rafael J. Wysocki
On Tuesday, 27 of November 2007, Rafael J. Wysocki wrote: > On Tuesday, 27 of November 2007, David Chinner wrote: > > On Tue, Nov 27, 2007 at 04:51:38PM +0100, Rafael J. Wysocki wrote: > > > On Monday, 26 of November 2007, Rafael J. Wysocki wrote: > > > > On Monday, 26 of November 2007, David

Re: Something similar to inotify in 2.4.

2007-11-29 Thread Kyle McMartin
On Thu, Nov 29, 2007 at 07:09:51PM +0200, Vitaliy Ivanov wrote: > Hi all, > > Can anyone advice whether there is something similar to inotify in 2.4 kernel? > > Need efficient way to track file system changes. > > Maybe some other tools, approaches under 2.4? > dnotify[1]? but it might make

Re: [RFC] Sample kset/ktype/kobject implementation

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 10:39:07AM +0100, Cornelia Huck wrote: > On Wed, 28 Nov 2007 22:11:39 -0800, > Greg KH <[EMAIL PROTECTED]> wrote: > > > > > foo->kobj.kset = example_kset; > > > > foo->kobj.ktype = _ktype; > > > > > > > > /* > > > > * Register the kobject

Re: [Bluez-users] Lost connections - mouse and keyboard

2007-11-29 Thread Jiri Kosina
On Thu, 29 Nov 2007, Marcel Holtmann wrote: > > >Nov 28 18:53:39 pico kernel: WARNING: at drivers/hid/hid-core.c:784 [ ... ] > > Does bluetooth input devices have something to do with usbhid? I don't > > know, perhaps this is another problem in kernel. > in case you have a HID proxy dongle the

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Greg KH wrote: On Thu, Nov 29, 2007 at 03:25:04PM -0500, Mark Lord wrote: (resending .. somebody trimmed the CC: list earlier) Greg KH wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in

Re: m68k build failure

2007-11-29 Thread Andrew Morton
On Wed, 28 Nov 2007 09:28:56 + Al Viro <[EMAIL PROTECTED]> wrote: > On Wed, Nov 28, 2007 at 01:00:56AM -0800, Andrew Morton wrote: > > > No the slightest. 12 seems like the correct, padded size. A size of 10 is > > > just weird as the unpadded size is 9 bytes. Could you dump the > > >

Re: 2.6.24-rc3-mm2 (bugfix for memory cgroup per-zone-struct allocation.)

2007-11-29 Thread Lee Schermerhorn
On Thu, 2007-11-29 at 14:24 +0900, KAMEZAWA Hiroyuki wrote: > On Thu, 29 Nov 2007 12:23:29 +0900 > KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote: > > I noticed CONFIG_NUMA + CONFIG_CGROUP_MEM_CONT + CONFIG_SLUB cannot boot > > because of my patch. > > (SLAB is ok.) > > I'll post workaround soon. >

Re: constant_tsc and TSC unstable

2007-11-29 Thread Michael Tokarev
H. Peter Anvin wrote: > Paul Rolland (ポール・ロラン) wrote: [] >> Measured 3978592228 cycles TSC warp between CPUs, turning off TSC clock. >> Marking TSC unstable due to: check_tsc_sync_source failed. [] >> but I was wondering if this is a bug or a feature ;) > The problem you're having is that the

Re: [PATCH x86/mm 06/11] x86 ptrace arch merge

2007-11-29 Thread Roland McGrath
> > --- a/arch/x86/kernel/ptrace.c > > +++ b/arch/x86/kernel/ptrace.c > > @@ -461,12 +461,13 @@ static int ptrace_set_debugreg(struct task_struct > > *child, > > void ptrace_disable(struct task_struct *child) > > { > > user_disable_single_step(child); > > +#ifdef TIF_SYSCALL_EMU > >

Re: [bug] SLOB, tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52 kmap_atomic_prot()

2007-11-29 Thread Matt Mackall
On Thu, Nov 29, 2007 at 03:39:20PM +0100, Ingo Molnar wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > i'm getting this on 32-bit (with the kmap-atomic debugging patch > > applied): > > > > > > > Calling initcall 0x78b67c00: tipc_init+0x0/0xc0() > > TIPC: Activated

patch kobject-drop-child-parent-ref-at-unregistration.patch added to gregkh-2.6 tree

2007-11-29 Thread gregkh
This is a note to let you know that I've just added the patch titled Subject: Kobject: drop child->parent ref at unregistration to my gregkh-2.6 tree. Its filename is kobject-drop-child-parent-ref-at-unregistration.patch This tree can be found at

Re: constant_tsc and TSC unstable

2007-11-29 Thread Patrick McHardy
H. Peter Anvin wrote: Paul Rolland (ポール・ロラン) wrote: Hello, I've a machine with a Core2Duo CPU. /proc/cpuinfo reports the flag constant_tsc, but at boot time, I have the log : ... Total of 2 processors activated (6919.15 BogoMIPS). ENABLING IO-APIC IRQs ..TIMER: vector=0x31 apic1=0 pin1=2

Re: [PATCH x86/mm 09/11] x86 ia32 ptrace arch merge

2007-11-29 Thread Roland McGrath
> On Thu, Nov 29, 2007 at 04:00:41AM -0800, Roland McGrath wrote: > > This moves the sys32_ptrace code into arch/x86/kernel/ptrace.c, > > verbatim except for a few hard-coded sizes replaced with sizeof. >[...] I just moved this code, I didn't change it. So let's leave style (or

Re: Out of tree module using LSM

2007-11-29 Thread Alan Cox
> Jargon File in all its glory. And if you still think you could look for > patterns, how about executable code that self-modifies in random ways > but when executed as a whole actually has the functionality of fetchmail > embedded within it? How would you guard against that? Thats a problem for

Re: [patch -mm 2/4] mqueue namespace : add unshare support

2007-11-29 Thread Eric W. Biederman
Oren Laadan <[EMAIL PROTECTED]> writes: > Two comments: > > 1) Does it ever make any sense to clone the IPC namespace *without* doing > so also for the MQ namespace or vice versa ? Unless there is a good > reason for doing so, a single CLONE_IPCMQ flag would suffice. SYSVIPC and POSIX IPC are

Re: [PATCH x86/mm 01/11] x86-32 thread_struct.debugreg

2007-11-29 Thread Roland McGrath
> thanks, i've merged your 11 patches - they passed a basic build and boot > test as well. Thanks! > Roland, you've done a lot of gdb / strace / glibc development, what > would you suggest for us to use as a ptrace regression checker? The > problem is that ptrace is not normally used on a

RE: kondemand: kernel BUG at kernel/workqueue.c:258!

2007-11-29 Thread Pallipadi, Venkatesh
>-Original Message- >From: Jiri Slaby [mailto:[EMAIL PROTECTED] >Sent: Thursday, November 29, 2007 1:43 PM >To: Pallipadi, Venkatesh; Nakajima, Jun >Cc: Linux kernel mailing list >Subject: kondemand: kernel BUG at kernel/workqueue.c:258! > >Hi, > >while trying to evoke another bug by

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 03:46:42PM -0500, Mark Lord wrote: > Greg KH wrote: >> So again, the problem is in the higher up scsi layer, and that is where >> the problem should already be fixed. > .. > > Ahhh.. so you figure the Oops should also have been fixed > as part of the 2.6.24 SCSI fixes ?

kobject_init rewrite

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 05:21:34PM +0100, Cornelia Huck wrote: > Kay Sievers <[EMAIL PROTECTED]> wrote: > > int kobject_init(struct kobject *kobj, struct kobj_type *type, const char > > *fmt, ...) > > Agreed. Better don't hide too much. Ok, how about this function. If it errors out, it is

Re: XFS related Oops (suspend/resume related)

2007-11-29 Thread Rafael J. Wysocki
On Thursday, 29 of November 2007, Tino Keitel wrote: > On Thu, Nov 29, 2007 at 22:05:24 +0100, Rafael J. Wysocki wrote: > > [...] > > > Tino, can you check if this patch helps, please? > > Not really. I suspend one to several times a day, and in most cases > resume works. I thing checking the

Re: kondemand: kernel BUG at kernel/workqueue.c:258!

2007-11-29 Thread Jiri Slaby
On 11/29/2007 10:47 PM, Pallipadi, Venkatesh wrote: > > >> -Original Message- >> From: Jiri Slaby [mailto:[EMAIL PROTECTED] >> Sent: Thursday, November 29, 2007 1:43 PM >> To: Pallipadi, Venkatesh; Nakajima, Jun >> Cc: Linux kernel mailing list >> Subject: kondemand: kernel BUG at

Race between generic_forget_inode() and sync_sb_inodes()?

2007-11-29 Thread David Chinner
If we are in the process of dropping an inode and it is hashed, generic_forget_inode() will mark it I_WILL_FREE and drop the inode_lock before calling write_inode_now(). However, at this point, the inode is still on the sb->s_dirty_list so sync_sb_inodes() could see it and try to write it back.

Re: kobject_init rewrite

2007-11-29 Thread Greg KH
One minor documentation update: > /** > * kobject_init - initialize a kobject structure > * @kobj: pointer to the kobject to initialize > * @ktype: pointer to the ktype for this kobject. > * @fmt: the name of the kobject > * > * This function will properly initialize a kobject such that it

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > (resending with condensed version of original syslog) (Sending a 344-KB log file wasn't enough, you had to send another 46-KB condensed version as well? :-) > Alan Stern wrote: > > On Thu, 29 Nov 2007, Mark Lord wrote: > > > >> But the flogging

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-29 Thread Adrian Bunk
On Wed, Nov 28, 2007 at 03:57:47PM -0800, Jeremy Fitzhardinge wrote: > Adrian Bunk wrote: > > This does not apply since we do not have a stable in-kernel API, and > > therefore changes to the in-kernel API can by definition not be > > regressions. > > > > 2.6.24 most likely contains hundreds of

Re: Race between generic_forget_inode() and sync_sb_inodes()?

2007-11-29 Thread Neil Brown
Hi David, On Friday November 30, [EMAIL PROTECTED] wrote: > > > I came across this because I've been making changes to XFS to avoid the > inode hash, and I've found that I need to remove the inode from the > dirty list when setting I_WILL_FREE to avoid this race. I can't see > how this race is

Re: ACPI related Warning in 2.6.24-rc3-git2

2007-11-29 Thread Lukas Hejtmanek
On Thu, Nov 29, 2007 at 04:22:43PM +0800, Zhao Yakui wrote: > Subject: ACPI : Delete the IRQ operation in throttling controll via PTC > >From : Zhao Yakui <[EMAIL PROTECTED]> > > The IRQ operation(enable/disable) should be avoided when throttling is > controlled via PTC method. It is replaced by

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > > So again, the problem is in the higher up scsi layer, and that is where > > the problem should already be fixed. > .. > > Ahhh.. so you figure the Oops should also have been fixed > as part of the 2.6.24 SCSI fixes ? That's what I was missing here. Yes

Re: + proc-fix-the-threaded-proc-self.patch added to -mm tree

2007-11-29 Thread Eric W. Biederman
"Albert Cahalan" <[EMAIL PROTECTED]> writes: > On Nov 28, 2007 6:31 AM, Eric W. Biederman <[EMAIL PROTECTED]> wrote: >> Ingo Molnar <[EMAIL PROTECTED]> writes: >> > * Albert Cahalan <[EMAIL PROTECTED]> wrote: >> >> On Nov 27, 2007 7:49 PM, Guillaume Chazarain <[EMAIL PROTECTED]> wrote: > >> In a

kondemand: kernel BUG at kernel/workqueue.c:258!

2007-11-29 Thread Jiri Slaby
Hi, while trying to evoke another bug by endlessly change governors, this appeared: kernel BUG at .../kernel/workqueue.c:258! invalid opcode: [1] PREEMPT SMP CPU 0 Modules linked in: iwl3945 mac80211 cfg80211 tun cpufreq_userspace rfcomm l2cap hci_usb bluetooth kvm_intel arc4 ecb blkcipher

Re: Out of tree module using LSM

2007-11-29 Thread Al Viro
On Thu, Nov 29, 2007 at 03:56:28PM -0500, [EMAIL PROTECTED] wrote: > Yes, most of these schemes *can* be bypassed because some malicious code does > a > mmap() or similar trick. But what is being overlooked here is that in most > cases, what is *desired* is a way to filter things being handled by

Re: [RFC] Sample kset/ktype/kobject implementation

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Greg KH wrote: > > > > kobject_put(foo) is needed since it gets you through kobject_cleanup() > > > > where the name can be freed. > > > > > > No, kobject_register() should have handled that for us, right? > > > > kobject_register() doesn't do a kobject_put() if

Re: Out of tree module using LSM

2007-11-29 Thread Justin Banks
Alan Cox wrote > > Jargon File in all its glory. And if you still think you could look for > > patterns, how about executable code that self-modifies in random ways > > but when executed as a whole actually has the functionality of fetchmail > > embedded within it? How would you guard against

Re: kobject_init rewrite

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Greg KH wrote: > Ok, how about this function. If it errors out, it is free to just call > kfree() on the kobject. Seems simple enough to me, any objections? If > not, I'll go through and fix up the whole tree... Looks good, _provided_ you also get rid of

Re: Possibly SATA related freeze killed networking and RAID

2007-11-29 Thread Phillip Susi
Tejun Heo wrote: Agreed. Nobody cared on ATA controllers is usually very effective at taking the whole machine down. Is there any reason why we don't turn on irqpoll on turned off IRQs automatically? Why does a single spurious interrupt cause it to be shut down? I can see if the interrupt

[PATCH] Fix forgotten module release in xt_CONNMARK and xt_CONNSECMARK

2007-11-29 Thread Jan Engelhardt
This one is against davem's net-2.6.25 branch. ===Begins here=== Fix forgotten module release in xt_CONNMARK and xt_CONNSECMARK When xt_CONNMARK is used outside the mangle table and the user specified "--restore-mark", the connmark_tg_check() function will (correctly) error out, but

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread Roland McGrath
> > case offsetof(struct user32, regs.gs): > > *val = child->thread.gsindex; > > + if (child == current) > > + asm("movl %%gs,%0" : "=r" (*val)); > > Won't this return the kernel's GS instead of the user's? [...] > But this is x86_64, where swapgs is

Re: Race between generic_forget_inode() and sync_sb_inodes()?

2007-11-29 Thread David Chinner
On Fri, Nov 30, 2007 at 09:07:06AM +1100, Neil Brown wrote: > > Hi David, > > On Friday November 30, [EMAIL PROTECTED] wrote: > > > > > > I came across this because I've been making changes to XFS to avoid the > > inode hash, and I've found that I need to remove the inode from the > > dirty

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread Roland McGrath
> But the ones that do the same thing for fs/es/ds are *not*. Those three > registers are kernel mode registers (ds/es are the regular kernel data > segment, fs is the per-cpu data segment), and restored on return to user > space from the stack. Um, really? This is x86-64 code. AIUI those

Re: [PATCH] Fix forgotten module release in xt_CONNMARK and xt_CONNSECMARK

2007-11-29 Thread Patrick McHardy
Jan Engelhardt wrote: Fix forgotten module release in xt_CONNMARK and xt_CONNSECMARK When xt_CONNMARK is used outside the mangle table and the user specified "--restore-mark", the connmark_tg_check() function will (correctly) error out, but (incorrectly) forgets to release the L3 conntrack

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: So again, the problem is in the higher up scsi layer, and that is where the problem should already be fixed. .. Ahhh.. so you figure the Oops should also have been fixed as part of the 2.6.24 SCSI fixes ? That's what I was missing

Re: [PATCH x86/mm 05/11] x86 ptrace getreg/putreg merge

2007-11-29 Thread Roland McGrath
> This didn't need to be implemented as a macro hence it shouldn't have been. Ok. diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c index b3433e1..000 100644 --- a/arch/x86/kernel/ptrace.c +++ b/arch/x86/kernel/ptrace.c @@ -45,8 +45,10 @@ /* * Determines whether a value

Re: 2.6.24-rc3-mm2

2007-11-29 Thread Stefan Richter
Andrew Morton wrote: > On Thu, 29 Nov 2007 21:58:16 +0100 > "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: >> First crash: >> >> [ 1116.083651] Unable to handle kernel NULL pointer dereference at >> 0378 RIP: >> [ 1116.089216] [] ether1394_dg_complete+0x28/0xa0 ... > Yep, looks like a

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread Linus Torvalds
On Thu, 29 Nov 2007, Roland McGrath wrote: > > Um, really? This is x86-64 code. AIUI those values don't have any effect > at all in 64-bit mode (as the kernel is). I haven't found any code in > entry_64.S or ia32entry.S that touches them. __switch_to uses direct > access to the segment

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 05:07:58PM -0500, Alan Stern wrote: > On Thu, 29 Nov 2007, Mark Lord wrote: > > > > So again, the problem is in the higher up scsi layer, and that is where > > > the problem should already be fixed. > > .. > > > > Ahhh.. so you figure the Oops should also have been fixed

Re: kobject_init rewrite

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 05:16:28PM -0500, Alan Stern wrote: > On Thu, 29 Nov 2007, Greg KH wrote: > > > Ok, how about this function. If it errors out, it is free to just call > > kfree() on the kobject. Seems simple enough to me, any objections? If > > not, I'll go through and fix up the whole

[SPARC64] Export symbols for sunvnet and sunvdc to be built modular

2007-11-29 Thread Ben Collins
Fixes this build failure: ERROR: "vio_driver_init" [drivers/net/sunvnet.ko] undefined! ERROR: "vio_driver_init" [drivers/block/sunvdc.ko] undefined! ERROR: "ldc_map_sg" [drivers/block/sunvdc.ko] undefined! Signed-off-by: Ben Collins <[EMAIL PROTECTED]> diff --git

Re: [PATCH x86/mm 11/11] x86 ptrace merge removals

2007-11-29 Thread Roland McGrath
> On Thu, Nov 29, 2007 at 04:00:57AM -0800, Roland McGrath wrote: > ...lots of ptrace merging... > > Can you make sure that UML still runs when you're done with ptrace? I'd be glad to, especially if you give me some advice on testing (.config for um-i386 and um-x86_64, what do try that

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > Alan Stern wrote: > > On Thu, 29 Nov 2007, Mark Lord wrote: > > > >>> So again, the problem is in the higher up scsi layer, and that is where > >>> the problem should already be fixed. > >> .. > >> > >> Ahhh.. so you figure the Oops should also have been

[PATCH 1/9] AOUT: Move STACK_TOP[_MAX] to asm/processor.h [2.6.24-rc3-mm2]

2007-11-29 Thread David Howells
Move STACK_TOP[_MAX] out of asm/a.out.h and into asm/processor.h as they're required whether or not A.OUT format is available. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- include/asm-alpha/a.out.h |8 +--- include/asm-alpha/processor.h |5 +

[PATCH 4/9] AOUT: Remove unnecessary inclusions of {asm, linux}/a.out.h [2.6.24-rc3-mm2]

2007-11-29 Thread David Howells
Remove now unnecessary inclusions of {asm,linux}/a.out.h. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- arch/alpha/kernel/osf_sys.c |1 - arch/alpha/kernel/process.c |1 - arch/alpha/kernel/setup.c |1 - arch/arm/kernel/process.c |1 -

[PATCH 2/9] AOUT: Mark arches that support A.OUT format [2.6.24-rc3-mm2]

2007-11-29 Thread David Howells
Mark arches that support A.OUT format by including the following in their master Kconfig files: config ARCH_SUPPORTS_AOUT def_bool y This should also be set if the arch provides compatibility A.OUT support for an older arch, for instance x86_64 for i386 or sparc64 for

[PATCH 3/9] AOUT: Suppress A.OUT library support if !CONFIG_ARCH_SUPPORTS_AOUT [2.6.24-rc3-mm2]

2007-11-29 Thread David Howells
Suppress A.OUT library support if CONFIG_ARCH_SUPPORTS_AOUT is not set. Not all architectures support the A.OUT binfmt, so the ELF binfmt should not be permitted to go looking for A.OUT libraries to load in such a case. Not only that, but under such conditions A.OUT core dumps are not produced

[PATCH 5/9] USB: net2280 can't have a function called show_registers() [2.6.24-rc3-mm2]

2007-11-29 Thread David Howells
net2280 can't have a function called show_registers() because this can produce a namespace clash with an arch function of the same name. All this driver's functions and variables should really be prefixed with "net2280_" to avoid such a problem in future. Signed-off-by: David Howells <[EMAIL

[PATCH 6/9] MN10300: Allocate serial port UART IDs for on-chip serial ports [2.6.24-rc3-mm2]

2007-11-29 Thread David Howells
Allocate serial port UART type IDs for the MN10300 on-chip serial ports. Signed-off-by: David Howells <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> --- include/linux/serial_core.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

[PATCH 8/9] MN10300: Add platform MTD support for the ASB2303 board [2.6.24-rc3-mm2]

2007-11-29 Thread David Howells
Add platform MTD support for the ASB2303 board. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- arch/mn10300/configs/asb2303_defconfig |5 +- arch/mn10300/unit-asb2303/Makefile |2 - arch/mn10300/unit-asb2303/flash.c | 100 3 files

[PATCH 9/9] MN10300: Fix MTD JEDEC probe so that the ASB2303 bootprom can be detected [2.6.24-rc3-mm2]

2007-11-29 Thread David Howells
Fix MTD JEDEC probe so that the ASB2303 bootprom can be accessed. This is presumably required because the bootprom is normally write-protected and so the normal flash probes don't work as they require the ability to write to the flash to send it commands. In the condition of the excluded

Re: named + capset = EPERM [Was: 2.6.24-rc3-mm2]

2007-11-29 Thread Jiri Slaby
On 11/29/2007 01:17 AM, Serge E. Hallyn wrote: > From 70d5da610fdbd66a36886c01e27b7fb11d2de044 Mon Sep 17 00:00:00 2001 > From: [EMAIL PROTECTED] <[EMAIL PROTECTED](none)> > Date: Wed, 28 Nov 2007 16:16:23 -0800 > Subject: [PATCH 1/1] capabilities: correct logic at capset_check > > Fix typo at

Re: sata NCQ blacklist entry

2007-11-29 Thread Tejun Heo
Bjoern Olausson wrote: > On 11/7/07, Tejun Heo <[EMAIL PROTECTED]> wrote: >> Thanks. We're currently trying to find out what's actually going on >> with all these drives. At first, drives which got blacklisted aren't >> many and made sense (had other problems with NCQ, etc..) but with new >>

Re: Out of tree module using LSM

2007-11-29 Thread Andi Kleen
Alan Cox <[EMAIL PROTECTED]> writes: > > The simple case is > open > write cathedral and bazaar in some order > close >process -> label eric_t> > > open (eric_t) - SELinux "no" > > > Anyone smart will then write it out of order and keep the file open, or That would

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread Chuck Ebbert
On 11/29/2007 05:21 PM, Roland McGrath wrote: >>> case offsetof(struct user32, regs.gs): >>> *val = child->thread.gsindex; >>> + if (child == current) >>> + asm("movl %%gs,%0" : "=r" (*val)); >> Won't this return the kernel's GS instead of the user's? >

Re: [PATCH x86/mm 01/11] x86-32 thread_struct.debugreg

2007-11-29 Thread Chuck Ebbert
On 11/29/2007 04:50 PM, Roland McGrath wrote: > Jan Kratochvil has helped me a great deal with ptrace testing lately. > We have started to collect a small regression test suite, see > http://sourceware.org/systemtap/wiki/utrace/tests for pointers. That > has tests for individual problems that

Re: Race between generic_forget_inode() and sync_sb_inodes()?

2007-11-29 Thread Neil Brown
On Friday November 30, [EMAIL PROTECTED] wrote: > On Fri, Nov 30, 2007 at 09:07:06AM +1100, Neil Brown wrote: > > > > Hi David, > > > > On Friday November 30, [EMAIL PROTECTED] wrote: > > > > > > > > > I came across this because I've been making changes to XFS to avoid the > > > inode hash,

alloc_page_vma: should be called from a module? (not exported in x86_64)

2007-11-29 Thread Alejandro Homs Puron
Hi, We've developed a driver for an image acquisition card, which maps kernel alloc'ed buffers into user space vma's. We use alloc_page + remap_pfn_range in the driver mmap file_operation. After looking at alloc_page_vma, I thought that it might be more appropiate than alloc_page in this

<    4   5   6   7   8   9   10   >