Re: [PATCH V2 0/4] [SCSI] ufs: Adds glue drivers to ufshcd

2012-07-13 Thread Arnd Bergmann
On Friday 13 July 2012, Vinayak Holikatti wrote: > This patch set adds following features > - Seprates PCI specific code from ufshcd.c to make it as core > - Adds PCI glue driver ufshcd-pci.c > - Adds Platform glue driver ufshcd-pltfrm.c > - Update correct transfer size in Command UPIU Acked-b

Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs

2012-07-13 Thread Matthew Garrett
On Fri, Jul 13, 2012 at 09:38:27AM -0600, Khalid Aziz wrote: > if (var->Attributes & 0x4) > str += sprintf(str, "EFI_VARIABLE_RUNTIME_ACCESS\n"); I know you're just following the pattern of the existing code, but could you change these to be more like if (var->Attributes & EF

RE: [PATCH]trace,x86: add x86 irq vector tracepoints

2012-07-13 Thread Thomas Gleixner
On Fri, 13 Jul 2012, Seiji Aguchi wrote: > Thomas, > > Any comment? Yes :) > > > +DECLARE_EVENT_CLASS(irq_vector, > > > + > > > + TP_PROTO(int irq), > > > + > > > + TP_ARGS(irq), > > > + > > > + TP_STRUCT__entry( > > > + __field(int,irq ) Shouldn't this be vector? > >

Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-13 Thread Chris Metcalf
Sorry for the slow reply to your feedback; I had to coordinate with our primary PCI developer (in another timezone) and we both had various unrelated fires to fight along the way. I've appended the patch that corrects all the issues you reported. Bjorn, I'm assuming that it's appropriate for me to

Re: mount -o loop with truncated dosdisk.img uses 100% cpu and can't be killed

2012-07-13 Thread Jeff Moyer
Jan Kara writes: >> It looks like the bug of __getblk_slow(). If requested block was beyond >> end of device, __find_get_block() will find buffer_mapped()'s buffer, >> but block >= end_block is unmapped. So, it can be loop. >> >> The following patch fixes it? If it fix, there are some options to

Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs

2012-07-13 Thread Khalid Aziz
On 07/13/2012 09:46 AM, Matthew Garrett wrote: On Fri, Jul 13, 2012 at 09:38:27AM -0600, Khalid Aziz wrote: if (var->Attributes & 0x4) str += sprintf(str, "EFI_VARIABLE_RUNTIME_ACCESS\n"); I know you're just following the pattern of the existing code, but could you chang

[PATCH v3] resource: make sure requested range is included in the root range

2012-07-13 Thread Octavian Purdila
When the requested range is outside of the root range the logic in __reserve_region_with_split will cause an infinite recursion which will overflow the stack as seen in the warning bellow. This particular stack overflow was caused by requesting the (1-107ff) range while the root range

Re: [PATCH v2] Extend core dump note section to contain file names of mapped files

2012-07-13 Thread Andi Kleen
On Fri, Jul 13, 2012 at 04:58:06PM +0200, Oleg Nesterov wrote: > On 07/12, Denys Vlasenko wrote: > > > > This note has the following format: > > > > long count -- how many files are mapped > > long page_size -- units for file_ofs > > array of [COUNT] elements of > >long start > >long en

Re: [PATCH v4 3/3] acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-07-13 Thread Toshi Kani
On Fri, 2012-07-13 at 17:53 +0900, Yasuaki Ishimatsu wrote: > acpi_bus_trim() stops removing devices, when acpi_bus_remove() return error > number. But acpi_bus_remove() cannot return error number correctly. > acpi_bus_remove() only return -EINVAL, when dev argument is NULL. Thus even if > device c

Re: [GIT PULL] KVM fixes for 3.5-rc6

2012-07-13 Thread Linus Torvalds
On Fri, Jul 13, 2012 at 8:45 AM, Linus Torvalds wrote: > Missing diffstat. Please please *please* always make sure you have > diffstats, because I really want to know that what I'm pulling matches > what you *think* that I'm pulling. And the diffstat isn't just for me > - it hopefully really makes

Re: [PATCH V2 2/4] [SCSI] drivers/scsi/ufs: Add PCI glue driver

2012-07-13 Thread Rolf Eike Beer
Vinayak Holikatti wrote: > +static int __devinit > +ufshcd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > +{ > + struct ufs_hba *hba; > + void __iomem *mmio_base; > + int err; > + > + err = pci_enable_device(pdev); > + if (err) { > + dev_err(&pdev

Re: [PATCH 33/36] AArch64: Generic timers support

2012-07-13 Thread Catalin Marinas
On Fri, Jul 13, 2012 at 01:40:03PM +0100, Arnd Bergmann wrote: > On Thursday 12 July 2012, John Stultz wrote: > > > > On 07/12/2012 10:31 AM, Marc Zyngier wrote: > > > On Thu, 12 Jul 2012 09:57:33 -0700, John Stultz > > > wrote: > > > > > >> So following ia64's method is probably better then copy

Re: [PATCH 33/36] AArch64: Generic timers support

2012-07-13 Thread Arnd Bergmann
On Friday 13 July 2012, Catalin Marinas wrote: > > Architectures that always have a working clock source would then just > > not include the timex.h header and #define ACT_HZ HZ in common code. > > Would something like below be enough? > > Also, are there any implications if we boot with clocksou

RE: [PATCH]trace,x86: add x86 irq vector tracepoints

2012-07-13 Thread Seiji Aguchi
> > > > +DECLARE_EVENT_CLASS(irq_vector, > > > > + > > > > + TP_PROTO(int irq), > > > > + > > > > + TP_ARGS(irq), > > > > + > > > > + TP_STRUCT__entry( > > > > + __field(int,irq ) > > Shouldn't this be vector? > Ok. I will change it to vector. >

Re: [PATCH RFC] regulator: mc13xxx: Populate selector from mc13xxx_fixed_regulator_set_voltage

2012-07-13 Thread Mark Brown
On Fri, Jul 13, 2012 at 11:01:14PM +0800, Axel Lin wrote: > Not very sure if we should implement set_voltage callback for fixed voltage. > ( Other drivers do not implement set_voltage callback for fixed voltage. > Since the voltage is fixed, implement set_voltage callback seems does not > make se

[PATCH] trivial: typo in comment in mksysmap

2012-07-13 Thread Masatake YAMATO
Signed-off-by: Masatake YAMATO --- scripts/mksysmap |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mksysmap b/scripts/mksysmap index 6e133a0..c1b6191 100644 --- a/scripts/mksysmap +++ b/scripts/mksysmap @@ -16,7 +16,7 @@ # The second row specify the type of the

Re: [Xen-devel] [PATCH WIP 2/6] xen/arm: Introduce xen_guest_init

2012-07-13 Thread Stefano Stabellini
On Mon, 9 Jul 2012, Konrad Rzeszutek Wilk wrote: > On Fri, Jun 22, 2012 at 05:14:41PM +0100, Stefano Stabellini wrote: > > We used to rely on a core_initcall to initialize Xen on ARM, however > > core_initcalls are actually called after early consoles are initialized. > > That means that hvc_xen.c

Re: [PATCH 0/6] KGDB/KDB FIQ (NMI) debugger

2012-07-13 Thread Colin Cross
On Fri, Jul 13, 2012 at 2:49 AM, Anton Vorontsov wrote: > On Thu, Jul 05, 2012 at 05:02:12PM -0700, Colin Cross wrote: > [...] >> KGDB can obviously only be enabled on development >> devices, although perhaps a more limited KDB could be left enabled. > > Um, I would argue about 'obviously'. :-) It

Re: [PATCH] fork: fix error handling in dup_task()

2012-07-13 Thread Chris Metcalf
On 7/13/2012 6:07 AM, Akinobu Mita wrote: > 2012/7/13 Andrew Morton : >> On Thu, 12 Jul 2012 20:04:53 +0900 >> Akinobu Mita wrote: >> >>> The function dup_task() may fail at the following function calls in >>> the following order. >>> >>> 0) alloc_task_struct_node() >>> 1) alloc_thread_info_node()

[PATCH 0/9] uprobes: misc, resend

2012-07-13 Thread Oleg Nesterov
Hello. Ingo, I am re-sending the patches which were already discussed and acked. Just in case, I will be offline during the next week. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [PATCH WIP 1/6] xen/arm: fix the shared_info and vcpu_info structs

2012-07-13 Thread Stefano Stabellini
On Mon, 9 Jul 2012, Konrad Rzeszutek Wilk wrote: > On Fri, Jun 22, 2012 at 05:14:40PM +0100, Stefano Stabellini wrote: > > Fix the shared_info and vcpu_info struct definitions to match the ones > > in Xen. > > Is there a corresponding c/s in the Xen tree for this? That's the problem: arch_vcpu_in

[PATCH 2/9] uprobes: __replace_page() should not use page_address_in_vma()

2012-07-13 Thread Oleg Nesterov
page_address_in_vma(old_page) in __replace_page() is ugly and wrong. The caller already knows the correct virtual address, this page was found by get_user_pages(vaddr). However, page_address_in_vma() can actually fail if page->mapping was cleared by __delete_from_page_cache() after get_user_pages(

[PATCH 1/9] uprobes: don't recheck vma/f_mapping in write_opcode()

2012-07-13 Thread Oleg Nesterov
write_opcode() rechecks valid_vma() and ->f_mapping, this is pointless. The caller, register_for_each_vma() or uprobe_mmap(), has already done these checks under mmap_sem. To clarify, uprobe_mmap() checks valid_vma() only, but we can rely on build_probe_list(vm_file->f_mapping->host). Signed-off-

[PATCH 5/9] uprobes: uprobe_mmap/munmap needs list_for_each_entry_safe()

2012-07-13 Thread Oleg Nesterov
The bug was introduced by me in 449d0d7c "uprobes: Simplify the usage of uprobe->pending_list". Yes, we do not care about uprobe->pending_list after return and nobody can remove the current list entry, but put_uprobe(uprobe) can actually free it and thus we need list_for_each_safe(). Reported-by:

[PATCH 6/9] uprobes: suppress uprobe_munmap() from mmput()

2012-07-13 Thread Oleg Nesterov
uprobe_munmap() does get_user_pages() and it is also called from the final mmput()->exit_mmap() path. This slows down exit/mmput() for no reason, and I think it is simply dangerous/wrong to try to fault-in a page into the dying mm. If nothing else, this happens after the last sync_mm_rss(), afaics

[PATCH 7/9] uprobes: fix overflow in vma_address/find_active_uprobe

2012-07-13 Thread Oleg Nesterov
vma->vm_pgoff is "unsigned long", it should be promoted to loff_t before the multiplication to avoid the overflow. Signed-off-by: Oleg Nesterov Acked-by: Srikar Dronamraju --- kernel/events/uprobes.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/events/uprob

[PATCH 8/9] uprobes: kill copy_vma()->uprobe_mmap()

2012-07-13 Thread Oleg Nesterov
Kill copy_vma()->uprobe_mmap(new_vma), it is absolutely wrong. This new_vma was just initialized to represent the new unmapped area, [vm_start, vm_end) was returned by get_unmapped_area() in the caller. This means that uprobe_mmap()->get_user_pages() will fail for sure, simply because find_vma()

[PATCH 9/9] uprobes: kill insert_vm_struct()->uprobe_mmap()

2012-07-13 Thread Oleg Nesterov
Kill insert_vm_struct()->uprobe_mmap(). It is not needed, nobody except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma) with vma->vm_file != NULL. And it is wrong. Again, get_user_pages() can not succeed before vma_link(vma) makes is visible to find_vma(). And even if this worked, we must no

[PATCH 4/9] uprobes: cleanup and document write_opcode()->lock_page(old_page)

2012-07-13 Thread Oleg Nesterov
The comment above write_opcode()->lock_page(old_page) tells about the race with do_wp_page(). I don't really understand which exactly race it means, but afaics this lock_page() was not enough to close all races with do_wp_page(). Anyway, since 77fc4af1 this code is always called with ->mmap_sem ho

[PATCH 3/9] uprobes: kill write_opcode()->lock_page(new_page)

2012-07-13 Thread Oleg Nesterov
write_opcode() does lock_page(new_page) for no reason. Nobody can see this page until __replace_page() exposes it under ptl lock, and we do nothing with this page after pte_unmap_unlock(). If nothing else, the similar code in do_wp_page() doesn't lock the new page for page_add_new_anon_rmap/set_pt

[PATCH] ipvs: fixed sparse warning

2012-07-13 Thread Claudiu Ghioc
Removed the following sparse warnings: * warning: symbol 'ip_vs_control_net_init_sysctl' was not declared. Should it be static? * warning: symbol 'ip_vs_control_net_cleanup_sysctl' was not declared. Should it be static? Signed-off-by: Claudiu Ghioc --- net/netfilter/i

Re: [PATCH] leds: Add LED driver for lm3554 chip

2012-07-13 Thread Shuah Khan
On Fri, 2012-07-13 at 18:11 +0900, G.Shark Jeong wrote: > From: "G.Shark Jeong" > > LM3554 : > The LM3554 is a 2 MHz fixed-frequency synchronous boost > converter with 1.2A dual high side led drivers. > Datasheet: www.ti.com > > Signed-off-by: G.Shark Jeong > --- > drivers/leds/Kconfig

Re: [PATCH WIP 1/6] xen/arm: fix the shared_info and vcpu_info structs

2012-07-13 Thread Ian Campbell
On Fri, 2012-07-13 at 12:48 -0400, Stefano Stabellini wrote: > On Mon, 9 Jul 2012, Konrad Rzeszutek Wilk wrote: > > On Fri, Jun 22, 2012 at 05:14:40PM +0100, Stefano Stabellini wrote: > > > Fix the shared_info and vcpu_info struct definitions to match the ones > > > in Xen. > > > > Is there a corr

Re: [PATCH] x86/vsyscall: allow seccomp filter in vsyscall=emulate

2012-07-13 Thread Will Drewry
On Fri, Jul 13, 2012 at 9:32 AM, Andrew Lutomirski wrote: > On Thu, Jul 12, 2012 at 10:17 PM, Will Drewry wrote: >> If a seccomp filter program is installed, older static binaries and >> distributions with older libc implementations (glibc 2.13 and earlier) >> that rely on vsyscall use will be te

[PATCH v2] x86/vsyscall: allow seccomp filter in vsyscall=emulate

2012-07-13 Thread Will Drewry
If a seccomp filter program is installed, older static binaries and distributions with older libc implementations (glibc 2.13 and earlier) that rely on vsyscall use will be terminated regardless of the filter program policy when executing time, gettimeofday, or getcpu. This is only the case when v

Re: [PATCH WIP 6/6] xen/arm: enable evtchn irqs

2012-07-13 Thread Stefano Stabellini
On Mon, 9 Jul 2012, Konrad Rzeszutek Wilk wrote: > On Fri, Jun 22, 2012 at 05:14:45PM +0100, Stefano Stabellini wrote: > > On ARM irqs are not enabled by default: > > Which IRQs? Xen IRQs? Linux IRQs? Linux IRQs > > - call enable_percpu_irq for IRQ_EVTCHN_CALLBACK; > > Why do we want to do tha

[PATCH] irda: Fix typo in irda

2012-07-13 Thread Masanari Iida
Correct spelling typo in irda. Signed-off-by: Masanari Iida --- net/irda/af_irda.c | 2 +- net/irda/irlan/irlan_provider.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/irda/af_irda.c b/net/irda/af_irda.c index bb14c34..bb738c9f 100644 --- a/net/irda/af_

Re: [PATCH 2/2] regulator: tps6586x: add support for input supply

2012-07-13 Thread Laxman Dewangan
On Friday 13 July 2012 07:52 PM, Mark Brown wrote: * PGP Signed by an unknown key On Fri, Jul 13, 2012 at 07:20:32PM +0530, Laxman Dewangan wrote: There is multiple voltage input pins on device which takes the voltage input for different voltage regulator. Support to configure the voltage input

Re: [PATCH v2] Extend core dump note section to contain file names of mapped files

2012-07-13 Thread Oleg Nesterov
On 07/13, Andi Kleen wrote: > > More information during debugging is always good. Agreed. BTW. Can't we turn (rename and export) alloc_fdmem/free_fdmem into the generic helpers? This patch looks like the "obvious" user. And pidlist_allocate... probably something else. (Denys, to avoid the confus

Re: [PATCH 3/3] tile pci: enable IOMMU to support DMA for legacy devices

2012-07-13 Thread Bjorn Helgaas
On Fri, Jul 13, 2012 at 11:52:11AM -0400, Chris Metcalf wrote: > Sorry for the slow reply to your feedback; I had to coordinate with our > primary PCI developer (in another timezone) and we both had various > unrelated fires to fight along the way. > > I've appended the patch that corrects all the

Re: linux-next: manual merge of the clk tree with the arm-soc tree

2012-07-13 Thread Mike Turquette
On 20120713-10:10, Rob Herring wrote: > > > On 07/13/2012 12:14 AM, Stephen Rothwell wrote: > > Hi Mike, > > > > Today's linux-next merge of the clk tree got a conflict in > > drivers/clk/Makefile between commit 4a31bd28e86a ("ARM: nomadik: convert &

Re: [PATCH] add blockconsole version 1.1

2012-07-13 Thread Jörn Engel
On Fri, 13 July 2012 15:03:38 +0200, Borislav Petkov wrote: > On Thu, Jul 12, 2012 at 01:46:34PM -0400, Jörn Engel wrote: > > + > > +It can currently only be used built-in. > > If so, you need to change the tristate in Kconfig below to bool. Fair point, fixed. > > Logging to partitions is not su

Remove easily user-triggerable BUG from generic_setlease

2012-07-13 Thread Dave Jones
This can be trivially triggered from userspace by passing in something unexpected. [126749.760961] kernel BUG at fs/locks.c:1468! [126749.761849] invalid opcode: [#1] SMP [126749.762490] CPU 2 [126749.811520] Pid: 15891, comm: trinity-child2 Not tainted 3.5.0-rc6+ #105 [126749.813723] RIP:

Re: [Ksummit-2012-discuss] Organising Mini Summits within the Kernel Summit

2012-07-13 Thread Theodore Ts'o
On Wed, Jul 11, 2012 at 09:09:15AM +0100, James Bottomley wrote: > Hi All, > > We have set aside the second day of the kernel summit (Tuesday 28 > August) as mini-summit day. So far we have only the PCI mini summit on > this day, so if you can think of other topics, please send them to the > kern

[PATCH v2] Add missing attributes to EFI variable attribute print out from sysfs

2012-07-13 Thread Khalid Aziz
Some of the EFI variable attributes are missing from print out from /sys/firmware/efi/vars/*/attributes. This patch adds those in. It also updates code to use pre-defined constants for masking current value of attributes. Signed-off-by: Khalid Aziz Cc: sta...@vger.kernel.org --- drivers/firmware

Re: Remove easily user-triggerable BUG from generic_setlease

2012-07-13 Thread Linus Torvalds
On Fri, Jul 13, 2012 at 10:35 AM, Dave Jones wrote: > This can be trivially triggered from userspace by passing in something > unexpected. Argh. It looks like it would be harmless (apart from the noise), except we hold file_lock_lock. Which turns the BUG_ON() into not just "noise and kill the pr

Re: [Xen-devel] [PATCH] xen/events: fix unmask_evtchn for PV on HVM guests

2012-07-13 Thread Stefano Stabellini
On Mon, 9 Jul 2012, Konrad Rzeszutek Wilk wrote: > On Fri, Jun 22, 2012 at 05:26:07PM +0100, Stefano Stabellini wrote: > > When unmask_evtchn is called, if we already have an event pending, we > > just set evtchn_pending_sel waiting for local_irq_enable to be called. > > That is because PV guests s

Re: Remove easily user-triggerable BUG from generic_setlease

2012-07-13 Thread Dave Jones
On Fri, Jul 13, 2012 at 10:47:43AM -0700, Linus Torvalds wrote: > On Fri, Jul 13, 2012 at 10:35 AM, Dave Jones wrote: > > This can be trivially triggered from userspace by passing in something > > unexpected. > > Argh. It looks like it would be harmless (apart from the noise), > except we

Re: [PATCH v2] Add missing attributes to EFI variable attribute print out from sysfs

2012-07-13 Thread Matthew Garrett
On Fri, Jul 13, 2012 at 11:42:16AM -0600, Khalid Aziz wrote: > Some of the EFI variable attributes are missing from print out from > /sys/firmware/efi/vars/*/attributes. This patch adds those in. It also > updates code to use pre-defined constants for masking current value > of attributes. > > Sig

Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool

2012-07-13 Thread Tony Luck
On Thu, Jul 12, 2012 at 4:46 PM, Tony Luck wrote: > Still hasn't come back in three reboots. I have to leave now, can continue > tomorrow. Tired of rebooting ... seems that it is very hard to hit this with this patch :-( -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs

2012-07-13 Thread Khalid Aziz
On 07/13/2012 09:46 AM, Matthew Garrett wrote: I know you're just following the pattern of the existing code, but could you change these to be more like if (var->Attributes & EFI_VARIABLE_RUNTIME_ACCESS) while you're at it? I think that'd be a worthwhile cleanup. I just sent out an updated p

Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs

2012-07-13 Thread Matthew Garrett
On Fri, Jul 13, 2012 at 11:52:15AM -0600, Khalid Aziz wrote: > EFI_VARIABLE_NON_VOLATILE -> EFI_VAR_NV > EFI_VARIABLE_BOOTSERVICE_ACCESS -> EFI_VAR_BOOT > EFI_VARIABLE_RUNTIME_ACCESS -> EFI_VAR_RUNTIME > EFI_VARIABLE_HARDWARE_ERROR_RECORD

Re: [PATCH] rpmsg bus subsys_initcall initialization ordering

2012-07-13 Thread Ohad Ben-Cohen
Hi Federico, On Wed, Jul 11, 2012 at 10:14 AM, Federico Fuga wrote: > it triggers a BUG() in drivers/base/driver.c line 169 Thanks for sharing this; it definitely makes sense now. > The subsys_initcall indeed solve this issue I agree. I'll take it, but will change the commit log to make it oma

Re: Runtime updates to EFI secure variables

2012-07-13 Thread Matthew Garrett
On Fri, Jul 13, 2012 at 06:12:26PM +0100, James Bottomley wrote: > This means (provided we have access to the relevant keys) we can move > the platform into and out of Setup Mode as well as add signing and other > keys. I'm pretty sure that the expected behaviour is to use EFI_VARIABLE_APPEND_WR

[PATCH] x86, amd: rename vmmu support capability

2012-07-13 Thread Davidlohr Bueso
From: Davidlohr Bueso AMD has renamed nested page table technology to rapid virtualization indexing, reflect this change in the kernel. Signed-off-by: Davidlohr Bueso --- arch/x86/include/asm/cpufeature.h |2 +- arch/x86/kernel/cpu/scattered.c |2 +- arch/x86/kvm/svm.c

Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs

2012-07-13 Thread Khalid Aziz
On 07/13/2012 11:54 AM, Matthew Garrett wrote: On Fri, Jul 13, 2012 at 11:52:15AM -0600, Khalid Aziz wrote: EFI_VARIABLE_NON_VOLATILE -> EFI_VAR_NV EFI_VARIABLE_BOOTSERVICE_ACCESS -> EFI_VAR_BOOT EFI_VARIABLE_RUNTIME_ACCESS -> EFI_VAR_RUN

3.5-rc6 futex_wait_requeue_pi oops.

2012-07-13 Thread Dave Jones
Looks like calling futex() with garbage makes things unhappy. Dave [ 673.054286] BUG: unable to handle kernel NULL pointer dereference at 0028 [ 673.055292] IP: [] __lock_acquire+0x5e/0x1ae0 [ 673.056225] PGD 1107c8067 PUD 11079c067 PMD 0 [ 673.057224] Oops: [#1] S

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-13 Thread Yinghai Lu
On Fri, Jul 13, 2012 at 6:41 AM, Stefan Bader wrote: > I was bisecting a problem on 64bit where any attempt to cause a crash kernel > to > boot would hang. The bisect ended up on commit 722bc6b (x86/mm: Fix the size > calculation of mapping tables) and somehow, looking at the calling function >

Re: UIO: missing resource mapping

2012-07-13 Thread Michael S. Tsirkin
On Fri, Jul 13, 2012 at 04:42:51PM +0200, Dominic Eschweiler wrote: > Am Freitag, den 13.07.2012, 16:22 +0300 schrieb Michael S. Tsirkin: > > Could you give an example of the problem? How do you bind > > both UIO and another driver to the same device? > > Sorry, I'm looking on it from the user-sp

Re: Runtime updates to EFI secure variables

2012-07-13 Thread James Bottomley
On Fri, 2012-07-13 at 19:02 +0100, Matthew Garrett wrote: > On Fri, Jul 13, 2012 at 06:12:26PM +0100, James Bottomley wrote: > > > This means (provided we have access to the relevant keys) we can move > > the platform into and out of Setup Mode as well as add signing and other > > keys. > > I'm p

Re: [GIT PULL] KVM fixes for 3.5-rc6

2012-07-13 Thread Thomas Gleixner
On Fri, 13 Jul 2012, Linus Torvalds wrote: > On Fri, Jul 13, 2012 at 8:45 AM, Linus Torvalds > wrote: > At the same time, I do wonder if maybe MSI + IRQF_ONESHOT couldn't be > improved. The fact that the KVM people think that the extra overhead > of IRQF_ONESHOT is a bad thing for MSI interrupts

[PATCH v2] kconfig: allow long lines in config file

2012-07-13 Thread cody
From: Cody Schafer For some config options (CONFIG_EXTRA_FIRMWARE, for example), the length of a config file line can exceed the 1024 byte buffer. Switch from fgets to compat_getline to fix. compat_getline is an internally implimented getline work-alike for portability purposes. Signed-off-by:

Re: [PATCH] kconfig: allow long lines in config file

2012-07-13 Thread cody
Do we have any strict standards for what is and is not portable? (I'm aware 'getline' was only added to posix ~4 years ago in 2008). -- Cody -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [PATCH 33/36] AArch64: Generic timers support

2012-07-13 Thread John Stultz
On 07/13/2012 09:02 AM, Catalin Marinas wrote: On Fri, Jul 13, 2012 at 01:40:03PM +0100, Arnd Bergmann wrote: Hmm, in the quest to eliminate CLOCK_TICK_RATE entirely, could we make a Kconfig symbol that is selected for all architectures that (may) rely on a periodic timer tick and require this t

Re: [PATCH 1/8] ntp: Fix STA_INS/DEL clearing bug

2012-07-13 Thread John Stultz
On 07/12/2012 10:58 PM, Ingo Molnar wrote: * John Stultz wrote: From: John Stultz In commit 6b43ae8a619d17c4935c3320d2ef9e92bdeed05d, I introduced a bug that kept the STA_INS or STA_DEL bit from being cleared from time_status via adjtimex() without forcing STA_PLL first. Usually once the S

Re: 3.5-rc6 futex_wait_requeue_pi oops.

2012-07-13 Thread Thomas Gleixner
On Fri, 13 Jul 2012, Dave Jones wrote: > Looks like calling futex() with garbage makes things unhappy. Cc'ing Darren and Peter. > [ 673.054286] BUG: unable to handle kernel NULL pointer dereference at > 0028 > [ 673.055292] IP: [] __lock_acquire+0x5e/0x1ae0 > [ 673.056225] PGD 11

Re: [RFC][PATCH 2/4 v4] ftrace/x86: Add save_regs for i386 function calls

2012-07-13 Thread Steven Rostedt
On Thu, 2012-07-12 at 21:39 +0900, Masami Hiramatsu wrote: > /* > * X86_32 CPUs don't save ss and esp if the CPU is already in kernel mode > * when it traps. The previous stack will be directly underneath the saved > * registers, and 'sp/ss' won't even have been saved. Thus the '®s->sp'. > *

Re: [RFC] dma-fence: dma-buf synchronization (v2)

2012-07-13 Thread Rob Clark
On Fri, Jul 13, 2012 at 12:35 PM, Tom Cooksey wrote: > My other thought is around atomicity. Could this be extended to > (safely) allow for hardware devices which might want to access > multiple buffers simultaneously? I think it probably can with > some tweaks to the interface? An atomic function

Re: [GIT PULL] KVM fixes for 3.5-rc6

2012-07-13 Thread Linus Torvalds
On Fri, Jul 13, 2012 at 11:28 AM, Thomas Gleixner wrote: > > We already discussed to let the irq chip (in this case MSI) tell the > core that it does not need the extra oneshot handling. That way the > code which requests an threaded irq with the NULL primary handler > works on both MSI and normal

Re: 3.5-rc6 futex_wait_requeue_pi oops.

2012-07-13 Thread Dave Jones
On Fri, Jul 13, 2012 at 08:47:38PM +0200, Thomas Gleixner wrote: > On Fri, 13 Jul 2012, Dave Jones wrote: > > > Looks like calling futex() with garbage makes things unhappy. > > WARN_ON(!&q.pi_state); > pi_mutex = &q.pi_state->pi_mutex; > ret

[pull] drm-intel-next

2012-07-13 Thread Daniel Vetter
Hi Dave, New pull for -next. Highlights: - rc6/turbo support for hsw (Eugeni) - improve corner-case of the reset handling code - gpu reset handling should be rock-solid now - support for fb offset > 4096 pixels on gen4+ (yeah, you need some fairly big screens to hit that) - the "Flush Me Harde

Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)

2012-07-13 Thread Steven Rostedt
On Fri, Jul 13, 2012 at 03:24:43PM +0200, Borislav Petkov wrote: > On Fri, Jul 13, 2012 at 03:15:29PM +0200, Paolo Bonzini wrote: > > Il 13/07/2012 15:13, KY Srinivasan ha scritto: > > >> > > > >> > Somone was trying to be funny, I guess. > > >> > > > >> > KY, I suppose you have access to Hyper-V

Re: [GIT PULL] KVM fixes for 3.5-rc6

2012-07-13 Thread Thomas Gleixner
On Fri, 13 Jul 2012, Linus Torvalds wrote: > On Fri, Jul 13, 2012 at 11:28 AM, Thomas Gleixner wrote: > > > > We already discussed to let the irq chip (in this case MSI) tell the > > core that it does not need the extra oneshot handling. That way the > > code which requests an threaded irq with t

Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs

2012-07-13 Thread Khalid Aziz
On 07/13/2012 12:04 PM, Mike Waychison wrote: You can probably save the wrap by copying out var->Attributes into a local. Yes, you are right. It will work in this case. I am considering the general case of very long name for a constant causing issues with line wrap in more complex code, or jus

Re: 3.5-rc6 futex_wait_requeue_pi oops.

2012-07-13 Thread Thomas Gleixner
On Fri, 13 Jul 2012, Dave Jones wrote: > On Fri, Jul 13, 2012 at 08:47:38PM +0200, Thomas Gleixner wrote: > > On Fri, 13 Jul 2012, Dave Jones wrote: > > > > > Looks like calling futex() with garbage makes things unhappy. > > > > WARN_ON(!&q.pi_state); > > pi

RE: [PATCH]trace,x86: add x86 irq vector tracepoints

2012-07-13 Thread Thomas Gleixner
On Fri, 13 Jul 2012, Seiji Aguchi wrote: > > Those x86 specific ones are not really frequently raised vectors, > > so enabling them all won't affect performance and readability of > > the traces too much. > > OK. I will unify these to a single tracepoint. > "x86_irq_vector" or so? I'd rather see

[PATCH] mn10300: Only add -mmem-funcs to KBUILD_CFLAGS if gcc supports it

2012-07-13 Thread Geert Uytterhoeven
It seems the current (gcc 4.6.3) no longer provides this so make it conditional. As reported by Tony before, the mn10300 architecture cross-compiles with gcc-4.6.3 if -mmem-funcs is not added to KBUILD_CFLAGS. Reported-by: Tony Breeds Signed-off-by: Geert Uytterhoeven --- Only compile-tested, n

Re: [PATCH 0/7] Add support for Freescale's mc34708 to mc13xxx driver

2012-07-13 Thread Junio C Hamano
Uwe Kleine-König writes: > It doesn't move it around, that's only how it looks. I removed enum > mc13xxx_id (above MC13XXX_NUMREGS) and added struct mc13xxx_variant > (below MC13XXX_NUMREGS). Git choosed to use the closing brace of enum > mc13xxx_id and struct mc13xxx_variant respectively as con

[PATCH v4 0/3] kvm: level irqfd and new eoifd

2012-07-13 Thread Alex Williamson
v4: - KVM_IRQFD_FLAG_LEVEL flag now documented and coded to only be necessary on assign. - Lock added to struct _irq_source to maintain the source ID assertion state to avoid repeat assertions or spurious EOIs. I couldn't figure out a way to make this work w/o races using atomics and do

[PATCH v4 1/3] kvm: Extend irqfd to support level interrupts

2012-07-13 Thread Alex Williamson
In order to inject a level interrupt from an external source using an irqfd, we need to allocate a new irq_source_id. This allows us to assert and (later) de-assert an interrupt line independently from users of KVM_IRQ_LINE and avoid lost interrupts. We also add what may appear like a bit of exce

[PATCH v4 2/3] kvm: KVM_EOIFD, an eventfd for EOIs

2012-07-13 Thread Alex Williamson
This new ioctl enables an eventfd to be triggered when an EOI is written for a specified irqchip pin. The first user of this will be external device assignment through VFIO, using a level irqfd for asserting a PCI INTx interrupt and this interface for de-assert and notification once the interrupt

[PATCH v4 3/3] kvm: Add a GSI specification for KVM_EOIFD

2012-07-13 Thread Alex Williamson
NOT FOR COMMIT - Here's what it would look like to add a GSI flavor for KVM_EOIFD later. I expect we're going to need this to support generic EOI notifiers in qemu when irqchip is enabled. No API doc included here yet. Signed-off-by: Alex Williamson --- include/linux/kvm.h |8 +++- vir

[RFC][PATCH] x86_32: Return actual stack when requesting sp from regs

2012-07-13 Thread Steven Rostedt
As x86_32 traps do not save sp when taken in kernel mode, we need to accommodate the sp when requesting to get the register. This affects kprobes. Before: # echo 'p:ftrace sys_read+4 s=%sp' > /debug/tracing/kprobe_events # echo 1 > /debug/tracing/events/kprobes/enable # cat trace

Re: 3.5-rc6 futex_wait_requeue_pi oops.

2012-07-13 Thread Dave Jones
On Fri, Jul 13, 2012 at 09:11:57PM +0200, Thomas Gleixner wrote: > On Fri, 13 Jul 2012, Dave Jones wrote: > > > On Fri, Jul 13, 2012 at 08:47:38PM +0200, Thomas Gleixner wrote: > > > On Fri, 13 Jul 2012, Dave Jones wrote: > > > > > > > Looks like calling futex() with garbage makes things

Re: Build regressions/improvements in v3.5-rc4

2012-07-13 Thread Geert Uytterhoeven
On Tue, Jun 26, 2012 at 9:59 PM, Geert Uytterhoeven wrote: > + drivers/i2c/busses/i2c-bfin-twi.c: error: 'ANAK' undeclared (first use in > this function): => 154:19 > + drivers/i2c/busses/i2c-bfin-twi.c: error: 'BUFRDERR' undeclared (first > use in this function): => 158:19 > + drivers/i2c

Re: [PATCH v2 05/12] rbtree: performance and correctness test

2012-07-13 Thread Andrew Morton
On Thu, 12 Jul 2012 17:31:50 -0700 Michel Lespinasse wrote: > This small module helps measure the performance of rbtree insert and erase. > > Additionally, we run a few correctness tests to check that the rbtrees have > all desired properties: > - contains the right number of nodes in the order

Re: [Xen-devel] incorrect layout of globals from head_64.S during kexec boot

2012-07-13 Thread Olaf Hering
On Tue, Jul 10, Keir Fraser wrote: > On 10/07/2012 19:09, "Olaf Hering" wrote: > > I'm not sure, most likely the gfn will just disappear from the guest, > > like a ballooned page disappears. Accessing it will likely cause a > > crash. > > Best thing to do, is possible, is map the shared-info pag

[PATCH 1/3] staging/vt6656: coding style fix in BSSvSecondTxData

2012-07-13 Thread Devendra Naga
this function seemed bit more coding style fix... The following fixes: remove spaces at start of line and use tabs use space between if and ( give a space in a multiplication operation use space after = and another variable/constant Signed-off-by: Devendra Naga --- drivers/staging/vt6656/wcmd.

[PATCH 2/3] staging/vt6656: remove unnecessary return in BSSvSecondTxData

2012-07-13 Thread Devendra Naga
this return is at the function end, and function is returning nothing.. i.e a void. Signed-off-by: Devendra Naga --- drivers/staging/vt6656/wcmd.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c index cecfdb6..c9de937 100644 ---

[PATCH 3/3] staging/vt6656: cleanup coding style in vResetCommandTimer

2012-07-13 Thread Devendra Naga
the following fixes... removed spaces at start of a line and used tabs Signed-off-by: Devendra Naga --- drivers/staging/vt6656/wcmd.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.

[PATCH] PCI: Fix undefined reference to 'pci_fixup_final_inited'

2012-07-13 Thread Myron Stowe
My "PCI: Integrate 'pci_fixup_final' quirks into hot-plug paths" patch introduced an undefined reference to 'pci_fixup_final_inited' when CONFIG_PCI_QUIRKS is not enabled (on x86_64): drivers/built-in.o: In function `pci_bus_add_device': (.text+0x4f62): undefined reference to `pci_fixup_final_i

RE: 2976579765? Really? (was Re: Move hyperv out of the drivers/staging/ directory)

2012-07-13 Thread Paul Bolle
On Fri, 2012-07-13 at 13:21 +, KY Srinivasan wrote: > Ok! I don't know how easy it is to change this. I'd say nothing could possibly break if you just changed that line to #define HV_LINUX_GUEST_ID_HI 2976579765 (Not that I, somehow, tested this.) Paul Bolle -- To unsubscribe

[PATCH] mac802154: fix sparse warning for mac802154_slave_get_priv

2012-07-13 Thread Silviu-Mihai Popescu
Make sparse happy by fixing the following error: * symbol 'mac802154_slave_get_priv' was not declared. Should it be static? Signed-off-by: Silviu-Mihai Popescu --- net/mac802154/mib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac802154/mib.c b/net/mac802154

[RFC] Simplifying kernel configuration for distro issues

2012-07-13 Thread Linus Torvalds
So this has long been one of my pet configuration peeves: as a user I am perfectly happy answering the questions about what kinds of hardware I want the kernel to support (I kind of know that), but many of the "support infrastructure" questions are very opaque, and I have no idea which of the them

Re: [PATCH] kconfig: allow long lines in config file

2012-07-13 Thread Michal Marek
Dne 13.7.2012 20:30, cody napsal(a): > Do we have any strict standards for what is and is not portable? We don't. I only checked the existing userspace code and except for perf, there is no other usage of getline(). > (I'm aware 'getline' was only added to posix ~4 years ago in 2008). Ah, good

Re: linux-next: Tree for July 12 (pci)

2012-07-13 Thread Myron Stowe
On Thu, Jul 12, 2012 at 10:11 AM, Randy Dunlap wrote: > On 07/11/2012 11:03 PM, Stephen Rothwell wrote: > >> Hi all, >> >> Changes since 20120710: >> >> >> The pci tree lost its conflicts. > > > on x86_64: > > drivers/built-in.o: In function `pci_bus_add_device': > (.text+0x4f62): undefined refere

[PATCH 2/5] MIPS: perf: Add cpu feature bit for PCI (performance counter interrupt)

2012-07-13 Thread Al Cooper
The PCI (Program Counter Interrupt) bit in the "cause" register is mandatory for MIPS32R2 cores, but has also been added to some R1 cores (BMIPS5000). This change adds a cpu feature bit to make it easier to check for and use this feature. Signed-off-by: Al Cooper --- arch/mips/include/asm/cpu-fe

[PATCH 3/5] MIPS: perf: Remove unnecessary #ifdef

2012-07-13 Thread Al Cooper
The #ifdef for CONFIG_HW_PERF_EVENTS is not needed because the Makefile will only compile the module if this config option is set. This means that the code under #else would never be compiled. This may have been done to leave the original broken code around for reference, but the FIXME comment abov

[PATCH 4/5] MIPS: perf: Split the Kconfig option CONFIG_MIPS_MT_SMP

2012-07-13 Thread Al Cooper
Split the Kconfig option CONFIG_MIPS_MT_SMP into CONFIG_MIPS_MT_SMP and CONFIG_MIPS_PERF_SHARED_TC_COUNTERS so some of the code used for performance counters that are shared between threads can be used for MIPS cores that are not MT_SMP. Signed-off-by: Al Cooper --- arch/mips/Kconfig

[PATCH 1/5] MIPS: perf: Change the "mips_perf_event" table unsupported indicator.

2012-07-13 Thread Al Cooper
Change the indicator from 0x in the "event_id" member to zero in the "cntr_mask" member. This removes the need to initialize entries that are unsupported. This also solves a problem where the number of entries in the table was increased based on a globel enum used for all platforms, but the

<    1   2   3   4   5   >