Re: [PATCH V2] staging: dgap: implement proper error handling in dgap_firmware_load()

2014-05-28 Thread Mark Hounschell
On 05/28/2014 06:11 AM, Dan Carpenter wrote: > On Wed, May 28, 2014 at 06:29:38PM +0900, DaeSeok Youn wrote: >>> In your patch it has: >>> + dgap_tty_uninit(brd, false); >>> >>> But it should only be "false" if dgap_tty_init() failed. If >>> dgap_tty_register_ports() fails then it should be

Re: [PATCH] block: mq flush: fix race between IPI handler and mq flush worker

2014-05-28 Thread Jens Axboe
On 2014-05-27 23:22, Christoph Hellwig wrote: On Tue, May 27, 2014 at 08:31:18PM -0600, Jens Axboe wrote: Christoph, I'll just run a few tests and then queue it up in the morning. Can you send a properly signed-off patch with a commit message as well? I was writing one up, but I still need the s

Re: [PATCH net] bridge: notify user space after fdb update

2014-05-28 Thread Sergei Shtylyov
Hello. On 05/28/2014 02:45 AM, Jon Maxwell wrote: There has been a number incidents recently where customers running KVM have reported that VM hosts on different Hypervisors are unreachable. Based on pcap traces we found that the bridge was broadcasting the ARP request out onto the network. How

Re: fs/dcache.c - BUG: soft lockup - CPU#5 stuck for 22s! [systemd-udevd:1667]

2014-05-28 Thread Al Viro
On Wed, May 28, 2014 at 04:11:36PM +0300, Mika Westerberg wrote: > I added this on top of your previus patch and unfortunately the livelock > is still there :-( > > >From the previous log, it looks like udev is doing exactly same operation > (check_submounts_and_drop) on 4 of the CPUs in paraller

Re: blk-mq: refactor request allocation

2014-05-28 Thread Jens Axboe
On 2014-05-27 23:19, Christoph Hellwig wrote: On Tue, May 27, 2014 at 02:58:08PM -0600, Jens Axboe wrote: On 05/27/2014 12:59 PM, Christoph Hellwig wrote: This series streamlines the request allocation path. Series looks innocuous enough to me, but it's about a 1.5% performance drop here wit

Re: [PATCH] fix busted pr_info conversion in kernel/workqueue.c

2014-05-28 Thread Tejun Heo
On Tue, May 27, 2014 at 04:27:09PM -0400, valdis.kletni...@vt.edu wrote: > On Tue, 27 May 2014 20:44:33 +0200, Fabian Frederick said: > > Hello Valdis, > > > > I thought Tejun directly reverted that patch (Joe Perches noticed > > the level problem just after submit).Anyway, problem is solved n

Re: [PATCH v2 0/4] memcg: Low-limit reclaim

2014-05-28 Thread Michal Hocko
On Wed 28-05-14 09:49:05, Johannes Weiner wrote: > On Wed, May 28, 2014 at 02:10:23PM +0200, Michal Hocko wrote: > > Hi Andrew, Johannes, > > > > On Mon 28-04-14 14:26:41, Michal Hocko wrote: > > > This patchset introduces such low limit that is functionally similar > > > to a minimum guarantee. M

[PATCH v3] ehea: Introduce the use of the managed version of kzalloc

2014-05-28 Thread Himangi Saraogi
This patch moves data allocated using kzalloc to managed data allocated using devm_kzalloc and cleans now unnecessary kfrees in probe and remove functions. Also, linux/device.h is added to make sure the devm_*() routine declarations are unambiguously available. The following Coccinelle semantic pa

Re: [PATCH] usb: pci-quirks: do not access OHCI_FMINTERVAL register on ULI hw

2014-05-28 Thread Alan Stern
On Wed, 28 May 2014, Nikita Yushchenko wrote: > 27.05.2014 19:08, Alan Stern пишет: > > On Tue, 27 May 2014, Nikita Yushchenko wrote: > > > >> This access causes hang on Freescale P2020DS board (that has OHCI > >> provided by ULI 1533 chip). > > > > Which access, the read or the write? > > thin

Re: [RFC 2/2] x86_64: expand kernel stack to 16K

2014-05-28 Thread H. Peter Anvin
We tried for 4K on x86-64, too, for b quite a while as I recall. The kernel stack is a one of the main costs for a thread. I would like to decouple struct thread_info from the kernel stack (PJ Waskewicz was working on that before he left Intel) but that doesn't buy us all that much. 8K additi

Re: [RFC PATCH v2 1/7] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-28 Thread Steven Rostedt
On Wed, 21 May 2014 09:26:41 +0100 Javi Merino wrote: > Hi Steve, > > On Wed, May 21, 2014 at 03:07:23AM +0100, Steven Rostedt wrote: > > Hmm, I didn't think about cross tree dependencies. I already pushed this > > patch to my for-next branch which is already in linux-next, and I do not > > reba

Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread James Bottomley
On Wed, 2014-05-28 at 03:41 -0700, Christoph Hellwig wrote: > On Sat, May 24, 2014 at 12:13:53PM +0200, Paul Bolle wrote: > > The acornscsi driver was added in v2.1.88. It has always #undef-ed > > CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be > > sure, it has also always t

Re: [stable-3.10.y] possible unsafe locking warning

2014-05-28 Thread Greg KH
On Wed, May 28, 2014 at 06:06:34PM +0800, Gu Zheng wrote: > Hi all, > When offline the whole memory of a movable numa node on kernel stable-3.10-y, > the following possible deadlock warning occurs. > > [ 2457.467359] > [ 2457.485175] = > [ 2457.537325] [ INFO: inco

Re: [PATCH V2] staging: dgap: implement proper error handling in dgap_firmware_load()

2014-05-28 Thread Dan Carpenter
On Wed, May 28, 2014 at 10:14:03AM -0400, Mark Hounschell wrote: > Is that TODO-list going to be commited? The TODO-list is a new thing. People are always complaining that there isn't a TODO-list with task for people to do. Now I can just search my inbox and generate one automatically. Fancy, h

[PATCH] ARM: pci: add call to pcie_bus_configure_settings()

2014-05-28 Thread Murali Karicheri
PCI core supports PCIE_BUS_SAFE and PCIE_BUS_PERFORMANCE modes. PCI controllers may not be able to handle pay load size higher than MPS and also read data size higher than MRSS. So limit the max to the least common supported payload size by calling pcie_bus_configure_settings(). Using pci=pcie_bus_

[PATCH] fence: Use smp_mb__before_atomic()

2014-05-28 Thread Thierry Reding
From: Thierry Reding Commit febdbfe8a91c (arch: Prepare for smp_mb__{before,after}_atomic()) deprecated the smp_mb__{before,after}_{atomic,clear}_{dec,inc,bit}*() functions in favour of the unified smp_mb__{before,after}_atomic(). Signed-off-by: Thierry Reding --- drivers/base/fence.c | 4 ++--

Re: [PATCH] HID: hid-sensor-hub: Set report quirk for Microsoft Surface

2014-05-28 Thread Jiri Kosina
On Wed, 28 May 2014, Benjamin Tissoires wrote: > I guess this should be fine: > f3b0cbce01 has no more impact (there is no USB_DEVICE_ID_MS_*_2 > anymore) > > e24d0d399b2f will properly add the HID_GROUP_SENSOR_HUB to the sensors > if the report descriptor is properly set. > > Given that the gro

[PATCH 1/2] Staging: rtl8192u: r8192U_wx.c Added missing spaces

2014-05-28 Thread Chaitanya Hazarey
Added spaces needed in the proper places to address: WARNING: please, no spaces at the start of a line WARNING: missing space after struct definition ERROR: spaces required around that '!=' (ctx:WxV) ERROR: spaces required around that '=' (ctx:WxV) ERROR: spaces required around that '=' (ctx:VxW)

[PATCH 2/2] Staging: rtl8192u: r8192U_wx.c Added {} braces and newlines

2014-05-28 Thread Chaitanya Hazarey
Added {} braces and newlines to address the following: ERROR: else should follow close brace '}' ERROR: space required before the open brace '{' ERROR: trailing statements should be on next line ERROR: space required before the open parenthesis '(' ERROR: that open brace { should be on the previou

Re: [PATCHv5 1/3] dts: socfpga: Add bindings for Altera SoC SDRAM controller

2014-05-28 Thread Alan Tull
On Wed, May 28, 2014 at 2:01 AM, Steffen Trumtrar wrote: > On Tue, May 27, 2014 at 03:57:47PM -0500, Alan Tull wrote: >> On Tue, May 27, 2014 at 2:42 PM, Steffen Trumtrar >> wrote: >> > On Tue, May 27, 2014 at 02:12:17PM -0500, Alan Tull wrote: >> >> On Tue, May 27, 2014 at 2:11 AM, Steffen Trumt

[RFC PATCH] crypto: crc32c-pclmul - Use pmovzxdq to shrink K_table

2014-05-28 Thread George Spelvin
While following a number of tangents in the code (I was figuring out how to edit lib/Kconfig; don't ask), I came across a table of 256 64-bit words, all of which had the high half set to zero. Since the code depends on both pclmulq and crc32, SSE 4.1 is obviously present, so it could use pmovzxdq

[PATCH] scsi/NCR5380: dprintk macro

2014-05-28 Thread Finn Thain
This is the delta between the two submissions: [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure and [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure The macro definition changes were discussed on the mailing list during review. The idea is to get

Re: [RFC PATCH 5/7] perf, x86: use the PEBS auto reload mechanism when possible

2014-05-28 Thread Andi Kleen
On Wed, May 28, 2014 at 09:59:37AM +0200, Peter Zijlstra wrote: > On Wed, May 28, 2014 at 02:18:08PM +0800, Yan, Zheng wrote: > > When a fixed period is specified, this patch make perf use the PEBS > > auto reload mechanism. This makes normal profiling faster, because > > it avoids one costly MSR w

Re: [PATCH] export efi.flags to sysfs

2014-05-28 Thread Vivek Goyal
On Wed, May 28, 2014 at 10:09:35AM +0800, Dave Young wrote: [..] > > I've only vaguely been following along with the other thread, so please > > summarise everything again in your patch. Particularly, I need answers > > to the following questions, > > > > - Are you trying to fix a kexec/kdump re

Re: [RFC PATCH 6/7] perf, x86: large PEBS interrupt threshold

2014-05-28 Thread Andi Kleen
> In particular, the 0x90 offset (IA32_PERF_GLOBAL_STATUS). Intel once > confirmed to me that that is a direct copy of the similarly named MSR at > the time of the PEBS assist. That is correct. > > This is a problem, since if multiple counters overflow multiple bits > will be set and its (afaict

[PATCH 1/1] watchdog: imx2: Added ioctl options to enable/disable watchdog as wanted by systemd.

2014-05-28 Thread Tord Andersson
When the current imx2 watchdog driver is used with the systemd watchdog feature, we get "Failed to enable hardware watchdog: Inappropriate ioctl for device". This is caused by missing ioctl setoptions to enable the watchdog. This patch will add WDIOC_SETOPTIONS for WDIOS_ENABLECARD and WDIOS_DISABL

Re: [RFC PATCH 6/7] perf, x86: large PEBS interrupt threshold

2014-05-28 Thread Peter Zijlstra
On Wed, May 28, 2014 at 02:54:25PM +0200, Stephane Eranian wrote: > On Wed, May 28, 2014 at 10:10 AM, Peter Zijlstra wrote: > > On Wed, May 28, 2014 at 02:18:09PM +0800, Yan, Zheng wrote: > >> PEBS always had the capability to log samples to its buffers without > >> an interrupt. Traditionally per

Re: [PATCH net] bridge: notify user space after fdb update

2014-05-28 Thread Vlad Yasevich
On 05/27/2014 06:45 PM, Jon Maxwell wrote: > There has been a number incidents recently where customers running KVM have > reported that VM hosts on different Hypervisors are unreachable. Based on > pcap traces we found that the bridge was broadcasting the ARP request out > onto the network. Howeve

Re: [PATCH 1/1] driver/md/block: Alloc space for member flush_rq

2014-05-28 Thread Mike Snitzer
On Wed, May 28 2014 at 2:22am -0400, Li, Zhen-Hua wrote: > This patch is trying to fix a kernel crash bug. > > When kernel boots on a HP large system, it crashes. > The reason is when blk_rq_init is called, the second parameter rq , which > is a member as q->flush_rq, is NULL. Kernel does not a

Re: [PATCH/RFC] Re: recvmmsg() timeout behavior strangeness [RESEND]

2014-05-28 Thread Arnaldo Carvalho de Melo
Em Wed, May 28, 2014 at 02:20:10PM +0200, Michael Kerrisk (man-pages) escreveu: > On 05/27/2014 10:30 PM, Arnaldo Carvalho de Melo wrote: > > attached goes the updated patch, and this is the > > diff to the last combined one: > > > > diff --git a/net/socket.c b/net/socket.c > > index 310a50971769.

Re: [jet.c...@intel.com: [bio] kernel BUG at drivers/block/virtio_blk.c:166!]

2014-05-28 Thread Dongsu Park
Hi, On 27.05.2014 13:24, Maurizio Lombardi wrote: > On Tue, May 27, 2014 at 10:43:59AM +0200, Maurizio Lombardi wrote: > > > > But now I'm suspicious of this part of commit 3979ef4dcf: > > > > failed: > > bvec->bv_page = NULL; > > bvec->bv_len = 0; > > bvec->bv_offset =

Re: [PATCH v2 02/11] sched: remove a wake_affine condition

2014-05-28 Thread Dietmar Eggemann
Hi Vincent & Peter, On 28/05/14 07:49, Vincent Guittot wrote: [...] > > Nick, > > While doing some rework on the wake affine part of the scheduler, i > failed to catch the use case that takes advantage of a condition that > you added some while ago with the commit > a3f21bce1fefdf92a4d1705e888d3

[RFC PATCH v4 0/4] ima: extending secure boot certificate chain

2014-05-28 Thread Mimi Zohar
The original patches extended the secure boot signature chain of trust to IMA-appraisal, by allowing only certificates signed by a 'trusted' key on the system_trusted_keyring to be added to the IMA keyring. There were a number of issues with the original patch set, including kbuild issues, which h

[RFC PATCH v4 3/4] ima: define '.ima' as a builtin 'trusted' keyring

2014-05-28 Thread Mimi Zohar
Require all keys added to the IMA keyring be signed by an existing trusted key on the system trusted keyring. Changelog v1: - don't link IMA trusted keyring to user keyring Changelog: - define stub integrity_init_keyring() function (reported-by Fengguang Wu) - differentiate between regular and tr

[PATCH] bio: decrease bi_iter.bi_size by len in the fail path

2014-05-28 Thread Dongsu Park
From: Dongsu Park Commit 3979ef4dcf3d1de55a560a3a4016c30a835df44d ("bio-modify- __bio_add_page-to-accept-pages-that-dont-start-a-new-segment-v3") introduced a regression as reported by Jet Chen. That results in a kernel BUG at drivers/block/virtio_blk.c:166. To fix that, bi_iter.bi_size must be

[RFC PATCH v4 1/4] KEYS: special dot prefixed keyring name bug fix

2014-05-28 Thread Mimi Zohar
Dot prefixed keyring names are supposed to be reserved for the kernel, but add_key() calls key_get_type_from_user(), which incorrectly verifies the 'type' field, not the 'description' field. This patch verifies the 'description' field isn't dot prefixed, when creating a new keyring, and removes the

[RFC PATCH v4 2/4] KEYS: verify a certificate is signed by a 'trusted' key

2014-05-28 Thread Mimi Zohar
Only public keys, with certificates signed by an existing 'trusted' key on the system trusted keyring, should be added to a trusted keyring. This patch adds support for verifying a certificate's signature. This is derived from David Howells pkcs7_request_asymmetric_key() patch. Changelog: - defi

[RFC PATCH v4 4/4] KEYS: define an owner trusted keyring

2014-05-28 Thread Mimi Zohar
(UEFI) secure boot provides a signature chain of trust rooted in hardware. The signature chain of trust includes the Machine Owner Keys(MOKs), which cannot be modified without physical presence. Instead of allowing public keys, with certificates signed by any key on the system trusted keyring, to

[PATCH 0/2] Use resource_size instead of computation

2014-05-28 Thread Benoit Taine
These patches enhance kernel style usage, and make use of the resource_size() function instead of explicit computation. The semantic patch at scripts/coccinelle/api/resource_size.cocci was used to detect and edit this situation. -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [linux-sunxi] [PATCH v9 1/2] Documentation: dt: Add Allwinner A31 DMA controller bindings

2014-05-28 Thread Chen-Yu Tsai
On Thu, May 22, 2014 at 8:34 PM, Maxime Ripard wrote: > The Allwinner A31 DMA controller is rather simple to describe in the DT. Add > the bindings documentation. > > Signed-off-by: Maxime Ripard > --- > .../devicetree/bindings/dma/sun6i-dma.txt | 45 > ++ > 1 file

[PATCH 1/2] ALSA: au1x00: Use resource_size instead of computation

2014-05-28 Thread Benoit Taine
This issue was reported by coccicheck using the semantic patch at scripts/coccinelle/api/resource_size.cocci Signed-off-by: Benoit Taine --- Not compile tested, due incompatible architecture. sound/mips/au1x00.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound

[PATCH 2/2] lpc_eth: Use resource_size instead of computation

2014-05-28 Thread Benoit Taine
This issue was reported by coccicheck using the semantic patch at scripts/coccinelle/api/resource_size.cocci Signed-off-by: Benoit Taine --- Not compile tested, due incompatible architecture. drivers/net/ethernet/nxp/lpc_eth.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

Re: [PATCH v2 1/4] devicetree: bindings: Properly document micrel ks8851 SPI chips

2014-05-28 Thread Uwe Kleine-König
Hello Stephen, On Tue, May 27, 2014 at 02:40:15PM -0700, Stephen Boyd wrote: > On 05/24/14 05:48, Mark Brown wrote: > > On Fri, May 23, 2014 at 12:57:17PM -0700, Stephen Boyd wrote: > > > >> Optional properties: > >> -- vdd-supply: supply for Ethernet mac > >> +- vdd-supply: analog 3.3V suppl

Re: [jet.c...@intel.com: [bio] kernel BUG at drivers/block/virtio_blk.c:166!]

2014-05-28 Thread Jet Chen
On 05/27/2014 07:24 PM, Maurizio Lombardi wrote: > On Tue, May 27, 2014 at 10:43:59AM +0200, Maurizio Lombardi wrote: >> >> But now I'm suspicious of this part of commit 3979ef4dcf: >> >> failed: >> bvec->bv_page = NULL; >> bvec->bv_len = 0; >> bvec->bv_offset = 0; >>

Re: [PATCH v2 08/11] sched: get CPU's activity statistic

2014-05-28 Thread Peter Zijlstra
On Wed, May 28, 2014 at 01:10:01PM +0100, Morten Rasmussen wrote: > The basic problem is that worst case: sum starting from 0 and period > already at LOAD_AVG_MAX = 47742, it takes LOAD_AVG_MAX_N = 345 periods > (ms) for sum to reach 47742. But it takes only 4 periods (4*32ms) to get ~94% of the

RE: [PATCH/RFC] Re: recvmmsg() timeout behavior strangeness [RESEND]

2014-05-28 Thread David Laight
From: Arnaldo Carvalho de Melo ... > > But, another question... > > > > In the case that the call is interrupted by a signal handler and some > > datagrams have already been received, then the call succeeds, and > > returns the number of datagrams received, and 'timeout' is updated with > > the rem

Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread Russell King - ARM Linux
On Wed, May 28, 2014 at 06:26:44PM +0400, James Bottomley wrote: > On Wed, 2014-05-28 at 03:41 -0700, Christoph Hellwig wrote: > > Looks good, > > > > Reviewed-by: Christoph Hellwig > > > > And I have to disagree with James here, removing code that isn't even > > compiled always is an improvemen

Re: perf_fuzzer crash on pentium 4

2014-05-28 Thread Peter Zijlstra
On Wed, May 28, 2014 at 06:06:32PM +0400, Cyrill Gorcunov wrote: > On Wed, May 28, 2014 at 03:56:17PM +0200, Pavel Machek wrote: > > Hi! > > > > > So just to be difficult I fired up the perf_fuzzer on a Pentium 4 machine. > > > > > > It crashes more or less instantly (sorry for the line wrapping,

Re: [PATCH] mfd: fix unintentional NULL check in menelaus_set_voltage()

2014-05-28 Thread Lee Jones
On Wed, 28 May 2014, Emil Goode wrote: > The struct menelaus_vtg pointer vtg cannot be NULL here > so the condition is never true and if it ever was true > it would lead to a NULL pointer dereference when we goto > label set_voltage. > > Before the below patch was applied the code was: > > if (v

Re: [PATCH 03/15] staging: rtl8188eu:Remove unused macro _init_queue()

2014-05-28 Thread navin patidar
On Wed, May 28, 2014 at 12:32 AM, Greg KH wrote: > On Tue, May 27, 2014 at 09:05:43PM +0530, navin patidar wrote: >> Signed-off-by: navin patidar >> --- >> drivers/staging/rtl8712/osdep_service.h |6 -- >> 1 file changed, 6 deletions(-) > > This is the rtl8712 driver, not the rtl8188eu d

Re: vmstat: On demand vmstat workers V5

2014-05-28 Thread Frederic Weisbecker
On Mon, May 12, 2014 at 01:18:10PM -0500, Christoph Lameter wrote: > #ifdef CONFIG_SMP > static DEFINE_PER_CPU(struct delayed_work, vmstat_work); > int sysctl_stat_interval __read_mostly = HZ; > +static DECLARE_BITMAP(cpu_stat_off_bits, CONFIG_NR_CPUS) __read_mostly; > +const struct cpumask *con

Re: [RFC PATCH 6/7] perf, x86: large PEBS interrupt threshold

2014-05-28 Thread Stephane Eranian
On Wed, May 28, 2014 at 4:58 PM, Andi Kleen wrote: >> In particular, the 0x90 offset (IA32_PERF_GLOBAL_STATUS). Intel once >> confirmed to me that that is a direct copy of the similarly named MSR at >> the time of the PEBS assist. > > That is correct. > >> >> This is a problem, since if multiple c

Re: [PATCH v2 02/11] sched: remove a wake_affine condition

2014-05-28 Thread Vincent Guittot
On 28 May 2014 17:09, Dietmar Eggemann wrote: > Hi Vincent & Peter, > > On 28/05/14 07:49, Vincent Guittot wrote: > [...] >> >> Nick, >> >> While doing some rework on the wake affine part of the scheduler, i >> failed to catch the use case that takes advantage of a condition that >> you added some

Re: [PATCH 5/7 v6] trace, RAS: Add eMCA trace event interface

2014-05-28 Thread Steven Rostedt
Added LKML On Tue, 27 May 2014 23:32:18 -0400 "Chen, Gong" wrote: > Add trace interface to elaborate all H/W error related information. > > v6 -> v5: format adjustment. > v5 -> v4: Add physical mask(LSB) in trace. > v4 -> v3: change ras trace dependency rule. > v3 -> v2: minor adjustment accord

Re: [PATCH v2 0/4] memcg: Low-limit reclaim

2014-05-28 Thread Johannes Weiner
On Wed, May 28, 2014 at 04:21:44PM +0200, Michal Hocko wrote: > On Wed 28-05-14 09:49:05, Johannes Weiner wrote: > > On Wed, May 28, 2014 at 02:10:23PM +0200, Michal Hocko wrote: > > > Hi Andrew, Johannes, > > > > > > On Mon 28-04-14 14:26:41, Michal Hocko wrote: > > > > This patchset introduces s

Re: [jet.c...@intel.com: [bio] kernel BUG at drivers/block/virtio_blk.c:166!]

2014-05-28 Thread Maurizio Lombardi
Hi, On Wed, May 28, 2014 at 11:16:17PM +0800, Jet Chen wrote: > > Sorry for late respond. Dongsu has sent a patch for this issue. > message-id > <1401289778-9840-1-git-send-email-dongsu.p...@profitbricks.com> > Do you still need me to test the following patch ? No, don't test my patch, it

Re: [RFC PATCH] crypto: crc32c-pclmul - Use pmovzxdq to shrink K_table

2014-05-28 Thread George Spelvin
Um, yeah, I just noticed the problem with that patch: half of the numbers in that table are 33 bits, and cause a pile of warnings (not errors, unfortunately!) from gas that scrolled by when I wasn't looking. Logically, there should be no need for 33-bit values; they should all be reducible modulo

Re: linux-next: manual merge of the gpio tree with Linus' tree

2014-05-28 Thread Michael Stickel
Am 28.05.2014 15:38, schrieb Michael Welling: > Looking at the Linux next version, I am fairly certian that the following is > redundant checking: > if (chips < 0) { > dev_err(&spi->dev, "FATAL: invalid negative chip > id\n"); > goto

Re: [RFC PATCH 6/7] perf, x86: large PEBS interrupt threshold

2014-05-28 Thread Peter Zijlstra
On Wed, May 28, 2014 at 07:58:31AM -0700, Andi Kleen wrote: > > In particular, the 0x90 offset (IA32_PERF_GLOBAL_STATUS). Intel once > > confirmed to me that that is a direct copy of the similarly named MSR at > > the time of the PEBS assist. > > That is correct. > > > > > This is a problem, sin

Re: [RFC PATCH 5/7] perf, x86: use the PEBS auto reload mechanism when possible

2014-05-28 Thread Peter Zijlstra
On Wed, May 28, 2014 at 07:46:43AM -0700, Andi Kleen wrote: > On Wed, May 28, 2014 at 09:59:37AM +0200, Peter Zijlstra wrote: > > On Wed, May 28, 2014 at 02:18:08PM +0800, Yan, Zheng wrote: > > > When a fixed period is specified, this patch make perf use the PEBS > > > auto reload mechanism. This m

Re: linux-next: manual merge of the staging tree with the net-next tree

2014-05-28 Thread Greg KH
On Wed, May 28, 2014 at 06:28:24PM +1000, Stephen Rothwell wrote: > Hi Greg, > > Today's linux-next merge of the staging tree got a conflict in > drivers/staging/rtl8821ae/core.c between commit 77be2c54c5bd > ("mac80211: add vif to flush call") from the net-next tree and commit > 0cd05ba54a53 ("st

Re: blk-mq: refactor request allocation

2014-05-28 Thread Jens Axboe
On 2014-05-27 23:19, Christoph Hellwig wrote: On Tue, May 27, 2014 at 02:58:08PM -0600, Jens Axboe wrote: On 05/27/2014 12:59 PM, Christoph Hellwig wrote: This series streamlines the request allocation path. Series looks innocuous enough to me, but it's about a 1.5% performance drop here wit

Re: [PATCH v2 08/11] sched: get CPU's activity statistic

2014-05-28 Thread Morten Rasmussen
On Wed, May 28, 2014 at 02:15:03PM +0100, Vincent Guittot wrote: > On 28 May 2014 14:10, Morten Rasmussen wrote: > > On Fri, May 23, 2014 at 04:53:02PM +0100, Vincent Guittot wrote: > >> Monitor the activity level of each group of each sched_domain level. The > >> activity is the amount of cpu_pow

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Mike Christie
On 05/28/2014 05:54 AM, Christoph Hellwig wrote: > be2iscsi: Fix processing cqe for cxn whose endpoint is freed I didn't look at your tree, but when this patch was posted on the list I think it had a bug. http://www.spinics.net/lists/linux-scsi/msg74191.html -- To unsubscribe from this list

Re: [stable-3.10.y] possible unsafe locking warning

2014-05-28 Thread Tejun Heo
(cc'ing Johannes for mm-foo) Hello, On Wed, May 28, 2014 at 06:06:34PM +0800, Gu Zheng wrote: > [ 2457.683370] inconsistent {RECLAIM_FS-ON-W} -> {IN-RECLAIM_FS-R} usage. > [ 2457.761540] kswapd2/1151 [HC0[0]:SC0[0]:HE1:SE1] takes: > [ 2457.824102] (&sig->group_rwsem){+?}, at: [] > exit_sign

Re: [PATCH] bio: decrease bi_iter.bi_size by len in the fail path

2014-05-28 Thread Maurizio Lombardi
Hi, thanks for the patch On Wed, May 28, 2014 at 05:09:38PM +0200, Dongsu Park wrote: > From: Dongsu Park > > Commit 3979ef4dcf3d1de55a560a3a4016c30a835df44d ("bio-modify- > __bio_add_page-to-accept-pages-that-dont-start-a-new-segment-v3") > introduced a regression as reported by Jet Chen. > Th

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Christoph Hellwig
On Wed, May 28, 2014 at 10:37:31AM -0500, Mike Christie wrote: > On 05/28/2014 05:54 AM, Christoph Hellwig wrote: > > be2iscsi: Fix processing cqe for cxn whose endpoint is freed > > I didn't look at your tree, but when this patch was posted on the list I > think it had a bug. > > http://ww

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-28 Thread Suman Anna
On 05/27/2014 11:20 PM, Jassi Brar wrote: > On Wed, May 21, 2014 at 10:57 PM, Mark Brown wrote: >> On Thu, May 15, 2014 at 11:41:00AM +0530, Jassi Brar wrote: >>> Introduce common framework for client/protocol drivers and >>> controller drivers of Inter-Processor-Communication (IPC). >> >> This lo

Re: [PATCH 1/2] ALSA: au1x00: Use resource_size instead of computation

2014-05-28 Thread Takashi Iwai
At Wed, 28 May 2014 17:14:06 +0200, Benoit Taine wrote: > > This issue was reported by coccicheck using the semantic patch > at scripts/coccinelle/api/resource_size.cocci > > Signed-off-by: Benoit Taine Applied, thanks. Takashi > --- > Not compile tested, due incompatible architecture. > >

Re: [PATCH 03/17] phy: ti-pipe3: add external clock support for PCIe PHY

2014-05-28 Thread Nishanth Menon
On Tue, May 27, 2014 at 8:54 PM, Mike Turquette wrote: > Quoting Nishanth Menon (2014-05-15 05:33:13) >> On 05/15/2014 07:18 AM, Kishon Vijay Abraham I wrote: >> > Hi, >> > >> > On Thursday 15 May 2014 05:42 PM, Nishanth Menon wrote: >> >> On Thu, May 15, 2014 at 6:59 AM, Kishon Vijay Abraham I

Re: [PATCH] bio: decrease bi_iter.bi_size by len in the fail path

2014-05-28 Thread Ming Lei
Hi Dongsu, On Wed, May 28, 2014 at 11:09 PM, Dongsu Park wrote: > From: Dongsu Park > > Commit 3979ef4dcf3d1de55a560a3a4016c30a835df44d ("bio-modify- > __bio_add_page-to-accept-pages-that-dont-start-a-new-segment-v3") > introduced a regression as reported by Jet Chen. > That results in a kernel

Re: perf_fuzzer crash on pentium 4

2014-05-28 Thread Cyrill Gorcunov
On Wed, May 28, 2014 at 05:20:11PM +0200, Peter Zijlstra wrote: > > > > > > Pentium 4 's were not 64bit, were they? > > > > Not all, but there were 64bit varians (Xeons iirc). > > http://en.wikipedia.org/wiki/Pentium_d > > consumer netburst chip with x86_64. Yeah, thanks. -- To unsubscribe fro

Re: [RFC 2/2] x86_64: expand kernel stack to 16K

2014-05-28 Thread Richard Weinberger
On Wed, May 28, 2014 at 8:53 AM, Minchan Kim wrote: > While I play inhouse patches with much memory pressure on qemu-kvm, > 3.14 kernel was randomly crashed. The reason was kernel stack overflow. > > When I investigated the problem, the callstack was a little bit deeper > by involve with reclaim f

Re: [PATCH] scsi/NCR5380: dprintk macro

2014-05-28 Thread Christoph Hellwig
On Thu, May 29, 2014 at 12:43:43AM +1000, Finn Thain wrote: > > This is the delta between the two submissions: > [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure > and > [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure > > The macro definition chan

Re: [PATCH v2 0/4] memcg: Low-limit reclaim

2014-05-28 Thread Michal Hocko
On Wed 28-05-14 11:28:54, Johannes Weiner wrote: > On Wed, May 28, 2014 at 04:21:44PM +0200, Michal Hocko wrote: > > On Wed 28-05-14 09:49:05, Johannes Weiner wrote: > > > On Wed, May 28, 2014 at 02:10:23PM +0200, Michal Hocko wrote: [...] > > > > My main motivation for the weaker model is that it

Re: [PATCH v5 2/2] arm64: enable context tracking

2014-05-28 Thread Kevin Hilman
Hi Will, Will Deacon writes: > On Mon, May 26, 2014 at 07:56:13PM +0100, Larry Bassel wrote: >> Make calls to ct_user_enter when the kernel is exited >> and ct_user_exit when the kernel is entered (in el0_da, >> el0_ia, el0_svc, el0_irq and all of the "error" paths). >> >> These macros expand t

Re: [PATCH] misc: atmel_pwm: only build for supported platforms

2014-05-28 Thread Alexandre Belloni
+ depends on AVR32 || AT91SAM9263 || AT91SAM9RL || AT91SAM9G45 > > Symbols AT91SAM9263, AT91SAM9RL, and AT91SAM9G45 do not seem to exist in > next-20140528. Should these perhaps be SOC_AT91SAM9263, SOC_AT91SAM9RL, > and SOC_AT91SAM9G45 and/or ARCH_AT91SAM9263, ARCH_AT91SAM9RL, and > ARCH

Re: [RFC PATCH 2/5] clk: Introduce 'clk_round_rate_nearest()'

2014-05-28 Thread Rafael J. Wysocki
On Tuesday, May 27, 2014 07:05:31 PM Mike Turquette wrote: > Quoting Rafael J. Wysocki (2014-05-26 04:22:32) > > On Monday, May 26, 2014 11:59:09 AM Viresh Kumar wrote: > > > On 23 May 2014 21:44, Sören Brinkmann wrote: > > > > Viresh: Could you imagine something similar for cpufreq? You suggested

Re: [PATCH] export efi.flags to sysfs

2014-05-28 Thread Alex Thorlton
On Wed, May 28, 2014 at 05:47:12PM +0800, Dave Young wrote: > Add Alex to cc > > > > The 1:1 mapping was required to make kexec + EFI work in the first > > > instance. If a machine implements the EFI 1:1 mapping, kexec should > > > work. If it doesn't implement the 1:1 mapping, then it's probably

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Sujit Reddy Thumma
On 5/28/2014 4:24 PM, Christoph Hellwig wrote: I've pushed the following changes to the drivers-for-3.16 tree. I've there's anyting matching the rules that I did forget please resend and/or ping me. Benoit Taine (2): qla4x

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-28 Thread Bjorn Helgaas
On Fri, May 23, 2014 at 6:31 PM, Suravee Suthikulanit wrote: > On 5/22/2014 9:54 PM, Bjorn Helgaas wrote: >> >> I've been poking around for recent dmesg logs that contain "PCI: Using >> configuration type 1 for extended access", and there are quite a few. >> In most cases there*is* an MCFG table,

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Christoph Hellwig
On Wed, May 28, 2014 at 09:31:14PM +0530, Sujit Reddy Thumma wrote: > The above 4 patches are just posted to mailing lists with no > review/ack's yet. I believe it still went in because the sender has > modified the author name to himself and signed-off by is present by the > original author which

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Mike Christie
On 05/28/2014 10:50 AM, Christoph Hellwig wrote: > On Wed, May 28, 2014 at 10:37:31AM -0500, Mike Christie wrote: >> On 05/28/2014 05:54 AM, Christoph Hellwig wrote: >>> be2iscsi: Fix processing cqe for cxn whose endpoint is freed >> >> I didn't look at your tree, but when this patch was post

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Christoph Hellwig
On Wed, May 28, 2014 at 11:04:31AM -0500, Mike Christie wrote: > Did you see these patchsets: > > [PATCH 00/10] qla4xxx: 5.04.00-k5: Updates for scsi "misc" branch > and > [PATCH 0/6] qla4xxx: 5.04.00-k6: Updates for scsi "misc" branch > > ? I think they should be ok for your tree if you did not

Re: [RFC 2/2] x86_64: expand kernel stack to 16K

2014-05-28 Thread Johannes Weiner
On Wed, May 28, 2014 at 07:13:45PM +1000, Dave Chinner wrote: > On Wed, May 28, 2014 at 06:37:38PM +1000, Dave Chinner wrote: > > [ cc XFS list ] > > [and now there is a complete copy on the XFs list, I'll add my 2c] > > > On Wed, May 28, 2014 at 03:53:59PM +0900, Minchan Kim wrote: > > > While I

Re: [PATCH 00/13] overlay filesystem v22

2014-05-28 Thread Miklos Szeredi
On Mon, May 26, 2014 at 10:56:42AM +0900, J. R. Okajima wrote: > > Here are some comments. Thanks for the review. > > - I have no objection about the 0:0 char-dev whiteout, but you don't > have to have the inode for each whiteout. The hardlink is better. > In this version, you have now. H

RE: Performance regression in v3.14

2014-05-28 Thread Doug Smythies
On 2014.05.27 01:40 Yuyang Du wrote: >> On 2014.05.27 01:00, Johan Hovold wrote: >> I tried applying your (rejected) patch "intel_pstate: Remove C0 >> tracking" posted here: >> >> https://lkml.org/lkml/2014/5/8/574 >> >> to v3.14.4 and it fixes the problem as expected. >> >> So we have a c

Re: [RFC PATCH 0/2] Loop device psuedo filesystem

2014-05-28 Thread Andy Lutomirski
On Wed, May 28, 2014 at 12:32 AM, Seth Forshee wrote: > On Tue, May 27, 2014 at 03:19:15PM -0700, Andy Lutomirski wrote: >> On Tue, May 27, 2014 at 2:58 PM, Seth Forshee >> wrote: >> > I'm posting these patches in response to the ongoing discussion of loop >> > devices in containers at [1]. >> >

Re: [RFC 2/2] x86_64: expand kernel stack to 16K

2014-05-28 Thread Linus Torvalds
On Tue, May 27, 2014 at 11:53 PM, Minchan Kim wrote: > > So, my stupid idea is just let's expand stack size and keep an eye > toward stack consumption on each kernel functions via stacktrace of ftrace. We probably have to do this at some point, but that point is not -rc7. And quite frankly, from

Re: [RFC PATCH 6/7] perf, x86: large PEBS interrupt threshold

2014-05-28 Thread Andi Kleen
On Wed, May 28, 2014 at 05:35:48PM +0200, Peter Zijlstra wrote: > On Wed, May 28, 2014 at 07:58:31AM -0700, Andi Kleen wrote: > > > In particular, the 0x90 offset (IA32_PERF_GLOBAL_STATUS). Intel once > > > confirmed to me that that is a direct copy of the similarly named MSR at > > > the time of t

Re: [PATCH] misc: atmel_pwm: only build for supported platforms

2014-05-28 Thread Paul Bolle
|| ARCH_AT91 || COMPILE_TEST) > > > > + depends on HAVE_CLK > > > > + depends on AVR32 || AT91SAM9263 || AT91SAM9RL || AT91SAM9G45 > > > > Symbols AT91SAM9263, AT91SAM9RL, and AT91SAM9G45 do not seem to exist in > > next-20140528. Shoul

Re: [PATCH 1/1] watchdog: imx2: Added ioctl options to enable/disable watchdog as wanted by systemd.

2014-05-28 Thread Guenter Roeck
On Wed, May 28, 2014 at 04:59:56PM +0200, Tord Andersson wrote: > When the current imx2 watchdog driver is used with the systemd watchdog > feature, > we get "Failed to enable hardware watchdog: Inappropriate ioctl for device". > This is caused by missing ioctl setoptions to enable the watchdog. >

Re: [RFC 2/2] x86_64: expand kernel stack to 16K

2014-05-28 Thread Richard Weinberger
Am 28.05.2014 18:08, schrieb Steven Rostedt: > On Wed, 28 May 2014 17:43:50 +0200 > Richard Weinberger wrote: > > >>> diff --git a/arch/x86/include/asm/page_64_types.h >>> b/arch/x86/include/asm/page_64_types.h >>> index 8de6d9cf3b95..678205195ae1 100644 >>> --- a/arch/x86/include/asm/page_64_t

Re: [RFC 2/2] x86_64: expand kernel stack to 16K

2014-05-28 Thread Linus Torvalds
On Wed, May 28, 2014 at 9:08 AM, Steven Rostedt wrote: > > What performance impact are you looking for? Now if the system is short > on memory, it would probably cause issues in creating tasks. It doesn't necessarily need to be short on memory, it could just be fragmented. But a page order of 2 s

Re: [RFC 2/2] x86_64: expand kernel stack to 16K

2014-05-28 Thread Steven Rostedt
On Wed, 28 May 2014 17:43:50 +0200 Richard Weinberger wrote: > > diff --git a/arch/x86/include/asm/page_64_types.h > > b/arch/x86/include/asm/page_64_types.h > > index 8de6d9cf3b95..678205195ae1 100644 > > --- a/arch/x86/include/asm/page_64_types.h > > +++ b/arch/x86/include/asm/page_64_types.h

[PATCH] blk-mq: remove alloc_hctx and free_hctx methods

2014-05-28 Thread Christoph Hellwig
There is no need for drivers to control hardware context allocation now that we do the context to node mapping in common code. Signed-off-by: Christoph Hellwig --- block/blk-mq.c| 26 +- drivers/block/mtip32xx/mtip32xx.c |2 -- drivers/block/null

Re: [PATCH v2 0/4] memcg: Low-limit reclaim

2014-05-28 Thread Greg Thelen
On Wed, May 28 2014, Johannes Weiner wrote: > On Wed, May 28, 2014 at 04:21:44PM +0200, Michal Hocko wrote: >> On Wed 28-05-14 09:49:05, Johannes Weiner wrote: >> > On Wed, May 28, 2014 at 02:10:23PM +0200, Michal Hocko wrote: >> > > Hi Andrew, Johannes, >> > > >> > > On Mon 28-04-14 14:26:41,

Re: [PATCH 2/2] lpc_eth: Use resource_size instead of computation

2014-05-28 Thread Joe Perches
On Wed, 2014-05-28 at 17:14 +0200, Benoit Taine wrote: > This issue was reported by coccicheck using the semantic patch > at scripts/coccinelle/api/resource_size.cocci Slightly associated trivial note: > diff --git a/drivers/net/ethernet/nxp/lpc_eth.c > b/drivers/net/ethernet/nxp/lpc_eth.c [] >

Re: [PATCH] dt: bindings: dwc2: fix required value for the phy-names property

2014-05-28 Thread Rob Herring
On Thu, Apr 24, 2014 at 12:12 PM, Matt Porter wrote: > "7408484 usb: gadget: s3c-hsotg: enable generic phy support" introduces > generic phy support to the dwc2.txt binding and the s3c-hsotg driver > which implements support for the binding. The binding documentation > incorrectly states that the

Re: [PATCH] mfd: fix unintentional NULL check in menelaus_set_voltage()

2014-05-28 Thread Emil Goode
Hello, On Wed, May 28, 2014 at 04:20:11PM +0100, Lee Jones wrote: > On Wed, 28 May 2014, Emil Goode wrote: > > > The struct menelaus_vtg pointer vtg cannot be NULL here > > so the condition is never true and if it ever was true > > it would lead to a NULL pointer dereference when we goto > > labe

<    1   2   3   4   5   6   7   8   9   10   >