Re: [RFC][PATCH 0/7] sched: balance callbacks

2015-06-01 Thread Peter Zijlstra
On Mon, Jun 01, 2015 at 03:58:18PM +0200, Peter Zijlstra wrote: Hi, Mike stumbled over a cute bug where the RT/DL balancing ops caused a bug. The exact scenario is __sched_setscheduler() changing a (runnable) task from FIFO to OTHER. In swiched_from_rt(), where we do pull_rt_task() we

Re: [PATCH 11/11] x86: perf_event_intel_pt.c: use arch_initcall to hook in enabling

2015-06-01 Thread Paul Gortmaker
On 15-06-01 03:05 AM, Peter Zijlstra wrote: On Sun, May 31, 2015 at 08:54:12PM -0400, Paul Gortmaker wrote: This was using module_init, but there is no way this code can be modular. Same thing; you could actually make this modular if you wanted to. ..and this file is even in the same

Re: [PATCH 02/11] perf, tools, report: Add flag for non ANY branch mode

2015-06-01 Thread Jiri Olsa
On Wed, May 27, 2015 at 10:51:45AM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Later patches need to cheaply check that the branch mode is in ANY. Add a new function to check all event attrs and add a flag to the report state, which is then initialized. v2: Rename flag

Re: [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-06-01 Thread Peter Zijlstra
On Mon, 2015-06-01 at 10:11 -0400, Paul Gortmaker wrote: On 15-06-01 03:04 AM, Peter Zijlstra wrote: On Sun, May 31, 2015 at 08:54:11PM -0400, Paul Gortmaker wrote: This was using module_init, but there is no way this code can be modular. No, I think you could actually make it

[RFC][PATCH 5/7] sched,rt: Convert switched_{from,to}_rt() / prio_changed_rt() to balance callbacks

2015-06-01 Thread Peter Zijlstra
Remove the direct {push,pull} balancing operations from switched_{from,to}_rt() / prio_changed_rt() and use the balance callback queue. Again, err on the side of too many reschedules; since too few is a hard bug while too many is just annoying. Signed-off-by: Peter Zijlstra (Intel)

Re: [PATCH 3/6] xhci: probe phy before add usb_hcd

2015-06-01 Thread Yingjoe Chen
On Wed, 2015-05-27 at 07:18 -0500, Felipe Balbi wrote: On Wed, May 27, 2015 at 07:48:00PM +0800, chunfeng@mediatek.com wrote: From: Chunfeng Yun chunfeng@mediatek.com find the phy driver before add primary usb_hcd to avoid acessing xHCI register which may hangup the system when

MIPS/IRQCHIP: some remainders of IRQ_CPU

2015-06-01 Thread Valentin Rothberg
Hi Ralf, your commit 1f1786e60b53 (MIPS/IRQCHIP: Move irq_chip from arch/mips to drivers/irqchip.) is in today's linux-next tree (i.e., next-20150601). It renames the Kconfig option IRQ_CPU to IRQ_MIPS_CPU, but misses to rename a few Kconfig selects (see git grep) in arch/mips. If you agree, I

Re: [PATCH V4 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller.

2015-06-01 Thread Graham Moore
On 05/20/2015 05:26 PM, Brian Norris wrote: On Mon, Mar 23, 2015 at 08:36:22AM -0500, Graham Moore wrote: ... I'm fixing the sparse, smatch, unused variables, etc. ... + if (n_tx opcode == SPINOR_OP_WD_EVCR + !(txbuf[0] EVCR_QUAD_EN_MICRON)) { + struct

Can ovl_drop_write() be called earlier in ovl_dentry_open()

2015-06-01 Thread David Howells
In ovl_dentry_open(), ovl_drop_write() is called after vfs_open() - but is this actually necessary? Can't we just drop it post-copyup? After all, that's all we wanted the write lock for, right? David --- --- a/fs/overlayfs/inode.c +++ b/fs/overlayfs/inode.c @@ -356,16 +356,14 @@ static int

[RFC][PATCH 1/7] sched: Replace post_schedule with a balance callback list

2015-06-01 Thread Peter Zijlstra
Generalize the post_schedule() stuff into a balance callback list. This allows us to more easily use it outside of schedule() and cross sched_class. Signed-off-by: Peter Zijlstra (Intel) pet...@infradead.org --- kernel/sched/core.c | 36

[RFC][PATCH 2/7] sched: Use replace normalize_task() with __sched_setscheduler()

2015-06-01 Thread Peter Zijlstra
Reduce duplicate logic; normalize_task() is a simplified version of __sched_setscheduler(). Parametrize the difference and collapse. This reduces the amount of check_class_changed() sites. Signed-off-by: Peter Zijlstra (Intel) pet...@infradead.org --- kernel/sched/core.c | 65

[RFC][PATCH 6/7] sched,dl: Remove return value from pull_dl_task()

2015-06-01 Thread Peter Zijlstra
In order to be able to use pull_dl_task() from a callback, we need to do away with the return value. Since the return value indicates if we should reschedule, do this inside the function. Since not all callers currently do this, this can increase the number of reschedules due rt balancing. Too

[RFC][PATCH 0/7] sched: balance callbacks

2015-06-01 Thread Peter Zijlstra
Hi, Mike stumbled over a cute bug where the RT/DL balancing ops caused a bug. The exact scenario is __sched_setscheduler() changing a (runnable) task from FIFO to OTHER. In swiched_from_rt(), where we do pull_rt_task() we temporarity drop rq-lock. This gap allows regular cfs load-balancing to

[RFC][PATCH 7/7] sched,dl: Convert switched_{from,to}_dl() / prio_changed_dl() to balance callbacks

2015-06-01 Thread Peter Zijlstra
Remove the direct {push,pull} balancing operations from switched_{from,to}_dl() / prio_changed_dl() and use the balance callback queue. Again, err on the side of too many reschedules; since too few is a hard bug while too many is just annoying. Signed-off-by: Peter Zijlstra (Intel)

[RFC][PATCH 4/7] sched,rt: Remove return value from pull_rt_task()

2015-06-01 Thread Peter Zijlstra
In order to be able to use pull_rt_task() from a callback, we need to do away with the return value. Since the return value indicates if we should reschedule, do this inside the function. Since not all callers currently do this, this can increase the number of reschedules due rt balancing. Too

Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

2015-06-01 Thread Jacek Anaszewski
On 06/01/2015 01:56 PM, Stas Sergeev wrote: 01.06.2015 11:31, Jacek Anaszewski пишет: With this approach, the LED will remain in its current blink state, in case LED_BRIGHTNESS_FAST flag is not set and delay to be set is below LED_SLOW_MIN_PERIOD. This is because timer is deleted at the

Re: [PATCH 04/11] perf, tools, report: Add infrastructure for a cycles histogram

2015-06-01 Thread Jiri Olsa
On Wed, May 27, 2015 at 10:51:47AM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com This adds the basic infrastructure to keep track of cycle counts per basic block for annotate. We allocate an array similar to the normal accounting, and then account branch cycles there. We

Re: [PATCH v2 3/4] arch: introduce memremap()

2015-06-01 Thread Arnd Bergmann
On Saturday 30 May 2015 14:39:48 Dan Williams wrote: On Sat, May 30, 2015 at 2:00 PM, Arnd Bergmann a...@arndb.de wrote: On Saturday 30 May 2015, Dan Williams wrote: +/* + * memremap() is ioremap for cases where it is known that the resource + * being mapped does not have i/o side

Re: linux-next: build failure after merge of the edac-amd tree

2015-06-01 Thread Arnd Bergmann
On Monday 01 June 2015 11:51:27 Borislav Petkov wrote: On Mon, Jun 01, 2015 at 05:07:42PM +1000, Stephen Rothwell wrote: Hi Borislav, After merging the edac-amd tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/edac/xgene_edac.c: In function

Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

2015-06-01 Thread Stas Sergeev
01.06.2015 17:19, Jacek Anaszewski пишет: In fact, the things are more complicated: some drivers do small udelay()'s but do not use a work-queue. I was not marking them as FAST, although perhaps they could still be marked as SYNC? This could be handled by adding a property to struct

[PATCH] libceph: use kvfree() in ceph_put_page_vector()

2015-06-01 Thread Geliang Tang
Use kvfree() instead of open-coding it. Signed-off-by: Geliang Tang geliangt...@163.com --- net/ceph/pagevec.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c index 096d914..d4f5f22 100644 --- a/net/ceph/pagevec.c +++

[PATCH v3 0/8] mfd: introduce a driver for LPSS devices on SPT

2015-06-01 Thread Andy Shevchenko
The new coming Intel platforms such as Skylake will contain Sunrisepoint PCH. The driver is based on MFD framework since the main device, i.e. serial bus controller, contains register space for itself, DMA part, and an additional address space (convergence layer). The public specification of

Re: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure

2015-06-01 Thread Linus Walleij
On Tue, May 26, 2015 at 8:37 PM, Sören Brinkmann soren.brinkm...@xilinx.com wrote: On Tue, 2015-05-26 at 10:12AM +0200, Arnd Bergmann wrote: Could we add a pinctrl_register_reason() variant that returns a meaningful error code as ERR_PTR? I agree with Arnd. As long as we don't get a precise

Re: [PATCH] mmc: core: Fix off-by-one error in mmc_do_calc_max_discard()

2015-06-01 Thread David Jander
On Mon, 01 Jun 2015 15:38:51 +0300 Adrian Hunter adrian.hun...@intel.com wrote: On 01/06/15 15:30, David Jander wrote: On Mon, 01 Jun 2015 14:50:47 +0300 Adrian Hunter adrian.hun...@intel.com wrote: On 01/06/15 14:32, David Jander wrote: On Mon, 01 Jun 2015 13:36:45 +0300 Adrian

Future of Ozwpan Driver - Maintainer? [Was: Re: [PATCH 0/4] ozwpan: Four remote packet-of-death vulnerabilities]

2015-06-01 Thread Jason A. Donenfeld
Hi all, With four security critical bug patches having finally been put in Greg's for-linus branch [1][2][3][4], I'd like to turn attention back at the bigger issue. Where is the maintainer of this driver during these discussions? The MAINTAINERS file lists Shigekatsu Tateno, and in a commit [5]

[RFC][PATCH 3/7] sched: Allow balance callbacks for check_class_changed()

2015-06-01 Thread Peter Zijlstra
In order to remove dropping rq-lock from the switched_{to,from}()/prio_changed() sched_class methods, run the balance callbacks after it. We need to remove dropping rq-lock because its buggy, suppose using sched_setattr()/sched_setscheduler() to change a running task from FIFO to OTHER. By the

Re: Can ovl_drop_write() be called earlier in ovl_dentry_open()

2015-06-01 Thread Miklos Szeredi
On Mon, Jun 1, 2015 at 3:52 PM, David Howells dhowe...@redhat.com wrote: In ovl_dentry_open(), ovl_drop_write() is called after vfs_open() - but is this actually necessary? Can't we just drop it post-copyup? After all, that's all we wanted the write lock for, right? Hmm, that could result

Re: [PATCH] USB: serial: Use setup_timer

2015-06-01 Thread Johan Hovold
On Mon, Jun 01, 2015 at 06:41:57AM +0530, Vaishali Thakkar wrote: Use the timer API function setup_timer instead of structure field assignments to initialize a timer. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: @change@

[PATCH v3 6/8] mfd: make mfd_remove_devices() iterate in reverse order

2015-06-01 Thread Andy Shevchenko
The newly introduced device_for_each_child_reverse() would be used when MFD core removes the device. After this patch applied the devices will be removed in a reversed order. This behaviour is useful when devices have implicit dependency on order, i.e. consider MFD device with serial bus

[PATCH v3 1/8] PM / QoS: Make it possible to expose device latency tolerance to userspace

2015-06-01 Thread Andy Shevchenko
From: Mika Westerberg mika.westerb...@linux.intel.com Typically when a device is created the bus core it belongs to (for example PCI) does not know if the device supports things like latency tolerance. This is left to the driver that binds to the device in question. However, at that time the

Re: Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen on n900.

2015-06-01 Thread Maxime Ripard
On Mon, Jun 01, 2015 at 04:06:06PM +0200, Pavel Machek wrote: Hi! But that's not what I'm asking. See a changelog of 3eea8b5d68c801fec788b411582b803463834752 and compare it with what it actually does. It is buggy. If fuzz is specified but maximum is not, it overwites maximum

Re: [PATCH] ethtool: changes of emac_regs structure accordingly within driver emac_regs structure.

2015-06-01 Thread Ivan Mikhaylov
On Mon, 1 June 2015 12:57 +0400 Ben Hutchings b...@decadent.org.uk wrote: On Thu, 2015-05-21 at 19:09 +0400, Ivan Mikhaylov wrote: In ibm_emac.c in ethtool size of emac structure which passing through to driver is nailed down and not correlating with current emac_regs structure.

Re: [PATCH 25/98] sctp.h: use __u8 and __u32 from linux/types.h

2015-06-01 Thread Neil Horman
On Sat, May 30, 2015 at 05:38:17PM +0200, Mikko Rapeli wrote: Fixes userspace compilation errors like: linux/sctp.h:652:2: error: unknown type name ‘uint32_t’ Signed-off-by: Mikko Rapeli mikko.rap...@iki.fi --- include/uapi/linux/sctp.h | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH] gpio: add ETRAXFS GPIO driver

2015-06-01 Thread Linus Walleij
On Thu, May 21, 2015 at 8:48 PM, Rabin Vincent ra...@rab.in wrote: On Tue, May 19, 2015 at 11:39:01AM +0200, Linus Walleij wrote: Three cells is rather unusual, is it the best arrangement? Usually it's just offset+flags (your flags are ununsed I see). And then you could divide offset by num

Re: [PATCH 5/5] pcmcia: add a new resource manager for non ISA systems

2015-06-01 Thread Alan Cox
On Sat, 2015-05-30 at 16:40 +0200, Dominik Brodowski wrote: Alan, On Thu, Dec 04, 2014 at 09:31:22PM +, Alan Cox wrote: On a pure PCI platform we don't actually need all the complexity of the rsrc_nonstatic manager, in fact we can just work directly with the pci allocators and avoid

Re: Cycles annotation support for perf tools v2

2015-06-01 Thread Jiri Olsa
On Wed, May 27, 2015 at 10:51:43AM -0700, Andi Kleen wrote: [v2: Addressed review comments. Fixed display problems and correctly compute IPC now. See patches for detailed changes.] The upcoming Skylake CPU has a new timed branch stack feature, that reports cycle counts for individual

[PATCH] overlay: Call ovl_drop_write() earlier in ovl_dentry_open()

2015-06-01 Thread David Howells
Call ovl_drop_write() earlier in ovl_dentry_open() before we call vfs_open() as we've done the copy up for which we needed the freeze-write lock by that point. Signed-off-by: David Howells dhowe...@redhat.com --- fs/overlayfs/inode.c | 14 -- 1 file changed, 4 insertions(+), 10

Re: Cycles annotation support for perf tools v2

2015-06-01 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 01, 2015 at 04:21:36PM +0200, Jiri Olsa escreveu: On Wed, May 27, 2015 at 10:51:43AM -0700, Andi Kleen wrote: [v2: Addressed review comments. Fixed display problems and correctly compute IPC now. See patches for detailed changes.] The upcoming Skylake CPU has a new timed

Re: [RFC][PATCH 0/7] sched: balance callbacks

2015-06-01 Thread Mike Galbraith
On Mon, 2015-06-01 at 15:58 +0200, Peter Zijlstra wrote: This survives Mike's testcase for well over an hour on my ivb-ep. I've not yet tested it on anything bigger. I'll plug it into -rt, and beat it up. I don't have any dl toys though. -Mike -- To unsubscribe from this list: send

Re: Device Tree Blob (DTB) licence

2015-06-01 Thread One Thousand Gnomes
not true, with a proprietary bios it's a clear pay this much money and don't worry about it while with GPL there's a nagging fear that someone you never heard of may sue you a decade from now claiming you need to give them the source to your OS. Not really no - the number of companies

[PATCH] Documentation, intel_pstate: Add a better description of the intel_pstate legacy mode internal governors

2015-06-01 Thread Prarit Bhargava
This patchset was originally submitted and acked here http://marc.info/?l=linux-kernelm=140203008832333w=2 but lost at some point. P. 8 The current documentation is incomplete wrt the intel_pstate legacy internal governors. The confusion comes from the general cpufreq governors which

Re: [RFC v1 05/25] gpio: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc

2015-06-01 Thread Jiang Liu
On 2015/6/1 20:45, Linus Walleij wrote: On Wed, May 20, 2015 at 11:59 AM, Jiang Liu jiang@linux.intel.com wrote: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc while we already have a pointer to corresponding irq_desc. Signed-off-by: Jiang Liu jiang@linux.intel.com

Re: [PATCH trivial] pinctrl: Spelling s/reseved/reserved/

2015-06-01 Thread Linus Walleij
On Thu, May 21, 2015 at 2:05 PM, Geert Uytterhoeven geert+rene...@glider.be wrote: Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

[PATCH 2/2] checkkconfigsymbols.py: colored output

2015-06-01 Thread Valentin Rothberg
Color output to make it more readable. Symbols will be printed yellow, relevant commits (see --find) red. Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com Acked-by: Stefan Hengelein stefan.hengel...@fau.de Acked-by: Andreas Ruprecht andreas.rupre...@fau.de ---

[PATCH 1/2] checkkconfigsymbols.py: find relevant commits

2015-06-01 Thread Valentin Rothberg
Add option -f/--find to find relevant commits when using the --diff option. --find is useful in case a user wants to check commits that potentially cause a Kconfig symbol to be missing. This is done via 'git log -G $SYMBOL' (i.e., to get a list of commits that change $SYMBOL). The relevant

Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen on n900.

2015-06-01 Thread Pavel Machek
Hi! But that's not what I'm asking. See a changelog of 3eea8b5d68c801fec788b411582b803463834752 and compare it with what it actually does. It is buggy. If fuzz is specified but maximum is not, it overwites maximum with zero. If maximum is not set, you'll have other issues anyway.

Re: [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-06-01 Thread Paul Gortmaker
On 15-06-01 03:04 AM, Peter Zijlstra wrote: On Sun, May 31, 2015 at 08:54:11PM -0400, Paul Gortmaker wrote: This was using module_init, but there is no way this code can be modular. No, I think you could actually make it modular if you really wanted to. By really wanted to -- do you mean

[PATCHv2] frontswap: allow multiple backends

2015-06-01 Thread Dan Streetman
Change frontswap single pointer to a singly linked list of frontswap implementations. Update Xen tmem implementation as register no longer returns anything. Frontswap only keeps track of a single implementation; any implementation that registers second (or later) will replace the previously

Re: [PATCH v2 2/4] devm: fix ioremap_cache() usage

2015-06-01 Thread Arnd Bergmann
On Saturday 30 May 2015 14:16:28 Dan Williams wrote: On Sat, May 30, 2015 at 1:52 PM, Arnd Bergmann a...@arndb.de wrote: On Saturday 30 May 2015, Dan Williams wrote: @@ -154,7 +148,7 @@ void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res) } if

Re: [PATCH 1/1] USB-SERIAL : Changing usb_serial_generic_open prototype

2015-06-01 Thread Johan Hovold
On Sat, May 30, 2015 at 06:47:20PM +0530, Abhishek Bist wrote: While designing a usb to uart converter driver open function I am using usb_serial_generic_open, but wouldn't find need to pass tty as an argument. As it is not performing any task for further significance. So, This patch

Re: linux-next: manual merge of the block tree with Linus' tree

2015-06-01 Thread Mike Snitzer
On Mon, Jun 01 2015 at 12:56am -0400, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Jens, Today's linux-next merge of the block tree got a conflict in drivers/md/dm.c between commits 3a1407559a59 (dm: fix NULL pointer when clone_and_map_rq returns !DM_MAPIO_REMAPPED) and e5d8de32cc02

[PATCH v3 3/8] Driver core: wakeup the parent device before trying probe

2015-06-01 Thread Andy Shevchenko
From: Heikki Krogerus heikki.kroge...@linux.intel.com If the parent is still suspended when driver probe is attempted, the result may be failure. For example, if the parent is a PCI MFD device that has been suspended when we try to probe our device, any register reads will return 0x. To

[PATCH v3 2/8] ACPI / PM: Attach ACPI power domain only once

2015-06-01 Thread Andy Shevchenko
From: Mika Westerberg mika.westerb...@linux.intel.com Some devices, like MFD subdevices, share a single ACPI companion device so that they are able to access their resources and children. However, currently all these subdevices are attached to the ACPI power domain and this might cause that the

[PATCH v3 8/8] mfd: Add support for Intel Sunrisepoint LPSS devices

2015-06-01 Thread Andy Shevchenko
The new coming Intel platforms such as Skylake will contain Sunrisepoint PCH. The main difference to the previous platforms is that the LPSS devices are compound devices where usually main (SPI, HSUART, or I2C) and DMA IPs are present. This patch brings the driver for such devices found on

Re: [PATCH] Input: stmpe-ts - enforce device tree only mode

2015-06-01 Thread Linus Walleij
On Sat, May 23, 2015 at 12:58 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: The STMPE MFD is only used with device tree configured systems (and STMPE MFD core depends on OF), so force the configuration to come from device tree only. Signed-off-by: Dmitry Torokhov

Re: Device Tree Blob (DTB) licence

2015-06-01 Thread One Thousand Gnomes
facts in a dts file. The GPL’d files aren’t stopping anybody from creating proprietary software. People that really care will rewrite the files from scratch anyway. People that don’t care.. well, one need look no further than the difficulty of getting source code to different SoC support

[PATCH] staging: wlan-ng: fix long line

2015-06-01 Thread Douglas Barbonaglia Sathler Figueiredo
Style (line over 80 chars) in drivers/staging/wlan-ng/prism2fw.c Signed-off-by: Douglas Barbonaglia Sathler Figueiredo eng.douglasfigueir...@gmail.com --- drivers/staging/wlan-ng/prism2fw.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 5/6] phy: twl4030-usb: add support for reading resistor on ID pin.

2015-06-01 Thread Kishon Vijay Abraham I
Hi, On Thursday 16 April 2015 01:33 PM, NeilBrown wrote: From: NeilBrown ne...@suse.de The twl4030 phy can measure, with low precision, the resistance-to-ground of the ID pin. Add a function to read the value, and export the result via sysfs. Little sceptical about adding new sysfs entries.

Re: [PATCH] pinctrl: remove useless const qualifier

2015-06-01 Thread Linus Walleij
On Fri, May 22, 2015 at 8:19 AM, Masahiro Yamada yamada.masah...@socionext.com wrote: This const claims the get_function_groups callback never changes the given num_groups pointer. It is always true in C language, so not worth mentioning. Signed-off-by: Masahiro Yamada

Re: [Patch v3 11/36] sh, irq: Use helper irq_data_get_irq_handler_data() to hide irq_desc details

2015-06-01 Thread Jiang Liu
On 2015/6/1 19:38, Sergei Shtylyov wrote: Hello. On 6/1/2015 11:05 AM, Jiang Liu wrote: Use helper function irq_data_get_irq_handler_data() to hide irq_desc implementation details. I'm only seeing calls to irq_{get|set}_handler_data() below... Hi Sergei, Thanks for review, I

Re: [PATCH][V2] usb: isp1760: fix null dereference if kzalloc returns null

2015-06-01 Thread Sergei Shtylyov
Hello. On 6/1/2015 1:43 AM, Colin King wrote: From: Colin Ian King colin.k...@canonical.com If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer dereference on req. Check for null to avoid this. I told you there's no dereference and yet you're repeating it

Re: [PATCH] perf: introduce new two options for objdump.

2015-06-01 Thread Martin Liška
On 06/01/2015 02:54 PM, Arnaldo Carvalho de Melo wrote: Em Mon, Jun 01, 2015 at 01:10:06PM +0200, Martin Liška escreveu: On 05/20/2015 03:05 PM, Arnaldo Carvalho de Melo wrote: Em Wed, May 20, 2015 at 03:02:01PM +0200, Martin Liška escreveu: On 05/19/2015 04:33 PM, Arnaldo Carvalho de Melo

Re: A question about state machine function state_next()

2015-06-01 Thread Baoquan He
On 06/01/15 at 02:01pm, Joerg Roedel wrote: On Mon, Jun 01, 2015 at 07:18:02PM +0800, Baoquan He wrote: Checked the code again, it may be a code bug if this is done in device_dma_ops_init(). Since this is called in amd_iommu_init_dma_ops()-amd_iommu_init_dma(). And amd_iommu_init_dma() is

RE: [RESEND PATCH V4 1/3] input: misc: da9063: OnKey driver

2015-06-01 Thread Opensource [Steve Twiss]
On 27 May 2015 16:38, Steve Twiss wrote: On 19 May 2015 11:33, S Twiss wrote: To: Dmitry Torokhov Subject: [RESEND PATCH V4 1/3] input: misc: da9063: OnKey driver From: Steve Twiss stwiss.opensou...@diasemi.com Add OnKey driver support for DA9063 Signed-off-by: Steve Twiss

Re: [PATCH 05/11] perf, tools, report: Add processing for cycle histograms

2015-06-01 Thread Jiri Olsa
On Wed, May 27, 2015 at 10:51:48AM -0700, Andi Kleen wrote: SNIP +void hist__account_cycles(struct branch_stack *bs, struct addr_location *al, + struct perf_sample *sample, bool nonany_branch_mode) +{ + struct branch_info *bi; + + /* If we have branch cycles

Re: [PATCH] perf: introduce new two options for objdump.

2015-06-01 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 01, 2015 at 03:58:16PM +0200, Martin Liška escreveu: On 06/01/2015 02:54 PM, Arnaldo Carvalho de Melo wrote: Em Mon, Jun 01, 2015 at 01:10:06PM +0200, Martin Liška escreveu: On 05/20/2015 03:05 PM, Arnaldo Carvalho de Melo wrote: Em Wed, May 20, 2015 at 03:02:01PM +0200, Martin

[PATCH] checkpatch: Make the output better readable

2015-06-01 Thread Petr Mladek
I always have troubles to parse checkpatch.pl output when I check the whole patchset. It is hard to say which messages belongs to what patch. This patch does few small changes to make the output look better for me: + delimit each patch from each other with dashes and empty line + remove

Re: [PATCH 12/15] KVM: MTRR: introduce mtrr_for_each_mem_type

2015-06-01 Thread Paolo Bonzini
On 01/06/2015 11:33, Paolo Bonzini wrote: +looker-mem_type = looker-mtrr_state-fixed_ranges[index]; + looker-start = fixed_mtrr_range_end_addr(seg, index); + return true; in mtrr_lookup_fixed_start is the same as this: + end = fixed_mtrr_range_end_addr(looker-seg,

[PATCH v3 5/8] driver core: implement device_for_each_child_reverse()

2015-06-01 Thread Andy Shevchenko
The new function device_for_each_child_reverse() is helpful to traverse the registered devices in a reversed order, e.g. in the case when an operation on each device should be done first on the last added device, then on one before last and so on. Signed-off-by: Andy Shevchenko

[PATCH v3 7/8] dmaengine: add a driver for Intel integrated DMA 64-bit

2015-06-01 Thread Andy Shevchenko
Intel integrated DMA (iDMA) 64-bit is a specific IP that is used as a part of LPSS devices such as HSUART or SPI. The iDMA IP is attached for private usage on each host controller independently. While it has similarities with Synopsys DesignWare DMA, the following distinctions doesn't allow to

[PATCH v3 4/8] klist: implement klist_prev()

2015-06-01 Thread Andy Shevchenko
klist_prev() gets the previous element in the list. It is useful to traverse through the list in reverse order, for example, to provide LIFO (last in first out) variant of access. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Greg Kroah-Hartman

Re: [PATCH] perf/tool: remove newline char when reading event scale and unit

2015-06-01 Thread Arnaldo Carvalho de Melo
Em Sun, May 31, 2015 at 11:36:23AM +0530, Madhavan Srinivasan escreveu: commit fd979c013207 intruduced perf_event_sysfs_show function to display event_str value of an attr in kernel/event/core.c. But the function returns the value with a newline char. So, if a event also carries a event.unit

[PATCH 0/2] checkkconfigsymbols.py: find relevant commits

2015-06-01 Thread Valentin Rothberg
This patch series consists of two patches adding an option (--find) to find and display git commits that may cause a Kconfig symbol to be missing. This option is helpful when diffing two states of the tree (e.g. v4.0-v4.1-rc1) to get a set of relevant git commits without doing that manually

Re: [PATCH 08/11] perf, tools, report: Move branch option parsing to own file

2015-06-01 Thread Jiri Olsa
On Wed, May 27, 2015 at 10:51:51AM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com .. to allow sharing between builtin-record and builtin-top later. No code changes, just moved code. v2: Add header Signed-off-by: Andi Kleen a...@linux.intel.com Acked-by: Jiri Olsa

[PATCH] NTB: Register client drivers with name and owner

2015-06-01 Thread Allen Hubbe
Following the example of pci_register_driver, change ntb_register_client to be a macro, calling __ntb_register_client with THIS_MODULE and KBUILD_MODNAME to initialize the driver .owner and .name members. Signed-off-by: Allen Hubbe allen.hu...@emc.com --- drivers/ntb/ntb.c | 10

Re: [PATCH 2/2] kprobes/x86: Use 16 bytes for each instruction slot again

2015-06-01 Thread Andy Lutomirski
On Mon, Jun 1, 2015 at 9:32 AM, Eugene Shatokhin eugene.shatok...@rosalab.ru wrote: Commit 91e5ed49fca0 (x86/asm/decoder: Fix and enforce max instruction size in the insn decoder) has changed MAX_INSN_SIZE from 16 to 15 bytes on x86. As a side effect, the slots Kprobes use to store the

Re: [PATCH v10 12/12] drivers/block/pmem: Map NVDIMM with ioremap_wt()

2015-06-01 Thread Andy Lutomirski
On Mon, Jun 1, 2015 at 1:58 AM, Ingo Molnar mi...@kernel.org wrote: * Andy Lutomirski l...@amacapital.net wrote: You answered the wrong question. :) I understand the point of the non-temporal stores -- I don't understand the point of using non-temporal stores to *WB memory*. I think we

Re: [PATCH RFC v2 1/2] crypto: add PKE API

2015-06-01 Thread Tadeusz Struk
On 05/31/2015 10:48 PM, Herbert Xu wrote: On Thu, May 28, 2015 at 09:54:41AM -0700, Tadeusz Struk wrote: If we do this that way then we will be able to pass only one input and one output parameter. There are cases when we will need more that this. For instance for ECDSA signature generation

Re: [PATCH-v2 2/4] target: Drop lun_sep_lock for se_lun-lun_se_dev RCU usage

2015-06-01 Thread Paul E. McKenney
On Sat, May 30, 2015 at 10:24:41PM -0700, Nicholas A. Bellinger wrote: On Thu, 2015-05-28 at 08:57 -0700, Paul E. McKenney wrote: On Wed, May 27, 2015 at 11:02:10PM -0700, Nicholas A. Bellinger wrote: On Wed, 2015-05-27 at 14:04 -0700, Paul E. McKenney wrote: On Tue, May 26, 2015 at

Re: [PATCH 1/1] net: core: 'ethtool' issue with querying phy settings

2015-06-01 Thread Ben Hutchings
On Sun, 2015-05-31 at 17:19 -0700, David Miller wrote: From: Ben Hutchings b...@decadent.org.uk Date: Sun, 31 May 2015 20:54:06 +0100 On Fri, 2015-05-22 at 16:15 -0400, David Miller wrote: From: Arun Parameswaran apara...@broadcom.com Date: Wed, 20 May 2015 14:35:30 -0700 When

Re: [PATCH] ethtool: changes of emac_regs structure accordingly within driver emac_regs structure.

2015-06-01 Thread Ben Hutchings
On Mon, 2015-06-01 at 16:30 +0400, Ivan Mikhaylov wrote: On Mon, 1 June 2015 12:57 +0400 Ben Hutchings b...@decadent.org.uk wrote: On Thu, 2015-05-21 at 19:09 +0400, Ivan Mikhaylov wrote: In ibm_emac.c in ethtool size of emac structure which passing through to driver is nailed down and

Re: [GIT PULL] qcom SoC changes for 4.2-1

2015-06-01 Thread Arnd Bergmann
On Friday 29 May 2015 14:42:01 Arnd Bergmann wrote: On Thursday 28 May 2015 10:55:39 Kumar Gala wrote: Qualcomm ARM Based SoC Updates for v4.2-1 * Added Subsystem Power Manager (SPM) driver * Split out 32-bit specific SCM code * Added HDCP SCM call Pulled into next/drivers,

Re: [PATCH 2/4] x86/pat: Merge pat_init_cache_modes() into its caller

2015-06-01 Thread Toshi Kani
On Sun, 2015-05-31 at 12:23 +0200, Borislav Petkov wrote: On Sun, May 31, 2015 at 11:48:04AM +0200, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de This way we can pass pat MSR value directly. This breaks xen as that function is used there, doh. :-\ Jürgen, can you check

Re: [PATCH 1/1] x86 TSC: set X86_FEATURE_TSC_RELIABLE, per CPUID

2015-06-01 Thread Andy Lutomirski
On 05/30/2015 10:44 PM, Len Brown wrote: From: Len Brown len.br...@intel.com Speed cpu_up() by believing CPUID's invariant TSC flag, and skipping the TSC warp test on single socket systems. I'm typing this email on a Intel(R) Core(TM) i7-3930K CPU @ 3.20GHz with a X79A-GD65 (8D) (MS-7760)

Re: [RFC][PATCH 0/4] Fixes for leapsecond expiring early ABS_TIME CLOCK_REALTIME timers

2015-06-01 Thread John Stultz
On Mon, Jun 1, 2015 at 4:57 AM, Prarit Bhargava pra...@redhat.com wrote: On 05/29/2015 04:24 PM, John Stultz wrote: As Prarit reported here: https://lkml.org/lkml/2015/5/27/458 Since the leapsecond is applied at timer tick time, and not the actual second edge, ABS_TIME CLOCK_REALTIME

Re: [PATCH] staging: unisys: use schedule_timeout_interruptible()

2015-06-01 Thread Ben Romer
As the actually intended timeout is not documented and msecs_to_jiffies timeouts can be a factor 10 different from the current effective timeout this needs to be checked by someone who knows the details of this driver in any case it should be passed in a HZ independent manner. I need an ack

Re: [Patch V1 2/3] x86, mce: Add infrastructure required to support LMCE

2015-06-01 Thread Raj, Ashok
-- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 3/5] i2c: at91: add support for new alternative command mode

2015-06-01 Thread Alexandre Belloni
Hi, On 01/06/2015 at 17:49:13 +0200, Cyrille Pitchen wrote : @@ -504,8 +589,22 @@ static int at91_twi_xfer(struct i2c_adapter *adap, struct i2c_msg *msg, int num) at91_twi_write(dev, AT91_TWI_IADR, internal_address); } - at91_twi_write(dev, AT91_TWI_MMR,

Re: [PATCH v2 1/9] rcu: Panic if RCU tree can not accommodate all CPUs

2015-06-01 Thread Paul E. McKenney
On Fri, May 29, 2015 at 11:53:37AM +0200, Alexander Gordeev wrote: Currently a condition when RCU tree is unable to accommodate the configured number of CPUs is not permitted and causes a fall back to compile-time values. However, the code has no means to exceed the RCU tree capacity neither

Re: [PATCH] staging: rtl8188eu: Kill dead calls to kill_pid()

2015-06-01 Thread Larry Finger
On 05/31/2015 08:04 AM, Jakub Sitnicki wrote: There is no interface to register PIDs of processes the driver should send a signal to. Remove it. Signed-off-by: Jakub Sitnicki jsitni...@gmail.com --- drivers/staging/rtl8188eu/include/drv_types.h | 1 -

Re: [PATCH] drm/ttm: dma: Don't crash on memory in the vmalloc range

2015-06-01 Thread Konrad Rzeszutek Wilk
On Tue, May 19, 2015 at 08:33:59PM +0900, Alexandre Courbot wrote: On 05/16/2015 04:55 AM, Konrad Rzeszutek Wilk wrote: On Fri, May 15, 2015 at 04:09:54PM +0900, Alexandre Courbot wrote: dma_alloc_coherent() can return memory in the vmalloc range. virt_to_page() cannot handle such addresses

Re: [PATCH] fuse: avoid clobbering fc-release with fuse_conn_init(fc)

2015-06-01 Thread Jeremiah Mahler
Miklos, On Mon, Jun 01, 2015 at 02:03:02PM +0200, Miklos Szeredi wrote: On Mon, Jun 1, 2015 at 3:31 AM, Jeremiah Mahler jmmah...@gmail.com wrote: fuse_conn_init(fc) zeros the entire fc structure before it assigns specific values. Since fc-release is set before fuse_conn_init(fc) is

Re: [Patch v3] apple-gmux: lock iGP IO to protect from vgaarb changes

2015-06-01 Thread Darren Hart
On Mon, Jun 01, 2015 at 08:22:27AM +0200, Bruno Prémont wrote: On Fri, 29 May 2015 18:36:50 +0200 Darren Hart wrote: Making sure to lock only the intel GPU when present and especially protecting against nvidia driver will be hard if legacy-IO is being processed by a hidden

Re: [PATCH v6 2/3] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-06-01 Thread Eric Anholt
Paul Bolle pebo...@tiscali.nl writes: On Fri, 2015-05-29 at 12:42 -0700, Eric Anholt wrote: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. v6: Drop the try_module_get/module_put

Re: runtime check for omap-aes bus access permission (was: Re: 3.13-rc3 (commit 7ce93f3) breaks Nokia N900 DT boot)

2015-06-01 Thread Tony Lindgren
* Matthijs van Duin matthijsvand...@gmail.com [150530 08:24]: On 29 May 2015 at 17:50, Tony Lindgren t...@atomide.com wrote: I believe some TI kernels use strongly-ordered mappings, mainline kernel does not. Which kernel version are you using? Normally I periodically rebuild based on

Re: [PATCH v5] Fix the resolution issue in ChromeOS

2015-06-01 Thread Frans Klaver
On Tue, Jun 02, 2015 at 12:39:13AM +0800, Hn Chen wrote: Hi, Klaver, Sorry for replying late and thanks for your opinion ! About the patch descrition, I will follow your suggestion and Ok. More on this is in Documentation/SubmittingPatches. maybe add more commemts between codes to be

Re: [PATCH] checkpatch: Make the output better readable

2015-06-01 Thread Joe Perches
(adding back cc's) On Mon, 2015-06-01 at 11:14 -0700, Jim Davis wrote: On Mon, Jun 1, 2015 at 11:02 AM, Joe Perches j...@perches.com wrote: On Mon, 2015-06-01 at 16:25 +0200, Petr Mladek wrote: I always have troubles to parse checkpatch.pl output when I check the whole patchset. It is hard

[PATCH RESEND] rtc: snvs: fix wakealarm by call enable_irq_wake earlier

2015-06-01 Thread Stefan Agner
When entering suspend while an wakeup alarm is set, enable_set_wake should make sure that the RTC interrupt keep being enabled and the .irq_set_wake for the RTC interrupt get called. However, since the driver uses the suspend_noirq callback, the call to enable_irq_wake has been made after

Re: Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen on n900.

2015-06-01 Thread Dmitry Torokhov
On Mon, Jun 01, 2015 at 05:21:11PM +0200, Pavel Machek wrote: The 3eea8b5d68c801fec788b411582b803463834752 is just bad. You were very welcome to review this patch at the time and/or suggest a fix that pleases everyone. You should be the one that should suggest fixes,

Re: watchdog: st_wdt: select on undefined MFD_ST_LPC

2015-06-01 Thread Lee Jones
On Mon, 01 Jun 2015, Valentin Rothberg wrote: Hi Lee, your commit d0c9e350b9a4 (watchdog: st_wdt: Add new driver for ST's LPC Watchdog) is in today's linux-next tree (i.e., next-20150601) and adds the following lines of code to drivers/watchdog/Kconfig. +config ST_LPC_WATCHDOG

<    1   2   3   4   5   6   7   8   9   10   >