[PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

2015-10-03 Thread Chandra S Gorentla
- kfree is being called for the members of the queue without de-queuing them; they are just inserted within this function; they are supposed to be de-queued and freed in a function for receiving the queue items - goto statements are removed - After kfree correction, there is no need

Re: [PATCH v3 3/4] iio: bmc150: Split the driver into core and i2c

2015-10-03 Thread Jonathan Cameron
On 23/09/15 13:51, Tirdea, Irina wrote: > > >> -Original Message- >> From: Markus Pargmann [mailto:m...@pengutronix.de] >> Sent: 21 September, 2015 13:55 >> To: Jonathan Cameron >> Cc: Srinivas Pandruvada; Tirdea, Irina; Lars-Peter Clausen; >> linux-...@vger.kernel.org;

Re: [PATCH v3 2/4] iio: bcm150: Remove i2c_client from private data

2015-10-03 Thread Jonathan Cameron
On 23/09/15 13:47, Tirdea, Irina wrote: > > >> -Original Message- >> From: Markus Pargmann [mailto:m...@pengutronix.de] >> Sent: 21 September, 2015 13:55 >> To: Jonathan Cameron >> Cc: Srinivas Pandruvada; Tirdea, Irina; Lars-Peter Clausen; >> linux-...@vger.kernel.org;

Re: [PATCH v3 4/4] iio: bmc150: Add SPI driver

2015-10-03 Thread Jonathan Cameron
On 03/10/15 12:04, Jonathan Cameron wrote: > On 21/09/15 11:55, Markus Pargmann wrote: >> Add a simple SPI driver which initializes the spi regmap for the bmc150 >> core driver. >> >> Signed-off-by: Markus Pargmann > After applying this one to latest togreg I get: >

Re: [PATCH v4 01/26] ARM: pxa: magician: Fix indentation in machine files

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:09 +0200 schrieb Petr Cvek: > This patch fixes the indentation for the HTC Magician machine > definition. > > Signed-off-by: Petr Cvek Acked-by: Philipp Zabel I still think these are a lot of arbitrary changes, maybe the

Re: [PATCH v4 10/26] ARM: pxa: magician: Optimize Samsung LCD refresh to 50Hz

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:32 +0200 schrieb Petr Cvek: > Change the default Samsung LCD refresh from an unrealistic 117Hz to > 50Hz > as no video applications on the HTC Magician can work that fast. > > The optimalization lowers the RAM latency at least by 3%. > > Signed-off-by: Petr Cvek

Re: [PATCH v4 11/26] ARM: pxa: magician: Optimize EGPIO initial values

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:32 +0200 schrieb Petr Cvek: > This patch optimizes initial values of the EGPIO chip driver. > > GSM and sound should be powered off during boot. A weak accumulator > and > a powered GSM sometimes cause a system reboot. A charging current > should be > as high as

Re: [PATCH v4 18/26] ARM: pxa: magician: Add support for ADS7846

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek: > Add support for an ADS7846 touchscreen. It's actually a TSC2045. > Signed-off-by: Petr Cvek > --- > arch/arm/mach-pxa/magician.c | 86 > > 1 file changed, 86 insertions(+)

Re: [PATCH v4 19/26] ARM: pxa: magician: Add support for Omnivision OV9640 camera

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek: > This patch adds support for an OV9640 camera to the HTC Magician > machine. > > Signed-off-by: Petr Cvek Still untested, but looks good to me. regards Philipp -- To unsubscribe from this list: send the line

Re: 4.2.2: NR_CPUS effectively being 1 bug

2015-10-03 Thread Mike Galbraith
On Sat, 2015-10-03 at 14:31 +0200, Frederic Weisbecker wrote: > On Sat, Oct 03, 2015 at 02:04:44PM +0200, Mike Galbraith wrote: > > On Sat, 2015-10-03 at 10:52 +0200, Ingo Molnar wrote: > > > Ok, looks like a patch with good intentions but bad effects. Mind sending > > > a revert > > > patch,

[PATCH 3/24] ver_linux: gcc.patch

2015-10-03 Thread Alexander Kapshuk
Using 'awk' here is a bit of an overkill. Should the output of 'gcc -dumpversion' vary on another disto, or change overtime, it may no longer be available at field 1, as relied on by the current implementation. I believe 'sed' offers greater flexibility here in terms of processing varying output

[PATCH 5/24] ver_linux: binutils.patch

2015-10-03 Thread Alexander Kapshuk
Fix broken output. Current implementation output on Gentoo Linux: binutils 2.25.1 1.1 2.25.1 Proposed implementation: binutils2.25.1 Tested on: Gentoo Linux Debian 6.0.10 Oracle Linux Server release 7.1 Arch Linux openSuSE 13.2 Signed-off-by: Alexander Kapshuk

[PATCH v2 3/5] net: dsa: complete dsa_switch_destroy

2015-10-03 Thread Neil Armstrong
When unbinding dsa, complete the dsa_switch_destroy to unregister the fixed link phy then cleanly unregister and destroy the net devices. Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 36 1 file changed, 36 insertions(+) diff

Re: [PATCH 02/17] rtc: ab8500: remove misuse of IRQF_NO_SUSPEND flag

2015-10-03 Thread Alexandre Belloni
On 21/09/2015 at 16:46:58 +0100, Sudeep Holla wrote : > The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > be left enabled so as to allow them to work as expected during the > suspend-resume cycle, but doesn't guarantee that it will wake the system > from a suspended state,

Re: [PATCH 06/17] rtc: ds1343: remove misuse of IRQF_NO_SUSPEND flag

2015-10-03 Thread Alexandre Belloni
On 21/09/2015 at 16:47:02 +0100, Sudeep Holla wrote : > The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > be left enabled so as to allow them to work as expected during the > suspend-resume cycle, but doesn't guarantee that it will wake the system > from a suspended state,

Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-10-03 Thread Alexandre Belloni
On 21/09/2015 at 16:46:57 +0100, Sudeep Holla wrote : > The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > be left enabled so as to allow them to work as expected during the > suspend-resume cycle, but doesn't guarantee that it will wake the system > from a suspended state,

Re: [PATCH v2 1/5] net: dsa: add missing kfree on remove

2015-10-03 Thread Neil Armstrong
On 10/03/2015 04:33 PM, Sergei Shtylyov wrote: > Hello. > > On 10/3/2015 5:25 PM, Neil Armstrong wrote: > >> To prevent memory leakage on unbinding, add missing kfree calls. >> >> Signed-off-by: Neil Armstrong >> --- >> net/dsa/dsa.c | 5 - >> 1 file changed, 4

Re: [PATCH] staging: lustre: lustre: llite: Added a blank line

2015-10-03 Thread Drokin, Oleg
On Oct 3, 2015, at 7:39 AM, Anjali Menon wrote: > Added a blank line after declaration to fix the coding > style warning detected by checkpatch.pl > > WARNING: Missing a blank line after declarations > > Signed-off-by: Anjali Menon > --- >

Re: WARNING: CPU: 4 PID: 863 at include/drm/drm_crtc.h:1577 drm_helper_choose_encoder_dpms+0x88/0x90() - evildoer found and neutralized

2015-10-03 Thread Borislav Petkov
On Sat, Oct 03, 2015 at 03:36:35PM +0800, Jiang Liu wrote: > The above change is not needed, pcibios_disable_irq() will > first check !pci_has_managed_irq(dev) before actually freeing > PCI irq. pci_has_managed_irq(dev) only returns true if > pcibios_alloc_irq() succeeds. > > So to summary, I

Re: [PATCH v3 1/7] acpi: Add early device probing infrastructure

2015-10-03 Thread Marc Zyngier
On Fri, 2 Oct 2015 16:06:05 -0500 Wei Huang wrote: Hi Wei, > Hi Marc, [...] > > +struct acpi_probe_entry { > > + __u8 id[ACPI_TABLE_ID_LEN]; > > + __u8 type; > > + acpi_probe_entry_validate_subtbl subtable_valid; > > + union { > > + acpi_tbl_table_handler

Re: [PATCH v3 3/4] iio: bmc150: Split the driver into core and i2c

2015-10-03 Thread Jonathan Cameron
On 21/09/15 11:55, Markus Pargmann wrote: > Signed-off-by: Markus Pargmann You didn't have the pm_ops structure exported which gave: ERROR: "bmc150_accel_pm_ops" [drivers/iio/accel/bmc150-accel-i2c.ko] undefined! scripts/Makefile.modpost:90: recipe for target '__modpost'

Re: [PATCH v3 1/4] iio: bmc150: Use i2c regmap

2015-10-03 Thread Jonathan Cameron
On 23/09/15 13:47, Tirdea, Irina wrote: > > >> -Original Message- >> From: Markus Pargmann [mailto:m...@pengutronix.de] >> Sent: 21 September, 2015 13:55 >> To: Jonathan Cameron >> Cc: Srinivas Pandruvada; Tirdea, Irina; Lars-Peter Clausen; >> linux-...@vger.kernel.org;

Re: [PATCH v3 4/4] iio: bmc150: Add SPI driver

2015-10-03 Thread Jonathan Cameron
On 21/09/15 11:55, Markus Pargmann wrote: > Add a simple SPI driver which initializes the spi regmap for the bmc150 > core driver. > > Signed-off-by: Markus Pargmann After applying this one to latest togreg I get: drivers/iio/accel/bmc150-accel-spi.c:69:37: error: undefined

Re: [PATCH v4 06/26] ARM: pxa: magician: Add new discovered EGPIO pins

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:15 +0200 schrieb Petr Cvek: > This patch adds EGPIO pins: Infra transceiver power, NiCD charging > and > inserted charger cable. > > Signed-off-by: Petr Cvek Acked-by: Philipp Zabel Do you have more details how NiCD

Re: [PATCH v3 2/2] Added trickle charger device tree binding

2015-10-03 Thread Alexandre Belloni
On 18/09/2015 at 17:22:39 +0200, Ivan Grimaldi wrote : > Introduce a device tree binding for specifying the trickle charger > configuration for ds1339. > > Signed-off-by: Ivan Grimaldi > --- > .../devicetree/bindings/rtc/dallas,ds1390.txt | 18 +++ >

Re: [PATCH v4 26/26] ARM: pxa: magician: Move platform_add_devices() to the end of magician_init()

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:42 +0200 schrieb Petr Cvek: > This patch moves platform_add_devices() (standard declaration of > devices) > outside of the platform specific device declarations. Moving to the > end > of the magician_init() clarifies the source code (standard and > specific >

[PATCH 8/24] ver_linux: e2fsprogs.patch

2015-10-03 Thread Alexander Kapshuk
'tune2fs' is located in varying places depending on the distro. Current implementation output on distros where 'tune2fs' is found at a location that is not available in the PATH for the regular user, e.g. '/sbin', will have nothing to display. While running 'ver_linux' as user 'root' should be OK.

[PATCH 15/24] ver_linux: libc.patch

2015-10-03 Thread Alexander Kapshuk
The current implementation has been found not to work across all distros. The proposed implementation relies on 'sed' to both output the string 'Linux C Library' as well as to open '/proc/self/maps' without having to use output redirection. Tested on: Gentoo Linux Debian 6.0.10 Oracle Linux

[PATCH 12/15] kaweth: remove ifdefed out call to dma_supported

2015-10-03 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- drivers/net/usb/kaweth.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index 1e9cdca..f64b25c 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers/net/usb/kaweth.c @@ -1177,12 +1177,6

[PATCH 10/15] nouveau: don't call pci_dma_supported

2015-10-03 Thread Christoph Hellwig
Just try to set a 64-bit DMA mask first and retry with the smaller dma_mask if dma_set_mask failed. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH 11/15] sfc: don't call dma_supported

2015-10-03 Thread Christoph Hellwig
dma_set_mask already checks for a supported DMA mask before updating it, the call to dma_supported is redundant. Signed-off-by: Christoph Hellwig --- drivers/net/ethernet/sfc/efx.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH 08/15] netup_unidvb: use pci_set_dma_mask insted of pci_dma_supported

2015-10-03 Thread Christoph Hellwig
This ensures the dma mask that is supported by the driver is recorded in the device structure. Signed-off-by: Christoph Hellwig --- drivers/media/pci/netup_unidvb/netup_unidvb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] ALSA: hda: Add dock support for ThinkPad T550

2015-10-03 Thread Takashi Iwai
On Fri, 02 Oct 2015 20:09:54 +0200, Laura Abbott wrote: > > Much like all the other Lenovo laptops, add a quirk to make > sound work with docking. > > Reported-and-tested-by: lackner...@gmail.com > Signed-off-by: Laura Abbott Thanks, applied now (with Cc to stable).

Re: [PATCH] usb-host: Remove fusbh200 driver

2015-10-03 Thread Peter Senna Tschudin
On Fri, Oct 2, 2015 at 7:39 PM, Felipe Balbi wrote: > On Fri, Oct 02, 2015 at 01:18:27PM +0200, Peter Senna Tschudin wrote: >> fusbh200 and fotg210 are very similar. The initial idea was to consolidate >> both drivers but I'm afraid fusbh200 is not being used. >> >> This patch

Re: [Dell XPS 13 9343] Random kernel Oops at boot with "acpi=ht", disappearing with "acpi=off"

2015-10-03 Thread Niccolò Belli
On venerdì 2 ottobre 2015 12:19:19 CEST, Mika Westerberg wrote: On Fri, Oct 02, 2015 at 11:59:38AM +0200, Niccolò Belli wrote: Hi, This laptop suffers of random kernel hangs at boot: I tested kernel 4.1.8, 4.2.1 and 4.3-rc3 and they are all affected. Every time I turn on my laptop I have to

Re: [tpmdd-devel] [PATCH 4/4] keys, trusted: seal/unseal with TPM 2.0 chips

2015-10-03 Thread Jarkko Sakkinen
On Sat, Oct 03, 2015 at 10:00:59AM +, Fuchs, Andreas wrote: > Hi Jarkko, > > [snip] > > diff --git a/security/keys/trusted.h b/security/keys/trusted.h > index ff001a5..fc32c47 100644 > --- a/security/keys/trusted.h > +++ b/security/keys/trusted.h > @@ -12,6 +12,13 @@ > #define

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

2015-10-03 Thread Arthur Marsh
Jiang Liu wrote on 03/10/15 17:41: Hi Arthur, The above results suggest that we need to shutdown eata controller for kexec. So could you please try to apply the attached patch upon the previous two patches? Thanks! Gerry Hi, I still get kexec shutdown errors like this with the 3rd

Re: [PATCH v4 03/26] ARM: pxa: magician: Print more specific error message for global GPIOs

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:10 +0200 schrieb Petr Cvek: > Print more specific error message for global GPIOs. > > Signed-off-by: Petr Cvek Acked-by: Philipp Zabel > --- > arch/arm/mach-pxa/magician.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v4 04/26] ARM: pxa: magician: Optimize debug messages for LCD power

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:11 +0200 schrieb Petr Cvek: > Optimize the debug messages for the LCD power. > > Signed-off-by: Petr Cvek Acked-by: Philipp Zabel regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v4 05/26] ARM: pxa: magician: Change description of LCD power GPIO

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:11 +0200 schrieb Petr Cvek: > This patch changes the description of the LCD power GPIO to be more > specific. > > Signed-off-by: Petr Cvek Acked-by: Philipp Zabel regards Philipp -- To unsubscribe from this list: send

Re: 4.2.2: NR_CPUS effectively being 1 bug

2015-10-03 Thread Mike Galbraith
On Sat, 2015-10-03 at 15:14 +0300, Alexey Dobriyan wrote: > On Sat, Oct 03, 2015 at 10:15:48AM +0200, Mike Galbraith wrote: > > On Sat, 2015-10-03 at 09:38 +0200, Ingo Molnar wrote: > > > * Peter Zijlstra wrote: > > > > > > > On Fri, Oct 02, 2015 at 02:00:33PM -0700, Andrew

Re: [PATCH v4 08/26] ARM: pxa: magician: Rename abstract LCD GPIOs

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:15 +0200 schrieb Petr Cvek: > This patch renames GPIOs, which are used to control the power lines > to > the LCD screen. New names correspond to a real functionality, which > was > measured on the HTC Magician board_id 0x3a. > > Signed-off-by: Petr Cvek

Re: 4.2.2: NR_CPUS effectively being 1 bug

2015-10-03 Thread Frederic Weisbecker
On Sat, Oct 03, 2015 at 02:04:44PM +0200, Mike Galbraith wrote: > On Sat, 2015-10-03 at 10:52 +0200, Ingo Molnar wrote: > > Ok, looks like a patch with good intentions but bad effects. Mind sending a > > revert > > patch, changelogged, signed off? > > No. They know. The reason for this patch

Re: [PATCH v4 07/26] ARM: pxa: magician: Fix HTC Magician pin mux definitions

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:15 +0200 schrieb Petr Cvek: > This patch fixes a pin mux for the HTC Magician machine. Wrong and > missing > definitions caused a bad LCD operation and an unavailability of > several > peripherals. > > Signed-off-by: Petr Cvek NAK on this one.

Re: [PATCH v4 09/26] ARM: pxa: magician: Optimize powerup delays for Samsung LCD

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:16 +0200 schrieb Petr Cvek: > Delays for the Samsung LCD are greater than needed. These values were > extracted from a datasheet. > > Signed-off-by: Petr Cvek Acked-by: Philipp Zabel regards Philipp -- To unsubscribe

Re: [PATCH v4 25/26] ARM: pxa: magician: Add missing regulator for PWM backlight

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:40 +0200 schrieb Petr Cvek: > Add a fake regulator, which is required for the correct > initialization > of the PWM backlight driver. Fixed, not fake. Even though we can't control it, the backlight does have a supply. > Signed-off-by: Petr Cvek

Re: [PATCH 24/38] rtc: opal: fix type of token

2015-10-03 Thread Alexandre Belloni
On 21/09/2015 at 15:33:56 +0200, Andrzej Hajda wrote : > The variable can take signed values. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > >

[PATCH 7/24] ver_linux: module-init-tools.patch

2015-10-03 Thread Alexander Kapshuk
The current implementation relies on 'depmod' to be available in the PATH. It also expects the version number to be found in the last field as seen by 'awk'. Should the output format be different, this approach would no longer be reliable. The proposed implementation locates 'depmod', and uses

[PATCH 12/24] ver_linux: pcmciautils.patch

2015-10-03 Thread Alexander Kapshuk
The current implementation uses both 'grep' and 'awk' for text processing here, which may be alright as a quick solution to be run on the command line. While in a script, 'sed' or 'awk' would be a better choice. On top of that, the current implementation expects the version number to be found in

[PATCH 19/24] ver_linux: net-tools.patch

2015-10-03 Thread Alexander Kapshuk
The current implementation relies on 'ifconfig' to be available in the PATH. It also uses both 'grep' and 'awk' for text processing here, which may be alright as a quick solution to be run on the command line. While in a script, 'sed' or 'awk' would be a better choice. On top of that, the current

[PATCH 18/24] ver_linux: procps.patch

2015-10-03 Thread Alexander Kapshuk
The current implementation uses both 'grep' and 'awk' for text processing here, which may be alright as a quick solution to be run on the command line. While in a script, 'sed' or 'awk' would be a better choice. On top of that, the current implementation expects the version number to be found in

[PATCH 22/24] ver_linux: udev.patch

2015-10-03 Thread Alexander Kapshuk
'udevinfo' no longer seems to be available across various distros. 'udevadm' seems to be the currently valid way to look up the 'udev' version. Tested on: Gentoo Linux Debian 6.0.10 Oracle Linux Server release 7.1 Arch Linux Signed-off-by: Alexander Kapshuk --- ---

[PATCH 23/24] ver_linux: wireless-tools.patch

2015-10-03 Thread Alexander Kapshuk
Using 'awk' here is a bit of an overkill. Should the output of 'iwconfig --version' vary on another disto, or change overtime, it may no longer be available in field 4, as relied on by the current implementation. I believe 'sed' offers greater flexibility here in terms of processing varying

Re: [PATCH V1] rtc: GPL copyright inconsistency fix

2015-10-03 Thread Alexandre Belloni
On 02/10/2015 at 11:21:11 +0100, Steve Twiss wrote : > From: Steve Twiss > > Fix misleading and inconsistent copyright header wording. > > Alter the copyright header text and MODULE_LICENSE macro to ensure the > GPL v2 licence description is correctly represented.

[PATCH 06/15] cx25821: use pci_set_dma_mask insted of pci_dma_supported

2015-10-03 Thread Christoph Hellwig
This ensures the dma mask that is supported by the driver is recorded in the device structure. Signed-off-by: Christoph Hellwig --- drivers/media/pci/cx25821/cx25821-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx25821/cx25821-core.c

Re: [RFC][PATCH] x86/mm: warn on W+x mappings

2015-10-03 Thread Borislav Petkov
On Sat, Oct 03, 2015 at 09:50:45AM +0200, Ingo Molnar wrote: > Ah, I think you missed the following detail: the patch I suggested would > separate > the debugfs bits from the checking bits and would thus allow a 'security > check > only' .config setting. > > Distros would normally not want to

Re: [PATCH] genirq: Move irq_set_vcpu_affinity out of "#ifdef CONFIG_SMP"

2015-10-03 Thread Jiang Liu
On 2015/10/3 16:20, Feng Wu wrote: > irq_set_vcpu_affinity() is needed when CONFIG_SMP=n, so move the > definition out of "#ifdef CONFIG_SMP" > > Suggested-by: Paolo Bonzini > Signed-off-by: Feng Wu Reviewed-by: Jiang Liu >

Re: [PATCH 00/18] Input - Fix make coccicheck warnings

2015-10-03 Thread Javier Martinez Canillas
Hello Dmitry, On 10/02/2015 08:25 PM, Dmitry Torokhov wrote: > Hi Javier, > > On Fri, Oct 02, 2015 at 03:40:11PM +0200, Javier Martinez Canillas wrote: >> Hello Dmitry, >> >> This series contains trivial patches with fixes to different warnings >> reported by make coccichek M=drivers/input. >>

Re: [PATCH v3 0/4] iio: bmc150 regmap and SPI

2015-10-03 Thread Jonathan Cameron
On 24/09/15 08:11, Markus Pargmann wrote: > Hi Irina, > > On Wed, Sep 23, 2015 at 12:46:04PM +, Tirdea, Irina wrote: >> >> >>> -Original Message- >>> From: Markus Pargmann [mailto:m...@pengutronix.de] >>> Sent: 21 September, 2015 13:55 >>> To: Jonathan Cameron >>> Cc: Srinivas

Re: [PATCH v4 17/26] ARM: pxa: magician: Fix wrongly enabled USB host ports

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek: > USB host ports on the HTC Magician are wrongly enabled. Port 1 is for > bluetooth and port 2 is for OTG (mux in the charger connector). > > Signed-off-by: Petr Cvek > --- > arch/arm/mach-pxa/magician.c | 4 +++- > 1

[PATCH 10/24] ver_linux: reiserfsprogs.patch

2015-10-03 Thread Alexander Kapshuk
The current implementation uses both 'grep' and 'awk' for text processing here, which may be alright as a quick solution to be run on the command line. While in a script, 'sed' or 'awk' would be a better choice. On top of that, the current implementation expects the version number to be found in

[PATCH 24/24] ver_linux: proc-modules.patch

2015-10-03 Thread Alexander Kapshuk
The current implementation used a combination of both 'cat' and 'sed' to generate an unsorted list of kernel modules separated by while space. The proposed implementation uses 'sort' and 'sed' to generate a sort list of kernel modules separated by while space. Tested on: Gentoo Linux Debian

Re: [PATCH 3/24] ver_linux: gcc.patch

2015-10-03 Thread Richard Weinberger
On Sat, Oct 3, 2015 at 3:07 PM, Alexander Kapshuk wrote: > Using 'awk' here is a bit of an overkill. Should the output of 'gcc > -dumpversion' vary on another disto, or change overtime, it may no longer > be available at field 1, as relied on by the current

[PATCH 07/11] staging: dgnc: alignment style

2015-10-03 Thread Sudip Mukherjee
checkpatch was warning us that the alignment should match the open parenthesis. Signed-off-by: Sudip Mukherjee --- drivers/staging/dgnc/dgnc_cls.c| 14 +++--- drivers/staging/dgnc/dgnc_driver.c | 2 +- drivers/staging/dgnc/dgnc_neo.c| 2 +-

[PATCH 02/11] staging: dgnc: remove multiple blank lines

2015-10-03 Thread Sudip Mukherjee
checkpatch warns us about multiple blank lines which are not needed. Remove them. Signed-off-by: Sudip Mukherjee --- drivers/staging/dgnc/dgnc_driver.c | 10 drivers/staging/dgnc/dgnc_mgmt.c | 5 drivers/staging/dgnc/dgnc_neo.c| 37

[PATCH 11/11] staging: dgnc: remove dgnc_init_globals function

2015-10-03 Thread Sudip Mukherjee
The dgnc_init_globals() function is only initializing the timer so initialize it directly and remove dgnc_init_globals() and change the comment appropriately. Signed-off-by: Sudip Mukherjee --- drivers/staging/dgnc/dgnc_driver.c | 18 ++ 1 file changed, 2

remove dma_supported and pci_dma_supported as public APIs

2015-10-03 Thread Christoph Hellwig
All driver should be using dma_set_mask / pci_set_dma_mask to try to set the dma mask instead of just querying it. Without that some iommu implementations may not work. pci_dma_supported is removed entirely, but dma_supported stays for dma_ops implementations for now. -- To unsubscribe from

[PATCH 08/11] staging: dgnc: remove NULL test

2015-10-03 Thread Sudip Mukherjee
This NULL test is not required as iounmap will validate the argument. Signed-off-by: Sudip Mukherjee --- drivers/staging/dgnc/dgnc_cls.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c

[PATCH 01/11] staging: dgnc: remove unused variables

2015-10-03 Thread Sudip Mukherjee
These variables were only assigned some values but were never used. Signed-off-by: Sudip Mukherjee --- drivers/staging/dgnc/dgnc_cls.c | 4 +--- drivers/staging/dgnc/dgnc_tty.c | 11 ++- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git

Re: [PATCH] coccinelle: misc: remove "complex return code" warnings

2015-10-03 Thread Julia Lawall
Acked-by: Julia Lawall Perhaps there is a more restricted version that can be acceptable, but I'm OK with dropping the current version. julia On Thu, 1 Oct 2015, Johan Hovold wrote: > On Thu, Oct 01, 2015 at 07:20:10AM +0200, Julia Lawall wrote: > > On Wed, 30 Sep 2015,

Re: [PATCH] coccinelle: simple_return: fix typos in messages

2015-10-03 Thread Julia Lawall
On Fri, 2 Oct 2015, Javier Martinez Canillas wrote: > All messages have a typo that misspells the word simplified. Thanks for your contribution, but in another thread it has been proposed to drop the semantic patch completely. julia > > Signed-off-by: Javier Martinez Canillas

Re: [PATCH] coccinelle: misc: remove "complex return code" warnings

2015-10-03 Thread Julia Lawall
Should have acked this message... Acked-by: Julia Lawall On Wed, 30 Sep 2015, Johan Hovold wrote: > This effectively reverts 932058a5d5f9 ("coccinelle: misc: semantic patch > to delete overly complex return code processing"). > > There can be both symmetry and readability

Re: [PATCH 14/19] sony-laptop: fix handling sony_nc_hotkeys_decode result

2015-10-03 Thread Darren Hart
On Thu, Sep 24, 2015 at 04:00:22PM +0200, Andrzej Hajda wrote: > The function can return negative value. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107

Re: [PATCH 2/2] video: fbdev: pxafb: initial devicetree conversion

2015-10-03 Thread Philipp Zabel
Hi Robert, On Sat, Oct 3, 2015 at 6:11 PM, Robert Jarzmik wrote: > This patch brings a first support of pxa framebuffer devices to a > devicetree pxa platform, as was before platform data. > > There are restrictions with this port, the biggest one being the lack of >

Re: [PATCH v3 1/2] ARM: at91/dt: shdwc binding: add new shutdown controller documentation

2015-10-03 Thread Alexandre Belloni
On 30/09/2015 at 18:22:00 +0200, Nicolas Ferre wrote : > +SHDWC Shutdown Controller (Alternative) > + > +1) shdwc node > + > +required properties: > +- compatible: should be "atmel,sama5d2-shdwc". > +- reg: should contain registers location and length > +- clocks: phandle to input clock. > +-

Re: [PATCH v2 1/3] unix: fix use-after-free in unix_dgram_poll()

2015-10-03 Thread Rainer Weikusat
Mathias Krause writes: > On 2 October 2015 at 22:43, Jason Baron wrote: >> The unix_dgram_poll() routine calls sock_poll_wait() not only for the wait >> queue associated with the socket s that we are poll'ing against, but also >> calls [useless

Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface

2015-10-03 Thread Darren Hart
On Tue, Sep 29, 2015 at 05:50:32PM +0800, joeyli wrote: > Hi Martin, > > On Tue, Sep 29, 2015 at 08:46:38AM +0200, Martin Kepplinger wrote: > > Signed-off-by: Martin Kepplinger > > --- > > This just looks odd in the logs. Feel free to ignore it or act on it > > differently ;)

[PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null()

2015-10-03 Thread mike dupuis
This is a patch to remove the function ieee80211_ccmp_null(). This function does nothing and can therefore be safely removed. Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 2/3] Staging: rtl8192u: remove ieee80211_wep_null()

2015-10-03 Thread mike dupuis
This is a patch to remove the function ieee80211_wep_null(). This function does nothing and can therefore be safely removed. Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 4

[PATCH 1/3] Staging: rtl8192u: remove ieee80211_tkip_null()

2015-10-03 Thread mike dupuis
This is a patch to remove the function ieee80211_tkip_null(). This function does nothing, and can therefore be safely removed. Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 6 --

Re: [PATCH] video: fbdev: add Marvell PXA framebuffer binding

2015-10-03 Thread Robert Jarzmik
Philipp Zabel writes: > On Sat, Oct 3, 2015 at 6:11 PM, Robert Jarzmik wrote: >> Add documentation for the PXA frambuffer devicetree binding. >> >> Signed-off-by: Robert Jarzmik >> Cc: Jean-Christophe Plagniol-Villard

[PATCH] staging: rdma: Fix braces around if/else

2015-10-03 Thread Martin Kletzander
Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl. Signed-off-by: Martin Kletzander --- There is one warning reported in this patch though. That's because of the multiline string and it's pre-existing. Feel free to let me know if that should be fixed

Re: [PATCH 3/24] ver_linux: gcc.patch

2015-10-03 Thread Alexander Kapshuk
On Sat, Oct 3, 2015 at 6:07 PM, Richard Weinberger wrote: > On Sat, Oct 3, 2015 at 3:07 PM, Alexander Kapshuk > wrote: >> Using 'awk' here is a bit of an overkill. Should the output of 'gcc >> -dumpversion' vary on another disto, or

[PATCH] usbhid: Fix for the WiiU adapter from Mayflash

2015-10-03 Thread Oliver Schmitt
The WiiU adapter from Mayflash (see http://www.mayflash.com/Products/NINTENDOWiiU/W009.html) is not working correctly. The "XInput" mode works fine, the controller is recognized as a xbox controller. But it is only possible to connect one controller with this method. In "DInput" mode the

Re: [PATCH 23/39] UBI: drop null test before destroy functions

2015-10-03 Thread Richard Weinberger
Am 13.09.2015 um 14:15 schrieb Julia Lawall: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > // > >

Re: [GIT PULL] x86 fixes

2015-10-03 Thread Thomas Gleixner
On Sat, 3 Oct 2015, Ingo Molnar wrote: > > Please pull the latest x86-urgent-for-linus git tree from: > > > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > > x86-urgent-for-linus > > > ># HEAD: f4b4aae1828855db761bf998ce37d3062b1d6446 x86/headers/uapi: Fix > >

[PATCH] [SMB3] Do not fall back to SMBWriteX in set_file_size error cases

2015-10-03 Thread Steve French
The error paths in set_file_size for cifs and smb3 are incorrect. In the unlikely event that a server did not support set file info of the file size, the code incorrectly falls back to trying SMBWriteX (note that only the original core SMB Write, used for example by DOS, can set the file size

[PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-03 Thread Daniel Thompson
Add support for STMicroelectronics STM32 random number generator. The config value defaults to N, reflecting the fact that STM32 is a very low resource microcontroller platform and unlikely to be targeted by any "grown up" defconfigs. Signed-off-by: Daniel Thompson

[PATCH 1/3] dt-bindings: Document the STM32 HW RNG bindings

2015-10-03 Thread Daniel Thompson
This adds documenttaion of device tree binds for the STM32 hardware random number generator. Signed-off-by: Daniel Thompson --- .../devicetree/bindings/hwrng/stm32-rng.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644

[PATCH 3/3] ARM: dts: stm32f429: Adopt STM32 RNG driver

2015-10-03 Thread Daniel Thompson
New bindings and driver have been created for STM32 series parts. This patch integrates this changes. Signed-off-by: Daniel Thompson --- arch/arm/boot/dts/stm32f429.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429.dtsi

Re: [PATCH 3/24] ver_linux: gcc.patch

2015-10-03 Thread Richard Weinberger
Am 03.10.2015 um 18:07 schrieb Alexander Kapshuk: > The main objective I endeavoured to attain was to come up with an > algorithm that would possibly result in a uniform output that would > work across as many distros as possbile. The current implementation > seems to struggle with that. What

[PATCH] staging: iio: adc: fix comment block coding style issue

2015-10-03 Thread Hugo Camboulive
This patch to ad7746.c makes the comment block end with a */ on a separate line. Signed-off-by: Hugo Camboulive --- drivers/staging/iio/cdc/ad7746.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/cdc/ad7746.c

Re: [PATCH] kselftest: replace $(RM) with rm -f command

2015-10-03 Thread Josh Triplett
On Sat, Oct 03, 2015 at 02:11:57PM +, Mathieu Desnoyers wrote: > - On Oct 3, 2015, at 12:38 AM, dvhart dvh...@infradead.org wrote: > > > On Mon, Sep 28, 2015 at 03:16:53AM +, Mathieu Desnoyers wrote: > >> - On Sep 27, 2015, at 10:10 PM, Wang Long long.wangl...@huawei.com > >>

Re: [PATCH] mm/mmap.c: Remove redundant vma looping

2015-10-03 Thread Richard Weinberger
On Sat, Oct 3, 2015 at 9:38 PM, Chen Gang wrote: > From 36dbcc145819655682f80efd49e72b01515b4e9a Mon Sep 17 00:00:00 2001 > From: Chen Gang > Date: Sun, 4 Oct 2015 03:22:41 +0800 > Subject: [PATCH] mm/mmap.c: Remove redundant vma looping > >

[PATCH 0/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-03 Thread Daniel Thompson
This patchset introduces a driver for the STM32 hardware random number generator. Daniel Thompson (3): dt-bindings: Document the STM32 HW RNG bindings hwrng: stm32 - add support for STM32 HW RNG ARM: dts: stm32f429: Adopt STM32 RNG driver .../devicetree/bindings/hwrng/stm32-rng.txt

[PATCH] hwrng: fix simple_return.cocci warnings

2015-10-03 Thread kbuild test robot
drivers/char/hw_random/stm32-rng.c:164:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Daniel Thompson Signed-off-by:

Re: [PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-03 Thread kbuild test robot
Hi Daniel, [auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore] coccinelle warnings: (new ones prefixed by >>) >> drivers/char/hw_random/stm32-rng.c:164:1-4: WARNING: end returns can be >> simpified Please review and possibly fold the followup patch. --- 0-DAY

Re: [PATCH] usb-host: Remove fusbh200 driver

2015-10-03 Thread Felipe Balbi
Peter Senna Tschudin writes: > On Fri, Oct 2, 2015 at 7:39 PM, Felipe Balbi wrote: >> On Fri, Oct 02, 2015 at 01:18:27PM +0200, Peter Senna Tschudin wrote: >>> fusbh200 and fotg210 are very similar. The initial idea was to consolidate >>> both drivers but

Re: [PATCH 05/17] platform: x86: remove misuse of IRQF_NO_SUSPEND flag

2015-10-03 Thread Darren Hart
On Mon, Sep 21, 2015 at 04:47:01PM +0100, Sudeep Holla wrote: > The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > be left enabled so as to allow them to work as expected during the > suspend-resume cycle, but doesn't guarantee that it will wake the system > from a suspended

Re: [PATCH] video: fbdev: add Marvell PXA framebuffer binding

2015-10-03 Thread Philipp Zabel
Am Samstag, den 03.10.2015, 19:23 +0200 schrieb Robert Jarzmik: [...] > a/Documentation/devicetree/bindings/video/marvell,pxafb.txt > > > b/Documentation/devicetree/bindings/video/marvell,pxafb.txt > > > new file mode 100644 > > > index ..489055bf3c57 > > > --- /dev/null > > > +++

<    1   2   3   4   5   6   7   >