Re: linux-next: duplicate patches in the kspp and kbuild trees

2016-07-26 Thread Kees Cook
On Tue, Jul 26, 2016 at 3:19 PM, Michal Marek wrote: > Dne 14.6.2016 v 18:39 Kees Cook napsal(a): >> On Tue, Jun 14, 2016 at 7:13 AM, Stephen Rothwell >> wrote: >>> Hi Michal, >>> >>> On Tue, 14 Jun 2016 15:01:42 +0200 Michal Marek wrote:

Re: linux-next: duplicate patches in the kspp and kbuild trees

2016-07-26 Thread Kees Cook
On Tue, Jul 26, 2016 at 3:19 PM, Michal Marek wrote: > Dne 14.6.2016 v 18:39 Kees Cook napsal(a): >> On Tue, Jun 14, 2016 at 7:13 AM, Stephen Rothwell >> wrote: >>> Hi Michal, >>> >>> On Tue, 14 Jun 2016 15:01:42 +0200 Michal Marek wrote: I won't :). Kees, are you going to keep the

Re: Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk

2016-07-26 Thread Rafael J. Wysocki
On Wed, Jul 27, 2016 at 12:42 AM, Rafael J. Wysocki wrote: > On Tuesday, July 26, 2016 04:53:19 PM Josh Poimboeuf wrote: >> On Tue, Jul 26, 2016 at 10:15:39PM +0200, Rafael J. Wysocki wrote: >> > On Tuesday, July 26, 2016 09:39:05 AM Josh Poimboeuf wrote: >> > > On Tue, Jul

Re: Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk

2016-07-26 Thread Rafael J. Wysocki
On Wed, Jul 27, 2016 at 12:42 AM, Rafael J. Wysocki wrote: > On Tuesday, July 26, 2016 04:53:19 PM Josh Poimboeuf wrote: >> On Tue, Jul 26, 2016 at 10:15:39PM +0200, Rafael J. Wysocki wrote: >> > On Tuesday, July 26, 2016 09:39:05 AM Josh Poimboeuf wrote: >> > > On Tue, Jul 26, 2016 at 01:32:28PM

[PATCH 4.8? 0/4] Allow the trampoline to use EFI boot services RAM

2016-07-26 Thread Andy Lutomirski
As currently configured, my laptop cannot boot any existing kernel because the real mode trampoline can't be reserved. The ranges in which it could live are rejected by the kernel: one is EFI boot services data and the other is above the EBDA. Allowing use of RAM between the EBDA and 640k is

[PATCH 4.8? 0/4] Allow the trampoline to use EFI boot services RAM

2016-07-26 Thread Andy Lutomirski
As currently configured, my laptop cannot boot any existing kernel because the real mode trampoline can't be reserved. The ranges in which it could live are rejected by the kernel: one is EFI boot services data and the other is above the EBDA. Allowing use of RAM between the EBDA and 640k is

[PATCH 1/4] x86/boot: Synchronize trampoline_cr4_features and mmu_cr4_features directly

2016-07-26 Thread Andy Lutomirski
The initialization process for trampoline_cr4_features and mmu_cr4_features was confusing. The intent is for mmu_cr4_features and *trampoline_cr4_features to stay in sync, but trampoline_cr4_features is NULL until setup_real_mode() runs. The old code synchronized *trampoline_cr4_features

[PATCH 4/4] x86/efi: Allocate a trampoline if needed in efi_free_boot_services()

2016-07-26 Thread Andy Lutomirski
On my Dell XPS 13 9350 with firmware 1.4.4 and SGX on, if I boot Fedora 24's grub2-efi off a hard disk, my first 1MB of RAM looks like: efi: mem00: [Runtime Data |RUN| | | | | | | |WB|WT|WC|UC] range=[0x-0x0fff] (0MB) efi: mem01: [Boot Data |

[PATCH 1/4] x86/boot: Synchronize trampoline_cr4_features and mmu_cr4_features directly

2016-07-26 Thread Andy Lutomirski
The initialization process for trampoline_cr4_features and mmu_cr4_features was confusing. The intent is for mmu_cr4_features and *trampoline_cr4_features to stay in sync, but trampoline_cr4_features is NULL until setup_real_mode() runs. The old code synchronized *trampoline_cr4_features

[PATCH 4/4] x86/efi: Allocate a trampoline if needed in efi_free_boot_services()

2016-07-26 Thread Andy Lutomirski
On my Dell XPS 13 9350 with firmware 1.4.4 and SGX on, if I boot Fedora 24's grub2-efi off a hard disk, my first 1MB of RAM looks like: efi: mem00: [Runtime Data |RUN| | | | | | | |WB|WT|WC|UC] range=[0x-0x0fff] (0MB) efi: mem01: [Boot Data |

[PATCH 3/4] x86/boot: Rework reserve_real_mode() to allow multiple tries

2016-07-26 Thread Andy Lutomirski
If reserve_real_mode() fails, panicing immediately means we're doomed. Make it safe to try more than once to allocate the trampoline: - Degrade a failure from panic() to pr_info(). (If we make it to setup_real_mode() without reserving the trampoline, we'll panic them.) - Factor out

[PATCH 2/4] x86/boot: Defer setup_real_mode() to early_initcall time

2016-07-26 Thread Andy Lutomirski
There's no need to run setup_real_mode() as early as we run it. Defer it to the same early_initcall that sets up the page permissions for the real mode code. This should be a code size reduction. More importantly, it give us a longer window in which we can allocate the real mode trampoline.

[PATCH 3/4] x86/boot: Rework reserve_real_mode() to allow multiple tries

2016-07-26 Thread Andy Lutomirski
If reserve_real_mode() fails, panicing immediately means we're doomed. Make it safe to try more than once to allocate the trampoline: - Degrade a failure from panic() to pr_info(). (If we make it to setup_real_mode() without reserving the trampoline, we'll panic them.) - Factor out

[PATCH 2/4] x86/boot: Defer setup_real_mode() to early_initcall time

2016-07-26 Thread Andy Lutomirski
There's no need to run setup_real_mode() as early as we run it. Defer it to the same early_initcall that sets up the page permissions for the real mode code. This should be a code size reduction. More importantly, it give us a longer window in which we can allocate the real mode trampoline.

Re: [PATCH v3] i2c: i2c-cros-ec-tunnel: Reduce logging noise

2016-07-26 Thread Doug Anderson
Hi On Tue, Jul 26, 2016 at 3:34 PM, Guenter Roeck wrote: > If an i2c access through i2c-cros-ec-tunnel returns an error, the following > log message is seen on the console. > > cros-ec-i2c-tunnel ff20.spi:ec@0:i2c-tunnel: > Error parsing EC i2c

Re: [PATCH v3] i2c: i2c-cros-ec-tunnel: Reduce logging noise

2016-07-26 Thread Doug Anderson
Hi On Tue, Jul 26, 2016 at 3:34 PM, Guenter Roeck wrote: > If an i2c access through i2c-cros-ec-tunnel returns an error, the following > log message is seen on the console. > > cros-ec-i2c-tunnel ff20.spi:ec@0:i2c-tunnel: > Error parsing EC i2c message -121 > > This

Re: [PATCH] mmc: sdhci-esdhc-imx: avoid unused function warnings

2016-07-26 Thread Ulf Hansson
On 26 July 2016 at 22:56, Arnd Bergmann wrote: > On Tuesday, July 26, 2016 10:18:53 PM CEST Ulf Hansson wrote: >> > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c >> > b/drivers/mmc/host/sdhci-esdhc-imx.c >> > index 2bb326bbc34a..593e34053c4b 100644 >> > ---

Re: [PATCH] mmc: sdhci-esdhc-imx: avoid unused function warnings

2016-07-26 Thread Ulf Hansson
On 26 July 2016 at 22:56, Arnd Bergmann wrote: > On Tuesday, July 26, 2016 10:18:53 PM CEST Ulf Hansson wrote: >> > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c >> > b/drivers/mmc/host/sdhci-esdhc-imx.c >> > index 2bb326bbc34a..593e34053c4b 100644 >> > --- a/drivers/mmc/host/sdhci-esdhc-imx.c

[GIT PULL] tracing: Updates for 4.8

2016-07-26 Thread Steven Rostedt
Linus, This is mostly clean ups and small fixes. Some of the more visible changes are: . The function pid code uses the event pid filtering logic . [ku]probe events have access to current->comm . trace_printk now has sample code . PCI devices now trace physical addresses . stack tracing

[GIT PULL] tracing: Updates for 4.8

2016-07-26 Thread Steven Rostedt
Linus, This is mostly clean ups and small fixes. Some of the more visible changes are: . The function pid code uses the event pid filtering logic . [ku]probe events have access to current->comm . trace_printk now has sample code . PCI devices now trace physical addresses . stack tracing

[PATCH] Skip UV runtime services mapping in the efi_runtime_disabled case

2016-07-26 Thread Alex Thorlton
This problem has actually been in the UV code for a while, but we didn't catch it until recently, because we had been relying on EFI_OLD_MEMMAP to allow our systems to boot for a period of time. We noticed the issue when trying to kexec a recent community kernel, where we hit this NULL pointer

[PATCH] Skip UV runtime services mapping in the efi_runtime_disabled case

2016-07-26 Thread Alex Thorlton
This problem has actually been in the UV code for a while, but we didn't catch it until recently, because we had been relying on EFI_OLD_MEMMAP to allow our systems to boot for a period of time. We noticed the issue when trying to kexec a recent community kernel, where we hit this NULL pointer

[RFC PATCH] Fix EFI callbacks on UV during kexec

2016-07-26 Thread Alex Thorlton
Hey everyone, This is a fix for our BIOS init code to skip mapping in runtime services when runtime_disabled == true. This is one that snuck under the radar for a while, since we were using EFI_OLD_MEMMAP for so long. I've explained the details of how it went unnoticed in the commit message.

[RFC PATCH] Fix EFI callbacks on UV during kexec

2016-07-26 Thread Alex Thorlton
Hey everyone, This is a fix for our BIOS init code to skip mapping in runtime services when runtime_disabled == true. This is one that snuck under the radar for a while, since we were using EFI_OLD_MEMMAP for so long. I've explained the details of how it went unnoticed in the commit message.

Re: [zer0...@yahoo.com: [oss-security] panic at big_key_preparse #4.7-r6/rc7 & master]

2016-07-26 Thread David Howells
Greg KH wrote: > David, here's a bug report with reproducer that was sent to the > oss-security mailing list for some unknown reason earlier today. > > Any ideas? I think may have figured it out: big_key_crypto_init() may fail even though big_key_init() succeeds

Re: [zer0...@yahoo.com: [oss-security] panic at big_key_preparse #4.7-r6/rc7 & master]

2016-07-26 Thread David Howells
Greg KH wrote: > David, here's a bug report with reproducer that was sent to the > oss-security mailing list for some unknown reason earlier today. > > Any ideas? I think may have figured it out: big_key_crypto_init() may fail even though big_key_init() succeeds (and also vice versa). The

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Guenter Roeck
On Tue, Jul 26, 2016 at 08:13:12PM +0800, Caesar Wang wrote: > SARADC controller needs to be reset before programming it, otherwise > it will not function properly. > > Signed-off-by: Caesar Wang > Cc: Jonathan Cameron > Cc: Heiko Stuebner

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Guenter Roeck
On Tue, Jul 26, 2016 at 08:13:12PM +0800, Caesar Wang wrote: > SARADC controller needs to be reset before programming it, otherwise > it will not function properly. > > Signed-off-by: Caesar Wang > Cc: Jonathan Cameron > Cc: Heiko Stuebner > Cc: Rob Herring > Cc: linux-...@vger.kernel.org >

Re: [PATCH 10/19] x86/dumpstack: add get_stack_info() interface

2016-07-26 Thread Andy Lutomirski
On Tue, Jul 26, 2016 at 3:24 PM, Josh Poimboeuf wrote: > On Tue, Jul 26, 2016 at 01:59:20PM -0700, Andy Lutomirski wrote: >> On Tue, Jul 26, 2016 at 9:26 AM, Josh Poimboeuf wrote: >> > On Mon, Jul 25, 2016 at 05:09:44PM -0700, Andy Lutomirski wrote: >>

Re: [PATCH 10/19] x86/dumpstack: add get_stack_info() interface

2016-07-26 Thread Andy Lutomirski
On Tue, Jul 26, 2016 at 3:24 PM, Josh Poimboeuf wrote: > On Tue, Jul 26, 2016 at 01:59:20PM -0700, Andy Lutomirski wrote: >> On Tue, Jul 26, 2016 at 9:26 AM, Josh Poimboeuf wrote: >> > On Mon, Jul 25, 2016 at 05:09:44PM -0700, Andy Lutomirski wrote: >> >> On Sat, Jul 23, 2016 at 7:04 AM, Josh

Re: Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk

2016-07-26 Thread Rafael J. Wysocki
On Tuesday, July 26, 2016 04:53:19 PM Josh Poimboeuf wrote: > On Tue, Jul 26, 2016 at 10:15:39PM +0200, Rafael J. Wysocki wrote: > > On Tuesday, July 26, 2016 09:39:05 AM Josh Poimboeuf wrote: > > > On Tue, Jul 26, 2016 at 01:32:28PM +0200, Rafael J. Wysocki wrote: > > > > Hi, > > > > > > > > The

Re: Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk

2016-07-26 Thread Rafael J. Wysocki
On Tuesday, July 26, 2016 04:53:19 PM Josh Poimboeuf wrote: > On Tue, Jul 26, 2016 at 10:15:39PM +0200, Rafael J. Wysocki wrote: > > On Tuesday, July 26, 2016 09:39:05 AM Josh Poimboeuf wrote: > > > On Tue, Jul 26, 2016 at 01:32:28PM +0200, Rafael J. Wysocki wrote: > > > > Hi, > > > > > > > > The

[PATCH v3] i2c: i2c-cros-ec-tunnel: Reduce logging noise

2016-07-26 Thread Guenter Roeck
If an i2c access through i2c-cros-ec-tunnel returns an error, the following log message is seen on the console. cros-ec-i2c-tunnel ff20.spi:ec@0:i2c-tunnel: Error parsing EC i2c message -121 This can happen a lot if, for example, the i2c-detect command is executed.

[PATCH v3] i2c: i2c-cros-ec-tunnel: Reduce logging noise

2016-07-26 Thread Guenter Roeck
If an i2c access through i2c-cros-ec-tunnel returns an error, the following log message is seen on the console. cros-ec-i2c-tunnel ff20.spi:ec@0:i2c-tunnel: Error parsing EC i2c message -121 This can happen a lot if, for example, the i2c-detect command is executed.

Re: [PATCH 10/19] x86/dumpstack: add get_stack_info() interface

2016-07-26 Thread Steven Rostedt
On Tue, 26 Jul 2016 17:24:54 -0500 Josh Poimboeuf wrote: > > This should be impossible unless that last entry is MCE. If we > > actually fire an event that isn't MCE early in NMI entry, something > > already went very wrong. > > So we don't need to support breakpoints in

Re: [PATCH 10/19] x86/dumpstack: add get_stack_info() interface

2016-07-26 Thread Steven Rostedt
On Tue, 26 Jul 2016 17:24:54 -0500 Josh Poimboeuf wrote: > > This should be impossible unless that last entry is MCE. If we > > actually fire an event that isn't MCE early in NMI entry, something > > already went very wrong. > > So we don't need to support breakpoints in the early NMI entry

Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time

2016-07-26 Thread David Miller
From: Colin King Date: Tue, 12 Jul 2016 11:59:39 +0100 > From: Colin Ian King > > According to the HPT366 data sheet, PCI config space dword 0x40-0x43 > bits 11:8 specify the primary drive cmd_high_time, however, > currently just 3 bits of

Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time

2016-07-26 Thread David Miller
From: Colin King Date: Tue, 12 Jul 2016 11:59:39 +0100 > From: Colin Ian King > > According to the HPT366 data sheet, PCI config space dword 0x40-0x43 > bits 11:8 specify the primary drive cmd_high_time, however, > currently just 3 bits of the 4 are being used because the mask > is 0x07 and

Re: [PATCH] ide-tape: fix misprint in failure handling in idetape_init()

2016-07-26 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 30 Apr 2016 01:11:12 +0300 > If driver_register() failed there is no sense to call driver_unregister(). > unregister_chrdev() should be called here. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by:

Re: [PATCH 5/5] cmd640: add __init attribute

2016-07-26 Thread David Miller
From: Julia Lawall Date: Mon, 18 Apr 2016 16:55:38 +0200 > Add __init attribute on a function that is only called from other __init > functions and that is not inlined, at least with gcc version 4.8.4 on an > x86 machine with allyesconfig. Currently, the function is put in

Re: [PATCH] ide-tape: fix misprint in failure handling in idetape_init()

2016-07-26 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 30 Apr 2016 01:11:12 +0300 > If driver_register() failed there is no sense to call driver_unregister(). > unregister_chrdev() should be called here. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov

Re: [PATCH 5/5] cmd640: add __init attribute

2016-07-26 Thread David Miller
From: Julia Lawall Date: Mon, 18 Apr 2016 16:55:38 +0200 > Add __init attribute on a function that is only called from other __init > functions and that is not inlined, at least with gcc version 4.8.4 on an > x86 machine with allyesconfig. Currently, the function is put in the > .text.unlikely

Re: [PATCH 10/19] x86/dumpstack: add get_stack_info() interface

2016-07-26 Thread Josh Poimboeuf
On Tue, Jul 26, 2016 at 01:59:20PM -0700, Andy Lutomirski wrote: > On Tue, Jul 26, 2016 at 9:26 AM, Josh Poimboeuf wrote: > > On Mon, Jul 25, 2016 at 05:09:44PM -0700, Andy Lutomirski wrote: > >> On Sat, Jul 23, 2016 at 7:04 AM, Josh Poimboeuf > >>

Re: [PATCH 10/19] x86/dumpstack: add get_stack_info() interface

2016-07-26 Thread Josh Poimboeuf
On Tue, Jul 26, 2016 at 01:59:20PM -0700, Andy Lutomirski wrote: > On Tue, Jul 26, 2016 at 9:26 AM, Josh Poimboeuf wrote: > > On Mon, Jul 25, 2016 at 05:09:44PM -0700, Andy Lutomirski wrote: > >> On Sat, Jul 23, 2016 at 7:04 AM, Josh Poimboeuf > >> wrote: > >> >> > Unless I'm missing something,

Re: linux-next: duplicate patches in the kspp and kbuild trees

2016-07-26 Thread Michal Marek
Dne 14.6.2016 v 18:39 Kees Cook napsal(a): > On Tue, Jun 14, 2016 at 7:13 AM, Stephen Rothwell > wrote: >> Hi Michal, >> >> On Tue, 14 Jun 2016 15:01:42 +0200 Michal Marek wrote: >>> >>> I won't :). Kees, are you going to keep the patch in your tree and

Re: [PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

2016-07-26 Thread David Miller
From: Bhaktipriya Shridhar Date: Tue, 26 Jul 2016 22:38:24 +0530 > The workqueue health->wq was used as per device private health thread. > This was done to perform delayed work. > > The workqueue has a single workitem(>work) and > hence doesn't require ordering. It is

Re: linux-next: duplicate patches in the kspp and kbuild trees

2016-07-26 Thread Michal Marek
Dne 14.6.2016 v 18:39 Kees Cook napsal(a): > On Tue, Jun 14, 2016 at 7:13 AM, Stephen Rothwell > wrote: >> Hi Michal, >> >> On Tue, 14 Jun 2016 15:01:42 +0200 Michal Marek wrote: >>> >>> I won't :). Kees, are you going to keep the patch in your tree and send >>> it to Linus once kbuild is in?

Re: [PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

2016-07-26 Thread David Miller
From: Bhaktipriya Shridhar Date: Tue, 26 Jul 2016 22:38:24 +0530 > The workqueue health->wq was used as per device private health thread. > This was done to perform delayed work. > > The workqueue has a single workitem(>work) and > hence doesn't require ordering. It is involved in handling the

Re: linux-next: manual merge of the clockevents tree with the arm-soc tree

2016-07-26 Thread Stephen Rothwell
Hi All, On Thu, 7 Jul 2016 14:12:26 +1000 Stephen Rothwell wrote: > > Hi Daniel, > > Today's linux-next merge of the clockevents tree got a conflict in: > > arch/arm/Kconfig > > between commit: > > c86f51737f8d ("ARM: clps711x: Switch to MULTIPLATFORM") > > from

Re: linux-next: manual merge of the clockevents tree with the arm-soc tree

2016-07-26 Thread Stephen Rothwell
Hi All, On Thu, 7 Jul 2016 14:12:26 +1000 Stephen Rothwell wrote: > > Hi Daniel, > > Today's linux-next merge of the clockevents tree got a conflict in: > > arch/arm/Kconfig > > between commit: > > c86f51737f8d ("ARM: clps711x: Switch to MULTIPLATFORM") > > from the arm-soc tree and

Re: [PATCH 2/6] extcon: Add the support for extcon property according to extcon type

2016-07-26 Thread Guenter Roeck
On Tue, Jul 26, 2016 at 5:09 AM, Chanwoo Choi wrote: > This patch support the extcon property for the external connector > because each external connector might have the property according to > the H/W design and the specific characteristics. > > - EXTCON_PROP_USB_[property

Re: [PATCH 2/6] extcon: Add the support for extcon property according to extcon type

2016-07-26 Thread Guenter Roeck
On Tue, Jul 26, 2016 at 5:09 AM, Chanwoo Choi wrote: > This patch support the extcon property for the external connector > because each external connector might have the property according to > the H/W design and the specific characteristics. > > - EXTCON_PROP_USB_[property name] > -

[PATCH v2] ASoC: dapm: Add a dummy snd_pcm_runtime to avoid NULL pointer access

2016-07-26 Thread Nicolin Chen
The SND_SOC_DAPM_PRE_PMU case would call startup()/hw_params() that might access substream->runtime through other functions. For example: Unable to handle kernel NULL pointer dereference at virtual address [] PC is at snd_pcm_hw_rule_add+0x24/0x1b0 LR is at

[PATCH v2] ASoC: dapm: Add a dummy snd_pcm_runtime to avoid NULL pointer access

2016-07-26 Thread Nicolin Chen
The SND_SOC_DAPM_PRE_PMU case would call startup()/hw_params() that might access substream->runtime through other functions. For example: Unable to handle kernel NULL pointer dereference at virtual address [] PC is at snd_pcm_hw_rule_add+0x24/0x1b0 LR is at

Re: [RFC PATCH 0/5] USB Audio Gadget refactoring

2016-07-26 Thread Ruslan Bilovol
On Tue, Jul 26, 2016 at 3:02 PM, Krzysztof Opasiak wrote: > > > On 07/26/2016 10:53 AM, Jassi Brar wrote: >> On Tue, Jul 26, 2016 at 7:01 AM, Ruslan Bilovol >> wrote: >>> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch >>>

Re: [RFC PATCH 0/5] USB Audio Gadget refactoring

2016-07-26 Thread Ruslan Bilovol
On Tue, Jul 26, 2016 at 3:02 PM, Krzysztof Opasiak wrote: > > > On 07/26/2016 10:53 AM, Jassi Brar wrote: >> On Tue, Jul 26, 2016 at 7:01 AM, Ruslan Bilovol >> wrote: >>> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch >>> wrote: >> On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol >>

[GIT PULL] usercopy protection for v4.8

2016-07-26 Thread Kees Cook
Hi, This is my next pull request for v4.8, which introduces a kernel self protection of copy_to_user/copy_from_user that has been under review and test on the kernel-hardening list for a while. It has lived for a bit in -next, and appears to be ready IMO. There will be more improvements in the

[GIT PULL] usercopy protection for v4.8

2016-07-26 Thread Kees Cook
Hi, This is my next pull request for v4.8, which introduces a kernel self protection of copy_to_user/copy_from_user that has been under review and test on the kernel-hardening list for a while. It has lived for a bit in -next, and appears to be ready IMO. There will be more improvements in the

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-26 Thread Grant Grundler
On Tue, Jul 26, 2016 at 2:14 PM, Robert Foss wrote: ... > Thanks for the feedback (for this patch and the other ones)! > I'm preparing a v2 and will submit it withing a day or two. Excellent! very welcome and thanks again for picking this up. ... >> FTR, current

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-26 Thread Grant Grundler
On Tue, Jul 26, 2016 at 2:14 PM, Robert Foss wrote: ... > Thanks for the feedback (for this patch and the other ones)! > I'm preparing a v2 and will submit it withing a day or two. Excellent! very welcome and thanks again for picking this up. ... >> FTR, current drivers/net/usb/ax88179_178a.c

Re: Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk

2016-07-26 Thread Josh Poimboeuf
On Tue, Jul 26, 2016 at 10:15:39PM +0200, Rafael J. Wysocki wrote: > On Tuesday, July 26, 2016 09:39:05 AM Josh Poimboeuf wrote: > > On Tue, Jul 26, 2016 at 01:32:28PM +0200, Rafael J. Wysocki wrote: > > > Hi, > > > > > > The following commit: > > > > > > commit

Re: Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk

2016-07-26 Thread Josh Poimboeuf
On Tue, Jul 26, 2016 at 10:15:39PM +0200, Rafael J. Wysocki wrote: > On Tuesday, July 26, 2016 09:39:05 AM Josh Poimboeuf wrote: > > On Tue, Jul 26, 2016 at 01:32:28PM +0200, Rafael J. Wysocki wrote: > > > Hi, > > > > > > The following commit: > > > > > > commit

Re: [PATCH v2] kbuild: Abort build on bad stack protector flag

2016-07-26 Thread Michal Marek
Dne 26.7.2016 v 23:26 Kees Cook napsal(a): > Before, the stack protector flag was sanity checked before .config had > been reprocessed. This meant the build couldn't be aborted early, and > only a warning could be emitted followed later by the compiler blowing > up with an unknown flag. This has

Re: [PATCH v2] kbuild: Abort build on bad stack protector flag

2016-07-26 Thread Michal Marek
Dne 26.7.2016 v 23:26 Kees Cook napsal(a): > Before, the stack protector flag was sanity checked before .config had > been reprocessed. This meant the build couldn't be aborted early, and > only a warning could be emitted followed later by the compiler blowing > up with an unknown flag. This has

Re: staging: lustre: One function call less in class_register_type() after error detection

2016-07-26 Thread Oleg Drokin
On Jul 26, 2016, at 3:56 PM, SF Markus Elfring wrote: >> But kobject_put() already checks for NULL, right? > > Yes. - Such an input parameter validation is performed by the > function implementation. > > >> you just submitted another batch about that in other area. > > I sent update

Re: staging: lustre: One function call less in class_register_type() after error detection

2016-07-26 Thread Oleg Drokin
On Jul 26, 2016, at 3:56 PM, SF Markus Elfring wrote: >> But kobject_put() already checks for NULL, right? > > Yes. - Such an input parameter validation is performed by the > function implementation. > > >> you just submitted another batch about that in other area. > > I sent update

Re: [PATCH 1/1 linux-next] kbuild: add make force=1 for testing

2016-07-26 Thread Michal Marek
Dne 26.7.2016 v 02:05 Andrew Morton napsal(a): > On Sun, 24 Jul 2016 15:28:18 +0200 Fabian Frederick wrote: >> This patch adds ability to do make force=1 for people >> not interested in modules_install in this case but only testing. >> >> (Note that other options could go under

Re: [PATCH 1/1 linux-next] kbuild: add make force=1 for testing

2016-07-26 Thread Michal Marek
Dne 26.7.2016 v 02:05 Andrew Morton napsal(a): > On Sun, 24 Jul 2016 15:28:18 +0200 Fabian Frederick wrote: >> This patch adds ability to do make force=1 for people >> not interested in modules_install in this case but only testing. >> >> (Note that other options could go under ifndef force) > >

Re: [GIT PULL] perf changes for v4.8

2016-07-26 Thread Stephen Rothwell
Hi Ingo, On Tue, 26 Jul 2016 08:38:17 +0200 Ingo Molnar wrote: > > * Stephen Rothwell wrote: > > > > I only affects cross building of the objtool and vdso2c tools (which is > > how I work). The latest version of the perf/core branch in the tip > > tree

Re: [GIT PULL] perf changes for v4.8

2016-07-26 Thread Stephen Rothwell
Hi Ingo, On Tue, 26 Jul 2016 08:38:17 +0200 Ingo Molnar wrote: > > * Stephen Rothwell wrote: > > > > I only affects cross building of the objtool and vdso2c tools (which is > > how I work). The latest version of the perf/core branch in the tip > > tree now has all the fixes, so I assume that

Re: [PATCH] [RFC] Introduce mmap randomization

2016-07-26 Thread Jason Cooper
On Tue, Jul 26, 2016 at 09:06:30PM +, Roberts, William C wrote: > > From: owner-linux...@kvack.org [mailto:owner-linux...@kvack.org] On > > Behalf Of Jason Cooper > > On Tue, Jul 26, 2016 at 08:13:23PM +, Roberts, William C wrote: > > > > > From: Jason Cooper [mailto:ja...@lakedaemon.net]

Re: [PATCH] [RFC] Introduce mmap randomization

2016-07-26 Thread Jason Cooper
On Tue, Jul 26, 2016 at 09:06:30PM +, Roberts, William C wrote: > > From: owner-linux...@kvack.org [mailto:owner-linux...@kvack.org] On > > Behalf Of Jason Cooper > > On Tue, Jul 26, 2016 at 08:13:23PM +, Roberts, William C wrote: > > > > > From: Jason Cooper [mailto:ja...@lakedaemon.net]

Re: [RFC PATCH 0/5] USB Audio Gadget refactoring

2016-07-26 Thread Ruslan Bilovol
On Tue, Jul 26, 2016 at 11:53 AM, Jassi Brar wrote: > On Tue, Jul 26, 2016 at 7:01 AM, Ruslan Bilovol > wrote: >> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch wrote: > On Tue, May 24, 2016 at 2:50 AM, Ruslan

Re: [RFC PATCH 0/5] USB Audio Gadget refactoring

2016-07-26 Thread Ruslan Bilovol
On Tue, Jul 26, 2016 at 11:53 AM, Jassi Brar wrote: > On Tue, Jul 26, 2016 at 7:01 AM, Ruslan Bilovol > wrote: >> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch wrote: > On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol > wrote: >> it may break current usecase for some people >>>

Re: [PATCH resend] clocksource: Defer override invalidation unless clock is unstable

2016-07-26 Thread John Stultz
Sorry for not getting back to you. This has been in my to-look-at list. On Tue, Jul 26, 2016 at 2:24 PM, Kyle Walker wrote: > The clock_select() operation will attempt to use the clocksource override > to apply the desired clocksource when the "clocksource=" boot parameter is

Re: [PATCH resend] clocksource: Defer override invalidation unless clock is unstable

2016-07-26 Thread John Stultz
Sorry for not getting back to you. This has been in my to-look-at list. On Tue, Jul 26, 2016 at 2:24 PM, Kyle Walker wrote: > The clock_select() operation will attempt to use the clocksource override > to apply the desired clocksource when the "clocksource=" boot parameter is > supplied.

Re: [PATCH 3/3] powerpc: Convert fsl_rstcr_restart to a reset handler

2016-07-26 Thread Scott Wood
On Tue, 2016-07-26 at 14:22 -0700, Andrey Smirnov wrote: > On Tue, Jul 26, 2016 at 12:59 AM, Scott Wood wrote: > > > > On Mon, 2016-07-25 at 21:25 -0700, Andrey Smirnov wrote: > > > > > > Convert fsl_rstcr_restart into a function to be registered with > > >

Re: [PATCH 3/3] powerpc: Convert fsl_rstcr_restart to a reset handler

2016-07-26 Thread Scott Wood
On Tue, 2016-07-26 at 14:22 -0700, Andrey Smirnov wrote: > On Tue, Jul 26, 2016 at 12:59 AM, Scott Wood wrote: > > > > On Mon, 2016-07-25 at 21:25 -0700, Andrey Smirnov wrote: > > > > > > Convert fsl_rstcr_restart into a function to be registered with > > > register_reset_handler() API and

[PATCH] qed: Add and use specific logging functions to reduce object size

2016-07-26 Thread Joe Perches
Current DP_ macros generate a lot of code. Using functions with vsprintf extension %pV helps reduce that size. $ size drivers/net/ethernet/qlogic/built-in.o* (x86-64) textdata bss dec hex filename 165161 28470 32812 226443 3748b

[PATCH] qed: Add and use specific logging functions to reduce object size

2016-07-26 Thread Joe Perches
Current DP_ macros generate a lot of code. Using functions with vsprintf extension %pV helps reduce that size. $ size drivers/net/ethernet/qlogic/built-in.o* (x86-64) textdata bss dec hex filename 165161 28470 32812 226443 3748b

Re: [PATCH v2] net: neigh: disallow transition to NUD_STALE if lladdr is unchanged in neigh_update()

2016-07-26 Thread David Miller
From: Chunhui He Date: Tue, 26 Jul 2016 06:16:52 + > NUD_STALE is used when the caller(e.g. arp_process()) can't guarantee > neighbour reachability. If the entry was NUD_VALID and lladdr is unchanged, > the entry state should not be changed. > > Currently the code

[PATCH v2] kbuild: Abort build on bad stack protector flag

2016-07-26 Thread Kees Cook
Before, the stack protector flag was sanity checked before .config had been reprocessed. This meant the build couldn't be aborted early, and only a warning could be emitted followed later by the compiler blowing up with an unknown flag. This has caused a lot of confusion over time, so this splits

[PATCH v2] kbuild: Abort build on bad stack protector flag

2016-07-26 Thread Kees Cook
Before, the stack protector flag was sanity checked before .config had been reprocessed. This meant the build couldn't be aborted early, and only a warning could be emitted followed later by the compiler blowing up with an unknown flag. This has caused a lot of confusion over time, so this splits

Re: [PATCH v2] net: neigh: disallow transition to NUD_STALE if lladdr is unchanged in neigh_update()

2016-07-26 Thread David Miller
From: Chunhui He Date: Tue, 26 Jul 2016 06:16:52 + > NUD_STALE is used when the caller(e.g. arp_process()) can't guarantee > neighbour reachability. If the entry was NUD_VALID and lladdr is unchanged, > the entry state should not be changed. > > Currently the code puts an extra

[PATCH resend] clocksource: Defer override invalidation unless clock is unstable

2016-07-26 Thread Kyle Walker
The clock_select() operation will attempt to use the clocksource override to apply the desired clocksource when the "clocksource=" boot parameter is supplied. However, in the event that "clocksource=tsc" is used on a system where there is a more desireable clocksource available, the boot parameter

[PATCH resend] clocksource: Defer override invalidation unless clock is unstable

2016-07-26 Thread Kyle Walker
The clock_select() operation will attempt to use the clocksource override to apply the desired clocksource when the "clocksource=" boot parameter is supplied. However, in the event that "clocksource=tsc" is used on a system where there is a more desireable clocksource available, the boot parameter

Re: [PATCH] ASoC: dapm: Add a dummy snd_pcm_runtime to avoid NULL pointer access

2016-07-26 Thread Nicolin Chen
On Tue, Jul 26, 2016 at 12:28:40PM -0700, Nicolin Chen wrote: > diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c > index 8698c26..eed15ca 100644 > --- a/sound/soc/soc-dapm.c > +++ b/sound/soc/soc-dapm.c > @@ -3493,6 +3493,7 @@ static int snd_soc_dai_link_event(struct > snd_soc_dapm_widget

Re: [PATCH] ASoC: dapm: Add a dummy snd_pcm_runtime to avoid NULL pointer access

2016-07-26 Thread Nicolin Chen
On Tue, Jul 26, 2016 at 12:28:40PM -0700, Nicolin Chen wrote: > diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c > index 8698c26..eed15ca 100644 > --- a/sound/soc/soc-dapm.c > +++ b/sound/soc/soc-dapm.c > @@ -3493,6 +3493,7 @@ static int snd_soc_dai_link_event(struct > snd_soc_dapm_widget

Re: [PATCH] scripts/recordmcount: improve EM_METAG define checks

2016-07-26 Thread Steven Rostedt
On Wed, 13 Jul 2016 14:37:46 +0100 Ross Burton wrote: > Current glibc (as of c10f90, soon to be 2.24) has an elf.h which defines > EM_METAG but doesn't also define R_METAG_ADDR32 and _NONE. This results in > recordmcount not defining any of the META symbols, and the

Re: [PATCH] scripts/recordmcount: improve EM_METAG define checks

2016-07-26 Thread Steven Rostedt
On Wed, 13 Jul 2016 14:37:46 +0100 Ross Burton wrote: > Current glibc (as of c10f90, soon to be 2.24) has an elf.h which defines > EM_METAG but doesn't also define R_METAG_ADDR32 and _NONE. This results in > recordmcount not defining any of the META symbols, and the compile failing. > > Handle

Re: [RFC PATCH 0/5] USB Audio Gadget refactoring

2016-07-26 Thread Ruslan Bilovol
On Tue, Jul 26, 2016 at 11:06 AM, Clemens Ladisch wrote: > Ruslan Bilovol wrote: >> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch wrote: > On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol > wrote: >> it may break

Re: [RESEND][PATCH] kbuild: Abort build on bad stack protector flag

2016-07-26 Thread Kees Cook
On Tue, Jul 26, 2016 at 2:06 PM, Michal Marek wrote: > On Tue, Jul 12, 2016 at 03:30:43PM -0700, Kees Cook wrote: >> Before, the stack protector flag was sanity checked before .config had >> been reprocessed. This meant the build couldn't be aborted early, and >> only a warning

Re: [RFC PATCH 0/5] USB Audio Gadget refactoring

2016-07-26 Thread Ruslan Bilovol
On Tue, Jul 26, 2016 at 11:06 AM, Clemens Ladisch wrote: > Ruslan Bilovol wrote: >> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch wrote: > On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol > wrote: >> it may break current usecase for some people >>> >>> And what are the benefits

Re: [RESEND][PATCH] kbuild: Abort build on bad stack protector flag

2016-07-26 Thread Kees Cook
On Tue, Jul 26, 2016 at 2:06 PM, Michal Marek wrote: > On Tue, Jul 12, 2016 at 03:30:43PM -0700, Kees Cook wrote: >> Before, the stack protector flag was sanity checked before .config had >> been reprocessed. This meant the build couldn't be aborted early, and >> only a warning could be emitted

Re: [PATCH 3/3] powerpc: Convert fsl_rstcr_restart to a reset handler

2016-07-26 Thread Andrey Smirnov
On Tue, Jul 26, 2016 at 12:59 AM, Scott Wood wrote: > On Mon, 2016-07-25 at 21:25 -0700, Andrey Smirnov wrote: >> Convert fsl_rstcr_restart into a function to be registered with >> register_reset_handler() API and introduce fls_rstcr_restart_register() >> function that can be

Re: [PATCH 3/3] powerpc: Convert fsl_rstcr_restart to a reset handler

2016-07-26 Thread Andrey Smirnov
On Tue, Jul 26, 2016 at 12:59 AM, Scott Wood wrote: > On Mon, 2016-07-25 at 21:25 -0700, Andrey Smirnov wrote: >> Convert fsl_rstcr_restart into a function to be registered with >> register_reset_handler() API and introduce fls_rstcr_restart_register() >> function that can be added as an initcall

Re: [LKP] More information please. Re: [fs] 54cc07a761: BUG: kernel test crashed

2016-07-26 Thread Dave Jones
On Tue, Jul 26, 2016 at 02:50:58PM -0500, Eric W. Biederman wrote: > > Yes that's the right directions to follow. We'll make the reports more > > understandable and the test/bisects more reliable. > > Thanks. Does trinity have a random seed it can export/import to rerun > the same tests?

Re: [LKP] More information please. Re: [fs] 54cc07a761: BUG: kernel test crashed

2016-07-26 Thread Dave Jones
On Tue, Jul 26, 2016 at 02:50:58PM -0500, Eric W. Biederman wrote: > > Yes that's the right directions to follow. We'll make the reports more > > understandable and the test/bisects more reliable. > > Thanks. Does trinity have a random seed it can export/import to rerun > the same tests?

Re: Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk

2016-07-26 Thread Thomas Garnier
I am sorry, there has been parallel work between KASLR memory randomization and hibernation support. That's why hibernation was not tested, it was not supported when the feature was created. Communication will be better next time. I will work on identifying the problem and pushing a fix. Thanks

Re: Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk

2016-07-26 Thread Thomas Garnier
I am sorry, there has been parallel work between KASLR memory randomization and hibernation support. That's why hibernation was not tested, it was not supported when the feature was created. Communication will be better next time. I will work on identifying the problem and pushing a fix. Thanks

<    1   2   3   4   5   6   7   8   9   10   >