Re: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation

On Fri, Sep 1, 2017 at 9:38 PM, Peter Zijlstra wrote: > On Fri, Sep 01, 2017 at 07:16:29PM +0900, Byungchul Park wrote: > >> It would be gone _only_ at the time the history overrun, and then it >> will be built again. So, you are wrong. s/it will be built again/the

Re: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation

On Fri, Sep 1, 2017 at 9:38 PM, Peter Zijlstra wrote: > On Fri, Sep 01, 2017 at 07:16:29PM +0900, Byungchul Park wrote: > >> It would be gone _only_ at the time the history overrun, and then it >> will be built again. So, you are wrong. s/it will be built again/the acquisition will be added into

Re: [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control

On 01.08.2017 15:23, Philippe CORNU wrote: > Based on patch "Convert drivers to explicit reset API" from Philipp Zabel > > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting > reset lines") started to transition the reset control request API calls > to explicitly state

Re: [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control

On 01.08.2017 15:23, Philippe CORNU wrote: > Based on patch "Convert drivers to explicit reset API" from Philipp Zabel > > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting > reset lines") started to transition the reset control request API calls > to explicitly state

[PATCH] qlcnic: remove redundant zero check on retries counter

From: Colin Ian King At the end of the do while loop the integer counter retries will always be zero and so the subsequent check to see if it is zero is always true and therefore redundant. Remove the redundant check and always return -EIO on this return path. Also

[PATCH] qlcnic: remove redundant zero check on retries counter

From: Colin Ian King At the end of the do while loop the integer counter retries will always be zero and so the subsequent check to see if it is zero is always true and therefore redundant. Remove the redundant check and always return -EIO on this return path. Also unbreak the literal string

[PATCH v2 27/27] media: dst_ca: remove CA_SET_DESCR boilerplate

This ioctl is not implemented at dst_ca driver. There's just a boilerplate code there. Remove it, as it is unlikely that anyone would implement it those days. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/bt8xx/dst_ca.c | 17 - 1 file

[PATCH v2 27/27] media: dst_ca: remove CA_SET_DESCR boilerplate

This ioctl is not implemented at dst_ca driver. There's just a boilerplate code there. Remove it, as it is unlikely that anyone would implement it those days. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/bt8xx/dst_ca.c | 17 - 1 file changed, 17 deletions(-) diff

[PATCH v2 03/27] media: dvb/intro: use the term Digital TV to refer to the system

On several places at the introduction, a digital TV board and its kernel support is called as DVB. The reason is simple: by the time the document was written, there were no other digital TV standards :-) Modernize the specs by referring to them as Digital TV. Signed-off-by: Mauro Carvalho Chehab

[PATCH v2 03/27] media: dvb/intro: use the term Digital TV to refer to the system

On several places at the introduction, a digital TV board and its kernel support is called as DVB. The reason is simple: by the time the document was written, there were no other digital TV standards :-) Modernize the specs by referring to them as Digital TV. Signed-off-by: Mauro Carvalho Chehab

[PATCH -v2 13/18] sched/fair: Propagate an effective runnable_load_avg

The load balancer uses runnable_load_avg as load indicator. For !cgroup this is: runnable_load_avg = \Sum se->avg.load_avg ; where se->on_rq That is, a direct sum of all runnable tasks on that runqueue. As opposed to load_avg, which is a sum of all tasks on the runqueue, which includes a

[PATCH -v2 13/18] sched/fair: Propagate an effective runnable_load_avg

The load balancer uses runnable_load_avg as load indicator. For !cgroup this is: runnable_load_avg = \Sum se->avg.load_avg ; where se->on_rq That is, a direct sum of all runnable tasks on that runqueue. As opposed to load_avg, which is a sum of all tasks on the runqueue, which includes a

[PATCH -v2 14/18] sched/fair: Synchonous PELT detach on load-balance migrate

Vincent wondered why his self migrating task had a roughly 50% dip in load_avg when landing on the new CPU. This is because we uncondionally take the asynchronous detatch_entity route, which can lead to the attach on the new CPU still seeing the old CPU's contribution to tg->load_avg, effectively

[PATCH -v2 14/18] sched/fair: Synchonous PELT detach on load-balance migrate

Vincent wondered why his self migrating task had a roughly 50% dip in load_avg when landing on the new CPU. This is because we uncondionally take the asynchronous detatch_entity route, which can lead to the attach on the new CPU still seeing the old CPU's contribution to tg->load_avg, effectively

[PATCH -v2 05/18] sched/fair: Change update_load_avg() arguments

Most call sites of update_load_avg() already have cfs_rq_of(se) available, pass it down instead of recomputing it. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) ---

[PATCH -v2 05/18] sched/fair: Change update_load_avg() arguments

Most call sites of update_load_avg() already have cfs_rq_of(se) available, pass it down instead of recomputing it. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) --- a/kernel/sched/fair.c

[PATCH -v2 09/18] sched/fair: More accurate reweight_entity()

When a (group) entity changes it's weight we should instantly change its load_avg and propagate that change into the sums it is part of. Because we use these values to predict future behaviour and are not interested in its historical value. Without this change, the change in load would need to

[PATCH -v2 09/18] sched/fair: More accurate reweight_entity()

When a (group) entity changes it's weight we should instantly change its load_avg and propagate that change into the sums it is part of. Because we use these values to predict future behaviour and are not interested in its historical value. Without this change, the change in load would need to

[PATCH -v2 08/18] sched/fair: Introduce {en,de}queue_load_avg()

Analogous to the existing {en,de}queue_runnable_load_avg() add helpers for {en,de}queue_load_avg(). More users will follow. Includes some code movement to avoid fwd declarations. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 156

[PATCH -v2 08/18] sched/fair: Introduce {en,de}queue_load_avg()

Analogous to the existing {en,de}queue_runnable_load_avg() add helpers for {en,de}queue_load_avg(). More users will follow. Includes some code movement to avoid fwd declarations. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 156

[PATCH -v2 04/18] sched/fair: Remove se->load.weight from se->avg.load_sum

Remove the load from the load_sum for sched_entities, basically turning load_sum into runnable_sum. This prepares for better reweighting of group entities. Since we now have different rules for computing load_avg, split ___update_load_avg() into two parts, ___update_load_sum() and

[PATCH -v2 04/18] sched/fair: Remove se->load.weight from se->avg.load_sum

Remove the load from the load_sum for sched_entities, basically turning load_sum into runnable_sum. This prepares for better reweighting of group entities. Since we now have different rules for computing load_avg, split ___update_load_avg() into two parts, ___update_load_sum() and

[PATCH -v2 01/18] sched/fair: Clean up calc_cfs_shares()

For consistencies sake, we should have only a single reading of tg->shares. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) --- a/kernel/sched/fair.c +++

[PATCH -v2 01/18] sched/fair: Clean up calc_cfs_shares()

For consistencies sake, we should have only a single reading of tg->shares. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2633,9

[PATCH -v2 12/18] sched/fair: Rewrite PELT migration propagation

When an entity migrates in (or out) of a runqueue, we need to add (or remove) its contribution from the entire PELT hierarchy, because even non-runnable entities are included in the load average sums. In order to do this we have some propagation logic that updates the PELT tree, however the way

[PATCH -v2 12/18] sched/fair: Rewrite PELT migration propagation

When an entity migrates in (or out) of a runqueue, we need to add (or remove) its contribution from the entire PELT hierarchy, because even non-runnable entities are included in the load average sums. In order to do this we have some propagation logic that updates the PELT tree, however the way

[PATCH -v2 18/18] sched/fair: Update calc_group_*() comments

I had a wee bit of trouble recalling how the calc_group_runnable() stuff worked.. add hopefully better comments. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 68 ++-- 1 file changed, 45 insertions(+), 23

[PATCH -v2 18/18] sched/fair: Update calc_group_*() comments

I had a wee bit of trouble recalling how the calc_group_runnable() stuff worked.. add hopefully better comments. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 68 ++-- 1 file changed, 45 insertions(+), 23 deletions(-) ---

[PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares()

Explain the magic equation in calc_cfs_shares() a bit better. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 61 1 file changed, 61 insertions(+) --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@

[PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares()

Explain the magic equation in calc_cfs_shares() a bit better. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 61 1 file changed, 61 insertions(+) --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2707,6 +2707,67 @@

[PATCH -v2 07/18] sched/fair: Rename {en,de}queue_entity_load_avg()

Since they're now purely about runnable_load, rename them. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3561,7 +3561,7 @@ static

[PATCH -v2 07/18] sched/fair: Rename {en,de}queue_entity_load_avg()

Since they're now purely about runnable_load, rename them. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3561,7 +3561,7 @@ static inline void

[PATCH -v2 17/18] sched/fair: Calculate runnable_weight slightly differently

From: Josef Bacik Our runnable_weight currently looks like this runnable_weight = shares * runnable_load_avg / load_avg The goal is to scale the runnable weight for the group based on its runnable to load_avg ratio. The problem with this is it biases us towards tasks that never

Re: [PATCH v2 5/5] net: mdio-mux: fix unbalanced put_device

On Fri, Sep 01, 2017 at 01:56:04PM +0200, Corentin Labbe wrote: > mdio_mux_uninit() call put_device (unconditionally) because of > of_mdio_find_bus() in mdio_mux_init. > But of_mdio_find_bus is only called if mux_bus is empty. > If mux_bus is set, mdio_mux_uninit will print a "refcount_t:

Re: [PATCH v2 5/5] net: mdio-mux: fix unbalanced put_device

On Fri, Sep 01, 2017 at 01:56:04PM +0200, Corentin Labbe wrote: > mdio_mux_uninit() call put_device (unconditionally) because of > of_mdio_find_bus() in mdio_mux_init. > But of_mdio_find_bus is only called if mux_bus is empty. > If mux_bus is set, mdio_mux_uninit will print a "refcount_t:

[PATCH -v2 17/18] sched/fair: Calculate runnable_weight slightly differently

From: Josef Bacik Our runnable_weight currently looks like this runnable_weight = shares * runnable_load_avg / load_avg The goal is to scale the runnable weight for the group based on its runnable to load_avg ratio. The problem with this is it biases us towards tasks that never go to sleep.

Re: [PATCH v2 3/5] net: mdio-mux: printing driver version is useless

On Fri, Sep 01, 2017 at 01:56:02PM +0200, Corentin Labbe wrote: > Remove the driver version information because this information > is not useful in an upstream kernel driver. > > Signed-off-by: Corentin Labbe Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2 3/5] net: mdio-mux: printing driver version is useless

On Fri, Sep 01, 2017 at 01:56:02PM +0200, Corentin Labbe wrote: > Remove the driver version information because this information > is not useful in an upstream kernel driver. > > Signed-off-by: Corentin Labbe Reviewed-by: Andrew Lunn Andrew

[PATCH -v2 03/18] sched/fair: Cure calc_cfs_shares() vs reweight_entity()

Vincent reported that when running in a cgroup, his root cfs_rq->avg.load_avg dropped to 0 on task idle. This is because reweight_entity() will now immediately propagate the weight change of the group entity to its cfs_rq, and as it happens, our approxmation (5) for calc_cfs_shares() results in 0

[PATCH -v2 03/18] sched/fair: Cure calc_cfs_shares() vs reweight_entity()

Vincent reported that when running in a cgroup, his root cfs_rq->avg.load_avg dropped to 0 on task idle. This is because reweight_entity() will now immediately propagate the weight change of the group entity to its cfs_rq, and as it happens, our approxmation (5) for calc_cfs_shares() results in 0

[PATCH -v2 00/18] sched/fair: A bit of a cgroup/PELT overhaul

Hi all, New this time is that Josef identified and fixed a problem he had with it. He also provided many compile fixes. Meanwhile I managed to reflow the patches so that the whole now looks like a normal patch series. Other than that, it should still very much be what it was before.. From the

[PATCH -v2 00/18] sched/fair: A bit of a cgroup/PELT overhaul

Hi all, New this time is that Josef identified and fixed a problem he had with it. He also provided many compile fixes. Meanwhile I managed to reflow the patches so that the whole now looks like a normal patch series. Other than that, it should still very much be what it was before.. From the

[PATCH -v2 15/18] sched/fair: Align PELT windows between cfs_rq and its se

The PELT _sum values are a saw-tooth function, dropping on the decay edge and then growing back up again during the window. When these window-edges are not aligned between cfs_rq and se, we can have the situation where, for example, on dequeue, the se decays first. Its _sum values will be

[PATCH -v2 15/18] sched/fair: Align PELT windows between cfs_rq and its se

The PELT _sum values are a saw-tooth function, dropping on the decay edge and then growing back up again during the window. When these window-edges are not aligned between cfs_rq and se, we can have the situation where, for example, on dequeue, the se decays first. Its _sum values will be

[PATCH -v2 11/18] sched/fair: Rewrite cfs_rq->removed_*avg

Since on wakeup migration we don't hold the rq->lock for the old CPU we cannot update its state. Instead we add the removed 'load' to an atomic variable and have the next update on that CPU collect and process it. Currently we have 2 atomic variables; which already have the issue that they can be

[PATCH -v2 11/18] sched/fair: Rewrite cfs_rq->removed_*avg

Since on wakeup migration we don't hold the rq->lock for the old CPU we cannot update its state. Instead we add the removed 'load' to an atomic variable and have the next update on that CPU collect and process it. Currently we have 2 atomic variables; which already have the issue that they can be

[PATCH -v2 16/18] sched/fair: More accurate async detach

The problem with the overestimate is that it will subtract too big a value from the load_sum, thereby pushing it down further than it ought to go. Since runnable_load_avg is not subject to a similar 'force', this results in the occasional 'runnable_load > load' situation. Signed-off-by: Peter

[PATCH -v2 16/18] sched/fair: More accurate async detach

The problem with the overestimate is that it will subtract too big a value from the load_sum, thereby pushing it down further than it ought to go. Since runnable_load_avg is not subject to a similar 'force', this results in the occasional 'runnable_load > load' situation. Signed-off-by: Peter

Re: [PATCH 14/15] futex: convert futex_pi_state.refcount to refcount_t

On Fri, Sep 01, 2017 at 01:24:16PM +, Reshetova, Elena wrote: > > > On Fri, Sep 01, 2017 at 11:05:33AM +, Reshetova, Elena wrote: > > > Actually on the second thought: does the above memory ordering differences > > > really apply when we have ARCH_HAS_REFCOUNT? To me it looks like the

Re: [PATCH 14/15] futex: convert futex_pi_state.refcount to refcount_t

On Fri, Sep 01, 2017 at 01:24:16PM +, Reshetova, Elena wrote: > > > On Fri, Sep 01, 2017 at 11:05:33AM +, Reshetova, Elena wrote: > > > Actually on the second thought: does the above memory ordering differences > > > really apply when we have ARCH_HAS_REFCOUNT? To me it looks like the

Re: [PATCH] drm/vblank: Fix delta_ns to an absolute value

On Fri, Sep 01, 2017 at 04:07:16PM +0900, Hoegeun Kwon wrote: > If scanout started, we should reduce etime by delta_ns. But delta_ns > is negative if scanout has not started. If delta_ns is negative, > subtraction of delta_ns from etime increases etime. This is wrong, the > etime should not be

Re: [PATCH] drm/vblank: Fix delta_ns to an absolute value

On Fri, Sep 01, 2017 at 04:07:16PM +0900, Hoegeun Kwon wrote: > If scanout started, we should reduce etime by delta_ns. But delta_ns > is negative if scanout has not started. If delta_ns is negative, > subtraction of delta_ns from etime increases etime. This is wrong, the > etime should not be

Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3

On Fri, Sep 01, 2017 at 05:04:54AM +0200, Stefan Bruens wrote: > On Donnerstag, 31. August 2017 16:51:35 CEST Maxime Ripard wrote: > > Hi, > > > > On Thu, Aug 31, 2017 at 01:36:07AM +0200, Stefan Brüns wrote: > > > +/* Between SoC generations, there are some significant differences: > > > + * -

Re: [PATCH net-next v2 4/4] Documentation/bindings: net: marvell-pp2: add the link interrupt

On Fri, Sep 01, 2017 at 11:04:55AM +0200, Antoine Tenart wrote: > A link interrupt can be described. Document this valid interrupt name. > > Signed-off-by: Antoine Tenart > Tested-by: Marcin Wojtas Reviewed-by: Andrew Lunn

Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3

On Fri, Sep 01, 2017 at 05:04:54AM +0200, Stefan Bruens wrote: > On Donnerstag, 31. August 2017 16:51:35 CEST Maxime Ripard wrote: > > Hi, > > > > On Thu, Aug 31, 2017 at 01:36:07AM +0200, Stefan Brüns wrote: > > > +/* Between SoC generations, there are some significant differences: > > > + * -

Re: [PATCH net-next v2 4/4] Documentation/bindings: net: marvell-pp2: add the link interrupt

On Fri, Sep 01, 2017 at 11:04:55AM +0200, Antoine Tenart wrote: > A link interrupt can be described. Document this valid interrupt name. > > Signed-off-by: Antoine Tenart > Tested-by: Marcin Wojtas Reviewed-by: Andrew Lunn Andrew

[PATCH -v2 06/18] sched/fair: Move enqueue migrate handling

Move the entity migrate handling from enqueue_entity_load_avg() to update_load_avg(). This has two benefits: - {en,de}queue_entity_load_avg() will become purely about managing runnable_load - we can avoid a double update_tg_load_avg() and reduce pressure on the global tg->shares

[PATCH -v2 06/18] sched/fair: Move enqueue migrate handling

Move the entity migrate handling from enqueue_entity_load_avg() to update_load_avg(). This has two benefits: - {en,de}queue_entity_load_avg() will become purely about managing runnable_load - we can avoid a double update_tg_load_avg() and reduce pressure on the global tg->shares

[PATCH -v2 10/18] sched/fair: Use reweight_entity() for set_user_nice()

From: Vincent Guittot Now that we directly change load_avg and propagate that change into the sums, sys_nice() and co should do the same, otherwise its possible to confuse load accounting when we migrate near the weight change. [peterz: Changelog, call condition]

[PATCH -v2 10/18] sched/fair: Use reweight_entity() for set_user_nice()

From: Vincent Guittot Now that we directly change load_avg and propagate that change into the sums, sys_nice() and co should do the same, otherwise its possible to confuse load accounting when we migrate near the weight change. [peterz: Changelog, call condition] [josef: fixed runnable and !SMP

[PATCH v2 15/27] media: dmx.h: get rid of GET_DMX_EVENT

This seems to be a pure fictional API :-) It only exists at the DVB book, with no code implemeting it. So, just get rid of it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/dvb/dmx-get-event.rst | 60 --

[PATCH v2 15/27] media: dmx.h: get rid of GET_DMX_EVENT

This seems to be a pure fictional API :-) It only exists at the DVB book, with no code implemeting it. So, just get rid of it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/dvb/dmx-get-event.rst | 60 -- Documentation/media/uapi/dvb/dmx_fcalls.rst

Re: [PATCH net-next v2 2/4] net: mvpp2: make the phy optional

On Fri, Sep 01, 2017 at 11:04:53AM +0200, Antoine Tenart wrote: > There is not necessarily a PHY between the GoP and the physical port. > However, the driver currently makes the "phy" property mandatory, > contrary to what is stated in the device tree bindings. This patch makes > the PHY optional,

Re: [PATCH net-next v2 2/4] net: mvpp2: make the phy optional

On Fri, Sep 01, 2017 at 11:04:53AM +0200, Antoine Tenart wrote: > There is not necessarily a PHY between the GoP and the physical port. > However, the driver currently makes the "phy" property mandatory, > contrary to what is stated in the device tree bindings. This patch makes > the PHY optional,

[PATCH v2 17/27] media: net.rst: Fix the level of a section of the net chapter

Due to a mistake, the DVB net chapter was actually broken into two different chapters. Fix it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/dvb/net.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/media/uapi/dvb/net.rst

[PATCH v2 17/27] media: net.rst: Fix the level of a section of the net chapter

Due to a mistake, the DVB net chapter was actually broken into two different chapters. Fix it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/dvb/net.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/media/uapi/dvb/net.rst

Re: [PATCH net-next v2 1/4] net: mvpp2: take advantage of the is_rgmii helper

On Fri, Sep 01, 2017 at 11:04:52AM +0200, Antoine Tenart wrote: > Convert all RGMII checks to use the phy_interface_mode_is_rgmii() > helper. This is a cosmetic patch. > > Signed-off-by: Antoine Tenart Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v2 1/4] net: mvpp2: take advantage of the is_rgmii helper

On Fri, Sep 01, 2017 at 11:04:52AM +0200, Antoine Tenart wrote: > Convert all RGMII checks to use the phy_interface_mode_is_rgmii() > helper. This is a cosmetic patch. > > Signed-off-by: Antoine Tenart Reviewed-by: Andrew Lunn Andrew

[PATCH v2 11/27] media: fe_property_parameters.rst: better document bandwidth

Use a table to document the supported bandwidths. That makes it clearer to readers. Signed-off-by: Mauro Carvalho Chehab --- .../media/uapi/dvb/fe_property_parameters.rst | 44 +- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git

[PATCH v2 11/27] media: fe_property_parameters.rst: better document bandwidth

Use a table to document the supported bandwidths. That makes it clearer to readers. Signed-off-by: Mauro Carvalho Chehab --- .../media/uapi/dvb/fe_property_parameters.rst | 44 +- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git

[PATCH v2 10/27] media: fe_property_parameters.rst: better define properties usage

Several frontend properties are specific to a subset of the delivery systems. Make it clearer when describing each property. Signed-off-by: Mauro Carvalho Chehab --- .../media/uapi/dvb/fe_property_parameters.rst | 82 -- 1 file changed, 75

[PATCH v2 10/27] media: fe_property_parameters.rst: better define properties usage

Several frontend properties are specific to a subset of the delivery systems. Make it clearer when describing each property. Signed-off-by: Mauro Carvalho Chehab --- .../media/uapi/dvb/fe_property_parameters.rst | 82 -- 1 file changed, 75 insertions(+), 7 deletions(-)

[PATCH v2 12/27] media: dmx.h: get rid of unused DMX_KERNEL_CLIENT

There's a flag defined for Digital TV demux that is not used anywhere, called DMX_KERNEL_CLIENT. Get rid of it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/dmx.h.rst.exceptions | 1 - Documentation/media/uapi/dvb/dmx_types.rst | 1 -

[PATCH v2 12/27] media: dmx.h: get rid of unused DMX_KERNEL_CLIENT

There's a flag defined for Digital TV demux that is not used anywhere, called DMX_KERNEL_CLIENT. Get rid of it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/dmx.h.rst.exceptions | 1 - Documentation/media/uapi/dvb/dmx_types.rst | 1 - include/uapi/linux/dvb/dmx.h

[PATCH v2 23/27] media: ca-get-slot-info.rst: document this ioctl

Instead of a generic boilerplate, fill it with relevant information about this ioctl. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/dvb/ca-get-slot-info.rst | 98 +++ 1 file changed, 11 insertions(+), 87 deletions(-) diff --git

[PATCH v2 23/27] media: ca-get-slot-info.rst: document this ioctl

Instead of a generic boilerplate, fill it with relevant information about this ioctl. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/dvb/ca-get-slot-info.rst | 98 +++ 1 file changed, 11 insertions(+), 87 deletions(-) diff --git

Re: powerpc/mm: Use seq_putc() in two functions

On Sun, 2017-05-07 at 14:38:36 UTC, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 7 May 2017 16:32:04 +0200 > > Two single characters (line breaks) should be put into a sequence. > Thus use the corresponding function "seq_putc". > > This issue was

Re: powerpc/mm: Use seq_putc() in two functions

On Sun, 2017-05-07 at 14:38:36 UTC, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 7 May 2017 16:32:04 +0200 > > Two single characters (line breaks) should be put into a sequence. > Thus use the corresponding function "seq_putc". > > This issue was detected by using the Coccinelle

[PATCH v2 18/27] media: ca.h: get rid of CA_SET_PID

This ioctl seems to be some attempt to support a feature at the bt8xx dst_ca driver. Yet, as said there, it "needs more work". Right now, the code there is just a boilerplate. At the end of the day, no driver uses this ioctl, nor it is documented anywhere (except for "needs more work"). So, get

[PATCH v2 18/27] media: ca.h: get rid of CA_SET_PID

This ioctl seems to be some attempt to support a feature at the bt8xx dst_ca driver. Yet, as said there, it "needs more work". Right now, the code there is just a boilerplate. At the end of the day, no driver uses this ioctl, nor it is documented anywhere (except for "needs more work"). So, get

[PATCH v2 07/27] media: dvb/frontend.h: move out a private internal structure

struct dtv_cmds_h is just an ancillary struct used by the dvb_frontend.c to internally store frontend commands. It doesn't belong to the userspace header, nor it is used anywhere, except inside the DVB core. So, remove it from the header. Signed-off-by: Mauro Carvalho Chehab

[PATCH v2 07/27] media: dvb/frontend.h: move out a private internal structure

struct dtv_cmds_h is just an ancillary struct used by the dvb_frontend.c to internally store frontend commands. It doesn't belong to the userspace header, nor it is used anywhere, except inside the DVB core. So, remove it from the header. Signed-off-by: Mauro Carvalho Chehab ---

Re: macintosh: Convert to using %pOF instead of full_name

On Tue, 2017-07-18 at 21:43:12 UTC, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring > Cc:

Re: macintosh: Convert to using %pOF instead of full_name

On Tue, 2017-07-18 at 21:43:12 UTC, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring > Cc: Benjamin Herrenschmidt

[PATCH v2 14/27] media: dmx.h: get rid of DMX_SET_SOURCE

No driver uses this ioctl, nor it is documented anywhere. So, get rid of it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/dmx.h.rst.exceptions| 13 Documentation/media/uapi/dvb/dmx-set-source.rst | 44 -

[PATCH v2 14/27] media: dmx.h: get rid of DMX_SET_SOURCE

No driver uses this ioctl, nor it is documented anywhere. So, get rid of it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/dmx.h.rst.exceptions| 13 Documentation/media/uapi/dvb/dmx-set-source.rst | 44 -

[PATCH v2 22/27] media: ca-get-cap.rst: document this ioctl

Instead of a generic boilerplate, fill it with relevant information about this ioctl. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/dvb/ca-get-cap.rst | 36 - 1 file changed, 5 insertions(+), 31 deletions(-) diff --git

Re: powerpc/eeh: Delete an error message for a failed memory allocation in two functions

On Fri, 2017-08-04 at 14:46:51 UTC, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 4 Aug 2017 16:37:56 +0200 > > Omit an extra message for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. >

[PATCH v2 22/27] media: ca-get-cap.rst: document this ioctl

Instead of a generic boilerplate, fill it with relevant information about this ioctl. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/dvb/ca-get-cap.rst | 36 - 1 file changed, 5 insertions(+), 31 deletions(-) diff --git

Re: powerpc/eeh: Delete an error message for a failed memory allocation in two functions

On Fri, 2017-08-04 at 14:46:51 UTC, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 4 Aug 2017 16:37:56 +0200 > > Omit an extra message for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > > Link: >

Re: [PATCH v3 2/3] drm/bridge/synopsys: dsi: Register list clean up

On 01.08.2017 15:23, Philippe CORNU wrote: > This patch cleans up the Synopsys mipi dsi register list: > - rename registers according to the Synopsys documentation > (1.30 & 1.31) > - fix typos > - re-order registers for a better coherency > > Signed-off-by: Philippe CORNU

Re: [08/15] powerpc/iommu: use permission-specific DEVICE_ATTR variants

On Sat, 2016-10-29 at 19:37:02 UTC, Julia Lawall wrote: > Use DEVICE_ATTR_RW for read-write attributes. This simplifies the > source code, improves readbility, and reduces the chance of > inconsistencies. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/)

Re: [PATCH v3 2/3] drm/bridge/synopsys: dsi: Register list clean up

On 01.08.2017 15:23, Philippe CORNU wrote: > This patch cleans up the Synopsys mipi dsi register list: > - rename registers according to the Synopsys documentation > (1.30 & 1.31) > - fix typos > - re-order registers for a better coherency > > Signed-off-by: Philippe CORNU > Reviewed-by:

Re: [08/15] powerpc/iommu: use permission-specific DEVICE_ATTR variants

On Sat, 2016-10-29 at 19:37:02 UTC, Julia Lawall wrote: > Use DEVICE_ATTR_RW for read-write attributes. This simplifies the > source code, improves readbility, and reduces the chance of > inconsistencies. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/)

Re: powerpc/macintosh: constify wf_sensor_ops structures

On Wed, 2017-08-02 at 21:01:45 UTC, Julia Lawall wrote: > The wf_sensor_ops structures are only stored in the ops field of a > wf_sensor structure, which is declared as const. Thus the > wf_sensor_ops structures themselves can be const. > > Done with the help of Coccinelle. > > // > @r disable

[PATCH v2 06/27] media: dvb/intro: adjust the notices about optional hardware

Both CA and decoders are optional. Also, the presence or absence has nothing to do on being a PCI card or not. Nowadays, most hardware leaves the decoders to either the GPU or to some ISP inside the SoC, instead of implementing it inside the Digital TV part of the device. So, change the wording

Re: powerpc/macintosh: constify wf_sensor_ops structures

On Wed, 2017-08-02 at 21:01:45 UTC, Julia Lawall wrote: > The wf_sensor_ops structures are only stored in the ops field of a > wf_sensor structure, which is declared as const. Thus the > wf_sensor_ops structures themselves can be const. > > Done with the help of Coccinelle. > > // > @r disable

[PATCH v2 06/27] media: dvb/intro: adjust the notices about optional hardware

Both CA and decoders are optional. Also, the presence or absence has nothing to do on being a PCI card or not. Nowadays, most hardware leaves the decoders to either the GPU or to some ISP inside the SoC, instead of implementing it inside the Digital TV part of the device. So, change the wording

[PATCH v2 16/27] media: dmx.h: add kernel-doc markups and use it at Documentation/

The demux documentation is pretty poor nowadays: most of the structs and enums aren't documented at all. Add proper kernel-doc markups for them and use it. Now, the demux API is fully documented :-) Signed-off-by: Mauro Carvalho Chehab ---

[PATCH v2 16/27] media: dmx.h: add kernel-doc markups and use it at Documentation/

The demux documentation is pretty poor nowadays: most of the structs and enums aren't documented at all. Add proper kernel-doc markups for them and use it. Now, the demux API is fully documented :-) Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/dmx.h.rst.exceptions | 5 +

<    3   4   5   6   7   8   9   10   11   12   >