[PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings

2017-09-20 Thread Chaotian Jing
Change the comptiable for support of multi-platform Add description for reg Add description for source_cg Add description for mediatek,latch-ck Note that source_cg and mediatek,latch-ck are optional for some projects, eg, MT2701 do not have source_cg, and MT2712 do not need mediatek,latch-ck

Re: [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob

2017-09-20 Thread 严海双
> On 2017年9月21日, at 上午5:22, David Miller wrote: > > From: Haishuang Yan > Date: Tue, 19 Sep 2017 17:38:14 +0800 > >> -if ((sysctl_tcp_fastopen & TFO_SERVER_WO_SOCKOPT1) && >> -(sysctl_tcp_fastopen & TFO_SERVER_ENABLE) && >> +tcp_fastopen =

Re: 4.13 breaks suspend to ram wakeup

2017-09-20 Thread Norbert Preining
Hi Ming, > So could you share us how often it is triggered? and what is your underlying > disk behind dm-crypt? It is triggered *every* time I suspend. Underlying disk is scsi 1:0:0:0: Direct-Access ATA WDC WD10JPVX-08J 1A07 PQ: 0 ANSI: 5 I checked the values in

Re: [PATCH 2/5] nvmem: mtk-efuse: use stack for nvmem_config instead of malloc'ing it

2017-09-20 Thread Masahiro Yamada
Hi Sean, 2017-09-21 1:32 GMT+09:00 Sean Wang : > Hi, Masahiro > > For maintainability, I felt it's better if we use the same way to > register nvmem as that most drivers does under nvmem usually using > static structure. Otherwise, they should also be changed to use the > one-time data in stack

RE: [PATCH 1/7] PM / OPP: Add platform specific set_clk function

2017-09-20 Thread A.s. Dong
> -Original Message- > From: Viresh Kumar [mailto:viresh.ku...@linaro.org] > Sent: Thursday, September 21, 2017 4:31 AM > To: Dong Aisheng > Cc: A.s. Dong; linux...@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; sb...@codeaurora.org; >

Re: [RFC RESEND 3/3] arm: dts: add Hi3521A dts

2017-09-20 Thread Marty E. Plummer
On Thu, Sep 21, 2017 at 01:08:39AM +, Rob Herring wrote: > On Wed, Sep 20, 2017 at 6:04 PM, Marty E. Plummer > wrote: > > On Wed, Sep 20, 2017 at 08:53:03PM +, Rob Herring wrote: > >> On Sun, Sep 17, 2017 at 03:23:27AM -0500, Marty E. Plummer wrote: > >> > Add hi3521a.dtsi and

Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning

2017-09-20 Thread Joe Perches
On Thu, 2017-09-21 at 09:27 +0900, Sergey Senozhatsky wrote: > On (09/20/17 10:38), Joe Perches wrote: > > On Thu, 2017-09-21 at 01:29 +0900, Sergey Senozhatsky wrote: > > > We deprecated '%pF/%pf' printk specifiers, since '%pS/%ps' is now smart > > > enough to handle function pointer dereference

[PATCH v2 0/2] Fix y2038 issues for security/keys subsystem

2017-09-20 Thread Baolin Wang
Since 'time_t', 'timeval' and 'timespec' types are not year 2038 safe on 32 bits system, this patchset tries to fix this issues for security/keys subsystem. Changes since v1: - Add reviewed tag from Arnd. - Drop Patch 3 which had been merged into kernel 4.14 by David. Baolin Wang (2):

[PATCH v2 1/2] security: keys: Replace time_t/timespec with time64_t

2017-09-20 Thread Baolin Wang
The 'struct key' will use 'time_t' which we try to remove in the kernel, since 'time_t' is not year 2038 safe on 32bit systems. Also the 'struct keyring_search_context' will use 'timespec' type to record current time, which is also not year 2038 safe on 32bit systems. Thus this patch replaces

[PATCH v2 2/2] security: keys: Replace time_t with time64_t for struct key_preparsed_payload

2017-09-20 Thread Baolin Wang
The 'struct key_preparsed_payload' will use 'time_t' which we will try to remove in the kernel, since 'time_t' is not year 2038 safe on 32bits systems. Thus this patch replaces 'time_t' with 'time64_t' which is year 2038 safe on 32 bits system for 'struct key_preparsed_payload', moreover we

Re: [PATCH v2] vfs: introduce UMOUNT_WAIT which waits for umount completion

2017-09-20 Thread Al Viro
On Wed, Sep 20, 2017 at 05:34:09PM -0700, Jaegeuk Kim wrote: > > flush_delayed_fput() > > does nothing, the list is empty > > how about waiting for workqueue completion here? > > > > > If all the __fput()s are not finished, do_umount() will return

RE: [PATCHv2 0/3] arm64: dts: ls1012a: add the DTS node for DSPI support

2017-09-20 Thread Z.q. Hou
Hi Shawn, > -Original Message- > From: Shawn Guo [mailto:shawn...@kernel.org] > Sent: 2017年9月20日 22:11 > To: Z.q. Hou > Cc: linux-arm-ker...@lists.infradead.org; devicet...@vger.kernel.org; > linux-kernel@vger.kernel.org; dw...@infradead.org; robh...@kernel.org; > mark.rutl...@arm.com;

[lkp-robot] [blk] 47e0fb461f: BUG:unable_to_handle_kernel

2017-09-20 Thread kernel test robot
FYI, we noticed the following commit: commit: 47e0fb461fca1a68a566c82fcc006cc787312d8c ("blk: make the bioset rescue_workqueue optional.") https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master in testcase: trinity with following parameters: runtime: 300s

Re: [PATCH] block: consider merge of segments when merge bio into rq

2017-09-20 Thread jianchao.wang
On 09/21/2017 09:29 AM, Christoph Hellwig wrote: > So the check change here looks good to me. > > I don't like like the duplicate code, can you look into sharing > the new segment checks between the two functions and the existing > instance in ll_merge_requests_fn by passing say two struct bio

[PATCH v2] block: consider merge of segments when merge bio into rq

2017-09-20 Thread Jianchao Wang
When account the nr_phys_segments during merging bios into rq, only consider segments merging in individual bio but not all the bios in a rq. This leads to the bigger nr_phys_segments of rq than the real one when the segments of bios in rq are contiguous and mergeable. The nr_phys_segments of rq

Re: Read-only `slaves` with shared subtrees?

2017-09-20 Thread Dawid Ciezarkiewicz
On Wed, Sep 20, 2017 at 5:39 PM, Ram Pai wrote: > Anyway; so something like this should be possible without breaking > existing semantics. > > mount -o bind,remount,ro /mnt > mount --make-pass-on-access /mnt > > anything that gets mounted under /mnt will inherit the > 'ro' attribute from its

Re: [PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf

2017-09-20 Thread Gregory Fong
On Wed, Sep 20, 2017 at 12:13 AM, Arvind Yadav wrote: > devm_kasprintf() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/gpio/gpio-brcmstb.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpio/gpio-brcmstb.c

Re: [PATCH] mpt3sas: downgrade full copy_from_user to access_ok check

2017-09-20 Thread Al Viro
On Tue, Sep 19, 2017 at 11:11:11PM -0400, Meng Xu wrote: > Since right after the user copy, we are going to > memset(, 0, sizeof(karg)), I guess an access_ok check is enough? access_ok() is *NOT* "will copy_from_user() succeed?" Not even close. On a bunch of architectures (sparc64, for one)

Re: [lkp-robot] [drivers] ceed73a2cf: drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c:#suspicious_rcu_dereference_check()usage

2017-09-20 Thread Subash Abhinov Kasiviswanathan
On 2017-09-19 19:55, kernel test robot wrote: FYI, we noticed the following commit: commit: ceed73a2cf4aff2921802aa3d21d45280677547d ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation") https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master in testcase: boot on

Re: [PATCH] mpt3sas: downgrade full copy_from_user to access_ok check

2017-09-20 Thread Meng Xu
> On Sep 20, 2017, at 11:26 PM, Al Viro wrote: > > On Tue, Sep 19, 2017 at 11:11:11PM -0400, Meng Xu wrote: >> Since right after the user copy, we are going to >> memset(, 0, sizeof(karg)), I guess an access_ok check is enough? > > access_ok() is *NOT* "will copy_from_user() succeed?" Not

linux-next: Tree for Sep 21

2017-09-20 Thread Stephen Rothwell
Hi all, Changes since 20170920: Linus' tree lost its build failure. The sound-asoc tree lost its build failure. Non-merge commits (relative to Linus' tree): 1337 1200 files changed, 49498 insertions(+), 15649 deletions

[git pull][vfs.git] a couple of fixes

2017-09-20 Thread Al Viro
A couple of regression fixes, one for this merge window, one for the previous cycle. The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e: Linux 4.14-rc1 (2017-09-16 15:47:51 -0700) are available in the git repository at:

[PATCH v2 2/5] clk: aspeed: Register core clocks

2017-09-20 Thread Joel Stanley
This registers the core clocks; those which are required to calculate the rate of the timer periperhal so the system can load a clocksource driver. Signed-off-by: Joel Stanley --- drivers/clk/clk-aspeed.c | 152 ++- 1 file changed, 149 insertions(+),

[PATCH v2 1/5] clk: Add clock driver for ASPEED BMC SoCs

2017-09-20 Thread Joel Stanley
This adds the stub of a driver for the ASPEED SoCs. The clocks are defined and the static registration is set up. Signed-off-by: Joel Stanley --- drivers/clk/Kconfig | 12 +++ drivers/clk/Makefile | 1 + drivers/clk/clk-aspeed.c | 162

[PATCH v2 0/5] clk: Add Aspeed clock driver

2017-09-20 Thread Joel Stanley
This driver supports the ast2500, ast2400 (and derivative) BMC SoCs from Aspeed. This is version two of the series. Version one contained two patches; an update to the binding document and a single patch for the driver. Lee has merged the bindings change, so that is dropped from this series, and

[PATCH v2 5/5] clk: aspeed: Add reset controller

2017-09-20 Thread Joel Stanley
There are some resets that are not associated with gates. These are represented by a reset controller. Signed-off-by: Joel Stanley --- drivers/clk/clk-aspeed.c | 82 +++- include/dt-bindings/clock/aspeed-clock.h | 9 2 files changed, 90

[PATCH v2 4/5] clk: aspeed: Register gated clocks

2017-09-20 Thread Joel Stanley
The majority of the clocks in the system are gates paired with a reset controller that holds the IP in reset. This borrows from clk_hw_register_gate, but registers two 'gates', one to control the clock enable register and the other to control the reset IP. This allows us to enforce the ordering:

[PATCH v2 3/5] clk: aspeed: Add platform driver and register PLLs

2017-09-20 Thread Joel Stanley
This registers a platform driver to set up all of the non-core clocks. The clocks that have configurable rates are now registered. Signed-off-by: Joel Stanley --- drivers/clk/clk-aspeed.c | 129 +++ 1 file changed, 129 insertions(+) diff --git

Re: [PATCH V6 2/3] dma-mapping: Rework dma_get_cache_alignment()function

2017-09-20 Thread 陈华才
Hi, Christoph, I have changed dma_get_cache_alignment's return value, and I don't know whether those drivers want to return ARCH_DMA_MINALIGN unconditionally. So I pass a NULL for those drivers, in order to keep their old behavior. Huacai -- Original -- From:

Re: [PATCH] powerpc/perf: Fix for core/nest imc call trace on cpuhotplug

2017-09-20 Thread Michael Ellerman
Anju T Sudhakar writes: > Nest/core pmu units are enabled only when it is used. A reference count is > maintained for the events which uses the nest/core pmu units. Currently in > *_imc_counters_release function a WARN() is used for notification of any > underflow of ref count. Replace WARN()

Re:Re: [PATCH net-next] net: Remove useless function skb_header_release

2017-09-20 Thread Gao Feng
At 2017-09-21 05:30:46, "David Miller" wrote: >From: gfree.w...@vip.163.com >Date: Tue, 19 Sep 2017 22:32:48 +0800 > >> From: Gao Feng >> >> There is no one which would invokes the function skb_header_release. >> So just remove it now. >> >> Signed-off-by: Gao Feng > >Networking patches must

Re: [PATCH v2 8/8] PM / devfreq: exynos-bus: Register cooling device

2017-09-20 Thread Chanwoo Choi
Dear all, Please ignore this patch. It has some problem. I'll fix and resend this patch on v2. Chanwoo Choi Samsung Electronics On 2017년 09월 21일 09:33, Chanwoo Choi wrote: > This patch registers the Exynos Bus-Frequency scaling device > as a cooling device of thermal management. > >

Re: [PATCH v2] vfs: introduce UMOUNT_WAIT which waits for umount completion

2017-09-20 Thread Jaegeuk Kim
On 09/21, Al Viro wrote: > On Wed, Sep 20, 2017 at 05:34:09PM -0700, Jaegeuk Kim wrote: > > > flush_delayed_fput() > > > does nothing, the list is empty > > > > how about waiting for workqueue completion here? > > > > > > > > > If all the __fput()s are not

Re: [PATCH net-next] net: dsa: better scoping of slave functions

2017-09-20 Thread Florian Fainelli
On 09/20/2017 04:31 PM, Vivien Didelot wrote: > A few DSA slave functions take a dsa_slave_priv pointer as first > argument, whereas the scope of the slave.c functions is the slave > net_device structure. Fix this and rename dsa_netpoll_send_skb to > dsa_slave_netpoll_send_skb. > >

Re: [PATCH net-next] net: dsa: add port fdb dump

2017-09-20 Thread Florian Fainelli
On 09/20/2017 04:32 PM, Vivien Didelot wrote: > Dumping a DSA port's FDB entries is not specific to a DSA slave, so add > a dsa_port_fdb_dump function, similarly to dsa_port_fdb_add and > dsa_port_fdb_del. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next] net: dsa: use dedicated CPU port

2017-09-20 Thread Florian Fainelli
On 09/20/2017 09:28 AM, Vivien Didelot wrote: > Each port in DSA has its own dedicated CPU port currently available in > its parent switch's ds->ports[port].cpu_dp. Use it instead of getting > the unique tree CPU port, which will be deprecated soon. > > Signed-off-by: Vivien Didelot > --- >

[PATCH v2 1/2] gpio: brcmstb: Handle return value of devm_kasprintf

2017-09-20 Thread Arvind Yadav
devm_kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2 : Set return 'err' to -ENOMEM. drivers/gpio/gpio-brcmstb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpio/gpio-brcmstb.c

Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable

2017-09-20 Thread Johannes Thumshirn
On Wed, Sep 20, 2017 at 04:59:31PM +0200, Christoph Hellwig wrote: > On Wed, Sep 20, 2017 at 12:40:32PM +0200, Johannes Thumshirn wrote: > > Notify sysfs about changes of a nvme controller so user-space can watch the > > file via poll() or select() in order to react to a state change. > >

[PATCH v2 2/3] ASoC: fsl-asoc-card: Handle return value of devm_kasprintf

2017-09-20 Thread Arvind Yadav
devm_kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2: Set return 'ret' to -ENOMEM. sound/soc/fsl/fsl-asoc-card.c | 4 1 file changed, 4 insertions(+) diff --git a/sound/soc/fsl/fsl-asoc-card.c

Re: [PATCH] dt-bindings: nand: denali: reduce the register space in the example

2017-09-20 Thread Masahiro Yamada
Hi. 2017-09-14 18:06 GMT+09:00 Oleksij Rempel : > On 14.09.2017 10:16, Masahiro Yamada wrote: >> >> Hi. >> >> >> 2017-09-14 17:04 GMT+09:00 Oleksij Rempel : >>> >>> Hi, >>> >>> i assume arch/arm/boot/dts/socfpga.dtsi should be update as well. Right? >> >> >> I think so. >> (also

Re: Memory hotplug regression in 4.13

2017-09-20 Thread Seth Forshee
On Wed, Sep 20, 2017 at 11:29:31AM +0200, Michal Hocko wrote: > Hi, > I am currently at a conference so I will most probably get to this next > week but I will try to ASAP. > > On Tue 19-09-17 11:41:14, Seth Forshee wrote: > > Hi Michal, > > > > I'm seeing oopses in various locations when

[PATCH] staging:rtl8188eu:hal Fix wrong comparison to False

2017-09-20 Thread Janani Sankara Babu
This patch solves the warning "Using comparison to false is error prone" Signed-off-by: Janani Sankara Babu --- drivers/staging/rtl8188eu/hal/odm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c

[PATCH v2] PM / OPP: Use snprintf to avoid kasprintf and kfree

2017-09-20 Thread Arvind Yadav
Use snprintf to avoid unnecessary initializations, avoid calling kfree. Signed-off-by: Arvind Yadav --- changes in v2: Remove kasprintf instead of error checking. drivers/base/power/opp/debugfs.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH] staging:rtl8188eu Fix remove semicolon in do {}while(0)

2017-09-20 Thread Janani Sankara Babu
This patch removes the semicolon at the end of while statement in the do while macro , inorder to avoid it behaving like compound statement. Signed-off-by: Janani Sankara Babu --- drivers/staging/rtl8188eu/core/rtw_security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC] sched/fair: Use wake_q length as a hint for wake_wide

2017-09-20 Thread Joel Fernandes
On Wed, Sep 20, 2017 at 2:17 PM, Atish Patra wrote: > On 09/20/2017 03:23 PM, Joel Fernandes wrote: >> >> On Wed, Sep 20, 2017 at 2:33 AM, Brendan Jackman >> wrote: >>> >>> >>> On Wed, Sep 20 2017 at 05:06, Joel Fernandes wrote: > > On Tue, Sep 19, 2017 at 3:05 AM, Brendan Jackman >

[PATCH] staging:vme Fix use BIT macro

2017-09-20 Thread Janani Sankara Babu
This patch is created to solve the following warning shown by the checkpatch script Warning: Replace all occurences of (1< --- drivers/staging/vme/devices/vme_pio2.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_pio2.h

[PATCH v2] zram: fix null dereference of handle

2017-09-20 Thread Minchan Kim
For the testing, I found handle passed to zs_map_object in __zram_bvec_read is NULL so that kernel goes the Oops by pin_object. The reason is there is no routine to check the slot's freeing after getting the slot's lock. This patch fixes it. * From v1: * remove unlikely branch - Sergey * In

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-09-20 Thread Shawn N
This is failing because our EC_CMD_GET_PROTOCOL_INFO host command is getting messed up, or the reply buffer is getting corrupted somehow. ec_dev->proto_version = min(EC_HOST_REQUEST_VERSION,

Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending !nr_pages flush

2017-09-20 Thread Amir Goldstein
On Wed, Sep 20, 2017 at 7:13 AM, Jens Axboe wrote: > On 09/19/2017 09:10 PM, Amir Goldstein wrote: >> On Tue, Sep 19, 2017 at 10:53 PM, Jens Axboe wrote: >>> A few callers pass in nr_pages == 0 when they wakeup the flusher >>> threads, which means that the flusher should just flush everything

Re: [PATCH v2 1/4] watchdog: aspeed: Retain watchdog enabled state

2017-09-20 Thread Joel Stanley
On Wed, Sep 20, 2017 at 3:00 PM, Andrew Jeffery wrote: > An unintended post-condition of probe() is that the watchdog is > disabled. This behaviour was introduced by an unnecessary write to the > control register to configure the hardware based on the devicetree. The > write is unnecessary

Re: [PATCH v2 2/4] watchdog: aspeed: Fix 'Apseed' typo in Kconfig

2017-09-20 Thread Joel Stanley
On Wed, Sep 20, 2017 at 3:00 PM, Andrew Jeffery wrote: > Apseed sounds like a good name for a web/mobile start-up incubator, but > isn't a reflection of Aspeed themselves. > > Signed-off-by: Andrew Jeffery > Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed,

Re: [PATCH v2 3/4] watchdog: aspeed: Remove specific reference to AST2400 in Kconfig

2017-09-20 Thread Joel Stanley
On Wed, Sep 20, 2017 at 3:00 PM, Andrew Jeffery wrote: > The driver also supports the watchdog in the AST25xx series, and > may work on earlier SoCs as well. > > Signed-off-by: Andrew Jeffery > Reviewed-by: Guenter Roeck Reviewed-by: Joel Stanley

Re: [PATCH] kbuild/mkspec: remove firmware from rpm package

2017-09-20 Thread Greg KH
On Wed, Sep 20, 2017 at 10:35:29AM +0800, shuw...@redhat.com wrote: > From: Shu Wang > > Commit 5620a0d1aacd ("firmware: delete in-kernel firmware") deleted > in-kernel firmware support, including the firmware install command. > > So make binrpm-pkg will failed as no firmware_install make

Re: [PATCH 3/5] powerpc64: Add .opd based function descriptor dereference

2017-09-20 Thread Sergey Senozhatsky
On (09/20/17 11:51), Michael Ellerman wrote: [..] > > unlike ppc_function_entry(), printk() can get called on any symbol, > > not just function pointers. > > > > for example, > > > > cat /proc/kallsyms | grep shrinker_rwsem > > 81a4b1e0 d shrinker_rwsem > > Yep, good point. So your patch

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-09-20 Thread Brian Norris
Hi, On Tue, Sep 19, 2017 at 11:05:38PM -0700, Shawn N wrote: > This is failing because our EC_CMD_GET_PROTOCOL_INFO host command is > getting messed up, or the reply buffer is getting corrupted somehow. > >ec_dev->proto_version = >

Re: [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall

2017-09-20 Thread Joel Stanley
On Wed, Sep 20, 2017 at 3:00 PM, Andrew Jeffery wrote: > Probing at device_initcall time lead to perverse cases where the > watchdog was probed after, say, I2C devices, which then leaves a > potentially running watchdog at the mercy of I2C device behaviour and > bus conditions. > > Load the

[PATCH v2] fs:btrfs: return -ENOMEM on allocation failure.

2017-09-20 Thread Allen Pais
v2: return -ENOMEM from btrfsic_dev_state_alloc() too. Signed-off-by: Allen Pais --- fs/btrfs/check-integrity.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index 7d5a9b5..9db1e76 100644 ---

Re: [PATCH] powerpc: make irq_chip const, __initdata and __initconst

2017-09-20 Thread Michael Ellerman
Bhumika Goyal writes: > Make ehv_pic_irq_chip, mpic_ipi_chip and mpic_tm_chip const as they are > used only as a copy operation. This usage is during init, so make them > __initconst too. > Make mpic_ipi_chip __initdata as it is only modified during the init > phase and there is no reference of

[PATCH 1/1] soc-pcm: check symmetry after hw_params

2017-09-20 Thread Jiada Wang
hw_params may be fixup by be_hw_params_fixup, calling soc_pcm_params_symmetry() before hw_params will have issue if there is hw_params changes in be_hw_params_fixup. For example, with following use case 1. a dai-link which is able to convert sample rate on BE side 2. set BE playback and capture

Re: [PATCH] zram: fix null dereference of handle

2017-09-20 Thread Sergey Senozhatsky
Hello, On (09/20/17 14:51), Minchan Kim wrote: > On Tue, Sep 19, 2017 at 07:21:25PM +0900, Sergey Senozhatsky wrote: > > Minchan, > > > > I just ran across it [because I had a bug to analize where this > > part was involved]. I'd really prefer the kernel to BUG_ON immediately > > instead of

Re: [PATCH][V2] x86/xen: clean up clang build warning

2017-09-20 Thread Juergen Gross
On 18/09/17 11:03, Colin King wrote: > From: Colin Ian King > > In the case where sizeof(maddr) != sizeof(long) p is initialized and > never read and clang throws a warning on this. Move declaration of > p to clean up the clang build warning: > > warning: Value stored to 'p' during its

Re: [PATCH v2] zram: fix null dereference of handle

2017-09-20 Thread Sergey Senozhatsky
On (09/20/17 15:02), Minchan Kim wrote: > For the testing, I found handle passed to zs_map_object in __zram_bvec_read > is NULL so that kernel goes the Oops by pin_object. > > The reason is there is no routine to check the slot's freeing > after getting the slot's lock. This patch fixes it. > >

[PATCH 0/3] [media] pvrusb2-ioread: Fine-tuning for eight function implementations

2017-09-20 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 20 Sep 2017 08:28:48 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use common error handling code in pvr2_ioread_get_buffer() Delete an unnecessary check before kfree() in two functions Delete

Re: [PATCH] powerpc: make irq_chip const, __initdata and __initconst

2017-09-20 Thread Julia Lawall
On Wed, 20 Sep 2017, Michael Ellerman wrote: > Bhumika Goyal writes: > > > Make ehv_pic_irq_chip, mpic_ipi_chip and mpic_tm_chip const as they are > > used only as a copy operation. This usage is during init, so make them > > __initconst too. > > Make mpic_ipi_chip __initdata as it is only

[PATCH 1/3] [media] pvrusb2-ioread: Use common error handling code in pvr2_ioread_get_buffer()

2017-09-20 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 19 Sep 2017 21:50:05 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH] HID: hidraw: fix power sequence when closing device

2017-09-20 Thread Benson Leung
Hi Dmitry, On Tue, Sep 19, 2017 at 06:37:46PM -0700, Dmitry Torokhov wrote: > We should not try to bring HID device out of full power state before > calling hid_hw_close(), so that transport driver operates on powered up > device (making this inverse of the opening sequence). > > Signed-off-by:

[PATCH 2/3] [media] pvrusb2-ioread: Delete an unnecessary check before kfree() in two functions

2017-09-20 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 19 Sep 2017 22:12:49 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: kfree(NULL) is safe and this check is probably not required Thus fix the affected source code places. Signed-off-by: Markus Elfring ---

[PATCH 3/3] [media] pvrusb2-ioread: Delete unnecessary braces in six functions

2017-09-20 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 20 Sep 2017 08:15:51 +0200 Do not use curly brackets at some source code places where a single statement should be sufficient. Signed-off-by: Markus Elfring --- drivers/media/usb/pvrusb2/pvrusb2-ioread.c | 38 -- 1 file changed, 15

Re: [PATCH] kbuild/mkspec: remove firmware from rpm package

2017-09-20 Thread Shu Wang
Hi Do you mean the patch for deb package? The patch didn't fix rpm package. or there's another patch I didn't get on the mailing list. https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1492398.html Thanks - Original Message - > From: "Greg KH" > To: shuw...@redhat.com > Cc:

[PATCH] zsmalloc: calling zs_map_object() from irq is a bug

2017-09-20 Thread Sergey Senozhatsky
Use BUG_ON(in_interrupt()) in zs_map_object(). Calling this function from IRQ is a bug, because we use per-CPU mappings and interrupt may corrupt those buffers. Signed-off-by: Sergey Senozhatsky --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/zsmalloc.c

Re: [linux-next][EXT4][Oops]kernel panics when running fsfuzzer

2017-09-20 Thread Michael Ellerman
Abdul Haleem writes: > Hi, > > next kernel panics when running fsfuzzer test on ext4 file system. > > Machine Type: Power 7 PowerVM LPAR > kernel : 4.13.0-next-20170915 > config : attached > Test: fsfuzzer > > dmesg: > - > EXT4-fs (loop1): couldn't mount RDWR because of unsupported optional

Re: [PATCH] zsmalloc: calling zs_map_object() from irq is a bug

2017-09-20 Thread Minchan Kim
On Wed, Sep 20, 2017 at 03:39:41PM +0900, Sergey Senozhatsky wrote: > Use BUG_ON(in_interrupt()) in zs_map_object(). Calling this > function from IRQ is a bug, because we use per-CPU mappings > and interrupt may corrupt those buffers. > > Signed-off-by: Sergey Senozhatsky IMHO, corruption the

Re: [PATCH] zsmalloc: calling zs_map_object() from irq is a bug

2017-09-20 Thread Sergey Senozhatsky
On (09/20/17 15:47), Minchan Kim wrote: > On Wed, Sep 20, 2017 at 03:39:41PM +0900, Sergey Senozhatsky wrote: > > Use BUG_ON(in_interrupt()) in zs_map_object(). Calling this > > function from IRQ is a bug, because we use per-CPU mappings > > and interrupt may corrupt those buffers. > > > >

[PATCHv2] tty: xilinx_uartps: move to arch_initcall for earlier console

2017-09-20 Thread Shubhrajyoti Datta
move to arch_initcall to get the console up really early, it is quite helpful for spotting early boot problems. Signed-off-by: Shubhrajyoti Datta --- drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c

Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure.

2017-09-20 Thread Allen
> static int cas_alloc_rxds(struct cas *cp) > { > int i; > > for (i = 0; i < N_RX_DESC_RINGS; i++) { > if (cas_alloc_rx_desc(cp, i) < 0) { > cas_free_rxds(cp); > return -1; > } > } >

Re: [PATCH] kbuild/mkspec: remove firmware from rpm package

2017-09-20 Thread Masahiro Yamada
2017-09-20 15:39 GMT+09:00 Shu Wang : > Hi > > Do you mean the patch for deb package? The patch didn't fix rpm > package. or there's another patch I didn't get on the mailing list. > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1492398.html > > Thanks > I sent this:

Re: [PATCH v2 0/6] Support PPTT for ARM64

2017-09-20 Thread Xiongfeng Wang
Hi Jeremy, I have tested it on D05 board, the sysfs can display right information about cpu topo and cache topo, except that the core_id and physical_package_id are not continuous and counting from zero. But this doesn't influence the system. Thanks, Xiongfeng Wang On 2017/9/20 2:47, Jeremy

[PATCH] drivers/perf: arm_pmu_acpi: Release memory obtained by kasprintf

2017-09-20 Thread Arvind Yadav
Free memory region, if arm_pmu_acpi_probe is not successful. Signed-off-by: Arvind Yadav --- drivers/perf/arm_pmu_acpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c index 0a9b787..3303dd8 100644 --- a/drivers/perf/arm_pmu_acpi.c

Re: [PATCH] KVM: x86: Fix the NULL pointer parameter in check_cr_write()

2017-09-20 Thread Yu Zhang
On 9/18/2017 11:56 PM, Jim Mattson wrote: kvm_cpuid ultimately wants to write all four of the GPRs passed in by reference. I don't see any advantage to allowing some of these pointers to be NULL. Thanks for your comments, Jim & David. 2 reasons I did not choose to change kvm_cpuid(): 1>

Re: [PATCH] dmaengine: sun6i: sun4i-gpadc: use of_device_get_match_data

2017-09-20 Thread Maxime Ripard
Hi, On Tue, Sep 19, 2017 at 06:44:47PM +, Corentin Labbe wrote: > The usage of of_device_get_match_data reduce the code size a bit. > Furthermore, it prevents an improbable dereference when > of_match_device() return NULL. > > Signed-off-by: Corentin Labbe The prefix of your commit title

[PATCH] PM / OPP: Handle return value of kasprintf

2017-09-20 Thread Arvind Yadav
kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/base/power/opp/debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/base/power/opp/debugfs.c b/drivers/base/power/opp/debugfs.c index 81cf120..226d6ae 100644

[PATCH] netfilter: nf_tables: Release memory obtained by kasprintf

2017-09-20 Thread Arvind Yadav
Free memory region, if nf_tables_set_alloc_name is not successful. Signed-off-by: Arvind Yadav --- net/netfilter/nf_tables_api.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 9299271..393e37e 100644 ---

Re: [PATCH] kbuild/mkspec: remove firmware from rpm package

2017-09-20 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Sep 20, 2017 at

Re: [PATCH 1/7] PM / OPP: Add platform specific set_clk function

2017-09-20 Thread Dong Aisheng
Hi Viresh, On Tue, Sep 19, 2017 at 03:58:40PM -0700, Viresh Kumar wrote: > On 24-08-17, 00:10, Dong Aisheng wrote: > > This is useful to support platforms which only the clk setting is > > different from the generic OPP set rate but others like voltage > > setting are still the same. > > > >

[PATCH] serial: core: Release memory obtained by kasprintf

2017-09-20 Thread Arvind Yadav
Free memory region, if uart_add_one_port is not successful. Signed-off-by: Arvind Yadav --- drivers/tty/serial/serial_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 3a14ccc..989adbb 100644

Re: [PATCH 6/7] cpufreq: make cpufreq_generic_init transition_latency default to CPUFREQ_ETERNAL

2017-09-20 Thread Dong Aisheng
On Tue, Sep 19, 2017 at 04:10:07PM -0700, Viresh Kumar wrote: > On 24-08-17, 00:10, Dong Aisheng wrote: > > If no valid transition_latency specified, let's make it default to > > CPUFREQ_ETERNAL which is consistent with its definition. > > > > This can save some of the same checkings like this: >

[PATCH] phy: tegra: Handle return value of kasprintf

2017-09-20 Thread Arvind Yadav
kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/phy/tegra/xusb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index 3cbcb25..4307bf0 100644 --- a/drivers/phy/tegra/xusb.c +++

Re: [PATCH] pinctrl: bcm2835: fix build warning in bcm2835_gpio_irq_handle_bank

2017-09-20 Thread Stefan Wahren
Am 19.09.2017 um 21:04 schrieb Corentin Labbe: This patch fix the following build warning: drivers/pinctrl/bcm/pinctrl-bcm2835.c:376:15: warning: variable 'type' set but not used [-Wunused-but-set-variable] Furthermore, it is unused for a long time, at least since commit 85ae9e512f43

Re: [PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe()

2017-09-20 Thread SF Markus Elfring
>> @@ -555,17 +553,13 @@ static int s2250_probe(struct i2c_client *client, >> /* initialize the audio */ >> if (write_regs(audio, aud_regs) < 0) { >> dev_err(>dev, "error initializing audio\n"); >> -goto fail; >> +goto e_io; > > Preserve the error

Re: [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure.

2017-09-20 Thread Allen
> > rlb_initialize() is only called by bond_alb_initialize(), and it > propagates the -1. That is only called by bond_open() with: > > if (bond_alb_initialize(bond, (BOND_MODE(bond) == BOND_MODE_ALB))) > return -ENOMEM; > Would this work? diff --git

Re: [PATCH 1/1] clk: bulk: add of_clk_bulk_get()

2017-09-20 Thread Dong Aisheng
Hi Geert, On Wed, Sep 13, 2017 at 03:40:32PM +0200, Geert Uytterhoeven wrote: > On Wed, Sep 13, 2017 at 2:34 AM, kbuild test robot wrote: > > [auto build test WARNING on clk/clk-next] > > [also build test WARNING on v4.13 next-20170912] > > [if your patch is applied to the wrong git tree, please

[PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf

2017-09-20 Thread Arvind Yadav
devm_kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/gpio/gpio-brcmstb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c index dd0308c..1227d6e 100644 ---

[PATCH 2/2] gpio: tb10x: Handle return value of devm_kasprintf

2017-09-20 Thread Arvind Yadav
devm_kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/gpio/gpio-tb10x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c index 091ffaa..ac6f2a9 100644 --- a/drivers/gpio/gpio-tb10x.c

[PATCH 0/2] Handle return value of devm_kasprintf

2017-09-20 Thread Arvind Yadav
devm_kasprintf() can fail here and we must check its return value. Arvind Yadav (2): [PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf [PATCH 2/2] gpio: tb10x: Handle return value of devm_kasprintf drivers/gpio/gpio-brcmstb.c | 3 +++ drivers/gpio/gpio-tb10x.c | 3 +++ 2

[PATCH] gpio: Wakeup gpio controller when it is used as IRQ controller

2017-09-20 Thread Michal Simek
From: Borsodi Petr There is a problem with GPIO driver when used as IRQ controller. It is not working because the module is sleeping (clock is disabled). The patch enables clocks when IP is used as IRQ controller. Signed-off-by: Borsodi Petr Signed-off-by: Michal Simek --- Based on

[PATCH v1 1/6] perf record: Record the first sample time and last sample time to perf file header

2017-09-20 Thread Jin Yao
perf report/script/... have a --time option to limit the time range of output. That's very useful to slice large traces, e.g. when processing the output of perf script for some analysis. But right now --time only supports absolute time. Also there is no fast way to get the start/end times of a

[PATCH v1 0/6] perf report/script: Support percent and multiple range in --time option

2017-09-20 Thread Jin Yao
Current perf report/script/... have a --time option to limit the time range of output. But it only supports the absolute time. The patch series extend this option to let it support percent of time and support the multiple time ranges. For example: 1. Select the second 10% time slice perf

Re: [PATCH v2 1/6] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-09-20 Thread Xiongfeng Wang
Hi Jeremy, On 2017/9/20 2:47, Jeremy Linton wrote: > ACPI 6.2 adds a new table, which describes how processing units > are related to each other in tree like fashion. Caches are > also sprinkled throughout the tree and describe the properties > of the caches in relation to other caches and

[PATCH v1 4/6] perf util: Create function to perform multiple time range checking

2017-09-20 Thread Jin Yao
Previous patch supports the multiple time range. For example, select the first and second 10% time slices. perf report --time 10%/1,10%/2 We need a function to check if a timestamp is in the ranges of [0, 10%) and [10%, 20%). This patch implments a new function perf_time__ranges_skip_sample.

[PATCH v1 3/6] perf util: Create function to parse time percent

2017-09-20 Thread Jin Yao
Current perf report/script/... have a --time option to limit the time range of output. But right now it only supports absolute time. For easy using, now it can support a percent of time usage. For example: 1. Select the second 10% time slice perf report --time 10%/2 2. Select from 0% to 10%

  1   2   3   4   5   6   7   8   9   10   >