[PATCH v3] pata_pdc2027x: Remove unnecessary error check

2017-11-25 Thread Arvind Yadav
Here, The function pdc_hardware_init always return zero. So it is not necessary to check its return value. Signed-off-by: Arvind Yadav --- changes in v2 : Make function return type 'void' instead of 'int. Add sapce between ':'. changes in v3 : Fix the

[PATCH] pata_pdc2027x: Fix coding sytle error

2017-11-25 Thread Arvind Yadav
Fix these checkpatch.pl error: ERROR: space prohibited before open square bracket '['. ERROR: space prohibited after that '~' (ctx:WxW) + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); ERROR: spaces required around that '?' (ctx:VxW) + long pout_required = board_idx?

Re: [PATCH v2 2/2] x86: disable IRQs before changing CR4

2017-11-25 Thread Thomas Gleixner
On Fri, 24 Nov 2017, Nadav Amit wrote: > /* Set in this cpu's CR4. */ > -static inline void cr4_set_bits(unsigned long mask) > +static inline void cr4_set_bits_irqs_off(unsigned long mask) This change is kinda weird. I'd expect that there is a corresponding function cr4_set_bits() which takes

Re: [PATCH] pata_pdc2027x: Fix coding sytle error

2017-11-25 Thread Joe Perches
On Sat, 2017-11-25 at 16:04 +0530, Arvind Yadav wrote: [] > diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c [] > @@ -84,7 +84,7 @@ static int pdc2027x_set_mode(struct ata_link *link, struct > ata_device **r_failed > */ > static struct pdc2027x_pio_timing { > u8

Re: [PATCH] pata_pdc2027x: Fix coding sytle error

2017-11-25 Thread arvindY
Hi Joe, On Saturday 25 November 2017 04:32 PM, Joe Perches wrote: On Sat, 2017-11-25 at 16:04 +0530, Arvind Yadav wrote: [] diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c [] @@ -84,7 +84,7 @@ static int pdc2027x_set_mode(struct ata_link *link, struct ata_device

[PATCH] pata_pdc2027x : make pdc2027x_*_timing structures const

2017-11-25 Thread Arvind Yadav
Make these pdc2027x_*_timing structures const as it is never modified. Signed-off-by: Arvind Yadav --- drivers/ata/pata_pdc2027x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c index d1e8b63..141bf81 100644

[PATCH] x86/mm/kaiser: Fix IRQ entries text section mapping

2017-11-25 Thread Ingo Molnar
* Ingo Molnar wrote: > > So it's either unwinder related, or seemingly minor changes to code > > alignment/placement will make the bug go away. > > Ok, I think the Orc unwinder is innocent: I just forced a build with frame > pointers but with ORC debuginfo and unwinder, and that is booting

[PATCH] nvmem: core: Deduplicate bus_find_device() by name matching

2017-11-25 Thread Lukas Wunner
No need to reinvent the wheel, we have bus_find_device_by_name(). Signed-off-by: Lukas Wunner --- drivers/nvmem/core.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 5a5cefd12153..93084ab61e0f 100644 ---

Re: [PATCH 15/43] x86/entry/64: Create a percpu SYSCALL entry trampoline

2017-11-25 Thread Borislav Petkov
On Fri, Nov 24, 2017 at 06:23:43PM +0100, Ingo Molnar wrote: > From: Andy Lutomirski > > Handling SYSCALL is tricky: the SYSCALL handler is entered with every > single register (except FLAGS), including RSP, live. It somehow needs > to set RSP to point to a valid stack, which means it needs to

[PATCH] nvmem: core: switch to device_property_present for reading property "read-only"

2017-11-25 Thread Heiner Kallweit
Switch to more generic device_property_present to consider also non-DT properties. Signed-off-by: Heiner Kallweit --- drivers/nvmem/core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 5a5cefd12..ba0e3b453 100644 ---

Re: [f2fs-dev] [PATCH] f2fs: remove an excess variable

2017-11-25 Thread Chao Yu
On 2017/11/25 11:46, LiFan wrote: > Remove the variable page_idx which no one would miss. > > Signed-off-by: Fan li Reviewed-by: Chao Yu Thanks,

Re: [PATCH 16/43] x86/irq: Remove an old outdated comment about context tracking races

2017-11-25 Thread Borislav Petkov
On Fri, Nov 24, 2017 at 06:23:44PM +0100, Ingo Molnar wrote: > From: Andy Lutomirski > > That race has been fixed and code cleaned up for a while now. > > Signed-off-by: Andy Lutomirski > Signed-off-by: Thomas Gleixner > Cc: Borislav Petkov > Cc: Brian Gerst > Cc: Dave Hansen > Cc: Josh

Re: [PATCH 17/43] x86/irq/64: In the stack overflow warning, print the offending IP

2017-11-25 Thread Borislav Petkov
On Fri, Nov 24, 2017 at 06:23:45PM +0100, Ingo Molnar wrote: > From: Andy Lutomirski > > In case something goes wrong with unwind (not unlikely in case of > overflow), print the offending IP where we detected the overflow. > > Signed-off-by: Andy Lutomirski > Signed-off-by: Thomas Gleixner >

Re: [PATCH 18/43] x86/entry/64: Move the IST stacks into cpu_entry_area

2017-11-25 Thread Borislav Petkov
On Fri, Nov 24, 2017 at 06:23:46PM +0100, Ingo Molnar wrote: > From: Andy Lutomirski > > The IST stacks are needed when an IST exception occurs and are > accessed before any kernel code at all runs. Move them into > cpu_entry_area. > > Signed-off-by: Andy Lutomirski > Signed-off-by: Thomas

[tip:x86/urgent] x86/tlb: Refactor CR4 setting and shadow write

2017-11-25 Thread tip-bot for Nadav Amit
Commit-ID: 0c3292ca8025c5aef44dc389ac3a6bf4a325e0be Gitweb: https://git.kernel.org/tip/0c3292ca8025c5aef44dc389ac3a6bf4a325e0be Author: Nadav Amit AuthorDate: Fri, 24 Nov 2017 19:29:06 -0800 Committer: Thomas Gleixner CommitDate: Sat, 25 Nov 2017 13:28:43 +0100 x86/tlb: Refactor CR4

[tip:x86/urgent] x86/tlb: Disable interrupts when changing CR4

2017-11-25 Thread tip-bot for Nadav Amit
Commit-ID: 9d0b62328d34c7044114d4f4281981d4c537c4ba Gitweb: https://git.kernel.org/tip/9d0b62328d34c7044114d4f4281981d4c537c4ba Author: Nadav Amit AuthorDate: Fri, 24 Nov 2017 19:29:07 -0800 Committer: Thomas Gleixner CommitDate: Sat, 25 Nov 2017 13:28:43 +0100 x86/tlb: Disable

Re: [PATCH 22/43] x86/mm/kaiser: Prepare assembly for entry/exit CR3 switching

2017-11-25 Thread Thomas Gleixner
On Sat, 25 Nov 2017, Thomas Gleixner wrote: > On Fri, 24 Nov 2017, Ingo Molnar wrote: > > @@ -1288,6 +1308,8 @@ ENTRY(error_entry) > > * from user mode due to an IRET fault. > > */ > > SWAPGS > > + /* We have user CR3. Change to kernel CR3. */ > > + SWITCH_TO_KERNEL_CR3

( Compensation Reinbursement )

2017-11-25 Thread United Nations
View the enclosed file for your Compensation Reinbursement. United Nations Compensation Unit.docx Description: Binary data

Re: [PATCH v5 10/11] intel_sgx: glue code for in-kernel LE

2017-11-25 Thread Jarkko Sakkinen
On Fri, Nov 17, 2017 at 03:07:05PM -0800, Darren Hart wrote: > On Mon, Nov 13, 2017 at 09:45:27PM +0200, Jarkko Sakkinen wrote: > > Glue code for hosting in-kernel Launch Enclave (LE) by using the user > > space helper framework. > > > > Tokens for launching enclaves are generated with by the

IRQ not handled on my Acer Aspire R3-131T

2017-11-25 Thread Florian Dollinger
Hi there! My machine is an Acer Aspire R3-131T, the firmware installed is the latest (1.17, released 2017/01/04). My problem is that my kernel log is overflooded with the following error: [5.356743] irq 173, desc: 9c9bb7b48800, depth: 1, count: 0, unhandled: 0 [5.356745]

06222d856e ("x86/mm/kaiser: Use PCID feature to make user and kernel switches faster"): BUG: kernel hang in boot stage

2017-11-25 Thread Fengguang Wu
Hi Dave, Here are two more error messages for commit https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.x86/mm commit 06222d856e45d727c18665ed37419d653f1dbef5 Author: Dave Hansen AuthorDate: Wed Nov 22 16:35:09 2017 -0800 Commit: Ingo Molnar CommitDate: Fri Nov 24

Re: [PATCH 0/3] scsi: arcmsr: add driver module parameter - (linux-kernel: dan.carpen...@oracle.com exclusive) msi_enable, msix_enable

2017-11-25 Thread Kristian Rasmussen
On 24.11.2017 15:53, Dan Carpenter - dan.carpen...@oracle.com wrote: > Is there a crash or a performance issue? What does the bug in the > current code look like from a user perspective? It looks like this: https://bugzilla.kernel.org/show_bug.cgi?id=197877 dmesg output can be found in the bug

21729f81ce ("x86/mm: Provide general kernel support for memory encryption"): BUG: kernel reboot-without-warning in early-boot stage, last printk: early console in setup code

2017-11-25 Thread Fengguang Wu
Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 21729f81ce8ae76a6995681d40e16f7ce8075db4 Author: Tom Lendacky AuthorDate: Mon Jul 17 16:10:07 2017 -0500 Commit: Ingo

Re: [PATCH v4] iio : Add cm3218 smbus ara and acpi support

2017-11-25 Thread Jonathan Cameron
On Tue, 21 Nov 2017 09:22:16 +0800 Phil Reid wrote: > On 20/11/2017 18:57, Mika Westerberg wrote: > > +Jarkko > > > > On Sun, Nov 19, 2017 at 04:35:51PM +, Jonathan Cameron wrote: > >> On Thu, 2 Nov 2017 16:04:07 +0100 > >> Wolfram Sang wrote: > >> > >>> On Thu, Nov 02, 2017 at

Re: [PATCH v4] iio : Add cm3218 smbus ara and acpi support

2017-11-25 Thread Jonathan Cameron
On Mon, 20 Nov 2017 12:57:56 +0200 Mika Westerberg wrote: > +Jarkko > > On Sun, Nov 19, 2017 at 04:35:51PM +, Jonathan Cameron wrote: > > On Thu, 2 Nov 2017 16:04:07 +0100 > > Wolfram Sang wrote: > > > > > On Thu, Nov 02, 2017 at 02:35:50PM +, Jonathan Cameron wrote: > > > > On

Re: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class

2017-11-25 Thread Hans de Goede
Hi, On 11/24/2017 01:19 PM, Heikki Krogerus wrote: Hi, On Tue, Nov 14, 2017 at 11:44:47AM +, Adam Thomson wrote: diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c index 78983e1..7c26c3d 100644 --- a/drivers/usb/typec/tcpm.c +++ b/drivers/usb/typec/tcpm.c @@ -12,6 +12,7 @@

Re: [PATCH v2] iio: adc: aspeed: Deassert reset in probe

2017-11-25 Thread Jonathan Cameron
On Mon, 20 Nov 2017 15:22:38 +1030 Joel Stanley wrote: > On Mon, Nov 20, 2017 at 2:33 AM, Jonathan Cameron wrote: > > On Thu, 2 Nov 2017 14:49:32 + > > Jonathan Cameron wrote: > >> IIO is closed for this cycle anyway now. > >> Otherwise, series looks good. > >> > >> Will pick up when

Re: [PATCH] iio: accel: mma8452: Add single pulse/tap event detection

2017-11-25 Thread Jonathan Cameron
On Sun, 19 Nov 2017 20:48:21 -0500 harinath Nampally wrote: > > > This patch adds following related changes: > > > - defines pulse event related registers > > > - enables and handles single pulse interrupt for fxls8471 > > > - handles IIO_EV_DIR_EITHER in read/write callbacks (because > > >

Re: [PATCH] nvmem: core: Deduplicate bus_find_device() by name matching

2017-11-25 Thread Srinivas Kandagatla
Thanks for the patch, On 25/11/17 11:31, Lukas Wunner wrote: No need to reinvent the wheel, we have bus_find_device_by_name(). Signed-off-by: Lukas Wunner --- drivers/nvmem/core.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) It looks good for me, I will queue it up! diff

Re: [PATCH] nvmem: core: switch to device_property_present for reading property "read-only"

2017-11-25 Thread Srinivas Kandagatla
Thanks for the patch, On 25/11/17 11:56, Heiner Kallweit wrote: Switch to more generic device_property_present to consider also non-DT properties. Signed-off-by: Heiner Kallweit --- drivers/nvmem/core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH net v3] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

2017-11-25 Thread David Miller
From: Aleksey Makarov Date: Thu, 23 Nov 2017 22:34:31 +0300 > From: Sunil Goutham > > Don't offload IP header checksum to NIC. > > This fixes a previous patch which enabled checksum offloading > for both IPv4 and IPv6 packets. So L3 checksum offload was > getting enabled for IPv6 pkts. And

Re: [PATCH] net: thunderbolt: Stop using zero to mean no valid DMA mapping

2017-11-25 Thread David Miller
From: Mika Westerberg Date: Fri, 24 Nov 2017 14:05:36 +0300 > Commit 86dabda426ac ("net: thunderbolt: Clear finished Tx frame bus > address in tbnet_tx_callback()") fixed a DMA-API violation where the > driver called dma_unmap_page() in tbnet_free_buffers() for a bus address > that might already

Re: [PATCH 15/43] x86/entry/64: Create a percpu SYSCALL entry trampoline

2017-11-25 Thread Andy Lutomirski
On Sat, Nov 25, 2017 at 3:40 AM, Borislav Petkov wrote: > On Fri, Nov 24, 2017 at 06:23:43PM +0100, Ingo Molnar wrote: >> From: Andy Lutomirski >> >> Handling SYSCALL is tricky: the SYSCALL handler is entered with every >> single register (except FLAGS), including RSP, live. It somehow needs >>

Re: [PATCH] iio: accel: kxsd9-i2c: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE

2017-11-25 Thread Jonathan Cameron
On Mon, 20 Nov 2017 12:55:18 -0800 Jesse Chan wrote: > This change resolves a new compile-time warning > when built as a loadable module: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/iio/accel/kxsd9-i2c.o > see include/linux/module.h for more information > > This adds the license

Re: [PATCH] iio: adc: qcom-vadc: add missing MODULE_DESCRIPTION/LICENSE

2017-11-25 Thread Jonathan Cameron
On Mon, 20 Nov 2017 12:55:51 -0800 Jesse Chan wrote: > This change resolves a new compile-time warning > when built as a loadable module: > > WARNING: modpost: missing MODULE_LICENSE() in > drivers/iio/adc/qcom-vadc-common.o > see include/linux/module.h for more information > > This adds the

Re: [PATCH 19/43] x86/entry/64: Remove the SYSENTER stack canary

2017-11-25 Thread Borislav Petkov
On Fri, Nov 24, 2017 at 06:23:47PM +0100, Ingo Molnar wrote: > From: Andy Lutomirski > > Now that the SYSENTER stack has a guard page, there's no need for a > canary to detect overflow after the fact. > > Signed-off-by: Andy Lutomirski > Signed-off-by: Thomas Gleixner > Cc: Borislav Petkov >

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-11-25 Thread Sakari Ailus
On Fri, Nov 17, 2017 at 10:33:55AM +0100, jacopo mondi wrote: > Hi Sakari! > > On Fri, Nov 17, 2017 at 02:36:51AM +0200, Sakari Ailus wrote: > > Hi Jacopo, > > > > On Wed, Nov 15, 2017 at 03:25:11PM +0100, jacopo mondi wrote: > > > Hi Sakari, > > >thanks for review! > > > > You're welcome! >

Re: [PATCH] arm64: allwinner: a64: Enable AXP803 for Orangepi Win

2017-11-25 Thread Maxime Ripard
On Thu, Nov 23, 2017 at 11:05:36PM +0530, Jagan Teki wrote: > Enable AXP803 PMIC and regulators for Orangepi Win. > > Signed-off-by: Jagan Teki Applied, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description:

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-11-25 Thread Maxime Ripard
On Thu, Nov 23, 2017 at 09:14:44AM +0800, Yong wrote: > > On Wed, Nov 22, 2017 at 09:33:06AM +0800, Yong wrote: > > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > > > > and CSI1 is used for

Re: [PATCH v1 08/10] media: i2c: ov772x: Remove soc_camera dependencies

2017-11-25 Thread Sakari Ailus
On Fri, Nov 17, 2017 at 10:14:51AM +0100, jacopo mondi wrote: > Hi Sakari! > > On Fri, Nov 17, 2017 at 02:43:15AM +0200, Sakari Ailus wrote: > > Hi Jacopo, > > > > On Wed, Nov 15, 2017 at 11:56:01AM +0100, Jacopo Mondi wrote: > > > > > [snip] > > > > +#include > > > #include > > > #include

[PATCH 0/2] video: ssd1307fb: Adjustments for ssd1307fb_probe()

2017-11-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 25 Nov 2017 16:56:46 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/video/fbdev/ssd1307fb.c | 4 ++-- 1

[PATCH 1/2] video: ssd1307fb: Delete an error message for a failed memory allocation in ssd1307fb_probe()

2017-11-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 25 Nov 2017 16:45:56 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/ssd1307fb.c | 1 - 1 file changed, 1 deletion(-)

[PATCH 2/2] video: ssd1307fb: Improve a size determination in ssd1307fb_probe()

2017-11-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 25 Nov 2017 16:50:26 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

Re: [PATCH] x86/mm/kaiser: Fix IRQ entries text section mapping

2017-11-25 Thread Thomas Gleixner
On Sat, 25 Nov 2017, Ingo Molnar wrote: > kaiser_add_user_map_ptrs_early(__entry_text_start, __entry_text_end, > __PAGE_KERNEL_RX | _PAGE_GLOBAL); > + kaiser_add_user_map_ptrs_early(__irqentry_text_start, > __irqentry_text_end, > +

Re: [PATCH v5 1/2] iio : Add cm3218 smbus ara and acpi support

2017-11-25 Thread Jonathan Cameron
On Wed, 22 Nov 2017 23:52:33 +0100 Marc CAPDEVILLE wrote: > On asus T100, Capella cm3218 chip is implemented as ambiant light > sensor. This chip expose an smbus ARA protocol device on standard > address 0x0c. The chip is not functional before all alerts are > acknowledged. > On asus T100, this

Re: [PATCH 20/43] x86/entry: Clean up SYSENTER_stack code

2017-11-25 Thread Borislav Petkov
On Fri, Nov 24, 2017 at 06:23:48PM +0100, Ingo Molnar wrote: > From: Andy Lutomirski > > The existing code was a mess, mainly because C arrays are nasty. > Turn SYSENTER_stack into a struct, add a helper to find it, and do > all the obvious cleanups this enables. > > Signed-off-by: Andy

Re: [PATCH 1/2] iio: adc: ina2xx: Make calibration register value fixed

2017-11-25 Thread Jonathan Cameron
On Wed, 22 Nov 2017 16:32:14 +0100 Maciej Purski wrote: > Calibration register is used for calculating current register in > hardware according to datasheet: > current = shunt_volt * calib_register / 2048 (ina 226) > current = shunt_volt * calib_register / 4096 (ina 219) > > Fix calib_register

Re: [PATCH] iio: accel: remove redundant pointer pdata

2017-11-25 Thread Jonathan Cameron
On Wed, 22 Nov 2017 14:32:11 + Colin King wrote: > From: Colin Ian King > > Pointer pdata is being assigned but it is never being used, hence > it is redundant and can be removed. Cleans up clang warning: > > drivers/iio/accel/st_accel_core.c:952:3: warning: Value stored to 'pdata' > is

Re: [PATCH 20/43] x86/entry: Clean up SYSENTER_stack code

2017-11-25 Thread Thomas Gleixner
On Sat, 25 Nov 2017, Borislav Petkov wrote: > > - > > + wrmsr(MSR_IA32_SYSENTER_ESP, (unsigned long)(cpu_SYSENTER_stack(cpu) + > > 1), 0); > > wrmsr(MSR_IA32_SYSENTER_EIP, (unsigned long)entry_SYSENTER_32, 0); > > Right, so we have now two TSS thingies, AFAICT: > > tss =

Re: [PATCH 20/43] x86/entry: Clean up SYSENTER_stack code

2017-11-25 Thread Andy Lutomirski
> On Nov 25, 2017, at 9:50 AM, Thomas Gleixner wrote: > > On Sat, 25 Nov 2017, Borislav Petkov wrote: >>> - >>> +wrmsr(MSR_IA32_SYSENTER_ESP, (unsigned long)(cpu_SYSENTER_stack(cpu) + >>> 1), 0); >>>wrmsr(MSR_IA32_SYSENTER_EIP, (unsigned long)entry_SYSENTER_32, 0); >> >> Right, so we

Re: [PATCH 20/43] x86/entry: Clean up SYSENTER_stack code

2017-11-25 Thread Thomas Gleixner
On Sat, 25 Nov 2017, Andy Lutomirski wrote: > > On Nov 25, 2017, at 9:50 AM, Thomas Gleixner wrote: > > > > On Sat, 25 Nov 2017, Borislav Petkov wrote: > >>> - > >>> +wrmsr(MSR_IA32_SYSENTER_ESP, (unsigned long)(cpu_SYSENTER_stack(cpu) > >>> + 1), 0); > >>>wrmsr(MSR_IA32_SYSENTER_EIP,

Re: [PATCH 20/43] x86/entry: Clean up SYSENTER_stack code

2017-11-25 Thread Borislav Petkov
On Sat, Nov 25, 2017 at 06:03:36PM +0100, Thomas Gleixner wrote: > > Maybe I should rename cpu_tss to cpu_tss_rw in that patch. > > For clarity that would be nice. + a comment stating the alias mapping. It took tglx and me a while on IRC to figure it out. :-) Thx. -- Regards/Gruss, Boris.

Re: [PATCH 24/43] x86/mm/kaiser: Mark per-cpu data structures required for entry/exit

2017-11-25 Thread Thomas Gleixner
On Fri, 24 Nov 2017, Ingo Molnar wrote: > diff --git a/arch/x86/include/asm/desc.h b/arch/x86/include/asm/desc.h > index aab4fe9f49f8..300090d1c209 100644 > --- a/arch/x86/include/asm/desc.h > +++ b/arch/x86/include/asm/desc.h > @@ -46,7 +46,7 @@ struct gdt_page { > struct desc_struct

Re: [PATCH v2 2/2] x86: disable IRQs before changing CR4

2017-11-25 Thread Nadav Amit
Thomas Gleixner wrote: > On Fri, 24 Nov 2017, Nadav Amit wrote: >> /* Set in this cpu's CR4. */ >> -static inline void cr4_set_bits(unsigned long mask) >> +static inline void cr4_set_bits_irqs_off(unsigned long mask) > > This change is kinda weird. I'd expect that there is a corresponding >

Re: [PATCH] lib: memmove: Use optimised memcpy if possible

2017-11-25 Thread PrasannaKumar Muralidharan
Hi, On 4 October 2017 at 22:26, PrasannaKumar Muralidharan wrote: > When there is no overlap between src and dst use optimised memcpy if it > is available. > > Signed-off-by: Paul Burton > Signed-off-by: PrasannaKumar Muralidharan > --- > This change is a small part of a patch [1] from Paul

Re: [PATCH v2 2/2] x86: disable IRQs before changing CR4

2017-11-25 Thread Thomas Gleixner
On Sat, 25 Nov 2017, Nadav Amit wrote: > Thomas Gleixner wrote: > > > On Fri, 24 Nov 2017, Nadav Amit wrote: > >> /* Set in this cpu's CR4. */ > >> -static inline void cr4_set_bits(unsigned long mask) > >> +static inline void cr4_set_bits_irqs_off(unsigned long mask) > > > > This change is

Re: [PATCH 20/43] x86/entry: Clean up SYSENTER_stack code

2017-11-25 Thread Andy Lutomirski
On Sat, Nov 25, 2017 at 9:10 AM, Borislav Petkov wrote: > On Sat, Nov 25, 2017 at 06:03:36PM +0100, Thomas Gleixner wrote: >> > Maybe I should rename cpu_tss to cpu_tss_rw in that patch. >> >> For clarity that would be nice. > > + a comment stating the alias mapping. It took tglx and me a while

[PATCH] x86/orc: Don't bail on stack overflow

2017-11-25 Thread Andy Lutomirski
If we overflow the stack into a guard page and then try to unwind it with ORC, it should work perfectly: by construction, there can't be any meaningful data in the guard page because no writes to the guard page will have succeeded. ORC seems entirely capable of unwinding in this situation, except

Re: [PATCH v2 2/2] x86: disable IRQs before changing CR4

2017-11-25 Thread Nadav Amit
Thomas Gleixner wrote: > On Sat, 25 Nov 2017, Nadav Amit wrote: >> Thomas Gleixner wrote: >> >>> On Fri, 24 Nov 2017, Nadav Amit wrote: /* Set in this cpu's CR4. */ -static inline void cr4_set_bits(unsigned long mask) +static inline void cr4_set_bits_irqs_off(unsigned long mask)

Re: [PATCH 1/2] iio: chemical: sgpxx: Support Sensirion SGPxx sensors

2017-11-25 Thread Jonathan Cameron
On Tue, 21 Nov 2017 22:46:07 +0100 (CET) Peter Meerwald-Stadler wrote: > Hello, > > some quick comments on this driver below A few additional bits from me but I think Peter got most of the key stuff. > > I think documentation is missing and the ABI is a bit problematic and > unusual > > >

Re: [PATCH 2/2] iio: chemical: sgpxx: triggered buffer support

2017-11-25 Thread Jonathan Cameron
On Tue, 21 Nov 2017 17:11:29 +0100 Andreas Brauchli wrote: > Support triggered buffer for use with e.g. hrtimer for automated > polling to ensure that the sensor's internal baseline is correctly > updated independently of the use-case. Given the really strict timing requirements for this device

[PATCH] Staging: sm750fb: Fix coding style issue in ddk750_sii164.c

2017-11-25 Thread Jeremy Lacomis
This is a patch to the ddk750_sii164.c file that fixes line length warnings found by the checkpatch.pl script Signed-off-by: Jeremy Lacomis --- drivers/staging/sm750fb/ddk750_sii164.c | 39 +++-- 1 file changed, 23 insertions(+), 16 deletions(-) diff --git

Re: [PATCH v5 10/11] intel_sgx: glue code for in-kernel LE

2017-11-25 Thread Jarkko Sakkinen
On Fri, Nov 17, 2017 at 03:07:05PM -0800, Darren Hart wrote: > No incremental cleanup here - appears to all be handled through > sgx_le_stop - do I have that right? Yes. This is correct. /Jarkko

Re: [GIT PULL] afs: Fixes

2017-11-25 Thread Linus Torvalds
On Fri, Nov 24, 2017 at 4:22 AM, David Howells wrote: > > (2) Don't write to a page that's being written out, but wait for it to > complete. So I see in the commit message why afs needs to do this, but it's worth pointing out that it's (a) impossible to avoid the "inconsistent data" case

Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-25 Thread Ishraq Ibne Ashraf
Hi, What was broken was private/device specific IOCTL calls implemented by this driver. The standard IOCTL calls worked and the driver worked as it was in client mode. But in AP mode with hostapd (https://w1.fi/hostapd/) the rtl871xdrv driver of hostapd (which is required for using devices

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-11-25 Thread jacopo mondi
Hi Sakari! On Sat, Nov 25, 2017 at 05:56:14PM +0200, Sakari Ailus wrote: > On Fri, Nov 17, 2017 at 10:33:55AM +0100, jacopo mondi wrote: > > Hi Sakari! > > [snip] > > I would like to make sure we're all on the same page with this. My > > preference would be: > > > > 1) Have renesas-ceu.c driver

Re: [PATCH] x86/orc: Don't bail on stack overflow

2017-11-25 Thread Andy Lutomirski
On Sat, Nov 25, 2017 at 9:28 AM, Andy Lutomirski wrote: > If we overflow the stack into a guard page and then try to unwind > it with ORC, it should work perfectly: by construction, there can't > be any meaningful data in the guard page because no writes to the > guard page will have succeeded. >

[PATCH 2/2] staging: sm750b: Fix coding style issues in sm750_accel.c

2017-11-25 Thread Jeremy Lacomis
This is a patch to sm750_accel.c that fixes 80-character line length warnings found by checkpatch.pl. It also fixes some grammatical errors in comments and moves parameter-specific comments from inline to before the function. Signed-off-by: Jeremy Lacomis ---

[PATCH 1/2] staging: sm750fb: Fix coding style in ddk750_sii164.h

2017-11-25 Thread Jeremy Lacomis
This patch to ddk750_sii164.h fixes line length warnings found by the checkpatch.pl script and reformats comments uniformly. Signed-off-by: Jeremy Lacomis --- drivers/staging/sm750fb/ddk750_sii164.h | 57 + 1 file changed, 22 insertions(+), 35 deletions(-) diff

[PATCH v3] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-25 Thread ishraq . i . ashraf
From: Ishraq Ibne Ashraf Commit 8bfb36766064 ("wireless: wext: remove ndo_do_ioctl fallback") breaks private WEXT IOCTL calls of this driver as these are not invoked through ndo_do_ioctl interface anymore. As a result hostapd stops working with this driver. In this patch this problem is solved

[PATCH] scsi: libfc: fix ELS request handling

2017-11-25 Thread Martin Wilck
The modification of fc_lport_recv_els_req() in commit fcabb09e59a7 (merged in 4.12-rc1) caused certain requests not to be handled at all. Fix that. Fixes: fcabb09e59a7 "scsi: libfc: directly call ELS request handlers" Signed-off-by: Martin Wilck --- drivers/scsi/libfc/fc_lport.c | 4 1

Re: [PATCH 2/2] hwmon: (ina2xx) Make calibration register value fixed

2017-11-25 Thread Guenter Roeck
On 11/22/2017 07:32 AM, Maciej Purski wrote: Calibration register is used for calculating current register in hardware according to datasheet: current = shunt_volt * calib_register / 2048 (ina 226) current = shunt_volt * calib_register / 4096 (ina 219) Fix calib_register value to 2048 for

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Pavel Machek
On Fri 2017-11-17 15:06:39, Mauro Carvalho Chehab wrote: > Hi Thomas, > > Em Fri, 17 Nov 2017 11:00:33 +0100 (CET) > Thomas Gleixner escreveu: > > > Subject: Documentation: Add license-rules.rst to describe how to properly > > identify file licenses > > From: Thomas Gleixner > > Date: Fri, 10

hi3521a syscon-reboot issue, reboot fails oddly.

2017-11-25 Thread Marty E. Plummer
Greetings, Having a slight issue with getting reboot to work on the board I'm tinkering with; according to the documentation writing any value to 0x12050004 should reset the system, as such I have the following snippet in my dts to make it work: sysctrl: system-controller@1205 {

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Pavel Machek
On Wed 2017-11-22 14:48:04, Greg Kroah-Hartman wrote: > On Wed, Nov 22, 2017 at 09:51:17AM -0200, Mauro Carvalho Chehab wrote: > > Em Wed, 22 Nov 2017 12:12:04 +0100 (CET) > > Thomas Gleixner escreveu: > > > > > On Fri, 17 Nov 2017, Christoph Hellwig wrote: > > > > On Fri, Nov 17, 2017 at

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Linus Torvalds
On Sat, Nov 25, 2017 at 9:04 AM, Pavel Machek wrote: > > That does not sound like he was deciding between /* */ and //. And > actually this was in context of files with no existing license. You > made the ugly patches. Stop hiding behind Linus. No, Linus happily stands up for //. I really don't

Re: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-25 Thread Pavel Machek
Hi! > > This would be even better: > > > > /* > > * Driver for SMSC USB3503 USB 2.0 hub controller driver > > * > > * Copyright (c) 2012-2013 Dongjin Kim (tobet...@gmail.com) > > */ > > ... > > SPDX_MODULE_LICENSE("GPL-2.0+") > > > > So yes, SPDX can be improvement. But in current

[PATCH] net: openvswitch: datapath: fix data type in queue_gso_packets

2017-11-25 Thread Gustavo A. R. Silva
gso_type is being used in binary AND operations together with SKB_GSO_UDP. The issue is that variable gso_type is of type unsigned short and SKB_GSO_UDP expands to more than 16 bits: SKB_GSO_UDP = 1 << 16 this makes any binary AND operation between gso_type and SKB_GSO_UDP to be always zero,

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Pavel Machek
On Sat 2017-11-25 09:11:58, Linus Torvalds wrote: > On Sat, Nov 25, 2017 at 9:04 AM, Pavel Machek wrote: > > > > That does not sound like he was deciding between /* */ and //. And > > actually this was in context of files with no existing license. You > > made the ugly patches. Stop hiding behind

Re: [PATCH 42/43] x86/mm/kaiser: Allow KAISER to be enabled/disabled at runtime

2017-11-25 Thread Thomas Gleixner
On Fri, 24 Nov 2017, Ingo Molnar wrote: > From: Dave Hansen > > The KAISER CR3 switches are expensive for many reasons. Not all systems > benefit from the protection provided by KAISER. Some of them can not > pay the high performance cost. > > This patch adds a debugfs file. To disable

Re: [PATCH v2] VSOCK: Don't call vsock_stream_has_data in atomic context

2017-11-25 Thread David Miller
From: Jorgen Hansen Date: Fri, 24 Nov 2017 06:25:28 -0800 > When using the host personality, VMCI will grab a mutex for any > queue pair access. In the detach callback for the vmci vsock > transport, we call vsock_stream_has_data while holding a spinlock, > and vsock_stream_has_data will access

Re: [PATCH net] net: dsa: fix 'increment on 0' warning

2017-11-25 Thread David Miller
From: Vivien Didelot Date: Fri, 24 Nov 2017 11:36:06 -0500 > Setting the refcount to 0 when allocating a tree to match the number of > switch devices it holds may cause an 'increment on 0; use-after-free', > if CONFIG_REFCOUNT_FULL is enabled. > > To fix this, do not decrement the refcount of a

lib/zstd/decompress.c:416:2: warning: argument 1 null where non-null expected

2017-11-25 Thread kbuild test robot
Hi Nick, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 844056fd74ebdd826bd23a7d989597e15f478acb commit: 5c1aab1dd5445ed8bdcdbb575abc1b0d7ee5b2e7 btrfs: Add zstd support date: 3 months ago config:

[PATCH v6 05/11] x86: add SGX MSRs to msr-index.h

2017-11-25 Thread Jarkko Sakkinen
From: Haim Cohen These MSRs hold the SHA256 checksum of the currently configured root key for enclave signatures. Signed-off-by: Haim Cohen Signed-off-by: Jarkko Sakkinen --- arch/x86/include/asm/msr-index.h | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v6 02/11] x86: add SGX definition to cpufeature

2017-11-25 Thread Jarkko Sakkinen
From: Kai Huang Added X86_FEATURE_SGX, which identifies that CPU supports software guard extensions (SGX). Signed-off-by: Kai Huang Signed-off-by: Jarkko Sakkinen --- arch/x86/include/asm/cpufeatures.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/include/asm/cpufeatures.h

[PATCH v6 01/11] intel_sgx: updated MAINTAINERS

2017-11-25 Thread Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2d3d750b19c0..30a4b7f97a93 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14932,6 +14932,11 @@ L: linux...@kvack.org S: Maintained F: mm/zswap.c

[PATCH v6 07/11] intel_sgx: ptrace() support

2017-11-25 Thread Jarkko Sakkinen
Implemented VMA callbacks in order to ptrace() debug enclaves. With debug enclaves data can be read and write the memory word at a time by using ENCLS(EDBGRD) and ENCLS(EDBGWR) leaf instructions. Signed-off-by: Jarkko Sakkinen --- drivers/platform/x86/intel_sgx/sgx_vma.c | 119

[PATCH v6 00/11] Intel SGX Driver

2017-11-25 Thread Jarkko Sakkinen
Intel(R) SGX is a set of CPU instructions that can be used by applications to set aside private regions of code and data. The code outside the enclave is disallowed to access the memory inside the enclave by the CPU access control. In a way you can think that SGX provides inverted sandbox. It

[PATCH v6 03/11] x86: define IA32_FEATURE_CONTROL.SGX_ENABLE

2017-11-25 Thread Jarkko Sakkinen
From: Sean Christopherson When IA32_FEATURE_CONTROL.SGX_ENABLE and IA32_FEATURE_CONTROL.LOCK are set by the pre-boot firmware, SGX is usable by the OS. Signed-off-by: Sean Christopherson Signed-off-by: Jarkko Sakkinen --- arch/x86/include/asm/msr-index.h | 1 + 1 file changed, 1 insertion(+)

[PATCH v6 04/11] x86: define IA32_FEATUE_CONTROL.SGX_LC

2017-11-25 Thread Jarkko Sakkinen
When IA32_FEATURE_CONTROL.SGX_LC identifies that the root key for enclave signatures can be configured either by the OS or pre-boot firmware. If this the case, IA32_SGXLEPUBKEYHASHn MSRs (0 < n < 4) can be used to set the SHA256 of the root key. IA32_FEATURE_CONTROL bit 17 controls whether the

[PATCH v6 08/11] intel_sgx: in-kernel launch enclave

2017-11-25 Thread Jarkko Sakkinen
This commits implements the in-kernel launch enclave. It is wrapped into a user space program that reads SIGSTRUCT instances from stdin and outputs launch tokens to stdout. The commit also adds enclave signing tool that is used by kbuild to measure and sign the launch enclave.

[PATCH v6 09/11] fs/pipe.c: export create_pipe_files() and replace_fd()

2017-11-25 Thread Jarkko Sakkinen
Exported create_pipe_files() and replace_fd() because the SGX driver needs to be able to setup pipes in order to communicate with the helper process that hosts the Launch Enclave (LE). The pipe creation will be done in the init-callback supplied to call_usermodehelper_setup(). The driver will use

[PATCH v6 06/11] intel_sgx: driver for Intel Software Guard Extensions

2017-11-25 Thread Jarkko Sakkinen
Intel SGX is a set of CPU instructions that can be used by applications to set aside private regions of code and data. The code outside the enclave is disallowed to access the memory inside the enclave by the CPU access control. SGX driver provides a ioctl API for loading and initializing

[PATCH v6 10/11] intel_sgx: glue code for in-kernel LE

2017-11-25 Thread Jarkko Sakkinen
Glue code for hosting in-kernel Launch Enclave (LE) by using the user space helper framework. Tokens for launching enclaves are generated with by the following protocol: 1. The driver sends a SIGSTRUCT blob to the LE hosting process to the input pipe. 2. The LE hosting process reads the

[PATCH v6 11/11] intel_sgx: driver documentation

2017-11-25 Thread Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen --- Documentation/index.rst | 1 + Documentation/x86/intel_sgx.rst | 101 2 files changed, 102 insertions(+) create mode 100644 Documentation/x86/intel_sgx.rst diff --git a/Documentation/index.rst

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Linus Torvalds
On Sat, Nov 25, 2017 at 9:17 AM, Pavel Machek wrote: > > There's logical place in the comment, and it should look like this: > > /* > * Driver for SMSC USB3503 USB 2.0 hub controller driver > * > * SPDX-License-Identifier: GPL-2.0+ > * Copyright (c) 2012-2013 Dongjin Kim

Re: [PATCH 42/43] x86/mm/kaiser: Allow KAISER to be enabled/disabled at runtime

2017-11-25 Thread Andy Lutomirski
> On Nov 25, 2017, at 12:18 PM, Thomas Gleixner wrote: > >> On Fri, 24 Nov 2017, Ingo Molnar wrote: >> >> From: Dave Hansen >> >> The KAISER CR3 switches are expensive for many reasons. Not all systems >> benefit from the protection provided by KAISER. Some of them can not >> pay the high

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-25 Thread Mauro Carvalho Chehab
Em Sat, 25 Nov 2017 09:30:46 -1000 Linus Torvalds escreveu: > On Sat, Nov 25, 2017 at 9:17 AM, Pavel Machek wrote: > > > > There's logical place in the comment, and it should look like this: > > > > /* > > * Driver for SMSC USB3503 USB 2.0 hub controller driver > > * > > *

Re: [PATCH 42/43] x86/mm/kaiser: Allow KAISER to be enabled/disabled at runtime

2017-11-25 Thread Thomas Gleixner
On Sat, 25 Nov 2017, Andy Lutomirski wrote: > > On Nov 25, 2017, at 12:18 PM, Thomas Gleixner wrote: > >> On Fri, 24 Nov 2017, Ingo Molnar wrote: > >> > >> From: Dave Hansen > >> > >> The KAISER CR3 switches are expensive for many reasons. Not all systems > >> benefit from the protection

Re: [PATCH] x86/mm/kaiser: Fix IRQ entries text section mapping

2017-11-25 Thread Steven Rostedt
On Sat, 25 Nov 2017 17:08:08 +0100 (CET) Thomas Gleixner wrote: > Tracing uses it to stop the printout of the function graph. Should be safe > to print the C-Code functions. It uses it to filter out interrupts, as well as to print the: "<==" "==>" annotations. Since function

<    1   2   3   4   >