Re: [PATCH 1/4] iio: gyro: add support for fxas21002c

2018-08-27 Thread Joe Perches
On Mon, 2018-08-27 at 18:08 +0100, Jonathan Cameron wrote: > On Sat, 25 Aug 2018 22:19:07 +0100 > Afonso Bordado wrote: > > > FXAS21002C is a 3 axis gyroscope with integrated temperature sensor > > > > Signed-off-by: Afonso Bordado > > Hi, > > Driver is pretty clean so only a few minor

Re: [PATCH 1/4] iio: gyro: add support for fxas21002c

2018-08-27 Thread Joe Perches
On Mon, 2018-08-27 at 18:08 +0100, Jonathan Cameron wrote: > On Sat, 25 Aug 2018 22:19:07 +0100 > Afonso Bordado wrote: > > > FXAS21002C is a 3 axis gyroscope with integrated temperature sensor > > > > Signed-off-by: Afonso Bordado > > Hi, > > Driver is pretty clean so only a few minor

Re: [PATCH 14/25] ubifs: Add authentication nodes to journal

2018-08-27 Thread Richard Weinberger
Am Mittwoch, 4. Juli 2018, 14:41:26 CEST schrieb Sascha Hauer: > Nodes that are written to flash can only be authenticated through the > index after the next commit. When a journal replay is necessary the > nodes are not yet referenced by the index and thus can't be > authenticated. > > This

Re: [PATCH 14/25] ubifs: Add authentication nodes to journal

2018-08-27 Thread Richard Weinberger
Am Mittwoch, 4. Juli 2018, 14:41:26 CEST schrieb Sascha Hauer: > Nodes that are written to flash can only be authenticated through the > index after the next commit. When a journal replay is necessary the > nodes are not yet referenced by the index and thus can't be > authenticated. > > This

Re: [PATCH] selftests: kselftest: Remove outdated comment

2018-08-27 Thread Thiago Jung Bauermann
Shuah Khan writes: > On 07/24/2018 08:57 PM, Thiago Jung Bauermann wrote: >> Commit 3c07aaef6598 ("selftests: kselftest: change KSFT_SKIP=4 instead of >> KSFT_PASS") reverted commit 11867a77eb85 ("selftests: kselftest framework: >> change skip exit code to 0") but missed removing the comment

Re: [PATCH] selftests: kselftest: Remove outdated comment

2018-08-27 Thread Thiago Jung Bauermann
Shuah Khan writes: > On 07/24/2018 08:57 PM, Thiago Jung Bauermann wrote: >> Commit 3c07aaef6598 ("selftests: kselftest: change KSFT_SKIP=4 instead of >> KSFT_PASS") reverted commit 11867a77eb85 ("selftests: kselftest framework: >> change skip exit code to 0") but missed removing the comment

Re: [PATCH v2] compiler.h: give up __compiletime_assert_fallback()

2018-08-27 Thread Daniel Santos
Hello Nick, On 08/27/2018 03:09 PM, Nick Desaulniers wrote: >> Now we're back to the question of "what do you mean by 'constant'"? If >> you mean a C constant expression (as defined in the C standard) than >> almost none of this code fits that criteria. For these compile-time >> assertions to

Re: [PATCH v2] compiler.h: give up __compiletime_assert_fallback()

2018-08-27 Thread Daniel Santos
Hello Nick, On 08/27/2018 03:09 PM, Nick Desaulniers wrote: >> Now we're back to the question of "what do you mean by 'constant'"? If >> you mean a C constant expression (as defined in the C standard) than >> almost none of this code fits that criteria. For these compile-time >> assertions to

Re: [PATCH 1/3] ARM: dts: NSP: Enable SFP on bcm958625hr

2018-08-27 Thread Andrew Lunn
> @@ -210,6 +228,17 @@ > reg = <4>; > }; > > + port@5 { > + label = "sfp"; > + phy-mode = "sgmii"; > + reg = <5>; > + sfp = <>; > + fixed-link { > +

Re: [PATCH 1/3] ARM: dts: NSP: Enable SFP on bcm958625hr

2018-08-27 Thread Andrew Lunn
> @@ -210,6 +228,17 @@ > reg = <4>; > }; > > + port@5 { > + label = "sfp"; > + phy-mode = "sgmii"; > + reg = <5>; > + sfp = <>; > + fixed-link { > +

Re: [PATCH 4.4 0/5] 4.4.153-stable review

2018-08-27 Thread Shuah Khan
On 08/26/2018 12:42 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.153 release. > There are 5 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

Re: [PATCH 4.4 0/5] 4.4.153-stable review

2018-08-27 Thread Shuah Khan
On 08/26/2018 12:42 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.153 release. > There are 5 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

[PATCH] sysctl: do not allow a 64bit value write in a 32bit knob

2018-08-27 Thread Aristeu Rozanski
Writing to a sysctl file that uses proc_dointvec_minmax like user/max_uts_namespaces a larger than 32 bit value won't cause an error as expected but instead will zero its value: # echo 21474836480 > max_uts_namespaces # cat max_uts_namespaces 0 This patches fixes it.

[PATCH] sysctl: do not allow a 64bit value write in a 32bit knob

2018-08-27 Thread Aristeu Rozanski
Writing to a sysctl file that uses proc_dointvec_minmax like user/max_uts_namespaces a larger than 32 bit value won't cause an error as expected but instead will zero its value: # echo 21474836480 > max_uts_namespaces # cat max_uts_namespaces 0 This patches fixes it.

RE: Linux 4.19-rc1

2018-08-27 Thread Winkler, Tomas
> > On Sun, Aug 26, 2018 at 3:51 PM Linus Torvalds foundation.org> wrote: > > > > So two weeks have passed, and the merge window for 4.19 is over. > > > > > > Anyway, go forth and test, > > > > I am seeing the errors use-after-free errors in mei_cl_write. dmesg as > follows. > Adding Tomas

RE: Linux 4.19-rc1

2018-08-27 Thread Winkler, Tomas
> > On Sun, Aug 26, 2018 at 3:51 PM Linus Torvalds foundation.org> wrote: > > > > So two weeks have passed, and the merge window for 4.19 is over. > > > > > > Anyway, go forth and test, > > > > I am seeing the errors use-after-free errors in mei_cl_write. dmesg as > follows. > Adding Tomas

Re: TLB flushes on fixmap changes

2018-08-27 Thread Nadav Amit
at 12:58 PM, Andy Lutomirski wrote: > On Mon, Aug 27, 2018 at 12:43 PM, Nadav Amit wrote: >> at 12:10 PM, Nadav Amit wrote: >> >>> at 11:58 AM, Andy Lutomirski wrote: >>> On Mon, Aug 27, 2018 at 11:54 AM, Nadav Amit wrote: >> On Mon, Aug 27, 2018 at 10:34 AM, Nadav Amit >>

Re: TLB flushes on fixmap changes

2018-08-27 Thread Nadav Amit
at 12:58 PM, Andy Lutomirski wrote: > On Mon, Aug 27, 2018 at 12:43 PM, Nadav Amit wrote: >> at 12:10 PM, Nadav Amit wrote: >> >>> at 11:58 AM, Andy Lutomirski wrote: >>> On Mon, Aug 27, 2018 at 11:54 AM, Nadav Amit wrote: >> On Mon, Aug 27, 2018 at 10:34 AM, Nadav Amit >>

Re: [PATCH] selftests: kselftest: Remove outdated comment

2018-08-27 Thread Shuah Khan
On 07/24/2018 08:57 PM, Thiago Jung Bauermann wrote: > Commit 3c07aaef6598 ("selftests: kselftest: change KSFT_SKIP=4 instead of > KSFT_PASS") reverted commit 11867a77eb85 ("selftests: kselftest framework: > change skip exit code to 0") but missed removing the comment which that > commit added, so

Re: [PATCH] selftests: kselftest: Remove outdated comment

2018-08-27 Thread Shuah Khan
On 07/24/2018 08:57 PM, Thiago Jung Bauermann wrote: > Commit 3c07aaef6598 ("selftests: kselftest: change KSFT_SKIP=4 instead of > KSFT_PASS") reverted commit 11867a77eb85 ("selftests: kselftest framework: > change skip exit code to 0") but missed removing the comment which that > commit added, so

Re: [PATCH v2] compiler.h: give up __compiletime_assert_fallback()

2018-08-27 Thread Nick Desaulniers
On Mon, Aug 27, 2018 at 1:05 PM Daniel Santos wrote: > > Hello Masahiro, > > > On 08/25/2018 01:16 PM, Masahiro Yamada wrote: > > __compiletime_assert_fallback() is supposed to stop building earlier > > by using the negative-array-size method in case the compiler does not > > support "error"

Re: [PATCH v2] compiler.h: give up __compiletime_assert_fallback()

2018-08-27 Thread Nick Desaulniers
On Mon, Aug 27, 2018 at 1:05 PM Daniel Santos wrote: > > Hello Masahiro, > > > On 08/25/2018 01:16 PM, Masahiro Yamada wrote: > > __compiletime_assert_fallback() is supposed to stop building earlier > > by using the negative-array-size method in case the compiler does not > > support "error"

[PATCH] perf annotate: Handle arm64 move instructions

2018-08-27 Thread Kim Phillips
Add default handler for non-jump instructions. This really only has an effect on instructions that compute a PC-relative address, such as 'adrp,' as seen in these couple of examples: BEFORE: adrp x0, 2aa11000 AFTER: adrp x0, kallsyms_token_index+0xce000 BEFORE: adrp x23,

[PATCH] perf annotate: Handle arm64 move instructions

2018-08-27 Thread Kim Phillips
Add default handler for non-jump instructions. This really only has an effect on instructions that compute a PC-relative address, such as 'adrp,' as seen in these couple of examples: BEFORE: adrp x0, 2aa11000 AFTER: adrp x0, kallsyms_token_index+0xce000 BEFORE: adrp x23,

Re: [PATCH] EDAC: Remove the i82443bxgx_edac driver

2018-08-27 Thread Tim Small
On 27/08/18 17:45, Borislav Petkov wrote: > Actually, looking at this driver more - it has been depending on > BROKEN since 2007! Hi, I'd forgotten that it was in BROKEN state. The issue was that the driver was fully functioning, but it clashed with the graphics aperture driver - both use

Re: [PATCH] EDAC: Remove the i82443bxgx_edac driver

2018-08-27 Thread Tim Small
On 27/08/18 17:45, Borislav Petkov wrote: > Actually, looking at this driver more - it has been depending on > BROKEN since 2007! Hi, I'd forgotten that it was in BROKEN state. The issue was that the driver was fully functioning, but it clashed with the graphics aperture driver - both use

Re: [PATCH v2] compiler.h: give up __compiletime_assert_fallback()

2018-08-27 Thread Daniel Santos
Hello Masahiro, On 08/25/2018 01:16 PM, Masahiro Yamada wrote: > __compiletime_assert_fallback() is supposed to stop building earlier > by using the negative-array-size method in case the compiler does not > support "error" attribute, but has never worked like that. > > You can simply try: > >

Re: [PATCH v2] compiler.h: give up __compiletime_assert_fallback()

2018-08-27 Thread Daniel Santos
Hello Masahiro, On 08/25/2018 01:16 PM, Masahiro Yamada wrote: > __compiletime_assert_fallback() is supposed to stop building earlier > by using the negative-array-size method in case the compiler does not > support "error" attribute, but has never worked like that. > > You can simply try: > >

[PATCH] ARM: wire up io_pgetevents syscall

2018-08-27 Thread Stefan Agner
Wire up the new io_pgetevents syscall for ARM. Signed-off-by: Stefan Agner --- arch/arm/tools/syscall.tbl | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/tools/syscall.tbl b/arch/arm/tools/syscall.tbl index fbc74b5fa3ed..8edf93b4490f 100644 --- a/arch/arm/tools/syscall.tbl +++

[PATCH] ARM: wire up io_pgetevents syscall

2018-08-27 Thread Stefan Agner
Wire up the new io_pgetevents syscall for ARM. Signed-off-by: Stefan Agner --- arch/arm/tools/syscall.tbl | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/tools/syscall.tbl b/arch/arm/tools/syscall.tbl index fbc74b5fa3ed..8edf93b4490f 100644 --- a/arch/arm/tools/syscall.tbl +++

[PATCH 1/3] ARM: dts: NSP: Enable SFP on bcm958625hr

2018-08-27 Thread Florian Fainelli
Enable the SFP connected to port 5 of the switch and wire up all GPIOs to the SFP cage. Because of a hardware limitation of the i2c controller on the iProc SoCs which prevents large i2c (> 256 bytes) transactions to work, we use the i2c-gpio interface instead, which does not have that limitation.

[PATCH 1/3] ARM: dts: NSP: Enable SFP on bcm958625hr

2018-08-27 Thread Florian Fainelli
Enable the SFP connected to port 5 of the switch and wire up all GPIOs to the SFP cage. Because of a hardware limitation of the i2c controller on the iProc SoCs which prevents large i2c (> 256 bytes) transactions to work, we use the i2c-gpio interface instead, which does not have that limitation.

[PATCH 0/3] ARM: NSP updates to support switch interrupts/SFP

2018-08-27 Thread Florian Fainelli
Hi all, This patch series updates the ARM NSP DTS and BCM958625HR in order to support the SFP connected to port 5 on these reference boards. I will be submitting the functional changes to drivers/net/dsa/b53 once net-next opens back up, but this is largely independent from getting these 3

[PATCH 2/3] dt-bindings: net: dsa: Document B53 SRAB interrupts and registers

2018-08-27 Thread Florian Fainelli
Document the Broadcom roboswitch Switch Register Access Block interrupt lines and additional register base addresses for port mux configuration and SGMII status/configuration registers. Signed-off-by: Florian Fainelli --- .../devicetree/bindings/net/dsa/b53.txt | 23 +++ 1

[PATCH 0/3] ARM: NSP updates to support switch interrupts/SFP

2018-08-27 Thread Florian Fainelli
Hi all, This patch series updates the ARM NSP DTS and BCM958625HR in order to support the SFP connected to port 5 on these reference boards. I will be submitting the functional changes to drivers/net/dsa/b53 once net-next opens back up, but this is largely independent from getting these 3

[PATCH 2/3] dt-bindings: net: dsa: Document B53 SRAB interrupts and registers

2018-08-27 Thread Florian Fainelli
Document the Broadcom roboswitch Switch Register Access Block interrupt lines and additional register base addresses for port mux configuration and SGMII status/configuration registers. Signed-off-by: Florian Fainelli --- .../devicetree/bindings/net/dsa/b53.txt | 23 +++ 1

[PATCH 3/3] ARM: dts: NSP: Wire up switch interrupts

2018-08-27 Thread Florian Fainelli
The Switch Register Access Block (SRAB) has one interrupt for link state change on each ports (0-5, 7-8) a PHY interrupt, timestamping interrupt and sleep timer interrupts for each management ports (5,7,8). Wire those up so we can utilize them to speed up link resolution. Signed-off-by: Florian

[PATCH 3/3] ARM: dts: NSP: Wire up switch interrupts

2018-08-27 Thread Florian Fainelli
The Switch Register Access Block (SRAB) has one interrupt for link state change on each ports (0-5, 7-8) a PHY interrupt, timestamping interrupt and sleep timer interrupts for each management ports (5,7,8). Wire those up so we can utilize them to speed up link resolution. Signed-off-by: Florian

Re: [PATCH 1/3] xen/gntdev: fix up blockable calls to mn_invl_range_start

2018-08-27 Thread Boris Ostrovsky
On 08/27/2018 07:26 AM, Michal Hocko wrote: > From: Michal Hocko > > 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers") > has introduced blockable parameter to all mmu_notifiers and the notifier > has to back off when called in !blockable case and it could block down > the

Re: [PATCH 1/3] xen/gntdev: fix up blockable calls to mn_invl_range_start

2018-08-27 Thread Boris Ostrovsky
On 08/27/2018 07:26 AM, Michal Hocko wrote: > From: Michal Hocko > > 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers") > has introduced blockable parameter to all mmu_notifiers and the notifier > has to back off when called in !blockable case and it could block down > the

[PATCH] [v2] HID: add support for Apple Magic Keyboards

2018-08-27 Thread Sean O'Brien
USB device Vendor 05ac (Apple) Device 026c (Magic Keyboard with Numeric Keypad) Bluetooth devices Vendor 004c (Apple) Device 0267 (Magic Keyboard) Device 026c (Magic Keyboard with Numeric Keypad) Support already exists for the Magic Keyboard over USB

[PATCH] [v2] HID: add support for Apple Magic Keyboards

2018-08-27 Thread Sean O'Brien
USB device Vendor 05ac (Apple) Device 026c (Magic Keyboard with Numeric Keypad) Bluetooth devices Vendor 004c (Apple) Device 0267 (Magic Keyboard) Device 026c (Magic Keyboard with Numeric Keypad) Support already exists for the Magic Keyboard over USB

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-08-27 Thread Stephen Boyd
Quoting Lina Iyer (2018-08-24 10:14:32) > On Fri, Aug 24 2018 at 02:22 -0600, Stephen Boyd wrote: > >Quoting Lina Iyer (2018-08-17 12:10:23) > >> During suspend the system may power down some of the system rails. As a > >> result, the TLMM hw block may not be operational anymore and wakeup > >>

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-08-27 Thread Stephen Boyd
Quoting Lina Iyer (2018-08-24 10:14:32) > On Fri, Aug 24 2018 at 02:22 -0600, Stephen Boyd wrote: > >Quoting Lina Iyer (2018-08-17 12:10:23) > >> During suspend the system may power down some of the system rails. As a > >> result, the TLMM hw block may not be operational anymore and wakeup > >>

Re: TLB flushes on fixmap changes

2018-08-27 Thread Andy Lutomirski
On Mon, Aug 27, 2018 at 12:43 PM, Nadav Amit wrote: > at 12:10 PM, Nadav Amit wrote: > >> at 11:58 AM, Andy Lutomirski wrote: >> >>> On Mon, Aug 27, 2018 at 11:54 AM, Nadav Amit wrote: > On Mon, Aug 27, 2018 at 10:34 AM, Nadav Amit wrote: > What do you all think? I agree in

Re: TLB flushes on fixmap changes

2018-08-27 Thread Andy Lutomirski
On Mon, Aug 27, 2018 at 12:43 PM, Nadav Amit wrote: > at 12:10 PM, Nadav Amit wrote: > >> at 11:58 AM, Andy Lutomirski wrote: >> >>> On Mon, Aug 27, 2018 at 11:54 AM, Nadav Amit wrote: > On Mon, Aug 27, 2018 at 10:34 AM, Nadav Amit wrote: > What do you all think? I agree in

Re: [PATCH v13 06/13] x86/sgx: Detect Intel SGX

2018-08-27 Thread Dave Hansen
> +config INTEL_SGX_CORE > + prompt "Intel SGX core functionality" > + def_bool n > + depends on X86_64 && CPU_SUP_INTEL > + help > + Intel Software Guard eXtensions (SGX) is a set of CPU instructions > + that allows ring 3 applications to create enclaves, private regions >

Re: [PATCH v13 06/13] x86/sgx: Detect Intel SGX

2018-08-27 Thread Dave Hansen
> +config INTEL_SGX_CORE > + prompt "Intel SGX core functionality" > + def_bool n > + depends on X86_64 && CPU_SUP_INTEL > + help > + Intel Software Guard eXtensions (SGX) is a set of CPU instructions > + that allows ring 3 applications to create enclaves, private regions >

Re: [PATCH] riscv: tlb: Provide definition of tlb_flush() before including tlb.h

2018-08-27 Thread Palmer Dabbelt
On Fri, 24 Aug 2018 11:22:55 PDT (-0700), li...@roeck-us.net wrote: From: Will Deacon As of commit fd1102f0aade ("mm: mmu_notifier fix for tlb_end_vma"), asm-generic/tlb.h now calls tlb_flush() from a static inline function, so we need to make sure that it's declared before #including the

Re: [PATCH v2 01/17] asm: simd context helper API

2018-08-27 Thread Palmer Dabbelt
On Fri, 24 Aug 2018 14:38:33 PDT (-0700), ja...@zx2c4.com wrote: Sometimes it's useful to amortize calls to XSAVE/XRSTOR and the related FPU/SIMD functions over a number of calls, because FPU restoration is quite expensive. This adds a simple header for carrying out this pattern:

Re: [PATCH] riscv: tlb: Provide definition of tlb_flush() before including tlb.h

2018-08-27 Thread Palmer Dabbelt
On Fri, 24 Aug 2018 11:22:55 PDT (-0700), li...@roeck-us.net wrote: From: Will Deacon As of commit fd1102f0aade ("mm: mmu_notifier fix for tlb_end_vma"), asm-generic/tlb.h now calls tlb_flush() from a static inline function, so we need to make sure that it's declared before #including the

Re: [PATCH v2 01/17] asm: simd context helper API

2018-08-27 Thread Palmer Dabbelt
On Fri, 24 Aug 2018 14:38:33 PDT (-0700), ja...@zx2c4.com wrote: Sometimes it's useful to amortize calls to XSAVE/XRSTOR and the related FPU/SIMD functions over a number of calls, because FPU restoration is quite expensive. This adds a simple header for carrying out this pattern:

[PATCH] phy: phy-twl4030-usb: fix denied runtime access

2018-08-27 Thread Andreas Kemnade
When runtime is not enabled, pm_runtime_get_sync() returns -EACCESS, the counter will be incremented but the resume callback not called, so enumeration and charging will not start properly. To avoid that happen, wait and try again later. Practically this happens when the device is woken up from

[PATCH] phy: phy-twl4030-usb: fix denied runtime access

2018-08-27 Thread Andreas Kemnade
When runtime is not enabled, pm_runtime_get_sync() returns -EACCESS, the counter will be incremented but the resume callback not called, so enumeration and charging will not start properly. To avoid that happen, wait and try again later. Practically this happens when the device is woken up from

Re: TLB flushes on fixmap changes

2018-08-27 Thread Nadav Amit
at 12:10 PM, Nadav Amit wrote: > at 11:58 AM, Andy Lutomirski wrote: > >> On Mon, Aug 27, 2018 at 11:54 AM, Nadav Amit wrote: On Mon, Aug 27, 2018 at 10:34 AM, Nadav Amit wrote: What do you all think? >>> >>> I agree in general. But I think that current->mm would need to be

Re: TLB flushes on fixmap changes

2018-08-27 Thread Nadav Amit
at 12:10 PM, Nadav Amit wrote: > at 11:58 AM, Andy Lutomirski wrote: > >> On Mon, Aug 27, 2018 at 11:54 AM, Nadav Amit wrote: On Mon, Aug 27, 2018 at 10:34 AM, Nadav Amit wrote: What do you all think? >>> >>> I agree in general. But I think that current->mm would need to be

[char-misc for 4.9 2/2] mei: bus: need to unlink client before freeing

2018-08-27 Thread Tomas Winkler
In case a client fails to connect in mei_cldev_enable(), the caller won't call the mei_cldev_disable leaving the client in a linked stated. Upon driver unload the client structure will be freed in mei_cl_bus_dev_release(), leaving a stale pointer on a fail_list. This will eventually end up in

[char-misc for 4.19 0/2] mei: fix suspend/hibernation regression

2018-08-27 Thread Tomas Winkler
A kernel panic during suspend/hibernation was reported on kernel 4.17. RIP: mei_cl_set_disconnected+0x5/0x260[mei] Call trace: mei_cl_all_disconnect+0x22/0x30 mei_reset+0x194/0x250 __synchronize_hardirq+0x43/0x50 _cond_resched+0x15/0x30 mei_me_intr_clear+0x20/0x100 mei_stop+0x76/0xb0

[char-misc for 4.9 1/2] mei: bus: fix hw module get/put balance

2018-08-27 Thread Tomas Winkler
In case the device is not connected it doesn't 'get' hw module and hence should not 'put' it on disable. Cc: 4.16+ Fixes:'commit 257355a44b99 ("mei: make module referencing local to the bus.c")' Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200455 Tested-by: Georg Müller Signed-off-by:

[char-misc for 4.9 2/2] mei: bus: need to unlink client before freeing

2018-08-27 Thread Tomas Winkler
In case a client fails to connect in mei_cldev_enable(), the caller won't call the mei_cldev_disable leaving the client in a linked stated. Upon driver unload the client structure will be freed in mei_cl_bus_dev_release(), leaving a stale pointer on a fail_list. This will eventually end up in

[char-misc for 4.19 0/2] mei: fix suspend/hibernation regression

2018-08-27 Thread Tomas Winkler
A kernel panic during suspend/hibernation was reported on kernel 4.17. RIP: mei_cl_set_disconnected+0x5/0x260[mei] Call trace: mei_cl_all_disconnect+0x22/0x30 mei_reset+0x194/0x250 __synchronize_hardirq+0x43/0x50 _cond_resched+0x15/0x30 mei_me_intr_clear+0x20/0x100 mei_stop+0x76/0xb0

[char-misc for 4.9 1/2] mei: bus: fix hw module get/put balance

2018-08-27 Thread Tomas Winkler
In case the device is not connected it doesn't 'get' hw module and hence should not 'put' it on disable. Cc: 4.16+ Fixes:'commit 257355a44b99 ("mei: make module referencing local to the bus.c")' Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200455 Tested-by: Georg Müller Signed-off-by:

Re: [PATCH v13 05/13] x86/msr: Add SGX definitions to msr-index.h

2018-08-27 Thread Dave Hansen
On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote: > @@ -866,10 +867,9 @@ void get_cpu_cap(struct cpuinfo_x86 *c) > } > } > > - /* Intel SGX features: level 0x0012 */ > - if (c->cpuid_level >= 0x0012) { > - cpuid(0x0012, , , , ); > - > + /*

Re: [PATCH v13 05/13] x86/msr: Add SGX definitions to msr-index.h

2018-08-27 Thread Dave Hansen
On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote: > @@ -866,10 +867,9 @@ void get_cpu_cap(struct cpuinfo_x86 *c) > } > } > > - /* Intel SGX features: level 0x0012 */ > - if (c->cpuid_level >= 0x0012) { > - cpuid(0x0012, , , , ); > - > + /*

Re: [PATCH v13 04/13] x86/sgx: Architectural structures

2018-08-27 Thread Dave Hansen
> +/** > + * enum sgx_encls_leaves - return codes for ENCLS, ENCLU and ENCLV > + * %SGX_SUCCESS: No error. > + * %SGX_INVALID_SIG_STRUCT: SIGSTRUCT contains an invalid value. > + * %SGX_INVALID_ATTRIBUTE: Enclave is not attempting to access a resource > + *

Re: [PATCH v13 04/13] x86/sgx: Architectural structures

2018-08-27 Thread Dave Hansen
> +/** > + * enum sgx_encls_leaves - return codes for ENCLS, ENCLU and ENCLV > + * %SGX_SUCCESS: No error. > + * %SGX_INVALID_SIG_STRUCT: SIGSTRUCT contains an invalid value. > + * %SGX_INVALID_ATTRIBUTE: Enclave is not attempting to access a resource > + *

Re: [PATCH v13 03/13] x86/cpufeatures: Add Intel-defined SGX leaf CPUID_12_EAX

2018-08-27 Thread Dave Hansen
On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote: > + /* Intel SGX features: level 0x0012 */ > + if (c->cpuid_level >= 0x0012) { > + cpuid(0x0012, , , , ); > + > + c->x86_capability[CPUID_12_EAX] = eax; > + } I've given this specific bit of feedback at

Re: [PATCH] HID: add support for Apple Magic Keyboards

2018-08-27 Thread Sean O'Brien
On Mon, Aug 27, 2018 at 5:19 AM Benjamin Tissoires wrote: > > Hi Sean, > > On Thu, Aug 23, 2018 at 6:40 PM Sean O'Brien wrote: > > > > USB device > > Vendor 05ac (Apple) > > Device 026c (Magic Keyboard with Numeric Keypad) > > > > Bluetooth devices > > Vendor 004c (Apple)

Re: [PATCH v13 03/13] x86/cpufeatures: Add Intel-defined SGX leaf CPUID_12_EAX

2018-08-27 Thread Dave Hansen
On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote: > + /* Intel SGX features: level 0x0012 */ > + if (c->cpuid_level >= 0x0012) { > + cpuid(0x0012, , , , ); > + > + c->x86_capability[CPUID_12_EAX] = eax; > + } I've given this specific bit of feedback at

Re: [PATCH] HID: add support for Apple Magic Keyboards

2018-08-27 Thread Sean O'Brien
On Mon, Aug 27, 2018 at 5:19 AM Benjamin Tissoires wrote: > > Hi Sean, > > On Thu, Aug 23, 2018 at 6:40 PM Sean O'Brien wrote: > > > > USB device > > Vendor 05ac (Apple) > > Device 026c (Magic Keyboard with Numeric Keypad) > > > > Bluetooth devices > > Vendor 004c (Apple)

Re: [PATCH v2] selftests: android: move config up a level

2018-08-27 Thread Shuah Khan
On 08/24/2018 06:49 AM, Anders Roxell wrote: > 'make kselftest-merge' assumes that the config files for the tests are > located under the 'main' test dir, like tools/testing/selftests/android/ > and not in a subdir to android. > > Signed-off-by: Anders Roxell > --- >

Re: [PATCH v2] selftests: android: move config up a level

2018-08-27 Thread Shuah Khan
On 08/24/2018 06:49 AM, Anders Roxell wrote: > 'make kselftest-merge' assumes that the config files for the tests are > located under the 'main' test dir, like tools/testing/selftests/android/ > and not in a subdir to android. > > Signed-off-by: Anders Roxell > --- >

Re: [PATCH 13/25] ubifs: authentication: Add hashes to index nodes

2018-08-27 Thread Richard Weinberger
Am Mittwoch, 4. Juli 2018, 14:41:25 CEST schrieb Sascha Hauer: > With this patch the hashes over the index nodes stored in the tree node > cache are written to flash and are checked when read back from flash. > The hash of the root index node is stored in the master node. > > During journal

Re: [PATCH 13/25] ubifs: authentication: Add hashes to index nodes

2018-08-27 Thread Richard Weinberger
Am Mittwoch, 4. Juli 2018, 14:41:25 CEST schrieb Sascha Hauer: > With this patch the hashes over the index nodes stored in the tree node > cache are written to flash and are checked when read back from flash. > The hash of the root index node is stored in the master node. > > During journal

Re: Linux 4.19-rc1

2018-08-27 Thread Guenter Roeck
On Mon, Aug 27, 2018 at 11:13:11AM -0700, Christoph Hellwig wrote: > On Mon, Aug 27, 2018 at 10:11:52AM -0700, Guenter Roeck wrote: > > When building sparc32 images, this results in the following > > error. > > > > drivers/base/platform.c: In function 'setup_pdev_archdata': > >

Re: Linux 4.19-rc1

2018-08-27 Thread Guenter Roeck
On Mon, Aug 27, 2018 at 11:13:11AM -0700, Christoph Hellwig wrote: > On Mon, Aug 27, 2018 at 10:11:52AM -0700, Guenter Roeck wrote: > > When building sparc32 images, this results in the following > > error. > > > > drivers/base/platform.c: In function 'setup_pdev_archdata': > >

Re: [PATCH 01/17] staging:rtl8192u: Remove unused defines - Style

2018-08-27 Thread Greg KH
On Mon, Aug 27, 2018 at 08:21:36PM +0100, John Whitmore wrote: > On Mon, Aug 27, 2018 at 07:27:19PM +0200, Greg KH wrote: > > On Tue, Aug 21, 2018 at 06:15:21PM +0100, John Whitmore wrote: > > > Remove a number of unused constant definitions. > > > > > > This is a coding style change which should

[PATCH] bpf: fix build error with clang

2018-08-27 Thread Stefan Agner
Building the newly introduced BPF_PROG_TYPE_SK_REUSEPORT leads to a compile time error when building with clang: net/core/filter.o: In function `sk_reuseport_convert_ctx_access': ../net/core/filter.c:7284: undefined reference to `__compiletime_assert_7284' It seems that clang has issues

Re: [PATCH 01/17] staging:rtl8192u: Remove unused defines - Style

2018-08-27 Thread Greg KH
On Mon, Aug 27, 2018 at 08:21:36PM +0100, John Whitmore wrote: > On Mon, Aug 27, 2018 at 07:27:19PM +0200, Greg KH wrote: > > On Tue, Aug 21, 2018 at 06:15:21PM +0100, John Whitmore wrote: > > > Remove a number of unused constant definitions. > > > > > > This is a coding style change which should

[PATCH] bpf: fix build error with clang

2018-08-27 Thread Stefan Agner
Building the newly introduced BPF_PROG_TYPE_SK_REUSEPORT leads to a compile time error when building with clang: net/core/filter.o: In function `sk_reuseport_convert_ctx_access': ../net/core/filter.c:7284: undefined reference to `__compiletime_assert_7284' It seems that clang has issues

Re: [PATCH 3.18 00/56] 3.18.120-stable review

2018-08-27 Thread Shuah Khan
On 08/26/2018 12:44 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 3.18.120 release. > There are 56 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

Re: [PATCH 3.18 00/56] 3.18.120-stable review

2018-08-27 Thread Shuah Khan
On 08/26/2018 12:44 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 3.18.120 release. > There are 56 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

Re: [PATCH v2 5/7] x86: plumb error code and fault address through to fault handlers

2018-08-27 Thread Jann Horn
On Mon, Aug 27, 2018 at 9:09 PM Andy Lutomirski wrote: > > On Mon, Aug 27, 2018 at 11:56 AM, Jann Horn wrote: > > This is preparation for looking at trap number and fault address in the > > handlers for uaccess errors. > > This patch should not change any behavior. > > Confused. $SUBJECT says

Re: [PATCH v2 5/7] x86: plumb error code and fault address through to fault handlers

2018-08-27 Thread Jann Horn
On Mon, Aug 27, 2018 at 9:09 PM Andy Lutomirski wrote: > > On Mon, Aug 27, 2018 at 11:56 AM, Jann Horn wrote: > > This is preparation for looking at trap number and fault address in the > > handlers for uaccess errors. > > This patch should not change any behavior. > > Confused. $SUBJECT says

Re: [PATCH v2 3/7] x86: stop calling fixup_exception() from kprobe_fault_handler()

2018-08-27 Thread Andy Lutomirski
On Mon, Aug 27, 2018 at 12:22 PM, Jann Horn wrote: > On Mon, Aug 27, 2018 at 9:02 PM Andy Lutomirski wrote: >> >> On Mon, Aug 27, 2018 at 11:56 AM, Jann Horn wrote: >> > This removes the call into exception fixup that was added in >> > commit c28f896634f2 ("[PATCH] kprobes: fix broken fault

Re: [PATCH v2 3/7] x86: stop calling fixup_exception() from kprobe_fault_handler()

2018-08-27 Thread Andy Lutomirski
On Mon, Aug 27, 2018 at 12:22 PM, Jann Horn wrote: > On Mon, Aug 27, 2018 at 9:02 PM Andy Lutomirski wrote: >> >> On Mon, Aug 27, 2018 at 11:56 AM, Jann Horn wrote: >> > This removes the call into exception fixup that was added in >> > commit c28f896634f2 ("[PATCH] kprobes: fix broken fault

Re: [PATCH 01/17] staging:rtl8192u: Remove unused defines - Style

2018-08-27 Thread John Whitmore
On Mon, Aug 27, 2018 at 07:27:19PM +0200, Greg KH wrote: > On Tue, Aug 21, 2018 at 06:15:21PM +0100, John Whitmore wrote: > > Remove a number of unused constant definitions. > > > > This is a coding style change which should have no impact on runtime > > code execution. > > > > Signed-off-by:

Re: [PATCH 01/17] staging:rtl8192u: Remove unused defines - Style

2018-08-27 Thread John Whitmore
On Mon, Aug 27, 2018 at 07:27:19PM +0200, Greg KH wrote: > On Tue, Aug 21, 2018 at 06:15:21PM +0100, John Whitmore wrote: > > Remove a number of unused constant definitions. > > > > This is a coding style change which should have no impact on runtime > > code execution. > > > > Signed-off-by:

Re: [PATCH v2 3/7] x86: stop calling fixup_exception() from kprobe_fault_handler()

2018-08-27 Thread Jann Horn
On Mon, Aug 27, 2018 at 9:02 PM Andy Lutomirski wrote: > > On Mon, Aug 27, 2018 at 11:56 AM, Jann Horn wrote: > > This removes the call into exception fixup that was added in > > commit c28f896634f2 ("[PATCH] kprobes: fix broken fault handling for > > x86_64"). > > > > On X86,

Re: [PATCH v2 3/7] x86: stop calling fixup_exception() from kprobe_fault_handler()

2018-08-27 Thread Jann Horn
On Mon, Aug 27, 2018 at 9:02 PM Andy Lutomirski wrote: > > On Mon, Aug 27, 2018 at 11:56 AM, Jann Horn wrote: > > This removes the call into exception fixup that was added in > > commit c28f896634f2 ("[PATCH] kprobes: fix broken fault handling for > > x86_64"). > > > > On X86,

[PATCH] mailbox: PCC: handle parse error

2018-08-27 Thread David Arcari
acpi_pcc_probe calls acpi_table_parse_entries_array but fails to check for an error return. This in turn can result in calling kcalloc with a negative count as well as emitting the following misleading erorr message: [2.642015] Could not allocate space for PCC mbox channels Fixes:

[PATCH] mailbox: PCC: handle parse error

2018-08-27 Thread David Arcari
acpi_pcc_probe calls acpi_table_parse_entries_array but fails to check for an error return. This in turn can result in calling kcalloc with a negative count as well as emitting the following misleading erorr message: [2.642015] Could not allocate space for PCC mbox channels Fixes:

Re: [PATCH 12/25] ubifs: Add hashes to the tree node cache

2018-08-27 Thread Richard Weinberger
Am Mittwoch, 4. Juli 2018, 14:41:24 CEST schrieb Sascha Hauer: > As part of the UBIFS authentication support every branch in the index > gets a hash covering the referenced node. To make that happen the tree > node cache needs hashes over the nodes. This patch adds a hash argument > to

Re: [PATCH 12/25] ubifs: Add hashes to the tree node cache

2018-08-27 Thread Richard Weinberger
Am Mittwoch, 4. Juli 2018, 14:41:24 CEST schrieb Sascha Hauer: > As part of the UBIFS authentication support every branch in the index > gets a hash covering the referenced node. To make that happen the tree > node cache needs hashes over the nodes. This patch adds a hash argument > to

RE: [PATCH] ata: Disable AHCI ALPM feature for Ampere Computing eMAG SATA

2018-08-27 Thread Suman Tripathi
Hi Hans Thanks for your fast response. With regards, Suman Please note my new email address → stripa...@amperecomputing.com -Original Message- From: Hans de Goede Sent: Monday, August 27, 2018 12:09 PM To: Suman Tripathi ; t...@kernel.org; linux-...@vger.kernel.org;

RE: [PATCH] ata: Disable AHCI ALPM feature for Ampere Computing eMAG SATA

2018-08-27 Thread Suman Tripathi
Hi Hans Thanks for your fast response. With regards, Suman Please note my new email address → stripa...@amperecomputing.com -Original Message- From: Hans de Goede Sent: Monday, August 27, 2018 12:09 PM To: Suman Tripathi ; t...@kernel.org; linux-...@vger.kernel.org;

Re: [PATCH] objtool: remove workaround for unreachable warnings from old GCC

2018-08-27 Thread Josh Poimboeuf
On Mon, Aug 27, 2018 at 12:39:43PM +0900, Masahiro Yamada wrote: > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > bumped the minimum GCC version to 4.6 for all architectures. > > This effectively reverts commit da541b20021c ("objtool: Skip > unreachable warnings for GCC

Re: [PATCH] objtool: remove workaround for unreachable warnings from old GCC

2018-08-27 Thread Josh Poimboeuf
On Mon, Aug 27, 2018 at 12:39:43PM +0900, Masahiro Yamada wrote: > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > bumped the minimum GCC version to 4.6 for all architectures. > > This effectively reverts commit da541b20021c ("objtool: Skip > unreachable warnings for GCC

Re: Linux 4.19-rc1

2018-08-27 Thread Shuah Khan
On Sun, Aug 26, 2018 at 3:51 PM Linus Torvalds wrote: > > So two weeks have passed, and the merge window for 4.19 is over. > > Anyway, go forth and test, > I am seeing the errors use-after-free errors in mei_cl_write. dmesg as follows. Adding Tomas Winkler to the thread. [ 12.602912] PM:

Re: TLB flushes on fixmap changes

2018-08-27 Thread Nadav Amit
at 11:58 AM, Andy Lutomirski wrote: > On Mon, Aug 27, 2018 at 11:54 AM, Nadav Amit wrote: >>> On Mon, Aug 27, 2018 at 10:34 AM, Nadav Amit wrote: >>> What do you all think? >> >> I agree in general. But I think that current->mm would need to be loaded, as >> otherwise I am afraid it would

<    1   2   3   4   5   6   7   8   9   10   >