Re: RFC: userspace exception fixups

2018-11-06 Thread Andy Lutomirski
On Tue, Nov 6, 2018 at 10:41 AM Dave Hansen wrote: > > On 11/6/18 10:20 AM, Andy Lutomirski wrote: > > I almost feel like the right solution is to call into SGX on its own > > private stack or maybe even its own private address space. > > Yeah, I had the same gut feeling. Couldn't the debugger ev

Re: [GIT PULL 00/18] perf/urgent improvements and fixes

2018-11-06 Thread Ingo Molnar
.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > tags/perf-urgent-for-mingo-4.20-20181106 > > for you to fetch changes up to 8e88c29b351ed4e09dd63f825f1c8260b0cb0ab3: > > perf tools: Do not zero sample_id_all for group members (2018-11-06 > 08:29:56 -0300) > > ---

Re: [PATCH v2] clk: meson-gxbb: set fclk_div3 as CLK_IS_CRITICAL

2018-11-06 Thread Stephen Boyd
Quoting Jerome Brunet (2018-11-05 15:08:20) > From: Christian Hewitt > > On the Khadas VIM2 (GXM) and LePotato (GXL) board there are problems > with reboot; e.g. a ~60 second delay between issuing reboot and the > board power cycling (and in some OS configurations reboot will fail > and require m

Re: RFC: userspace exception fixups

2018-11-06 Thread Dave Hansen
On 11/6/18 10:20 AM, Andy Lutomirski wrote: > I almost feel like the right solution is to call into SGX on its own > private stack or maybe even its own private address space. Yeah, I had the same gut feeling. Couldn't the debugger even treat the enclave like its own "thread" with its own stack a

[PATCH] EDAC, skx: Better fix for randconfig builds

2018-11-06 Thread Luck, Tony
On Tue, Nov 06, 2018 at 03:32:53PM +0100, Borislav Petkov wrote: > On Tue, Nov 06, 2018 at 02:44:42PM +0100, Arnd Bergmann wrote: > > No, it was unintentional, the 'if ACPI' can be dropped when we add > > 'depends on ACPI'. > > So I have one fix already which takes care of non-sensical configs. If

[PATCH 3/4] clk: mediatek: Drop THIS_MODULE from platform_driver

2018-11-06 Thread Stephen Boyd
This is already set by platform_driver_register(), so we can remove it here. Cc: Ryder Lee Signed-off-by: Stephen Boyd --- drivers/clk/mediatek/clk-mt2712.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/mediatek/clk-mt2712.c b/drivers/clk/mediatek/clk-mt2712.c index 17c031d110

[PATCH 2/4] clk: mediatek: Convert to platform_driver_probe_by_match_data()

2018-11-06 Thread Stephen Boyd
Use this function to reduce the boiler-plate code that the mediatek clk driver needs to implement to probe clks for different devices within the same driver. Cc: Ryder Lee Signed-off-by: Stephen Boyd --- drivers/clk/mediatek/clk-mt2701.c | 20 +--- drivers/clk/mediatek/clk-m

[PATCH 0/4] Simplify mediatek clk driver probes

2018-11-06 Thread Stephen Boyd
I suggested this some time ago but nobody has gotten around to doing it so far. Well now I have! Here's a patch series that cuts down the boiler-plate code that Mediatek clk drivers have to multiplex probe amongst the device match data. Rob/Frank, I'd prefer to take the first patch via clk tree so

[PATCH 4/4] clk: mediatek: Simplify single driver probes

2018-11-06 Thread Stephen Boyd
We don't need to do the multiplex probe design here when we only have one compatible string. Just setup probe to point at the one probe function for now. Cc: Ryder Lee Signed-off-by: Stephen Boyd --- drivers/clk/mediatek/clk-mt2701-g3d.c | 28 +++ drivers/clk/mediatek/cl

[PATCH 1/4] of/device: Add a way to probe drivers by match data

2018-11-06 Thread Stephen Boyd
We have a handful of clk drivers that have a collection of slightly variant device support keyed off of the compatible string. In each of these drivers, we demux the variant and then call the "real" probe function based on whatever is stored in the match data for that compatible string. Let's gener

Re: [PATCH anybus v3 1/6] misc: support the Arcx anybus bridge

2018-11-06 Thread Rob Herring
On Tue, Nov 6, 2018 at 8:46 AM Sven Van Asbroeck wrote: > > On Tue, Nov 6, 2018 at 8:58 AM Rob Herring wrote: > > > It doesn't really sound like the host should be in DT. The bridge > > should register itself as an anybus provider and that should in turn > > enable the anybus host protocol. > > V

Re: [PATCH RFC 09/18] staging: vchiq_core: do not initialize semaphores twice

2018-11-06 Thread Nicolas Saenz Julienne
On Tue, 2018-11-06 at 17:06 +0100, Stefan Wahren wrote: > Am 06.11.18 um 16:41 schrieb Nicolas Saenz Julienne: > > Hi Stefan, > > thanks for spending the time reviewing the code. I took note of the > > rest of comments. > > > > On Sun, 2018-10-28 at 21:45 +0100, Stefan Wahren wrote: > > > Hi Nicol

Re: [PATCH] sh: Provide prototypes for PCI I/O mapping in asm/io.h

2018-11-06 Thread Mark Brown
On Tue, Nov 06, 2018 at 07:21:41PM +0100, Geert Uytterhoeven wrote: > > +#include > Is this sufficient? > include/asm-generic/pci_iomap.h provides the dummies if CONFIG_PCI=n and > CONFIG_GENERIC_PCI_IOMAP=y, while arch/sh/Kconfig selects GENERIC_PCI_IOMAP > only if PCI is enabled. Hence it's n

fs/ubifs/auth.c:249:2: error: implicit declaration of function 'request_key'

2018-11-06 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 8053e5b93eca9b011f7b79bb019bf1eeaaf96c4b commit: d8a22773a12c6d78ee758c9e530f3a488bb7cb29 ubifs: Enable authentication support date: 2 weeks ago config: i386-randconfig-h1-11070135 (attached as .config) co

Re: [PATCH 1/2] perf-bench: Add epoll parallel epoll_wait benchmark

2018-11-06 Thread Davidlohr Bueso
Mind this fixlet for using et/oneshot and the multiq option. diff --git a/tools/perf/bench/epoll-wait.c b/tools/perf/bench/epoll-wait.c index c4c5ef60feb4..4e4efc5cfe22 100644 --- a/tools/perf/bench/epoll-wait.c +++ b/tools/perf/bench/epoll-wait.c @@ -215,13 +215,13 @@ static void *workerfn(void

[PATCH] staging: wlan-ng: Fix a typo.

2018-11-06 Thread Rohit Sarkar
"Exiting" instead of "Exitting" Signed-off-by: Rohit Sarkar --- drivers/staging/wlan-ng/prism2fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c index f99626ca6bdc..a2c851c74bef 100644 --- a/drivers/st

Re: [PATCH] sh: Provide prototypes for PCI I/O mapping in asm/io.h

2018-11-06 Thread Geert Uytterhoeven
Hi Mark, On Tue, Nov 6, 2018 at 6:52 PM Mark Brown wrote: > Most architectures provide prototypes for the PCI I/O mapping operations > when asm/io.h is included but SH doesn't currently do that, leading to > for example warnings in sound/pci/hda/patch_ca0132.c when pci_iomap() is > used on curren

Re: RFC: userspace exception fixups

2018-11-06 Thread Andy Lutomirski
> On Nov 6, 2018, at 9:19 AM, Sean Christopherson > wrote: > >> On Tue, 2018-11-06 at 08:57 -0800, Andy Lutomirski wrote: >> >> So I guess the non-enclave code basically can’t trust its stack pointer >> because of these shenanigans. And the AEP code has to live with the fact >> that its RSP

[tip:x86/urgent] acpi/nfit, x86/mce: Validate a MCE's address before using it

2018-11-06 Thread tip-bot for Vishal Verma
Commit-ID: e8a308e5f47e545e0d41d0686c00f5f5217c5f61 Gitweb: https://git.kernel.org/tip/e8a308e5f47e545e0d41d0686c00f5f5217c5f61 Author: Vishal Verma AuthorDate: Thu, 25 Oct 2018 18:37:29 -0600 Committer: Borislav Petkov CommitDate: Tue, 6 Nov 2018 19:13:26 +0100 acpi/nfit, x86/mce: Val

Re: [RFC/RFT][PATCH v3] cpuidle: New timer events oriented governor for tickless systems

2018-11-06 Thread Rafael J. Wysocki
On Tue, Nov 6, 2018 at 6:04 PM Peter Zijlstra wrote: > > On Sun, Nov 04, 2018 at 05:31:20PM +0100, Rafael J. Wysocki wrote: > > + * - If there is a pattern of 5 or more recent non-timer wakeups earlier > > than > > + * the closest timer event, expect one more of them to occur and use the > > +

[tip:x86/urgent] acpi/nfit, x86/mce: Handle only uncorrectable machine checks

2018-11-06 Thread tip-bot for Vishal Verma
Commit-ID: 5d96c9342c23ee1d084802dcf064caa67ecaa45b Gitweb: https://git.kernel.org/tip/5d96c9342c23ee1d084802dcf064caa67ecaa45b Author: Vishal Verma AuthorDate: Thu, 25 Oct 2018 18:37:28 -0600 Committer: Borislav Petkov CommitDate: Tue, 6 Nov 2018 19:13:10 +0100 acpi/nfit, x86/mce: Han

Re: [PATCH 3/4] of/property: Introduce of_fwnode_name()

2018-11-06 Thread Rob Herring
On Tue, Nov 6, 2018 at 8:28 AM Andy Shevchenko wrote: > > On Tue, Nov 06, 2018 at 07:18:14AM -0600, Rob Herring wrote: > > On Tue, Nov 6, 2018 at 6:27 AM Heikki Krogerus > > wrote: > > > > > > On Tue, Nov 06, 2018 at 12:58:03PM +0200, Andy Shevchenko wrote: > > > > On Mon, Nov 05, 2018 at 12:50:0

Re: [PATCH] slab.h: Avoid using & for logical and of booleans

2018-11-06 Thread Alexander Duyck
On Tue, Nov 6, 2018 at 9:48 AM Bart Van Assche wrote: > > On Tue, 2018-11-06 at 09:20 -0800, Alexander Duyck wrote: > > On Mon, Nov 5, 2018 at 4:32 PM Bart Van Assche wrote: > > > > > > On Mon, 2018-11-05 at 16:11 -0800, Alexander Duyck wrote: > > > > If we really don't care then why even bother

Re: [PATCH] docs: Extend trusted keys documentation for TPM 2.0

2018-11-06 Thread Mimi Zohar
On Tue, 2018-11-06 at 09:46 -0700, Jerry Snitselaar wrote: > On Fri Oct 19 18, Stefan Berger wrote: > >Extend the documentation for trusted keys with documentation for how to > >set up a key for a TPM 2.0 so it can be used with a TPM 2.0 as well. > > > >Signed-off-by: Stefan Berger > >Reviewed-by:

Re: [PATCH v2 00/10] steal tasks to improve CPU utilization

2018-11-06 Thread Steven Sistare
On 11/6/2018 12:52 PM, Valentin Schneider wrote: > Hi Steve, > > On 05/11/2018 20:07, Steve Sistare wrote: > [...] >> The patch series is based on kernel 4.19.0-rc7. It compiles, boots, and >> runs with/without each of CONFIG_SCHED_SMT, CONFIG_SMP, CONFIG_SCHED_DEBUG, >> and CONFIG_PREEMPT. It r

Re: [PATCH 3/4] of/property: Introduce of_fwnode_name()

2018-11-06 Thread Rob Herring
On Tue, Nov 6, 2018 at 9:53 AM Andy Shevchenko wrote: > > On Tue, Nov 06, 2018 at 05:05:03PM +0200, Heikki Krogerus wrote: > > > Maybe it would be best to just read the "name" device property in > > fwnode_name() and not have of_fwnode_name at all. > > If it's a mandatory property or somehow its p

Re: [PATCH] firmware: raspberrypi: Define timeout for transactions

2018-11-06 Thread Stefan Wahren
> Eric Anholt hat am 31. Oktober 2018 um 18:16 geschrieben: > > > Stefan Wahren writes: > > > We should never assume to get a reply from the firmware otherwise > > the call could block forever and the user don't get informed. So > > define a timeout of 1 sec and print a stacktrace once in the

Re: [PATCH v3 6/7] x86/alternatives: use temporary mm for text poking

2018-11-06 Thread Nadav Amit
From: Peter Zijlstra Sent: November 6, 2018 at 1:11:19 PM GMT > To: Nadav Amit > Cc: Ingo Molnar , LKML , X86 > ML , H. Peter Anvin , Thomas Gleixner > , Borislav Petkov , Dave Hansen > , Andy Lutomirski , Kees Cook > , Dave Hansen , Masami > Hiramatsu > Subject: Re: [PATCH v3 6/7] x86/alter

[PATCH] Revert "scripts/setlocalversion: git: Make -dirty check more robust"

2018-11-06 Thread Guenter Roeck
This reverts commit 6147b1cf19651c7de297e69108b141fb30aa2349. The reverted patch results in attempted write access to the source repository, even if that repository is mounted read-only. Output from "strace git status -uno --porcelain": getcwd("/tmp/linux-test", 129) = 16 open("/tmp/lin

Applied "regulator: pfuze100-regulator: add coin support to PF0100" to the regulator tree

2018-11-06 Thread Mark Brown
The patch regulator: pfuze100-regulator: add coin support to PF0100 has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next

Applied "ASoC: qdsp6: q6asm-dai: Only add routing once." to the asoc tree

2018-11-06 Thread Mark Brown
The patch ASoC: qdsp6: q6asm-dai: Only add routing once. has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent t

Applied "ASoC: qdsp6: q6afe-dai: Fix the dai widgets" to the asoc tree

2018-11-06 Thread Mark Brown
The patch ASoC: qdsp6: q6afe-dai: Fix the dai widgets has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to L

Re: [PATCH v3 17/25] dt-bindings: panel: Add Bananapi S070WV20-CT16 ICN6211 MIPI-DSI to RGB bridge

2018-11-06 Thread Jagan Teki
On Wed, Oct 31, 2018 at 2:45 PM Andrzej Hajda wrote: > > On 31.10.2018 09:58, Chen-Yu Tsai wrote: > > On Wed, Oct 31, 2018 at 4:53 PM Andrzej Hajda wrote: > >> On 26.10.2018 16:43, Jagan Teki wrote: > >>> Bananapi S070WV20-CT16 ICN6211 is 800x480, 4-lane MIPI-DSI to RGB > >>> bridge panel, which

Re: [PATCH v2 2/3] drivers/irqchip: Add Actions external interrupts support

2018-11-06 Thread Parthiban Nallathambi
Hello Marc, Ping on this patch for feedback. On 9/20/18 11:42 AM, Parthiban Nallathambi wrote: Hello Marc, Ping on this patch for feedback. On 08/26/2018 05:20 PM, Parthiban Nallathambi wrote: Hello Marc, Thanks for your feedback. On 8/13/18 1:46 PM, Marc Zyngier wrote: On 12/08/18 13:22,

Applied "ASoC: pxa: change ac97 dependencies" to the asoc tree

2018-11-06 Thread Mark Brown
The patch ASoC: pxa: change ac97 dependencies has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus dur

Re: [PATCH -next] edac: i82975x: remove set but not used variable 'dtype'

2018-11-06 Thread Borislav Petkov
On Thu, Nov 01, 2018 at 10:26:04AM +0800, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/edac/i82975x_edac.c:378:16: warning: > variable ‘dtype’ set but not used [-Wunused-but-set-variable] > > It never used since introduction in commit > 084a4fccef39 ("edac: move

Re: [PATCH v5 4/5] pinctrl: actions: Add Actions Semi S700 pinctrl driver

2018-11-06 Thread Parthiban Nallathambi
On 11/6/18 6:25 PM, Manivannan Sadhasivam wrote: Hi, On Tue, Nov 06, 2018 at 05:44:47PM +0100, Parthiban Nallathambi wrote: ping on this patch series! Please send v6 incorporating the comments I provided. You have already replied to those, so I was expecting another revision! Sure, tha

Re: [PATCH V3 1/2] dt-bindings: mmc: sdhci-msm: Add new compatible string for SDM845 SOC

2018-11-06 Thread Veerabhadrarao Badiganti
On 11/6/2018 2:41 AM, Doug Anderson wrote: Hi, On Mon, Nov 5, 2018 at 12:37 PM Rob Herring wrote: On Thu, Nov 01, 2018 at 01:29:54PM -0700, Doug Anderson wrote: Hi, On Thu, Nov 1, 2018 at 5:07 AM Veerabhadrarao Badiganti wrote: For SDM845 SOC, new compatible string "qcom,sdm845-sdhci"

Re: [PATCH v2 00/10] steal tasks to improve CPU utilization

2018-11-06 Thread Valentin Schneider
Hi Steve, On 05/11/2018 20:07, Steve Sistare wrote: [...] > The patch series is based on kernel 4.19.0-rc7. It compiles, boots, and > runs with/without each of CONFIG_SCHED_SMT, CONFIG_SMP, CONFIG_SCHED_DEBUG, > and CONFIG_PREEMPT. It runs without error with CONFIG_DEBUG_PREEMPT + > CONFIG_SLUB_

[PATCH] sh: Provide prototypes for PCI I/O mapping in asm/io.h

2018-11-06 Thread Mark Brown
Most architectures provide prototypes for the PCI I/O mapping operations when asm/io.h is included but SH doesn't currently do that, leading to for example warnings in sound/pci/hda/patch_ca0132.c when pci_iomap() is used on current -next. Make SH more consistent with other architectures by includ

Re: [PATCH V3 2/2] mmc: sdhci-msm: Re-initialize DLL if MCLK is gated dynamically

2018-11-06 Thread Veerabhadrarao Badiganti
On 11/2/2018 2:03 AM, Doug Anderson wrote: Hi, On Thu, Nov 1, 2018 at 5:08 AM Veerabhadrarao Badiganti wrote: static const struct sdhci_msm_variant_info sdhci_msm_v5_var = { .mci_removed = true, + .restore_dll_config = false, + .var_ops = &v5_var_ops, + .offset

Re: [PATCH] slab.h: Avoid using & for logical and of booleans

2018-11-06 Thread Bart Van Assche
On Tue, 2018-11-06 at 09:20 -0800, Alexander Duyck wrote: > On Mon, Nov 5, 2018 at 4:32 PM Bart Van Assche wrote: > > > > On Mon, 2018-11-05 at 16:11 -0800, Alexander Duyck wrote: > > > If we really don't care then why even bother with the switch statement > > > anyway? It seems like you could ju

Re: [PATCH v2 15/17] arm64: dts: qcom: qcs404: Add BAM DMA node

2018-11-06 Thread Vinod Koul
On 05-11-18, 11:12, Bjorn Andersson wrote: > On Mon 05 Nov 07:45 PST 2018, Vinod Koul wrote: > > > Add the BAM DMA instance found in BLSP1 node of the QCS404 > > What about blsp2 bam? Haven't tested that yet :( Serial helped on this one so added :) -- ~Vinod

Re: [PATCH v2 13/17] arm64: dts: qcom: qcs404: Add remoteproc nodes

2018-11-06 Thread Vinod Koul
On 05-11-18, 11:10, Bjorn Andersson wrote: > On Mon 05 Nov 07:45 PST 2018, Vinod Koul wrote: > > > From: Bjorn Andersson > > > > Add the TrustZone based remoteproc nodes and their glink edges for > > adsp, cdsp and wcss. > > > > Signed-off-by: Bjorn Andersson > > Signed-off-by: Vinod Koul > >

Re: [PATCH] clk: qcom: smd: Add support for QCS404 rpm clocks

2018-11-06 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-11-03 00:00:02) > From: Taniya Das > > Add rpm smd clocks, PMIC and bus clocks which are required on QCS404 > for clients to vote on. > > Signed-off-by: Taniya Das > Signed-off-by: Anu Ramanathan > [bjorn: Dropped cxo, voter clocks and static initialization] > Sig

Re: [PATCH 6/8] clk: s2mps11: constify clk_ops structure

2018-11-06 Thread Stephen Boyd
Quoting Julia Lawall (2018-10-26 22:47:40) > The clk_ops structure is only stored in the ops fields of > clk_init_data structures. This field is const, so the clk_ops > structure can be const as well. > > Identified and transformed using Coccinelle. > > Signed-off-by: Julia Lawall > > --- App

Re: [PATCH 5/8] clk: pxa: constify clk_ops structures

2018-11-06 Thread Stephen Boyd
Quoting Julia Lawall (2018-10-26 22:47:39) > These clk_ops structures are only passed to a call to > clk_register_composite where the corresponding parameters > are const, so the clk_ops structure can be const as well. > > Identified and transformed using Coccinelle. > > Signed-off-by: Julia Lawa

Re: [PATCH 4/8] clk: pistachio: constify clk_ops structures

2018-11-06 Thread Stephen Boyd
Quoting Julia Lawall (2018-10-26 22:47:38) > These clk_ops structures are only stored in the ops field of a > clk_init_data structure. This field is const, so the clk_ops > structures can be const as well. > > Identified and transformed using Coccinelle. > > Signed-off-by: Julia Lawall > > ---

Re: [PATCH 3/8] clk: palmas: constify clk_ops structure

2018-11-06 Thread Stephen Boyd
Quoting Julia Lawall (2018-10-26 22:47:37) > The clk_ops structure is only stored in the ops field of clk_init_data > structures. This field is const, so the clk_ops structure can be > const as well. > > Identified and transformed using Coccinelle. > > Signed-off-by: Julia Lawall > > --- Appl

Re: [PATCH 1/8] clk: max77686: constify clk_ops structure

2018-11-06 Thread Stephen Boyd
Quoting Julia Lawall (2018-10-26 22:47:35) > The clk_ops structure is only stored in the ops field of a > clk_init_data structure. This field is const, so the clk_ops > structure can be const as well. > > Identified and transformed using Coccinelle. > > Signed-off-by: Julia Lawall > > --- App

[PATCH v4 17/17] tpm: remove @flags from tpm_transmit()

2018-11-06 Thread Jarkko Sakkinen
Remove @flags from tpm_transmit() API. It is no longer used for anything. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-chip.c | 32 ++--- drivers/char/tpm/tpm-dev-common.c | 2 +- drivers/char/tpm/tpm-interface.c | 18 drivers/char/tpm/tpm-sysfs.c

[PATCH v4 14/17] tpm: remove TPM_TRANSMIT_UNLOCKED flag

2018-11-06 Thread Jarkko Sakkinen
Added locking as part of tpm_try_get_ops() and tpm_put_ops() as they are anyway used in most of the call sites except in tpmrm_release() where we take the locks manually. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-chip.c | 2 ++ drivers/char/tpm/tpm-dev-common.c | 4 +--- dr

[PATCH v4 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-06 Thread Jarkko Sakkinen
Call tpm_chip_start() and tpm_chip_stop() in * tpm_try_get_ops() and tpm_put_ops() * tpm_chip_register() * tpm2_del_space() And remove these calls from tpm_transmit(). The core reason for this change is that in tpm_vtpm_proxy a locality change requires a virtual TPM command (a command made up jus

[PATCH v4 15/17] tpm: introduce tpm_chip_start() and tpm_chip_stop()

2018-11-06 Thread Jarkko Sakkinen
Encapsulate power gating and locality functionality to tpm_chip_start() and tpm_chip_stop() in order to clean up the branching mess in tpm_transmit(). Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-chip.c | 110 +++ drivers/char/tpm/tpm-interface.c | 87

[PATCH v4 11/17] tpm: move TPM space code out of tpm_transmit()

2018-11-06 Thread Jarkko Sakkinen
Prepare and commit TPM space before and after calling tpm_transmit() instead of doing that inside tpm_transmit(). After this change we can remove TPM_TRANSMIT_NESTED flag from tpm2_prepare_space() and tpm2_commit_space() and replace it with TPM_TRANSMIT_UNLOCKED. Signed-off-by: Jarkko Sakkinen --

[PATCH v4 09/17] tpm: move tpm_validate_commmand() to tpm2-space.c

2018-11-06 Thread Jarkko Sakkinen
Move tpm_validate_command() to tpm2-space.c and make it part of the tpm2_prepare_space() flow. Make cc resolution as part of the TPM space functionality in order to detach it from rest of the tpm_transmit() flow. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 72 +++---

[PATCH v4 10/17] tpm: encapsulate tpm_dev_transmit()

2018-11-06 Thread Jarkko Sakkinen
Encapsulate tpm_transmit() call pattern to tpm_dev_transmit() because it is identically used from two places. Use unlocked version of tpm_transmit() so that we are able to move the calls to tpm2_prepare_space() and tpm2_commit_space() later on to this new function. Signed-off-by: Jarkko Sakkinen

[PATCH v4 13/17] tpm: use tpm_try_get_ops() in tpm-sysfs.c.

2018-11-06 Thread Jarkko Sakkinen
Use tpm_try_get_ops() in tpm-sysfs.c so that we can consider moving other decorations (locking, localities, power management for example) inside it. This direction can be of course taken only after other call sites for tpm_transmit() have been treated in the same way. Signed-off-by: Jarkko Sakkine

[PATCH v4 12/17] tpm: remove @space from tpm_transmit()

2018-11-06 Thread Jarkko Sakkinen
Remove @space from tpm_transmit() API` in order to completely remove the bound between low-level transmission functionality and TPM spaces. The only real dependency existing is the amount of data saved before trying to send a command to the TPM. It doesn't really matter if we save always a bit mor

[PATCH v4 04/17] tpm: call tpm2_flush_space() on error in tpm_try_transmit()

2018-11-06 Thread Jarkko Sakkinen
Always call tpm2_flush_space() on failure in tpm_try_transmit() so that the volatile memory of the TPM gets cleared. If /dev/tpm0 does not have sufficient permissions (usually it has), this could lead to the leakage of TPM objects. Through /dev/tpmrm0 this issue does not raise any new security conc

Re: [PATCH v2 11/17] arm64: dts: qcom: pms405: add gpios

2018-11-06 Thread Vinod Koul
On 05-11-18, 11:08, Bjorn Andersson wrote: > On Mon 05 Nov 07:45 PST 2018, Vinod Koul wrote: > > > Add the GPIOs present on PMS405 chip. > > > > Signed-off-by: Vinod Koul > > --- > > arch/arm64/boot/dts/qcom/pms405.dtsi | 16 > > 1 file changed, 16 insertions(+) > > > > diff -

[PATCH v4 05/17] tpm: print tpm2_commit_space() error inside tpm2_commit_space()

2018-11-06 Thread Jarkko Sakkinen
The error logging for tpm2_commit_space() is in a wrong place. This commit moves it inside that function. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 8 ++-- drivers/char/tpm/tpm2-space.c| 9 ++--- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git

[PATCH v4 06/17] tpm: clean up tpm_try_transmit() error handling flow

2018-11-06 Thread Jarkko Sakkinen
Move locking, locality handling and power management to tpm_transmit() in order to simplify the flow. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 71 1 file changed, 35 insertions(+), 36 deletions(-) diff --git a/drivers/char/tpm/tpm-in

[PATCH v4 08/17] tpm: access command header through struct in tpm_try_transmit()

2018-11-06 Thread Jarkko Sakkinen
Instead of accessing fields of the command header through offsets to the raw buffer, it is a better idea to use the header struct pointer that is already used elsewhere in the function. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH v4 03/17] tpm: return 0 from pcrs_show() when tpm1_pcr_read() fails

2018-11-06 Thread Jarkko Sakkinen
Do not print partial list of PCRs when tpm1_pcr_read() fails but instead return 0 from pcrs_show(). This is consistent behavior with other sysfs functions. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-sysfs.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --

[PATCH v4 07/17] tpm: declare struct tpm_header

2018-11-06 Thread Jarkko Sakkinen
Decleare struct tpm_header that replaces struct tpm_input_header and struct tpm_output_header. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 9 - drivers/char/tpm/tpm.h| 27 --- drivers/char/tpm/tpm2-cmd.c | 4 ++-- dri

[PATCH v4 00/17] Remove nested TPM operations

2018-11-06 Thread Jarkko Sakkinen
[was Detach TPM space code out of the tpm_transmit() flow but the scope expanded a bit.] Make the changes necessary to detach TPM space code and TPM activation code out of the tpm_transmit() flow because of both of these can cause nested tpm_transmit() calls. The nesteds calls make the whole flow

[PATCH v4 02/17] tpm: fix invalid return value in pubek_show()

2018-11-06 Thread Jarkko Sakkinen
Return zero when tpm_buf_init() fails as we do for other functions in tpm-sysfs.c. Fixes: da379f3c1db0c ("tpm: migrate pubek_show to struct tpm_buf") Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-sysfs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/c

[PATCH v4 01/17] tpm: use tpm_buf in tpm_transmit_cmd() as the IO parameter

2018-11-06 Thread Jarkko Sakkinen
Since we pass an initialized struct tpm_buf instance in every call site now, it is cleaner to pass that directly to the tpm_transmit_cmd() as the TPM command/response buffer. Fine-tune a little bit tpm_transmit() and tpm_transmit_cmd() comments while doing this. Signed-off-by: Jarkko Sakkinen --

Re: [PATCH v2 01/17] arm64: dts: qcom: qcs404: add base dts files

2018-11-06 Thread Vinod Koul
Thanks for the review Bjorn, On 05-11-18, 10:56, Bjorn Andersson wrote: > On Mon 05 Nov 07:45 PST 2018, Vinod Koul wrote: > > > diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dts > > b/arch/arm64/boot/dts/qcom/qcs404-evb.dts > > new file mode 100644 > > index ..74dc09ddb0d2 > > ---

Re: [PATCH V2] clk: imx7d: remove UART1 clock setting

2018-11-06 Thread Stephen Boyd
Quoting Anson Huang (2018-10-18 18:05:36) > There are clock assignments in all i.MX7D dtb files for UART1, > below is the example in imx7d-sdb.dts, so setting UART1 clock > in clock driver is NOT necessary, actually, module clocks setting > should be done in module driver. > > &uart1 { > p

Re: [PATCH v2 2/3] dt-bindings: clk: add documentation for the SiFive PRCI driver

2018-11-06 Thread Stephen Boyd
Quoting Paul Walmsley (2018-10-20 06:50:23) > diff --git a/Documentation/devicetree/bindings/clock/sifive/fu540-prci.txt > b/Documentation/devicetree/bindings/clock/sifive/fu540-prci.txt > new file mode 100644 > index ..d7c1e83fa5ed > --- /dev/null > +++ b/Documentation/devicetree/bind

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Keith Busch
On Tue, Nov 06, 2018 at 05:21:00PM +, Lorenzo Pieralisi wrote: > If you have a simple reproducer for the bugs I am happy to help you test > it (I can also apply arm64 DYNAMIC_FTRACE_WITH_REGS patches and test that > new code path if that's the final direction we are taking). The easiest way to

Re: PEBS level 2/3 breaks dwarf unwinding! [WAS: Re: Broken dwarf unwinding - wrong stack pointer register value?]

2018-11-06 Thread Andi Kleen
> hum, is this about having 'large pebs' or there's this window > if there's also only single pebs record allowed? which should > be case for dwarf unwind With large PEBS today there is never any stack unwind because stack unwinding can be only done from a PMI. The window happens even with single

Re: [PATCH v5 4/5] pinctrl: actions: Add Actions Semi S700 pinctrl driver

2018-11-06 Thread Manivannan Sadhasivam
Hi, On Tue, Nov 06, 2018 at 05:44:47PM +0100, Parthiban Nallathambi wrote: > ping on this patch series! > Please send v6 incorporating the comments I provided. You have already replied to those, so I was expecting another revision! Thanks, Mani > On 9/4/18 9:28 PM, Saravanan Sekar wrote: > >

Re: [PATCH v3] clk: qoriq: add more chips support

2018-11-06 Thread Stephen Boyd
Quoting Yuantian Tang (2018-10-31 00:46:16) > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c > index 4c30b6e..5baa9e0 100644 > --- a/drivers/clk/clk-qoriq.c > +++ b/drivers/clk/clk-qoriq.c > @@ -1418,12 +1418,23 @@ static void __init clockgen_init(struct device_node > *np) > > C

Re: [PATCH] arm64: dts: sdm845: Add videocc node

2018-11-06 Thread Taniya Das
Thanks Stephen for adding Andy. On 11/6/2018 4:51 AM, Stephen Boyd wrote: Quoting Taniya Das (2018-11-05 02:35:17) This adds the video clock controller node to sdm845 based on the examples in the bindings. Signed-off-by: Taniya Das --- Did you mean to send "To:" Andy? Clk tree doesn't take

Re: [RFC][PATCH] tree-wide: Remove __inline__ and __inline usage

2018-11-06 Thread Miguel Ojeda
On Tue, Nov 6, 2018 at 3:46 PM Peter Zijlstra wrote: > > If you actually read what I wrote: You got me, I did read very quickly :) > Dunno, but that is a far more difficult patch. The proposed one is an > obvious identify. I would say they are orthogonal, even if both would solve the problem. I

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Lorenzo Pieralisi
On Tue, Nov 06, 2018 at 09:47:52AM -0700, Keith Busch wrote: > On Tue, Nov 06, 2018 at 04:34:08PM +, Lorenzo Pieralisi wrote: > > The question is whether we really need to dynamically patch the kernel > > with ftrace to achieve what that patch does. > > > > Furthermore, it would also be good t

Re: [PATCH] slab.h: Avoid using & for logical and of booleans

2018-11-06 Thread Alexander Duyck
On Mon, Nov 5, 2018 at 4:32 PM Bart Van Assche wrote: > > On Mon, 2018-11-05 at 16:11 -0800, Alexander Duyck wrote: > > If we really don't care then why even bother with the switch statement > > anyway? It seems like you could just do one ternary operator and be > > done with it. Basically all you

Re: RFC: userspace exception fixups

2018-11-06 Thread Sean Christopherson
On Tue, 2018-11-06 at 08:57 -0800, Andy Lutomirski wrote: > > So I guess the non-enclave code basically can’t trust its stack pointer > because of these shenanigans. And the AEP code has to live with the fact > that its RSP is basically arbitrary and probably can’t even be unwound > by a debugger?

Re: [PATCH v8] clk: qcom: Add lpass clock controller driver for SDM845

2018-11-06 Thread Stephen Boyd
Quoting Taniya Das (2018-11-02 20:16:20) > On 11/2/2018 10:08 PM, Stephen Boyd wrote: > > Quoting Taniya Das (2018-10-28 00:35:40) > > > > How about moving the QSPI clocks too under this qcom property? Later > could add the support? Yes the plan would be to have QSPI clks there too. Bjorn has s

Re: [PATCH v1 2/2] clk: qcom : dispcc: Add support for display port clocks

2018-11-06 Thread Stephen Boyd
Quoting Taniya Das (2018-10-31 22:02:22) > + Chandan from Display Port team, > > On 10/30/2018 10:03 PM, Stephen Boyd wrote: > > Also, those > > numbers look like gigabits per second (Gbit/s) for the DP spec which > > isn't exactly the same as a clk frequency. What frequency does the PLL > > run a

Re: [PATCH] hyper-v: Fix wakeup from suspend-to-idle

2018-11-06 Thread Vitaly Kuznetsov
"Rafael J. Wysocki" writes: > On Mon, Sep 24, 2018 at 11:24 AM Jiri Kosina wrote: >> >> On Wed, 12 Sep 2018, Vitaly Kuznetsov wrote: >> >> > It makes little sense but still possible to put Hyper-V guests into >> > suspend-to-idle state. To wake them up two wakeup sources were registered >> > in

Re: [RFC/RFT][PATCH v3] cpuidle: New timer events oriented governor for tickless systems

2018-11-06 Thread Peter Zijlstra
On Sun, Nov 04, 2018 at 05:31:20PM +0100, Rafael J. Wysocki wrote: > + * - If there is a pattern of 5 or more recent non-timer wakeups earlier than > + * the closest timer event, expect one more of them to occur and use the > + * average of the idle duration values corresponding to them to sele

Re: RFC: userspace exception fixups

2018-11-06 Thread Dave Hansen
On 11/6/18 8:57 AM, Andy Lutomirski wrote: > I’m assuming it’s way too late for the SGX SDK to be changed to use a > normal RPC mechanism? I’m a bit disappointed that enclaves can even > manipulate outside state like this. I assume Intel had some reason > for making it possible, but still. Just be

Re: + fls-change-parameter-to-unsigned-int.patch added to -mm tree

2018-11-06 Thread Alexey Dobriyan
On Tue, Nov 06, 2018 at 07:44:37AM -0800, Matthew Wilcox wrote: > On Tue, Nov 06, 2018 at 06:14:44PM +0300, Alexey Dobriyan wrote: > > On Mon, Nov 05, 2018 at 03:33:01PM -0800, a...@linux-foundation.org wrote: > > > > > -static inline int fls(int x) > > > +static inline int fls(unsigned int x) > >

Re: [PATCHv3] rtlwifi: rtl8723ae: Remove set but not used variables and #defines

2018-11-06 Thread Kalle Valo
zhong jiang wrote: > radiob_array_table' and 'radiob_arraylen' are not used after setting its > value. > It is safe to remove the unused variable. Meanwhile, radio B array should be > removed as well. because it will no longer be referenced. > > Signed-off-by: zhong jiang > Acked-by: Ping-Ke S

Re: RFC: userspace exception fixups

2018-11-06 Thread Dave Hansen
On 11/6/18 7:37 AM, Sean Christopherson wrote: > > void *sgx_alloc_untrusted_stack(size_t size) > { > struct sgx_encl_tls *tls = get_encl_tls(); > struct sgx_out_call_context *context; > void *tmp; > > /* create a frame on the trusted stack to hold the out-call context */

Re: RFC: userspace exception fixups

2018-11-06 Thread Andy Lutomirski
> On Nov 6, 2018, at 7:37 AM, Sean Christopherson > wrote: > >> On Fri, 2018-11-02 at 16:32 -0700, Andy Lutomirski wrote: >>> On Fri, Nov 2, 2018 at 4:28 PM Jann Horn wrote: >>> >>> >>> On Fri, Nov 2, 2018 at 11:04 PM Sean Christopherson >>> wrote: > On Fri, Nov 02, 2018 at 08:0

Re: [PATCH v16 18/22] platform/x86: Intel SGX driver

2018-11-06 Thread Dave Hansen
On 11/6/18 8:40 AM, Sean Christopherson wrote: >> +struct sgx_encl { >> +unsigned int flags; >> +uint64_t attributes; >> +uint64_t xfrm; >> +unsigned int page_cnt; >> +unsigned int secs_child_cnt; >> +struct mutex lock; >> +struct mm_struct *mm; >> +struct file *back

Re: [PATCH] psi: simplify cgroup_move_task

2018-11-06 Thread Johannes Weiner
On Sat, Nov 03, 2018 at 11:33:39AM -0700, Olof Johansson wrote: > The existing code triggered an invalid warning about 'rq' possibly being > used uninitialized. Instead of doing the silly warning suppression by > initializa it to NULL, refactor the code to bail out early instead. > > Warning was:

Re: [PATCH 00/12] error handling and pciehp maintenance

2018-11-06 Thread Keith Busch
On Tue, Nov 06, 2018 at 04:34:08PM +, Lorenzo Pieralisi wrote: > The question is whether we really need to dynamically patch the kernel > with ftrace to achieve what that patch does. > > Furthermore, it would also be good to report what bugs we are actually > fixing, from what you are writing

Re: [PATCH v4 2/3] arm64: implement live patching

2018-11-06 Thread Miroslav Benes
Hi, On Fri, 26 Oct 2018, Torsten Duwe wrote: > Based on ftrace with regs, do the usual thing. > (see Documentation/livepatch/livepatch.txt) > > Use task flag bit 6 to track patch transisiton state for the consistency > model. Add it to the work mask so it gets cleared on all kernel exits to > us

Re: [PATCH 1/2] perf: Add munmap callback

2018-11-06 Thread Liang, Kan
On 11/6/2018 10:00 AM, Stephane Eranian wrote: /* * mmap 1 page at the location of the unmap page (should reuse virtual space) * This creates a continuous region built from two mmaps and potentially two different sources * especially with jitted runtimes */ The two mmaps are both anon. As my

Re: [PATCH] docs: Extend trusted keys documentation for TPM 2.0

2018-11-06 Thread Jerry Snitselaar
On Fri Oct 19 18, Stefan Berger wrote: Extend the documentation for trusted keys with documentation for how to set up a key for a TPM 2.0 so it can be used with a TPM 2.0 as well. Signed-off-by: Stefan Berger Reviewed-by: Mimi Zohar Acked-by: Jerry Snitselaar --- .../security/keys/trusted

[PATCHv10 0/8] Add Intel Stratix10 FPGA manager and service layer

2018-11-06 Thread richard . gong
From: Richard Gong This is the 10th submission of Intel Stratix10 service layer and FPGA manager driver patches. In this submission I have moved Stratix10 service layer driver .c file to drivers/firmware and header files to include/linux/firmware/intel. I have added Stratix10 service layer docume

Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-06 Thread Dave Hansen
On 11/5/18 9:49 PM, Jarkko Sakkinen wrote: > On Mon, Nov 05, 2018 at 12:27:11PM -0800, Dave Hansen wrote: >> The ABI seems entirely undocumented and rather lightly designed, which >> seems like something we should fix before this is merged. > > ABI is documented in arch/x86/include/uapi/asm/sgx.h

[PATCHv10 2/8] arm64: dts: stratix10: add stratix10 service driver binding to base dtsi

2018-11-06 Thread richard . gong
From: Richard Gong Add Intel Stratix10 service layer to the device tree Signed-off-by: Richard Gong Signed-off-by: Alan Tull Acked-by: Moritz Fischer --- v2: change to put service layer driver node under the firmware node change compatible to "intel, stratix10-svc" v3: no change v4: s/ser

Re: [PATCH v5 4/5] pinctrl: actions: Add Actions Semi S700 pinctrl driver

2018-11-06 Thread Parthiban Nallathambi
ping on this patch series! On 9/4/18 9:28 PM, Saravanan Sekar wrote: On 08/29/18 18:34, Manivannan Sadhasivam wrote: On Wed, Aug 29, 2018 at 10:24:12AM +0200, Saravanan Sekar wrote: Add pinctrl driver for Actions Semi S700 SoC. The driver supports pinctrl, pinmux and pinconf functionalities

<    1   2   3   4   5   6   7   8   >