[patch V2 27/28] x86/speculation: Add seccomp Spectre v2 user space protection mode

2018-11-25 Thread Thomas Gleixner
If 'prctl' mode of user space protection from spectre v2 is selected on the kernel command-line, STIBP and IBPB are applied on tasks which restrict their indirect branch speculation via prctl. SECCOMP enables the SSBD mitigation for sandboxed tasks already, so it makes sense to prevent spectre v2

[patch V2 17/28] x86/speculation: Add command line control for indirect branch speculation

2018-11-25 Thread Thomas Gleixner
Add command line control for user space indirect branch speculation mitigations. The new option is: spectre_v2_user= The initial options are: - on: Unconditionally enabled - off: Unconditionally disabled -auto: Kernel selects mitigation (default off for now) When the spectre_v

[patch V2 18/28] x86/speculation: Prepare for per task indirect branch speculation control

2018-11-25 Thread Thomas Gleixner
To avoid the overhead of STIBP always on, it's necessary to allow per task control of STIBP. Add a new task flag TIF_SPEC_IB and evaluate it during context switch if SMT is active and flag evaluation is enabled by the speculation control code. Add the conditional evaluation to x86_virt_spec_ctrl()

[patch V2 28/28] x86/speculation: Provide IBPB always command line options

2018-11-25 Thread Thomas Gleixner
Provide the possibility to enable IBPB always in combination with 'prctl' and 'seccomp'. Add the extra command line options and rework the IBPB selection to evaluate the command instead of the mode selected by the STIPB switch case. Signed-off-by: Thomas Gleixner --- Documentation/admin-guide/k

[patch V2 13/28] x86/speculation: Reorder the spec_v2 code

2018-11-25 Thread Thomas Gleixner
Reorder the code so it is better grouped. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/cpu/bugs.c | 168 ++--- 1 file changed, 84 insertions(+), 84 deletions(-) --- a/arch/x86/kernel/cpu/bugs.c +++ b/arch/x86/kernel/cpu/bugs.c @@ -124,29 +124,6 @@

[patch V2 19/28] x86/process: Consolidate and simplify switch_to_xtra() code

2018-11-25 Thread Thomas Gleixner
Move the conditional invocation of __switch_to_xtra() into an inline function so the logic can be shared between 32 and 64 bit. Remove the handthrough of the TSS pointer and retrieve the pointer directly in the bitmap handling function. Use this_cpu_ptr() instead of the per_cpu() indirection. Thi

[patch V2 22/28] ptrace: Remove unused ptrace_may_access_sched() and MODE_IBRS

2018-11-25 Thread Thomas Gleixner
The IBPB control code in x86 removed the usage. Remove the functionality which was introduced for this. Signed-off-by: Thomas Gleixner --- include/linux/ptrace.h | 17 - kernel/ptrace.c| 10 -- 2 files changed, 27 deletions(-) --- a/include/linux/ptrace.h ++

[patch V2 21/28] x86/speculation: Prepare for conditional IBPB in switch_mm()

2018-11-25 Thread Thomas Gleixner
The IBPB speculation barrier is issued from switch_mm() when the kernel switches to a user space task with a different mm than the user space task which ran last on the same CPU. An additional optimization is to avoid IBPB when the incoming task can be ptraced by the outgoing task. This optimizati

[patch V2 05/28] x86/speculation: Disable STIBP when enhanced IBRS is in use

2018-11-25 Thread Thomas Gleixner
If enhanced IBRS is active, STIBP is redundant for mitigating Spectre v2 user space exploits from hyperthread sibling. Disable STIBP when enhanced IBRS is used. Signed-off-by: Tim Chen Signed-off-by: Thomas Gleixner --- arch/x86/kernel/cpu/bugs.c |7 +++ 1 file changed, 7 insertions(+

[patch V2 04/28] x86/speculation: Reorganize cpu_show_common()

2018-11-25 Thread Thomas Gleixner
The Spectre V2 printout in cpu_show_common() handles conditionals for the various mitigation methods directly in the sprintf() argument list. That's hard to read and will become unreadable if more complex decisions need to be made for a particular method. Move the conditionals for STIBP and IBPB s

[patch V2 09/28] x86/Kconfig: Select SCHED_SMT if SMP enabled

2018-11-25 Thread Thomas Gleixner
CONFIG_SCHED_SMT is enabled by all distros, so there is not a real point to have it configurable. The runtime overhead in the core scheduler code is minimal because the actual SMT scheduling parts are conditional on a static key. This allows to expose the scheduler's SMT state static key to the sp

[patch V2 11/28] x86/speculation: Rework SMT state change

2018-11-25 Thread Thomas Gleixner
arch_smt_update() is only called when the sysfs SMT control knob is changed. This means that when SMT is enabled in the sysfs control knob the system is considered to have SMT active even if all siblings are offline. To allow finegrained control of the speculation mitigations, the actual SMT state

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-11-25 Thread Dr. Greg
On Sun, Nov 25, 2018 at 08:22:35AM -0800, Andy Lutomirski wrote: Good morning to everyone, I hope the weekend continues to proceed well. Proposal follows below for kernel based policy management of enclaves if people want to skip forward. > >> On Nov 25, 2018, at 6:53 AM, Jarkko Sakkinen > >>

Re: [PATCH] mm: put_and_wait_on_page_locked() while page is migrated

2018-11-25 Thread Linus Torvalds
On Sat, Nov 24, 2018 at 7:21 PM Hugh Dickins wrote: > > Linus, I'm addressing this patch to you because I see from Tim Chen's > thread that it would interest you, and you were disappointed not to > root cause the issue back then. I'm not pushing for you to fast-track > this into 4.20-rc, but I ex

[PATCH] clk: rockchip: add clock ID of ACODEC for rk3328

2018-11-25 Thread Katsuhiro Suzuki
This patch adds clock ID of audio CODEC (ACODEC) for rk3328. Signed-off-by: Katsuhiro Suzuki --- include/dt-bindings/clock/rk3328-cru.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/clock/rk3328-cru.h b/include/dt-bindings/clock/rk3328-cru.h index 9d5f799469ee..bcaa455

[PATCH] clk: rockchip: add clock gate of ACODEC for rk3328

2018-11-25 Thread Katsuhiro Suzuki
This patch adds small changes into clock gate definition to enable ACODEC for rk3328. Signed-off-by: Katsuhiro Suzuki --- drivers/clk/rockchip/clk-rk3328.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/rockchip/clk-rk3328.c b/drivers/clk/rockchip/clk-rk3328.c i

[PATCH] KVM: x86: Trace changes to active TSC offset regardless if vCPU in guest-mode

2018-11-25 Thread Paolo Bonzini
For some reason, kvm_x86_ops->write_l1_tsc_offset() skipped trace of change to active TSC offset in case vCPU is in guest-mode. This patch changes write_l1_tsc_offset() behavior to trace any change to active TSC offset to aid debugging. The VMX code is changed to look more similar to SVM, which is

Re: [GIT PULL] Please pull NFS client changes

2018-11-25 Thread pr-tracker-bot
The pull request you sent on Sun, 25 Nov 2018 03:04:11 +: > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/17c2f540863a6c0faa3f0ede3c785d9427bcaf80 Thank you! -- Deet-doot-dot, I am a bot

Re: [GIT PULL] XArray updates

2018-11-25 Thread pr-tracker-bot
The pull request you sent on Sat, 24 Nov 2018 09:32:09 -0800: > git://git.infradead.org/users/willy/linux-dax.git xarray has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e2125dac22f2c9c66c412cd8e049a7305af59f73 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wik

Re: [GIT PULL] dma-mapping fixes for 4.20

2018-11-25 Thread pr-tracker-bot
The pull request you sent on Sun, 25 Nov 2018 09:35:52 +0100: > git://git.infradead.org/users/hch/dma-mapping.git tags/dma-mapping-4.20-3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d6d460b89378b1bc6715574cdafd748ba59d5a27 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH] x86/kvm/vmx: fix old-style function declaration

2018-11-25 Thread Paolo Bonzini
On 08/11/18 04:22, Yi Wang wrote: > The inline keyword which is not at the beginning of the function > declaration may trigger the following build warnings, so let's fix it: > > arch/x86/kvm/vmx.c:1309:1: warning: ‘inline’ is not at beginning of > declaration [-Wold-style-declaration] > arch/x86/

Re: [PATCH] KVM: x86: fix empty-body warnings

2018-11-25 Thread Paolo Bonzini
On 08/11/18 09:48, Yi Wang wrote: > We get the following warnings about empty statements when building > with 'W=1': > > arch/x86/kvm/lapic.c:632:53: warning: suggest braces around empty body in an > ‘if’ statement [-Wempty-body] > arch/x86/kvm/lapic.c:1907:42: warning: suggest braces around empt

Re: [PATCH] svm: Add mutex_lock to protect apic_access_page_done on AMD systems

2018-11-25 Thread Paolo Bonzini
On 12/11/18 14:37, j...@8bytes.org wrote: > On Mon, Nov 12, 2018 at 12:23:14PM +, Suthikulpanit, Suravee wrote: >> From: Wei Wang >> >> There is a race condition when accessing kvm->arch.apic_access_page_done. >> Due to it, x86_set_memory_region will fail when creating the second vcpu >> for a

Re: [PATCH] KVM: LAPIC: Fix pv ipis use-before-initialization

2018-11-25 Thread Paolo Bonzini
On 20/11/18 02:39, Wanpeng Li wrote: > Reported by syzkaller: > > BUG: unable to handle kernel NULL pointer dereference at 0014 > PGD 80040410c067 P4D 80040410c067 PUD 40410d067 PMD 0 > Oops: [#1] PREEMPT SMP PTI > CPU: 3 PID: 2567 Comm: poc Tainted: G OE

Re: [PATCH] KVM: X86: Fix scan ioapic use-before-initialization

2018-11-25 Thread Paolo Bonzini
On 20/11/18 09:34, Wanpeng Li wrote: > From: Wanpeng Li > > Reported by syzkaller: > > BUG: unable to handle kernel NULL pointer dereference at 01c8 > PGD 8003ec4da067 P4D 8003ec4da067 PUD 3f7bfa067 PMD 0 > Oops: [#1] PREEMPT SMP PTI > CPU: 7 PID: 5059 Comm: debug T

Re: Question about "regulator: core: Only count load for enabled consumers" in -next

2018-11-25 Thread Doug Anderson
Hi, On Sun, Nov 25, 2018 at 1:37 AM Brian Masney wrote: > I bisected the issue to the following commit: > > 5451781dadf8 ("regulator: core: Only count load for enabled consumers") > > We have to increase the load for the sdhci in device tree in order for > the phone to boot properly. This change

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Tony Lindgren
* Aaro Koskinen [181125 16:58]: > Below changes get traffic going with DMA & g_ether... Oh cool, if you have dma and g_ether working, you should test it with a variable size ping test loop :) That should expose any issues within few minutes. Below is the test script I was using earlier, the tusb

[PATCH] staging: greybus: Parenthesis alignment

2018-11-25 Thread Cristian Sicilia
Some parameters are aligned with parentheses. Some parentheses was opened at end of line. Signed-off-by: Cristian Sicilia --- Changes on v2: * There was some function that was splitted in two line, as suggested, is better to keep it in one line. drivers/staging/greybus/audio_manager_modul

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Aaro Koskinen
Hi, On Sun, Nov 25, 2018 at 11:11:05AM +, Russell King - ARM Linux wrote: > I think we're better off leaving omap-udc well alone, and if it's > now broken with DMA, then that's unfortunate - it would require > someone with the hardware to diagnose the problem and fix it. I > think trying to c

[PATCH] MAINTAINERS: change Sparse's maintainer

2018-11-25 Thread Luc Van Oostenryck
I'm taking over the maintainance of Sparse so add myself as maintainer and move Christopher's info to CREDITS. Signed-off-by: Luc Van Oostenryck --- CREDITS | 4 MAINTAINERS | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CREDITS b/CREDITS index 5befd2d71..3d3e79

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-11-25 Thread Andy Lutomirski
>> On Nov 25, 2018, at 6:53 AM, Jarkko Sakkinen >> wrote: >> >> On Sat, Nov 24, 2018 at 09:21:14AM -0800, Jarkko Sakkinen wrote: >> On Thu, Nov 22, 2018 at 07:21:08AM -0800, Andy Lutomirski wrote: At a high level, addressing these issues is straight forward. First, the driver needs

The "udl" driver crashes the kernel.

2018-11-25 Thread wzabo...@elektron.elka.pw.edu.pl
When I connect my Displaylink DL-165 adapter to my Debian/testing machine, the "udl" driver is loaded and the following error messages appears in kernel logs: Nov  7 20:47:30 wzdell kernel: [  205.871354] usb 4-1.2: new high-speed USB device number 4 using ehci-pci Nov  7 20:47:35 wzdell kernel:

Re: [PATCH 1/3] iio: add IIO_MASSCONCENTRATION channel type

2018-11-25 Thread Tomasz Duszynski
On Sun, Nov 25, 2018 at 06:14:44AM -0800, Matt Ranostay wrote: > On Sun, Nov 25, 2018 at 6:03 AM Jonathan Cameron > wrote: > > > > On Sun, 25 Nov 2018 05:51:32 -0800 > > Matt Ranostay wrote: > > > > > On Sat, Nov 24, 2018 at 2:14 PM Tomasz Duszynski > > > wrote: > > > > > > > > Measuring partic

Re: [PATCH 1/3] iio: add IIO_MASSCONCENTRATION channel type

2018-11-25 Thread Tomasz Duszynski
On Sun, Nov 25, 2018 at 02:03:16PM +, Jonathan Cameron wrote: > On Sun, 25 Nov 2018 05:51:32 -0800 > Matt Ranostay wrote: > > > On Sat, Nov 24, 2018 at 2:14 PM Tomasz Duszynski wrote: > > > > > > Measuring particulate matter in ug / m3 (micro-grams per cubic meter) > > > is de facto standard.

WARNING: bad usercopy in corrupted (2)

2018-11-25 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:aea0a897af9e ptp: Fix pass zero to ERR_PTR() in ptp_clock_.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=101b91d540 kernel config: https://syzkaller.appspot.com/x/.config?x=c36a72af2123e78a da

Re: [PATCH 1/3] iio: add IIO_MASSCONCENTRATION channel type

2018-11-25 Thread Tomasz Duszynski
On Sun, Nov 25, 2018 at 08:35:07AM +, Jonathan Cameron wrote: > On Sat, 24 Nov 2018 23:14:13 +0100 > Tomasz Duszynski wrote: > > > Measuring particulate matter in ug / m3 (micro-grams per cubic meter) > > is de facto standard. Existing air quality sensors usually follow > > this convention and

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-11-25 Thread Jarkko Sakkinen
On Sat, Nov 24, 2018 at 09:21:14AM -0800, Jarkko Sakkinen wrote: > On Thu, Nov 22, 2018 at 07:21:08AM -0800, Andy Lutomirski wrote: > > > At a high level, addressing these issues is straight forward. First, > > > the driver needs to support authorization equivalent to that which is > > > implement

Re: [PATCH 1/3] iio: add IIO_MASSCONCENTRATION channel type

2018-11-25 Thread Matt Ranostay
On Sun, Nov 25, 2018 at 6:03 AM Jonathan Cameron wrote: > > On Sun, 25 Nov 2018 05:51:32 -0800 > Matt Ranostay wrote: > > > On Sat, Nov 24, 2018 at 2:14 PM Tomasz Duszynski wrote: > > > > > > Measuring particulate matter in ug / m3 (micro-grams per cubic meter) > > > is de facto standard. Existi

Re: [PATCH] iio: hid-sensor-hub: clean up indentation, remove extraneous tab

2018-11-25 Thread Jonathan Cameron
On Sun, 18 Nov 2018 16:27:57 + Colin King wrote: > From: Colin Ian King > > The statement is indented too much by one level, fix this by > removing the extraneous tab. > > Signed-off-by: Colin Ian King Applied to the togreg branch of iio.git and pushed out as testing because lots of other

Re: [PATCH 1/3] iio: add IIO_MASSCONCENTRATION channel type

2018-11-25 Thread Jonathan Cameron
On Sun, 25 Nov 2018 05:51:32 -0800 Matt Ranostay wrote: > On Sat, Nov 24, 2018 at 2:14 PM Tomasz Duszynski wrote: > > > > Measuring particulate matter in ug / m3 (micro-grams per cubic meter) > > is de facto standard. Existing air quality sensors usually follow > > this convention and are capabl

Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-25 Thread Masahiro Yamada
On Sat, Nov 24, 2018 at 6:06 PM Miguel Ojeda wrote: > > On Fri, Nov 23, 2018 at 10:14 PM Luc Van Oostenryck > wrote: > > > > On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote: > > > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot > > > reported lots of "unknown

Re: [PATCH v4 0/2] dmaengine: add UniPhier MIO DMAC driver

2018-11-25 Thread Masahiro Yamada
On Sat, Nov 24, 2018 at 11:16 PM Vinod Koul wrote: > > On 12-10-18, 01:41, Masahiro Yamada wrote: > > 1/2: DT-binding > > 2/2: driver > > Applied this series, thanks Thanks. > While building I noticed that we get few warns when compiling with > C=1, I would prefer you fix them. Please send fix

Re: [PATCH 1/3] iio: add IIO_MASSCONCENTRATION channel type

2018-11-25 Thread Matt Ranostay
On Sat, Nov 24, 2018 at 2:14 PM Tomasz Duszynski wrote: > > Measuring particulate matter in ug / m3 (micro-grams per cubic meter) > is de facto standard. Existing air quality sensors usually follow > this convention and are capable of returning measurements using > this unit. > > IIO currently doe

Re: [PATCH 2/2] iio: adc: ti_am335x_tscadc: Improve accuracy of measurement

2018-11-25 Thread Jonathan Cameron
On Mon, 19 Nov 2018 12:12:36 +0530 Vignesh R wrote: > When performing single ended measurements with TSCADC, its recommended > to set negative input (SEL_INM_SWC_3_0) of ADC step to ADC's VREFN in the > corresponding STEP_CONFIGx register. > Also, the positive(SEL_RFP_SWC_2_0) and negative(SEL_RF

Re: [PATCH] iio: st_sensors: Fix the sleep time for sampling

2018-11-25 Thread Jonathan Cameron
On Wed, 21 Nov 2018 13:13:40 +0800 Jian-Hong Pan wrote: > Denis CIOCCA 於 2018年11月20日 週二 上午3:05寫道: > > > > Hi Jian, > > > > Not clear to me why should be + instead of *. > > > > ODR is expressed in Hz, so (1/Hz) = period in seconds (1 sample sampling > > time) [s] > > 1000 * (1/Hz) = period in m

Re: [PATCH 3/3] iio: adc: stm32-adc: switch off running adc when going to low power

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 11:12:32 +0100 Fabrice Gasnier wrote: > Switch off ADC when going to low power mode, in case it has been left > running in buffer mode. Then re-enable it when resuming. > > Signed-off-by: Fabrice Gasnier My suspicion is that we have other drivers not correctly handing this c

Re: [PATCH 2/3] iio: adc: stm32-adc: add power management support

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 11:12:31 +0100 Fabrice Gasnier wrote: > Add support for runtime PM & sleep. Move all regulator and clock management > to dedicated HW start/stop routines. Then rely on (runtime) PM OPS to > call them. > > Signed-off-by: Fabrice Gasnier Whilst I'll be the first to admit that

Re: [PATCH 1/3] iio: adc: stm32-adc: move self-calibration to prepare routine

2018-11-25 Thread Jonathan Cameron
On Sun, 25 Nov 2018 13:03:39 + Jonathan Cameron wrote: > On Tue, 20 Nov 2018 11:12:30 +0100 > Fabrice Gasnier wrote: > > > Move self-calibration routine to prepare routine. > > - This is precursor patch to ease power management handling. > > - This also allow to factorize few error cases (e

Re: WARNING in sysfs_remove_group (2)

2018-11-25 Thread Tetsuo Handa
On 2018/11/25 20:21, syzbot wrote: > syzbot has found a reproducer for the following crash on: > > HEAD commit:    e195ca6cb6f2 Merge branch 'for-linus' of git://git.kernel... > git tree:   upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1659a62b40 > kernel config:  ht

Re: [PATCH 1/3] iio: adc: stm32-adc: move self-calibration to prepare routine

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 11:12:30 +0100 Fabrice Gasnier wrote: > Move self-calibration routine to prepare routine. > - This is precursor patch to ease power management handling. > - This also allow to factorize few error cases (error handling). > > Signed-off-by: Fabrice Gasnier one trivial point in

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Russell King - ARM Linux
On Sun, Nov 25, 2018 at 11:11:05AM +, Russell King - ARM Linux wrote: > On Sat, Nov 24, 2018 at 05:07:17PM -0800, Tony Lindgren wrote: > > * Russell King - ARM Linux [181124 20:10]: > > > On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > > > > Hi, > > > > > > > > On Fri, Nov 23

Re: [PATCH v2 5/5] Staging: iio: adt7316: Use device tree data to assign irq_type

2018-11-25 Thread Jonathan Cameron
On Wed, 21 Nov 2018 15:02:52 +0530 Shreeya Patel wrote: > On Wed, 2018-11-21 at 08:21 +, Ardelean, Alexandru wrote: > > On Tue, 2018-11-20 at 22:30 +0530, Shreeya Patel wrote: > > > ADT7316 driver no more uses platform data and hence use device tree > > > data instead of platform data for a

Re: [PATCH v2 4/5] Staging: iio: adt7316: Change the name from irq_flags to irq_type

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 22:28:36 +0530 Shreeya Patel wrote: > Most of the drivers in IIO uses irq_type as the name for > storing the interrupt type and hence change the name from > irq_flags to irq_type for maintaining the consistency. > > Signed-off-by: Shreeya Patel Applied to the togreg branch o

Re: [PATCH v2 3/5] Staging: iio: adt7316: Switch irq_flags to a local variable

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 22:26:58 +0530 Shreeya Patel wrote: > There is no need to store irq_flags into the structure as it > is always set to the same thing. Hence switch irq_flags to a > local variable. > > Signed-off-by: Shreeya Patel Applied to the togreg branch of iio.git and pushed out as test

Re: [PATCH v2 2/5] Staging: iio: adt7316: Use device tree data to set ldac_pin

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 22:24:36 +0530 Shreeya Patel wrote: > Make the driver use device tree instead of the platform data. > Hence, use devm_gpiod_get_optional function to get the data from > device tree for ldac-pin and accordingly make the needed changes > in the driver. > > Signed-off-by: Shreey

Re: [PATCH v2 1/5] Staging: iio: adt7316: Add of_device_id table

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 22:22:30 +0530 Shreeya Patel wrote: > When the kernel starts up, it kicks off compiled-in drivers > that match “compatible” entries it finds in the device tree. > At a later stage (when /lib/modules is available), all kernel modules > that match “compatible” entries in the dev

Re: [PATCH v2 2/2] dt-bindings: iio: adc: Add docs for AD7606 ADC

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 17:44:37 +0200 Stefan Popa wrote: > Document support for AD7606 Analog to Digital Converter. > > Signed-off-by: Stefan Popa This looks good to me, but given my recent inability to pick up on the subtle (and not so subtle) issues in DT patches, I'd like a review from the DT s

Re: [PATCH v2 1/2] staging: iio: ad7606: Move out of staging

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 17:43:46 +0200 Stefan Popa wrote: > Move ad7606 ADC driver out of staging and into the mainline. > > Signed-off-by: Stefan Popa One idle thought, how much would the performance suffer if we moved the parallel path over to the new gpiod_get/set_raw_array_value and friends?

Re: [PATCH] ALSA: pcm: Fix starvation on down_write_nonblock()

2018-11-25 Thread kbuild test robot
Hi Chanho, I love your patch! Yet something to improve: [auto build test ERROR on sound/for-next] [also build test ERROR on v4.20-rc3 next-20181123] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commi

Re: WARNING in sysfs_remove_group (2)

2018-11-25 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:e195ca6cb6f2 Merge branch 'for-linus' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1659a62b40 kernel config: https://syzkaller.appspot.com/x/.config?x=73e2bc

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 05:07:17PM -0800, Tony Lindgren wrote: > * Russell King - ARM Linux [181124 20:10]: > > On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > > > Hi, > > > > > > On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > > > > On 22/11/2018 17.12, Russell

Re: [PATCH] staging: iio: ad7780: Add gain & filter gpio support

2018-11-25 Thread Jonathan Cameron
On Thu, 22 Nov 2018 11:01:00 + "Popa, Stefan Serban" wrote: > On Mi, 2018-11-21 at 16:04 -0200, Giuliano Belinassi wrote: > > Previously, the AD7780 driver only supported gpio for the 'powerdown' > > pin. This commit adds suppport for the 'gain' and 'filter' pin. > Hey, > > Comments inline

Re: [PATCH] staging: iio: ad5933: replaced kfifo by triggered_buffer

2018-11-25 Thread Jonathan Cameron
On Thu, 22 Nov 2018 10:53:47 -0200 Marcelo Schmitt wrote: > Previously, there was an implicit creation of a kfifo which was replaced > by a call to triggered_buffer_setup, which is already implemented in iio > infrastructure. > > Signed-off-by: Marcelo Schmitt I'm a little surprised that this

Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-11-25 Thread Himanshu Jha
On Sat, Nov 24, 2018 at 11:14:14PM +0100, Tomasz Duszynski wrote: > Add support for Sensirion SPS30 particulate matter sensor. > > Signed-off-by: Tomasz Duszynski > --- > drivers/iio/chemical/Kconfig | 11 ++ > drivers/iio/chemical/Makefile | 1 + > drivers/iio/chemical/sps30.c | 359 ++

Re: [PATCH 1/1] iio: adc: meson-saradc: fix internal clock names

2018-11-25 Thread Jonathan Cameron
On Thu, 22 Nov 2018 23:01:11 +0100 Martin Blumenstingl wrote: > Before this patch we are registering the internal clocks (for example on > Meson8b, where the SAR ADC IP block implements the divider and gate > clocks) with the following names: > - /soc/cbus@c110/adc@8680#adc_div > - /soc/cbus@

Re: [PATCH] iio: adc: meson-saradc: check for devm_kasprintf failure

2018-11-25 Thread Jonathan Cameron
On Thu, 22 Nov 2018 22:44:55 +0100 Martin Blumenstingl wrote: > On Thu, Nov 22, 2018 at 8:52 AM Nicholas Mc Guire wrote: > > > > devm_kasprintf() may return NULL on failure of internal allocation thus > > the assignments to init.name are not safe if not checked. On error > > meson_sar_adc_clk_

Re: [PATCH v3 2/4] iio: adc: add STMPE ADC driver using IIO framework

2018-11-25 Thread Jonathan Cameron
On Fri, 23 Nov 2018 15:24:09 +0100 Philippe Schenker wrote: > From: Stefan Agner > > This adds an ADC driver for the STMPE device using the industrial > input/output interface. The driver supports raw reading of values. > The driver depends on the MFD STMPE driver. If the touchscreen > block is

Re: [PATCH v4] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-11-25 Thread Pavel Machek
Hi! > Use the gpiod interface instead of the deprecated old non-descriptor > interface in olpc_dcon_xo_1.c. > > Signed-off-by: Nishad Kamdar You may want to cc: lkund...@v3.sk, he was doing great work on OLPC lately... Best regards,

Re: [PATCH v3 3/4] iio: adc: add STMPE ADC devicetree bindings

2018-11-25 Thread Jonathan Cameron
On Fri, 23 Nov 2018 15:24:10 +0100 Philippe Schenker wrote: > From: Stefan Agner > > This adds the devicetree bindings for the STMPE ADC. > > Signed-off-by: Stefan Agner > Signed-off-by: Max Krummenacher > Signed-off-by: Philippe Schenker Clearly this will need review from input and mfd. I

Re: [PATCH v2] staging: iio: ad5933: add device tree support

2018-11-25 Thread Jonathan Cameron
On Sat, 24 Nov 2018 11:18:57 -0200 Marcelo Schmitt wrote: > Add a of_device_id struct variable and subsequent call to > MODULE_DEVICE_TABLE macro to complete device tree support. > > Signed-off-by: Marcelo Schmitt Applied to the togreg branch of iio.git and pushed out as testing for the autobui

Re: [PATCH v3 7/7] staging:iio:ad2s90: Move out of staging

2018-11-25 Thread Jonathan Cameron
On Fri, 23 Nov 2018 22:23:12 -0200 Matheus Tavares wrote: > Move ad2s90 resolver driver out of staging to the main tree. > > Signed-off-by: Matheus Tavares > Signed-off-by: Victor Colombo Hi. One totally trivial comment inline, but if you want to clean that up, do it after we have moved this

Re: [PATCH 00/16] x86/microcode/AMD: Improve container verification

2018-11-25 Thread Pavel Machek
On Wed 2018-11-07 18:02:02, Borislav Petkov wrote: > From: Borislav Petkov > > Hi all, > > this is work which got started by Maciej a while ago. I have finally had > the time to redo all the ideas properly, split it in self-contained, > logical chunks and test it. > > Reveiew and comments are a

Re: [PATCH v2] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-25 Thread Frank Lee
On Sun, Nov 25, 2018 at 5:43 PM Daniel Lezcano wrote: > > On 25/11/2018 06:00, Yangtao Li wrote: > > of_find_node_by_path() acquires a reference to the node > > returned by it and that reference needs to be dropped by its caller. > > integrator_ap_timer_init_of() doesn't do that.The pri_node and t

Re: [PATCH v2] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-25 Thread Daniel Lezcano
On 25/11/2018 06:00, Yangtao Li wrote: > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > integrator_ap_timer_init_of() doesn't do that.The pri_node and the > sec_node are used as an identifier to compare against the cu

Re: [PATCH] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-25 Thread Daniel Lezcano
On 25/11/2018 05:25, Frank Lee wrote: > On Sun, Nov 25, 2018 at 3:49 AM Daniel Lezcano > wrote: >> >> On 24/11/2018 15:58, Frank Lee wrote: >>> On Thu, Nov 22, 2018 at 11:23 PM Yangtao Li wrote: of_find_node_by_path() acquires a reference to the node returned by it and that referen

Question about "regulator: core: Only count load for enabled consumers" in -next

2018-11-25 Thread Brian Masney
Hi all, I see errors like the following in linux next-20181123 when trying to boot a mainline kernel on a LG Nexus 5 phone: [ 14.495056] mmc1: Card stuck in wrong state! mmcblk1 card_busy_detect status: 0xe00 [ 14.495185] mmc1: cache flush error -110 [ 14.601547] mmc1: Reset 0x1 never comp

Re: [PATCH 1/3] x86: add support for Huawei WMI hotkeys.

2018-11-25 Thread Pavel Machek
On Wed 2018-10-31 15:19:36, Ayman Bagabas wrote: > This driver adds support for missing hotkeys on some Huawei laptops. > Currently, only Huawei Matebook X Pro is supported. The driver > recognizes the following keys: brightness keys, micmute, wlan, and > Huawei special key. The brightness keys are

[PATCH] openrisc: Add spaces around & operator

2018-11-25 Thread Liu Xiang
Add spaces around '&' to follow kernel coding style. Signed-off-by: Liu Xiang --- arch/openrisc/include/asm/fixmap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/openrisc/include/asm/fixmap.h b/arch/openrisc/include/asm/fixmap.h index 5a01595..75c7a77 100644 --- a/ar

[PATCH] asm-generic: Add spaces around & operator

2018-11-25 Thread Liu Xiang
Add spaces around '&' to follow kernel coding style. Signed-off-by: Liu Xiang --- include/asm-generic/fixmap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/asm-generic/fixmap.h b/include/asm-generic/fixmap.h index 827e4d3..d6e8da3 100644 --- a/include/asm-generic/f

[PATCH] arm64: mm: Add spaces around + operator

2018-11-25 Thread Liu Xiang
Add spaces around '+' to follow kernel coding style. Signed-off-by: Liu Xiang --- arch/arm64/mm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index d1d6601..1dbd7be 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@

[PATCH] staging: pi433: fix potential null dereference

2018-11-25 Thread Michael Straube
Add a test for successful call to cdev_alloc() to avoid potential null dereference. Issue reported by smatch. Signed-off-by: Michael Straube --- drivers/staging/pi433/pi433_if.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433

RFC: script to convert vsprintf uses of %pf to %ps and %pF to %pS

2018-11-25 Thread Joe Perches
commit 04b8eb7a4ccd ("symbol lookup: introduce dereference_symbol_descriptor()}" deprecated vsprintf extension %pf and %pF. There are approximately these total uses of the symbolic lookup vsprintf extensions %p[SsFf]: $ git grep '".*[^%]%p[SsFf]' | \ grep -oh '%p[SsFf]' | sort | uniq -c | sort

For your Perusal

2018-11-25 Thread John William
Dearest , Its really good to see your Prompt Response it show how Responsible and diligent you will be in handling the sum of $10.5 MILLION if placed in your care and for investment Purposes in your Country . These said Funds have being placed in Safekeeping in DEUTSCHE BANK in SOUTH AFRICA f

Re: [PATCH 3/3] iio: chemical: sps30: add device tree support

2018-11-25 Thread Jonathan Cameron
On Sat, 24 Nov 2018 23:14:15 +0100 Tomasz Duszynski wrote: > Add device tree support for Sensirion SPS30 particulate > matter sensor. > > Signed-off-by: Tomasz Duszynski one comment inine, around the fact we are trying to move to generic names in DT where ever possible. Now we don't have a sui

Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-11-25 Thread Jonathan Cameron
On Sat, 24 Nov 2018 23:14:14 +0100 Tomasz Duszynski wrote: > Add support for Sensirion SPS30 particulate matter sensor. > > Signed-off-by: Tomasz Duszynski A few things inline. I'm particularly curious as to why we are ignoring two of the particle sizes that the sensor seems to capture? Also,

Re: [PATCH 1/3] iio: add IIO_MASSCONCENTRATION channel type

2018-11-25 Thread Jonathan Cameron
On Sat, 24 Nov 2018 23:14:13 +0100 Tomasz Duszynski wrote: > Measuring particulate matter in ug / m3 (micro-grams per cubic meter) > is de facto standard. Existing air quality sensors usually follow > this convention and are capable of returning measurements using > this unit. > > IIO currently

Re: [RFC PATCH 1/5] mm: print more information about mapping in __dump_page

2018-11-25 Thread Michal Hocko
On Fri 23-11-18 16:04:04, Andrew Morton wrote: > On Wed, 7 Nov 2018 11:18:26 +0100 Michal Hocko wrote: > > > From: Michal Hocko > > > > __dump_page prints the mapping pointer but that is quite unhelpful > > for many reports because the pointer itself only helps to distinguish > > anon/ksm mapp

<    1   2   3