[PATCH v3] vfio_pci: Enable memory accesses before calling pci_map_rom

2019-02-15 Thread Eric Auger
pci_map_rom/pci_get_rom_size() performs memory access in the ROM. In case the Memory Space accesses were disabled, readw() is likely to trigger a synchronous external abort on some platforms. In case memory accesses were disabled, re-enable them before the call and disable them back again just aft

Re: [PATCH v5 05/10] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings

2019-02-15 Thread Tony Lindgren
Hi, * Lokesh Vutla [190214 18:03]: > On 2/14/2019 11:16 PM, Tony Lindgren wrote: > > But I'd rather have a proper hardware based phandle + index > > type mapping in the dts if possible though. > > The idea about sysfw here is that Linux is not aware of anything about > this device(Interrupt Rout

Re: [PATCH] drm: Mark expected switch fall-throughs

2019-02-15 Thread Gustavo A. R. Silva
On 2/15/19 10:11 AM, Alex Deucher wrote: > On Fri, Feb 15, 2019 at 11:08 AM Gustavo A. R. Silva > wrote: >> >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> Notice th

[PATCH] net: phy: xgmiitorgmii: Support generic PHY status read

2019-02-15 Thread Paul Kocialkowski
Some PHY drivers like the generic one do not provide a read_status callback on their own but rely on genphy_read_status being called directly. With the current code, this results in a NULL function pointer call. Call genphy_read_status instead when there is no specific callback. Signed-off-by: Pa

[PATCH] ARC: [plat-hsdk]: Add reset controller handle to manage USB reset

2019-02-15 Thread Eugeniy Paltsev
DW USB controller on HSDK hangs sometimes after SW reset, so add reset handle to make possible to reset DW USB controller HW. Signed-off-by: Eugeniy Paltsev --- arch/arc/boot/dts/hsdk.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dt

Re: [PATCH v3] exec: load_script: Do not exec truncated interpreter path

2019-02-15 Thread Oleg Nesterov
On 02/14, Kees Cook wrote: > > --- a/fs/binfmt_script.c > +++ b/fs/binfmt_script.c > @@ -42,9 +42,18 @@ static int load_script(struct linux_binprm *bprm) > fput(bprm->file); > bprm->file = NULL; > > - bprm->buf[BINPRM_BUF_SIZE - 1] = '\0'; > - if ((cp = strchr(bprm->buf,

Re: Userspace regression in LTS and stable kernels

2019-02-15 Thread Samuel Dionne-Riel
On 15/02/2019, Michal Hocko wrote: > On Fri 15-02-19 10:19:12, Sasha Levin wrote: >> On Fri, Feb 15, 2019 at 10:42:05AM +0100, Michal Hocko wrote: >> > On Fri 15-02-19 10:20:13, Greg KH wrote: >> > > On Fri, Feb 15, 2019 at 10:10:00AM +0100, Michal Hocko wrote: >> > > > On Fri 15-02-19 08:00:22, G

[RFC PATCH 4.4] Documentation/network: reword kernel version reference

2019-02-15 Thread Mark Rustad
It seemed odd to say "since 4.17" in a 4.4 kernel. Consider rewording the reference to indicate where in the stable series it was introduced as well as where it originated. Signed-off-by: Mark Rustad --- Does this brief elaboration add useful information? It seems to me that someone using a par

Re: [PATCH 1/2] regulator: ltc3676: Simplify .readable_reg and .writable_reg callbacks

2019-02-15 Thread Tim Harvey
On Fri, Feb 15, 2019 at 3:54 AM Axel Lin wrote: > > Use case range for continuous range to make the code shorter. > The .readable_reg and .writable_reg implementation are exactly the same, > so use a common ltc3676_readable_writeable_reg function instead. > > Signed-off-by: Axel Lin > --- > driv

Re: [PATCH] net: phy: xgmiitorgmii: Support generic PHY status read

2019-02-15 Thread Andrew Lunn
On Fri, Feb 15, 2019 at 05:17:08PM +0100, Paul Kocialkowski wrote: > Some PHY drivers like the generic one do not provide a read_status > callback on their own but rely on genphy_read_status being called > directly. > > With the current code, this results in a NULL function pointer call. > Call ge

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-15 Thread Nicolas Dufresne
Le vendredi 15 février 2019 à 14:44 +0100, Hans Verkuil a écrit : > Hi Stanimir, > > I never paid much attention to this patch series since others were busy > discussing it and I had a lot of other things on my plate, but then I heard > that this patch made G_FMT blocking. > > That's a no-go. App

Re: [PATCH v3] exec: load_script: Do not exec truncated interpreter path

2019-02-15 Thread Kees Cook
On Fri, Feb 15, 2019 at 8:18 AM Oleg Nesterov wrote: > WITHOUT '\n' at the end. If I read load_script() correctly it should work, > so I think the 2nd for() loop should also reset "truncated" if *cp == '\0'. Correct. My original v3 handles this correctly. I'll work on a version with small inline

Re: [Xen-devel][PATCH 1/2] xen/gntdev: Do not destroy context while dma-bufs are in use

2019-02-15 Thread Juergen Gross
On 15/02/2019 16:35, Oleksandr Andrushchenko wrote: > On 2/15/19 5:28 PM, Boris Ostrovsky wrote: >> On 2/15/19 10:07 AM, Oleksandr Andrushchenko wrote: >>> On 2/15/19 5:03 PM, Boris Ostrovsky wrote: On 2/14/19 9:23 AM, Oleksandr Andrushchenko wrote: >      /* DMA buffer export support. */

Re: [PATCH] net: phy: xgmiitorgmii: Support generic PHY status read

2019-02-15 Thread Paul Kocialkowski
Hi, On Fri, 2019-02-15 at 17:23 +0100, Andrew Lunn wrote: > On Fri, Feb 15, 2019 at 05:17:08PM +0100, Paul Kocialkowski wrote: > > Some PHY drivers like the generic one do not provide a read_status > > callback on their own but rely on genphy_read_status being called > > directly. > > > > With th

Re: [PATCH 0/2] ARM errata 814220

2019-02-15 Thread Alexandre Torgue
On 2/13/19 3:52 PM, Arnd Bergmann wrote: On Wed, Feb 13, 2019 at 10:56 AM Benjamin Gaignard wrote: Implement ARM errata 814220 for Cortex A7. This patch has been wroten by Jason Liu years ago but never send upstream. I have tried to contact the author on multiple email addresses but I have

[PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read

2019-02-15 Thread Paul Kocialkowski
Some PHY drivers like the generic one do not provide a read_status callback on their own but rely on genphy_read_status being called directly. With the current code, this results in a NULL function pointer call. Call genphy_read_status instead when there is no specific callback. Fixes: f411a6160b

Re: [PATCH 0/7] Eliminate delegation self-conflicts

2019-02-15 Thread J. Bruce Fields
On Mon, Feb 11, 2019 at 10:58:04AM -0500, J. Bruce Fields wrote: > On Sat, Feb 09, 2019 at 07:43:54AM -0500, Jeff Layton wrote: > > On Fri, 2019-02-08 at 15:10 -0500, J. Bruce Fields wrote: > > > From: "J. Bruce Fields" > > > > > > These patches allow NFSv4 clients holding delegations to keep the

[PATCH] VMCI: Support upto 64-bit PPNs

2019-02-15 Thread Vishnu DASA
Add support in the VMCI driver to handle upto 64-bit PPNs when the VMCI device exposes the capability for 64-bit PPNs. Reviewed-by: Adit Ranadive Reviewed-by: Jorgen Hansen Signed-off-by: Vishnu Dasa --- drivers/misc/vmw_vmci/vmci_doorbell.c | 9 ++-- drivers/misc/vmw_vmci/vmci_doorbell.h

[PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-15 Thread Paul Kocialkowski
According to the chipidea driver bindings, the USB PHY is specified via the "phys" phandle node. However, this only takes effect for USB PHYs that use the common PHY framework. For legacy USB PHYs, a simple lookup based on the USB PHY type is done instead. This does not play out well when more tha

Re: [PATCH] i2c: mediatek: modify threshold passed to i2c_get_dma_safe_msg_buf()

2019-02-15 Thread Wolfram Sang
>> > Ok, I can add a check in another patch. Should we return NULL pointer >> > if msg->len is 0 or print out some warnings? Thanks. >> >> No warning, msg->len == 0 is a valid setting. But interesting question: >> I was about to say NULL, but your driver would assume ENOMEM there and >> discard t

Re: WARNING: locking bug in __queue_work

2019-02-15 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:cb5b020a8d38 Revert "exec: load_script: don't blindly trun.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12b68c8f40 kernel config: https://syzkaller.appspot.com/x/.config?x=ee4345

[LSF/MM TOPIC] Improve performance of fget/fput

2019-02-15 Thread Dave Watson
In some of our hottest network services, fget_light + fput overhead can represent 1-2% of the processes' total CPU usage. I'd like to discuss ways to reduce this overhead. One proposal we have been testing is removing the refcount increment and decrement, and using some sort of safe memory reclam

Re: [PATCH v3] exec: load_script: Do not exec truncated interpreter path

2019-02-15 Thread Linus Torvalds
On Fri, Feb 15, 2019 at 8:18 AM Oleg Nesterov wrote: > > Not sure. Consider a script file which has a single line > > #!/path/to/interpreter > > WITHOUT '\n' at the end. Heh. I'm not sure how valid that is, but it's an interesting case for sure. But it's actually fairly easy to fix with

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-15 Thread Hans Verkuil
On 2/15/19 5:27 PM, Nicolas Dufresne wrote: > Le vendredi 15 février 2019 à 14:44 +0100, Hans Verkuil a écrit : >> Hi Stanimir, >> >> I never paid much attention to this patch series since others were busy >> discussing it and I had a lot of other things on my plate, but then I heard >> that this p

Re: [PATCH] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.

2019-02-15 Thread Konrad Rzeszutek Wilk
On Wed, Feb 13, 2019 at 06:21:31PM -0500, Prarit Bhargava wrote: > From: Konrad Rzeszutek Wilk > +LKML > This was submitted in 2015 here > > https://marc.info/?l=linux-kernel&m=142807132515973&w=2 > > and has been included in Fedora builds ever since. No issues have been > reported with the p

Re: [GIT PULL] ARM: samsung: mach/soc for v5.1

2019-02-15 Thread Arnd Bergmann
On Mon, Feb 11, 2019 at 8:54 PM Krzysztof Kozlowski wrote: > Samsung mach/soc changes for v5.1 > > Two fixes: one for handling timeout while booting secondary CPU of > Exynos and second for S3C24xx DVS notifier. Pulled into arm/soc, thanks! Arnd

Re: [PATCH] perf tests shell: Skip trace+probe_vfs_getname.sh if built without trace support

2019-02-15 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 15, 2019 at 03:42:46PM +0200, Tommi Rantala escreveu: > From: Tommi Rantala > > If perf was built without trace support, trace+probe_vfs_getname.sh > fails: > > # perf trace -h > perf: 'trace' is not a perf-command. See 'perf --help' > > # perf test 64 > 64: Check open filen

Re: [PATCH 2/2] driver core: Fix possible supplier PM-usage counter imbalance

2019-02-15 Thread Jon Hunter
On 15/02/2019 14:37, Ulf Hansson wrote: > On Fri, 15 Feb 2019 at 12:00, Jon Hunter wrote: >> >> Hi Rafael, >> >> On 12/02/2019 12:08, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> If a stateless device link to a certain supplier with >>> DL_FLAG_PM_RUNTIME set in the flags is add

Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()

2019-02-15 Thread Stephen Hemminger
On Fri, 15 Feb 2019 15:53:24 +0800 Jason Wang wrote: > When fail, translate_desc() returns negative value, otherwise the > number of iovs. So we should fail when the return value is negative > instead of a blindly check against zero. > > Reported-by: Stephen Hemminger > Fixes: cc5e71075947 ("vh

Re: [PATCH v2] nfit/ars: Allow root to busy-poll the ARS state machine

2019-02-15 Thread Dan Williams
On Thu, Feb 14, 2019 at 12:32 PM Dan Williams wrote: > > The ARS implementation implements exponential back-off on the poll > interval to prevent high-frequency access to the DIMM / platform > interface. Depending on when the ARS completes the poll interval may > exceed the completion event by min

Re: WARNING: refcount bug in kvm_vm_ioctl

2019-02-15 Thread Dmitry Vyukov
On Fri, Feb 15, 2019 at 5:03 PM Jann Horn wrote: > > On Fri, Feb 15, 2019 at 4:40 PM Dmitry Vyukov wrote: > > On Thu, Oct 11, 2018 at 4:18 PM Paolo Bonzini wrote: > > > On 10/10/2018 09:58, syzbot wrote: > > > > do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:316 > > > > invalid_op+0x14/0x20 a

Re: [PATCH] kvm: vmx: Fix entry nubmer check for add_atomic_switch_msr()

2019-02-15 Thread Konrad Rzeszutek Wilk
On Thu, Feb 14, 2019 at 12:08:58PM +0800, Xiaoyao Li wrote: > Commit ca83b4a7f2d068da79a0 ("x86/KVM/VMX: Add find_msr() helper function") > introduces the helper function find_msr(), which returns -ENOENT when > not find the msr in vmx->msr_autoload.guest/host. Correct checking contion s/not find/

[PATCH] drm/amdgpu/si_dpm: Mark expected switch fall-throughs

2019-02-15 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/amd

Re: linux-next: Tree for Feb 15 (net/core/lwt_bpf.c)

2019-02-15 Thread Randy Dunlap
On 2/14/19 10:03 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190214: > on x86_64: ld: net/core/lwt_bpf.o: in function `bpf_lwt_xmit_reroute': lwt_bpf.c:(.text+0x11e): undefined reference to `ip_route_output_flow' ld: net/core/lwt_bpf.o: in function `bpf_input': lwt_bpf.c:(.text+0x

Re: [PATCH v3] hugetlb: allow to free gigantic pages regardless of the configuration

2019-02-15 Thread Vlastimil Babka
On 2/14/19 8:31 PM, Alexandre Ghiti wrote: > On systems without CMA or (MEMORY_ISOLATION && COMPACTION) activated but > that support gigantic pages, boottime reserved gigantic pages can not be > freed at all. This patch simply enables the possibility to hand back > those pages to memory allocator.

[PATCH] drm/amd/display/dc/bios_parser2: Mark expected switch fall-throughs

2019-02-15 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/amd

[PATCH v3] x86/ima: require signed kernel modules

2019-02-15 Thread Mimi Zohar
Have the IMA architecture specific policy require signed kernel modules on systems with secure boot mode enabled; and coordinate the different signature verification methods, so only one signature is required. Requiring appended kernel module signatures may be configured, enabled on the boot comma

[PATCH] drm/amd/display/dce_mem_input: Mark expected switch fall-through

2019-02-15 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 3 was used: -Wimplicit-fallthrough=3 Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find. This patch is part

Re: [PATCH 0/4] keys: Miscellaneous fixes

2019-02-15 Thread David Howells
James Morris wrote: > For which kernel, -rc or 5.1? -rc, preferably, but I don't think any of them are particularly urgent, so if you'd rather wait... David

[GIT PULL 0/1] EFI updates for v5.1

2019-02-15 Thread Ard Biesheuvel
The following changes since commit 69c1f396f25b805aeff08f06d2e992c315ee5b1e: efi/x86: Convert x86 EFI earlyprintk into generic earlycon implementation (2019-02-04 08:27:30 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git tags/efi-next

[PATCH 1/1] efi: fix build error redeclaration of enumerator

2019-02-15 Thread Ard Biesheuvel
From: Anders Roxell Commit a893ea15d764 ("tpm: move tpm_chip definition to include/linux/tpm.h") introduced a build error when both ima and efi is enabled. What happens is that both headers (ima.h and efi.h) defines the same 'NONE' constant, and it broke when they started getting included from th

[PATCH] drm/amd/powerplay/smu7_hwmgr: Mark expected switch fall-throughs

2019-02-15 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/amd

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

2019-02-15 Thread Meelis Roos
I have noticed ext4 filesystem corruption on two of my test alphas with 4.20.0-09062-gd8372ba8ce28. Retried it, still happens with 5.0.0-rc5-00358-gdf3865f8f568 - rsync of emerge --sync just fail with nothing in dmesg. Finished second round of bisecting, first round did not get me far enough

Re: [GIT PULL] tee subsys for v5.1

2019-02-15 Thread Arnd Bergmann
On Mon, Feb 4, 2019 at 9:56 AM Jens Wiklander wrote: > > Hello arm-soc maintainers, > > Please pull this TEE subsystem enhancement. A tee bus driver framework > is introduced in order to support an OP-TEE based RNG driver. > > The last commit makes changes under drivers/char/hw_random which > also

Re: [PATCH 2/9] clk: Introduce get_parent_hw clk op

2019-02-15 Thread Stephen Boyd
Quoting Jerome Brunet (2019-02-13 01:16:18) > On Tue, 2019-02-05 at 16:01 -0800, Stephen Boyd wrote: > > > > > > I really don't understand why you insist on keeping this special case for > > > num_parent == 1, when we know it is not coherent. > > > > > > Considering, that I already proposed the f

Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read

2019-02-15 Thread Andrew Lunn
On Fri, Feb 15, 2019 at 05:32:20PM +0100, Paul Kocialkowski wrote: > Some PHY drivers like the generic one do not provide a read_status > callback on their own but rely on genphy_read_status being called > directly. > > With the current code, this results in a NULL function pointer call. > Call ge

Re: [PATCH v3] exec: load_script: Do not exec truncated interpreter path

2019-02-15 Thread Kees Cook
On Fri, Feb 15, 2019 at 8:39 AM Linus Torvalds wrote: > > On Fri, Feb 15, 2019 at 8:18 AM Oleg Nesterov wrote: > > > > Not sure. Consider a script file which has a single line > > > > #!/path/to/interpreter > > > > WITHOUT '\n' at the end. > > Heh. I'm not sure how valid that is, but it's

Re: [GIT PULL] soc: ti: couple of non critical fixes for v5.1

2019-02-15 Thread Arnd Bergmann
On Fri, Feb 1, 2019 at 7:04 PM Santosh Shilimkar wrote: > soc: ti: couple of non critical fixes for v5.1 > > - Fix the Clang warning for enum in Navigator dma > - Simplify code in ti_sci with DEFINE_SHOW_ATTRIBUTE macro Pulled into arm/drivers, thanks! Arnd

Re: [PATCH v3] x86/ima: require signed kernel modules

2019-02-15 Thread Luis Chamberlain
On Fri, Feb 15, 2019 at 11:50:18AM -0500, Mimi Zohar wrote: > Have the IMA architecture specific policy require signed kernel modules > on systems with secure boot mode enabled; and coordinate the different > signature verification methods, so only one signature is required. > > Requiring appended

Re: [PATCH] net: phy: xgmiitorgmii: Support generic PHY status read

2019-02-15 Thread Andrew Lunn
> > How about using phy_read_status()? > > Thanks fo rthe suggestion! Though I don't that would work here since > our priv->phy_drv != phydev->drv, so it looks like we need to be > breaking it down in the driver. Ahm, yes. I forgot how this driver works. Andrew

WARNING: locking bug in flush_workqueue_prep_pwqs

2019-02-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:cb5b020a8d38 Revert "exec: load_script: don't blindly trun.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1016c0f340 kernel config: https://syzkaller.appspot.com/x/.config?x=ee434566c893c7b1 da

Re: [PATCH v2 perf,bpf 01/11] perf, bpf: consider events with attr.bpf_event as side-band events

2019-02-15 Thread Song Liu
> On Feb 15, 2019, at 6:14 AM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Feb 14, 2019 at 03:58:40PM -0800, Song Liu escreveu: >> Events with bpf_event should be considered as side-band event, as they >> carry information about BPF programs. >> >> Fixes: 6ee52e2a3fe4 ("perf, bpf: Introduce P

[PATCH 00/13] Convert x86 & arm64 to use generic page walk

2019-02-15 Thread Steven Price
Most architectures current have a debugfs file for dumping the kernel page tables. Currently each architecture has to implement custom functions for walking the page tables because the generic walk_page_range() function is unable to walk the page tables used by the kernel. This series extends the

[PATCH 01/13] arm64: mm: Add p?d_large() definitions

2019-02-15 Thread Steven Price
From: James Morse Exposing the pud/pgd levels of the page tables to walk_page_range() means we may come across the exotic large mappings that come with large areas of contiguous memory (such as the kernel's linear map). Expose p?d_large() from each architecture to detect these large mappings. a

[PATCH 06/13] mm: pagewalk: Add 'depth' parameter to pte_hole

2019-02-15 Thread Steven Price
The pte_hole() callback is called at multiple levels of the page tables. Code dumping the kernel page tables needs to know what at what depth the missing entry is. Add this is an extra parameter to pte_hole(). When the depth isn't know (e.g. processing a vma) then -1 is passed. Note that depth sta

[PATCH 02/13] x86/mm: Add p?d_large() definitions

2019-02-15 Thread Steven Price
Exposing the pud/pgd levels of the page tables to walk_page_range() means we may come across the exotic large mappings that come with large areas of contiguous memory (such as the kernel's linear map). Expose p?d_large() from each architecture to detect these large mappings. x86 already has these

[PATCH 04/13] mm: pagewalk: Add p4d_entry() and pgd_entry()

2019-02-15 Thread Steven Price
pgd_entry() and pud_entry() were removed by commit 0b1fbfe50006c410 ("mm/pagewalk: remove pgd_entry() and pud_entry()") because there were no users. We're about to add users so reintroduce them, along with p4d_entry() as we now have 5 levels of tables. Note that commit a00cc7d9dd93d66a ("mm, x86:

[PATCH 08/13] arm64: mm: Convert mm/dump.c to use walk_page_range()

2019-02-15 Thread Steven Price
Now walk_page_range() can walk kernel page tables, we can switch the arm64 ptdump code over to using it, simplifying the code. Signed-off-by: Steven Price --- arch/arm64/mm/dump.c | 108 +-- 1 file changed, 53 insertions(+), 55 deletions(-) diff --git a/a

[PATCH 09/13] x86/mm: Point to struct seq_file from struct pg_state

2019-02-15 Thread Steven Price
mm/dump_pagetables.c passes both struct seq_file and struct pg_state down the chain of walk_*_level() functions to be passed to note_page(). Instead place the struct seq_file in struct pg_state and access it from struct pg_state (which is private to this file) in note_page(). Signed-off-by: Steven

[PATCH 07/13] mm: pagewalk: Add test_p?d callbacks

2019-02-15 Thread Steven Price
It is useful to be able to skip parts of the page table tree even when walking without VMAs. Add test_p?d callbacks similar to test_walk but which are called just before a table at that level is walked. If the callback returns non-zero then the entire table is skipped. Signed-off-by: Steven Price

[PATCH 03/13] mm: Add generic p?d_large() macros

2019-02-15 Thread Steven Price
From: James Morse Exposing the pud/pgd levels of the page tables to walk_page_range() means we may come across the exotic large mappings that come with large areas of contiguous memory (such as the kernel's linear map). For architectures that don't provide p?d_large() macros, provided a does not

[PATCH 12/13] x86/mm: Convert ptdump_walk_pgd_level_core() to take an mm_struct

2019-02-15 Thread Steven Price
An mm_struct is needed to enable x86 to use of the generic walk_page_range() function. In the case of walking the user page tables (when CONFIG_PAGE_TABLE_ISOLATION is enabled), it is necessary to create a fake_mm structure because there isn't an mm_struct with a pointer to the pgd of the user pag

Re: [PATCH v2 perf,bpf 05/11] perf, bpf: save bpf_prog_info in a rbtree in perf_env

2019-02-15 Thread Song Liu
> On Feb 15, 2019, at 6:21 AM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Feb 14, 2019 at 04:00:06PM -0800, Song Liu escreveu: >> bpf_prog_info contains information necessary to annotate bpf programs. >> This patch saves bpf_prog_info for bpf programs loaded in the system. >> >> Signed-off-b

[PATCH 11/13] x86/mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct

2019-02-15 Thread Steven Price
To enable x86 to use the generic walk_page_range() function, the callers of ptdump_walk_pgd_level_debugfs() need to pass in the mm_struct. This means that ptdump_walk_pgd_level_core() is now always passed a valid pgd, so drop the support for pgd==NULL. Signed-off-by: Steven Price --- arch/x86/i

[PATCH 13/13] x86: mm: Convert dump_pagetables to use walk_page_range

2019-02-15 Thread Steven Price
Make use of the new functionality in walk_page_range to remove the arch page walking code and use the generic code to walk the page tables. The effective permissions are passed down the chain using new fields in struct pg_state. The KASAN optimisation is implemented by including test_p?d callback

[PATCH 10/13] x86/mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct

2019-02-15 Thread Steven Price
To enable x86 to use the generic walk_page_range() function, the callers of ptdump_walk_pgd_level() need to pass an mm_struct rather than the raw pgd_t pointer. Luckily since commit 7e904a91bf60 ("efi: Use efi_mm in x86 as well as ARM") we now have an mm_struct for EFI on x86. Signed-off-by: Steve

[PATCH 05/13] mm: pagewalk: Allow walking without vma

2019-02-15 Thread Steven Price
Since 48684a65b4e3: "mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)", page_table_walk() will report any kernel area as a hole, because it lacks a vma. This means each arch has re-implemented page table walking when needed, for example in the per-arch ptdump walker. Remove the

[PATCH] drm/drm_vm: Mark expected switch fall-throughs

2019-02-15 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 3 was used: -Wimplicit-fallthrough=3 Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find. This patch is part

Re: [PATCH v2 perf,bpf 09/11] perf-top: add option --bpf-event

2019-02-15 Thread Song Liu
> On Feb 15, 2019, at 6:27 AM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Feb 14, 2019 at 04:00:10PM -0800, Song Liu escreveu: >> bpf events are only tracked when opts->bpf_event is enabled. This patch >> adds command line flag to enable this for perf-top. > > Shouldn't this start as enabled

Re: [PATCH net-next 01/13] net: mvpp2: do not call phylink_mac_change if there is no event

2019-02-15 Thread Russell King - ARM Linux admin
On Fri, Feb 15, 2019 at 04:32:29PM +0100, Antoine Tenart wrote: > This patch makes the link interrupt handler to avoid calling > phylink_mac_change when there are no event. The reasoning being? > > Signed-off-by: Antoine Tenart > --- > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 6 +++---

[PATCH] drm/radeon/ci_dpm: Mark expected switch fall-throughs

2019-02-15 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/rad

Re: [PATCH 0/2] [GIT PULL] tracing: Two more fixes

2019-02-15 Thread Linus Torvalds
On Fri, Feb 15, 2019 at 6:21 AM Steven Rostedt wrote: > > - Have kprobes not use copy_from_user to access kernel addresses >as this is now considered a security issue. No, you people are confused. The problem isn't that it's using a user access function on kernel memory. The problem is tha

Re: [git pull] drm fixes for 5.0-rc7

2019-02-15 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Feb 2019 13:17:43 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2019-02-15-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/545aabcbdcec6c88faa3dfde506ad1931d119f52 Thank you! -- Deet-doot-dot, I am a bot. https:/

Re: [PATCH v3] exec: load_script: Do not exec truncated interpreter path

2019-02-15 Thread Oleg Nesterov
On 02/15, Linus Torvalds wrote: > > +static inline bool tabspc(char c) { return c == ' ' || c == '\t'; } > +static inline bool no_tab_or_space(const char *first, const char *last) > +{ > + // Skip leading space > + for (;tabspc(*first) ; first++) > + if (!*first || first == last

Re: [GIT PULL] MMC fixes for v5.0-rc7

2019-02-15 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Feb 2019 10:49:01 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git tags/mmc-v5.0-rc5 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/dfeae3379836fd0609488e73f4df260af4af2672 Thank you! -- Deet-doot-dot, I am a b

Re: [GIT PULL] signal fixes for v5.0-rc7

2019-02-15 Thread pr-tracker-bot
The pull request you sent on Thu, 14 Feb 2019 14:56:25 -0600: > git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git > for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/02d75040897f37e43cc6df9a7084ecdd20526f1a Thank you! -- Deet-doot-dot

Re: [GIT] Networking

2019-02-15 Thread pr-tracker-bot
The pull request you sent on Thu, 14 Feb 2019 18:00:59 -0800 (PST): > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6e7bd3b5494620265d39463b9289b7ba872f6df1 Thank you! -- Deet-doot-dot, I am

Re: [GIT] Crypto Fixes for 5.0

2019-02-15 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Feb 2019 10:47:39 +0800: > git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2aba322074de0d6781f4ae6b44d3e792b9bd2243 Thank you! -- Deet-doot-dot, I am a bot

Re: linux-next: Tree for Feb 15 (net/core/lwt_bpf.c)

2019-02-15 Thread Peter Oskolkov
On Fri, Feb 15, 2019 at 8:48 AM Randy Dunlap wrote: > > On 2/14/19 10:03 PM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20190214: > > > > on x86_64: > > ld: net/core/lwt_bpf.o: in function `bpf_lwt_xmit_reroute': > lwt_bpf.c:(.text+0x11e): undefined reference to `ip_route_output_flo

Re: WARNING: refcount bug in kvm_vm_ioctl

2019-02-15 Thread Jann Horn
On Fri, Feb 15, 2019 at 5:45 PM Dmitry Vyukov wrote: > > On Fri, Feb 15, 2019 at 5:03 PM Jann Horn wrote: > > > > On Fri, Feb 15, 2019 at 4:40 PM Dmitry Vyukov wrote: > > > On Thu, Oct 11, 2018 at 4:18 PM Paolo Bonzini wrote: > > > > On 10/10/2018 09:58, syzbot wrote: > > > > > do_invalid_op+0

Re: WARNING: refcount bug in kvm_vm_ioctl

2019-02-15 Thread Dmitry Vyukov
On Fri, Feb 15, 2019 at 6:10 PM Jann Horn wrote: > > On Fri, Feb 15, 2019 at 5:45 PM Dmitry Vyukov wrote: > > > > On Fri, Feb 15, 2019 at 5:03 PM Jann Horn wrote: > > > > > > On Fri, Feb 15, 2019 at 4:40 PM Dmitry Vyukov wrote: > > > > On Thu, Oct 11, 2018 at 4:18 PM Paolo Bonzini > > > > wro

Re: [PATCH v2 perf,bpf 11/11] perf, bpf: save information about short living bpf programs

2019-02-15 Thread Song Liu
> On Feb 15, 2019, at 6:41 AM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Feb 14, 2019 at 04:00:45PM -0800, Song Liu escreveu: >> To annotate bpf programs in perf, it is necessary to save information in >> bpf_prog_info and btf. For short living bpf program, it is necessary to >> save these i

Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-15 Thread Russell King - ARM Linux admin
On Fri, Feb 15, 2019 at 04:32:38PM +0100, Antoine Tenart wrote: > The documentation advises to set the XPCS in reset while reconfiguring > the serdes lanes. This seems to be a good thing to do, but the PPv2 > driver wasn't doing it. This patch fixes it. Hmm. That statment seems to have some ambig

Re: [PATCH v3] exec: load_script: Do not exec truncated interpreter path

2019-02-15 Thread Linus Torvalds
On Fri, Feb 15, 2019 at 9:01 AM Kees Cook wrote: > > The !*first will never hit here (since it's been checked to be either > ' ' or '\t', and if first == last it's whitespace all the way, so we > could just return true here to bail out early (there's no interpreter > at all, so we want to -ENOEXEC

Re: [dm-devel] [PATCH V15 00/18] block: support multi-page bvec

2019-02-15 Thread Bart Van Assche
On Fri, 2019-02-15 at 08:49 -0700, Jens Axboe wrote: > On 2/15/19 4:13 AM, Ming Lei wrote: > > This patchset brings multi-page bvec into block layer: > > Applied, thanks Ming. Let's hope it sticks! Hi Jens and Ming, Test nvmeof-mp/002 fails with Jens' for-next branch from this morning. I have no

[PATCH] drm/radeon/si_dpm: Mark expected switch fall-throughs

2019-02-15 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/rad

Re: [LSF/MM TOPIC] Improve performance of fget/fput

2019-02-15 Thread Matthew Wilcox
On Fri, Feb 15, 2019 at 04:38:05PM +, Dave Watson wrote: > There might also be ways to rearrange the file* struct or fd table so > that we're not taking so many cache misses for sockfd_lookup_light, > since for sockets we don't use most of the file* struct at all. I don't think there's too muc

Re: [PATCH 13/13] x86: mm: Convert dump_pagetables to use walk_page_range

2019-02-15 Thread Dave Hansen
On 2/15/19 9:02 AM, Steven Price wrote: > arch/x86/mm/dump_pagetables.c | 281 ++ > 1 file changed, 146 insertions(+), 135 deletions(-) I'll look through this in more detail in a bit. But, I'm a bit bummed out by the diffstat. When I see patches add a bunch of in

Re: [PATCH] sched/x86: Save [ER]FLAGS on context switch

2019-02-15 Thread Linus Torvalds
On Thu, Feb 14, 2019 at 11:34 AM Peter Zijlstra wrote: > > Something like the below, right? > > + frame->flags = 0; > + frame->flags = 0; Those are not valid flag values. Can you popf them? Yes. Do they make sense? No. It has the IF flag clear, for example. Is that intentional? If

Re: [PATCH 4.20 00/50] 4.20.9-stable review

2019-02-15 Thread Guenter Roeck
On Fri, Feb 15, 2019 at 07:56:22AM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 14, 2019 at 01:02:26PM -0800, Guenter Roeck wrote: > > On Wed, Feb 13, 2019 at 07:38:05PM +0100, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 4.20.9 release. > > > There are 50

Re: [PATCH V4 7/9] x86/alternative: Batch of patch operations

2019-02-15 Thread Steven Rostedt
On Fri, 15 Feb 2019 17:00:49 +0100 Daniel Bristot de Oliveira wrote: > On 2/14/19 3:40 PM, Steven Rostedt wrote: > > On Thu, 14 Feb 2019 15:30:30 +0100 > > Borislav Petkov wrote: > > > >>> void *trampoline; > >> > >> Well, it ain't a trampoline either. It is a "temporary location to go

Re: WARNING: refcount bug in kvm_vm_ioctl

2019-02-15 Thread Jann Horn
On Fri, Feb 15, 2019 at 6:13 PM Dmitry Vyukov wrote: > On Fri, Feb 15, 2019 at 6:10 PM Jann Horn wrote: > > On Fri, Feb 15, 2019 at 5:45 PM Dmitry Vyukov wrote: > > > On Fri, Feb 15, 2019 at 5:03 PM Jann Horn wrote: > > > > On Fri, Feb 15, 2019 at 4:40 PM Dmitry Vyukov > > > > wrote: > > > >

Re: [RFC PATCH v2 0/4] dynamic indirect call promotion

2019-02-15 Thread Edward Cree
On 05/02/19 08:50, Nadav Amit wrote: >> In cases where RCU cannot be used (e.g. because some callees need to RCU >> synchronise), it might be possible to add a variant that uses >> synchronize_rcu_tasks() when updating, but this series does not attempt this. > I wonder why. Mainly because I have ye

Re: [PATCH 0/2] [GIT PULL] tracing: Two more fixes

2019-02-15 Thread Steven Rostedt
On Fri, 15 Feb 2019 09:08:38 -0800 Linus Torvalds wrote: > On Fri, Feb 15, 2019 at 6:21 AM Steven Rostedt wrote: > > > > - Have kprobes not use copy_from_user to access kernel addresses > >as this is now considered a security issue. > > No, you people are confused. > > The problem isn't

RE: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-15 Thread Stefan Chulski
> On Fri, Feb 15, 2019 at 04:32:38PM +0100, Antoine Tenart wrote: > > The documentation advises to set the XPCS in reset while reconfiguring > > the serdes lanes. This seems to be a good thing to do, but the PPv2 > > driver wasn't doing it. This patch fixes it. > > Hmm. That statment seems to h

Re: [PATCH v2 perf,bpf 08/11] perf, bpf: save btf information as headers to perf.data

2019-02-15 Thread Song Liu
> On Feb 15, 2019, at 6:26 AM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Feb 14, 2019 at 04:00:09PM -0800, Song Liu escreveu: >> This patch enables perf-record to save btf information as headers to >> perf.data A new header type HEADER_BTF is introduced for this data. > > Jiri, > > W

[PATCH] drm/amdgpu/powerplay/polaris10_smumgr: Mark expected switch fall-through

2019-02-15 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/amd

Re: [PATCH] drm/nouveau/bo: mark expected switch fall-through

2019-02-15 Thread Gustavo A. R. Silva
Hi all, Alex Deucher requested me to send separate patches for each driver, which makes this patch available to be taken, again. Thanks -- Gustavo On 2/15/19 10:02 AM, Gustavo A. R. Silva wrote: > Hi, > > Please drop this, as I have included this fix into > the following patch, which addresses

Re: [PATCH 13/13] x86: mm: Convert dump_pagetables to use walk_page_range

2019-02-15 Thread Steven Price
On 15/02/2019 17:16, Dave Hansen wrote: > On 2/15/19 9:02 AM, Steven Price wrote: >> arch/x86/mm/dump_pagetables.c | 281 ++ >> 1 file changed, 146 insertions(+), 135 deletions(-) > > I'll look through this in more detail in a bit. But, I'm a bit bummed > out by t

Re: [RFC PATCH 1/5] iommu: Add APIs for IOMMU PASID management

2019-02-15 Thread Jean-Philippe Brucker
Hi Jacob, Lu, On 30/01/2019 19:05, Jacob Pan wrote: > On Mon, 12 Nov 2018 14:44:57 +0800 > Lu Baolu wrote: > >> This adds APIs for IOMMU drivers and device drivers to manage >> the PASIDs used for DMA transfer and translation. It bases on >> I/O ASID allocator for PASID namespace management and

<    1   2   3   4   5   6   7   8   9   10   >