Re: [PATCH] Bluetooth: hci_bcm: Fix empty regulator supplies for Intel Macs

2019-04-23 Thread Marcel Holtmann
Hi Chen-Yu, > The code path for Macs goes through bcm_apple_get_resources(), which > skips over the code that sets up the regulator supplies. As a result, > the call to regulator_bulk_enable() / regulator_bulk_disable() results > in a NULL pointer dereference. > > This was reported on the

Re: [PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices

2019-04-23 Thread Marcel Holtmann
Hi Matthias, > qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that > the HCI is always associated with a serdev device. This isn't true for > ROME controllers instantiated through ldisc, where the call causes a > crash due to a NULL pointer dereferentiation. Only call the

Re: [PATCH] x86/mm/tlb: Remove flush_tlb_info from the stack

2019-04-23 Thread Andy Lutomirski
On Tue, Apr 23, 2019 at 9:56 AM Nadav Amit wrote: > > > On Apr 23, 2019, at 9:50 AM, Andy Lutomirski wrote: > > > > On Tue, Apr 23, 2019 at 12:12 AM Nadav Amit wrote: >https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/log/?h=x86/fixes > >> Remove flush_tlb_info variables from the

Re: [PATCH] x86_64: uninline TASK_SIZE

2019-04-23 Thread Andy Lutomirski
On Tue, Apr 23, 2019 at 4:13 AM Ingo Molnar wrote: > > > * Andy Lutomirski wrote: > > > > Saving 2KB on a defconfig is quite a lot. > > > > Saving 2kB of text by adding 8 bytes to thread_info seems rather > > dubious to me. You only need 256 tasks before you lose. My > >

Re: [PATCH] The patch solves the type error of the parameter “off” in syscall mmap on the ARM64 platform.

2019-04-23 Thread Mark Rutland
On Tue, Apr 23, 2019 at 06:04:45PM +0100, Will Deacon wrote: > On Thu, Apr 18, 2019 at 12:28:18PM +0100, Mark Rutland wrote: > > [adding linux-arch and relevant folk] > > > > On Wed, Apr 17, 2019 at 08:35:25PM +0800, Boyang Zhou wrote: > > > The error information is that “offset value too large

Re: [PATCH v3 2/5] nds32: Use the correct style for SPDX License Identifier

2019-04-23 Thread Souptick Joarder
On Tue, Apr 16, 2019 at 8:54 PM Nishad Kamdar wrote: > > This patch corrects the SPDX License Identifier style > in the nds32 Hardware Architecture related files. > > Suggested-by: Joe Perches > Signed-off-by: Nishad Kamdar > --- > arch/nds32/include/asm/assembler.h | 2 +- >

Re: [linux-sunxi] [PATCH] drm/sun4i: Unbind components before releasing DRM and mem at master unbind

2019-04-23 Thread Chen-Yu Tsai
On Tue, Apr 23, 2019 at 10:06 AM Paul Kocialkowski wrote: > > Hi, > > Le vendredi 19 avril 2019 à 19:10 +0200, Paul Kocialkowski a écrit : > > Hi, > > > > On Fri, 2019-04-19 at 09:02 -0700, Chen-Yu Tsai wrote: > > > On Fri, Apr 19, 2019 at 1:03 AM Paul Kocialkowski > > > wrote: > > > > Our

Re: [PATCH] PCI/LINK: Account for BW notification in vector calculation

2019-04-23 Thread Bjorn Helgaas
On Tue, Apr 23, 2019 at 09:33:53AM -0500, Alex G wrote: > On 4/22/19 7:33 PM, Alex Williamson wrote: > > There is nothing wrong happening here that needs to fill logs. I > > thought maybe if I enabled notification of autonomous bandwidth > > changes that it might categorize these as something we

Re: [PATCH] Bluetooth: btbcm: Add default address for BCM43341B

2019-04-23 Thread Marcel Holtmann
Hi Ferry, > The BCM43341B has the default MAC address 43:34:1B:00:1F:AC if none > is given. This address was found when enabling Bluetooth on multiple > Intel Edison modules. It also contains the sequence 43341B, the name > the chip identifies itself as. Using the same BD_ADDR is problematic >

Re: [PATCH] x86/mpx: fix recursive munmap() corruption

2019-04-23 Thread Laurent Dufour
Le 23/04/2019 à 18:04, Dave Hansen a écrit : On 4/23/19 4:16 AM, Laurent Dufour wrote: My only concern is the error path. Calling arch_unmap() before handling any error case means that it will have to be undo and there is no way to do so. Is there a practical scenario where munmap() of the

Re: [PATCH] The patch solves the type error of the parameter “off” in syscall mmap on the ARM64 platform.

2019-04-23 Thread Will Deacon
On Thu, Apr 18, 2019 at 12:28:18PM +0100, Mark Rutland wrote: > [adding linux-arch and relevant folk] > > On Wed, Apr 17, 2019 at 08:35:25PM +0800, Boyang Zhou wrote: > > The error information is that “offset value too large for defined data > > type”. > > Reason: > > On the X86 platform, the

Re: [PATCH 0/1] Bluetooth: btmrvl: add support for SD8987 chipset

2019-04-23 Thread Marcel Holtmann
Hi Tamas, > Changes here have been tested with u-blox JODY-W2XX and Marvell > TB-AQB8987-QFN-EPA-2A. It would be great to have driver support upstream. > Kindly review. > > Kind regards, > Tamas > > Tamás Szűcs (1): > Bluetooth: btmrvl: add support for SD8987 chipset > >

Re: [RFC PATCH v3] Bluetooth: hci_qca: Collect controller memory dump during SSR

2019-04-23 Thread Marcel Holtmann
Hi Balakrishna, > We will collect the ramdump of BT controller when hardware error event > received before rebooting the HCI layer. Before restarting a subsystem > or a process running on a subsystem, it is often required to request > either a subsystem or a process to perform proper cache dump

Re: [PATCH] x86/mm/tlb: Remove flush_tlb_info from the stack

2019-04-23 Thread Nadav Amit
> On Apr 23, 2019, at 9:50 AM, Andy Lutomirski wrote: > > On Tue, Apr 23, 2019 at 12:12 AM Nadav Amit wrote: >> Remove flush_tlb_info variables from the stack. This allows to align >> flush_tlb_info to cache-line and avoid potentially unnecessary cache >> line movements. It also allows to have

[PATCH] x86/mm: fix a crash with kmemleak_scan()

2019-04-23 Thread Qian Cai
The first kmemleak_scan() after boot would trigger a crash below because kernel_init free_initmem mem_encrypt_free_decrypted_mem free_init_pages unmapped some memory inside the .bss with DEBUG_PAGEALLOC=y. Since kmemleak_init() will register the .data/.bss sections (only register

[PATCH] apparmor: Force type-casting of current->real_cred

2019-04-23 Thread Bharath Vedartham
This patch fixes the sparse warning: warning: cast removes address space '' of expression. Signed-off-by: Bharath Vedartham --- security/apparmor/lsm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c index 87500bd..36478c4

Re: [PATCH v20 00/28] Intel SGX1 support

2019-04-23 Thread Andy Lutomirski
On Tue, Apr 23, 2019 at 4:56 AM Jarkko Sakkinen wrote: > > On Wed, Apr 17, 2019 at 01:39:10PM +0300, Jarkko Sakkinen wrote: > > Intel(R) SGX is a set of CPU instructions that can be used by applications > > to set aside private regions of code and data. The code outside the enclave > > is

Re: [PATCH] x86/mm/tlb: Remove flush_tlb_info from the stack

2019-04-23 Thread Andy Lutomirski
On Tue, Apr 23, 2019 at 12:12 AM Nadav Amit wrote: > > Remove flush_tlb_info variables from the stack. This allows to align > flush_tlb_info to cache-line and avoid potentially unnecessary cache > line movements. It also allows to have a fixed virtual-to-physical > translation of the variables,

Re: DISCONTIGMEM is deprecated

2019-04-23 Thread Meelis Roos
ia64 (looks complicated ...) Well as far as I can tell it was not even used 12 or so years ago on Itanium when I worked on that stuff. My notes tell that on UP ia64 (RX2620), !NUMA was broken with both SPARSEMEM and DISCONTIGMEM. NUMA+SPARSEMEM or !NUMA worked. Even NUMA+DISCONTIGMEM worked,

Re: [rcu:dev.2019.04.16a 38/72] kernel/rcu/tree.c:2408:36: sparse: sparse: incorrect type in initializer (different address spaces)

2019-04-23 Thread Sebastian Andrzej Siewior
On 2019-04-23 09:38:09 [-0700], Paul E. McKenney wrote: > Ah, thank you! Shall I fold the above patch into your existing one, > or are you looking to do something else here? The problem (that has been reported) isn't introduced by the patch in question but existed since the very beginning. I

[v2 PATCH] mm: thp: fix false negative of shmem vma's THP eligibility

2019-04-23 Thread Yang Shi
The commit 7635d9cbe832 ("mm, thp, proc: report THP eligibility for each vma") introduced THPeligible bit for processes' smaps. But, when checking the eligibility for shmem vma, __transparent_hugepage_enabled() is called to override the result from shmem_huge_enabled(). It may result in the

RE: [PATCH][v2] drivers: hid: Add a module description line to the hid_hyperv driver

2019-04-23 Thread Michael Kelley
From: Joseph Salisbury Sent: Monday, April 22, 2019 8:47 PM > > This patch only adds a MODULE_DESCRIPTION statement to the driver. > This change is only cosmetic, so there should be no runtime impact. > > > Signed-off-by: Joseph Salisbury > --- Reviewed-by: Michael Kelley

Re: [Question] Should direct reclaim time be bounded?

2019-04-23 Thread Mike Kravetz
On 4/23/19 12:19 AM, Michal Hocko wrote: > On Mon 22-04-19 21:07:28, Mike Kravetz wrote: >> In our distro kernel, I am thinking about making allocations try "less hard" >> on nodes where we start to see failures. less hard == NORETRY/NORECLAIM. >> I was going to try something like this on an

Re: [PATCH v4 00/63] Include linux ACPI/PCI/X86 docs into Sphinx TOC tree

2019-04-23 Thread Rafael J. Wysocki
On Tue, Apr 23, 2019 at 6:30 PM Changbin Du wrote: > > Hi Corbet and All, > The kernel now uses Sphinx to generate intelligent and beautiful documentation > from reStructuredText files. I converted all of the Linux ACPI/PCI/X86 docs to > reST format in this serias. > > In this version I combined

RE: [PATCH][v2] drivers: hv: Add a module description line to the hv_vmbus driver

2019-04-23 Thread Michael Kelley
From: Joseph Salisbury Sent: Monday, April 22, 2019 8:47 PM > > This patch only adds a MODULE_DESCRIPTION statement to the driver. > This change is only cosmetic, so there should be no runtime impact. > > Signed-off-by: Joseph Salisbury > Reviewed-by: Michael Kelley

RE: [PATCH][v2] drivers: input: serio: Add a module desription to the hyperv_keyboard driver

2019-04-23 Thread Michael Kelley
From: Joseph Salisbury Sent: Monday, April 22, 2019 8:47 PM > > This patch only adds a MODULE_DESCRIPTION statement to the driver. > This change is only cosmetic, so there should be no runtime impact. > > Signed-off-by: Joseph Salisbury > --- Reviewed-by: Michael Kelley

[PATCH v4 59/63] Documentation: x86: convert x86_64/mm.txt to reST

2019-04-23 Thread Changbin Du
This converts the plain text documentation to reStructuredText format and add it to Sphinx TOC tree. No essential content change. Signed-off-by: Changbin Du --- Documentation/x86/x86_64/index.rst | 1 + Documentation/x86/x86_64/mm.rst| 161 +

[PATCH v4 47/63] Documentation: x86: convert pat.txt to reST

2019-04-23 Thread Changbin Du
This converts the plain text documentation to reStructuredText format and add it to Sphinx TOC tree. No essential content change. Signed-off-by: Changbin Du --- Documentation/x86/index.rst | 1 + Documentation/x86/pat.rst | 235 Documentation/x86/pat.txt

Re: [rcu:dev.2019.04.16a 38/72] kernel/rcu/tree.c:2408:36: sparse: sparse: incorrect type in initializer (different address spaces)

2019-04-23 Thread Paul E. McKenney
On Tue, Apr 23, 2019 at 05:08:14PM +0200, Sebastian Andrzej Siewior wrote: > On 2019-04-23 05:46:19 [-0700], Paul E. McKenney wrote: > > On Tue, Apr 23, 2019 at 06:33:33PM +0800, kbuild test robot wrote: > > > tree: > > > https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git >

[PATCH v4 50/63] Documentation: x86: convert amd-memory-encryption.txt to reST

2019-04-23 Thread Changbin Du
This converts the plain text documentation to reStructuredText format and add it to Sphinx TOC tree. No essential content change. Signed-off-by: Changbin Du --- ...ory-encryption.txt => amd-memory-encryption.rst} | 13 ++--- Documentation/x86/index.rst | 1 + 2

[PATCH v4 51/63] Documentation: x86: convert pti.txt to reST

2019-04-23 Thread Changbin Du
This converts the plain text documentation to reStructuredText format and add it to Sphinx TOC tree. No essential content change. Signed-off-by: Changbin Du --- Documentation/x86/index.rst| 1 + Documentation/x86/{pti.txt => pti.rst} | 19 ++- 2 files changed, 15

Re: [PATCH] PCI/LINK: Account for BW notification in vector calculation

2019-04-23 Thread Alex Williamson
On Tue, 23 Apr 2019 11:27:39 -0500 Alex G wrote: > On 4/23/19 11:22 AM, Alex Williamson wrote: > > Nor should pci-core decide what link speed changes are intended or > > errors. Minimally we should be enabling drivers to receive this > > feedback. Thanks, > > Not errors. pci core reports

Re: [PATCH v1 0/4] Add a couple of enhancements to btmtksdio

2019-04-23 Thread Marcel Holtmann
Hi Sean, > First three are all minor changes and the final one adds a runtime pm support > to > enter a lower power state for decreasing power dissipation when there is idle > traffic in SDIO transport for a while. > > Sean Wang (4): > Bluetooth: btmtksdio: Drop newline with bt_dev logging

[PATCH v4 29/63] Documentation: PCI: convert MSI-HOWTO.txt to reST

2019-04-23 Thread Changbin Du
This converts the plain text documentation to reStructuredText format and add it to Sphinx TOC tree. No essential content change. Signed-off-by: Changbin Du Acked-by: Bjorn Helgaas --- v2: o drop numbering. o simplify author list --- .../PCI/{MSI-HOWTO.txt => MSI-HOWTO.rst} | 83

Re: [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts

2019-04-23 Thread Marcel Holtmann
Hi Balakrishna, > When flag HCI_QUIRK_USE_BDADDR_PROPERTY is set, we will read the > bluetooth address from dts. If the bluetooth address node is missing > from the dts we will enable it controller UNCONFIGURED state. > This patch enables the normal flow even if the BD address is missing > from

[PATCH v4 30/63] Documentation: PCI: convert acpi-info.txt to reST

2019-04-23 Thread Changbin Du
This converts the plain text documentation to reStructuredText format and add it to Sphinx TOC tree. No essential content change. Signed-off-by: Changbin Du Acked-by: Bjorn Helgaas --- Documentation/PCI/{acpi-info.txt => acpi-info.rst} | 11 --- Documentation/PCI/index.rst

[PATCH v4 31/63] Documentation: PCI: convert pci-error-recovery.txt to reST

2019-04-23 Thread Changbin Du
This converts the plain text documentation to reStructuredText format and add it to Sphinx TOC tree. No essential content change. Signed-off-by: Changbin Du Acked-by: Bjorn Helgaas --- Documentation/PCI/index.rst | 1 + ...or-recovery.txt => pci-error-recovery.rst} | 178

[PATCH] locking/percpu-rwsem: Add DEFINE_PERCPU_RWSEM(), use it to initialize cgroup_threadgroup_rwsem

2019-04-23 Thread Oleg Nesterov
Turn DEFINE_STATIC_PERCPU_RWSEM() into __DEFINE_PERCPU_RWSEM() with the additional "is_static" argument to introduce DEFINE_PERCPU_RWSEM(). Change cgroup.c to use DEFINE_PERCPU_RWSEM(cgroup_threadgroup_rwsem). Signed-off-by: Oleg Nesterov --- include/linux/percpu-rwsem.h | 8 ++--

Re: [PATCH] pci: aardvark: Wait for endpoint to be ready before training link

2019-04-23 Thread Lorenzo Pieralisi
On Wed, Mar 13, 2019 at 10:37:52PM +0100, Remi Pommarel wrote: > When configuring pcie reset pin from gpio (e.g. initially set by > u-boot) to pcie function this pin goes low for a brief moment > asserting the PERST# signal. Thus connected device enters fundamental > reset process and link

[PATCH v4 11/63] Documentation: ACPI: move dsdt-override.txt to admin-guide/acpi and convert to reST

2019-04-23 Thread Changbin Du
This converts the plain text documentation to reStructuredText format and add it to Sphinx TOC tree. No essential content change. Signed-off-by: Changbin Du --- .../acpi/dsdt-override.rst} | 8 +++- Documentation/admin-guide/acpi/index.rst | 1

two small nommu cleanups

2019-04-23 Thread Christoph Hellwig
Hi all, these two patches avoid writing some boilerplate code for the upcoming RISC-V nommu support, and might also help to clean up existing nommu support in other architectures down the road.

[PATCH 1/2] mm: provide a print_vma_addr stub for !CONFIG_MMU

2019-04-23 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/linux/mm.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index 6b10c21630f5..969185079ae4 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2676,7 +2676,13 @@ extern int

[PATCH v4 09/63] Documentation: ACPI: move method-customizing.txt to firmware-guide/acpi and convert to reST

2019-04-23 Thread Changbin Du
This converts the plain text documentation to reStructuredText format and add it to Sphinx TOC tree. No essential content change. Signed-off-by: Changbin Du --- Documentation/acpi/method-customizing.txt | 73 - Documentation/firmware-guide/acpi/index.rst | 3 +-

[PATCH 2/2] mm: stub out all of swapops.h for !CONFIG_MMU

2019-04-23 Thread Christoph Hellwig
The whole header file deals with swap entries and PTEs, none of which can exist for nommu builds. Signed-off-by: Christoph Hellwig --- include/linux/swapops.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/linux/swapops.h b/include/linux/swapops.h index

[PATCH v4 08/63] Documentation: ACPI: move gpio-properties.txt to firmware-guide/acpi and convert to reST

2019-04-23 Thread Changbin Du
This converts the plain text documentation to reStructuredText format and add it to Sphinx TOC tree. No essential content change. Signed-off-by: Changbin Du --- .../acpi/gpio-properties.rst} | 78 +++ Documentation/firmware-guide/acpi/index.rst | 1 +

Re: [PATCH] mm: thp: fix false negative of shmem vma's THP eligibility

2019-04-23 Thread Yang Shi
On 4/22/19 11:50 PM, Michal Hocko wrote: On Tue 23-04-19 06:24:53, Yang Shi wrote: The commit 7635d9cbe832 ("mm, thp, proc: report THP eligibility for each vma") introduced THPeligible bit for processes' smaps. But, when checking the eligibility for shmem vma,

[PATCH v4 05/63] Documentation: ACPI: move linuxized-acpica.txt to driver-api/acpi and convert to reST

2019-04-23 Thread Changbin Du
This converts the plain text documentation to reStructuredText format and add it to Sphinx TOC tree. No essential content change. Signed-off-by: Changbin Du --- Documentation/driver-api/acpi/index.rst | 1 + .../acpi/linuxized-acpica.rst}| 115 ++ 2 files

Re: [PATCH v4 14/16] locking/rwsem: Guard against making count negative

2019-04-23 Thread Linus Torvalds
On Tue, Apr 23, 2019 at 7:17 AM Peter Zijlstra wrote: > > I'm not aware of an architecture where disabling interrupts is faster > than disabling preemption. I don't thin kit ever is, but I'd worry a bit about the preempt_enable() just because it also checks if need_resched() is true when

Re: general protection fault in debugfs_remove

2019-04-23 Thread Dmitry Vyukov
On Tue, Apr 23, 2019 at 7:26 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:dc4060a5 Linux 5.1-rc5 > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=146c7ab720 > kernel config:

Re: [PATCH 2/2] Bluetooth: btusb: Disable LE Advertising on system suspend

2019-04-23 Thread Marcel Holtmann
Hi Kai-Heng, > System may freeze during suspend, and it's caused by btusb early wakeup: > > kernel: pci_pm_suspend(): hcd_pci_suspend+0x0/0x30 returns -16 > kernel: dpm_run_callback(): pci_pm_suspend+0x0/0x130 returns -16 > kernel: PM: Device :00:14.0 failed to suspend async: error -16 >

Re: general protection fault in fanotify_handle_event

2019-04-23 Thread Jan Kara
On Fri 19-04-19 12:33:02, Amir Goldstein wrote: > On Thu, Apr 18, 2019 at 8:14 PM syzbot > wrote: > > > > syzbot has bisected this bug to: > > > > commit 77115225acc67d9ac4b15f04dd138006b9cd1ef2 > > Author: Amir Goldstein > > Date: Thu Jan 10 17:04:37 2019 + > > > > fanotify: cache

Re: [PATCH] PCI/LINK: Account for BW notification in vector calculation

2019-04-23 Thread Alex G
On 4/23/19 11:22 AM, Alex Williamson wrote: Nor should pci-core decide what link speed changes are intended or errors. Minimally we should be enabling drivers to receive this feedback. Thanks, Not errors. pci core reports that a link speed change event has occured. Period. Alex

general protection fault in debugfs_remove

2019-04-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:dc4060a5 Linux 5.1-rc5 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=146c7ab720 kernel config: https://syzkaller.appspot.com/x/.config?x=856fc6d0fbbeede9 dashboard link:

KASAN: slab-out-of-bounds Read in fib6_rule_action

2019-04-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:73248801 Merge tag 'mlx5-fixes-2019-04-09' of git://git.ke.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=10cb89d320 kernel config: https://syzkaller.appspot.com/x/.config?x=4fb64439e07a1ec0

KASAN: slab-out-of-bounds Read in linear_transfer (2)

2019-04-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:bcb67f0f Add linux-next specific files for 20190412 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=134b986720 kernel config: https://syzkaller.appspot.com/x/.config?x=35c479ecf64ba753

KASAN: use-after-free Read in xfrm_sk_policy_lookup (2)

2019-04-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:f9221a7a Add linux-next specific files for 20190415 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=105982cb20 kernel config: https://syzkaller.appspot.com/x/.config?x=5593069f14799e67

Re: [PATCH] PCI/LINK: Account for BW notification in vector calculation

2019-04-23 Thread Alex Williamson
On Tue, 23 Apr 2019 11:03:04 -0500 Alex G wrote: > On 4/23/19 10:34 AM, Alex Williamson wrote: > > On Tue, 23 Apr 2019 09:33:53 -0500 > > Alex G wrote: > > > >> On 4/22/19 7:33 PM, Alex Williamson wrote: > >>> On Mon, 22 Apr 2019 19:05:57 -0500 > >>> Alex G wrote: > echo

Re: [PATCH] reiserfs: Add comment to explain endianness issue in xattr_hash

2019-04-23 Thread Bharath Vedartham
On Tue, Apr 23, 2019 at 09:48:31PM +0530, Bharath Vedartham wrote: > csum_partial() gives different results for little-endian and big-endian > hosts. This causes images created on little-endian hosts and mounted on > big endian hosts to see csum mismatches. This causes an endianness bug. > Sparse

[RFC PATCH v2 01/17] stop_machine: Fix stop_cpus_in_progress ordering

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) Make sure the entire for loop has stop_cpus_in_progress set. Signed-off-by: Peter Zijlstra (Intel) --- kernel/stop_machine.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c index 067cb83f37ea..583119e0c51c 100644

Re: mmotm 2019-04-19-14-53 uploaded (objtool)

2019-04-23 Thread Linus Torvalds
On Tue, Apr 23, 2019 at 1:25 AM Peter Zijlstra wrote: > > Now, we could of course allow this symbol, but I found only the below > was required to make allyesconfig build without issue. > > Andy, Linus? Ack on that patch. Except I think the uaccess.h part should be a separate commit: I think it

[RFC PATCH v2 04/17] sched/{rt,deadline}: Fix set_next_task vs pick_next_task

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) Because pick_next_task() implies set_curr_task() and some of the details haven't matter too much, some of what _should_ be in set_curr_task() ended up in pick_next_task, correct this. This prepares the way for a pick_next_task() variant that does not affect the

[RFC PATCH v2 08/17] sched: Rework pick_next_task() slow-path

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) Avoid the RETRY_TASK case in the pick_next_task() slow path. By doing the put_prev_task() early, we get the rt/deadline pull done, and by testing rq->nr_running we know if we need newidle_balance(). This then gives a stable state to pick a task from. Since the

[RFC PATCH v2 05/17] sched: Add task_struct pointer to sched_class::set_curr_task

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) In preparation of further separating pick_next_task() and set_curr_task() we have to pass the actual task into it, while there, rename the thing to better pair with put_prev_task(). Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/core.c | 12

[RFC PATCH v2 13/17] sched: Add core wide task selection and scheduling.

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) Instead of only selecting a local task, select a task for all SMT siblings for every reschedule on the core (irrespective which logical CPU does the reschedule). NOTE: there is still potential for siblings rivalry. NOTE: this is far too complicated; but thus far

[RFC PATCH v2 12/17] sched: A quick and dirty cgroup tagging interface

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) Marks all tasks in a cgroup as matching for core-scheduling. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/core.c | 62 kernel/sched/sched.h | 4 +++ 2 files changed, 66 insertions(+) diff --git

[RFC PATCH v2 09/17] sched: Introduce sched_class::pick_task()

2019-04-23 Thread Vineeth Remanan Pillai
From: "Peter Zijlstra (Intel)" Because sched_class::pick_next_task() also implies sched_class::set_next_task() (and possibly put_prev_task() and newidle_balance) it is not state invariant. This makes it unsuitable for remote task selection. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by:

[RFC PATCH v2 11/17] sched: Basic tracking of matching tasks

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) Introduce task_struct::core_cookie as an opaque identifier for core scheduling. When enabled; core scheduling will only allow matching task to be on the core; where idle matches everything. When task_struct::core_cookie is set (and core scheduling is enabled) these

[RFC PATCH v2 10/17] sched: Core-wide rq->lock

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) Introduce the basic infrastructure to have a core wide rq->lock. Signed-off-by: Peter Zijlstra (Intel) --- kernel/Kconfig.preempt | 7 +++- kernel/sched/core.c| 91 ++ kernel/sched/sched.h | 31 ++ 3 files

[RFC PATCH v2 16/17] sched: Wake up sibling if it has something to run

2019-04-23 Thread Vineeth Remanan Pillai
During core scheduling, it can happen that the current rq selects a non-tagged process while the sibling might be idling even though it had something to run (because the sibling selected idle to match the tagged process in previous tag matching iteration). We need to wake up the sibling if such a

[RFC PATCH v2 06/17] sched/fair: Export newidle_balance()

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) For pick_next_task_fair() it is the newidle balance that requires dropping the rq->lock; provided we do put_prev_task() early, we can also detect the condition for doing newidle early. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 18

[RFC PATCH v2 15/17] sched: Trivial forced-newidle balancer

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) When a sibling is forced-idle to match the core-cookie; search for matching tasks to fill the core. Signed-off-by: Peter Zijlstra (Intel) --- include/linux/sched.h | 1 + kernel/sched/core.c | 131 +- kernel/sched/idle.c

[RFC PATCH v2 14/17] sched/fair: Add a few assertions

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 45d86b862750..08812fe7e1d3 100644 --- a/kernel/sched/fair.c +++

[RFC PATCH v2 17/17] sched: Debug bits...

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) Not-Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/core.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 0e3c51a1b54a..e8e5f26db052 100644 ---

[RFC PATCH v2 07/17] sched: Allow put_prev_task() to drop rq->lock

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) Currently the pick_next_task() loop is convoluted and ugly because of how it can drop the rq->lock and needs to restart the picking. For the RT/Deadline classes, it is put_prev_task() where we do balancing, and we could do this before the picking loop. Make this

[RFC PATCH v2 00/17] Core scheduling v2

2019-04-23 Thread Vineeth Remanan Pillai
Second iteration of the core-scheduling feature. This version fixes apparent bugs and performance issues in v1. This doesn't fully address the issue of core sharing between processes with different tags. Core sharing still happens 1% to 5% of the time based on the nature of workload and timing of

[PATCH] reiserfs: Add comment to explain endianness issue in xattr_hash

2019-04-23 Thread Bharath Vedartham
csum_partial() gives different results for little-endian and big-endian hosts. This causes images created on little-endian hosts and mounted on big endian hosts to see csum mismatches. This causes an endianness bug. Sparse gives a warning as csum_partial returns a restricted integer type __wsum_t

[RFC PATCH v2 03/17] sched: Wrap rq::lock access

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) In preparation of playing games with rq->lock, abstract the thing using an accessor. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Vineeth Remanan Pillai Signed-off-by: Julien Desfossez --- Changes in v2 - - Fixes a deadlock due in

[RFC PATCH v2 02/17] sched: Fix kerneldoc comment for ia64_set_curr_task

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 4778c48a7fda..416ea613eda8 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c

Re: [PATCH v2 28/36] coresight: platform: Use fwnode handle for device search

2019-04-23 Thread Mathieu Poirier
On Mon, Apr 15, 2019 at 05:04:11PM +0100, Suzuki K Poulose wrote: > We match of_node while searching for a device. Make this > more generic in preparation for the ACPI support by using > fwnode_handle. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- >

Re: [PATCH v2 29/36] coresight: Use fwnode handle instead of device names

2019-04-23 Thread Mathieu Poirier
On Mon, Apr 15, 2019 at 05:04:12PM +0100, Suzuki K Poulose wrote: > We rely on the device names to find a CoreSight device on the > coresight bus. The device name however is obtained from the platform, > which is bound to the real platform/amba device. As we are about > to use different naming

WARNING: locking bug in split_huge_page_to_list

2019-04-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:e53f31bf Merge tag '5.1-rc5-smb3-fixes' of git://git.samba.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14ecb7e320 kernel config: https://syzkaller.appspot.com/x/.config?x=856fc6d0fbbeede9

Re: mmotm 2019-04-19-14-53 uploaded (objtool)

2019-04-23 Thread Andy Lutomirski
> On Apr 23, 2019, at 1:24 AM, Peter Zijlstra wrote: > >> On Fri, Apr 19, 2019 at 09:36:46PM -0700, Randy Dunlap wrote: >>> On 4/19/19 2:53 PM, a...@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2019-04-19-14-53 has been uploaded to >>> >>>

general protection fault in fib6_purge_rt (2)

2019-04-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:c543cb4a ipv4: ensure rcu_read_lock() in ipv4_link_failure() git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=17fd659f20 kernel config: https://syzkaller.appspot.com/x/.config?x=4fb64439e07a1ec0

[PATCH v4 2/2] arm64: dts: qcom: Add Lenovo Miix 630

2019-04-23 Thread Jeffrey Hugo
This adds the initial DT for the Lenovo Miix 630 laptop. Supported functionality includes USB (host), microSD-card, keyboard, and trackpad. Signed-off-by: Jeffrey Hugo --- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/msm8998-clamshell.dtsi | 278

[PATCH v4 1/2] HID: quirks: Refactor ELAN 400 and 401 handling

2019-04-23 Thread Jeffrey Hugo
There needs to be coordination between hid-quirks and the elan_i2c driver about which devices are handled by what drivers. Currently, both use whitelists, which results in valid devices being unhandled by default, when they should not be rejected by hid-quirks. This is quickly becoming an issue.

[PATCH v4 0/2] Basic DT support for Lenovo Miix 630

2019-04-23 Thread Jeffrey Hugo
The Lenovo Miix 630 is one of three ARM based (specifically Qualcomm MSM8998) laptops that comes with Windows, and seems to have a dedicated following of folks intrested to get Linux up and running on it. This series adds support for the basic functionality this is validated towork using

Re: [PATCH v2 2/3] arm64: dts: allwinner: h6: add r_watchog node

2019-04-23 Thread Maxime Ripard
On Fri, Apr 19, 2019 at 09:00:42PM +0200, Clément Péron wrote: > Hi, > > On Thu, 11 Apr 2019 at 17:34, Clément Péron wrote: > > > > Allwinner H6 has a r_watchdog similar to A64. > > > > Declare it in the device-tree. > > > > Signed-off-by: Clément Péron > > --- > >

Re: [PATCH V2 2/2] arm64/mm: Enable memory hot remove

2019-04-23 Thread Mark Rutland
On Tue, Apr 23, 2019 at 01:01:58PM +0530, Anshuman Khandual wrote: > Generic usage for init_mm.pagetable_lock > > Unless I have missed something else these are the generic init_mm kernel page > table > modifiers at runtime (at least which uses init_mm.page_table_lock) > > 1.

Re: [PATCH] MAINTAINERS: normalize Laurent Pinchart's email address

2019-04-23 Thread Laurent Pinchart
Hi Lukas, Thank you for the patch. On Sat, Apr 13, 2019 at 11:35:22AM +0200, Lukas Bulwahn wrote: > MAINTAINERS contains lower-case and upper-case variants of > Laurent Pinchart's email address. > > Only keep the lower-case variant in MAINTAINERS. > > Signed-off-by: Lukas Bulwahn

Re: [PATCH] x86/mpx: fix recursive munmap() corruption

2019-04-23 Thread Dave Hansen
On 4/23/19 4:16 AM, Laurent Dufour wrote: > My only concern is the error path. > Calling arch_unmap() before handling any error case means that it will > have to be undo and there is no way to do so. Is there a practical scenario where munmap() of the VDSO can split a VMA? If the VDSO is

Re: [PATCH] PCI/LINK: Account for BW notification in vector calculation

2019-04-23 Thread Alex G
On 4/23/19 10:34 AM, Alex Williamson wrote: On Tue, 23 Apr 2019 09:33:53 -0500 Alex G wrote: On 4/22/19 7:33 PM, Alex Williamson wrote: On Mon, 22 Apr 2019 19:05:57 -0500 Alex G wrote: echo :07:00.0:pcie010 | sudo tee /sys/bus/pci_express/drivers/pcie_bw_notification/unbind That's

Re: [PATCH] Bluetooth: hci_h5: fix spelling mistake "sliped" -> "slipped"

2019-04-23 Thread Marcel Holtmann
Hi Colin, > There is a spelling mistake in a BT_DBG debug message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/bluetooth/hci_h5.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

[PATCH v2] ASoC: stm32: sai: simplify dai driver initialisation

2019-04-23 Thread Arnaud Pouliquen
Suppress the useless dynamic allocation of the dai driver structure. Signed-off-by: Arnaud Pouliquen --- V1 to V2: - add "sai" in commit title to identify the driver - add reviewed-by sound/soc/stm/stm32_sai_sub.c | 43 +-- 1 file changed, 9

Re: [PATCH] riscv: Support non-coherency memory model

2019-04-23 Thread Gary Guo
On 23/04/2019 16:46, Guo Ren wrote: > On Tue, Apr 23, 2019 at 07:55:48AM +0200, Christoph Hellwig wrote: >> On Tue, Apr 23, 2019 at 08:13:48AM +0800, Guo Ren wrote: We should probably start a working group for this ASAP unless we can get another working group to help taking care of it.

RE: [PATCH 1/3] remap: Add I3C bus support

2019-04-23 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Tue, Apr 23, 2019 at 16:14:16 > On Tue, 23 Apr 2019 14:58:06 + > Vitor Soares wrote: > > > Hi Mark, > > > > From: Mark Brown > > Date: Tue, Apr 16, 2019 at 16:39:48 > > > > > On Mon, Apr 15, 2019 at 09:19:39PM +0200, Vitor Soares wrote: > > > >

Re: [PATCH 1/7] thermal/drivers/core: Remove the module Kconfig's option

2019-04-23 Thread Eduardo Valentin
Hello, On Tue, Apr 02, 2019 at 06:12:44PM +0200, Daniel Lezcano wrote: > The module support for the thermal subsystem makes little sense: > - some subsystems relying on it are not modules, thus forcing the >framework to be compiled in > - it is compiled in for almost every configs, the

Re: [PATCH] PCI/LINK: Account for BW notification in vector calculation

2019-04-23 Thread Lukas Wunner
On Tue, Apr 23, 2019 at 09:34:08AM -0600, Alex Williamson wrote: > On Tue, 23 Apr 2019 09:33:53 -0500 Alex G wrote: > > 0.5W savings on a 100+W GPU? I agree it's meaningless. > > Evidence? Regardless, I don't have control of the driver that's making > these changes, but the claim seems

Re: [kvmtool PATCH v10 5/5] KVM: arm/arm64: Add a vcpu feature for pointer authentication

2019-04-23 Thread Dave Martin
On Tue, Apr 23, 2019 at 10:12:38AM +0530, Amit Daniel Kachhap wrote: > This patch adds a runtime capabality for KVM tool to enable Arm64 8.3 > Pointer Authentication in guest kernel. Two vcpu features > KVM_ARM_VCPU_PTRAUTH_[ADDRESS/GENERIC] are supplied together to enable > Pointer Authentication

Re: [PATCH] riscv: Support non-coherency memory model

2019-04-23 Thread Guo Ren
On Tue, Apr 23, 2019 at 07:55:48AM +0200, Christoph Hellwig wrote: > On Tue, Apr 23, 2019 at 08:13:48AM +0800, Guo Ren wrote: > > > We should probably start a working group for this ASAP unless we can > > > get another working group to help taking care of it. > > Good news, I prefer to use

[PATCH 2/2] HID: input: fix assignment of .value

2019-04-23 Thread Benjamin Tissoires
The value field is actually an array of .maxfield. We should assign the correct number to the correct usage. Not that we never encounter a device that requires this ATM, but better have the proper code path. Fixes: 2dc702c991e377 ("HID: input: use the Resolution Multiplier for

<    1   2   3   4   5   6   7   8   9   >