Re: [PATCH v2] consolemap: Fix a memory leaking bug in drivers/tty/vt/consolemap.c

2019-05-25 Thread Kees Cook
On Fri, May 24, 2019 at 10:37:59AM +0100, Jon Hunter wrote: > Kees, > > On 23/05/2019 17:54, Kees Cook wrote: > > On Thu, May 23, 2019 at 08:34:52AM +0800, Gen Zhang wrote: > >> In function con_insert_unipair(), when allocation for p2 and p1[n] > >> fails, ENOMEM is returned, but previously

Re: [PATCH][next] ASoC: cx2072x: remove redundant assignment to pulse_len

2019-05-25 Thread Takashi Iwai
On Fri, 24 May 2019 23:44:19 +0200, Colin King wrote: > > From: Colin Ian King > > Variable pulse_len is being initialized to 1 however this value is > never read and pulse_len is being re-assigned later in a switch > statement. Clean up the code by removing the redundant initialization. > >

Re: [PATCH][next] ASoC: cx2072x: fix integer overflow on unsigned int multiply

2019-05-25 Thread Takashi Iwai
On Sat, 25 May 2019 00:25:51 +0200, Colin King wrote: > > From: Colin Ian King > > In the case where frac_div larger than 96 the result of an unsigned > multiplication overflows an unsigned int. For example, this can > happen when the sample_rate is 192000 and pll_input is 122. Fix > this by

Re: [PATCH net] staging: Remove set but not used variable ‘status’

2019-05-25 Thread maowenan
On 2019/5/25 13:01, Greg KH wrote: > On Sat, May 25, 2019 at 12:26:42PM +0800, Mao Wenan wrote: >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/staging/kpc2000/kpc_spi/spi_driver.c: In function >> ‘kp_spi_transfer_one_message’: >>

Re: [PATCH v7 5/5] namei: resolveat(2) syscall

2019-05-25 Thread Aleksa Sarai
On 2019-05-24, Linus Torvalds wrote: > On Tue, May 7, 2019 at 9:44 AM Aleksa Sarai wrote: > > > > The most obvious syscall to add support for the new LOOKUP_* scoping > > flags would be openat(2) (along with the required execveat(2) change > > included in this series). However, there are a few

[PATCH] mm/mempolicy: Fix an incorrect rebind node in mpol_rebind_nodemask

2019-05-25 Thread zhong jiang
We bind an different node to different vma, Unluckily, it will bind different vma to same node by checking the /proc/pid/numa_maps. Commit 213980c0f23b ("mm, mempolicy: simplify rebinding mempolicies when updating cpusets") has introduced the issue. when we change memory policy by seting

[PATCH -next v2] staging: kpc2000: Remove set but not used variable ‘status’

2019-05-25 Thread Mao Wenan
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/kpc2000/kpc_spi/spi_driver.c: In function ‘kp_spi_transfer_one_message’: drivers/staging/kpc2000/kpc_spi/spi_driver.c:282:9: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] int status = 0; ^~

[PATCH] drivers/dca: fix warning PTR_ERR_OR_ZERO can be used

2019-05-25 Thread Hariprasad Kelam
fix below warning reported by coccicheck ./drivers/dca/dca-sysfs.c:43:1-3: WARNING: PTR_ERR_OR_ZERO can be used Signed-off-by: Hariprasad Kelam --- drivers/dca/dca-sysfs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/dca/dca-sysfs.c b/drivers/dca/dca-sysfs.c

[RFC PATCH 0/6] x86/mm: Flush remote and local TLBs concurrently

2019-05-25 Thread Nadav Amit
Currently, local and remote TLB flushes are not performed concurrently, which introduces unnecessary overhead - each INVLPG can take 100s of cycles. This patch-set allows TLB flushes to be run concurrently: first request the remote CPUs to initiate the flush, then run it locally, and finally wait

[RFC PATCH 5/6] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-05-25 Thread Nadav Amit
To improve TLB shootdown performance, flush the remote and local TLBs concurrently. Introduce flush_tlb_multi() that does so. The current flush_tlb_others() interface is kept, since paravirtual interfaces need to be adapted first before it can be removed. This is left for future work. In such PV

[RFC PATCH 1/6] smp: Remove smp_call_function() and on_each_cpu() return values

2019-05-25 Thread Nadav Amit
The return value is fixed. Remove it and amend the callers. Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner Cc: Tony Luck Cc: Fenghua Yu Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Andrew Morton Signed-off-by: Nadav Amit --- arch/alpha/kernel/smp.c | 19

[RFC PATCH 6/6] x86/mm/tlb: Optimize local TLB flushes

2019-05-25 Thread Nadav Amit
While the updated smp infrastructure is capable of running a function on a single local core, it is not optimized for this case. The multiple function calls and the indirect branch introduce some overhead, making local TLB flushes slower than they were before the recent changes. Before calling

[RFC PATCH 3/6] smp: Run functions concurrently in smp_call_function_many()

2019-05-25 Thread Nadav Amit
Currently, on_each_cpu() and similar functions do not exploit the potential of concurrency: the function is first executed remotely and only then it is executed locally. Functions such as TLB flush can take considerable time, so this provides an opportunity for performance optimization. To do so,

[RFC PATCH 4/6] x86/mm/tlb: Refactor common code into flush_tlb_on_cpus()

2019-05-25 Thread Nadav Amit
arch_tlbbatch_flush() and flush_tlb_mm_range() have very similar code, which is effectively the same. Extract the mutual code into a new function flush_tlb_on_cpus(). There is one functional change, which should not affect correctness: flush_tlb_mm_range compared loaded_mm and the mm to figure

[RFC PATCH 2/6] cpumask: Purify cpumask_next()

2019-05-25 Thread Nadav Amit
cpumask_next() has no side-effects. Mark it as pure. Cc: "David S. Miller" Signed-off-by: Nadav Amit --- include/linux/cpumask.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h index 147bdec42215..20df46705f9c 100644 ---

Re: [RFC PATCH 2/6] cpumask: Purify cpumask_next()

2019-05-25 Thread Ingo Molnar
* Nadav Amit wrote: > cpumask_next() has no side-effects. Mark it as pure. > > Cc: "David S. Miller" > Signed-off-by: Nadav Amit > --- > include/linux/cpumask.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h >

Re: [RFC PATCH 5/6] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-05-25 Thread Nadav Amit
> On May 25, 2019, at 1:22 AM, Nadav Amit wrote: > > To improve TLB shootdown performance, flush the remote and local TLBs > concurrently. Introduce flush_tlb_multi() that does so. The current > flush_tlb_others() interface is kept, since paravirtual interfaces need > to be adapted first before

Re: [PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000

2019-05-25 Thread Simon Sandström
On Sat, May 25, 2019 at 07:00:17AM +0200, Greg KH wrote: > On Fri, May 24, 2019 at 10:30:58PM +0200, Simon Sandström wrote: > > Fixes build errors: > > > > ERROR: "mfd_remove_devices" [kpc2000.ko] undefined! > > ERROR: "uio_unregister_device" [kpc2000.ko] undefined! > > ERROR: "mfd_add_devices"

Re: [PATCH] mm/gup: continue VM_FAULT_RETRY processing event for pre-faults

2019-05-25 Thread Sebastian Andrzej Siewior
On 2019-05-24 15:22:51 [-0700], Hugh Dickins wrote: > I've now run a couple of hours of load successfully with Mike's patch > to GUP, no problem; but whatever the merits of that patch in general, > I agree with Andrew that fault_in_pages_writeable() seems altogether > more appropriate for

[PATCH 4/4 v2] w1: ds2805: rename w1_family struct, fixing c-p typo

2019-05-25 Thread Mariusz Bialonczyk
The ds2805 has a structure named: w1_family_2d, which surely comes from a w1_ds2431 module. This commit fixes this name to prevent confusion and mark a correct family name. Signed-off-by: Mariusz Bialonczyk --- Changes in v2: Added a missing commit msg. drivers/w1/slaves/w1_ds2805.c | 6

Re: [PATCH 1/2] perf/x86: Disable non generic regs for software/probe events

2019-05-25 Thread Ingo Molnar
* kan.li...@linux.intel.com wrote: > @@ -57,6 +57,11 @@ static unsigned int pt_regs_offset[PERF_REG_X86_MAX] = { > #endif > }; > > +u64 non_generic_regs_mask(void) > +{ > + return (~((1ULL << PERF_REG_X86_XMM0) - 1)); > +} > + > u64 perf_reg_value(struct pt_regs *regs, int idx) > { >

Re: [PATCH 2/2] perf/x86/regs: Check reserved bits

2019-05-25 Thread Ingo Molnar
* kan.li...@linux.intel.com wrote: > From: Kan Liang > > The perf fuzzer triggers a warning which map to: > > if (WARN_ON_ONCE(idx >= ARRAY_SIZE(pt_regs_offset))) > return 0; > > The bits between XMM registers and generic registers are reserved. > But

Re: [PATCH 4/4] w1: ds2805: rename w1_family struct, fixing c-p typo

2019-05-25 Thread Mariusz Bialonczyk
On Fri, 24 May 2019 20:21:09 +0200 Greg KH wrote: > On Mon, May 20, 2019 at 09:05:58AM +0200, Mariusz Bialonczyk wrote: > > Signed-off-by: Mariusz Bialonczyk > > --- > > drivers/w1/slaves/w1_ds2805.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > I can not take patches

Re: [RFC PATCH 5/6] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-05-25 Thread Juergen Gross
On 25/05/2019 10:22, Nadav Amit wrote: > To improve TLB shootdown performance, flush the remote and local TLBs > concurrently. Introduce flush_tlb_multi() that does so. The current > flush_tlb_others() interface is kept, since paravirtual interfaces need > to be adapted first before it can be

[PATCH] drivers/pci/controller: fix warning PTR_ERR_OR_ZERO can be used

2019-05-25 Thread Hariprasad Kelam
fix below warnings reported by coccichek /drivers/pci/controller/pci-tegra.c:1132:1-3: WARNING: PTR_ERR_OR_ZERO can be used ./drivers/pci/controller/dwc/pcie-qcom.c:703:1-3: WARNING: PTR_ERR_OR_ZERO can be used ./drivers/pci/controller/dwc/pci-meson.c:185:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Re: C3600, sata controller

2019-05-25 Thread Carlo Pisani
guys? yah, SYBA-SY-PCX40009 does wrk :D :D 02:03.0 RAID bus controller: Silicon Image, Inc. SiI 3124 PCI-X Serial ATA Controller (rev 01) 10 hours burn-in test passed while [ 1 ] do for item in `ls *.bin` do rm -f $copy.out echo -n "$item ... "

Re: [PATCH] kernel: sysctl: change ipfrag_high/low_thresh to CTL_ULONG

2019-05-25 Thread Kefeng Wang
On 2019/5/24 23:00, Eric Dumazet wrote: > On Fri, May 24, 2019 at 7:30 AM Kefeng Wang > wrote: >> 3e67f106f619 ("inet: frags: break the 2GB limit for frags storage"), >> changes ipfrag_high/low_thread 'type' from int to long, using CTL_ULONG >> instead of CTL_INT to keep consistent. > > What

[PATCH] libbpf: fix warning PTR_ERR_OR_ZERO can be used

2019-05-25 Thread Hariprasad Kelam
fix below warning reported by coccicheck /tools/lib/bpf/libbpf.c:3461:1-3: WARNING: PTR_ERR_OR_ZERO can be used Signed-off-by: Hariprasad Kelam --- tools/lib/bpf/libbpf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c

mainline/master boot bisection: v5.2-rc1-233-g0a72ef899014 on meson-g12a-x96-max

2019-05-25 Thread kernelci.org bot
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the

Re: Revert "leds: avoid races with workqueue"?

2019-05-25 Thread Pavel Machek
Hi! > I'm having to revert 0db37915d912 ("leds: avoid races with workqueue") > from my 5.2-rc testing tree, because lockdep and other debug options > don't like it: net/mac80211/led.c arranges for led_blink_setup() to be > called at softirq time, and flush_work() is not good for calling > then.

[PATCH] ceph: fix warning PTR_ERR_OR_ZERO can be used

2019-05-25 Thread Hariprasad Kelam
change1: fix below warning reported by coccicheck /fs/ceph/export.c:371:33-39: WARNING: PTR_ERR_OR_ZERO can be used change2: typecasted PTR_ERR_OR_ZERO to long as dout expecting long Signed-off-by: Hariprasad Kelam --- fs/ceph/export.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000

2019-05-25 Thread Simon Sandström
On Sat, May 25, 2019 at 10:39:18AM +0200, Simon Sandström wrote: > On Sat, May 25, 2019 at 07:00:17AM +0200, Greg KH wrote: > > > > This is already in linux-next (in a different form), are you sure you > > are working against the latest kernel tree? > > > > thanks, > > > > greg k-h > > It's

Re: [PATCH v4 1/3] amr64: map FDT as RW for early_init_dt_scan()

2019-05-25 Thread Mike Rapoport
On Thu, May 23, 2019 at 05:04:18PM -0700, Stephen Boyd wrote: > Quoting Hsin-Yi Wang (2019-05-19 09:04:44) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > > index a170c6369a68..29648e86f7e5 100644 > > --- a/arch/arm64/mm/mmu.c > > +++ b/arch/arm64/mm/mmu.c > > @@ -940,12 +940,12 @@

Re: Revert "leds: avoid races with workqueue"?

2019-05-25 Thread Pavel Machek
Hi! > I'm having to revert 0db37915d912 ("leds: avoid races with workqueue") > from my 5.2-rc testing tree, because lockdep and other debug options > don't like it: net/mac80211/led.c arranges for led_blink_setup() to be > called at softirq time, and flush_work() is not good for calling > then.

[PATCH] drivers/scsi: fix warning PTR_ERR_OR_ZERO can be used

2019-05-25 Thread Hariprasad Kelam
fix below warnig reported by coccicheck /drivers/scsi/ufs/ufs-hisi.c:459:1-3: WARNING: PTR_ERR_OR_ZERO can be used ./drivers/scsi/qla2xxx/tcm_qla2xxx.c:1477:1-3: WARNING: PTR_ERR_OR_ZERO can be used Signed-off-by: Hariprasad Kelam --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 +---

mainline/master boot bisection: v5.2-rc1-320-g86c2f5d65305 on meson-g12a-x96-max

2019-05-25 Thread kernelci.org bot
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the

[PATCH] spi: gpio: fix warning PTR_ERR_OR_ZERO can be used

2019-05-25 Thread Hariprasad Kelam
fix below warning reported by coccicheck ./drivers/spi/spi-gpio.c:302:1-3: WARNING: PTR_ERR_OR_ZERO can be used Signed-off-by: Hariprasad Kelam --- drivers/spi/spi-gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c

[PATCH] rtc: ds1347: fix warning PTR_ERR_OR_ZERO can be used

2019-05-25 Thread Hariprasad Kelam
fix below warning reported by coccicheck ./drivers/rtc/rtc-ds1347.c:158:1-3: WARNING: PTR_ERR_OR_ZERO can be used Signed-off-by: Hariprasad Kelam --- drivers/rtc/rtc-ds1347.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-ds1347.c

Re: [PATCH v5 1/4] media: v4l: Add definitions for the HEVC slice controls

2019-05-25 Thread Hans Verkuil
Hi Paul, This patch is missing your Signed-of-by line! Can you reply with your SoB? Regards, Hans On 5/24/19 11:36 AM, Paul Kocialkowski wrote: > This introduces the required definitions for HEVC decoding support with > stateless VPUs. The controls associated to the HEVC slice format

Re: [PATCH] clk: meson: g12a: fix hifi typo in mali parent_names

2019-05-25 Thread Martin Blumenstingl
On Fri, May 24, 2019 at 11:16 AM Alexandre Mergnat wrote: > > Replace hihi by hifi in the mali parent_names of the g12a SoC family. > > Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller") > Cc: Jerome Brunet > Signed-off-by: Alexandre Mergnat this is "obviously correct"

Re: [PATCH v5 3/4] media: pixfmt: Document the HEVC slice pixel format

2019-05-25 Thread Hans Verkuil
On 5/24/19 11:36 AM, Paul Kocialkowski wrote: > Document the current state of the HEVC slice pixel format. > The format will need to evolve in the future, which is why it is > not part of the public API. > > Signed-off-by: Paul Kocialkowski > --- > .../media/uapi/v4l/pixfmt-compressed.rst

[PATCH V4 06/12] misc: xilinx_sdfec: Add ability to configure turbo

2019-05-25 Thread Dragan Cvetic
mode Add the capability to configure and retrieve turbo mode via the ioctls XSDFEC_SET_TURBO and XSDFEC_GET_TURBO. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 61 ++

[PATCH V4 00/12] misc: xilinx sd-fec drive

2019-05-25 Thread Dragan Cvetic
This patchset is adding the full Soft Decision Forward Error Correction (SD-FEC) driver implementation, driver DT binding and driver documentation. Forward Error Correction (FEC) codes such as Low Density Parity Check (LDPC) and turbo codes provide a means to control errors in data transmissions

[PATCH V4 09/12] misc: xilinx_sdfec: Support poll file operation

2019-05-25 Thread Dragan Cvetic
Support monitoring and detecting the SD-FEC error events through IRQ and poll file operation. The SD-FEC device can detect one-error or multi-error events. An error triggers an interrupt which creates and run the ONE_SHOT IRQ thread. The ONE_SHOT IRQ thread detects type of error and pass that

[PATCH V4 12/12] MAINTAINERS: add maintainer for SD-FEC

2019-05-25 Thread Dragan Cvetic
support Add maintainer entry for Xilinx SD-FEC driver support. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- MAINTAINERS | 12 1 file changed, 12 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5cfbea4..6e558ae 100644 --- a/MAINTAINERS +++

[PATCH V4 07/12] misc: xilinx_sdfec: Add ability to configure LDPC

2019-05-25 Thread Dragan Cvetic
Add the capability to configure LDPC mode via the ioctl XSDFEC_ADD_LDPC_CODE_PARAMS. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 332 +++ include/uapi/misc/xilinx_sdfec.h | 98

[PATCH V4 01/12] dt-bindings: xilinx-sdfec: Add SDFEC binding

2019-05-25 Thread Dragan Cvetic
Add the Soft Decision Forward Error Correction (SDFEC) Engine bindings which is available for the Zynq UltraScale+ RFSoC FPGA's. Signed-off-by: Dragan Cvetic Signed-off-by: Derek Kiernan --- .../devicetree/bindings/misc/xlnx,sd-fec.txt | 58 ++ 1 file changed, 58

[PATCH V4 05/12] misc: xilinx_sdfec: Store driver config and state

2019-05-25 Thread Dragan Cvetic
Stores configuration based on parameters from the DT node and values from the SD-FEC core plus reads the default state from the SD-FEC core. To obtain values from the core register read, write capabilities have been added plus related register map details. Tested-by: Dragan Cvetic Signed-off-by:

[PATCH V4 02/12] misc: xilinx-sdfec: add core driver

2019-05-25 Thread Dragan Cvetic
Implements an platform driver that matches with xlnx, sd-fec-1.1 device tree node and registers as a character device, including: - SD-FEC driver binds to sdfec DT node. - creates and initialise an initial driver dev structure. - add the driver in Linux build and Kconfig. Tested-by: Dragan Cvetic

[PATCH V4 10/12] misc: xilinx_sdfec: Add stats & status ioctls

2019-05-25 Thread Dragan Cvetic
SD-FEC statistic data are: - count of data interface errors (isr_err_count) - count of Correctable ECC errors (cecc_count) - count of Uncorrectable ECC errors (uecc_count) Add support: 1. clear stats ioctl callback which clears collected statistic data, 2. get stats ioctl callback which reads a

[PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl

2019-05-25 Thread Dragan Cvetic
Add char device interface per DT node present and support file operations: - open(), - close(), - unlocked_ioctl(), - compat_ioctl(). Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 57

[PATCH V4 08/12] misc: xilinx_sdfec: Add ability to get/set config

2019-05-25 Thread Dragan Cvetic
- Add capability to get SD-FEC config data using ioctl XSDFEC_GET_CONFIG. - Add capability to set SD-FEC data order using ioctl SDFEC_SET_ORDER. - Add capability to set SD-FEC bypass option using ioctl XSDFEC_SET_BYPASS. - Add capability to set SD-FEC active state using ioctl XSDFEC_IS_ACTIVE.

[PATCH V4 03/12] misc: xilinx_sdfec: Add CCF support

2019-05-25 Thread Dragan Cvetic
Add the support for Linux Clock Control Framework (CCF). Registers and enables clocks with the Clock Control Framework (CCF), to prevent shared clocks from been disabled. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 185

[PATCH V4 11/12] Docs: misc: xilinx_sdfec: Add documentation

2019-05-25 Thread Dragan Cvetic
Add SD-FEC driver documentation. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- Documentation/misc-devices/index.rst| 1 + Documentation/misc-devices/xilinx_sdfec.rst | 291 2 files changed, 292 insertions(+) create mode 100644

Re: [PATCH] rtc: ds1347: fix warning PTR_ERR_OR_ZERO can be used

2019-05-25 Thread Alexandre Belloni
Hi, On 25/05/2019 15:23:22+0530, Hariprasad Kelam wrote: > fix below warning reported by coccicheck > > ./drivers/rtc/rtc-ds1347.c:158:1-3: WARNING: PTR_ERR_OR_ZERO can be used > Could you elaborate on what is the exact improvement? > Signed-off-by: Hariprasad Kelam > --- >

Re: [PATCH v5 1/4] media: v4l: Add definitions for the HEVC slice controls

2019-05-25 Thread Hans Verkuil
Hi Paul, Besides the missing SoB I have two more comments: On 5/24/19 11:36 AM, Paul Kocialkowski wrote: > This introduces the required definitions for HEVC decoding support with > stateless VPUs. The controls associated to the HEVC slice format provide > the required meta-data for decoding

[PATCH] kconfig: tests: fix recursive inclusion unit test

2019-05-25 Thread Masahiro Yamada
Adding SPDX license identifier is pretty safe; however, here is one exception. Since commit ec8f24b7faaf ("treewide: Add SPDX license identifier - Makefile/Kconfig"), "make testconfig" would not pass. When Kconfig detects a circular file inclusion, it displays error messages with a file name and

Re: 8d2bd61bd8 ("sched/core: Clean up sched_init() a bit"): BUG: unable to handle page fault for address: 00ba0396

2019-05-25 Thread Ingo Molnar
* kernel test robot wrote: > Greetings, > > 0day kernel testing robot got the below dmesg and the first bad commit is > > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core > > commit 8d2bd61bd89260d5da5eaef7cf264587f19a7e0d > Author: Qian Cai > AuthorDate: Wed May

[PATCH] usb: dwc3: qcom: Use of_clk_get_parent_count()

2019-05-25 Thread Kefeng Wang
Use of_clk_get_parent_count() instead of open coding. Signed-off-by: Kefeng Wang --- drivers/usb/dwc3/dwc3-qcom.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index 184df4daa590..821f5179d7b6 100644 ---

[PATCH] pwm: rockchip: Use of_clk_get_parent_count()

2019-05-25 Thread Kefeng Wang
Use of_clk_get_parent_count() instead of open coding. Signed-off-by: Kefeng Wang --- drivers/pwm/pwm-rockchip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c index 4d99d468df09..a0fbb9a139bd 100644 ---

[tip:efi/urgent] efi/x86/Add missing error handling to old_memmap 1:1 mapping code

2019-05-25 Thread tip-bot for Gen Zhang
Commit-ID: 4e78921ba4dd0aca1cc89168f45039add4183f8e Gitweb: https://git.kernel.org/tip/4e78921ba4dd0aca1cc89168f45039add4183f8e Author: Gen Zhang AuthorDate: Sat, 25 May 2019 13:25:58 +0200 Committer: Ingo Molnar CommitDate: Sat, 25 May 2019 13:48:17 +0200 efi/x86/Add missing error

[tip:efi/urgent] efi: Allow the number of EFI configuration tables entries to be zero

2019-05-25 Thread tip-bot for Rob Bradford
Commit-ID: 88447c5b93d98be847f428c39ba589779a59eb83 Gitweb: https://git.kernel.org/tip/88447c5b93d98be847f428c39ba589779a59eb83 Author: Rob Bradford AuthorDate: Sat, 25 May 2019 13:25:59 +0200 Committer: Ingo Molnar CommitDate: Sat, 25 May 2019 13:48:17 +0200 efi: Allow the number of

[PATCH] drivers: base: power: Use of_clk_get_parent_count()

2019-05-25 Thread Kefeng Wang
Use of_clk_get_parent_count() instead of open coding. Signed-off-by: Kefeng Wang --- drivers/base/power/clock_ops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c index 59d19dd64928..9c7e83267eac 100644 ---

Re: [PATCH] ceph: fix warning PTR_ERR_OR_ZERO can be used

2019-05-25 Thread Yan, Zheng
On 5/25/19 5:15 PM, Hariprasad Kelam wrote: change1: fix below warning reported by coccicheck /fs/ceph/export.c:371:33-39: WARNING: PTR_ERR_OR_ZERO can be used change2: typecasted PTR_ERR_OR_ZERO to long as dout expecting long Signed-off-by: Hariprasad Kelam --- fs/ceph/export.c | 2 +-

Re: [PATCH 4.19 108/114] Revert "Dont jump to compute_result state from check_result state"

2019-05-25 Thread Pavel Machek
On Thu 2019-05-23 21:06:47, Greg Kroah-Hartman wrote: > From: Song Liu > > commit a25d8c327bb41742dbd59f8c545f59f3b9c39983 upstream. > > This reverts commit 4f4fd7c5798bbdd5a03a60f6269cf1177fbd11ef. > > Cc: Dan Williams > Cc: Nigel Croxon > Cc: Xiao Ni > Signed-off-by: Song Liu >

Re: [PATCH 4.19 008/114] nfp: flower: add rcu locks when accessing netdev for tunnels

2019-05-25 Thread Pavel Machek
Hi! > From: Pieter Jansen van Vuuren > > [ Upstream commit cb07d915bf278a7a3938b983bbcb4921366b5eff ] > > Add rcu locks when accessing netdev when processing route request > and tunnel keep alive messages received from hardware. > /* Get the neighbour entry for the lookup */ > n =

Re: [PATCH v4] driver core: Fix use-after-free and double free on glue directory

2019-05-25 Thread Muchun Song
Hi greg k-h, Greg KH 于2019年5月25日周六 上午3:04写道: > > On Thu, May 16, 2019 at 10:23:42PM +0800, Muchun Song wrote: > > There is a race condition between removing glue directory and adding a new > > device under the glue directory. It can be reproduced in following test: > > > > Is this related to: >

[PATCH -next] MIPS: uprobes: remove set but not used variable 'epc'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: arch/mips/kernel/uprobes.c: In function 'arch_uprobe_pre_xol': arch/mips/kernel/uprobes.c:115:17: warning: variable 'epc' set but not used [-Wunused-but-set-variable] It's never used since introduction in commit 40e084a506eb ("MIPS: Add uprobes

[PATCH -next] ASoC: cx2072x: remove set but not used variable 'is_right_j '

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: sound/soc/codecs/cx2072x.c: In function cx2072x_config_i2spcm: sound/soc/codecs/cx2072x.c:679:6: warning: variable is_right_j set but not used [-Wunused-but-set-variable] It's never used and can be removed. Signed-off-by: YueHaibing ---

[PATCH -next] scsi: megaraid_sas: remove set but not used variable 'sge_sz'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/megaraid/megaraid_sas_base.c: In function megasas_create_frame_pool: drivers/scsi/megaraid/megaraid_sas_base.c:4124:6: warning: variable sge_sz set but not used [-Wunused-but-set-variable] It's not used any more since commit

[PATCH -next] scsi: megaraid_sas: remove set but not used variable 'cur_state'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/megaraid/megaraid_sas_base.c: In function megasas_transition_to_ready: drivers/scsi/megaraid/megaraid_sas_base.c:3900:6: warning: variable cur_state set but not used [-Wunused-but-set-variable] It's not used any more since commit

[PATCH -next] scsi: megaraid_sas: remove set but not used variables 'buff_addr' and 'ci_h'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warnings: drivers/scsi/megaraid/megaraid_sas_base.c: In function megasas_fw_crash_buffer_show: drivers/scsi/megaraid/megaraid_sas_base.c:3138:16: warning: variable buff_addr set but not used [-Wunused-but-set-variable]

[PATCH -next] scsi: megaraid_sas: remove set but not used variables 'host' and 'wait_time'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warnings: drivers/scsi/megaraid/megaraid_sas_base.c: In function megasas_suspend: drivers/scsi/megaraid/megaraid_sas_base.c:7269:20: warning: variable host set but not used [-Wunused-but-set-variable] drivers/scsi/megaraid/megaraid_sas_base.c: In function

[PATCH net-next] cxgb4: Make t4_get_tp_e2c_map static

2019-05-25 Thread YueHaibing
Fix sparse warning: drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:6216:14: warning: symbol 't4_get_tp_e2c_map' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v5 1/4] media: v4l: Add definitions for the HEVC slice controls

2019-05-25 Thread Paul Kocialkowski
Hi Hans, On Sat, 2019-05-25 at 13:08 +0200, Hans Verkuil wrote: > Hi Paul, > > This patch is missing your Signed-of-by line! Can you reply with your SoB? Ouch, sorry about that. This is definitely: Signed-off-by: Paul Kocialkowski Cheers, Paul > Regards, > > Hans > > On 5/24/19

Re: [PATCH v5 2/4] media: pixfmt: Add HEVC slice pixel format

2019-05-25 Thread Jernej Škrabec
Hi! Dne petek, 24. maj 2019 ob 11:36:33 CEST je Paul Kocialkowski napisal(a): > Introduce the V4L2_PIX_FMT_HEVC_SLICE pixel format, which currently > describes an output buffer with enough appended slice data for > producing one decoded frame with a stateless video decoder. > > This will need to

[PATCH -next] binfmt_flat: remove set but not used variable 'inode'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: fs/binfmt_flat.c: In function load_flat_file: fs/binfmt_flat.c:419:16: warning: variable inode set but not used [-Wunused-but-set-variable] It's never used and can be removed. Signed-off-by: YueHaibing --- fs/binfmt_flat.c | 2 -- 1 file

[PATCH -next] IB/hfi1: remove set but not used variables 'offset' and 'fspsn'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/infiniband/hw/hfi1/tid_rdma.c: In function tid_rdma_rcv_error: drivers/infiniband/hw/hfi1/tid_rdma.c:2029:7: warning: variable offset set but not used [-Wunused-but-set-variable] drivers/infiniband/hw/hfi1/tid_rdma.c: In function

Re: [PATCH net] staging: Remove set but not used variable ‘status’

2019-05-25 Thread Sven Van Asbroeck
On Sat, May 25, 2019 at 12:20 AM Mao Wenan wrote: > > The variable 'status' is not used any more, remve it. > /* do the transfers for this message */ > list_for_each_entry(transfer, >transfers, transfer_list) { > if (transfer->tx_buf == NULL && transfer->rx_buf == NULL && >

Re: [PATCH 2/2] staging: gdm724x: Remove variable

2019-05-25 Thread Sven Van Asbroeck
On Fri, May 24, 2019 at 2:04 AM Nishka Dasgupta wrote: > > The return variable is used only twice (in two different branches), and > both times it is assigned the same constant value. These can therefore > be merged into the same assignment, placed at the point that both > these branches (and no

[PATCH 1/6] MIPS: use the generic get_user_pages_fast code

2019-05-25 Thread Christoph Hellwig
The mips code is mostly equivalent to the generic one, minus various bugfixes and one and a half arch overrides that this patch adds to pgtable.h. Note that this defines ARCH_HAS_PTE_SPECIAL for mips as mips has pte_special and pte_mkspecial implemented and used in the existing gup code. They

[PATCH 5/6] sparc64: use the generic get_user_pages_fast code

2019-05-25 Thread Christoph Hellwig
The sparc64 code is mostly equivalent to the generic one, minus various bugfixes and two arch overrides that this patch adds to pgtable.h. Signed-off-by: Christoph Hellwig --- arch/sparc/Kconfig | 1 + arch/sparc/include/asm/pgtable_64.h | 40 arch/sparc/mm/Makefile

[PATCH 6/6] mm: don't allow non-generic get_user_pages_fast implementations

2019-05-25 Thread Christoph Hellwig
Add an explicit ifdef instead of the weak functions for the stubs so that we can't let new get_user_pages_fast implementation slip in. Signed-off-by: Christoph Hellwig --- mm/util.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/mm/util.c b/mm/util.c index

[PATCH 3/6] sh: use the generic get_user_pages_fast code

2019-05-25 Thread Christoph Hellwig
The sh code is mostly equivalent to the generic one, minus various bugfixes and two arch overrides that this patch adds to pgtable.h. Signed-off-by: Christoph Hellwig --- arch/sh/Kconfig | 1 + arch/sh/include/asm/pgtable.h | 85 +++ arch/sh/mm/Makefile | 2

[PATCH 4/6] mm: add a gup_fixup_start_addr hook

2019-05-25 Thread Christoph Hellwig
This will allow sparc64 to override its ADI tags for get_user_pages and get_user_pages_fast. I have no idea why this is not required for plain old get_user_pages, but it keeps the existing sparc64 behavior. Signed-off-by: Christoph Hellwig --- mm/gup.c | 8 ++-- 1 file changed, 6

[PATCH 2/6] sh: add a missing pud_page definition

2019-05-25 Thread Christoph Hellwig
sh oddly enough had pud_page_vaddr, but not pud_page. Signed-off-by: Christoph Hellwig --- arch/sh/include/asm/pgtable-3level.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sh/include/asm/pgtable-3level.h b/arch/sh/include/asm/pgtable-3level.h index 7d8587eb65ff..8ff6fb6b4d19

RFC: switch the remaining architectures to use generic GUP

2019-05-25 Thread Christoph Hellwig
Hi Linus and maintainers, below is a series to switch mips, sh and sparc64 to use the generic GUP code so that we only have one codebase to touch for further improvements to this code. I don't have hardware for any of these architectures, and generally no clue about their page table management,

[PATCH -next] sample/mdev/mbochs: remove set but not used variable 'mdev_state'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: samples/vfio-mdev/mbochs.c: In function mbochs_ioctl: samples/vfio-mdev/mbochs.c:1188:21: warning: variable mdev_state set but not used [-Wunused-but-set-variable] It's not used any more since commit 104c7405a64d ("vfio: add edid support to mbochs

[PATCH -next] agp: remove some set but not used variables

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warnings: drivers/char/agp/frontend.c: In function agp_find_seg_in_client: drivers/char/agp/frontend.c:105:6: warning: variable num_segments set but not used [-Wunused-but-set-variable] drivers/char/agp/isoch.c: In function agp_3_5_isochronous_node_enable:

[PATCH -next] ufs: remove set but not used variable 'usb3'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: fs/ufs/super.c: In function ufs_statfs: fs/ufs/super.c:1409:32: warning: variable usb3 set but not used [-Wunused-but-set-variable] It is not used since commmit c596961d1b4c ("ufs: fix s_size/s_dsize users") Signed-off-by: YueHaibing ---

[PATCH -next] HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices

2019-05-25 Thread YueHaibing
We should return 'retval' as the correct return value instead of always zero. Fixes: 74808f9115ce ("HID: logitech-dj: add support for non unifying receivers") Signed-off-by: YueHaibing --- drivers/hid/hid-logitech-dj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH -next] Input: synaptics-rmi4 - Remove set but not used variable 'sensor_flags'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/input/rmi4/rmi_f12.c: In function rmi_f12_read_sensor_tuning: drivers/input/rmi4/rmi_f12.c:76:6: warning: variable sensor_flags set but not used [-Wunused-but-set-variable] It's not used since introduction in commit b43d2c1e9353 ("Input:

Re: [RFC v2 1/2] clocksource: davinci-timer: add support for clockevents

2019-05-25 Thread Daniel Lezcano
On 24/05/2019 13:53, Bartosz Golaszewski wrote: > pt., 24 maj 2019 o 10:59 Daniel Lezcano > napisał(a): >> >> On 24/05/2019 09:28, Bartosz Golaszewski wrote: >>> czw., 23 maj 2019 o 18:38 Daniel Lezcano >>> napisał(a): On 23/05/2019 14:58, Bartosz Golaszewski wrote: > From:

[PATCH -next] leds: max77650: Remove set but not used variable 'parent'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/leds/leds-max77650.c: In function max77650_led_probe: drivers/leds/leds-max77650.c:67:17: warning: variable parent set but not used [-Wunused-but-set-variable] It is never used and can be removed. Signed-off-by: YueHaibing ---

[PATCH -next] xen/pvcalls: Remove set but not used variable

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/xen/pvcalls-front.c: In function pvcalls_front_sendmsg: drivers/xen/pvcalls-front.c:543:25: warning: variable bedata set but not used [-Wunused-but-set-variable] drivers/xen/pvcalls-front.c: In function pvcalls_front_recvmsg:

[PATCH -next] clk: mmp: frac: Remove set but not used variable 'prev_rate'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/clk/mmp/clk-frac.c: In function clk_factor_set_rate: drivers/clk/mmp/clk-frac.c:81:16: warning: variable prev_rate set but not used [-Wunused-but-set-variable] It's never used and can be removed. Signed-off-by: YueHaibing ---

GOOD NEWS

2019-05-25 Thread Karbiru Ahmed
Dear Friend, I'm happy to inform you about my success in getting the fund transferred under the cooperation of a new partner from London. Presently I'm in London for investment projects with my own share of the total sum. Meanwhile, I didn't forget your past efforts and attempts to assist me in

[PATCH -next] Input: tca8418 - Remove set but not used variable ''

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/input/keyboard/tca8418_keypad.c: In function tca8418_keypad_probe: drivers/input/keyboard/tca8418_keypad.c:269:24: warning: variable max_keys set but not used [-Wunused-but-set-variable] It's not used since commit 16ff7cb1848a ("Input:

[PATCH -next] staging: rtl8723bs: hal: Remove set but not used variable 'no_res' and 'phal'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c: In function xmit_xmitframes: drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c:205:5: warning: variable no_res set but not used [-Wunused-but-set-variable] drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c:

[PATCH -next] USB: ohci-spear: Remove set but not used variable 'ohci'

2019-05-25 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/host/ohci-spear.c: In function spear_ohci_hcd_drv_probe: drivers/usb/host/ohci-spear.c:38:19: warning: variable ohci set but not used [-Wunused-but-set-variable] It is never used since commit 1cc6ac59ffaa ("USB: OHCI: make ohci-spear a

  1   2   3   >